From nobody Wed Jun 17 04:14:31 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A23AE37CD35 for ; Tue, 28 Apr 2026 09:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777367901; cv=none; b=rdnGPATxr9JsLbjoiVR4bOZcvfZp0ZTv3t6O+oTkYXm7dnHB7vljKM8dgbfsv4p8ZjnfJIK30XmKS5BNrwGncnY+GqW/lnBSFChF9ORjdszgzZCe+qe/YRN7xgU8je1BbN1/FTGf/xFoQdXDR/YfZrBUn+yi/I67Xb+NcIyjOKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777367901; c=relaxed/simple; bh=oHlhoX2XD37ttuQs+I+7ABrsXNk0vNHMk8q0WeMaVsI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aa0CCRb+fyl1hj101EZbMBSAHprbMPb1C4NVCZtP3R/uvbHg1GJ7DV8mmjhmOlJdTioHoZMEgjQSqc9KmwPIaazuTDZGgwRsLwskjcbgqb2xL7Z1uDdSWUKzP2UuJGd3P3kcaFiDGuPbR2gqaIfifwZObzMikM7Bv+r0+e9NG8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IMqVH99v; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IMqVH99v" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43fe3e22e33so7213550f8f.0 for ; Tue, 28 Apr 2026 02:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777367898; x=1777972698; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L7DB7L+MoopCfaj05ayyoXdqOZG6gM4ZReiwvIg30wk=; b=IMqVH99v+YhQ23WsK9EXACtPjm5QQedK0RQg2qm25zuZVB7bCcHDgr4E3Y1okOmEIq 0fidKLwdpEUctupaCGIXvwPc0DJwZTrDqzZV/JKZtGQpI/u5dBinCAIu0djKw+HX2kNJ x2zHR7Kb4wsMIfVrW9WJcqZ+cMbzowASS38ukqUyW+uDmCwWPdW5nUJgbFNi1iCfOz8/ xZvMOTdlvtd2RiHC4FTw2HQq5PXa9ksGbGt/2RW83duBqqdoNr01OWd0jlaq+I33z+Sz 74FgkDIK2Am6LhkbqmCGTYGBzLhBaaz2eSJF9ZQnteATp03Gzt8JXqpR0wpruxCIrmjB RFlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777367898; x=1777972698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=L7DB7L+MoopCfaj05ayyoXdqOZG6gM4ZReiwvIg30wk=; b=LZFofVoIn740/G7p7d/rSKCr9VA/GqDjwmJJiHwqRIwfBNcpeGsz1aqgfoXReJWdKd XcDSnzxjVsdAuVYJxBEKtcusKQx79OqczWgUi8jRqXSkuDQRPqInTnX5fOGsvIelHbVS 81P8L4rBEKr0F2miPGPYT19rWPtQhVGUxDCMrCAkEX05diy38Vacny5AUnZ9BDHUnAgI 5ck7S/87gmYzrf/mAv7/5feVE0MzDXlkHmzPQHOLRzfdRjDbcbTD+NSM9zT85P0RWln8 cki+IjOB5J/WsG9z9Ngcz6KpvSgBtUECFryE7ZXgJoc940NDOrzanAj/vdPaokRaF5kR E9wQ== X-Forwarded-Encrypted: i=1; AFNElJ+3W5d93lomnpfnxaDkoMDhlu2MvSt5PfePKl321deC2y/R1pJDmVp+A1koPllhl99Iati80M4BNA52mUM=@vger.kernel.org X-Gm-Message-State: AOJu0YzKyq0r0hxIwDzraHNeo45QIkcnL7wge4vg58IF6zPgPLDO4+eX F/e8eS49tfflAZtcUB30sK6QGXahRmGRhFJp8kLoXaeb5IN46c6xLl+mfHe0EA== X-Gm-Gg: AeBDietXibOJ3Sozi8gnEa0vTPTiCWJEQBhbTILtF8ZRkOlTSXqkYogvTbbPmt7ugTF mCkfr/tFbNtGMXwEQfv1Wcr1AWx0yfZvHnu52DENUCyoXy9K2q7AEaFYLQqLfPrNPwmUk4ED4+k 5fT3DmrPJYG8NIg+e1ZhaPYTCH9EupHPise2cozG974Zr5bSEywDpkxPce000AWhUae2XfGY9Jq 9cOYMwnLY4KUg1Gy1XsiCs/9XH10jAglKrtix0lTFqL8SvFojN9cQCwwL6RI2+WlAB0OCt2KD/f +vanpE/JUyP/GKVfgepn9TbQUsCwK2BzeOgYABGX/IJ1Uie6FfRohRpdOgqmNoKUIkaKIRYbfQt cIq7BmdDyojx9SVo9gSBnya2bUbsrQTQhH+LJunHwKWB/YSJrWaRoN1+IkFaIe2mcoWrKwaRih1 WK6h5R+2I77L3Bq0g473XRU7YxiNEZCdQYUKKFVtsmmeNnhTpGFGM0LH9QWiJ0UiKok5d341a/S kdyM2/93fnN4NLxgQlKwUtGmaVpi7kEUWsKwEoEWbOYP7e76hhAbplnAeDIvUxxa73dciACFSYW fCTG/A== X-Received: by 2002:a05:6000:18a4:b0:43d:7e11:1b72 with SMTP id ffacd0b85a97d-44648f28e43mr4198132f8f.9.1777367897958; Tue, 28 Apr 2026 02:18:17 -0700 (PDT) Received: from ahossu.localdomain ([82.78.232.184]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463d02f6a1sm4902502f8f.13.2026.04.28.02.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 02:18:17 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: error27@gmail.com, luka.gejak@linux.dev, hossu.alexandru@gmail.com, stable@vger.kernel.org Subject: [PATCH v3 1/2] staging: rtl8723bs: fix OOB write in HT_caps_handler() Date: Tue, 28 Apr 2026 11:16:20 +0200 Message-ID: <20260428091621.739680-2-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260428091621.739680-1-hossu.alexandru@gmail.com> References: <20260428091621.739680-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" HT_caps_handler() iterates pIE->length bytes and writes into HT_caps.u.HT_cap[], which is a fixed 26-byte array (sizeof struct HT_caps_element). Because pIE->length is a raw u8 from an over-the-air 802.11 AssocResponse frame and is never validated, a malicious AP can set it up to 255, causing up to 229 bytes of out-of-bounds writes into adjacent fields of struct mlme_ext_info. Truncate the iteration count to the size of HT_caps.u.HT_cap using umin() so that data from a longer-than-expected IE is silently ignored rather than written out of bounds, preserving interoperability with APs that pad the element. An early return on oversized IEs was considered but rejected: it would bypass the pmlmeinfo->HT_caps_enable =3D 1 assignment that precedes the loop, silently disabling HT mode for APs that append extra bytes to the HT Capabilities IE. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Alexandru Hossu Reviewed-by: Luka Gejak --- Changes in v3: - Use umin() instead of min_t() (Dan Carpenter) - Keep truncation approach; early return would bypass HT_caps_enable =3D 1, disabling HT mode for vendor-padded IEs (Luka Gejak, AI review) - Expand commit message to document the early return tradeoff - Add changelog AI review (flagged early return as regression-inducing): https://sashiko.dev/#/patchset/2026041408-grill-mahogany-d1e3%40gregkh Greg KH v1 reply (requested truncation over early return): https://lore.kernel.org/linux-staging/2026042630-tightness-runner-2121@gr= egkh/ drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index e0d73c267786..dd34f229df12 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -936,7 +936,8 @@ void HT_caps_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) =20 pmlmeinfo->HT_caps_enable =3D 1; =20 - for (i =3D 0; i < (pIE->length); i++) { + for (i =3D 0; i < umin(pIE->length, + sizeof(pmlmeinfo->HT_caps.u.HT_cap)); i++) { if (i !=3D 2) { /* Commented by Albert 2010/07/12 */ /* Got the endian issue here. */ --=20 2.53.0 From nobody Wed Jun 17 04:14:31 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FD9237EFFD for ; Tue, 28 Apr 2026 09:18:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777367904; cv=none; b=iUhqv2ckC+ljr14hiT+fSmSnWbINBGcVRjSBGp9pL0doGrpjiS8+zgBPlxF+YuWrf3dmxaAZ6mJrrv3Xhj+2Z9FT9BVBNIpY5Vr9RxVFg8q3A1C0Br6hO4/29543lQ4AJZWyTW2wBKhQRZVjld+qgDnL0zC6nt7Sxdrip2h35ZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777367904; c=relaxed/simple; bh=+YeUIV1+wtcPKuOvB4oPRVaxMCPwWFWxjyfdg1SSC4U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OOAHCoUzeUkBTAgSd53gxzY0c6VegZJjGDsDU+UhTWttK6UAs5+aq5pfRwribCb9+V7PyCB5HycRyQbRGrmJXG8W/SjS9M7PRK7W0PtMIifyos0WsMYR7oUFUWC6Ci9e6MVlS+oChVeSdoKXUSI5WaEcncahxRhyfEnXuwRptTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HjMWd/Vb; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HjMWd/Vb" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-446fea16729so145749f8f.3 for ; Tue, 28 Apr 2026 02:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777367901; x=1777972701; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nMczc9e1ajSbK4Mrr/Qq92dYlg6aGcU3H3gAe4DnWL8=; b=HjMWd/VbVqCxlFtri/E7sdo/vK0wLB4gUg7O69/VGAxvmtgjttxYWCaSzZ4DfxyrQi +78pdelNftrv3wP2L1XJWu045RsCmyFrZUZVK8eJ9dvpWaJD5zQ2zPrwgP3lgZVvI7x1 eeN6F2TfPcYUWIJCMIp5f+JPL+L22XlPwZZY30wbjXb/AcxGgYDPSH7ft2Qxc5Z1RXRz w70im6oES46NnB0vtkBuDm+RNjY6pAZIg9Xvvv/fPzWOIkFloB96/P5Ge7jiS0/jSgl1 KTVXnYMYpByov7mEt4nA6/ciDlzaSw9lG2iz0K6e3tyygHLgyhvTOh4A3AL6/IxkCuUN FhVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777367901; x=1777972701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nMczc9e1ajSbK4Mrr/Qq92dYlg6aGcU3H3gAe4DnWL8=; b=DdBEcb1zpjxSub7tC9i+LW3IRRhB80wcTh7WVmFrqhDKMGSs1rfwNHIFfQK9RPtcTt 7TemR+Qwfgpj67Xv5OAq777wWSr2vwE7VWG7vT4B7C+8KrZo9I+lfCHo+Ihiv3axRTcb EE5/bAtCSMrf8bSE+SItu57zy3QsMwnkgdeoIrLQodREqkrwObjsKZ4DPLxBWhw4wX7F w9p95uCe+9OwHjJKCUi3k2CdnXTp2TdehO6E6lyL/7LZZ054gYEMsNMmvIRJPbx8eD/L c1GxXikRl2RXDyb7ZDCRxEZxLhUS8XQ2obRXvO9YQQoUS6GD/FnDMk16L4BgItlHYgKr gTLQ== X-Forwarded-Encrypted: i=1; AFNElJ+CN6A/ospPY2TdowJCwGn/POUHmH+pU6yYhn9wZo52LrmfP21QUj5nUWP5uJPy2/GIvaQdq8E3BAdmtIw=@vger.kernel.org X-Gm-Message-State: AOJu0YzDWIZ3w41awi1Uv2BTyTCKdUk7D8qeUmVp6PEMt2RdvSlq86EB +eO79oF6ISN1QAzux6tkoNqtUSyRcywyBH2mDsr0SxL4p+8ZGWpZ8DZ6/ZERWQ== X-Gm-Gg: AeBDiesrC3eHHGc98UxAOq/lv4SFTcprupMsgDyjqh0NyjIf7xjG5ip/r7dEuxJwkgB MXyvraGDcEaHiWEwckM49ccHmc4BB7oPHPAah27CpNabGVhrpOsZpM/EEK08GDMdZ2L0EuYHGVF N4fsPcHpAINZnDo6o5YrCc3/oFH95d5VGInzyvzMBLUOBhzhrS5QIAFPxIZMLR6iEIDV7OOV/V2 oR+WLV3NFk8ca1rilphV9sQ4D9cPcFIYT/FMTrpiT4//nPz8bP8SLDc0bs8ptN7+lfNbqV8WTXj E2N1uNGEaNXzmHoqEewEIZxAbYo/nUVgiE/mHi+g0c8jwdl5M1cft29KAmvByvFZdZa8dc/THv3 aO1jhSO+0fqYc8ORj8KGheEswCjNZ26x5W8f8SpgjZr/gG281kUs4lkFrFfjseo6dPbE1mmY3Cz wDahcQzeCmwmcEpv/p901thdZyOQnfABcvbZ4+lUbbCMYGR9zc9noEtwmWzYvzXEgsPXVzWHDFl aBoD5/fk9p8XGiS4r0WZuRv6X8LBXrSetnmfvkqnsFXV8t60QqOunHT/BN9YWrQ7FTiIsU= X-Received: by 2002:a05:6000:40cb:b0:43c:f28b:8863 with SMTP id ffacd0b85a97d-44648963530mr4196668f8f.13.1777367901404; Tue, 28 Apr 2026 02:18:21 -0700 (PDT) Received: from ahossu.localdomain ([82.78.232.184]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463d02f6a1sm4902502f8f.13.2026.04.28.02.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 02:18:21 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: error27@gmail.com, luka.gejak@linux.dev, hossu.alexandru@gmail.com, stable@vger.kernel.org Subject: [PATCH v3 2/2] staging: rtl8723bs: fix OOB read in OnAssocRsp() IE loop Date: Tue, 28 Apr 2026 11:16:21 +0200 Message-ID: <20260428091621.739680-3-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260428091621.739680-1-hossu.alexandru@gmail.com> References: <20260428091621.739680-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IE parsing loop in OnAssocRsp() advances by (pIE->length + 2) each iteration but only guards on i < pkt_len. When a malicious AP sends an AssocResponse whose last IE has only one byte remaining in the frame (the element_id byte lands at pkt_len-1), the loop reads pIE->length from pframe[pkt_len], which is one byte past the allocated receive buffer. Additionally, even when the header bytes are in bounds, pIE->length itself can extend the data window beyond pkt_len, silently passing a truncated IE to the handler functions. Add two guards at the top of the loop body: 1. Break if fewer than sizeof(*pIE) bytes remain (can't read header). 2. Break if the IE's declared data extends past pkt_len. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Alexandru Hossu Reviewed-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index c646dc2a1741..68ce422305ed 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1406,7 +1406,11 @@ unsigned int OnAssocRsp(struct adapter *padapter, un= ion recv_frame *precv_frame) /* to handle HT, WMM, rate adaptive, update MAC reg */ /* for not to handle the synchronous IO in the tasklet */ for (i =3D (6 + WLAN_HDR_A3_LEN); i < pkt_len;) { + if (i + sizeof(*pIE) > pkt_len) + break; pIE =3D (struct ndis_80211_var_ie *)(pframe + i); + if (i + sizeof(*pIE) + pIE->length > pkt_len) + break; =20 switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: --=20 2.53.0