From nobody Wed Jun 17 04:15:33 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E3E31F989 for ; Tue, 28 Apr 2026 08:02:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777363375; cv=none; b=W35BBIIVd1640BXweC9Voq/0fwqmZyaToUk5deUky/9354HnMd805A+Eh7PqTZZmq9YHJAi1u1igYhjS0VgCqTZcLadJuqqjrpM9Q/HZDtZT89w1vbYyTeJdiDAFByzsYBx+4o8JCVkQbFPQHTHduy+T4RwwvNVsB/nDQWjsfvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777363375; c=relaxed/simple; bh=JY4+az23NLVkJxSPmQ4N8VCU4QfbBXdSOtko8CBjPXg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=u6jvHXTqX+Pc4Ezk8Vs/9ivlIu0x7LI94Zati06ag3LZ5v/aYLE4cI5DJ8ZlhWa/QxeYtw4wAJCFHabi1xAgpj4F+V6tGeeZvSsrgHDV305XJyTINM7XI3f9pAHYfgMvazHaYjWNDutI5ZkP9Nh6N7mRXfXQ+shrjoBwOJ7KeGU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lfhclOQO; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lfhclOQO" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-35fb0bb27e7so7380632a91.1 for ; Tue, 28 Apr 2026 01:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777363374; x=1777968174; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wh7HcfQ2a4z6YZXbRcuBA6egqAfxDuTb+4ocYPWlJts=; b=lfhclOQOJ58Jn5ftxv0bgSqFzWI5kd7Pzf/v3SouN8ucxFnPIClL7uZnECrH9DmZCi kNBAoH4F2em7sizmKfj+ksZBOKWTo3FxV2XYXwDgHLN0KygU2hLdP4Q+q7Eon4X8+lmy 1jSTcqa1PZ61113RZsJB6+lkmyUV6/PkCcDKpAay0eCUgpduodo+wyeJ+AuWuBqRZ9G0 soEiM1lufEd6H17xK8a2mQDGk2z6jNg9Vvets28F3xveeobKpgzDtxFudDJOJbCkkIsl 7mtS7Vu9TvQB1Ic7TDaCKqh1XnkDBUS4+dRUQvtE+IDVlv/3Uhtg7LXNM4+I3QT7V3MM rELA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777363374; x=1777968174; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wh7HcfQ2a4z6YZXbRcuBA6egqAfxDuTb+4ocYPWlJts=; b=Kv+WskPwPPfkFe4Fg0kJkAKDr2zd+Zd/pA/2dA/hI/+xKqKy5yRcYXwyBBH4sWFYkB 1WtGy1gYQ7SwfSL/d0UgiMxN8kN+IfuWQy4QL5UIISgHeauYYvW3UBE6rMflm6LWOHjp Qch8I/UARDuLfXvad/lpgnw0SttpLTNCS1hjPStJolld3g4clchiwfxGOQFClIU6GhqX h6OSzStLOvzKYXaC18OAQLuk7w4kIkCawvBo2WxpmzKlwfTpJAXrSsOIafhiS3PJN985 yH/XipH3foCxuJadh1qJiawPlOxYkL6/xO3o+QfVCVbfpXFOvgqjIvYQi9X+ILWBf+4d 55rQ== X-Forwarded-Encrypted: i=1; AFNElJ9LvBrbPnrUlg9hEFik2CEC5J3/NmkGp+EphyDEnGcUiiLE7cSD4fyfk/oCAkS3SCeKHjRNQ+FghHMVLGk=@vger.kernel.org X-Gm-Message-State: AOJu0YzWUELEGFDvXKjvNp4+zNjgLAsMQ99set0c0N8ASkiT/Yn6vQxq ksRyUTTmVP+Hhrt28N26aKW8vB7ih3O9OG/TDHRHLpba+0Vy6wt4fcI= X-Gm-Gg: AeBDieurRmYpo7j4MpZ4qeTn4XjT1/YfnDPW++q1l+Mpb76u68fF4QZBsVePHOegTzq ZDBJIx0N9oPLUmgTaiLIf7qwrJ0ER3xovJ0gFQmS8sxlQJsDcMxyNdaZY1DJkSCOkx9UVheAmsO Nf5m4AUXeVicTcARRp2UMBQEru1tZu+p1FGYWrlfgu31wn/A+B2rfZJnHxT0u0QjDvqrsCHZWNJ sGCv9evZFJodNSB2JvmzWP1HTqwlVROh4CfSxtNKTDDuFfFdZc8OOVLeHGy9uD1wnDm83mCgDb2 bMuIe3MSGtrT67FggW6twh4xRbvKR55Jq61ptmYgev1Krqlnkw8pDyvCkq28XdFCRZJKAap3r7t MDzKLsD39Og3IepI92yLisC3AS/FWApNSjG5JdNB8BDG9cSOudasbfJ47BDGyCYATBoTWQXbyBx BWYuouZOulIaRbF14wacSMJotsMR6kYBMfg3HRh85CKzLPfbeO16EPQJ3Iuzwvkyu9Hdfucs5fV hionZPaUtDGj7u2IKc1pmORr7kylbhxVcisI/vV5BX33JY= X-Received: by 2002:a17:90b:1802:b0:359:15c8:e8e1 with SMTP id 98e67ed59e1d1-36492078018mr2142216a91.25.1777363373488; Tue, 28 Apr 2026 01:02:53 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36490fd57dasm1876283a91.17.2026.04.28.01.02.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 28 Apr 2026 01:02:52 -0700 (PDT) From: "=?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?=" X-Google-Original-From: =?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?= To: "James E.J. Bottomley" , "Martin K. Petersen" , Ijae Kim Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak Subject: [PATCH v2] scsi: pcmcia: sym53c500: Fix probe error cleanup Date: Tue, 28 Apr 2026 17:02:45 +0900 Message-ID: <20260428080247.96624-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Myeonghun Pak SYM53C500_config() calls SYM53C500_release() from its early failure path even though those failures can happen before a SCSI host has been allocated and stored in link->priv. SYM53C500_release() unconditionally dereferences info->host and then tears down a fully registered host, so the probe error path can dereference a NULL host instead of unwinding only the resources acquired so far. Use pcmcia_disable_device() on configuration failures and let SYM53C500_probe() free the per-device allocation when configuration fails, because the driver's remove callback is not called after a failed probe. Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functio= ns") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- Changes in v2: - Centralize SYM53C500_config() failure exits to avoid duplicate pcmcia_disable_device() cleanup. drivers/scsi/pcmcia/sym53c500_cs.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/pcmcia/sym53c500_cs.c b/drivers/scsi/pcmcia/sym53= c500_cs.c index 1530c1ad5d..88e8b20c37 100644 --- a/drivers/scsi/pcmcia/sym53c500_cs.c +++ b/drivers/scsi/pcmcia/sym53c500_cs.c @@ -711,14 +711,14 @@ SYM53C500_config(struct pcmcia_device *link) =20 ret =3D pcmcia_loop_config(link, SYM53C500_config_check, NULL); if (ret) - goto failed; + goto err_disable; =20 if (!link->irq) - goto failed; + goto err_disable; =20 ret =3D pcmcia_enable_device(link); if (ret) - goto failed; + goto err_disable; =20 /* * That's the trouble with copying liberally from another driver. @@ -763,7 +763,7 @@ SYM53C500_config(struct pcmcia_device *link) host =3D scsi_host_alloc(tpnt, sizeof(struct sym53c500_data)); if (!host) { printk("SYM53C500: Unable to register host, giving up.\n"); - goto err_release; + goto err_no_devices; } =20 data =3D (struct sym53c500_data *)host->hostdata; @@ -800,12 +800,9 @@ SYM53C500_config(struct pcmcia_device *link) err_free_scsi: scsi_host_put(host); -err_release: - release_region(port_base, 0x10); +err_no_devices: printk(KERN_INFO "sym53c500_cs: no SCSI devices found\n"); - return -ENODEV; - -failed: - SYM53C500_release(link); +err_disable: + pcmcia_disable_device(link); return -ENODEV; } /* SYM53C500_config */ =20 @@ -845,6 +845,7 @@ static int SYM53C500_probe(struct pcmcia_device *link) { struct scsi_info_t *info; + int ret; =20 dev_dbg(&link->dev, "SYM53C500_attach()\n"); =20 @@ -856,7 +857,13 @@ SYM53C500_probe(struct pcmcia_device *link) link->priv =3D info; link->config_flags |=3D CONF_ENABLE_IRQ | CONF_AUTO_SET_IO; =20 - return SYM53C500_config(link); + ret =3D SYM53C500_config(link); + if (ret) { + kfree(info); + link->priv =3D NULL; + } + + return ret; } /* SYM53C500_attach */ =20 MODULE_AUTHOR("Bob Tracy ");