From nobody Wed Jun 17 05:15:23 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26EDB8287E for ; Tue, 28 Apr 2026 02:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777344982; cv=none; b=ayOr9PqmtsgnxaDuq5Bxlm4JJSOyHX0sU42ofaBNej0jIkKodwpLXUetweRcsbhRqzskI+L8SlewZam/YWIhFZafRPoMs9Efs2mOpX6ADZlBniH9NiwT7Kft4ao578334i8IdDKDxl5FJuHhG2zrAlVBlomHYoxtTxNqPNaBojI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777344982; c=relaxed/simple; bh=qmtafg0UZ6atgVkhElKq2ugQfKz7K4QxDArFCI4e4nE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=S/Tmko/0wWOFL/03kdSvHSzK7lskT6UVZ0QBrRIW5Utikf2uI+WYvFbVCeMpOvhplBuAtSqfCBR7TymO1IHVzk7KJJogcW6yAY34XPkl6GWB4PIlxQoaYVcIOXgQKD6LlFe/9TWiq3b0PuQBw5r2MCXhVRLJPPzD3HxVGhqSosg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Nb0z0UaX; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Nb0z0UaX" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35d90833cacso6825304a91.2 for ; Mon, 27 Apr 2026 19:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777344980; x=1777949780; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BHQ2XadwvL8sO2gmMjzHrXHFd8fYwTAjs/sjK9AivAw=; b=Nb0z0UaXY1AKY5bxZugbde9TxU2rVX975fFVhxsu6qfrX46op+HlnFzssYEC31ptdI BcP7pGcFTkj7F/6w9axbfD6lSkeEVzWzuu9GyQzF4inR9ejqyB3+p3lK5PY63ubJBbq8 UaT5dn/1aBxzcVHGMFFmiNj85hfO4o4/wo0Gs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777344980; x=1777949780; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BHQ2XadwvL8sO2gmMjzHrXHFd8fYwTAjs/sjK9AivAw=; b=mFQ0TbfISkhe4W7dPWvqxdbmwpdRYXTaVf0/PimmM6Nir6cO+go2LjoV5dZF9uyLbZ 9Qgnos+qdXAbx83dXzDW9OZTVrGMeUJ+7rJdupSDZRP2h91UWEknCog8ht2SECsI/Xv0 ayqbDqQkhPDzQsVBEPCnzRVyfNqmQGcv5//fgovV7KHy8eabzgHMajl7YgsqTOZizaMr yjCN3X28xbhzvvvI3dY0WW1J8uNRYiCm9B11qXWTjJ++gbkcAULwaLpG98ILhjQfm/Qy oyd5vNC0HhCuy+Pg/2QIZMCRBBV3G1QzRpidPSirXtEEAKjBqP1mGwbtqFW25z3icLRn yXKQ== X-Forwarded-Encrypted: i=1; AFNElJ/e2gSmULZS62x6qZBLsAcRSMHa9UdqvsUyvaNy97XzXTLwOesaENSyGm+QXQkAiHigcxOiPx6T8bRD8QE=@vger.kernel.org X-Gm-Message-State: AOJu0YyiVF8d/Nu2MFr++MRB6DGz014J/qEo6FH4XmFDzyrWKhoJ/r7e X0CS8hUK9DB8zsHh8t1O4FBGIXRP/vS4qqxPVIWaR+UP1r70EwTBwq/JkHQBliTd0Q== X-Gm-Gg: AeBDiescyzvttoKDH/U+PJc10B8NfmeI62roSFiK09kMWfaZgFNeRNkGPaRv2nXLzn4 Uo5O3myPrfmDxbwxAz1BO3+Qr7/jRV8ew/8YaCWFc5DpcdzuiJhGsxrjXNIfb+KPFuYEKOeXCVK pCOg80wgyctNrsc+zU6qPULN70KvVfGkum0na+fqVhs5ZhLQpuPaPnQqpUltxb3AV2+DSOPbj/1 ZkwSsxrixWmss8jqX/4hBzhDLTGzxnSioaLOOFhYWzqmS+99NqEd+N9gHovi/3/WmqwVK1dS/8/ zgC29r76fptbzBb0ZPXWmjE8yyv8+LqcxSZwUWGnDWw5Bu4rkl5HWjbH7hBLPiU3O+cMRGBHRjD w23aaQMma5+Qgpn6nxhjYfN8a671/MwKTnLRbKLlgjy929TtHTlldaDTWNRCUUbr2NgrPzFh/c7 zIseDSeef6Ko9/vJLd+NzGYunQL/5qRRsX6H5Lsr8JY01TjQx3xSRSXhHwjxZ29amwkfah3ziWt hRUY2tjXJbffrbaTKuypKQK X-Received: by 2002:a17:90b:4f91:b0:35e:5051:fb18 with SMTP id 98e67ed59e1d1-3649206916emr1119860a91.26.1777344980513; Mon, 27 Apr 2026 19:56:20 -0700 (PDT) Received: from tigerii.tok.corp.google.com ([2a00:79e0:2031:6:b64e:793f:a44e:7279]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36490026a45sm1236408a91.3.2026.04.27.19.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 19:56:20 -0700 (PDT) From: Sergey Senozhatsky To: Jassi Brar , Matthias Brugger , AngeloGioacchino Del Regno , Allen-KH Cheng , YC Hung Cc: Tzung-Bi Shih , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Sergey Senozhatsky Subject: [PATCH] mailbox: mtk-adsp: fix UAF during device teardown Date: Tue, 28 Apr 2026 11:55:44 +0900 Message-ID: <20260428025614.1094085-1-senozhatsky@chromium.org> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable When the SOF audio driver fails to initialize (e.g. firmware boot timeout), its devres unwind frees the snd_sof_dev object that the mailbox client (mtk-adsp-ipc) reaches via chan->cl->rx_callback. The mtk-adsp-mailbox shutdown clears the mailbox command registers but leaves the IRQ line unmasked, so a late interrupt can still queue a threaded handler after mbox_free_channel() had cleared chan->cl, and mbox_chan_received_data() would then trigger UAF: BUG: KASAN: slab-use-after-free in sof_ipc3_validate_fw_version sof_ipc3_validate_fw_version sof_ipc3_do_rx_work sof_ipc3_rx_msg mt8196_dsp_handle_request mtk_adsp_ipc_recv mbox_chan_received_data mtk_adsp_mbox_isr irq_thread_fn Freed by task ...: kfree devres_release_all really_probe ... (sof-audio-of-mt8196 probe failure) The crash was observed roughly three seconds after the failed probe. disable_irq() in shutdown and enable_irq() in startup. disable_irq() also waits for any in-flight interrupts, so by the time mbox_free_channel() proceeds to clear chan->cl no rx_callback can run. In addition, request the IRQ with IRQF_NO_AUTOEN so it stays masked between probe and the first client bind =E2=80=94 otherwise an early interr= upt can crash on chan->cl =3D=3D NULL in mbox_chan_received_data(). Fixes: af2dfa96c52d ("mailbox: mediatek: add support for adsp mailbox contr= oller") Signed-off-by: Sergey Senozhatsky Reviewed-by: Tzung-Bi Shih --- drivers/mailbox/mtk-adsp-mailbox.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-= mailbox.c index 91487aa4d7da..8bcecddee0eb 100644 --- a/drivers/mailbox/mtk-adsp-mailbox.c +++ b/drivers/mailbox/mtk-adsp-mailbox.c @@ -19,6 +19,7 @@ struct mtk_adsp_mbox_priv { struct mbox_controller mbox; void __iomem *va_mboxreg; const struct mtk_adsp_mbox_cfg *cfg; + int irq; }; =20 struct mtk_adsp_mbox_cfg { @@ -67,6 +68,8 @@ static int mtk_adsp_mbox_startup(struct mbox_chan *chan) writel(0xFFFFFFFF, priv->va_mboxreg + priv->cfg->clr_in); writel(0xFFFFFFFF, priv->va_mboxreg + priv->cfg->clr_out); =20 + enable_irq(priv->irq); + return 0; } =20 @@ -74,6 +77,8 @@ static void mtk_adsp_mbox_shutdown(struct mbox_chan *chan) { struct mtk_adsp_mbox_priv *priv =3D get_mtk_adsp_mbox_priv(chan->mbox); =20 + disable_irq(priv->irq); + /* Clear ADSP mbox command */ writel(0xFFFFFFFF, priv->va_mboxreg + priv->cfg->clr_in); writel(0xFFFFFFFF, priv->va_mboxreg + priv->cfg->clr_out); @@ -139,8 +144,10 @@ static int mtk_adsp_mbox_probe(struct platform_device = *pdev) if (irq < 0) return irq; =20 + priv->irq =3D irq; ret =3D devm_request_threaded_irq(dev, irq, mtk_adsp_mbox_irq, - mtk_adsp_mbox_isr, IRQF_TRIGGER_NONE, + mtk_adsp_mbox_isr, + IRQF_TRIGGER_NONE | IRQF_NO_AUTOEN, dev_name(dev), mbox->chans); if (ret < 0) return ret; --=20 2.54.0.545.g6539524ca2-goog