From nobody Wed Jun 17 04:17:32 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013052.outbound.protection.outlook.com [40.107.162.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 054AA3D6CD7; Tue, 28 Apr 2026 08:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365670; cv=fail; b=rBTYxHnqXbzPH/vbtYJeLX1Nua48CVw0mgiyDlJRuz4gNTgBsRGe6G7n2e8brZYionyig27AHGMwlJBpgjEAGndMF6w5MN/+9dEy6fUItBr+9OGFywchahpoqOP7GsGUZuAUi1TWg7Iv3VySfN7zCExjwZ1W2S/cZwYiqWKg7iU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365670; c=relaxed/simple; bh=YRQUjB3hNBy0tlNuQvrfgkpNNwqaZ6as4ymESzjBLHw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=TN3SGgVsOlGNp95tXfN3ci5liOUEimxHLBGJ4hK3bxg+sQYwDXwwVsahUO6c85VpD0kancO2fJMHQkV3unV7n57cyvOUAtWISCKiug8isJxJcQD9PAs6Y69tzKYdLIkyR8S7kLzLYg2++Nbr9HsOLh5wYVvSkU8VklV5EsG69+U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=ghicmXqf; arc=fail smtp.client-ip=40.107.162.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="ghicmXqf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C7R7hiI/iher68JJvzIICOE/ZkHh2slVa6QUFWVhBhFKX6S8yj28Hp+wqOgQByo/CMpGWsdUqGZHbvMimL3ZzEZ3iV4APM0YqdbzCzIyXJfTi71bFInJveHzp0xwbsodbIvf896Pnv6K/JDdNKoGQuA81iGRwD9w4z9y/wYTjS09agFqFczGWbPirO0W4M3D9r06es1Uq1eivvNeoDIWaaU0APiDS8Liczr+9sEIKi0GqwRQxZ8NnGaCGPi+uIoPYFH812vuA82haXG7xp3W4zGc+xppJbLwsL1FN59mNU3cnoodFCpW3VDGgmrZy6vIrvm/zh34vQj2ostUi+BuAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jHhLpjDWbFuw+Xf2mKVpMATKMTSu6iay1Vcdo7ntAes=; b=DT6HvP9EiX3LMf49Y1J9/Z/OSIGUo6hW2Pw1+fgeoXI1IRTv7Mgc3vsTBbXLk+MDH7Deab+7yaQNAdqbyUirA7/cRxjR467O2E26zHznmwxG2kGo92pSkrYXEAALtYDkQtfZy981nUoZJNlXVcdIvKPjUYJY4xP/DTLmZW1FFTb7ek7A7neXA5xjA5/nONYDahHYY/xzQ3wE/kOriee1gM1uzCwam2UWiSn0QObM1NpM9/5fFytP8negS4htuUmodqaZF+WRnzwqkNRMZnWO4lRLyLBczUjIAeuIjJAU33hQQ5lYhYWh6TdC5G3JdjiO9ju+ec+0HyqzZgNNPUY/rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jHhLpjDWbFuw+Xf2mKVpMATKMTSu6iay1Vcdo7ntAes=; b=ghicmXqfpj30pY2WVFqmqOZkw120lyT4IuqzF+d2YlVsHLNrw9Fz6PDc3OXElYubRepSD9MmFQuQdKRoz2Z3y/6l0ePSpPBbew+wE8H+qqWSBMfbFgLfk1jZHUWE8aAAzLwE1nVJD3PHm3mBmf3LBFhMCvzs3kB2pZ+TJ3pNqEVDRwQEuJDKanxjQM3Y1kfMVOCoBgebGVqxuC/n3Eye9Cx96cx0hDY4ZU3PFYVL2+BPzOT2NK+F5nyWOmm4It255Zb09ufPmhNZDjyl8Dt99W7ZWGStFIYo4kiORz1dTMK4olmieMybZMZP5WkAALyihsj4VAmT5K+S6kWLZ4RZ1g== Received: from CWLP265CA0392.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1d6::17) by GVXPR10MB8782.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:1d9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Tue, 28 Apr 2026 08:40:59 +0000 Received: from AMS0EPF000001B2.eurprd05.prod.outlook.com (2603:10a6:400:1d6:cafe::37) by CWLP265CA0392.outlook.office365.com (2603:10a6:400:1d6::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Tue, 28 Apr 2026 08:40:59 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AMS0EPF000001B2.mail.protection.outlook.com (10.167.16.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Tue, 28 Apr 2026 08:40:58 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:44:29 +0200 Received: from localhost (10.252.13.121) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:40:57 +0200 From: Benjamin Mugnier Date: Tue, 28 Apr 2026 10:40:55 +0200 Subject: [PATCH 1/5] media: i2c: vd55g1: Fix media bus code initialization Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260428-vd55g4_and_fixes-v1-1-4f745a83b87e@foss.st.com> References: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> In-Reply-To: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> To: Sylvain Petinot , Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil CC: , , , Benjamin Mugnier X-Mailer: b4 0.15.2 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001B2:EE_|GVXPR10MB8782:EE_ X-MS-Office365-Filtering-Correlation-Id: 64b3ce54-44e2-4891-e545-08dea501defd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|82310400026|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: vhdZsa0GgYQ+g7cBY87WLXXACBrEZW2pIad4KQ7RXNwgLrgzL/VuCeAO5d/oDNENYIF5Zyy7a/tSstESfjdmzNU4gmqpUl3V1dndA3QuFMUoawzNKoo60bN4A4swatL7W1zcVvWCkVP2nMZN3OvLOn5hGMgKZ60lIA7H6zC1Vqi1DmvZiNhrTEEkp1B1SMGF4Vv9M5UU22I2hJNJOGrXFO4PaMmonArld+ElxUmpkUTTplV3vyvL5hBAg9+C+7LLvdnBzK7oSkW/cNYZMIuexPaiU2VEjWCdptaSTWuzwjWxqdZYOVY8uAlpdNqfQvfiFKYdAKGbskj/5LQ98QXJn+DXl+PqDqO2vgyynqg1cCfAXdpn/hbdSb5yAr4vKfgQll0pkyrEzc44XketATkBRWvfthp9NJd8boNDjW7M5Nl6xX94UITrVWrhCgX+w4LAFtKvD8RZ9l7XqPAQjSwAvyCz7HOrUQXUiYyKf/WPrPU+dzQtr4M8WfENPWq4ImlWbdmHv7JGOA1Y8FPHecVcCizYoWscpEzPjKbPCJBjDxHkLYka0kjDmpiGtwQAkBOwhd4Yy0KqRDe8nLem6P+3Gh07taL2VmIJs3dxbKvvkoFbTvXE0u67QUHIIgiZlKZennyYoctQPWAQQHhomvp+1QEv110XGybon0q/SXskLqKX/jXMx16+/WV3ZmCPgdW1rYt/J6aIX6HzceVLpJG0jIRhiEkQw9qJJFSFG5fgwflM2fjTygU5NYdOjxQp5nwDDYMMnT7zKChzdB9xCVhkOQ== X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(82310400026)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hX/7mtpnbEcvTK2hLZSXQd8cgZXAbbd4xl6rmPdvMD+HhZwZHspQJ081G3t5WzAycTo9B56mggiaJNpn26ph9dlBZV9n/nGFY886Ee8M3RVvbT5R/jeqbQJNQyfhKxviDB4l/7b9znxBcOtuTw7znJlXysBDQS1xf3Q8v6yI10z+NxFdTWNQUpKnmpar1R9wP4chBOn5IuKfvAx5XXap9+uy34B4SmRE0sRE14gvQzyE+wS9RGM2Lf8+pMG+ViBAcqyMQQGEOzqIzFgKPmpgfJ/fmuAnAdnPWBOZ8FnDpBLF/pY1ccFLu0IHdody4SMxtZGr0lLkkoMuQ/7WUcOCA2f87O4kNTWwwSc2l+mT2YTD4t4eH/hedNc4YcJ8xBchekvG/li1Tm8TaCPigp9i6YoaIuFtPLBqK9Cu+cHUYpp6VL6JmakxCNHZ9EBQclbe X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 08:40:58.6965 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64b3ce54-44e2-4891-e545-08dea501defd X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001B2.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR10MB8782 In the driver initialization, the index of the default media bus code from the supported media bus code array is passed directly to the vd55g1_get_fmt_code() function instead of the proper media bus code. This works correctly as a proper media bus code is set after initialization but could not have been the case. This also resulted in mutliple "Unsupported mbus format" error messages. Retrieve the media bus code from the media bus code array, and pass this media bus code to vd55g1_get_fmt_code() instead of the code index. Rename VD55G1_MBUS_CODE_DEF to VD55G1_MBUS_CODE_IDX_DEF and VD55G1_MODE_DEF to VD55G1_MODE_IDX_DEF while at it to avoid future confusions. Display the guilty error code in warning message. Fixes: e138e7f00042 ("media: i2c: vd55g1: Add support for vd65g4 RGB varian= t") Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 78d18c028154..1e9db21322e3 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -114,9 +114,9 @@ =20 #define VD55G1_WIDTH 804 #define VD55G1_HEIGHT 704 -#define VD55G1_MODE_DEF 0 +#define VD55G1_MODE_IDX_DEF 0 #define VD55G1_NB_GPIOS 4 -#define VD55G1_MBUS_CODE_DEF 0 +#define VD55G1_MBUS_CODE_IDX_DEF 0 #define VD55G1_DGAIN_DEF 256 #define VD55G1_AGAIN_DEF 19 #define VD55G1_EXPO_MAX_TERM 64 @@ -634,7 +634,7 @@ static u32 vd55g1_get_fmt_code(struct vd55g1 *sensor, u= 32 code) goto adapt_bayer_pattern; } } - dev_warn(sensor->dev, "Unsupported mbus format\n"); + dev_warn(sensor->dev, "Unsupported mbus format: 0x%x\n", code); =20 return code; =20 @@ -1347,6 +1347,7 @@ static int vd55g1_init_state(struct v4l2_subdev *sd, { struct vd55g1 *sensor =3D to_vd55g1(sd); struct v4l2_subdev_format fmt =3D { 0 }; + int code; struct v4l2_subdev_route routes[] =3D { { .flags =3D V4L2_SUBDEV_ROUTE_FL_ACTIVE } }; @@ -1361,9 +1362,13 @@ static int vd55g1_init_state(struct v4l2_subdev *sd, if (ret) return ret; =20 - vd55g1_update_pad_fmt(sensor, &vd55g1_supported_modes[VD55G1_MODE_DEF], - vd55g1_get_fmt_code(sensor, VD55G1_MBUS_CODE_DEF), - &fmt.format); + if (sensor->id =3D=3D VD55G1_MODEL_ID_VD55G1) + code =3D vd55g1_mbus_formats_mono[VD55G1_MBUS_CODE_IDX_DEF]; + else + code =3D vd55g1_mbus_formats_bayer[VD55G1_MBUS_CODE_IDX_DEF][0]; + vd55g1_update_pad_fmt(sensor, + &vd55g1_supported_modes[VD55G1_MODE_IDX_DEF], + vd55g1_get_fmt_code(sensor, code), &fmt.format); =20 return vd55g1_set_pad_fmt(sd, sd_state, &fmt); } --=20 2.43.0 From nobody Wed Jun 17 04:17:32 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011032.outbound.protection.outlook.com [52.101.70.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BDD23CFF53; Tue, 28 Apr 2026 08:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365667; cv=fail; b=gpDBlEpkzKShailQAdZkAnsm8iAxYZ2J/eiSoOgKAFqUO7M3d6sHWnMsmUpEZNgOfvNkBwijWwDyedp/gqWz6Jwn5moj7lxxidj2fEOnVbaorfO+PrTb40AYyYHG5Ark7816deJNw7lwfvK4LJTG/Go8yvwqi/A2g4s/BNafWU8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365667; c=relaxed/simple; bh=f7Sd+jlS0mK5D1n854tMi2ZFPf52V7CBz3Qh2H3dZCg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=jIazntKHUpqKAPKYrHZg8K+R+ANuiAUbVZqCpjdO6SNw5CIA/cx/sHMakY3JwnqEwWwUkpCvZkVvc2JJIICDbCz58XjfsUgSQFSpvRI0o/szOB0HD39qNzZ/XDmjSiqx/mxRYfrVgOcxfs8TWW4JEhY/WsNLvcc9wLowXjZkEUY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=f4WS7HjR; arc=fail smtp.client-ip=52.101.70.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="f4WS7HjR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TfMhY+lFLvW4f1TXUzYMKCwUhOG0gohJM5HCNvAamer4UXHgT5Nb8Vu3fiF/EC5VybAlooujUWxpG6PiJcdkHyKogy50P6gu7IJq/ukk1dgWeCkjnLtJ5M5UGj9csQxg5jSp6w0Hvzhpr0KbzC1i1r74Vp+CI5ut+sbgjGaVs1p75y+bDEbtZew42SfALaNoO0sIM6HhU1wJnWa3eOvEjcc8KcpOmJLG9Jr20HpFIf2knSjLYhg3GmVs/KUEyTRp9/ZWztcd4WFRwAWaczgKK1z4leN71CrP5QWz0F4YIomHqNchPoQImgc2f7Nm22dUUWjT0AKSroH+34eJtQtNjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UN0SFXbLMB1m+JXP3yeMI/Bae8jhNBeM1Uhv1/41eKA=; b=QXCkQZtQGqjLYERnMwR7kuF9lif8KGzDAEya5FzpgxdYeQzDL9MeuY+o7zJncC29z5aXnN5+4EO0xzf8FBig3b67qIKEg6m0zb2QkErIfpKBCbhshO8W+d57mKLOXVgVn4hX44AWN3SgpndUoXM9rDNx1CAnJJ4q8VBThoVPhDnr+BG0QtHVHdqbixRYLgxfEtkfwty/17n70ZmodN1d+GXe7y+AxaAR5ngYsiDT7p0Od0GlhGnqk7ziIN9L+Bc9IQUQMeu+/tBskicGzcd8I2ToHSUGs+DAaJcUdminrLeOgqxO2mdhEkKYqhvkMAsDiZ6zQz9zeCKGjM0vQsD+FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UN0SFXbLMB1m+JXP3yeMI/Bae8jhNBeM1Uhv1/41eKA=; b=f4WS7HjRxy8JwpUG5fgoD9A8vktuqLIaeB6AlOVI0B73x8PuSxBj7e2HXvMI9aWV5CgKWqhiBdL7LvWPp1MTcUykrtgD+KJ+gngtgOOOBFrlu40wBhXTlHvQHltnKHgq+y7v0D6/k6oCTbTeZbibIu3W0PkC7h6yoC7IFU/yTAlQDln9FwMK7hP4SkPE0s+huAP96YdumSulCfghUZgAHsT8Z6pt6wUjlb/rx6fIObrMyTM2iFUhC+o2hLxlm64ox1IV4zpKNUAXRuA36hBh3NAguIkci2El+GJexb1d1ZnDaTkXtn4vDdwane/mpJ49PwuO/ZGA3N8FKLdq4i7AmQ== Received: from CWLP265CA0397.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1d6::6) by PA1PR10MB8977.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:451::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Tue, 28 Apr 2026 08:41:00 +0000 Received: from AMS0EPF000001B2.eurprd05.prod.outlook.com (2603:10a6:400:1d6:cafe::91) by CWLP265CA0397.outlook.office365.com (2603:10a6:400:1d6::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Tue, 28 Apr 2026 08:41:00 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AMS0EPF000001B2.mail.protection.outlook.com (10.167.16.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Tue, 28 Apr 2026 08:41:00 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:44:30 +0200 Received: from localhost (10.252.13.121) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:40:58 +0200 From: Benjamin Mugnier Date: Tue, 28 Apr 2026 10:40:56 +0200 Subject: [PATCH 2/5] media: i2c: vd55g1: Remove spurious pad format update on init_state() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260428-vd55g4_and_fixes-v1-2-4f745a83b87e@foss.st.com> References: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> In-Reply-To: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> To: Sylvain Petinot , Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil CC: , , , Benjamin Mugnier X-Mailer: b4 0.15.2 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001B2:EE_|PA1PR10MB8977:EE_ X-MS-Office365-Filtering-Correlation-Id: 05de88f3-0442-4060-63bd-08dea501e012 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: H3CbnDKDJvITMWyKSbBRt0+z81la6WGItkHPUjKOcf8ZAKmDyp8clO/AXDDzs/3S7ry5h4grDkMsca0ipL1Wl2zZGiRuz2TDkq3VOhhQNHG+APhmsK+9VrztbgMouegjkhb+BjQumO9mzSnabKrg3Vv2vGl63CJq1pcITqEHWV78RVEOiFWamRa4AIvwfgtjLgE3xU3gH0xQSOaNwlrSVKxgEJqfPfLJ04jnvCXaHOqP8wirT6NgR+ow3QHeVxPJ1Baoj7qckfXPx29srWkqcTCnMzn14o8UEaeKGPG7K9o22P9l9wE+QgZ9VJDYs+AsrdCZq4rC8RfL+pIWVr3tZ4xqT2+tLsgSVUrkFwJAOM9v0B/SlI5WlmZQV2KUgWwXNokWpyaSwj5KxaoUkuFAph/GrD/bGvQ1dvl8/mh8BazEIf+Mib6WZQpMb6MzXpbebQt2u8zkPZm1T33dsqcBbKX5UDSO4Io3OV57E9hxbPIZyZ4XctRNKbmi3lVjL48DQHuOCvufNZhgVXW1ZMj7v+9qKu3mCh85piDl/sH9l4XRKbVt6csQkApqboQu1SBfM8EWcEvJTfIBN2OopwT/jtLqAEwOIuW4x1WOouYp6IcdsXTlwDkndZxJmi/YAdRj3umAeEZKlwuFLPcshKAwqvco/jXKDMZnYKSDicc9lRpa0dc6pN2ZCYgSqI0mP28hBAgoQW5S7S2EFg3JxMRp+uSZ6sgu4HcRCgvHA7wv9MYYGmNB/vimdOb7pnVCneSgQi/6bki9rCP8ED7k5nYsbg== X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1Fh4R6sD5RdfHuCOQW/P2xEWX9GWogFXu3E3wuxLPDSryRH2vWr10ER/fgq2/5zNhmBBCGE+fYGa5F4wDqyzkcMcjFcy8yynW48AJNv55WmQ3liEENX75lfw4AL5DiVHzpyu5/1MNwups/DqE1x0TDuBDSXvGriV7drFl/j4Ltq+oeTsFMyR5wwzBA5d3SBKQB4uLqC07rY118PmDm10yIO8QDuJQZLNEOfVT1AV2j0MePoaDSxiWKDT0uQ5WOa3egNHRDo6ZqntjS1hcRYo4E3Gg0SJFp/gJhwaYxNlkdK1KkVwVnDYAgGSiTqxAOTacRnz8MRgaXgDOyeoC+04+T5xG7bm/LWO+dz8dPN6dEd+M/GTC1nTgIDAacwS3KcT/s9V/7bfEjP8xXMZxalstZ3UH5nbPLNkaCIak0fUP1upz3+1R68G87SUzfFt7xt9 X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 08:41:00.5128 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05de88f3-0442-4060-63bd-08dea501e012 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001B2.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR10MB8977 vd55g1_update_pad_fmt() is called in vd55g1_init_state(). But vd55g1_set_pad_fmt(), called at the end of vd55g1_init_state(), also calls vd55g1_update_pad_fmt() itself. Enhance readability and clear confusion by only preparing the format in vd55g1_init_state() and let vd55g1_set_pad_fmt() update it instead, effectively calling it only 1 time instead of 2. Fixes: e138e7f00042 ("media: i2c: vd55g1: Add support for vd65g4 RGB varian= t") Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 1e9db21322e3..e44174056ace 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -1366,9 +1366,9 @@ static int vd55g1_init_state(struct v4l2_subdev *sd, code =3D vd55g1_mbus_formats_mono[VD55G1_MBUS_CODE_IDX_DEF]; else code =3D vd55g1_mbus_formats_bayer[VD55G1_MBUS_CODE_IDX_DEF][0]; - vd55g1_update_pad_fmt(sensor, - &vd55g1_supported_modes[VD55G1_MODE_IDX_DEF], - vd55g1_get_fmt_code(sensor, code), &fmt.format); + fmt.format.code =3D vd55g1_get_fmt_code(sensor, code); + fmt.format.width =3D vd55g1_supported_modes[VD55G1_MODE_IDX_DEF].width; + fmt.format.height =3D vd55g1_supported_modes[VD55G1_MODE_IDX_DEF].height; =20 return vd55g1_set_pad_fmt(sd, sd_state, &fmt); } --=20 2.43.0 From nobody Wed Jun 17 04:17:32 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012014.outbound.protection.outlook.com [52.101.66.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 032FD2DCC01; Tue, 28 Apr 2026 08:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.14 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365667; cv=fail; b=bRXCZwn8sUYJzcRYfnrJZbPSK2P6EY7K43NY3y3jwJkzarpbUB3QvCJ+RJrW+CckyFMACuA9EtlFBi3HUEVqcLEPofarwuqWpWVja6Jgu/FrVrI0QyrmWt8fosoje6KiWpcZZ+QVxrz+EsL5K5J5puEvSahfq6pZw3tS54ALAZw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365667; c=relaxed/simple; bh=kilHZ0x3ScyEtUgGi1wLSklQthfNdlNvNMHBH71xiIw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=niRN/wxPw9sI+4BDCdDts4lyLUQZ+zZor5qyhFtShIXhbMf8iW2sjQSKvIypunqAmce8ZDFECVW4ovu05XY7BjA6huRapovxDAHV8HFQxG1f6C7SCmV5030iRF2bMg3YwG2uXHkE37fBm5gv1zozzE+GECk7KNpdgt+HYA669/Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=etZHRHWJ; arc=fail smtp.client-ip=52.101.66.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="etZHRHWJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FLxiAd3zUdBuDh6hECil0+y2uiVmumo2JF/uyPJ0KOG4/UrU9CphcCzPuGxN9nADEK84G3CRysfyZrUHDfq/L27wYu7+gI58InhXQefTJUCVSKPas33WjM88BMFHZ6+vaztbje7dVfjs78smp0DRUYzQsqM8EUBcW5S+Q1J2rM99KPPKfHzJ6uv5c9NcYYTf6UmKPL/w+EfGRqSc/0DKOgnvct94ujA0T6JXYlAL3qMGz+rgvUJg54XaqNPCjunSdacZHsKIC68/cfGgPKRs0qUzg4Zn+VEryqrHX+MGdnhB51BqYCwvTi4AMmLGp+OD/JwBw5vBjdjsKxm5cunXxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rboA/EhHDCOnI9zRFirCKI20oVezFDqNeIq9dIOVQ6k=; b=LMs80uR5r72C3p1MqkVphw8tvVGj0bEsWRSk4VDFy2VfZDtGA2PZCjVlHqsR6n4x6wTXmeOlvAheu4yZG1fHfpJWOLDBYLyRpy6Nvlo63RJ0ezN1MVEePY+mAhh1/yVFx5XYXiibRx8WzXJIfmc9WYGwpOPRPp9NGJg1ttG53/TacSevGdgRXDpFiCzonYkDz8JI1XP7IFZQF2OlnKPT096iYhJGIOapkKKFPnkIeuzkr8LgZpRl6kRtPoFEEqF+gX8Ycm5TupKyVOzoo/EgQTjGJcRvKSR2pR8Fm3EMXfAL8FA5C9qhpUCXMUj4XiBubiu2SH7evMWOFn+IfwTjNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rboA/EhHDCOnI9zRFirCKI20oVezFDqNeIq9dIOVQ6k=; b=etZHRHWJHt6A96qsS2HpeyRrERTvZ4uKNbv2YbIQy+T6ZRTOeexsUq5OdUC5ZSEcvkgMK4LlYPeZiRgCooRlXMUGXSM7b6sN6PlwEudRNQGCi5m6aO47116fQt/MqFyF5BohvfZIgeNujIOWtxq5RXA0WXXpbWE8tqNmWS0hLtwIb1jeBWHUmoJOKlB7DCVfBaQgDZyHY2qfB03S+MloBPzJ7nY4amCiWK3PNT0bkv1ClnTofiHOnVMOg5oHbEB2jYHlHrQxdaxbkKE8V9M/m5Pgv2Oh7+jfGPWFPSGyvg3EG1a24i/6rmwOqkdcrhJbeP+uz9eoRUECk4JZsHY0FQ== Received: from AS4P192CA0014.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5da::14) by PA2PR10MB8942.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:416::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Tue, 28 Apr 2026 08:41:00 +0000 Received: from AM4PEPF00025F97.EURPRD83.prod.outlook.com (2603:10a6:20b:5da:cafe::fb) by AS4P192CA0014.outlook.office365.com (2603:10a6:20b:5da::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Tue, 28 Apr 2026 08:41:00 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AM4PEPF00025F97.mail.protection.outlook.com (10.167.16.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.0 via Frontend Transport; Tue, 28 Apr 2026 08:41:00 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:44:12 +0200 Received: from localhost (10.252.13.121) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:40:59 +0200 From: Benjamin Mugnier Date: Tue, 28 Apr 2026 10:40:57 +0200 Subject: [PATCH 3/5] media: i2c: vd55g1: Fix manual digital gain on color variant Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260428-vd55g4_and_fixes-v1-3-4f745a83b87e@foss.st.com> References: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> In-Reply-To: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> To: Sylvain Petinot , Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil CC: , , , Benjamin Mugnier X-Mailer: b4 0.15.2 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM4PEPF00025F97:EE_|PA2PR10MB8942:EE_ X-MS-Office365-Filtering-Correlation-Id: 496e8243-9396-4305-2145-08dea501e01e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: k/3CRTE0EvO30Jjy0AFhWXPRW80cesrCHpI8Fw2JCbqL9Iewwffartff6iHyWJnN9mFa1VBpga6ir+Mgg+ztXsjIWwF2BrTzxHqLUC/ff0RVMJKv0D49rOJXPPKJKYvQQ+2XumZV24mZ1G0ialHbMMqdFENHEtZADtkQWWi3z1MkihZUJrb1ydQBHMReZKdGOe7NUfHv5kKaRYdnkiwV94bdOIpKc8bjLvf7WnFV6wvWLYifE9M/sF3rHJjCe2xH/AD2sR5E6fGLumZG9e4FPRzRY8f4trzaJ+YRIEM15vbSGBFlWHqT54NesWOpYPH8l6/nawFcTZdEnYjzIl+9YugP0vBUToYISV0feH+nA3M3NQHp2sPC9lbMdT+LdJvTrU7+2YmTWJ2E31AtWirmsMTL12qdmxRbpuyf+iH7J3utS8qhTdN8B8oFrZi93PiCfMu+tEKjKoIHErbotgztxXOc+wxNU7HKH4hHeU0lf8b/YfdDbZfr60UjVwmf/zIe3LbDbe9UPKMbpHLNahKoJNOJ9PJbVnYnGgsae3/kFppyoYkM4LX27D7T6jsXfooMQU2TM4Q6nJQGLr8Z5CCZnGP4unID4ctu+qD23bHsv9Dzf39CivEgbSHtssCfTlnp/afrZ5Mq+4u8bnKq/LIjLa9+HAmvAnNrBkPbcH5G00x6CIfs476Km3EoEQAYIrzoZ8yFdLyN+FxI/qNAuj7lhNNlO+yz6ytCeajcqP5E2YfkoKqQxzg2cdGIsdgw7dfAfDk1hGoPMZ0fsVlwVGOoTw== X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5r9cfAwwJLObTTs2EcR7XLalLCgrH0DEgh2Ls6d1XYrvNMYc93CWBG81HWLb1GDnpM3+xby02H23dMnaKzHt/0XvA5aInLOStajUpH7sCI2plrbJDwwNc505NC2VKtUJ/AV0N2gMnsVMx1dQZNUcBkM6ELCid0L9r3C+/6aOM0qJ+l2M8ajd8JXrxlJIhlV5ZXSyPIcKSDlqGoZ/PIE6QhSNNZMTLVj00OTRaLyYQb2fQ54jJMSqzw5Jnyu9U/nLWmoJ8n4h5YS67t23y7ODiin+ktJPybT3KOdoGaE9hQKUcWH9b+A8r6wcKvm6gUywJ6Yl+2d13YRgoGobPcVqHf7ZhzspUFoTsmJMUuQQQedQeSh6BcQi/k9AB9aeg66+99ZnKio7UI8+etgySPDCAGwzFg4lxbcWBMPXH9oljleY9yVZjYdL3TnSXOWYaHTS X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 08:41:00.5946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 496e8243-9396-4305-2145-08dea501e01e X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F97.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR10MB8942 Apply digital gain to all channels, each channel representing a color. Fixes: e138e7f00042 ("media: i2c: vd55g1: Add support for vd65g4 RGB varian= t") Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index e44174056ace..2c962fcb41d2 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -60,7 +60,10 @@ #define VD55G1_PATGEN_ENABLE BIT(0) #define VD55G1_REG_MANUAL_ANALOG_GAIN CCI_REG8(0x0501) #define VD55G1_REG_MANUAL_COARSE_EXPOSURE CCI_REG16_LE(0x0502) -#define VD55G1_REG_MANUAL_DIGITAL_GAIN CCI_REG16_LE(0x0504) +#define VD55G1_REG_MANUAL_DIGITAL_GAIN_CH0 CCI_REG16_LE(0x0504) +#define VD55G1_REG_MANUAL_DIGITAL_GAIN_CH1 CCI_REG16_LE(0x0506) +#define VD55G1_REG_MANUAL_DIGITAL_GAIN_CH2 CCI_REG16_LE(0x0508) +#define VD55G1_REG_MANUAL_DIGITAL_GAIN_CH3 CCI_REG16_LE(0x050a) #define VD55G1_REG_APPLIED_COARSE_EXPOSURE CCI_REG16_LE(0x00e8) #define VD55G1_REG_APPLIED_ANALOG_GAIN CCI_REG16_LE(0x00ea) #define VD55G1_REG_APPLIED_DIGITAL_GAIN CCI_REG16_LE(0x00ec) @@ -850,9 +853,16 @@ static int vd55g1_update_expo_cluster(struct vd55g1 *s= ensor, bool is_auto) vd55g1_write(sensor, VD55G1_REG_MANUAL_ANALOG_GAIN, sensor->again_ctrl->val, &ret); =20 - if (!is_auto && sensor->dgain_ctrl->is_new) - vd55g1_write(sensor, VD55G1_REG_MANUAL_DIGITAL_GAIN, + if (!is_auto && sensor->dgain_ctrl->is_new) { + vd55g1_write(sensor, VD55G1_REG_MANUAL_DIGITAL_GAIN_CH0, sensor->dgain_ctrl->val, &ret); + vd55g1_write(sensor, VD55G1_REG_MANUAL_DIGITAL_GAIN_CH1, + sensor->dgain_ctrl->val, &ret); + vd55g1_write(sensor, VD55G1_REG_MANUAL_DIGITAL_GAIN_CH2, + sensor->dgain_ctrl->val, &ret); + vd55g1_write(sensor, VD55G1_REG_MANUAL_DIGITAL_GAIN_CH3, + sensor->dgain_ctrl->val, &ret); + } =20 return ret; } --=20 2.43.0 From nobody Wed Jun 17 04:17:32 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011049.outbound.protection.outlook.com [40.107.130.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4406A3D75A0; Tue, 28 Apr 2026 08:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365670; cv=fail; b=eVv8oj4+pdnZDL7odUyB4Zc1mYkkPyi29jb7ZMt9/CEkpWsDz359rmpxN8jwf+PmQTiHPQmyxHw2Dk8wp2HgvHP/XTLQT8NkdX/cB84m6KY8Kfl4LhOStr9EbY7XME9pOE0KOpgRL4grQptGinZOUIvBbLZ57QUE7YjX57PyYIo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365670; c=relaxed/simple; bh=thoyuZdo9XWEOUcYnNU2ur8iLcBUTTqYQlBHMnjtnxo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=U660kKfI6SJZCZG39I1c0FdRPGVmfYg+dv6JJMCX2aRY06yQNyAZdzv51CxX3wzmYhYI+09ba+Mtw4U1oCg63taxRIIFRvDC1k8Q6a8DeOs1n5MOE7mLntSwybNdE9+5/C8yTFT1Yuex4/NfokV1fWR6idkt5+O/OYqe8iLvUZw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=VCj/6o9z; arc=fail smtp.client-ip=40.107.130.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="VCj/6o9z" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ekQ6Nz1ebHApFbo4lcEOwNcJP22KL+Hve5gUBdq0TWB5Ne3gQ7xjckF8MzC6oW7vOnK7LqX2VCU4K2LaVA72jDkrHpoAB4NbITykQS5oiuAOYfZ+Jm2OG2Tuhmk+S1aUoECpwI9NvnhRnxQu9q1vvcfRXwZzhbwI0qwXwb9jdobE50j4iLicM6WXdrNyjYNdkp4AM+jHPy5Mo5KLKgBIB/WR7pK6cE3SUY0hkdjSQqzKqWRiHYxgD1FOAYuWr8E93VyaWnRkM1ePbfJdsbyMpd3whpzO1VfyPwWm/VKwddDyQTeFCc1maat6oX6P0FmYvPWcuaYamv/1A8g1pP/fXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q76Er9P3YRyKzyVRjXRi/XfOaU125s19oTDyyv6CaVY=; b=ZUOwEKQjqC+mQMhmx+LrlFMdHVgpW2FkI/MC/HXBYlF/RYs6LFYORxRwKWIoc+1xJn2H3qh+e5IXr5xN6CKDlwL3H5vtmjM009754B+KljeOn0v3du5vAGUEcuwWVCUF4r3isVg8qZQg1NnSJ9HzbZ5x5TCS7oKGEY74ws+AMHU09qlVQa0pbd8p8Mcnnufe2Eed4TWsJziorJqkTR9B/OVbROxgbeYL7BXSyLJiDCxh8KVNKldIK26bh48eYYAu4ym288lCoLavGZ9mI29L9bqq3rSgOIIizi5OuYaeElvFw6tvEB5khhSsZWGTRvBCKgva0THs54g68mhJJL4mRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q76Er9P3YRyKzyVRjXRi/XfOaU125s19oTDyyv6CaVY=; b=VCj/6o9zFV90w81gW8m5/q1FGRT8keoyk+EiSihw0nrk5B6iJ8fZicYJ5B0gKkMhp8ZMASvWsXsvEalQLfOhowgLK2/OB5b4BO9kc+fToREb34tu6o0rSrXBfAn47sWrMoWsGfh+LIaU4/tySVFfmszYldGA0yy6DJdN84cV6PA/b5KteEyTpAc3OXFnHG9TDpjsejZBct7bMqjlbm6KK2XCXVURIsUrkvtAV16fVEV3K0c6XvCuy5TLbOL5mAT9O5clIcYC6pR6dW3QmZvvW5d7E2bZj2ETKeGwW54jSBuia9s3bwlrJs5H6vSEgdcCm4gAL84JWW7+kjmyDlWTHg== Received: from CWLP265CA0406.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1b6::9) by AS8PR10MB7157.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:61f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Tue, 28 Apr 2026 08:41:03 +0000 Received: from AMS0EPF000001B6.eurprd05.prod.outlook.com (2603:10a6:400:1b6:cafe::1a) by CWLP265CA0406.outlook.office365.com (2603:10a6:400:1b6::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Tue, 28 Apr 2026 08:41:02 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AMS0EPF000001B6.mail.protection.outlook.com (10.167.16.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Tue, 28 Apr 2026 08:41:01 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:44:32 +0200 Received: from localhost (10.252.13.121) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:41:01 +0200 From: Benjamin Mugnier Date: Tue, 28 Apr 2026 10:40:58 +0200 Subject: [PATCH 4/5] media: i2c: vd55g1: Add support for vd55g4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260428-vd55g4_and_fixes-v1-4-4f745a83b87e@foss.st.com> References: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> In-Reply-To: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> To: Sylvain Petinot , Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil CC: , , , Benjamin Mugnier X-Mailer: b4 0.15.2 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001B6:EE_|AS8PR10MB7157:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cbc49e7-bf0f-4310-e9c1-08dea501e0db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: 3iJ8UtEFJnv5XuV8jr90KLiXTvzKD2299nWcOIyZc2dvdykkCeQTmw83e7hCmqreaGLtZisDCz6ruEPV0g/ajOxxCCkkl8jDo/T082bwJe9OMHmxGexoG59tDMJr5b8QZnmaT/AMSo8TIEjRCZtMvdHtVzBIkQu6KWd+7Ba7UP7DaxAjgpeQGVx1kNP43ZIumw5SAOm+G2EWNTsgzf+uVvdFQgwmzyCqDkuqWycxJjnGZ3ac7hwIn8GEtPkCzxob4GO9PXxm0bCyMHqChZ/iLz+pbR7L+/Ty2dGFeOvWs1xOXlvKb2KpVjftr3ILZiOiEEx9j7ASNHtqJPJx+Pe0MFcWeeiY+TsSiXlB8WM9tzOGAUzuxnV1EMzRASzRlvYUenAep2rJsMhIziEmGDYd/qFzzSKBVxC9mF68VD3NTnSMZ3n+YG3cEbGJXt8ZyIQfje7HZQ0lWtCqGWysNw2WRlfk3tDJNKuSjYZU5voe14Srz7IloYF8VR9yugFwI0o5YCI+bmKOzSsc6J0oUL6Yah8EGzvFTTKyOtJHJZ5CCA6G1aBw54S9UFpe5g0yoawCL7UfBAoPx9WZMU0wpreRNTvOTZK2MlAQ2KU1zM8g/ypqwd0456cLn9g/gQYkG9/WRXY8ffzHbICu4BSW15Q4aGH0dOb4UwYz3837H3oZG7toGNV5NG/pNWi14SjlVP3HHotbs0y7t/yT0VSqGU11EwfkqAIebdlArwJJUM8nYpn+rY27gvaVL1dnvQ/UtGeT58ZRRDshAppzQxdiZJHP9w== X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cdmtuhUOIuR5UGsYMzzLyg/JumWwKQpljq4kUG9t+w80jQY+fW4zOFmfgiJUaiv8GZgs8hx5qjGi0CEs9OLZbj5k8/oNQ9cBDwCbvVY18A/Vb4jN1gFWRULJBRReouY+MjjTp2v1F+5dpuKscAhn5A0p+aesmXjjNHM/x9fXTx+FHE+nGf585NAGKTJfbb1FMR51zDUtdgsxrEPklBhHTxljF6cqZwWldtIxBfHGBeUuhbUzhgcqFe+Jyx2t2cZjK4Bq3s55iQZ6arpbdaJBTw4O+9UrMKZk0u8HSKb0fEG01WhPs9hWmIsxmx4lB2NzNwNowTwjKcKQ+KiKbqRvX1sIV6L9ji9UQp9ldzV9BctRWxBIuBAZJa80GhmceaHgJeuCMbFnEJwYS9JAYzznKx+u/EihObbMP/vei0oh32G6CPgbPXpeoe2WeaT9jMFZ X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 08:41:01.8400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7cbc49e7-bf0f-4310-e9c1-08dea501e0db X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001B6.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7157 vd55g4 is the same device as vd65g4 but outputs in monochrome instead of RGB. Adapt the driver structure according to this new variant, and add its support. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 110 ++++++++++++++++++++++++++++++-----------= ---- 1 file changed, 74 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 2c962fcb41d2..9f62fc0428a1 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -29,11 +29,7 @@ =20 /* Register Map */ #define VD55G1_REG_MODEL_ID CCI_REG32_LE(0x0000) -#define VD55G1_MODEL_ID_VD55G1 0x53354731 /* Mono */ -#define VD55G1_MODEL_ID_VD65G4 0x53354733 /* RGB */ -#define VD55G1_REG_REVISION CCI_REG16_LE(0x0004) -#define VD55G1_REVISION_CCB 0x2020 -#define VD55G1_REVISION_BAYER 0x3030 +#define VD55G1_REG_COLOR_VERSION CCI_REG32_LE(0x0670) #define VD55G1_REG_FWPATCH_REVISION CCI_REG16_LE(0x0012) #define VD55G1_REG_FWPATCH_START_ADDR CCI_REG8(0x2000) #define VD55G1_REG_SYSTEM_FSM CCI_REG8(0x001c) @@ -138,8 +134,39 @@ #define VD55G1_MIPI_RATE_MIN (250 * MEGA) #define VD55G1_MIPI_RATE_MAX (1200 * MEGA) =20 -#define VD55G1_MODEL_ID_NAME(id) \ - ((id) =3D=3D VD55G1_MODEL_ID_VD55G1 ? "vd55g1" : "vd65g4") +enum vd55g1_model_id { + VD55G1_MODEL_ID_2 =3D 0x53354731, + VD55G1_MODEL_ID_3 =3D 0x53354733, +}; + +enum vd55g1_color_version { + VD55G1_COLOR_VERSION_MONO =3D 0x0, + VD55G1_COLOR_VERSION_BAYER =3D 0x1, +}; + +struct vd55g1_version { + char *name; + enum vd55g1_model_id id; + enum vd55g1_color_version color; +}; + +static const struct vd55g1_version vd55g1_versions[] =3D { + { + .name =3D "vd55g1", + .id =3D VD55G1_MODEL_ID_2, + .color =3D VD55G1_COLOR_VERSION_MONO, + }, + { + .name =3D "vd55g4", + .id =3D VD55G1_MODEL_ID_3, + .color =3D VD55G1_COLOR_VERSION_MONO, + }, + { + .name =3D "vd65g4", + .id =3D VD55G1_MODEL_ID_3, + .color =3D VD55G1_COLOR_VERSION_BAYER, + }, +}; =20 static const u8 vd55g1_patch_array[] =3D { 0x44, 0x03, 0x09, 0x02, 0xe6, 0x01, 0x42, 0x00, 0xea, 0x01, 0x42, 0x00, @@ -535,7 +562,7 @@ struct vd55g1_vblank_limits { =20 struct vd55g1 { struct device *dev; - unsigned int id; + const struct vd55g1_version *version; struct v4l2_subdev sd; struct media_pad pad; struct regulator_bulk_data supplies[ARRAY_SIZE(vd55g1_supply_name)]; @@ -628,7 +655,7 @@ static u32 vd55g1_get_fmt_code(struct vd55g1 *sensor, u= 32 code) { unsigned int i, j; =20 - if (sensor->id =3D=3D VD55G1_MODEL_ID_VD55G1) + if (sensor->version->color !=3D VD55G1_COLOR_VERSION_BAYER) return code; =20 for (i =3D 0; i < ARRAY_SIZE(vd55g1_mbus_formats_bayer); i++) { @@ -1183,8 +1210,8 @@ static int vd55g1_patch(struct vd55g1 *sensor) u64 patch; int ret =3D 0; =20 - /* vd55g1 needs a patch while vd65g4 does not */ - if (sensor->id =3D=3D VD55G1_MODEL_ID_VD55G1) { + /* Version 2 needs a patch while version 3 does not */ + if (sensor->version->id =3D=3D VD55G1_MODEL_ID_2) { vd55g1_write_array(sensor, VD55G1_REG_FWPATCH_START_ADDR, sizeof(vd55g1_patch_array), vd55g1_patch_array, &ret); @@ -1256,7 +1283,7 @@ static int vd55g1_enum_mbus_code(struct v4l2_subdev *= sd, struct vd55g1 *sensor =3D to_vd55g1(sd); u32 base_code; =20 - if (sensor->id =3D=3D VD55G1_MODEL_ID_VD55G1) { + if (sensor->version->color !=3D VD55G1_COLOR_VERSION_BAYER) { if (code->index >=3D ARRAY_SIZE(vd55g1_mbus_formats_mono)) return -EINVAL; base_code =3D vd55g1_mbus_formats_mono[code->index]; @@ -1372,7 +1399,7 @@ static int vd55g1_init_state(struct v4l2_subdev *sd, if (ret) return ret; =20 - if (sensor->id =3D=3D VD55G1_MODEL_ID_VD55G1) + if (sensor->version->color !=3D VD55G1_COLOR_VERSION_BAYER) code =3D vd55g1_mbus_formats_mono[VD55G1_MBUS_CODE_IDX_DEF]; else code =3D vd55g1_mbus_formats_bayer[VD55G1_MBUS_CODE_IDX_DEF][0]; @@ -1659,38 +1686,48 @@ static int vd55g1_init_ctrls(struct vd55g1 *sensor) return ret; } =20 +static const struct vd55g1_version * + vd55g1_get_version(enum vd55g1_model_id id, + enum vd55g1_color_version color) +{ + unsigned int i; + + for (i =3D 0; i < ARRAY_SIZE(vd55g1_versions); i++) { + if (vd55g1_versions[i].id =3D=3D id && + vd55g1_versions[i].color =3D=3D color) + return &vd55g1_versions[i]; + } + + return NULL; +} + static int vd55g1_detect(struct vd55g1 *sensor) { - unsigned int dt_id =3D (uintptr_t)device_get_match_data(sensor->dev); - u64 rev, id; - int ret; + const struct vd55g1_version *dt_version =3D + device_get_match_data(sensor->dev); + const struct vd55g1_version *version; + u64 color, id; + int ret =3D 0; =20 - ret =3D vd55g1_read(sensor, VD55G1_REG_MODEL_ID, &id, NULL); + vd55g1_read(sensor, VD55G1_REG_MODEL_ID, &id, &ret); + vd55g1_read(sensor, VD55G1_REG_COLOR_VERSION, &color, &ret); if (ret) return ret; =20 - if (id !=3D VD55G1_MODEL_ID_VD55G1 && id !=3D VD55G1_MODEL_ID_VD65G4) { - dev_warn(sensor->dev, "Unsupported sensor id 0x%x\n", - (u32)id); + version =3D vd55g1_get_version(id, color); + if (!version) { + dev_warn(sensor->dev, "Unsupported sensor version, expected %s\n", + dt_version->name); return -ENODEV; } - if (id !=3D dt_id) { - dev_err(sensor->dev, "Probed sensor %s and device tree definition (%s) m= ismatch", - VD55G1_MODEL_ID_NAME(id), VD55G1_MODEL_ID_NAME(dt_id)); + if (version->id !=3D dt_version->id || + version->color !=3D dt_version->color) { + dev_err(sensor->dev, "Probed sensor version %s and device tree definitio= n %s mismatch", + version->name, dt_version->name); return -ENODEV; } - sensor->id =3D id; =20 - ret =3D vd55g1_read(sensor, VD55G1_REG_REVISION, &rev, NULL); - if (ret) - return ret; - - if ((id =3D=3D VD55G1_MODEL_ID_VD55G1 && rev !=3D VD55G1_REVISION_CCB) && - (id =3D=3D VD55G1_MODEL_ID_VD65G4 && rev !=3D VD55G1_REVISION_BAYER))= { - dev_err(sensor->dev, "Unsupported sensor revision 0x%x for sensor %s\n", - (u16)rev, VD55G1_MODEL_ID_NAME(id)); - return -ENODEV; - } + sensor->version =3D version; =20 return 0; } @@ -2048,8 +2085,9 @@ static void vd55g1_remove(struct i2c_client *client) } =20 static const struct of_device_id vd55g1_dt_ids[] =3D { - { .compatible =3D "st,vd55g1", .data =3D (void *)VD55G1_MODEL_ID_VD55G1 }, - { .compatible =3D "st,vd65g4", .data =3D (void *)VD55G1_MODEL_ID_VD65G4 }, + { .compatible =3D "st,vd55g1", .data =3D (void *)&vd55g1_versions[0] }, + { .compatible =3D "st,vd55g4", .data =3D (void *)&vd55g1_versions[1] }, + { .compatible =3D "st,vd65g4", .data =3D (void *)&vd55g1_versions[2] }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, vd55g1_dt_ids); --=20 2.43.0 From nobody Wed Jun 17 04:17:32 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013010.outbound.protection.outlook.com [40.107.159.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DD6E3D6CDE; Tue, 28 Apr 2026 08:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365670; cv=fail; b=fjfvMypfXbJaYEdw8xc4DWEqBMUy4li0Zv3jRYFP+NYo1fmi3348soPT/R9GPUY6NxX9AbgceFOr5bOAnMGS5+XmoJT1eI1dtbkNiZfrkSWl+Gl48MQjyw8DcOfGpuYGC8wB/rjpUSHWCERFC4zC84gZgBn1706GdPK3E7OJeOw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365670; c=relaxed/simple; bh=4j2yp0kn8sUPxuIpk+LzB7c6vmwGygpui5ggT899fHs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=QEmezjUlegY6UA8bZX4fquYj4AV43XIPsuP521kqVpsibJ7caDZkfybw1i9gz9Mtfy2US9YYrGnH28zbi8ijJElaVZkNb00HzWLMF1tUyxtFqw2hOXq0laZvhPenPzLRRXsOePX9KPpITZvBwpfzjAgqvvQR+7LQT/XhSvZpT7M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=gSwPNf0P; arc=fail smtp.client-ip=40.107.159.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="gSwPNf0P" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sJDDzUr1c5DZ70OxaZJBonOvQ9UdcTkE0Vpto3xUFJk6tEBw1CEPrIm+PIZN511wwBkIXTTi4foyyoJUJk9o7D8rrp2v9kHI7Sm6+BQduM6IFrc5H9hVH0wGOldKA+fgghJjwGzhwWZZNNqNX0Q8LwWy8S6kTCAnygOqV25rTXao1RgscqQSOUCBRYNmgJGAI34l6ctQB4UKZIxhsGgu1/N2sSCFd5pcl9T4c4GRv2ilF5HoJ+4b0xvUyF8o5XFGAxHdq9dWjT42idh+wQeut/Ikl93NYkHBhC7mG+DTZGZuWOCOal9On2YLOygpFRWRaA8Axudy+UTFlXTKTpypiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lRqN+4agfW/D5Hib8bicyQhW1uYLutr/jx2ya+TzWVk=; b=zScklt0+ItlNA9ZaKnVgbGTKon9U1BZ3yQWoJdR/yxZ5C570cLNEp85s/f1m6Iri1eyV3iiW55xpfVzKaywnrjOFBMzHQYXpD+co6vdXlKwBlnjmOyegp3bKWi7mWRPOYF0UCk5prLJctGnryvLSuq1wgUxrIaGpFFNttd85Yr0YtfYeGWXfSBOsAGeP61uYhLVSvahZD80sW5jB+DrwJ2ZBEqPeoeteqk+Jyj3ZU5jPFv5UlG48FbD8CWlGLO/aKM2xL8zAQE0zxMiCbcwy/yIFUKdNsOO/8TbsqxVm0LLrlsa0aJhieMbfreocHqyvFPcNRx23k/Kz9P1bXYaQsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lRqN+4agfW/D5Hib8bicyQhW1uYLutr/jx2ya+TzWVk=; b=gSwPNf0PByASXz0NenXSZeS6zpvoyALyluFULzw5u4QEp/LRrZyLmPQz6VVWZR/CUsFwnypVt/v3jhiUIaLqZJU7LT2+GKNqQA/nNA7TuQ7lSX/g6EGsVSawjz5eniSPi4Y4bzJwg3hFNq+nfUwJ/3zhovG9c7XW7sNZp6t5xB9TCoysd2xmC/H1U8k0vCJLpFU6+d9mtdvaVHU2ooDRmQTcSTLP50IseU5EYGfOgZgra2HD0mSHj5GKQE4rGNMIvMCkeP/YN+1HV7yAn9O3+knPDVZudlQvFDNLANFsUco6StH3SktwhaOCSOaCWwA20ZL6RZlX9CKWFMeDQMasIg== Received: from PA7P264CA0364.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:37c::20) by PA2PR10MB8992.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:422::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Tue, 28 Apr 2026 08:41:03 +0000 Received: from AM4PEPF00025F99.EURPRD83.prod.outlook.com (2603:10a6:102:37c:cafe::e0) by PA7P264CA0364.outlook.office365.com (2603:10a6:102:37c::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Tue, 28 Apr 2026 08:41:03 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AM4PEPF00025F99.mail.protection.outlook.com (10.167.16.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.0 via Frontend Transport; Tue, 28 Apr 2026 08:41:02 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:44:14 +0200 Received: from localhost (10.252.13.121) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 28 Apr 2026 10:41:01 +0200 From: Benjamin Mugnier Date: Tue, 28 Apr 2026 10:40:59 +0200 Subject: [PATCH 5/5] media: dt-bindings: vd55g1: Add vd55g4 compatible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260428-vd55g4_and_fixes-v1-5-4f745a83b87e@foss.st.com> References: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> In-Reply-To: <20260428-vd55g4_and_fixes-v1-0-4f745a83b87e@foss.st.com> To: Sylvain Petinot , Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil CC: , , , Benjamin Mugnier X-Mailer: b4 0.15.2 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM4PEPF00025F99:EE_|PA2PR10MB8992:EE_ X-MS-Office365-Filtering-Correlation-Id: 417d7489-aa66-4838-df55-08dea501e15a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: fgv2vqFTN7l0yAPrVLSri9qShhfO8lAYdXBYoclQPZtNq97nSrUVjiPDdvhiiJxx5b5ZaeBigvStR1HB/ECUhS66OpCg0R61EIEtgGoAxlTeOTOl1Ny9KmDLoNWoNgDoZt7+3ktEbftaaXBtT6DNo1Ph2CJuypazeFpcUlbWzmDZ1LfY9SUeAOXcktaHkeWI7cPV5HZmM1pLeIoUeSicUjmlzz9sCwKZPbywgSMoC6xNzl6a+7+O6onhYOFN5XOo/abHniLwRAoj+TC+GHj8RP8Ou0xwXEkoA8YCzpU3ZiRRGDblM7ZOPwhpq2gkuxpHI4Dm0Qnew61lSfi5E2Th/4dW1vt4lY2k/sn1+AddPqkzw0KgqN+WMjaxqnIehPtLC1zS+pm7yby/MAGyzmKQ1vbCPLFrcpkRxKiYa4mxFbrBfZHL4+QiEwaiFz/UnwO8oALoPffjwDgDfqXCfN/GmZKK5quMvvZspzgdfteLWjFB2b2y1V1Hpok5KeZVfQfX5/yly7nk/bo0Qcmb8kfPmjZ9wX2gvd3lo0DSSLu9a8d2P6USf7g7aYF68IghyukMamKHAA70wIrmmUFuMMIfpH0LnCOpt/tt+U1guWeJNjkaIGFESMak2j805LDOJYKUq1YtcxBPjcqGBgMPDAWz0auFinj8QMoR/EONCaBDKfOVlyozagfppI6thkceeKeexkwEJ6099QZF1JNCSGet0+6GxjJ/0/UTIoVMcA6/6yQ= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /pOnszO+4YQy0bFG3STrHyw8K9MjMwY6458g+KqEK9verayPm/64Zu9Blfu7Sha5bOU+v0PDN4HVayKClGPr3eWCiZCUM8+AGwnu+PcRT2DpBBMEd8PzEtPFZyzek//bKwqQ+A8I+wAnMzx5JxRPE1bEpRizjAqQqIANukdpcKyC+7/q5933zeMq8lq9MnK95INZgghreLs1Ikup08KWVM9waGzkMdvqzj9/cykoRmxfLw1fVpOJttM88CStsn2Ou+UWMf6Pmq7lvu06tQPNP5xUovN/Op77/UPjIbH8VwvSViMNAkZxaPxqq74K6wbx88rLq1zsmkyywqOyBhqLZdX2cRqqnfyStKa6Bdk9m4ZJhqNNZK/yJuRbQRE7RLPBOqioGh1G2oqlYTiYGBFg5ShO6rBxa4tZFstS8n9pw65M0HikreF6E4bQhvw+2HTf X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 08:41:02.6697 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 417d7489-aa66-4838-df55-08dea501e15a X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F99.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR10MB8992 Define it as a new monochrome variant of vd65g4. Signed-off-by: Benjamin Mugnier Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml b/D= ocumentation/devicetree/bindings/media/i2c/st,vd55g1.yaml index 060ac6829b66..58b1f9e85a9d 100644 --- a/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml +++ b/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml @@ -27,9 +27,10 @@ properties: compatible: enum: - st,vd55g1 + - st,vd55g4 - st,vd65g4 description: - VD55G1 is the monochrome variant, while VD65G4 is the color one. + VD55G1 and VD55G4 are monochrome variants, while VD65G4 is a color o= ne. =20 reg: maxItems: 1 --=20 2.43.0