From nobody Wed Jun 17 02:50:54 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94D57441044; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; cv=none; b=QwZJJbU6N0It2fjPWIz9brNJGRvfH5dQZcUP0fqZNytOtRC9VcftfBmG2/wu21p0feMN1uj/b7dVKJrIVKDwXJJpCeVVTjWXUvkDRGb/rER3uoASjC7wc8TJH1xWyvXpf0iDyGGfe+hZyV7ZkiKygoCdf6ewC32f8NlMVfnZox8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; c=relaxed/simple; bh=/CFQzyYD+JkOgXFRcQs68j0yNyskvw7AN4256x+Kuxg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gvHAPPij7Tkc15E2pBdDP/8rZ4Imf7sQLfY0IL72kv1eRY98Maeiz/+xQ+c+9GTY262REA78d2OteDeR6HwUgNZ4tvZ6nLf4GZPHbOw94siXHn0g1JhbCcYbFRtB5pt0dmm+qtOgFRDcroJsgqP4S/KAMENYqBST4vRMIwBLFt0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=crOrL00q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="crOrL00q" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5361FC2BCB5; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777382316; bh=/CFQzyYD+JkOgXFRcQs68j0yNyskvw7AN4256x+Kuxg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=crOrL00qlWzBRjbv/PlQgPrY3/qjPjWXKhX61mb9j/9NM+uRuSNVMxr+6ityVBeng gJSt1trf6NH1WqIpMm4jBMRabshMjAGhoVvsIPPRfoJJ5QVlM7W0C7j1t7m1qALzTg wQeZCUGOLmNH9a985Fu0MJas8YYv2Kd6ZcXhxLLKeKn6ZZnDNOaJOYFRwUDRXRwp9Z zrVVO2Hqejgv9Hpqj1K+ZbUiBy3XwrYKG2WYAR+RayVYt/1vCeTukDNc6oRnG3QTwK FOlAQ7Pe/FKlIL87YpT3j8kirobBVvMv7wl4VP/fjoOsQb+P9iQ73rmoauROVeJhdb kFhYgIS6IUSZg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E16FF8868; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Tue, 28 Apr 2026 15:18:33 +0200 Subject: [PATCH v2 1/5] iio: light: si1133: prefer complex macros enclosed in parenthesis Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260428-si1133-checkup-v2-1-70ad14bfefe2@gmail.com> References: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> In-Reply-To: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777382314; l=2461; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=6bHXuqv0VZRabyw8eBUBbiHAH0Nn4p7e0lWZDJyg1lI=; b=IzwXD3G+51okCPZMLIgA2Fpa3SsAVKs9HB3RTlK77OZLv1+9reJIi7zsnk3z2jhRx/kbJZ9+W Jqu3yc6pJC2DBGCu5FRBs6HKYqAwoYQD8nW4Yl70QM9kK8K2v5Ndn3w X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Enclose complex macros in parenthesis per checkpatch.pl error to improve code style. Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 44fa152dbd24c26c97cc778cbe641d92ecd56afa..52e4269dc35014b87b7c46a120e= 64723be716768 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -50,23 +50,23 @@ #define SI1133_MAX_CMD_CTR 0xF =20 #define SI1133_PARAM_REG_CHAN_LIST 0x01 -#define SI1133_PARAM_REG_ADCCONFIG(x) ((x) * 4) + 2 -#define SI1133_PARAM_REG_ADCSENS(x) ((x) * 4) + 3 -#define SI1133_PARAM_REG_ADCPOST(x) ((x) * 4) + 4 +#define SI1133_PARAM_REG_ADCCONFIG(x) (((x) * 4) + 2) +#define SI1133_PARAM_REG_ADCSENS(x) (((x) * 4) + 3) +#define SI1133_PARAM_REG_ADCPOST(x) (((x) * 4) + 4) =20 #define SI1133_ADCMUX_MASK 0x1F =20 -#define SI1133_ADCCONFIG_DECIM_RATE(x) (x) << 5 +#define SI1133_ADCCONFIG_DECIM_RATE(x) ((x) << 5) =20 #define SI1133_ADCSENS_SCALE_MASK 0x70 #define SI1133_ADCSENS_SCALE_SHIFT 4 #define SI1133_ADCSENS_HSIG_MASK BIT(7) #define SI1133_ADCSENS_HSIG_SHIFT 7 #define SI1133_ADCSENS_HW_GAIN_MASK 0xF -#define SI1133_ADCSENS_NB_MEAS(x) fls(x) << SI1133_ADCSENS_SCALE_SHIFT +#define SI1133_ADCSENS_NB_MEAS(x) (fls(x) << SI1133_ADCSENS_SCALE_SHIFT) =20 #define SI1133_ADCPOST_24BIT_EN BIT(6) -#define SI1133_ADCPOST_POSTSHIFT_BITQTY(x) (x & GENMASK(2, 0)) << 3 +#define SI1133_ADCPOST_POSTSHIFT_BITQTY(x) (((x) & GENMASK(2, 0)) << 3) =20 #define SI1133_PARAM_ADCMUX_SMALL_IR 0x0 #define SI1133_PARAM_ADCMUX_MED_IR 0x1 @@ -87,15 +87,15 @@ #define SI1133_CMD_MINSLEEP_US_HIGH 7500 #define SI1133_CMD_TIMEOUT_MS 25 #define SI1133_CMD_LUX_TIMEOUT_MS 5000 -#define SI1133_CMD_TIMEOUT_US SI1133_CMD_TIMEOUT_MS * 1000 +#define SI1133_CMD_TIMEOUT_US (SI1133_CMD_TIMEOUT_MS * 1000) =20 -#define SI1133_REG_HOSTOUT(x) (x) + 0x13 +#define SI1133_REG_HOSTOUT(x) ((x) + 0x13) =20 #define SI1133_MEASUREMENT_FREQUENCY 1250 =20 #define SI1133_X_ORDER_MASK 0x0070 #define SI1133_Y_ORDER_MASK 0x0007 -#define si1133_get_x_order(m) ((m) & SI1133_X_ORDER_MASK) >> 4 +#define si1133_get_x_order(m) (((m) & SI1133_X_ORDER_MASK) >> 4) #define si1133_get_y_order(m) ((m) & SI1133_Y_ORDER_MASK) =20 #define SI1133_LUX_ADC_MASK 0xE --=20 2.47.3 From nobody Wed Jun 17 02:50:54 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8105F43DA4F; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; cv=none; b=Ay4dboX7a05ygSjzTy7Vyj0X7SfSpyGolngrjRRA+gIkjMRF+gN5TAOfw6pFlcFd7zaCVHDd9QR9QvCrgUyGJYjzf37rcMi/TBgX7spZnYXM5C0FjLoWSdigllrKTXAbOIXcmUnRWbYr9Wu+90benfoWTLrot+k9w+Ll68E7WDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; c=relaxed/simple; bh=b6fb23sK+0a50rFQTjadTzLojC/l9EDl4In5i+uOzAc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LaKFxpVjme+MebUe6ZzF0cJQz8AF4m+ymZP+xnuQ1YnGWNby7BoOIVk0Wa91sMCzUA+pxLrn1l2q5PsCBCqLI/RT28ecTUnOQc0+wF0O1YkSAk1gMI/EjrOsXYt98gu0Chiz6HWO4OCd3OjlVMTIjT61lsS1kweb1kNzSvZk6K0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EQ2KtJIp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EQ2KtJIp" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5D33FC2BCB9; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777382316; bh=b6fb23sK+0a50rFQTjadTzLojC/l9EDl4In5i+uOzAc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=EQ2KtJIpw/VCMtWZJ4tlqGFl6RoPEBrS8lbiqdSy0eLPeKoF+R5r3p/HyZDRN9I2i bMgilThA7sjtY6df2zoYiKezhVofKLXHF6pNBEzaU1VKOJOoPfvBpW5LRhqbb3YoZc UddkHiGCeU8lvB4oxCcy84eD15f7RtVGYDo4ntEAucRzxFp7+jHxLMZ1r4z0351HVL fMHahrO92H2JNXJWZJj6bPUSodwiJXvbD0z69FaEhz7Pu53i6oj9lKGSG1ETn4iVsR yHR2RB8Iu8N9GzCERdhxs6pHEDTfQIZ9ILavKo/wmys/YogKhWig8ZetArlaVxq0B7 PJYgEOCYFhbIA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5222FFF8873; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Tue, 28 Apr 2026 15:18:34 +0200 Subject: [PATCH v2 2/5] iio: light: si1133: remove unused macros Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260428-si1133-checkup-v2-2-70ad14bfefe2@gmail.com> References: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> In-Reply-To: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777382314; l=1486; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=sAJi4jzXAC1/xkjwpgVBUUVE/UZJLoyjyYEoIQrqUtw=; b=hPVVeDLOV8wrvYmDq+tIMEfeaEYl3ptAXJXt/LGS8G4hR7bHtDT6SgrepOeucxG+w8S5nHxEV KiaO7yM1vORCirhyPsnG4yM1RPbaSDeHj8v3VzvuhG7O541lVtSoj/t X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Remove unused macros to improve readability. No functional change. Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 52e4269dc35014b87b7c46a120e64723be716768..ada8da122b76c9a0a55751baa65= 22a145f0fc7e8 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -22,8 +22,6 @@ #define SI1133_REG_PART_ID 0x00 #define SI1133_REG_REV_ID 0x01 #define SI1133_REG_MFR_ID 0x02 -#define SI1133_REG_INFO0 0x03 -#define SI1133_REG_INFO1 0x04 =20 #define SI1133_PART_ID 0x33 =20 @@ -40,7 +38,6 @@ #define SI1133_CMD_RESET_CTR 0x00 #define SI1133_CMD_RESET_SW 0x01 #define SI1133_CMD_FORCE 0x11 -#define SI1133_CMD_START_AUTONOMOUS 0x13 #define SI1133_CMD_PARAM_SET 0x80 #define SI1133_CMD_PARAM_QUERY 0x40 #define SI1133_CMD_PARAM_MASK 0x3F @@ -86,13 +83,9 @@ #define SI1133_CMD_MINSLEEP_US_LOW 5000 #define SI1133_CMD_MINSLEEP_US_HIGH 7500 #define SI1133_CMD_TIMEOUT_MS 25 -#define SI1133_CMD_LUX_TIMEOUT_MS 5000 -#define SI1133_CMD_TIMEOUT_US (SI1133_CMD_TIMEOUT_MS * 1000) =20 #define SI1133_REG_HOSTOUT(x) ((x) + 0x13) =20 -#define SI1133_MEASUREMENT_FREQUENCY 1250 - #define SI1133_X_ORDER_MASK 0x0070 #define SI1133_Y_ORDER_MASK 0x0007 #define si1133_get_x_order(m) (((m) & SI1133_X_ORDER_MASK) >> 4) --=20 2.47.3 From nobody Wed Jun 17 02:50:54 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94DF8441048; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; cv=none; b=AK183YqgaTTNYuCyWfvNN7+thxf1bSRDGuRMVdQPgRa5rhLawQORLGBDEvQ4yMyFu1sdSGQ8UxunT449USLOvInHC6jqJlCEmGniVEq7VYoPMAAysi6nnFymrUTmHlUSNL9STpNzeuqsHlcRLRT344xWPoP/IqHzcnGIi2XYZ6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; c=relaxed/simple; bh=Tf9Usd+TGMS4cV9YIAlaKhgJyO0gaGlhJv+u37S2NUs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=peBM7Nz2Qh6bOuxk/8xYU579XeTCBJZSsrDklq+mPCOAAI2r26kONyJnP3s11vCJXQh9Skigdu4ErZjNqIeV1slAG1giXYHCaBmtbqyt8zVIuvh/ar8hfnpy4u2WuIjzFL0mUlg4Rm1GQMb2SxkUfAtX/BJXY3jS84xGuGjaJbE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qv3p3b26; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qv3p3b26" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6AC2BC2BCC6; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777382316; bh=Tf9Usd+TGMS4cV9YIAlaKhgJyO0gaGlhJv+u37S2NUs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qv3p3b26huoDSaatCt2kZVFBUxVlA4zdMezYX8Q0jqXkY/Vpvf7nInOhEgXrElJNQ /9grhgqdVKfvi//nTlj2zw2hEc3eIbuGK9YnvqtCSnjzlg4TGcSR5wboW553CRIHee cBQp2O6yq5Rt9c031skAqReRN2KqRDFJC2FU4dzj4TTT174y9dqHxd+1kcAp217rTv LlORpU7weFJrsWdVdlz7sJd3oYyuhJTyp0FfSHqnS/djrgpDcZfJGwu0GkExWELqxS W5+p247DneHCP1XoJD3AQLz/TQOxuuuwCA/qkUNxc1tJNepyR/0xcgnklMlCIEk7zb tuiCgZhDMpPKw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61DF8FF886D; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Tue, 28 Apr 2026 15:18:35 +0200 Subject: [PATCH v2 3/5] iio: light: si1133: add missing include headers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260428-si1133-checkup-v2-3-70ad14bfefe2@gmail.com> References: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> In-Reply-To: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777382314; l=1193; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=MpzT4gTigdm0pGKTWDLW4wW/fRg5QLjpB5QmAWAztOo=; b=UcUtVPhbosFV6g0gpCRCpa5IQsYlORL0hsqkOwRjauhr1Obz60kEiTFmKFH7l0v5uB4cG5a7O KXtJ+zbUH6xAxNRaO/3lJAvHBgUUT3RgFzevXu7xZfimOYi9uAjdGat X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Add missing include headers to prevent compilation relying on transient dependencies (array_size.h, bitops.h, completion.h, dev_printk.h, err.h, irqreturn.h, jiffies.h, math.h, mutex.h, types.h). Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index ada8da122b76c9a0a55751baa6522a145f0fc7e8..5c5c5ae0535a9592522c0b21496= f47068044c6ff 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -6,11 +6,21 @@ * Copyright 2018 Maxime Roussin-Belanger */ =20 +#include +#include +#include #include +#include +#include #include #include +#include +#include +#include #include +#include #include +#include =20 #include #include --=20 2.47.3 From nobody Wed Jun 17 02:50:54 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AAF2441049; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; cv=none; b=F4ZmwK66krkJSV2W2EFxvc71MLSNA3dfLsli97vltWmoy2sfVLqE0pQM+RH1ZZvaRIxc6koGxspYNanKDsPhxdTsnw0KdK00FzEC8UQNJGOE3qgrNc6WYi5Ekm8pO00MqjdJ4lL6M1psLwiYPzvj45zEmguIqREKAQhSRnntLkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; c=relaxed/simple; bh=3INDDAAeuGZJjvJpNIHDcypkpPRwot8PZrzZ40usoqI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZwXPnF0xq+251ymRAIoccJUAXqPE5K0HKn74P69wzWtvPv22FLhZyL2yJhlT3WLUMmHAo8xAyzb0OSWj3IQnNryO63x3JW1ThqZk1C5MYS7vAlkTAEL/LJNyxXLWSL3kv8BtQCshIV6TSNyM68TsMixWA49tPDcMcvnVblgPNXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UJ9KDjkW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UJ9KDjkW" Received: by smtp.kernel.org (Postfix) with ESMTPS id 7A2ABC2BCF5; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777382316; bh=3INDDAAeuGZJjvJpNIHDcypkpPRwot8PZrzZ40usoqI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=UJ9KDjkW/ZqyzuFBUHaHkqMECpXIuYwbzt/ZzTmgb/E+UBzFTbQO4oHCbN3iqVDEX sGI7Xp1ecX2oRaK/gViHHawpIZXrMv3iVyzVnkllPQ12YTAXXWibcnjTLk7I2dM2fK qaMM96p0VbO7N8xZQmeWeHLX+i3GaZqU8lHJKB0pvTaFbzmV31IHulj5oZ9L0Y4e6A KWX4a/lbyJIT+TCVvR9LHX4bLADEwi9175ZctHAh25jxSIYA5yJ0YYgfHNP4cIlQ9B wRDyt6y7DkI64Bi219mWzewZxs9w1dL8b4SlptLAUJ+kG/oQtmfWMx4Svf0ws2ZY2S wE3MBCxJStt8Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFFEFF8868; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Tue, 28 Apr 2026 15:18:36 +0200 Subject: [PATCH v2 4/5] iio: light: si1133: group generic headers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260428-si1133-checkup-v2-4-70ad14bfefe2@gmail.com> References: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> In-Reply-To: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777382314; l=901; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=Hvej5eqSWeD7xV4MQtx/PHfw5MbA/CGHl9BhtamspOQ=; b=Jq6Mm6BMuxPeRSM/zgyQQlhBls3VQKeMNzAmuCPCkeqSIrBztw1/V0FZ5zaPc4Un2nzcNBwSP S5pD6WHm1qSAwPpXC38Plocga5bLjyIq36kw6o7eBLVti2OJCrAQw1m X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Group generic include headers to improve code style. No functional change. Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 5c5c5ae0535a9592522c0b21496f47068044c6ff..f2a79675c026c86bb56d85a65cd= 035d7540d0ef8 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -21,14 +21,12 @@ #include #include #include +#include +#include =20 #include #include =20 -#include - -#include - #define SI1133_REG_PART_ID 0x00 #define SI1133_REG_REV_ID 0x01 #define SI1133_REG_MFR_ID 0x02 --=20 2.47.3 From nobody Wed Jun 17 02:50:54 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A77884418E6; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; cv=none; b=uyrrZP/E3MdkeD4EiQalI3cQcBBQdet6MlWlfCdTjlswDYnIVXM78rJfZWu0UH3XBrsMhNX2OB+jovdZGzuSORmj5zuaagTSj+4aZnlZB1LWuBTUv62+QGNFLCE96qALJq7apIZKXM2fk6HL/WWVatNgaD22Hk5CbstcAh2uGZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382316; c=relaxed/simple; bh=H1coTGSLtrZl7CmThJiiya5f1xJf3QLNF2DO1wXAqmw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qtC/8YYV4mLUWiXQnqTN3J4067+VA5hhqQGnu+lsnU82vRlJYNCwXSdnhZdC6tld25wFso0y7BookPrCshUXv1cK6KmMTkPSM9c5gXO/LwvwuZwARye5G/W+1DuEN4ADlKI7LySHwVZrtPuTAdmgEXgU3dJlcYDvLuM7pQlB4RI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lhlHHsoj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lhlHHsoj" Received: by smtp.kernel.org (Postfix) with ESMTPS id 86C6CC2BCC4; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777382316; bh=H1coTGSLtrZl7CmThJiiya5f1xJf3QLNF2DO1wXAqmw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=lhlHHsojD85BUf5pxM9k/qyq/w0b6CU1HSLc/5CIfSVQgCYQa/h1GsSKdv7eI+IUC IY81ErRVdpJ9eHHfIp3wwytDKVH9jxxFQOTqojkGhBMgg9GCNTbvGcNpUH0WahIZhl s7fRBdVubUNhTLyfnDYLQ8fG5wmXRXo5KVPf7JFfwcVIkontylS2zF7WLFUb198SEd eA5Hl8eIEig4ifrG92kt2hwrXt75bT3/dFMn1HSd9WjoPB7oujxYmqg2Y0rPTd3/l9 LlEsKxKHYeGNv4liiDlTg0JQnSrsmUC2aLsWPlKjzzOyZIMzBHM149TJZiMkWObbdK 3YCf6sY4UKAsw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E592FF885A; Tue, 28 Apr 2026 13:18:36 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Tue, 28 Apr 2026 15:18:37 +0200 Subject: [PATCH v2 5/5] iio: light: si1133: use guard(mutex)() macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260428-si1133-checkup-v2-5-70ad14bfefe2@gmail.com> References: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> In-Reply-To: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777382314; l=2115; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=GjpeLCBEZ33hvOHDtnqIc83HA4qlDRcZtYHurZdxMdI=; b=HCFYRM9n+KCvW2xqz9Qnj51nvSA24dcEEA4pWjEHT3GFVF3EdbP3iNYGKAVauKaBRRHcW7TRt QhsGncuxC4dDiIbkyMyV+uv5a4tevbAtFiUk7Y/DWAjxkw+M1EoA9SF X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Remove mutex_lock()/mutex_unlock() and goto instances and add guard(mutex)() macro to modernize driver and improve mutex handling. Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index f2a79675c026c86bb56d85a65cd035d7540d0ef8..3b40defda383bcbe731dc0b4139= 03e0267f03b01 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -8,6 +8,7 @@ =20 #include #include +#include #include #include #include @@ -392,7 +393,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) int err; int expected_seq; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 expected_seq =3D (data->rsp_seq + 1) & SI1133_MAX_CMD_CTR; =20 @@ -403,19 +404,17 @@ static int si1133_command(struct si1133_data *data, u= 8 cmd) if (err) { dev_warn(dev, "Failed to write command 0x%02x, ret=3D%d\n", cmd, err); - goto out; + return err; } =20 if (cmd =3D=3D SI1133_CMD_FORCE) { /* wait for irq */ if (!wait_for_completion_timeout(&data->completion, - msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS))) { - err =3D -ETIMEDOUT; - goto out; - } + msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS))) + return -ETIMEDOUT; err =3D regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp); if (err) - goto out; + return err; } else { err =3D regmap_read_poll_timeout(data->regmap, SI1133_REG_RESPONSE0, resp, @@ -428,7 +427,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) dev_warn(dev, "Failed to read command 0x%02x, ret=3D%d\n", cmd, err); - goto out; + return err; } } =20 @@ -439,9 +438,6 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) data->rsp_seq =3D expected_seq; } =20 -out: - mutex_unlock(&data->mutex); - return err; } =20 --=20 2.47.3