From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F7BF37C939; Mon, 27 Apr 2026 21:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326113; cv=fail; b=KeHsh3Qcc5B+3UvmwySorqtXfnwvihaUCVAT3tovM6fU2gTKGm6OHk1H773MrPdHLSbk2R9gyrTi7Xd+/+HqlDaKyq4SpWCKwCHPpXhUX2UByVxlPU0ho4FreE2GT5Gem2jlame9sY7f0cuu1NPDmEmzgRn0wPbAqQkhlmVbDhA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326113; c=relaxed/simple; bh=djiLW62A+9+XHsg6ekXJjvdMvy7fp7CTHANd+skRqhk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=WrfasYnKoYGU3wI3iF7hbb26mQQvLOJn+LVEv8l4JTU+KNer61iB4KwD75oNbj6z0B9Y83ydmCpZrMTLuiumHzhv/O214LmxYffpwk3fZ9HogsaXr+z5Y868jd4RWQAwnsOQWhsVQp/dtd2seCCiGniv9u3oIPr1YNqyrU48chA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ey1tjxvj; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ey1tjxvj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QeJjnRGfETn4MvVW57obZD25CK1dZPGpAyFvDQFTqGe+r3/5RBoewBhlUqJ5cA0l4MAaquUITtJf/gY1smbXbo+HLlfnidC+H88j9irv+cCPTC+wK2U7f2TH9NUsgRo2wTZ3FPzVS5FCvsKNxSompuJjUqkiFYuWRiHGpNUOK1xIpH4a554UVoOmT37EIBsLrQ6TznN8EhlLXPFTDOuLF+lb3VR5WNgiR2QN8lLBLsArRpGsSAawqBXBZrzf/101Sg/EXthvdXSVi7EkIy4oHVfyETrZwOj8xSnNOK949FSh25MAg/lKyaZBd4W88klxODyrMhwtF5XSscv7djWO0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PF86IjnLk7u6qiOLwmi5ggjeNCS4nXYc5WQ5CMAQ2Jk=; b=luVd6ZCcTVJ9+wdQQQuFgZxUa4MAOWJc206GATMOBc76qE7rGuj7sMR9YFvtA6DHY3S7qwPgI8qWl8eHSVr/ZT5cDEvElw43OXe/W6bZRtOhGx0WDacGHkfee14ddYuo507HS1HSQG8WuO4Lfy9/uE6HG3ZLJgdxGMrS8udATkG9Y+ZUIQdJN0x1FMJIXODMyM00YPrK9x28XLGWsaCDMckaC2kTM9Vjg1cYEt7qUH8POfeDhMNO3nmgeNwduxJvOKyuB4kNuo4wDr/VG4lVYxmKMJWxsZAcqYb3aIXGULOFx0O3tk6BrxXEfdivemiBbON9s3p1cWULo7gmHsA3Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PF86IjnLk7u6qiOLwmi5ggjeNCS4nXYc5WQ5CMAQ2Jk=; b=ey1tjxvjHWQiS+vTWg0tf1e643NLldxgoDUZNxjP71/sC0tBrq5s/g6VxZft2qTaGD2LU2Wv3JSLunrSyCp/l1wqD/fPsnp/0EzTtInf0WQmdxBh9+9HgIj8eBV63jFDQ7LS+LlSMuH3GPx8xr/vOxEKMUzHaSoCYDN5QdptCWtkWkj7PLMYVhFzn7THAIfgrbhzPq2pCF8DTa3A6G/9ADNGNRaSzbbqpK4dzMzFmc85PAARvh79A0815KNhGFWvYmfFaXGRyBjwey0Fcs1SUfwSv3BFNWk+6c7Zpn1BUf0X3y5ur+Rh4Wbwjvw3XLQq2JZFlmHCWN4erStZrQthTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:41:46 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:41:45 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 1/9] bitfield: add FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:18 -0400 Message-ID: <20260427214127.406067-2-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0117.namprd03.prod.outlook.com (2603:10b6:408:fd::32) To DS7PR12MB8290.namprd12.prod.outlook.com (2603:10b6:8:d8::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: b6dc1d92-cfdd-483a-2fd0-08dea4a5c736 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: h77wBTyfXpAko00N2CmGlWRdJ9kLR8x1mHhEKT9aGsbGGG3EQX240nAGxcCKHJmyd43qBxBTZ/+9/prS/3X1B/0pSlIDizzJAxkjZnYEUKNXEuJGK3irPXCHekI3Mz3sTyinNFmJj5W7hfUjKeWiKdIVpoMQyKW/LJIBMMeFCqRt0vbRjKQnIopHq8VBejRRJ08azrhuKJbXkJrr7rrdsK0HZ3lA3AKOHUyNV9VLzU2YmGmWZJUsF53GtWHIgVWya8bMTiF4iHuh/0CkqT6fHUq8y9wNfxStH6ZJc6suU3seFWF0zQTbfSa09XFsTyAWKskaiB9abLR4Aqxa/x+uv8PZDuYoefRcBmqs3fEfCH7jKRSsAfNbj6xRiRe64N634JiNgQPwGGvy7nlUjZP5Bnex+i+tOM3fGBbCtsuv8lIayuBfJapfYrYPHxaH1bVqXObbGgdeyqvQmsnn/Xuy6Lijb9fUgOSEdn81Ajpn79QilwYu7d6Vfabj7kohTZZkHu035yl5nngQuxoihkDQulCz5zvy59wTQ5hGPeTGRC1EzdDLdAmn/BgX7bp6DbC7GCtEoOjAWvRqCjdXAnt6ZQTZNqfb4hcc42lxjhlMhx+Y6Jq9HX25Vgm9BAQJMOKq7wIOSABGyHp7EzXAWV9HmL1ag4Ge54B2IApVMz/BzgCw3gxcyfalNCbsCvDHTlDR9/XhJzxgar3n7o/XybRahB4yp2zdhTJXS6tINNzm9DwyL36fukagalCRv19j+dJswgFKV14BBG7E8Fugpi+8wQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mVALzdwk70NZrxvyQWrvj45+MRNCVUc7DjMjFjnQtyKu6n4qIGQz32j/gIe7?= =?us-ascii?Q?woVt++3j8FRiUt98ivtAQOHA7wAiKTjl1rPSZi0rfn4cdqqBxI+/6jDeRGlD?= =?us-ascii?Q?UZ5Od7Hp9MCVJt4FCzRpzJnM5gFuq2I/guMMkOV9GguFHdJbhZNUPQMFrH+l?= =?us-ascii?Q?iNS9mGGsm2qTCJEgz0tjG/eq+/cjhp29c/819ULS7V7ikYUW4N5j4aMe68ho?= =?us-ascii?Q?4U5ALmebSwTvPvhtOglubRI2xXDEUHDdZHPkuy3IOSasRPS5KflQfAgq2/CK?= =?us-ascii?Q?Z4BUWfhCxCz0DMBaLCpooUgwv+BoNDIjaZxhgCr8UoSIGQe9zPF7A8DL5pj6?= =?us-ascii?Q?wj2zadgbsHDiPHjZrrKcKS3XuJNtZz6SrmXwYWfUL6QDSW4BlYTY0rOD2zB5?= =?us-ascii?Q?GFvP7HqJ9tHv3elIiVmfv4Nq92qWZf1UwCGt4NMf7M05h9NhaqePlf8a+e0h?= =?us-ascii?Q?TnlB864bICpSc7Qn0OalgmErrvAKQU14e7qo99V3kfEjWl+5nk8EZAMU7kzh?= =?us-ascii?Q?i5rJ/Sg6L59zDEfljhdo9NXJX+GLVW9jgufLQTu+/XCa/hGQD1T+y2ZeaFUZ?= =?us-ascii?Q?rMfn7mRUYVOl5t0FgWY+FRhwMP74MjJgngmKiEL5kyoU4HnJdsMuEgocR6Dj?= =?us-ascii?Q?GT3UoodmoHRmBSft+1CBmMI5oMsGnPqq5oj10dPZpmVlsVux/8lffFFh/sPa?= =?us-ascii?Q?4h8XFf4dEbEKs6d9x45vnRLk8EMxsO9LOfI15Udg3kjTg73wr5YSTWnCRyQa?= =?us-ascii?Q?F45IpacpJa6DDWM6qen+ygfccCiBIOJ06Kxe5HWogSumltTk22ZxtkzzCSPs?= =?us-ascii?Q?rsbaehzkeyneZ+d9juJY6mK6EB3zhagLoW62kbfgh+tY2MiHOA/nyrof2jO7?= =?us-ascii?Q?CxH/6KxdtwkwGWFbgmblPMvAGQnUnMQl8XWzdcH6jXTo1E1NYfr5JVP3Xn0L?= =?us-ascii?Q?Jy8b0DX+cYGOmp0YmCiTt+QwvDVUS69g40+lBtkc5wvdJN4XiKIRQ73OGula?= =?us-ascii?Q?sm3Xt/skMSx6jskG3s6/9W+gRQLP9Iz6xHU1uvpyCMhRZDttgJcCPurlYfdn?= =?us-ascii?Q?ZG+yT1MTwPgI2FbYDlyB3T4iGYQdINV4kylUXFkz9hqCJg11ouVBAhP4cjQi?= =?us-ascii?Q?nYxEi5C+fxBDZUbzBGoy6r9mp69Dkjo8HEkZXKZVt90w8YntAEtcvoBeVkST?= =?us-ascii?Q?5Zl0Awv6zkdXBeyASc4Pu9bFqaV7LUnpg22bhxVLzoI3VyyzmQtS1obkJQ4e?= =?us-ascii?Q?1sHiTFfVgUVKTQEhGmYdooHj/x6zDXru6W7Q42ETcb0+CtD9Xcy/Ys010Nh0?= =?us-ascii?Q?/V2fnRptOuHN2LLfhdoaFEnNo1eOB9Hsw6UyolZFp2/WtSYdNgoAh9ZY+kU8?= =?us-ascii?Q?V34GiQn5gGa9EcRTlnSGDuXVSPqtvJ1qak7Olp5OrUwu1LBzNjexyNDyttuc?= =?us-ascii?Q?wDrRznGFs/EWBc95XRMI6E0KY2kQRbYqMsdXTUeanX/+tcPYkw79Xj2RF+HW?= =?us-ascii?Q?2yonfL0CTerNeBNTu/jL7dWLbRBq0lxU5Sr4hsNhjGXnyUapjxNlZSXq/C9z?= =?us-ascii?Q?ZwatzTLzNGSKSEAIkPSBFoECpNDkt+oJo3lod5LaprMncJxaV1OEYv2SyYIb?= =?us-ascii?Q?a6AD7stCj8Fume9JfMHeFNtHbjOadw/4WatiuGwp4i8lRDmreW3O/gJdz1uf?= =?us-ascii?Q?3NEdf4CJL9S/T0wcHQbJ8bYk+6IMOvDdIQVqYdA13qhiCsCN9UObY/eSNISg?= =?us-ascii?Q?s7mX8+LfCyEL11ROUzLKVxv24yKM/jS6FuMbVVwjrbhsjzZ1m7Gu?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6dc1d92-cfdd-483a-2fd0-08dea4a5c736 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8290.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:41:45.9215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HtginAblZ4qsYaPt8R0D+8pQWviedceo0YGFcI7ONgObNlmdsofNqYU5zj8QU+2MT11J89x8hZedpxwtrv8IDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Content-Type: text/plain; charset="utf-8" The bitfields are designed in assumption that fields contain unsigned integer values, thus extracting the values from the field implies zero-extending. Some drivers need to sign-extend their fields, and currently do it like: dc_re +=3D sign_extend32(FIELD_GET(0xfff000, tmp), 11); dc_im +=3D sign_extend32(FIELD_GET(0xfff, tmp), 11); It's error-prone because it relies on user to provide the correct index of the most significant bit and proper 32 vs 64 function flavor. Thus, introduce a FIELD_GET_SIGNED(). With the new API, the above snippet turns into the more convenient: dc_re +=3D FIELD_GET_SIGNED(0xfff000, tmp); dc_im +=3D FIELD_GET_SIGNED(0xfff, tmp); It compiles (on x86_64) into just a couple instructions: shl and sar. When the mask includes MSB, the '<< __builtin_clzll(mask)' part becomes a NOP, and the compiler only emits a single sar: long long foo(long long reg) { 10: f3 0f 1e fa endbr64 return FIELD_GET_SIGNED(GENMASK_ULL(63, 60), reg); 14: 48 89 f8 mov %rdi,%rax 17: 48 c1 f8 3c sar $0x3c,%rax } 32-bit code generation is equally well. On arm32: long long foo(long long reg) { return FIELD_GET_SIGNED(0x00f00000ULL, reg); } generates: foo(long long): lsls r1, r0, #8 asrs r0, r1, #28 asrs r1, r1, #31 bx lr Signed-off-by: Yury Norov --- include/linux/bitfield.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h index 54aeeef1f0ec..cd44013281c7 100644 --- a/include/linux/bitfield.h +++ b/include/linux/bitfield.h @@ -178,6 +178,22 @@ __FIELD_GET(_mask, _reg, "FIELD_GET: "); \ }) =20 +/** + * FIELD_GET_SIGNED() - extract a signed bitfield element + * @mask: shifted mask defining the field's length and position + * @reg: value of entire bitfield + * + * Returns the sign-extended field specified by @_mask from the + * bitfield passed in as @_reg by masking and shifting it down. + */ +#define FIELD_GET_SIGNED(mask, reg) \ + ({ \ + __BF_FIELD_CHECK(mask, reg, 0U, "FIELD_GET_SIGNED: "); \ + ((__signed_scalar_typeof(mask)) \ + (((long long)(reg) << __builtin_clzll(mask)) >> \ + (__builtin_clzll(mask) + __builtin_ctzll(mask)))); \ + }) + /** * FIELD_MODIFY() - modify a bitfield element * @_mask: shifted mask defining the field's length and position --=20 2.51.0 From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5384389118; Mon, 27 Apr 2026 21:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326115; cv=fail; b=ZRKOjBTMDEKXFy7NNm16pR5RsEoakpWkOkGOMJ9F0BiBhKgaNw2oyLzE++FLxVnrHKFBH1y1d7EL+pOoOozVYdrVWLnTLEo4DsUemEBLrLlqkHCt4qdOtR1Y3cRbn8KJLoZlTb8AnFsfe0YmKr8JLucSPqrgjATUT0AZuUVZCTI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326115; c=relaxed/simple; bh=JgZUpkqORJEtYDfMecZvPdn5eWws1MP5JqxnU+z1rNE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=iZRmkRmFFbv8T1u0BjX+lVa8oJc+SB3TYX7tlnmPGuEd3d2F2Ry7wWeA42EV8G62RA0rXVK0OE2eh9XB/FWPtG0Ll1RjJiQcRsfwAfU3BhTobbVdcQeiDNHxn5iaYg0CwSdb3Y41Dv+mE5Wl7RqddbkOCXL3POP3aLyFSTYtjnI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qESWIM2i; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qESWIM2i" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hUe9CQyyz7hNX9m2/UoBVMnzstS47fy31TOJvEYGyG7t6HzLWnmTjixDOpZi6Db1bED1JUHsK+8nM7Or2xNkoJcIT6P2fMsNXNwFrJXh5S692uRBHn+BOMq6NV6cyaEmAYLKjI3mPO38sMLhscxjDwvFQ1srpIbKyPCq88z2abKG2p6WuzCN1v31OzHj1phvsVHCpuMO7QT1gXJqtnno8de9GmkI7ppjmAP4NNZbPoXWwWrr9C4+T7BZaGcQC3qPenxJwwWOedfwr26gmvoecwaZP7gerFg8LU04Ota5cBppW57UVAmQGa6y0o6M98ne9am6zNv4Ru/+sDCVPAE2TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2B7QScIRqTIpMKMAiKDKrhaAwGkL8Fxo+PAeS0sBbeA=; b=Nfz8h8BZcUwWNbIFggZHLY4gUWyH6p0pthoIcHLig2sIEb3tDTR3NUULOG8C7d7K7RnQb21fqz7maT6KIoBRU0lZSFb4bdlmVkgO7lTURzJhci5Qvw7h/zR/M3yUFc6y3Qt+LWr/yaaD9LRmte4nnompa8icGw1EGvwsFTCBKx/Drc32CKJvCOZuuNFEbxC0BfHQOtz6UewfaTLKkZHhhSj2DvcLe7H0GVVSsu0UQxm7SQrYoMgndxBZGQ/dDKShOgQh60sq1YR1AiAHRzJ8CsDahB6hDLGdV5QyK9RjWTRcsgWk99GAuSsOltZMKiZCAjreNPqy6SA1hyEzwuiS7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2B7QScIRqTIpMKMAiKDKrhaAwGkL8Fxo+PAeS0sBbeA=; b=qESWIM2iDxKtWj8kCS6BtHj4Tuu4IzdoNbE0So2Ay8/eTU2XhEngocELrYhjpTmrBp/b1A/zCwFQFOzBzKk99qFDaNBuujk39oLvUlTxzSo5rfQG2jXw9Xu/36WQNbXzWQRcwFaP/gqT4UR3pvTARnGOs3LmP9EH0clpKGRUdlFogeaK3x5Xsz/Z7XzFgi5qlCTp8oAr8U9hSZRibp+VVB5hdJ2S3fuOW/PymBmECuSM7XqLipi4ykGb1E26Ha84W3x9U0b6niehzH6R7jcP4T7HY6q0mBRo8O8RvamXFeqxG+yxr77fFWhnsDG57UJuCKJVuGYSJQ0bXc2lh1G7yA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:41:48 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:41:48 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 2/9] x86/extable: switch to using FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:19 -0400 Message-ID: <20260427214127.406067-3-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0295.namprd03.prod.outlook.com (2603:10b6:408:f5::30) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a3e0f26-b4ed-4e4f-1c70-08dea4a5c910 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: 4kNZ/9jpAB1V5uFVHX7WgbVmNDQWfFlE0c1+j8RDyGbYc47l7CdrZjr6fraqZutKRjz3aYh5JqrEk6hkSFZq/GXvZMu1Pacns7ZL+qJSL7/CK0tWKrRkFro7a5DAVM3beC34CT8/vayTp9HP3Zdh5sqaP+mrDseyxh8VpPHxIL7TrR17N0yoNVgslgpAlFBEdth3L3Hl5n3bOuFW/JiLuuzMh34g5NV4Q/ThGBBrcGCZBVvn2v2claNF0WhFK4b3buJkMufdfHe4Xm2BBgontXvRWgz5iH/7ZnPl41kYMAQihMmqykXp8rQruH4+swHYcFABPl1KOaL4tOLPyfHNcE/czP9z83FS1sG63wSc2z+/hsqph7vGtpksC7LI0ky8KVAQAYB4mENiyoEJScx/ghwbW6dyN2yumOlA8R89cxyTj+mjF5OABPhTEQttfYQI6CSjLzlSofoW/9zQJxgyS1DkqnXYIJaCcd/WfVVI7Aun7EDYTivYok94hIkcUf7Y1QDZOu/dpraae6JoUtA7KcUQDbgSA8j184FYLE9HEAfqgkzculRjU1AjoPlVL9dx+f7btihbFhiBzz4rrxRFF4iA1/7LDFmrJLJaxDx9+qD8tTnkrhnTzhBzPg0T+UrCtNNojX8QA/j3OmgeWEWnBAQ8BGEi6rVquLcgX7OXO/FGlX3qEw5I7XRkv256NVeXkExD/aGHKaCuJ6+6K2934u7THMzGR6vRy1DWJitbnGst2Ea9vAIEtJVisL11i4V1+FzMZXhTFhDsarQH9hDlmQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ap6tQTJwXZMX/+MofsBmCxRDGMeiT9mpDiOt4yPsG3yvboyhnS6YlcmTU7LT?= =?us-ascii?Q?QgJ9G2TKFe7psjoFfix4j3YQhU0HTfY/pyiLvpgjSHO7QhnvAz5WaeTWkgRh?= =?us-ascii?Q?7ek5+UxcfjEc0ge9kbaOEGdc5V7X330Z1BP+cMPRltBt66UGXeqv3hu0Ks81?= =?us-ascii?Q?csk+PbJVFAVnJfa19y4cTswBPmas97NLxxoJxPm4YKXXbcF1ONsBBctT/Tl1?= =?us-ascii?Q?7/RW/g/bQm8DXXR6LxV7+bdqa/lpAMJHdnIGa4a39oG7hdIgKb1/yyGs1lu1?= =?us-ascii?Q?9VbniQA2Fw9m4adGYf9I4ENLSyrHUjCWD8fvSe7JBKNR6wWTweuZ1ZrOsS5h?= =?us-ascii?Q?KadxZVcQEgysS6hKGKY7N9+pIGab4GqKkHo7Jv00GErkUcrA5aokpqbtxs2q?= =?us-ascii?Q?EaNcpE+ezguqccsuqDGLe5UnRWECaRsoiIylfwQmPPKLSvVaxcLXpki5aNJf?= =?us-ascii?Q?QpWqz9KKrLowykMfVJFGVfOp1bd7pik3UP0RoXzQQtuHJEDyQlUNkb2nnNvn?= =?us-ascii?Q?Kx+BmGmTrt4mugPC336GMmJbzYahALbw3fX/elVV4NCbjm0/AFLEydHzEPen?= =?us-ascii?Q?Gcm0M2FwPTw39rJb1GVJErQU8gURUpqZTvrOhcEm2Uvjd3ADpAGEGTnIjCg4?= =?us-ascii?Q?lKyGO2gAujSWmhNpt1txm5ytps3stX0JMgq9IWVXlCLt5ZmN4c0b4CGFsGnC?= =?us-ascii?Q?nGz+H/Fdj/QA4bHWMOvuof9YWk6MLaC3ZJ2Gq/wcyBY0GjSQe2bmviB1S7AO?= =?us-ascii?Q?JNCbRvttEh2bG7v9aYXdtdyOsGanCUJpIz1kuh8KnBzq0ESgU4T8hUxvQK4D?= =?us-ascii?Q?NcgvChazFACbDaRg0VHFsHM+5rU256/2pLnbKj5xLkpMjU7w/OJuebnYowEC?= =?us-ascii?Q?s3fxn5DWS4PueuAmdAUzBbzXcoNdvKV53sC5//QyLmEIha4YTjmlhGw1USm8?= =?us-ascii?Q?2PrzHJ28HWB6+bOW6tIEqPsQFD6EuHnp1htn9cQgPni8obGL2Jk0wwzHsyW9?= =?us-ascii?Q?fUkSdGpV/FNBRGI5QOR6fBDDP7DyUMqhlJSKlfKmA7m89urpkpR+bA0gd7RY?= =?us-ascii?Q?s5F976KU4YKm4JfFaBQtXnLYbl6B1//3cq6U/VVyGBSgPMvPlX5hJLe27tV9?= =?us-ascii?Q?26jkBx/iBanv1OD5/lM8PfdJ9ESFjy70oi0qNpwRvu1h0fMnLP2fUhDlbA5p?= =?us-ascii?Q?xDTxR+KijF2sCMCloCjskK8q9ikEmPrEjo7JOYxFUQ2iZQQ+eb7FFfDSnonJ?= =?us-ascii?Q?a7R9P9y/+hwkvvV15nrRYhIcvFb/btf4GW1pwGCJc0b6eca9YTUOTJSlwiY/?= =?us-ascii?Q?UUv3Fe7s1JKw0ddFkFK6yM4iTYyphCEi+KKxoBSjB5M752EXyitHgEj+dB72?= =?us-ascii?Q?v0zcjrVi2YfQNSUlpz14HI1S5h59qnHAE9p3UX2aHMWpqgsDUZmGa4AKxGuU?= =?us-ascii?Q?9CIvrmflxy7zgL8xelxkbIn0jPhVbIGm6lYxMCmCCs5IQu9AUra9xY27hE/d?= =?us-ascii?Q?USt0TysamSRATmnmgbgswFZr1i1W0WWOr4KBQzj4nJHzEx/D0clnlohEwV1n?= =?us-ascii?Q?5F9dzTNqYs7TBZs/ibvIlylYBiOgRY5FaXWwohePUCu1IloVU1gq2FAmMaeH?= =?us-ascii?Q?37LnQi9QxI9sy3WufWbRMjlC30+rppx/WjSQ4PdeRJ+zF4w5bx2PfCLRhc1h?= =?us-ascii?Q?OrJO+mbgag8dYIY3pG6r/kT9Husvn9c1lomNGsENUt9uHtC5gj6KyBpNFAbD?= =?us-ascii?Q?9uEH2xRXWf/SVbYKHoS6t64BPstmvD9Q3SJivHZ492Vz0fxgw3Hm?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a3e0f26-b4ed-4e4f-1c70-08dea4a5c910 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:41:48.4995 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: soxAmvf61Vjqzh2vvmEVGaCI6C1EOVPvv+sx1g1oJZDiz2GbdN94a4VLYvOqu0hc0XPWXL/KjQWpRoRaKzNisg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Content-Type: text/plain; charset="utf-8" The EX_DATA register is laid out such that EX_DATA_IMM occupied MSB. It's done to make sure that FIELD_GET() will sign-extend the IMM field during extraction. To enforce that, all EX_DATA masks are made signed integers. This works, but relies on the particular implementation of FIELD_GET(), i.e. masking then shifting, not vice versa; and the particular placement of the fields in the register. Switch to using the dedicated FIELD_GET_SIGNED(), and relax those limitations. Signed-off-by: Yury Norov Acked-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/extable_fixup_types.h | 13 ++++--------- arch/x86/mm/extable.c | 2 +- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/extable_fixup_types.h b/arch/x86/include/= asm/extable_fixup_types.h index 906b0d5541e8..fd0cfb472103 100644 --- a/arch/x86/include/asm/extable_fixup_types.h +++ b/arch/x86/include/asm/extable_fixup_types.h @@ -2,15 +2,10 @@ #ifndef _ASM_X86_EXTABLE_FIXUP_TYPES_H #define _ASM_X86_EXTABLE_FIXUP_TYPES_H =20 -/* - * Our IMM is signed, as such it must live at the top end of the word. Als= o, - * since C99 hex constants are of ambiguous type, force cast the mask to '= int' - * so that FIELD_GET() will DTRT and sign extend the value when it extract= s it. - */ -#define EX_DATA_TYPE_MASK ((int)0x000000FF) -#define EX_DATA_REG_MASK ((int)0x00000F00) -#define EX_DATA_FLAG_MASK ((int)0x0000F000) -#define EX_DATA_IMM_MASK ((int)0xFFFF0000) +#define EX_DATA_TYPE_MASK (0x000000FF) +#define EX_DATA_REG_MASK (0x00000F00) +#define EX_DATA_FLAG_MASK (0x0000F000) +#define EX_DATA_IMM_MASK (0xFFFF0000) =20 #define EX_DATA_REG_SHIFT 8 #define EX_DATA_FLAG_SHIFT 12 diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c index 6b9ff1c6cafa..ceb8d03191ab 100644 --- a/arch/x86/mm/extable.c +++ b/arch/x86/mm/extable.c @@ -322,7 +322,7 @@ int fixup_exception(struct pt_regs *regs, int trapnr, u= nsigned long error_code, =20 type =3D FIELD_GET(EX_DATA_TYPE_MASK, e->data); reg =3D FIELD_GET(EX_DATA_REG_MASK, e->data); - imm =3D FIELD_GET(EX_DATA_IMM_MASK, e->data); + imm =3D FIELD_GET_SIGNED(EX_DATA_IMM_MASK, e->data); =20 switch (type) { case EX_TYPE_DEFAULT: --=20 2.51.0 From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E32203A1A38; Mon, 27 Apr 2026 21:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326118; cv=fail; b=rKSaiNSB9Dvrb7Qyyln5HHmHcO2ZhHCx8PoptHFaMvnNwHYPqgLbcu9uoicVk3e02tzbvs+FL07zayhJx6cPjCzwDaR0Q4L/SGZjOiLoroH8A5Cqv5esJxRoRRCLCCFD/nhCLv9B2dOTm1gvn608l864p/t1jbeVCi1oOGOBrP0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326118; c=relaxed/simple; bh=OGauGFrFwsbMvkpucrRq5bHoJWBG6JyQpgOL87nuGog=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=PbBwIuU9kc19tHKUDZbG5s4wv8/M+dnwn66jbTuQ494YP6GN0sKL3Ve9SdHV9iHi0ohdPW/iBPIsfe40QOTQLiRSyJuP/0S5lNgT7nI14I2qQWQdtlwk2jQKD+wakXDHXyWd6Vm4LoBG7DXHLVMVZJFcOd7o7O11gco1/K4qavo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QUrrEeMV; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QUrrEeMV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V9gSJscSM6bWyucUYrw5g91c8oMiqCzzU9WrFTQ9/PbF3mT6Xz1DNYjnYLFkwgufPZ12nmJ1xSM/c6/XqRuI3m0kpBjoBVHhullpx0dP7pJFXD+QUjOLFWAVgDcJUXGMVJQQoFKv5D+1yIDnJ+v63osgfmp2kwap2bLjHMqkpzTfTIOHT3W7RV0o56ZwOTelKtcy1JQkRWPWkM6mZQLCETEpzjfvePLSiHv5kH58igxrLGdBOZdqcNO+isjYWQlpiat/8aTpFC4WXLEoPN7zdvTQs6tozG8jLovkMId1TeOicp+lMcGyE0d22OFgVxk5uAFwKLbjVtJogqLJ+WIInw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pu9qYdnyxhQydpo73rWHpYD/2ko9Ex64kwBwjZoAH9Q=; b=SKZgeAiHlBD6IV6R89CuHWM64CiUwEJk3iu+ULUq5gTMYV0wg9yrNfWVILLjPOPfWcxlFl6qjxmXaAFrY4SH47DQkSpEEthN4RG2m2azZ3FcPLs8GgKZvG8mi1FEv2K6AmMbLeuAqmmKvm1kUN0flc8qaelco01Ebtet6lgbLhcBqjiZqKmuH7s0RlpRB7S3HFHmj5lswFIAU/3TUyQZX9scCmh9+I1DfSBJBIZFD12TYIUZyVcjy3ZlZ4eHCG8DomeO9aD8yyai/uIvE6lQfzGXdEXILb9a1I617yoJfYLo4UIdMXpLWk3TKwjft5y9/5ZO6daXilhxJDJsqFysfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pu9qYdnyxhQydpo73rWHpYD/2ko9Ex64kwBwjZoAH9Q=; b=QUrrEeMVLvqYd8ZJmp0Gsuh2QF+uvTn10nljXcRLWjsOBgp3YP7EI/4EyIwosBzEDaEzS95ruWzR+vGINnsRyXEb8h83BfM9ByWV5ExUQuJ4Fgug9YpEZXY7Pru3wlEuLpBgHrJv2jX+aVSOhxLQFTy+HftN/MV+r7SzShWer+Q89jGr9FsslPJuLA/5Unge/ls9jE6eglQ+nRg6dATcNdEWDa5iCdAAus6BFVbAFHahgq+CLnTzuvC580b2C6DN9gk/tANlltHU8ETk/2fq7qQ+tBB4EdGN4EDWA0gx1Uf8Q9CNAOQoinFUS044EEZTPkmlcWh7CWx4TaJ+9AQ0/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:41:51 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:41:50 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 3/9] iio: intel_dc_ti_adc: switch to using FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:20 -0400 Message-ID: <20260427214127.406067-4-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9P223CA0024.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::29) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bdc7c79-e92f-46f8-c540-08dea4a5ca77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: JzctzgQgbBtmP7fa8G+7UZJH2OZkQ3ZuSoosilH8Tkg129AA7p60WuhHNkJfSqQfxTQubvuoLVQu2prHeJSgTYsYDpJpYByV/nI/gw7OHRE01gNPm71tqoBMWtYLZ6lKpjOs581Y9jXGg+lPfCOcNEHEJoMfvKUe06SeRxU75rsE5Efp2yOuljpEralJC4TxIYMRrN9kBSmFScy95ysMfiyE2QxsCE6x4VB/mO76L3qfYuuAcJukpdsTPXkb8omNqk0ZwePPW+XYi+iH8pFXrpNtsqzCfbV6u+2NjtgJyGNi4rRLDQ+vJkdyrRI0jaX/kBTnmQhtc7d+KRXtBiiRRCEnM1Jxhl7tgTubhBdqynkUqksdKXyYd+joRJPt4NXE7Lxev2DtWSKyjjak3osOdrHbX8y0MbXLhxotJcTwFO3yjyji+NTh9Lw6fSJ4OaktVow+oM/k4J0XcsptQxhSzaKcA0okW9KYwvexqDKO6zqPqmMkh6AGFFRIMgkh1E/oXU/kh56InA4y3kgtPoSH9CYO6h7/58J81xh/sDqQLUkxxPWz6zBjYV6uSa1oYi1/jOxjpcPoZ1+WJYCuZmHbZ8kFXcQtMqyRUueCLVwh67aiU8D1Q4bLukvic5T6yYwLBujLx71q8gsFeQl77HVInwzBW8DGlKgWzlwVEwL3wtDW+lMmLCirVqgOuJHZLQALvz5R6xYDp6spSeM61enaxWe+nIkvdNPdkmD+kw0irC3vTlQMCMhbmhcPd2PT5e4TMFX65d64d4H03LN3Wsw3cw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+pUCoFxQfh7bVVtJS+k3cFSurB6E90Wse2QBCEdYB7PgP8fvZUMNLhM+M7Nl?= =?us-ascii?Q?/QUwZA1aQlJRbf47j9P4nGt0ymw1WDDd7EpyE8lKWj/nQ6ty6nRrhff/0TKE?= =?us-ascii?Q?B6q/sPnJrkgWU9tVroG9S9AA9yAELFaO1K3hzVWqRlsmiNhyyMpcu2ZUkrF8?= =?us-ascii?Q?M0dRBzDWyOhJf7Nb9IqA/uc5Pt1oHtj0rNBOOuI8NiJhfDuQMWI8Y72KLIIX?= =?us-ascii?Q?biOWEAvpsuU1MAHarIod8nAQJs2F15XFggFuu/+K5yExlhyl/oY+nk4SNp51?= =?us-ascii?Q?mxJnL/P2jVdMjmRjTcrdPZ3aVaWbEZHndBBbbV3zeSkAeBgnBU8s3NrdBvaf?= =?us-ascii?Q?b6Bc7U0N1i/z9jeQW6RStAFVCMiDCnJqGv3935ulqqu898AG0jHrA0JO6WMu?= =?us-ascii?Q?rVl0M+W34j2Lxm+pr2F/HXg0QgMBqFDP7azysNdtTFyDIkdFtiCdLR8fGoJz?= =?us-ascii?Q?PB2Q7Sy1X1LeTHp0Zf2sOWeL9lt9e11R3hjkwaOuofJpxuDBGQfRtjrF4m6F?= =?us-ascii?Q?SvTCNy2HmF6x+IWIbk8SApgIZ/hCPJ1w3C95ngWwXlrhSP4aIHQu/sg2ERK/?= =?us-ascii?Q?A+VpHB8iAt/8wwSHX/tyvtgLkviqs5BnPDoVF2cjDsn+HqGe6EBZYlKovUD0?= =?us-ascii?Q?eNGI3dizatp9uHgDu2NX4uSekUsQDF17n+w7SuEodrHGbbAsQgnBoKWsL+G3?= =?us-ascii?Q?wAYo3eCPHknstfiQ/5PJ3Fv6A6cGvSjjn4PLFdE0PSGJlCGQoym1EaAMnvOG?= =?us-ascii?Q?ng2j0Y3MhK6HCc5mSMt0K8qIAOHYFB+dNUwV919i6Vg1UaDqATgQ2QU5KHPM?= =?us-ascii?Q?PYPgSBFBUEyBnq6f3He/AdOqhV021F0Egv3gQiaYWbCeUylpauQIQwTcUql1?= =?us-ascii?Q?fvAqY+VfIE/4HLhbFeNjSq4gdY5hviimX7cnCl4o9VsC42eCDT1BKnXp/Gm+?= =?us-ascii?Q?iNzSXI5yMRN1j7Yl5n60P4bPLj0DLjvSFAU3r0mQKNhj6HGQvKgyGIxH4v7K?= =?us-ascii?Q?GGq/8kSOoesOYQ63BHmTs/7WmRFGyxOS894MMTW1MaQG+H2DrWyY7Wdzq79M?= =?us-ascii?Q?tqTX3KMXL/GvJZ94Ia6QRe3wYy6OywKd/JSBpaATjwJDtVZUE3DDoDguiwQ/?= =?us-ascii?Q?sbePPaHZwYWVcNTHedvqfgyno0j6a2VmMoJzTpbIFiJVdk9JwSYDTOR8UNiG?= =?us-ascii?Q?4rNUhtRgvNi5eWJzJwJ9ae0GTtBLN02jRbwpwlzLXo7/S8fkAiWSEL0gJtRg?= =?us-ascii?Q?ePev8Ds1xEuWaiYQMzyXa8nHdrrZ+VER6GJXAd4y71Hd4xGJlbumCK6mSprX?= =?us-ascii?Q?eZBk+P5l8IoT2/4WDhv0ECZJLcqy2J5ok94sWrd+el55RqTEIYj8mB91honP?= =?us-ascii?Q?YHQQGkGz9Rc2/42M50L28FjtphKM2mHE1Am9cuFEDazNzXAd7v4/70QUhdln?= =?us-ascii?Q?+u6F7o9lLq0hG+b21hqYSYQ5oxHSjoFzgwtrvdD5w7WDhpdaxuC4kXhGO0ua?= =?us-ascii?Q?x3Ju0UoHu5nuDidfh8+JieKJDVt6O8kp6uTNM3HhsqHaciVonAQCZzg+TBmU?= =?us-ascii?Q?iNTvGarQcGNU2zjq5Y2L9OsHea3N6kUMqH6y7HBXwoyAUSCP+8uIjdxjhGxh?= =?us-ascii?Q?7L4paKsYSsgNudY5ZTskSbUXxdPfu3mM/WrZgzjDuztayAZUd/TMsDXd8dcO?= =?us-ascii?Q?WOKfKhRnPgi+NeiWAyAWKsFbVO4u2kRF1oluT5EKozf/TpNQZigqQwTIzl9T?= =?us-ascii?Q?DLRYnzNJduKTrSPmk0tflBs9EBdAJ3VlOPqxwIobQ5emcTtqY5ZM?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bdc7c79-e92f-46f8-c540-08dea4a5ca77 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:41:50.8104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6eSt8RcKWufIOd0hr4PZ6DJ5Sp0g/8w2zm3fwoztBtGuR3WV1335J13UL1chyB4OcWgjjrxHRGufHSPjA44DkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Content-Type: text/plain; charset="utf-8" Switch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't provide the fields length explicitly. Acked-by: Jonathan Cameron Signed-off-by: Yury Norov --- drivers/iio/adc/intel_dc_ti_adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/intel_dc_ti_adc.c b/drivers/iio/adc/intel_dc_t= i_adc.c index 0fe34f1c338e..b5afad713e2d 100644 --- a/drivers/iio/adc/intel_dc_ti_adc.c +++ b/drivers/iio/adc/intel_dc_ti_adc.c @@ -290,8 +290,8 @@ static int dc_ti_adc_probe(struct platform_device *pdev) if (ret) return ret; =20 - info->vbat_zse =3D sign_extend32(FIELD_GET(DC_TI_VBAT_ZSE, val), 3); - info->vbat_ge =3D sign_extend32(FIELD_GET(DC_TI_VBAT_GE, val), 3); + info->vbat_zse =3D FIELD_GET_SIGNED(DC_TI_VBAT_ZSE, val); + info->vbat_ge =3D FIELD_GET_SIGNED(DC_TI_VBAT_GE, val); =20 dev_dbg(dev, "vbat-zse %d vbat-ge %d\n", info->vbat_zse, info->vbat_ge); =20 --=20 2.51.0 From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3748C3A0B36; Mon, 27 Apr 2026 21:41:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326119; cv=fail; b=COTwnEKddcvPg5iZ5ElZa5LF2jk4+fkqt4EHrUugxgEjT1Fj98WslmPx2hNEdjlCkJrNiwYrjmX4En9mWXGcAGl20slxv4LLhIYwB3UWeR0WhIG3rqgxuI1TqPi95jkfoL2Jrd8EUblbk7QG5AGnVz5Fqg/P1UHnfIg7kKFXoVg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326119; c=relaxed/simple; bh=oLGJ2a1mpRCsHuGgG0vZULv9EJ78iNCksc8gNrlIk/4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=a7CWNEcXbfg9NgvS+dr1A2yUT1x/Q97717PpWddn9Urz8o/4YC0mk4DGImkNHm2p/9/N8CCIXuFMbFsWzA4P+thqeYvd5GhGGA3C+NoTjfnzpb7dRiz0HyAiinAIz3rlDw8cNAmJyIDfwcaigStN8NQA+72VZIDv2Ujcwmh9IuI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qonkoJav; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qonkoJav" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LPvMHmT2dLVktKodYP2Mu7zrXWxUZAZ2IBvqXTcJF3qJ6/dYQ3g8AGrc894gDMa+iqc/7vWIG5orwBBMf+JiCSrZKp3GRDEoD/CJ5f6sbdowo5dv6ZaY7K3r16acS2Scu4KEN1TDP/wVbi7zjpCx2VdihzIzEFdaaLkeDL55+o0zPIoP8864/n17R9kzwsG2v7Ca++TSzSUsM6EZ6v1PC47SSIbofsYsc1XpcpsWPQB+TlbfXJco0lJrTFhhnCh/KoCDfxfcHf5aLqIEpfWwClakuad25nev/M6h2hqUHBjADukT9Gjm90knKmcEyGsBOtqeJIM2h183ohCs0GC+Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YEJ1t2D7Di6vMg2XXHh39R083x+S7XVB9xSaeRqObro=; b=D71E9/7ceHslgFhmp4EsFZ1AAYwc19YYobuZK3bydmupLl00f8aXXNyNxZcccSnl84pXV/37IAApTkaK3ANjBABU7cV58q2AtTnRMmjl7qabhNELr9f4/8GzVYZyFGcomxCzdLqzY7ZAltpuSrhfoSGBUNt2TVrlhKCrKhySy0SKWG5aqYHne09JHJqXfUbbD9WoPexUXsHef+k7FjikmrBYAQm+QO1cj92nl7rjqfNZFuV+n7Skl+0ePHV/yJrVTRfNCvVyrvOmfQfC13Ap3TajE+yo4qwtjDaFPS82T2elYwHbNp80fbA2v0yxpm6Jh7onzw+cM227mHVJ1YS7Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YEJ1t2D7Di6vMg2XXHh39R083x+S7XVB9xSaeRqObro=; b=qonkoJavGUTZ+HhqpsatwxelIhQHlOftuyXtGp0CEn79XN2Iym1jd++/CWznJUEJfp0qIXJwMJ+1R0YW5PniTitajcEemdubfjcYQcIsWjctzEhikbtbgrVDpx3zPvGg5BaS7lKNUq2MusExthCFrw47rCyjqk7qXuSHlxgZ/aV8DjUHU3ZPn/Cmah3tvxZRK9lryXW74u2uIdo+k9C2iNwkhk3S45N65WqKfSauvX9RL35ske5rUhcFcdV2U0mDOu1KJ69+MUyKU0mupNSbEqc0IgFdMV+CNY4YtH2TRb1KPZWVU8FBZGMFdV/oNXEZI8YiaXlLGP9J6iTBwnuRfA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:41:53 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:41:53 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 4/9] iio: magnetometer: yas530: switch to using FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:21 -0400 Message-ID: <20260427214127.406067-5-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN0PR04CA0155.namprd04.prod.outlook.com (2603:10b6:408:eb::10) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: f3ad00bc-514e-44d4-4f5c-08dea4a5cbc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: KXImmwK4z4FO7e0AmYeKVP+lEijB4Ps/It4kb9SU92aWQXHvjPOt3nWWDiU1Eu82jclsKTe9jxXkLz7lrqyvRdnq7eSWaIdcQ3Jv3s3zVocm7mXC22wkyzQ3goUSQdC+baLRWXT0Kl/muJppnw4TZh+t06XBYB4kuqs/w/2X4EXTd7CMmkUE952qofdGZ506LmD6kGGmu04FZIDIo8yHY0oxwuiCyfxpgUAQYb4Ss7Za2rJXPdQn6+Mz45JCAzlk3zMB+FA58DDYoInp9kSlWLK9nhpR4TF4RWgMLqoLEdg0CPk1OKafNzc5zdLnG3X1x0ZKOoFNIzJGQHBjjPcqoaHWA+IGoH26+o6HpZXXQ9LFKYTupwVtS8efWa04WwazwtjiWfSxWzhXKaYMBcgiOfMhi27uiea3SkMvza7vxKFGjvGMTuuqwIDHMwTYJemtjqeWZuJOmPv5iJ2ztyWUTvouUzibTBxHUDlGKmfEhhqjBdr/4C/Z5ZuRXhWb+50eMuhQvS6elDUNh43hXma4jY/luOalTqfBk3zfuYkddT1WHt/bYMx1DaHIp/K0jkq4AHMAyN1vhSdVsvF10Su+HamckLMGoWpPt0SYIU4G4OPgmQoYT8dB0/JiEKwkl0kuvBhO0PpQ/KtwEctQ64qO1zdpyH3wiXta2/PwpFzU17PnOAItX2tYUKhqI0BKGNqYmerxeJQWPwL1QRgiB+xXgG1GvqL42/0gf/jLls5hVdZS42GBxC3zVVd0VPVWyVzARQXBobwmJ2D/YzM31WDpjQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lT0bf22sRkl41bfYtAJz0bN06DIW5MXQQMKuYu30HI0iRoX9OkYgOf+Vc1Wn?= =?us-ascii?Q?8yRB8qqWWeXr5tH9faQtAXqonm8xc28BdeyCChFBCnqW+P1SbTds1HKxk8/y?= =?us-ascii?Q?qf0f7sV9PNw4rvJg2qvToqv6eMIQPk1mruSQiQIW6RDQ+WPnH/2G4hZO+WTr?= =?us-ascii?Q?j2wjOeCRufdqmVfaiFSUt6kvnN0oj2wzOkNTWt71jgc6sBZi44aFOgyd8ivn?= =?us-ascii?Q?k96NgMwJhICYG5x5Pilzd98i9CEUApLqe/a53suVD0hK6H0sh/EudhJBMPDY?= =?us-ascii?Q?5XUQd/dH1c1bObEUkw1rn5/lWEW5c6IgSYHc7J+WUOwCXFBmQrsCZuEiHoTx?= =?us-ascii?Q?R1HiDeu9COt2hQ849iGLS2y2dElwmGsCxiKWeMcSuKqNVSBKCdoQiukQIIl9?= =?us-ascii?Q?HPjqNvBSsXcIf9595TB6f6HmvqCrhLjOoRUfBp753u6+3BGp0x6hJh8pinh6?= =?us-ascii?Q?ECQEhEwHOYZJpvOWWMInzabrqqV0oOB+a7To7orfY1Uum0nuWIlY3O2psdhR?= =?us-ascii?Q?cvdYhXO1efnOajN8rTyt367utkEkW1RTDlD27zy7ZHDFXI9PRfl8Q3XbPBh/?= =?us-ascii?Q?Khb6VZfdoJlMbZlbla08RSSVjvtHCC8Ue7t0aK16/gfQKJnAzZ13TF6NrH60?= =?us-ascii?Q?qg4k8CYoZDaXDonbaYx9F+GFUnA9x1/lEZMw9JEonWpfTRryOKWUVLU8JlwP?= =?us-ascii?Q?8Qv44i7b88K8MZMzBLSN3doHmAJHRwY+p31CdOygdmDR4lwA8mJEWEDd6x/x?= =?us-ascii?Q?IAYv9W3OPjnbPvJCe8PskM7au5BToEsZ/NrwnpO67AS336X5QDJTKHXEFya5?= =?us-ascii?Q?OwMItiXOkHVSq8WBSyw01GG7utdgOkrvG55q5n870w2n3AEeFTlGRREgQcao?= =?us-ascii?Q?6ZDX7UrSydihQCPOWkarqUZEkei/A/7hAqF7Y59bW22CaqCGhi4shzY8TdSe?= =?us-ascii?Q?9/6LxKHcrtCNHIBnAn/OWul3NAUZBjfgAjTFAJVzO45U5q1nqPzj/lqFKZxg?= =?us-ascii?Q?f9YptcqV2/dEjV8dXAW575Q0C0J1Ys/o4QSGZ/ztJjSqMZ0XmPG981ooON+9?= =?us-ascii?Q?iGWZKwEk21ymQbMs0rnurHzZnNdeDiPnQW+jRSk4efUUuJrTrxIE4Nor13QU?= =?us-ascii?Q?q+XYclR+OiVBF5PYfYTdeCIFl4GZL8gxpX9Cr1D8EtQ12rfUSGmqiCnIlDp2?= =?us-ascii?Q?5lo9nVhGrH8KWDgKCOSXx3XpTbBm1qdtK8KRW1V0qv9HELmTWB5uZx2o40d9?= =?us-ascii?Q?J8Lxfy1dp0JK7q33dwFr5AAHfpFfoPh2JVGc4ux9o2heZDiP9Me0/+3/QiNV?= =?us-ascii?Q?LV5lnPAqeV6Mik+1P3Xe1+tDVnCkSgqMrlNipGp3q4T4FNSzD5qHnNgzohMu?= =?us-ascii?Q?M+yAilqL1HQfGXIrT3Z+UJ2/wQDIxL1qY34K1CbkpRV532b72pi5uuj1vMu+?= =?us-ascii?Q?obdfUF7OxMkhpKOWsOnWEH0tT2NWdlz2tTdC1BcCcWYrBx8iHPqRSHrJOlUw?= =?us-ascii?Q?rqOv8c6Z5DJOmHf4VZ1ELyL4rNz9INhcGEub4aEZH4b7zEk37m9K8QQXHBBH?= =?us-ascii?Q?wa1w+wf6Sr2n2YOWxPmQaOrzD8zvjGws0UvFvsFhWO6g/4ECP+ZqXXEg7MyH?= =?us-ascii?Q?RcChYhmoLhDVshBLHiAgBKVnzXIfbwxZw2iAIyZNAniggdaqvd+DgnNTH2Qd?= =?us-ascii?Q?il0ADIL9XsGYFEyWxbPicniQMTibuBYJilJiwWTd5hhaXrO7jCRc0eFleRR4?= =?us-ascii?Q?/M0ksqjac2OpxnhFYWJAml5wkkP50DSTtpu4ONxyynX0I0+3EJMf?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3ad00bc-514e-44d4-4f5c-08dea4a5cbc3 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:41:52.9572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bdK3cg7h4yNGm7EwCxPuvbzzP+jUOpdv5WBmuttKMhduVvRP1ao/bXqTEge7lyIYf1wJPxdLLW9fV05dbxXU6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Content-Type: text/plain; charset="utf-8" Switch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: Yury Norov --- drivers/iio/magnetometer/yamaha-yas530.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magneto= meter/yamaha-yas530.c index d49e37edcbed..6a80042602c6 100644 --- a/drivers/iio/magnetometer/yamaha-yas530.c +++ b/drivers/iio/magnetometer/yamaha-yas530.c @@ -859,9 +859,9 @@ static int yas530_get_calibration_data(struct yas5xx *y= as5xx) c->f[0] =3D FIELD_GET(GENMASK(22, 21), val); c->f[1] =3D FIELD_GET(GENMASK(14, 13), val); c->f[2] =3D FIELD_GET(GENMASK(6, 5), val); - c->r[0] =3D sign_extend32(FIELD_GET(GENMASK(28, 23), val), 5); - c->r[1] =3D sign_extend32(FIELD_GET(GENMASK(20, 15), val), 5); - c->r[2] =3D sign_extend32(FIELD_GET(GENMASK(12, 7), val), 5); + c->r[0] =3D FIELD_GET_SIGNED(GENMASK(28, 23), val); + c->r[1] =3D FIELD_GET_SIGNED(GENMASK(20, 15), val); + c->r[2] =3D FIELD_GET_SIGNED(GENMASK(12, 7), val); =20 return 0; } @@ -914,9 +914,9 @@ static int yas532_get_calibration_data(struct yas5xx *y= as5xx) c->f[0] =3D FIELD_GET(GENMASK(24, 23), val); c->f[1] =3D FIELD_GET(GENMASK(16, 15), val); c->f[2] =3D FIELD_GET(GENMASK(8, 7), val); - c->r[0] =3D sign_extend32(FIELD_GET(GENMASK(30, 25), val), 5); - c->r[1] =3D sign_extend32(FIELD_GET(GENMASK(22, 17), val), 5); - c->r[2] =3D sign_extend32(FIELD_GET(GENMASK(14, 7), val), 5); + c->r[0] =3D FIELD_GET_SIGNED(GENMASK(30, 25), val); + c->r[1] =3D FIELD_GET_SIGNED(GENMASK(22, 17), val); + c->r[2] =3D FIELD_GET_SIGNED(GENMASK(14, 7), val); =20 return 0; } --=20 2.51.0 From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E710B39891F; Mon, 27 Apr 2026 21:41:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326134; cv=fail; b=ozHFEQiIqYscRjdOWd2wUvcVGrRfQjF5e6RBhDed90lpqBaxVzzUsVAJ88EZjUFbtDB2n9cCc12O3UgtyDprv8eUpYuL/LC6sdndvSraWWVqTFTT6DBHXfn9ZMWeTG+DUzDfoJzywFV1Dq7UiWoOXhHM6iWP+m8RDdrEPSy6RAk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326134; c=relaxed/simple; bh=9lqe4s463F4muQgCa7LdzEAYWNBJnYP2672T1SP2vDw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=PMawirl87ONIuBtqdoLoXtWFQRMgPLjKAAIFLf/zM3NCOy9OGsT4vIGmbqIFhCTAOPfLSy7CIk2NTX24JnAMvKC/PT2CgRKJp8UKiBE+dylsqXTmkLcdd+WlGPkZrbg2uknlwQaS2wTj/GBJVxG9mGgK1piJe+697wofGztyHA4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=lBvbNaaj; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="lBvbNaaj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FkIqlZuRjjjfZoc8xdxkmlAJdrdOD+bOpgD/r3tjhRXae1VZWBQUAdR38XGAdyUWjbRpXR+271LXQ14kBBNM3pMaoURXmhxkyebXyGJiWKYa2uedqkysvcLaIFqduQxnhl9YaAou3AXmqk1LaEmvUtUIvrC/ytjq+E+z+/r9CbuTA4BZq01Pe8JDxPa7BWN/tH+Mwz9meGzg+lY4t2vGD0s2aZKL914T8BHheHky1+a8U5W+ANL2r2ed6LA9nvKpavqoeDLekJ/U1hnpOxB0LBuCvhASYXwMvxBz14nXFRh+cz/+SqUl8lwHTDoNdIm8CvlQi/me+Q4nPZd+AHqCCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eXsyt/jN1qIhzpJR9HUljNX26+MNijJ11fwLmG3bRTQ=; b=fuVCLw1R/Rvpl3Vqj4R2oR8cLTFrB5rssTNVwxt9PxurhIPml1W3vw6Jh2Ijv84qJk8iYaJV+FrLFu8ez8cz5bfcwx3vkdVwLJsH5wTnaPxMQxPZjWuhvHTDJkYIYvkphXoAcP3Ol1eKr2FKd84Ky7KVkIgX6iGiccoEwxqpZoovZoMY5BOSuauhU/a9l+xOkUJvzFy3d4BSVSxyus8q+MAUcQIyHTEF7KqvHjavqG/yhoQstuZTXKfz+T1mGiICiriUaML/qOco+AVhJeFl7PSJ7UDqDHhaB64Zxqa1OCX2+Q3aBMFLoy9dz7opdB/MDd/lG3+lvMXgdQIuRqV8AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eXsyt/jN1qIhzpJR9HUljNX26+MNijJ11fwLmG3bRTQ=; b=lBvbNaajzvmVZ/f6HF2nxbCr9oDG2mSbdhHN+cG9YPetjoQm32dJdSNTpxT7zkRFUCeTjckhxIlrHy1DOY5rN0qUflEjWdB40/nhGOTr6fGa4gNARZs8o966WSEcFHkBQRjGScF0jEQMipFtcznUHrDALHGZOWRnTK627Ps3j1/t9yNrMvVBuE9ky/moXVNmba9mAM6gcCVYY039VbxDAQV24QO72snNsuhamO7HRzdrZuliKpxOwODkmAvR2Mz2cyIDSlR27ZnCD/71EQ4tPU5YccPT/D/0g7ppcilqxK9grGhmA5xbyJKsvHeyWf8NrQ0Sh7aYZGi/Rq9qhmy+8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:41:55 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:41:55 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 5/9] iio: pressure: bmp280: switch to using FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:22 -0400 Message-ID: <20260427214127.406067-6-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0274.namprd03.prod.outlook.com (2603:10b6:408:f5::9) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fcb4f55-c68b-4189-a15c-08dea4a5cd05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: fwVF02dLBFs91NF+4leIV3Vv8syH7LXHCDTI5msfXZSzV+sVcP0blCUfTxv0tYJnfVOQ5moLDZyps3UvcecpFt7XWRtOMn2UdXHApFgMmYytO4WWJ6nV2mhdHmwp6SlUIfYx+BNR3JbZRivBQmpfBFnRh4g9Rb1BKr3xRXS0N+LF6h2XLsmelDv7AH4thvfDMg2WCIs5L4HH//NrMNFSUawRhTB/U3nvlx2y8c4QO1LsrA9k9O2le8mzGK8arSiP43RoJS+GeXapNxBqgsDpGMu79K4HZMLgdqQR63JgDMCjYhGQ/clTMxkEFIjxbA5v68BMGIBnK+Gqou+xlx2FrGWEURZjAR4I/C/dR5y7ExrKz40l/7C4JvajKUBH8cXJGP7kADDV3pW3bV1HFhEI3NZeqkUD6PW5ELHqRmSEYcp/x6SH2fru5INvvDRqS0KMMWSmbRyAJu5Fdlr5kyCKKIq+574Fxth8TIwe24DQrx0ifJU7x8QioZ/EUDFBdHmcv7IunSKfEDN9ezXPahANJk9pSKiwOHcwBlqg/d6IoFyJUvM/FoG2mypQLZymkMepqh+9rHHgX0DMNxrrrvgK2J9qxq78VLtsEoKQLAwEIzK07ia7O6gYI63j86XVoQJ5MyIRrL76UtBqeISZ5OErGKIWAZk2CfWFHa5UBrg5QipIWmy1Eo2Bdvejv6q5D2Txt5nRk8YgxRgiXqeD/DfhWyoyCeKLSWnQ3GxmhIWgsGYXf7Cvng8tEvqjRhp6Q7KcwqYkKJ04XWZvdjOBo+5ndw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GP6V2BjYGikt3vQIZ2Y+cKFm/DWGw9++g2VDXIQhBNqHqmGzRnGaHstmBFJv?= =?us-ascii?Q?fyfn060dAp4E9HIz1Rfq47L99af2Wq3O/kVJv43HgMczE9r7c5fLgBWW2Z+D?= =?us-ascii?Q?VQH22S4NlqI//BGHdqVyNMxopgecqfYvENT3Tjxc4qtb1bav7VY/0lLeWs6T?= =?us-ascii?Q?ieWtUruL09+GbtlpHLL+EnlkgjrOAeKk4FruO0Lg8ObqBwrPIoqGJ080yFzv?= =?us-ascii?Q?waw/7D4rZd1WjE0wjOYTHl4GN7dEZKNIJZnpNH8+btBgzbuzJAjlWvv1HFfE?= =?us-ascii?Q?syreAELpAsRHZcOuV6hSvR4Gxk+ohc9IN6vgW9pDsq0AKqcHzScgOowSKPGq?= =?us-ascii?Q?DFV04G89t8+nQWgOv8YE7RgmzV7cUB6zXoo0ObKHxnNGUMKlAJP536AurP1E?= =?us-ascii?Q?AVumA04RXDGRdPEF5OldRNl4SVgZrCde01y087TFjoiSbiUmgnhLr9X6KCnF?= =?us-ascii?Q?aalYth8Af4iNQNy4Vi8CceJTav8DTvVPrZodyB3a6biLYI8QNLUFF2xDYECH?= =?us-ascii?Q?K8JABhe806gzh5Ntll9n251JAlg4MJcyA+hx397NmaA3576jrVD4k/bB7vsE?= =?us-ascii?Q?4V8sur9XksoHwonQrDwTJpNz13Aq338l6hBhnKu6lecYMs0vZiwWbO2hCvuU?= =?us-ascii?Q?xI5CrFxJk4SjmD0tPBKcpmM0EhoNN9dIlQsRFpyUMKgpm6b1FfUmgaeAKMkG?= =?us-ascii?Q?E2stWVci/0Lp0nU7P21AK7VzVajyO3t8o+5AEgRqYf3Nss7ol88g5Q0rdPED?= =?us-ascii?Q?g7r8t697nuVVMkNQLJKftsSqT4e8OFoSVYdNws2sx/R1/6a/qEuTdS4PeSol?= =?us-ascii?Q?r1JZjgjmWwRp6SqnM649ixAWmMlqwqfhZut7dmOGo7e6e0Yvw2gx3UYvxxh1?= =?us-ascii?Q?EgB7eFNmQr8PAq0hvNg3cUfsCi9Tw6nXYYBu2xnZKh+doNHUYVYQjj7jq0oE?= =?us-ascii?Q?qYKhmKfGLxa+iplLnoBHBcdlQAkjPKs7o0xUDZ1kSe8slASsdSKxhSFWIinG?= =?us-ascii?Q?+OXSQLKnjAkEGr+PQrLqV4akwgGFA96mfOzjE8IjPX0/IjBW8fTPiuKrf2hP?= =?us-ascii?Q?Tod22J5jfiqKHHuzEmAac46OqMJo/4noiRG7aJIIooRexKci9IFqaI1ZlYuf?= =?us-ascii?Q?SvjChdj4U6lD4TvvEJ6CkIHBcB/tWvRT1SE0NdDLW2nGvtFcWH+K9bFk/BEt?= =?us-ascii?Q?cYnav0dX8bKwALIZQ6SeefkAmugpLYesk+RMP6oW1Pr252IEjb4XlpK4Xsd+?= =?us-ascii?Q?vBJw3H5eAyiBLUz+lLXi6cGzJM9lTt0yTWPc+axXEzttPl1AOhOhYZQFAKvd?= =?us-ascii?Q?jHiT+D1BWhvJg1e0DNaVtobWUhGTS9TdvMH6SSUqPLU2aHO1Hnq/0cuHGdxG?= =?us-ascii?Q?DBwzuVSOEAhl8/VU9XWQ133jDlpTKrZJpSDWy/uqG25hOicb2iKDK/xWXIOL?= =?us-ascii?Q?t/nubVdpF8IbDmdP5tQZC1XuuXxdLRhRTrdaIKSgyQxiLRJ7/89jI4ljqJ5s?= =?us-ascii?Q?lkeQlSLbTFLu2Zon3R/0b+52R6pn8Kdw4Jn1q7uEQmX1zKRloQyimNOTqqLz?= =?us-ascii?Q?M07Q7twPykrQPtoDBganruwbU70nZmSVHKfHGZHhqSXJ14TnYMcBYypZXPMv?= =?us-ascii?Q?mTjvkdLvxkUyIM/0siHJxsZA7Oa1R4jsbzO8DChiAwxml8HBGaI+C7Y8ahn1?= =?us-ascii?Q?Rb5NUJP37uXMhDuRV88ZGWA8BTo+i/OBdfEi9kpNi7xZl1gwlMVSOjv6I+gM?= =?us-ascii?Q?xpLhA2p40LxNMoWWoCASPYHTvFwHtQEz9W5b4K43R+TCcPAZVkMz?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fcb4f55-c68b-4189-a15c-08dea4a5cd05 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:41:55.1076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TeozLTFRHOi+Y7kEy+Ze9V9Vq9tWn+AVqqjaojMJ74AglrAxnWgurHkTS0BuMaJL7FiKICc5HBRGZ/laXt7wXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Content-Type: text/plain; charset="utf-8" Switch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly. Acked-by: Jonathan Cameron Signed-off-by: Yury Norov --- drivers/iio/pressure/bmp280-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp2= 80-core.c index d983ce9c0b99..f722aea16e0e 100644 --- a/drivers/iio/pressure/bmp280-core.c +++ b/drivers/iio/pressure/bmp280-core.c @@ -392,7 +392,7 @@ static int bme280_read_calib(struct bmp280_data *data) h4_lower =3D FIELD_GET(BME280_COMP_H4_MASK_LOW, tmp_1); calib->H4 =3D sign_extend32(h4_upper | h4_lower, 11); tmp_3 =3D get_unaligned_le16(&data->bme280_humid_cal_buf[H5]); - calib->H5 =3D sign_extend32(FIELD_GET(BME280_COMP_H5_MASK, tmp_3), 11); + calib->H5 =3D FIELD_GET_SIGNED(BME280_COMP_H5_MASK, tmp_3); calib->H6 =3D data->bme280_humid_cal_buf[H6]; =20 return 0; --=20 2.51.0 From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78D93385511; Mon, 27 Apr 2026 21:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326135; cv=fail; b=IWn4Tf/iT8dr29S04BpCXv2Z6nLObUTRBh9Wc8jxNswTi8BiH8h5t4ziu/fhRzKJk1P0dWDgkvmI+QVdbGrwnYC1Nro/39gULxdxdX87Ne+MLjK4p4R84IKzdQu5cZ1BjkvLf+hPpR31xCk7ltfgIYe6dqMzUTqyLOn7kXvKc0Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326135; c=relaxed/simple; bh=NmX7diBXWLVyEWL4ak+Olp1X4AFpXzF6+xq3S7BBRIs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=QhwwfEIrckxEK7y9cumWHZeVDEOWpzeZE4T79kZVUa4gwlvnH9wZVfXsB/LG52wCGC6dtjOibn0cZdFVVcu3oJIgv9PsV5k3XzyCGFrR7jvbhya7o57Bi/4wTl/u1B9EzYElUApjJlxLlz4S/1tw1ABUfnaN7ao2PGfmcl3KRPk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=bGLIeKER; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="bGLIeKER" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kdh4D9hy6pogmztdaxuzVSZ01RC0QIpEUOVIkA/A4E/IA6q8jlc8QTVzW4njB4FerzrhlOcmB5l7/6CGTYJ5PJNA8dC0W+ysFTAaCVLZbAo4IWLfBIzNI5gU9UowNrk++fIq+yhIDT86o9CwgkB8LdnHMsDT1hLjFBy22bhTJbWDo8IlY59M+7VBCPuo4H1a/Wa+mENkOh8qHuqe+hpTZmPdekRo/wU82cQloSGFcuaZbvZm07GwVoHeFk1bCyBoKz2AZcv+EfAgjgmCt0HNrOb/4blz2MWWXCcama5m8QCuRcdjRNdGgNCBmIRT6x27szx5Si37sOb2BJ1gsRwd0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M75Yg7BQjU+KtB+Ke4YhIvkFQKWbOiRe5R+iAPCCmiU=; b=RLIrmweSp1O6zp/x7IMp1uhAeU8DlBGEYqnczDrgeIJqOp/IIBBDyoRnZ/6JwxlIxh16M7LSlv3ag5Jq8OQvYsqmFPwYvSWRg0yjLH2Q85Mr5dYO00p3rhfJUVvfj+1Xh6G54DkEd9E3ejCRlOnLesJhr9o3lSOE05gtcVz7SOdAOn2uNqDp5QCFwa8T7jz7G+TU9BUKZBl7tnr9ZcnPCnQ97sRUEMjS1955dL9CF0UHiEDlMRTU69wV3bZln7KLAKgI6Z35AvcXiVKExiNAs4/qgrT+wBWDpD93fMMQCOrhbd1c9LkcFMySkg00+udRVEHwKM3nsVeGqHdpPVc8JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M75Yg7BQjU+KtB+Ke4YhIvkFQKWbOiRe5R+iAPCCmiU=; b=bGLIeKERYeKwCCOn4V7OZPHlZxYGTcsZ4CW8neHYRbeHEc1Z3W65M5fZt/z/p7DQpTtGaMI/ADI1Z405s7p6Cwa9eJltApYAJw5z/ybH3zJN3mRrAICoct/SENhfnzpvnBMBQPfFCUDyCfYBq2nWQtzlh/rksEduyWVNzxy/aEDphaVipxqu7K+TIF88vJF+EBGaWVR633JiPcyMNOjAofz2rCWsFC0FznnhlxlNPdKKhivrz31uC1q8IxHiy2rdUJ30eJ67Yc1/LUtY5jAQMokTNt3DZjUDDystiOe7d09rG4g1obhqZevFFtNj9I5JPTiQxcM3+pO1/AGiWsnyLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:41:57 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:41:57 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 6/9] iio: mcp9600: switch to using FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:23 -0400 Message-ID: <20260427214127.406067-7-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0478.namprd03.prod.outlook.com (2603:10b6:408:139::33) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: ab6bda23-9d7f-4e7b-678c-08dea4a5ce70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: W8EMGw55og5q9DEhlw3lPSKV1w6BMMuwIW0jyz569KsLdClAr9+CzP1+QdCwzB/V712TBQqMZ5INWLUv9UkAYVbjqqHcf9COiISQdNFuvS9ABCZX4DGDq1lZyt9DdICazFzK9KYKnq6gndko9taZtY5oAWZcX6QtIbzx2RUyNb8w1fMMEFCVyMO/eeGVWFgZe5wGXNbYzuWQuc1ciceeJBYO4/4wpELQ9/xI0Um76afhG812XzfLjzx6hpnEOb0x0I2XtBK5Nkau6Sky2ymgHUK18mZ9+maiiUrnIk2fXbKnERXeGxI5bJXXBl8gjeo4g7pw/Yi68vCMHwzDvbBxZ5FasA96MwpMRJxichWfWiyrltyLeK4/MuxgJCE0cxNGCtwuMMVvLDanqq6B0yNd9fQLoc2mmEOflhA+wuEm3Ctj74viEP0iCwwggHNuCOHPT0iI/a3Y0tPSbw5V3EgaszoGvEyMVkBZnAID971nxwswwRCsMFOhiuSu7K4ueXZuEjDc5zWI5j9fOb0/4YUfeTXb37hCd5Z8WaPShIOyc0NJAL9z2roBATXuyiSGhe+uPvEaNku/p6fGOziVaP34Alo9R7hz7UWze0lnaUHL5ZNkdrDBfKul8vItojmC73rbeduRFhPJpFto1c6wCw4PuS8awtjDhI3O2OUOr03nSeBu/vKBlzIOSmFn5CmzXNeh9Jx4xd51hhaF2Bf3+W30z9gyV2CK1rYFQBc8mn5oQupf2qnyKGuEqDjZwRrAouZSQ2nMPJWbvj/XJzYEDiWtNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGdtK1hlcTdHVWlhRjNiNVlWMFZwUm5nRWtiMEVtZngxTlVydUJqSkdzbnd3?= =?utf-8?B?eEdwSmQ3bENSMm16L3I5UCtiYVkyelV2eXJvTjMyTWRVWnFSMWNxMUY5bnZp?= =?utf-8?B?NnFKMFBIUlF5Q0wvZWpqMGh2dlhuWkczbUhHbUhWRkVMU1UxOWdGeDBBQ0JH?= =?utf-8?B?VHNRZXI1dyszVFlBV2tIR3l6c09JV3F1VGFMcXdMRXg0MS8xeGFmdVBicHcv?= =?utf-8?B?bDNFWkpYejFqQ3piTEJFNGtRVFZNdVU1RTQwT21VUXQ1c1JaZ01vYmY1MDN4?= =?utf-8?B?NStPYy9heCtxOGxESiswU2xsR29MbnlQaXdEaGNqRnhINmpuaVc4MkVkczE4?= =?utf-8?B?RXFmMUJBZlJ1OGRSUFI0SHFkb3pockFvSWpYRFpWSnZlY3lHTm5ucHlWTmNV?= =?utf-8?B?S1EvbFlNSzB0Zjk5c2RrQzg5ZGkxb2VzRk1iSjR2V0VlZnBBSHhmYlI5Rkxo?= =?utf-8?B?V1FZVXhjOTllYXBURURrczlkUU95a3R3K1JPSGlyS0Eva2hWM21xTVFoOHp5?= =?utf-8?B?emI5T3RCYThxR3ppemhjUkFvVk1tY3NKd1VWUnNqV2lzalp2TG50YjF1dUhQ?= =?utf-8?B?Q0VPUC9GcER0TlFmVnF3NHVTSU9tQlJ2NkhWeHU4a1pHdndrazYwV2dJY2Fk?= =?utf-8?B?RldyNW1hNWl3bXNpZzNSY0tTSmdUT0JhZ0haVlhtQWVyTlhISW1wWlZueXFC?= =?utf-8?B?NzFTYmM4MjZ5bm9hcEozYXVJQmNZL2FEWjZvZ0RZbEtxbWRyUENGZzhIb1R2?= =?utf-8?B?SG9MUVpncGZCNklMdENVQktjeTh5b0pZRkI5cm1tK2lGb0VKQjRwNW1XaCtk?= =?utf-8?B?T2VENTRPSXU3clo2bE9abTNGNXpscEIxakg1cTYranpaRUptNnlXa3FFd1l4?= =?utf-8?B?aFIzSk5HcjRzZ2l4SUZwczJMazFqbGxWa2o0aHNISWJNbU1IeElEOTBOaTN6?= =?utf-8?B?RjFnRE41cUZzSzBGbTZhcXhQZ2pzaUZMMXFoWHBvNE9jMUdtL3M2K3hVaHYr?= =?utf-8?B?SUsxR1JDSWdkR1VuRTMxZXZiSnZya1p6aEgwQSsrb1V5b0JLdlFWUGVIRExQ?= =?utf-8?B?WE5GYnVTRDM0djVsZ01TSWdvMk5DclNRUWhvd0xRS0xFQkNXUW52S1kweCtB?= =?utf-8?B?elQxbVMrckZkZTljb2NCRjVtREQ5MUtNcFFrbFZSc3o0SDdxS3djZVhFZ1Ey?= =?utf-8?B?NTc5QWpJYzNhWjZhZzl6elArOE5rVjJ5Z2orSnV3WmpPN3huZlRaUkJoejBl?= =?utf-8?B?RC9JTXRINkdReTNYYmtidEVvbVBid2xDMmVnTjBBZmFxeDVjam1pc1Nvay9q?= =?utf-8?B?LzBLZWV0Si90clZmMjhsbnlVOUxnakd1bi9VcllKSVl3MkRSbjFKc2FrTEJB?= =?utf-8?B?VTdpMEFNaHRZNm42NTcxWVJ6WXIrWWt6QjByYytadjdLQktFTlExQ0pQWk14?= =?utf-8?B?OWgvQjJkaTh0OU15akQ3QThZWlJPVFh1UFd0cTBUeUhnL0pFTzcyc1kxKzRF?= =?utf-8?B?OGUyQ1I1WG5Hd1pRSXJhb2dtamVoZkdxZThjMlN6azhObmwvaEpmRU1BcnR6?= =?utf-8?B?cnpWUmFvUG0wK0QxS2hXeUhqY1hoRVg2MkU1MEtxR1FMajBXc0NtY3VkWXQ3?= =?utf-8?B?eEhKaFVkSHVUblNRZk1id1VXZGVYUHpNVkVRQmFBK24rMSticXJJWUkvWk8y?= =?utf-8?B?UXBMTlhrMTZjZmZka0NMNWpRT2JJNnEvS1J5WTk0WHBhTk1mbkpRVVJlYkFl?= =?utf-8?B?UmFzRE4xamFKakhpbGdDVDhscUwwM2wvczhJTjd5U0hrWlhtWERaYkQwWjQv?= =?utf-8?B?d2JiWEcyQ040bWNKaUFDU1VGWVNXRHUzVWc5akQ3TTdLQVRvdXZRbHJuN0V4?= =?utf-8?B?SGgwWXlKd3ZOR3NsNUVmTm5mbEorQU4rYUxMNXFSMWdwSTJsN0VYYUFHbTRB?= =?utf-8?B?ZHFKU2QrQzJFNDFINlhIYkVSMW8xSHdwNG92Slcxc3JLTlFuMFpmVnV3SjZB?= =?utf-8?B?U1FuWnQzUE5TdjRRQlkxT3lxNGN5ZmdGN3RzdUtNMDdBdW1tbXpLOURPd0Ey?= =?utf-8?B?bjNqTVRCdVZjVUZDR0lHd2RGd1NvSGlFU3l1U0ZDcHRiNVJndGRHRkdockV6?= =?utf-8?B?S2tSMUpkUmg1SmtRQ2E2cHhoelhwOXdpUW5zcTM3K1E1Zk1EM1BCMkFjb0xs?= =?utf-8?B?MlFQb3Q0ZGIxVFNjTTBRQU5DOVQxM2trWXkycE93VmUweDYwdTRKeklsaWJK?= =?utf-8?B?ZE9Hd1ppTXVHMHVoOXVRTU9XOEdKOWduRGZHaVJkVjMyRWR2SDZudWh4d0xL?= =?utf-8?B?WDNtL2ZSSzFzWituZmovamVhVFBDYTVvRUh6bmFiSmNIeTFoeVlSZUMxcFVH?= =?utf-8?Q?8FKCONuWoC0dwbNaaOEKBLTqNKo8zPrY6tvhb?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab6bda23-9d7f-4e7b-678c-08dea4a5ce70 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:41:57.4486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kfEfGlMgkM2XbBBxWVa8unDrrHdPtyX0g1JtfHLY0tAO+vY8C3/+ROCtLoI0RYzjLB1lw1Eq4Io8y6TO2kX71w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Switch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly. Acked-by: Jonathan Cameron Signed-off-by: Yury Norov --- drivers/iio/temperature/mcp9600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/temperature/mcp9600.c b/drivers/iio/temperature/mc= p9600.c index aa42c2b1a369..69baf654c9c0 100644 --- a/drivers/iio/temperature/mcp9600.c +++ b/drivers/iio/temperature/mcp9600.c @@ -297,7 +297,7 @@ static int mcp9600_read_thresh(struct iio_dev *indio_de= v, * Temperature is stored in two=E2=80=99s complement format in * bits(15:2), LSB is 0.25 degree celsius. */ - *val =3D sign_extend32(FIELD_GET(MCP9600_ALERT_LIMIT_MASK, ret), 13); + *val =3D FIELD_GET_SIGNED(MCP9600_ALERT_LIMIT_MASK, ret); *val2 =3D 4; return IIO_VAL_FRACTIONAL; case IIO_EV_INFO_HYSTERESIS: --=20 2.51.0 From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E38D63A1D0C; Mon, 27 Apr 2026 21:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326139; cv=fail; b=Gk7LagKwOfwXPt4JwZiEFDHVqcIxFAB+nRUcb0qADA4r7ZOceYECpUlPtYFnOCmFgFIBAl47/7ETImUr83fSlwK+j28bWlJ4kzAYKucH/wnvCay//yHvCW0wyvN7YmdyKkHjN1pn1zMJDX1qpKVbeGv8PBpfMWlLR7mNOSwebrw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326139; c=relaxed/simple; bh=iTpF4KIxXNzM3ZLXR4PlU3PeEE/HIHQ8pPxIAOapRlw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tRmEIThmQ5SxiVyQrqzFuqzpOaukH8jF9s6KMGOVrs7V1EP9u3HZESg4+zor7uz32EjwsaL5UAH1UAAmGCUf+mpDgGrcMjCH9aUVYCtx4tPLIXP8Qo9kJSIYNn/+Kr5WZ0zbEMBHepwwFsdGi2EMEYR7NC3AHFV5gGhAhRzV3XE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QEnn3k+3; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QEnn3k+3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CYLOh2Q+S8z5ORnFMHIqurqZv8+oH/PHa1QDvqVtRYjUQbji/GPHBN4p3Fxq+258XsWDl5xVg0DNZ6riXqH7brPbvnq1Ov3xIcF9QsKa4p3MTHAMiIC8wKoeUitULZ7bGfyq9XGPJj1bZXI7a5qxqiAQQQLoIUZ/PHSb+pGq153Y69gxsI3VnfVcgW76eVwrpSunIKrmvjf9jf5mJO6g2RgqfO3r3sgqoDFVh6ZMcdVJPkRsX0YA5RfsnZ48ayhBpas4O5gso3amVx1I0R4VgfvUzJ17r6tNQ6McLt+PsV8HxN5WqUJZerqRMiBve2Ey8Sw3UUn/HVKQbo1xylHm3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S00wv2lseA9XleGekVV/RmNTBFbFEnxGNyFbpxThubU=; b=uPO9cZoRWM+WvcXyeRq4+RZNJ4+T0MCUzHS7jfQ3ersEViJ9xuGmYPc0ybHwU42SQD5Cdy+2OSuA0g85kifgdgQ/378jzKCy40FAEvvoDEWgtmiQX0adYrvPKSruzPAW87c5lk0EuFDmh4i6gqWN4r/GJTFmmfAsSYwvI1TYlSMOWSV2ju6hRnjLzLjCgU3wZDGvkb30djj1JNrjtHyB9bsyID4/AhO1Tw4wbTvAw4+3TKYQYcYDxHuifgg007Q4PNw5UhkduCCXjZigyqFQ7elfH3k8Zry54C8ECcXZBw79weV7Ssjn2oVaa0P66TrnFutp4sKFrabEf4NNp11pSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S00wv2lseA9XleGekVV/RmNTBFbFEnxGNyFbpxThubU=; b=QEnn3k+395kZH40raBFRZD9UBgzElz8uY/s3BXpWuZGt85l+xa41/Jg0gjN2c+0mRfQGqGPXAA2I08JMdtlEsKOXSbLvtikXgdyjgEDcYKRG6IZADnwygmDcyVbQ0VJ9O+U5CSuGW8dxbIrgD+CankASz57wM44IiHlfMc7Z2M3AbrNxMsdKARkxgg+lpw44usRHmgXZDTftP+zzzH/dWq+U9LhgF7MOal+aRLfs42Y+6L9TKJin1wiCByTv5kQivyot5CDipuShUst7wnqQ59EB9mp5Fwe9N9akITV+EB3L5IVrfcBolsUQNt1xSb7PZrC0zyIqJCzRIcOD2oy2ew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:42:00 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:41:59 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:24 -0400 Message-ID: <20260427214127.406067-8-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0141.namprd03.prod.outlook.com (2603:10b6:408:fe::26) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: 5976cd16-0353-4024-bf71-08dea4a5cfce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: AdWjq4zC3uD+CLU0s6C9DA7Fqi5VNLPQZcP1wL6NY+jIGkSUk2f72/P+gE2rWVyLa5WtWgeex09nr+9wpR5V3erannQ3dKycsU3mz5RonzB4d1qAqBeyZMuXNyVZFI0KO1fgkacG3KjUOqzccLwhP7qYvxHbxyOHf2dAjlJMx65q/LWBaxp5vHVhJkPSgvZU8Hfina1NqNC+6uce/7b5al2GtkQ2cevZmPK94w9Cz9tM6k2114PZ6BbQAhlXMiFa0U0XUwqe7DmnzN7JnmcCYpAlql46trXnrPpZWpWnOk4jcmFKoljzG0mSsTiyzoPV9YKSP77Yk8yDd82EkuLuoBBCubu+0EpJ0ZcXCGbfMrZn/IZVoqT4BjC7X8rp7URA5BmfwnE4Z8BFfiK4y0F4DoBy4CNh4SP2p+bNE6swLfgReYCvxQxtJlF2WWi98rPVcZQHlWA/CJshd4JFMI9gsOyT0/2bqHcpAITSJ0iJZsXTisaFnPDf5gS3pSM/LQ4Iit/zkBwqAE5zYyzjXIRrFX5uIZh66BbHAW1M9wEKJJsM8kFxmAWsnfukyFod0LUu/hbLlpFwlIn78ZT2x0eVPC8sKp+wM0BsJkWAzhaO7TIyhoXH7Zd6pq2B5kNXz6kBGhjCQBTcH7FjENiF3HC3Bkr0SSDo/DjJcYaFSYphT/lVoC6ZLsPD7mhBdvhNZcu5lPmx2b03Wo0x7ceCUsMVXbM2JW/RlYXrgmFz3ZUn1fKegPlIFzxEdVCwLWbDmmzq1rqgeTMeerHfIZtIzW7vlQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tMnzDyUzuUSOTrZ8Mb7wUVHVjOfd3jYGj7iSznZBnwsgL4Gf5UOLTTYvZX8U?= =?us-ascii?Q?iGEAZhgJs1Gk8mcdCqnooTv7cCiWfbjQSK4ikZDg64a1FtUtRdegcSkbhnQr?= =?us-ascii?Q?8DWABL9WUTCJJejH2GklF7Hwz1mE3hHmqYKpmYTi4vVGhniJOBh/Gdr5vXly?= =?us-ascii?Q?VQmXaw4rJ4WE2GMRpdWd12VtUesSstshuNRxPoX3HpKUJ9QNNGhGNm+64mKq?= =?us-ascii?Q?ggDsAypIf+zGjekvgix5AqTZuGuNmnQkDYNpyl3rw/MHodBizAGOuM84puOu?= =?us-ascii?Q?KIVAVX6ipTjicgKNl3UOpEXhAR266Tsan/+dOLBny/dfoPWM23mscM+3o9Nr?= =?us-ascii?Q?d31s1v3d6bC0ec6bXkrM+BvfyOgN2avbR4nCGsLXCnlKCNwrJMsgTYfmY4pQ?= =?us-ascii?Q?GS6+EtLHB6rKh2Gk2l64rgMaBtFSqJZBOtIYHdilfCLsQfQ8kB4dm4lqvsZD?= =?us-ascii?Q?qedXAPOTyk1H4sCRl6NzfYWepCpz6mzEmxcDPt4dxLYRIzcFabzOGQa6K1AC?= =?us-ascii?Q?OKE/SZJWqtKY+o0qWVPGwMbLMbBxxlF3eV7wcqh6krSZZZskPN0c/cEOMDUP?= =?us-ascii?Q?Dt01bZ5jBy1Fco6iphp5vYu+fgIDgz0xZgaNEuXToEKpb7FgL44P87186yE0?= =?us-ascii?Q?WyZu+R5JqZvpJQavSaRIrub7snFhIQtwDfxzFcANL+XcfJOkaN2DkYwMVRjI?= =?us-ascii?Q?WNX9nAWBXVUgcq6PJOiNiO77SE+2a29H8EjsbtvqANGBX63EZYBDUrWD6qJT?= =?us-ascii?Q?+elnJKGRtBajRIIBteKa9BEN3kf4fvj4yj0YCM6YYzSQwCgLZVTFf7UvNnnc?= =?us-ascii?Q?99D992uUYH6hMJ5BqR2eapfxtNJz3FMoOnpgclsYLTsp/rlLuLbQZ+1dsQSx?= =?us-ascii?Q?j4Csz56SSVybyT5IjTjZcgdJ+jRM0H6BnuqNzRXKA/kwlOa72HQkvjPQyZZ4?= =?us-ascii?Q?ulDi03E08krlPis9lByZUhoSWw4PJnq7ax0UmQk3EgTVgyynGrPC1xNlg//r?= =?us-ascii?Q?WXX3Bk9hcfpHQx+ren5KOwKRrcbVbHb2CBHxVDU3MuAPuEpRrnBks3RyIlre?= =?us-ascii?Q?Bx8BsUpqnqxAVbZauzGEiFQ87Ov9k5iWMtvMXO12oG/AVGqXKq+WMy3Hl1SM?= =?us-ascii?Q?0M1JW4347nnb0CehFSC7omvjKu0vASVzxnwzzCz5FnvFJkLBEVdHQaOJezw9?= =?us-ascii?Q?7bNELqogxIMFq55sGWdgSSo5PzCzzE3Rp7NcAjEC2Z49AdRbRiH/VfOUB5/w?= =?us-ascii?Q?0TkXD8czM6seeG2e76zwIpCuObofNKGAJchIAlHqoeiDkcWuAqVP8wPj9jop?= =?us-ascii?Q?TZDvM8wHKpLyYEJ1up/9l8Ghu4NNh5svcTQxWIUcb90GvgDMG/P9MirT30UQ?= =?us-ascii?Q?XQkB332PmKAeHHaWo/QjrIOotUGdijONzS/GeLGCutl2YgpKAkQ0jXkX+2ny?= =?us-ascii?Q?B1Frhsn0Tr/Ny5k/gAGPJTTSMLPajeP3unJ/Cje2+0PBG0tlijPYVH9GKHvx?= =?us-ascii?Q?rxjozDBiQfXtoFQUzVHIPesy3AlT0UzXUeVk8+6yh0HSSPuECuZv6PNG2KKS?= =?us-ascii?Q?Iu7BbewHbYaw8e1t8dpKJUA048bN5KSUxiDDtVGmzIi+QCSmbc2MAbvc6izo?= =?us-ascii?Q?+D/LOkdb9+Gi5vjJCaaUYHXTPoumRwO1g9sfA/dctQ6SnwSO7sOHmtp9tHaJ?= =?us-ascii?Q?XW2NJEYas8nMnfQH+QjOTJ/gQeWN3grygPVJSiaJx8BW7HvPP+yueaq4dXfC?= =?us-ascii?Q?oeh9QByINA8Z8f69VR9GUuAZwMkqJByAXQMEt/WSs9KcxOY2o0G5?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5976cd16-0353-4024-bf71-08dea4a5cfce X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:41:59.8256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Via0rZI41zyW+UkwUJj0VY8ECtQX07Mqfe2vkjb93C+oPj33QMcIZvwbTlScT+Ka8yLAh7Rua/HuEQ/pfCQdJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Content-Type: text/plain; charset="utf-8" Switch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly. Signed-off-by: Yury Norov Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c | 4 ++-- drivers/net/wireless/realtek/rtw89/rtw8852b_common.c | 4 ++-- drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c | 4 ++-- drivers/net/wireless/realtek/rtw89/rtw8852c.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c b/drivers/ne= t/wireless/realtek/rtw89/rtw8852a_rfk.c index 463399413318..8679b21fd3fd 100644 --- a/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c @@ -334,8 +334,8 @@ static void _check_addc(struct rtw89_dev *rtwdev, enum = rtw89_rf_path path) =20 for (i =3D 0; i < ADDC_T_AVG; i++) { tmp =3D rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD); - dc_re +=3D sign_extend32(FIELD_GET(0xfff000, tmp), 11); - dc_im +=3D sign_extend32(FIELD_GET(0xfff, tmp), 11); + dc_re +=3D FIELD_GET_SIGNED(0xfff000, tmp); + dc_im +=3D FIELD_GET_SIGNED(0xfff, tmp); } =20 dc_re /=3D ADDC_T_AVG; diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c b/drivers= /net/wireless/realtek/rtw89/rtw8852b_common.c index 65b839323e3e..df5fbae50ff5 100644 --- a/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c +++ b/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c @@ -206,9 +206,9 @@ static void rtw8852bx_efuse_parsing_tssi(struct rtw89_d= ev *rtwdev, static bool _decode_efuse_gain(u8 data, s8 *high, s8 *low) { if (high) - *high =3D sign_extend32(FIELD_GET(GENMASK(7, 4), data), 3); + *high =3D FIELD_GET_SIGNED(GENMASK(7, 4), data); if (low) - *low =3D sign_extend32(FIELD_GET(GENMASK(3, 0), data), 3); + *low =3D FIELD_GET_SIGNED(GENMASK(3, 0), data); =20 return data !=3D 0xff; } diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c b/drivers/ne= t/wireless/realtek/rtw89/rtw8852b_rfk.c index 70b1515c00fa..8db6ea475128 100644 --- a/drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c +++ b/drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c @@ -497,8 +497,8 @@ static void _check_addc(struct rtw89_dev *rtwdev, enum = rtw89_rf_path path) =20 for (i =3D 0; i < ADDC_T_AVG; i++) { tmp =3D rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD); - dc_re +=3D sign_extend32(FIELD_GET(0xfff000, tmp), 11); - dc_im +=3D sign_extend32(FIELD_GET(0xfff, tmp), 11); + dc_re +=3D FIELD_GET_SIGNED(0xfff000, tmp); + dc_im +=3D FIELD_GET_SIGNED(0xfff, tmp); } =20 dc_re /=3D ADDC_T_AVG; diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c.c b/drivers/net/wi= reless/realtek/rtw89/rtw8852c.c index 40db7e3c0d97..32eecd184b7c 100644 --- a/drivers/net/wireless/realtek/rtw89/rtw8852c.c +++ b/drivers/net/wireless/realtek/rtw89/rtw8852c.c @@ -517,9 +517,9 @@ static void rtw8852c_efuse_parsing_tssi(struct rtw89_de= v *rtwdev, static bool _decode_efuse_gain(u8 data, s8 *high, s8 *low) { if (high) - *high =3D sign_extend32(FIELD_GET(GENMASK(7, 4), data), 3); + *high =3D FIELD_GET_SIGNED(GENMASK(7, 4), data); if (low) - *low =3D sign_extend32(FIELD_GET(GENMASK(3, 0), data), 3); + *low =3D FIELD_GET_SIGNED(GENMASK(3, 0), data); =20 return data !=3D 0xff; } --=20 2.51.0 From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2AA1242D6A; Mon, 27 Apr 2026 21:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326143; cv=fail; b=PNXBJmbkEJi8ZXHqJMJWHprRdm5k7f3o7h3pxGykcZ53Ulw3DH4Qooo/QaYuOiMfXutw3MJZjLwnj5euyGytP5NE3vAqbFYzPP95ITjgcI7GpBQ7U6UnJ/Ey03btsCHVVeL+5wEZyIUdAqYJZW8ATf5mKabJihMALP+ngi21y9Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326143; c=relaxed/simple; bh=3+RdxaChtlgx3enDvepKS2v43zsaM7kJetaA4Pxc/SQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=LTP7E1XEPJSXk6HIFn649vYDoZ2wJjTdhp2OGm7NOyzfg5cZqDcB2pF3U7zVSFbMXmchS9lf/fROWN7tUoC3fXATEuRqMoeWiwUhjToxMG0cHDEXl355j24kxczSZD+y9bS7Ed/j+NVeichVUKhWhhewF7U5F+DQRIe9O666M0c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=LS8JnAcH; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="LS8JnAcH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TDf5CayQFqGRXz4nca+oserDm6C3olIqD0UIXExsToM+uIzeRLQ1K3EKS6VD2qoEEa2Jdz18Jzh+tMQGSnsiEPcApCasRQUWUqgwqB2nIeL7ZT7Q1oSISMf0XwihyKhtyDkBGpx/32rMQCBd6FPKf3Q6jVjllndix54ObldoOh5lAY/wV4Vcty4j7/ydNzAUYdTKkwHlZBdkWSSeCdicgAV+ebF7TYHywOhyd4TlflDN1ummOOl1XbRbSisYvHyVIZXibm9ML6R9ChvtpxFne0upM6zQBnj4dSZ2ThIQ4MIeeCBh92hW0KE1lGqbGyIVWlvV8apbKQKjWmeZ93qx0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fxEiKWv1V1a4Y7+76ZS2LesUQISOVuKu8tCOpUR15tE=; b=qsYmzKPqxbbB4yarLEWxszeItX45sYr/WTs09kj9jXsRAG4cBsctqdcrZbPJJoY3i3RAoZt3YP1Bp9AYLRJ3H9Y5CFQ7Sl6BBoP2RudJPhkPvSSy09Ra0/c9TunDxjjNtg0fdIq96h1slt4kVnbCtoMVB8tMePeo49j+TOZC8CpscjXF334f+lCPtT+DsoPsQBp4rjfVWARhspRxkUSLX0izdhBNGgw0Z5SU0wN2MJlf/nlw+T+iUuYLCACp2hZ/tIYnoriWI1rysuyLolcOoDDWXl+KyIa++0MMQP+2paxGdn1sBvMEPz+09rNaMcUfTbci9c9hzbiuOnPFRbm2aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fxEiKWv1V1a4Y7+76ZS2LesUQISOVuKu8tCOpUR15tE=; b=LS8JnAcHAHGB7Sb6qQ+aqW2vPzFfouTAz7XkSbijqRe9tzO8jCxgivAXA0SfeULNiHjOrs+V5a68jG4iBcn5n3gCAS4uN2MJPl2SEQOiLiDJAVLV0gtAfX9zfwAqxLYT7ge2qJeNNAz5DQUAgpWh82Lf8ib4GycM4yU6ERgeZlUhQOkEROGIbF9cX/9ku0AwYQDJUjxc0Hi7QpuY1tYhl+isFh2Gp/FOrln/7ksg7dPpeEpyDC+4W5uAXm5LNod5fb8IQOzegQ8Kg3yWIzKmyqLpslieKDglNwBl67RNyOOkd6htiA/z9GV1PViNqJmZh4RCMW73pklb36yU1z9Z/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:42:03 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:42:03 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 8/9] rtc: rv3032: switch to using FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:25 -0400 Message-ID: <20260427214127.406067-9-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0703.namprd03.prod.outlook.com (2603:10b6:408:ef::18) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: d6cdd0af-c743-4a0c-db57-08dea4a5d1e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: Cmze7IbhsMyXaC3wvLRFom7smE++ED/2d/wpC1AqAnfJwYHZLNzILP+ZTuOmUg73yW0sQeyEUyWImzFalyNHKJ2CyOidZAiOcfFzuBSRAlLJXALF00J1+JchjbHS9t5IQusbpakoTyOP9VjbEcd7uwiIpyuss3VgWO2ueXFDhUP4LG34GdPHZTPa6nz69TiYIIS9nPDCc872mMgjfqhrVu9Z9SbXrup3Dib0TGCk3aIpk3v34/Evr5ZNlRhdA0CYmzLjAK9TEKU9xnjXI8rW7tEAndue9j+9gGExwQdzaxyoZum1DsJcOZqGHC5gnTRK3FTGC10gzWEyWjcDQZ90gH06dIW6bApZNpHyuoQdPIXCYfaRIdNUOyaBrIS99Dlxheve4c+RZWCUkYLkOACHuN81BpY6EDygLip5NPNkJfxZfKYfxSnl2buI6vGYalZDwevpDd7Mg4/SBOGqoxe1LjWBzqEXrprHalqc+DQo+h4AQW7lMI5bc+JQvJ9PqelX/gI6/ZGB9iIJ8ZvDEzovUHIH7j+CdgKyvJwSc4zpp7KxoaAV+OAY0ZcUVe6wzPlAjnIru3gGdy+am3HoonE7VKWA6aPo43XIPL+MGTEPo+jnSP3hYvoH8Q5PwaXcV4yJ6OBiD08tVVO/1xDO6yWQTr/KHnt3X8KGeFePA4Ca7Ugw69782FxP4JlSEWyPxhYwakEtLoWIEzxdpMSdKVr4Rxr0bjkrd7cwMa6w1K5PP3vDhUSdsu4C+5ZJqvWboR2Deg5bzDc+O6AWqfLYSHavIA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DCwcFUCPstnDn4fHRh+gfMqMNQ6RuA08jYnXUqtu707TGNWrr3Wg+eAECgeJ?= =?us-ascii?Q?ZhQKpG7xe8VSzu21QZyoKcEEXDV50Iqvo29Doa0iRNfSJ834xSVCvDddgsWa?= =?us-ascii?Q?uL1eK/1sqxcMYNap9jG4DGzY9uBRfgkQSLNcealEyXezCyFSlKNjz1cHFTgg?= =?us-ascii?Q?jGOCGUzQ/oB6IX/7YCyDJcU6OvCW59+eJQOZBAcgN5Vwsfy2k5vuHuDfAVav?= =?us-ascii?Q?D7M3jlijFDlVHyngeUGv8BuJNpVm+r5i9oTC7gqJMwpm0iVhj3hRZdhIDN86?= =?us-ascii?Q?T2YAdIqXIVcm4KjfqETP8p4g1mofBaWj7SYkLkbLW8eAn05MxKsuptTnuA09?= =?us-ascii?Q?XVSFRwCiuGKYZPmK+eXPbAwZ3xEeZOxR5zC2jYUOHZkf8+LqYEAC1VXuL0of?= =?us-ascii?Q?OV+6/8tnyiRB2EXtXBC9mFjHOJB1kgBZK+zBWytTebihMTFsPZCDa4SStRMx?= =?us-ascii?Q?wIDp3/wSii5VWQctTnHG8v6rdw9D3cKDL4HVSXitO45NRMnNJ1hqinlHIEM9?= =?us-ascii?Q?lCdzuEcn99wwZQ70CGKefiNnOxp+PDe/rlWpyyQ5KmVRcHl0to2seZJse2jp?= =?us-ascii?Q?4ztP4R45GEK5AaCp8ihTvQpbxORqTWK/olRBTLLtp4hsjldxhdePhCzVc75E?= =?us-ascii?Q?4UppA8NytnmBVSBUdtP2CuxCP2mdJQ/uSdkAQWINL62n57F4fe4j4uBNSxvF?= =?us-ascii?Q?JOBBrPxkc0BBBKVVjh+RczPePU3oWRckShWu7NNyIBNYYBZ5xgAJoXu1oyqb?= =?us-ascii?Q?FliZsqhSUwP/kKvMhQoPXaQwibXKiyw1r5koK5ANzBj1g4WReNLKf04flkKA?= =?us-ascii?Q?3hvYnqKXUe0Ra8hQDkePjjB2PWX3zBzf9EL0inQhJbNdlcw4BlY/ZJuWKirR?= =?us-ascii?Q?OR0ljawZETvOIvBcOMwFWtsdT1i0RKhVErbDkiPxNsisCwqGzqcVkEdpeU9v?= =?us-ascii?Q?BwJmeZsl2sLUHylh6dIdZdq+S3OX7Nh1Lh1jwxSUwdQiFhD2s+ENsGPPxj94?= =?us-ascii?Q?FHWxQdI+dlV2kJXG+yqdkA/xO7QUerHeRbWGxASMVk1M3yjZI9nifewyACRF?= =?us-ascii?Q?4qyXrIIf+v068ut1CuFFU0RsPqDGvDYmwdTg/SmtG8wMHKTFJmIWp18Y+t3p?= =?us-ascii?Q?kEfKb3sNJ8c+ozl6pD0DqeuDz2wX79fnuwud7E1yb4nlGEuH/mp8DVBUUoCO?= =?us-ascii?Q?HiN7nallIYo9B4bNu+S7P0nMMJmPnhzg4oajGUGLrEKbM3PxPnHahblHmKgM?= =?us-ascii?Q?2P2JBvDe+aU7Ay3rcov8/GJAz4k9x31PF16FI2Lp9hWrUPh7k7AczVk4bWVa?= =?us-ascii?Q?56/imCbC7Q3PFIe1ib5wzwRnD6eOvrZG8pTFZBaPiai30fwUJ3QBztohLJDW?= =?us-ascii?Q?11DLWeJqb5hKM076C2Zuf24zmKUweYhtWgLsG9SlkRarf/kzmsjoxAlEfFVe?= =?us-ascii?Q?+35kCUVkFisILzXucWQtqpv+rdkEnivgWFni9vvwat42UDCCdLw+mIpmasJL?= =?us-ascii?Q?rj3KccErgw/NCesMYI+XaWMkeIpl+rCWu1llojEKu/ppYPibGHGWErCk5Gxh?= =?us-ascii?Q?FaiksvqAcmo55IjnJrtby7cazqzjZmWNEsExYhUnw/01Z3c1Rvm6zlVWlHNw?= =?us-ascii?Q?xYPipKT519KLe5Kos9EvXYlWnUQvpD1IFrjI8FoW3CW7T/s9kkxxWk6mTkcc?= =?us-ascii?Q?B6LtDl+hdJgQtTg54rTaQTOc+bDiVQRaz22i8CfpWVkLx7+iYj6PwJz+OxTY?= =?us-ascii?Q?YhATPu445JQ/j3J53s9h9xn/SrCmYosQwjwYPncfaS/0x+JQhElq?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6cdd0af-c743-4a0c-db57-08dea4a5d1e3 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:42:03.3286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n3yERB3EATyizhBKk6OJfLa9NwWNSQpYb/8pBalHfWaSyGiixgUw+ejUBaRSnq05lYdEUo8W4clonQmkozVQwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Content-Type: text/plain; charset="utf-8" Switch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly. Signed-off-by: Yury Norov Acked-by: Alexandre Belloni --- drivers/rtc/rtc-rv3032.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv3032.c b/drivers/rtc/rtc-rv3032.c index 6c09da7738e1..6bafdec637ae 100644 --- a/drivers/rtc/rtc-rv3032.c +++ b/drivers/rtc/rtc-rv3032.c @@ -376,7 +376,7 @@ static int rv3032_read_offset(struct device *dev, long = *offset) if (ret < 0) return ret; =20 - steps =3D sign_extend32(FIELD_GET(RV3032_OFFSET_MSK, value), 5); + steps =3D FIELD_GET_SIGNED(RV3032_OFFSET_MSK, value); =20 *offset =3D DIV_ROUND_CLOSEST(steps * OFFSET_STEP_PPT, 1000); =20 --=20 2.51.0 From nobody Wed Jun 17 05:11:37 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5907E3A75B7; Mon, 27 Apr 2026 21:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326144; cv=fail; b=b0crcHanRuGcTaS2rk1MrmY4edd57y+w8GcNqJ7VKOdy2MBzqXD4ckyuGzGOhXMiO5WbCyebufLadAOOM33ntzXLYn40vQ0vkS6L/aWv9roJY4DniwsI2hbphTMlB+ZV/6wYdDaICCmZCyNgQBZOJ9I50PP72UsJb5HZ4ptXfU0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326144; c=relaxed/simple; bh=klhIQzv4remmWRP7GbUeuT79RcUz1K1FRUqDJZsk8LU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=n/ZX4GQeJoUvEBRukHaFdhfWAsPzZuHBmEVMRzHTVhpIj/YJOAl8Sk86NOtYj6NKxOTVYNazKEtAClk/VSArB3w1qI3evGCahYMGxNyrKmd3UUdGAzClS2CiTgQc2Py+WW4TbTpOz2RxppckEdNCGoxULm51ouI5AzXZfMFke7U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=bKej7/26; arc=fail smtp.client-ip=52.101.61.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="bKej7/26" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AssupH0S+bKH4JtGZCtx0wpe/eLhKFbr7fCT+M5aE6Ysrl3VyXPxQIARtpRYda93ZMyc5/YeRlRJ1HUEvW0n9OpzM7Dod/o0KuvKtY+o00Uxod7+uHVygxhbGTO9GGfOSEmxw2h+kyNBzuDmoaitnHYdLDb/pJFubEtisAD+pCR6eSjpF4HCa94hrCIERJzMogPRknprQu7Ex5WdHjW5QBvNfF5Aw3en4RwHbaGkyyMA5/YoR7axpa56iCu2OpeValJVnN5pJASpXns/xWQHPTq5gQwuJhqsl8NS7Gf8kLLNL8GgfvuviY+ARspOcHE50h0oTzckavfQDrPH4RTZUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YhEMlCS+gk5qzaIUTW6mjfmr6VnP9Ohc19O2DtAx8YA=; b=TiK5WGWUhBVICEzETfY5xKJ9YbNO22+q5pM1ROSWlP/SbnxhCzeR1TKUGOOJivkRzE4QFzQNANDzfdSq3imeTQ1MQm6YyeECYzNHfFkMgxyoexa/J0aGehT+aZEmvkkljqLpR467pK+l+dNECvqWOLTkiccwALx9lgZ+rYRB1VS5E/9HkY5WDxWu9+xABqGBhOxcKIarkyv2RDY9u9srVXvtLLV9RoWXXmz3KR/EECHSA/9dnW2QR4EczIqgOzhbD7kuSRdc7L7+cRDB8JLCx/1HUOyW8f1eYI9ySCaU8gpc9MBNemsmI7zZjJlboyKzGNnUu4ppEcX4WLdrx8m0Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YhEMlCS+gk5qzaIUTW6mjfmr6VnP9Ohc19O2DtAx8YA=; b=bKej7/269vED6UQwMi+TlVF/E/abfRK0y67L9qVFv5gTF2WxCVGthg2x0fn2ZH4vX2mnvB+ex3SRoJ1TnaRUIREPo1Xymq5TOpaff7dB2ZDTcnrL2DTi8mg0WH23F1A8869jOUBpXGt0j0Gj6eEky5/uQB3ALUgpZO2LIQNhSDNID8bl6X2FZjG4JSt5r3fvtZmkCbarVod1waQtm5GgMIMXGh2ziFAwNGkYrEIVCztCYRWmohstQloocBdOwJzEzZfBS39j9Zhsa0c0Om8JhxXkmC3hXT5o4I+ApuqQV7NldKfZk3Y1BAEQdPLwvVV2zGc4akZA9x9T0RhtLLoqbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by LV9PR12MB9829.namprd12.prod.outlook.com (2603:10b6:408:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 21:42:06 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9870.013; Mon, 27 Apr 2026 21:42:05 +0000 From: Yury Norov To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 9/9] ptp: switch to using FIELD_GET_SIGNED() Date: Mon, 27 Apr 2026 17:41:26 -0400 Message-ID: <20260427214127.406067-10-ynorov@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260427214127.406067-1-ynorov@nvidia.com> References: <20260427214127.406067-1-ynorov@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0548.namprd03.prod.outlook.com (2603:10b6:408:138::13) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|LV9PR12MB9829:EE_ X-MS-Office365-Filtering-Correlation-Id: ced701be-80e4-4701-f10d-08dea4a5d34e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|376014|7416014|1800799024|366016|921020|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: UpcHuupd9rTpQWlQonfjFHvVSc8x2JV8fktSK8HuZgZqbZiUGQL79gOHmznAQtaWjkEfe3rCmu6I9+lfYIXIk05fjeXX8bjbt+93fV7PkzTmm6TCc+eSEVwYCywE0WJRULUTv1CeiHhzae6G7w9Y6TJmGikKX0FOPhGdtKEKgdNnUBuLZY7MvWBv1OiXQTdI+SIyWoCfEglXGwTMxZyNCO2fx6eB3K1yu0CGA3/uLnVQjBzvjvEP47C3qVVKp1apyVzyBC/gUh6ivuUfuQ4b/F5lspIKCJFulJEPK/T6KHRz52C7thapCF9zxC7FdyUHFFk3yJW4+qx4veknErYGLQQmpfm424MTSriMUO8n6rBPwW3Q/CyTSNd5zOEksNg6mcetVDTAItEO56nTVkDkGCPJuytvSOz1S3lNo6wwisz73tVON4AgsRaxAuowra938qnT0LFOSrjc95lvJt289vu7NNIzK2f9UKZbhRFqZk8eQnNT0ZOsie/cOl0+8mxiuRbpNUY4TKkfj+QcKv+hAuzZvYz6EUx2hU5iDd+uR+tx+mXmSNp7/PuOMMj0LZUHL6ks4RtR4q/LgOuMOoVkaIuL7XF5O29K2AwtNmunndaPNQy6v53owOn4oJIQl+lZNKXN1529L5Z9ruv5unFTUKoH9Y1xKJvR+TrGQqI5CX/3MbKn2F8agr6mbeg1vS0uWHeQFdHW4pl2NYUtMf1HyB11jTcPUPL42xH9XhlXXDnfErBUSZ2InkZSYEXaX8Yud2R8OU2UbK1CTkXbBHBEeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(7416014)(1800799024)(366016)(921020)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O/kokQ8FiCtYOoUSRmVrGAyld+whJ9lNuq1WuG5e0K+QLQYYIVwlRSAequ6z?= =?us-ascii?Q?o2j8FBF5OTHACMWAsSs3ZOZlGegK0aKdRF5/vPN53kNeWm2hpgEekLypr/HI?= =?us-ascii?Q?K0ypZJnpYy/LsUCYqJilnUV8lVj8V1LwdM3xGKScT//L9dWOCBH2QnSJ3InW?= =?us-ascii?Q?ODTMuo0jxRFW2r6h5WlU/3JMj1kx4rhwKJBKIyWW0DpV4JcBTwXeOQfINLKL?= =?us-ascii?Q?KBo/lK6+TiBLdzbgCiaH/7jlsPOtSYTvxwVEjna1s9dAuRTgiVDByKnVd1sA?= =?us-ascii?Q?nrGwp/JoFNQjzJB67+41r/VF7/Bwv0eaLPOvHko8ERjAjpUJTvWnKYU37r7y?= =?us-ascii?Q?ZKfbQCGlqkjTU9D8b8XbPcrp7kkPoqgGPWJIM2I7S12KbXWrZllBmQJqOQiK?= =?us-ascii?Q?g23ab/NHL19rm+ETuptuVAYFx7t7sf8bl7HvUXtXC7D1YBrGNHjJsJjkdl9m?= =?us-ascii?Q?SGW98Mun78/YLN+w5+D86tTwor4fd88FpyL5K/pTOSj016PsykIl8ujuwT79?= =?us-ascii?Q?pboAUwaGisuzydXOqGIVUQGF5oqK9yZ8nqeAcll5DqNKgNZOwdJOxQq3ZFy0?= =?us-ascii?Q?IEDvrh5NM1L8nEYH/6GSMehFoWiXAxxD+lKIZ69BGXhiFOdD/1x4bCoOIfC/?= =?us-ascii?Q?adWCTF8sbJ4rh8C7BoCMDCtAg3zQOF1dZynqsIcGJyi1n7DHdQe+et8Jz8mF?= =?us-ascii?Q?XrSn95fZunYUZPs3o5BDEDo4RKT8NkorMQJlPwLP/9CvW/jH9jo4sMTxrbtH?= =?us-ascii?Q?Bcxap3M1tzJ2R3EQMctxrkxdeMOPozA5QRk00F/e7oy67tUAJegsVBfq1rlI?= =?us-ascii?Q?+lNvG0P5jnXyWns6mXEuoVT2Hv/YTmoE6j/6VfnLeecYdU17psbvFiPYvNGf?= =?us-ascii?Q?5ZMyhGtC3gj4oXrnEDorW60bCENqhuoL1y+eOaqkb+G+yBqZ5E6rF+rDJsDe?= =?us-ascii?Q?Sk+18UQJlYqpJ8rUCv8Q8aIvAgLEBnN/COOwrLxfx/788bnRNIx4X6utEBgW?= =?us-ascii?Q?PgXR9DEuGhsQ3zYCe99j1IKCEItERHpAQakhPAX1e58X30TrP+WoWP5opM86?= =?us-ascii?Q?TzHmg0tY2E1eYxJNfR7uxrsdJpJZvrUqc9pJpHSyTcXBVdAf/mjkXVRyyohy?= =?us-ascii?Q?x3bBd7d3FhOIDVZIOGfI5ST7X8FlwSwLOA79LHQK+UyDl2VuR6oJEIAt4q/H?= =?us-ascii?Q?UKUdnMt++CMwWVdI1QROytDu0/rPAlw0819ShzFC4NxsXA+h6nI0wnRVUXEM?= =?us-ascii?Q?mcvyN67yGR932EowbR/i3OAAnmmspVkp7AKFMRKy8sOG1rMwNse9bMG8T3TE?= =?us-ascii?Q?tuFMsHoYmofc68Xnt6pl+l62ERs2cPrE3E5YFMAkSlkfn25PJW9pNEad9vuf?= =?us-ascii?Q?wqJ0yYND92Id6qPTQsDZRglXc93yS7Os7dZkVayhBzFCcFfpX+LxosaQ6RAi?= =?us-ascii?Q?kOoXRphLOIAhRwrG1TGK+sGJdLLKbpL45VCW5W7TnmngsHeH6Z49/iuCDGU9?= =?us-ascii?Q?MqGqasU7g1hZMd77KJyrSZvSxlhJh+1EjMdWRO8npmaqBdEFcPuJDU8Qz4EE?= =?us-ascii?Q?0tH/QrUbuXVtjJjswDlYsuxdU3raC+AwsGVzcAgSYkNMDLt++zzb/txqp3H9?= =?us-ascii?Q?tX1/jdGNVcXJc/mKUCDykvA8MIm8I5RBYQEEOCXyJ7GXFafZZRMxTt1ZDN/j?= =?us-ascii?Q?VmapkC5BtwmmFyMOAkwdRE30jES2AtpSs8U6+V/YaB5uozvL2DNfX1eD7saE?= =?us-ascii?Q?xAZLy8bVReuv5oDXeb6WZtMMjRqXgm6OdEcRjo/i7bbqtfchaeOu?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ced701be-80e4-4701-f10d-08dea4a5d34e X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 21:42:05.6485 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e+kEhbL6Atkk8mN4bWyp0cFWJpzUnGJ5BtVEYInC4Bl65X5/SJ2LqSntEd2mzHG3dbOOi7elMzT1QS9sLrTKDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV9PR12MB9829 Content-Type: text/plain; charset="utf-8" Switch from sign_extend32(FIELD_GET()) to the dedicated FIELD_GET_SIGNED() and don't calculate the fields length explicitly. Signed-off-by: Yury Norov --- drivers/ptp/ptp_fc3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/ptp_fc3.c b/drivers/ptp/ptp_fc3.c index 70002500170e..f0e000428a3f 100644 --- a/drivers/ptp/ptp_fc3.c +++ b/drivers/ptp/ptp_fc3.c @@ -55,8 +55,8 @@ static s64 tdc_meas2offset(struct idtfc3 *idtfc3, u64 mea= s_read) { s64 coarse, fine; =20 - fine =3D sign_extend64(FIELD_GET(FINE_MEAS_MASK, meas_read), 12); - coarse =3D sign_extend64(FIELD_GET(COARSE_MEAS_MASK, meas_read), (39 - 13= )); + fine =3D FIELD_GET_SIGNED(FINE_MEAS_MASK, meas_read); + coarse =3D FIELD_GET_SIGNED(COARSE_MEAS_MASK, meas_read); =20 fine =3D div64_s64(fine * NSEC_PER_SEC, idtfc3->tdc_apll_freq * 62LL); coarse =3D div64_s64(coarse * NSEC_PER_SEC, idtfc3->time_ref_freq); --=20 2.51.0