From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24BAA36DA0A; Mon, 27 Apr 2026 20:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320868; cv=none; b=lWx9C7U4R2Ef1bvbV92Q4+gd5yGJ0EjEdp1kVJw8zwZrc4fozyifBZXXsklmEIcu+Qab0IhYoRs/1GKLupO1b7HCLXowj8D/jqQV3HPwGQvnFWKApUSfvf25+R0OXWlsulXbYpNl8x2ZG1RY3V79F4Cz2JB8SHuk1TopS8mQEnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320868; c=relaxed/simple; bh=aseIrcz6Ex1dScsc0MGOOOOU+gdhgIyBS8RygfiFzl8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AFntXR3MWG+Z13vJibyMW5SdND36pi1dmFdzhIARGna+I1IuYMwoMvRctOIs5MaIBvF2bMg2SuaAVFLSiowbexbz5/HW9tDFx6Sf4wa+MnmnZLh8DePdWgrYm4QpfWkiEyC2MYdKCtj75bKYN04lOR3HF1z55bWkAsRtmN9F92o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SFq4Zm2h; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SFq4Zm2h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320867; x=1808856867; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aseIrcz6Ex1dScsc0MGOOOOU+gdhgIyBS8RygfiFzl8=; b=SFq4Zm2hMxjLJ4mGVikGqw2/CKn9BXJqy2tMVrpKf4WRLiUx9YMlvxPZ pc64xvZw/fxMPOTikFuLqEycTJzmlQy04qy7iUfr5aEPXWixnXuFmNSUx SEx5MNiOKrGUGKQL0CQRO6p1efkRr2i0VcT19QVjJDhtk21TU3ExJScxJ Louc+MRDLd6nNd6d7Bj3EV8Of8RoyI1mnRF1BMIKIGHiAK7cQlbQpW7M/ ngFLud0SS4O9NI+Fbld0rMEupiNsaTLPTcSUfM3wE6QfZxLj82HsUmho3 rPFI7s6viZo1zz41SE4mZKLx9RMcJByFg03z4cycAh8iWBbVxlG77ke0W A==; X-CSE-ConnectionGUID: 6VstPah/RSK9BoAqx0KFYw== X-CSE-MsgGUID: IfDT7SnRRWur06Qq6HSkyg== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384096" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384096" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:21 -0700 X-CSE-ConnectionGUID: wwlj/bV9Ski9frqy81hhng== X-CSE-MsgGUID: cVSxsieMTYa4iapN8+C37A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857721" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:19 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 4B3A798; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 01/14] drivers/iio/magnetometer/ak8975.c: fixup for the IWYU change Date: Mon, 27 Apr 2026 22:09:46 +0200 Message-ID: <20260427201412.3067235-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index c09db212a6cc..378940e82550 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C365636AB5E; Mon, 27 Apr 2026 20:14:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320868; cv=none; b=dd14XPFFDeeDBLMzXpexjzqtecj4saN3XI1hXhWhZ2ugaOSP6G0ZM6JThyjp3i7SNJ8chuGG2IGLkxNrQztroIyA7795PSnv8tZd0sSM4buzy1SoS/ZSQGclIso7Iiy4zMYVsPy7Ua3p+vlQ73iQckONrUHnrNKn7nYK/YVoOtI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320868; c=relaxed/simple; bh=Q7qtNXag6aWKfMJ6Hbb92WsBS/EGMi9QSTNvOE5ITFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t3bjFXxEw0V57FQ+i2Qs1RVPENLbJeNCr72Zls6Q+LkSvtbuNZymgjVlqCKlJIOgcmO4E30843omcQnnIwMYvskqorF1fl+2yNgaZH1yM604EQ1G30J6i6iRjCy1FPhDVloEoVMgnVS7EKtEU4Nbt9u3KvXvvrzlf8VHx8/D6S4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ceH6isge; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ceH6isge" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320867; x=1808856867; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Q7qtNXag6aWKfMJ6Hbb92WsBS/EGMi9QSTNvOE5ITFA=; b=ceH6isgeQOXXq8G8ymJwTLbXUSbB+7BnKoBVzY3vUWo/SGEAJxwfUFxo L7fbVqZ4y2MWTgoOgbsm+5A0Juq+H2FF5qqdEIqXo0pYvDO1K7f7T3jUT KTuNunH9RbBIb6Dvh6cVxvqfuMnsr0KRNltdbqXVEiFFSgJ873B8E2XN0 sYd5as+R+ZXFHM4zL9Sd54Vhyix46pmSOcUi5JKWvnuyiRfj8M4d2d0pp NSJSirG9SaFId9koMeJFBCXOTfry12eaS5mgq9sljocSgjN9tunEzCmnK KtQIhbIRosm0qNOK9NWJBFsQXdSJBEaepUwVWs8pfq3nU2SKKLvvyJxyQ Q==; X-CSE-ConnectionGUID: rlkmBr/KRji+Gdtu4jI8ZA== X-CSE-MsgGUID: sI+ZnEY4THyrZ7GEepWDIA== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384084" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384084" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:20 -0700 X-CSE-ConnectionGUID: urlWibbWSwCuhwkpBlm81A== X-CSE-MsgGUID: FbMHmlN8QA2f0/7Zp+7bZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857720" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:19 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 4F42499; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 02/14] drivers/iio/magnetometer/ak8975.c: fixup for the errno fix Date: Mon, 27 Apr 2026 22:09:47 +0200 Message-ID: <20260427201412.3067235-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index 378940e82550..833ee7ca9f46 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -693,7 +693,7 @@ static int wait_conversion_complete_polled(struct ak897= 5_data *data) return val; } =20 -/* Returns 0 if the end of conversion interrupt occurred or -ETIME otherwi= se */ +/* Returns 0 if the end of conversion interrupt occurred or -ETIMEDOUT oth= erwise */ static int wait_conversion_complete_interrupt(struct ak8975_data *data) { int ret; @@ -703,7 +703,7 @@ static int wait_conversion_complete_interrupt(struct ak= 8975_data *data) AK8975_DATA_READY_TIMEOUT); clear_bit(0, &data->flags); =20 - return ret > 0 ? 0 : -ETIME; + return ret > 0 ? 0 : -ETIMEDOUT; } =20 static int ak8975_start_read_axis(struct ak8975_data *data, --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90DE834D911; Mon, 27 Apr 2026 20:14:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320866; cv=none; b=hz6rpS4F4Tve+6YyS6B3LLoRqbyjwPacewKD1OuGBD8SBByKBmg5b8Xqaqwz5Cc96Kich5bG34gWoFX+ibnCNEKyl+5w5S7/IKDiwS03Rn9pZDpPo227txWqdk0sY7YwnZRO5/IIwOi/sFfwTXesj0J97VyXTSRfHjzrO/LC/wE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320866; c=relaxed/simple; bh=RtKsKY072NESOXa+UJHijk0YAKoJeRw9V3ZqEU5r3D4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ls+D7dpmc19rmNcwR0EKAF+x1/35RM/z/dQsCijijZdCaN2Gv1aksM/Ikgd4V1a3q7A7zPMMRoPXLth8YM/1yvNvb1othttOOhUGR8mBGKK8XB0WmSTXPF+ejFwgpo6uoeuDPxMBhnN2V2dPbIwwoVf2ZL8tE5p8MvpOrx+/Ers= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JH3vY087; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JH3vY087" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320865; x=1808856865; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RtKsKY072NESOXa+UJHijk0YAKoJeRw9V3ZqEU5r3D4=; b=JH3vY087qZrIWZ2C38GMDuo12C5FTpvPrDG13yQec1/O00+G/vO/upL9 4H03/Mjw/7Mr9nQjk5mpNW6tQ8AUK/85qIb8GaFAtuomwugU6ZAc/yxvA ErPTsB1zaoSxkZ7f4/PthEJyMwptxkSW2FrHBtXC2q9GNIme0XfuH4el9 2TbQdiDdwC/K49OwAYmLgk5L2uOb9o91VaIq/cdXpMUO1lZ6X/GTAVppE EWqYMGstWUaRwrt22Ax29LVS9sI+lAC3pgyMB3zvFJrLT9vVg7NW1UOrG 4BGtHACff2fxhKv8XlfrF8PNnc49DnPo91Qvf3Ri9l9ta9PelB6tzzwa2 Q==; X-CSE-ConnectionGUID: UXVB13pxSmCU6Wk+FVArnQ== X-CSE-MsgGUID: f1WPfSW3RPm61MLUEUd1Jg== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384091" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384091" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:20 -0700 X-CSE-ConnectionGUID: cK/OvxHNQwiLrHLNv/zRag== X-CSE-MsgGUID: 0Sg3G9prTpubkjAryyVxQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857722" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:19 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 539AF9B; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 03/14] drivers/iio/magnetometer/ak8975.c: fixup for the iopoll.h conversion Date: Mon, 27 Apr 2026 22:09:48 +0200 Message-ID: <20260427201412.3067235-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index 833ee7ca9f46..4cc92a15e937 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -657,8 +657,7 @@ static int wait_conversion_complete_gpio(struct ak8975_= data *data) int val; =20 /* Wait for the conversion to complete. */ - ret =3D readx_poll_timeout(gpiod_get_value, data->eoc_gpiod, val, - val !=3D 0, + ret =3D readx_poll_timeout(gpiod_get_value, data->eoc_gpiod, val, val != =3D 0, AK8975_CONVERSION_DONE_POLL_TIME * USEC_PER_MSEC, AK8975_MAX_CONVERSION_TIMEOUT * USEC_PER_MSEC); if (ret) --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6035E372EF6; Mon, 27 Apr 2026 20:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320870; cv=none; b=NdfpjdhP6Y0grtC3tXWdGzzcaUZ3LVySO59dgD3ZlOwY9GRhAU1O5U+aG2+oJWexW5nEV+utkuovOxlTd4ycx9IJyZTxIPM3Wl3R1itLGsAuHo2NB67ImlBMwrSMh/YE1EPJfVOpKoJZVC7DtRqzAVcyXzHpkbKhxfZYDnoSgg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320870; c=relaxed/simple; bh=CVRZYCazG89I7PuoYcnKfEFYQtBs0D+MXygDnumjph4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TA0YDesJ3B7MqkJR6AY2uGMWkfemtqWxZbcQ24m9yphBvp4Pw/81AhRr/QFVAUMA6Sw4Q97p/KJoSicnaGm+Q7IKOW18HBHcCDSEkRdkwDD6vW//Xr34JJKYx/oUOgoaCSLgqyTK1u+AuQyYBtJ5ylXqydF8LC7HE5gqGV9zLvY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Y74C4vO5; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Y74C4vO5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320869; x=1808856869; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CVRZYCazG89I7PuoYcnKfEFYQtBs0D+MXygDnumjph4=; b=Y74C4vO577tihhD71G+3aMiojXvf4YqQkpDsotLmV8nXvIuR69MSSFjg R/HKjP0awUixAUiua5O+cY/J8uQPg3k7x5dP6g0trAyWDPfWIb4PmFpOw 34xZUtx39oVqyw5Ts0JHaYa2rbwMSbEJo884N+5qgnv61vIyzo9JChAgc y1C/Uu+KHjaq0khYt3D32o1qSlM8Ll+RYAMVIXAw7en2FBrBdEhjItXmA OBL7qYccCDo3DBt0NWfB7zG/eQN1SY7oxATakqwBrMGBsbPVh8OPmojp/ zwPOHcSthvC82rp1Pqrx9uLHVVmfn5lKeqH2Ha9hSPEhGxlEYY0u8rRUS A==; X-CSE-ConnectionGUID: zLdhHprwSSG0VX0+gacV8Q== X-CSE-MsgGUID: FDT7KdGYTlmkUKMPLz5lKw== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384101" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384101" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:21 -0700 X-CSE-ConnectionGUID: wph6QvYYRayC84PUF5QHTg== X-CSE-MsgGUID: dfa2BUyPSQ60u1jKse/JhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857723" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:19 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 580E89D; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 04/14] iio: magnetometer: ak8975: Inline timeout constants Date: Mon, 27 Apr 2026 22:09:49 +0200 Message-ID: <20260427201412.3067235-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since we have switched to using macros from iopoll.h it's better to read when the timeout values are explicitly provided in the parameters of the respective helpers. Besides that, fix the home grown and obviously wrong in some cases the jiffy-based timeout. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index 4cc92a15e937..53987f3b13d2 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -133,13 +134,6 @@ =20 #define AK09912_MAX_REGS AK09912_REG_ASAZ =20 -/* - * Miscellaneous values. - */ -#define AK8975_MAX_CONVERSION_TIMEOUT 500 -#define AK8975_CONVERSION_DONE_POLL_TIME 10 -#define AK8975_DATA_READY_TIMEOUT ((100*HZ)/1000) - /* * Precalculate scale factor (in Gauss units) for each axis and * store in the device data. @@ -658,8 +652,7 @@ static int wait_conversion_complete_gpio(struct ak8975_= data *data) =20 /* Wait for the conversion to complete. */ ret =3D readx_poll_timeout(gpiod_get_value, data->eoc_gpiod, val, val != =3D 0, - AK8975_CONVERSION_DONE_POLL_TIME * USEC_PER_MSEC, - AK8975_MAX_CONVERSION_TIMEOUT * USEC_PER_MSEC); + 10 * USEC_PER_MSEC, 500 * USEC_PER_MSEC); if (ret) return ret; =20 @@ -678,8 +671,7 @@ static int wait_conversion_complete_polled(struct ak897= 5_data *data) =20 /* Wait for the conversion to complete. */ ret =3D read_poll_timeout(i2c_smbus_read_byte_data, val, val !=3D 0, - AK8975_CONVERSION_DONE_POLL_TIME * USEC_PER_MSEC, - AK8975_MAX_CONVERSION_TIMEOUT * USEC_PER_MSEC, + 10 * USEC_PER_MSEC, 500 * USEC_PER_MSEC, true, client, data->def->ctrl_regs[ST1]); if (ret) @@ -699,7 +691,7 @@ static int wait_conversion_complete_interrupt(struct ak= 8975_data *data) =20 ret =3D wait_event_timeout(data->data_ready_queue, test_bit(0, &data->flags), - AK8975_DATA_READY_TIMEOUT); + msecs_to_jiffies(100)); clear_bit(0, &data->flags); =20 return ret > 0 ? 0 : -ETIMEDOUT; --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A534A374E6F; Mon, 27 Apr 2026 20:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320870; cv=none; b=MSbl6XLz4H0coEKZiMKdwpu770wQv2xH1LJnRhIyu1pcdeipc3pXX4+FDeykSkzmmB/WreOcmhIDGdr9p/XU0h1RyCon3C1o5L/fPydXOumz9z89+p1Qbx/Q2+acBwsjpNs0BwiJJ3u0+XMyAtbHLpOLDn9WJgyydo664AEiUA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320870; c=relaxed/simple; bh=JztD/4jQB7bnX5nFIToIiwdz0tTeOpMBNe7z3mvFR8Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=piLNe4A5T0OneGKSJMzpnp9yd8HLkEUMWyKIPh2GfGVT2dTz3AMghpYU1Z0AHzitTCxKIrsloVnUlOOXYNGMDSBX60iypuEOSUmjj/Y93VeEiT/FDXQaJd/zu1lcfrHr+Ra1ySwwuNr12tRSIpFaqwthwqvC5kkM7k/ZzLaefnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cMmV7RSc; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cMmV7RSc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320869; x=1808856869; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JztD/4jQB7bnX5nFIToIiwdz0tTeOpMBNe7z3mvFR8Q=; b=cMmV7RSc7ZvdeXlVvvRtJXjwIPXYQRu0Rjob1HkawDBLtdqQ0js8HDWp MNLyZ74J1Cv7zPeN1FcdjS3A1m8nXcqndh3WQ/aCqxPWJlhWHDTEhyHFu RpdYI3Xjz56EeOHkNo6bXidtZrBNwGycpUPrLO+Nj23yQiJe5Fl8JumFV 4JpQpiK97KuZpzFljCM9b0rS3yf5VrUjJgmvP6yxjkMwcpP6wrWrW/+eF +hV8WuKkc98rp9Dw2wxA4Xafq/k8cUrFbnbY8G3o8U2WGZO3+SH/eDrPt TV9BPMpk0mUcGxvUqEO6qe1EAbgSsRVTCs3NJDt9pvijSlJ7Z2ybBbFJV A==; X-CSE-ConnectionGUID: wsnKYp4qSXCOszuwZVBUjQ== X-CSE-MsgGUID: dhFa//MES0u8zv+jyCf3Fg== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384113" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384113" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: DhWRuzd9QBSIlvtvDBxZPA== X-CSE-MsgGUID: VCkXpuCvR8qmBMYP3K3fTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857727" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 5C5079E; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 05/14] iio: magnetometer: ak8975: Avoid using temporary variable Date: Mon, 27 Apr 2026 22:09:50 +0200 Message-ID: <20260427201412.3067235-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid using temporary variable in ak8975_read_axis(). With that being done, the clamp_t() call becomes idiomatic in the driver and can be factored out to a helper later on (and if needed). Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index 53987f3b13d2..b70fbef1ea3c 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -729,7 +729,6 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, = int index, int *val) const struct i2c_client *client =3D data->client; const struct ak_def *def =3D data->def; __le16 rval; - u16 buff; int ret; =20 pm_runtime_get_sync(&data->client->dev); @@ -766,8 +765,8 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, = int index, int *val) pm_runtime_put_autosuspend(&data->client->dev); =20 /* Swap bytes and convert to valid range. */ - buff =3D le16_to_cpu(rval); - *val =3D clamp_t(s16, buff, -def->range, def->range); + *val =3D clamp_t(s16, le16_to_cpu(rval), -def->range, def->range); + return IIO_VAL_INT; =20 exit: --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4BEE34B1B0; Mon, 27 Apr 2026 20:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320865; cv=none; b=Piutz58AoN2NTrJLHt25tUjFT5aRoflMM17+sjOw4JFph7dBqobrH2nudMyFno5Wj6eWGKOXRlJL4hs5hqLnRRYxMF+5yXll7GUtaf7flpo1PIkiNpo7GWGq1KvwKB3YZ2b8TWVm44Ih7ZO7IC/VeOSMsEWS9GfZNmm39/rcavI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320865; c=relaxed/simple; bh=JIGf400tD/IcjdcJvugGuEpXAmyKM8a3/jJ8QYWNqcg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VI8RpLp3Wlble7Swt1uPI8WHn7+KeMLJCEM2oBD/Moc6sUFuEoYoxxAnlBodziNd+4jAEjXw9MXI3KuQi2PcVP/Sc9lXioPji5/dwE5WdZG8PV/GsGj0sMqJMome8LgIIgbEkQF3zyhTJn/vo+85+m6g0LrPuSNjHGmeFmxD7Js= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bpnrfx+7; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bpnrfx+7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320864; x=1808856864; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JIGf400tD/IcjdcJvugGuEpXAmyKM8a3/jJ8QYWNqcg=; b=bpnrfx+7NUG8Fo2CVWZzwcXDxaP2UOj98qvY4qn5Rx8JyUTtijoAsoSt 1hkwgsHilSfe5wfnBbWt9P+pfHje0n74NYAPzt0/l4daFL3OR1zl92P0i +zKtvGjI735lh7LK3VnEyEtj5OeYSUuQSApGGzcK08JAZqWw2it5gUNSF kQVTcus6PJzQgYlSk0iQoA5vgcggqbnCRbJofSqieoEAwjA+nPAxF+Ncy wy/6iU6aBNKaMTRvwGY6w+E/gHZRZlidQnPsO0ZmOs3mFjDu73+YotZN9 w6oPHEZsdYj3pzEuDzTcFZT4LRbMRc2z9swCl/GGMC6PxV1+qBCZ03+4n w==; X-CSE-ConnectionGUID: C+xpYjKbQHmQ91CFJKvIuw== X-CSE-MsgGUID: gXlTgODPQ2ytSW8Wx19x/g== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="78138353" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="78138353" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: pIrw6MJERYihgyOOZAz/7w== X-CSE-MsgGUID: yR3F4St0R/ugveSC6nZd3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="238074769" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa004.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 60DAFA1; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 06/14] iio: magnetometer: ak8975: Drop duplicate NULL check Date: Mon, 27 Apr 2026 22:09:51 +0200 Message-ID: <20260427201412.3067235-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The gpiod_set_consumer_name() is NULL-aware, no need to perform the same check in the caller. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index b70fbef1ea3c..288bdb3bf14b 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -906,8 +906,7 @@ static int ak8975_probe(struct i2c_client *client) eoc_gpiod =3D devm_gpiod_get_optional(&client->dev, NULL, GPIOD_IN); if (IS_ERR(eoc_gpiod)) return PTR_ERR(eoc_gpiod); - if (eoc_gpiod) - gpiod_set_consumer_name(eoc_gpiod, "ak_8975"); + gpiod_set_consumer_name(eoc_gpiod, "ak_8975"); =20 /* * According to AK09911 datasheet, if reset GPIO is provided then --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3D2035F8C5; Mon, 27 Apr 2026 20:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320865; cv=none; b=PMTq4hLdpBGbN9SEolECUgKxw3XT2t1VvizeyBCrcNLitilae4sMIsxltazw0aLnUcGiGSWN+JEWiVuq35sE8B27hJGN7ErpDDUVOKaOshflYOVw4jkeGhSWbMKqm+8Z7HvTLFyO07ZdjXeXMrbXJ+cGOLptVby8mE9eM2f7o2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320865; c=relaxed/simple; bh=QYgEMYbhm3EK8rVSz7/6YWVSQPkpF5v5THgixu78Itc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lAelL75MgTD6oocyxwVaTvM2LrD67Pe9I7Nqfo1qd3z2HhyktJtI9H83baiEl8K9xqepSCsx0rE0KGTxn9e+4isHUlGJtw3iJifDUd8vGJWlnuMX0OI/1lUdtfzWLJg/cVE5buHJy0xLmy2gxn+3i5HvefKEW/dzdOW+3+5q28k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oDH1pqbo; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oDH1pqbo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320864; x=1808856864; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QYgEMYbhm3EK8rVSz7/6YWVSQPkpF5v5THgixu78Itc=; b=oDH1pqbohUN2qUxNv1slvlD6l+PAGmghPS7hxSmlASItoxkeLy6m/UKm kmO5g3aSp4gDvNdv18sykcBMOAniL7NK/UL5GX4xdywxzinVWGzt48jRU Wg6jcvq1iXrRp93lcg2/o30b+XTK07F950L6NOhW35ADINb5zBhV0L6Ci nrvigX9AmuVMGc0yHgvtGkq6LBU3pc/hiot3+dqg3hMgS5H1XBTCjIJrS laJm8S6phwTEA2PvpNJqn924DIpRuVdr111W7+IB6VKz4GBtee6oEqjye Kb7gQW/TBgjzlI3PDrg+qRfewIBpDbGiTrCHdrVPgz0R6knrFz/Xa5DyK A==; X-CSE-ConnectionGUID: pi8Ob+5fTGuPJYlAGxTZ3w== X-CSE-MsgGUID: 9FF5810QSGWK5zrz35UH+g== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="78138358" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="78138358" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: OxEHzRWuSG2ULTBKKvS39Q== X-CSE-MsgGUID: QzTHqTVJQtugm5yN4Bkr0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="238074772" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa004.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 656EEA2; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 07/14] iio: magnetometer: ak8975: remove duplicate error message Date: Mon, 27 Apr 2026 22:09:52 +0200 Message-ID: <20260427201412.3067235-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_request_irq() already prints an error message. Remove the duplicate. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index 288bdb3bf14b..dbaa64c66e4d 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -584,17 +584,14 @@ static int ak8975_setup_irq(struct ak8975_data *data) rc =3D devm_request_irq(&client->dev, irq, ak8975_irq_handler, IRQF_TRIGGER_RISING, dev_name(&client->dev), data); - if (rc < 0) { - dev_err(&client->dev, "irq %d request failed: %d\n", irq, rc); + if (rc < 0) return rc; - } =20 data->eoc_irq =3D irq; =20 return rc; } =20 - /* * Perform some start-of-day setup, including reading the asa calibration * values and caching them. --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A3937AA98; Mon, 27 Apr 2026 20:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320871; cv=none; b=ec/VIkKKXWNq8vbm1eZunQ1JIk7v9c/KExyYinWwqxwyBci9YpDyyupzXBtHj8uO719kjnPbQ5zgxszobVA8GcP9r9GicvMpuKBo2T0g5OvP895moj5vA1DxKpowVhYKUuJMqyeibfrn3Rp24rEVQqefOZJcnlA8lZLcjLgCzsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320871; c=relaxed/simple; bh=vm9VO9p5mzpqWI5oVoVUa2H4DddECknhlZG4n1fkysc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OWZq/ZY9eigO/CearOttb8Tc9efSIdvkQFEm8jw+AttaGPfOw/G3KEfIkvmYIuJ2AnI6nAOAw5Dxy76SBHNT3neLS2Q6DEp272WasMVgTOwIANGSscGs2N04xuUkJBf5A35IoB5W9n3AJa/RS3rCsmJuczamEMXlVCwXQf3yrhY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MN/tTBpM; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MN/tTBpM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320870; x=1808856870; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vm9VO9p5mzpqWI5oVoVUa2H4DddECknhlZG4n1fkysc=; b=MN/tTBpMxuekgEjQjJ5yplaYgsD5r6pm2lBf08n2ciBkek66dovUR/y/ YfYErJLLo+v5CE7a2g5R7taMHUhLVyfV3TWKlE+NcQ1SJ5/Tbph0/5utf MxAsoPZvkbQf1YXy9f6xRAitr1aYK7vPUJu24U1RUL3+qh9/JQBDNBGdK JsdB/QimCrXJRe9U15n6SkgSpC/JuU9iUf3VuLFjeZBcTwjJdzVqPQcWH vNl4jyEJi1nnvib3mVDtVVgBGhlVP2yn/RYkG7LkXnAcfzSMEDGK2mZ9+ 151h/MqwgaEcPvggRLdOiWolo8yWG3oxfpDOFOC1SJAbi6NmZ0OzLUP8s A==; X-CSE-ConnectionGUID: yIh/CpaDRZ6N5zZ5vmIDBg== X-CSE-MsgGUID: R3jIqwNNQ6ODGeWcbSWy1Q== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384114" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384114" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: CguXh7KsS8upwVOHx/Bj4Q== X-CSE-MsgGUID: dIpMIIoNRhe5W7zB/hEPvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857730" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 69E73A4; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 08/14] iio: magnetometer: ak8975: Reduce usage of magic lengths of the buffer Date: Mon, 27 Apr 2026 22:09:53 +0200 Message-ID: <20260427201412.3067235-9-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reduce usage of magic lengths of the supplied buffer by replacing them with the corresponding sizeof():s. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index dbaa64c66e4d..7ec1d4848fca 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -490,8 +490,10 @@ static int ak8975_who_i_am(struct i2c_client *client, * AK8975 | DEVICE_ID | NA * AK8963 | DEVICE_ID | NA */ - ret =3D i2c_smbus_read_i2c_block_data_or_emulated( - client, AK09912_REG_WIA1, 2, wia_val); + ret =3D i2c_smbus_read_i2c_block_data_or_emulated(client, + AK09912_REG_WIA1, + sizeof(wia_val), + wia_val); if (ret < 0) { dev_err(&client->dev, "Error reading WIA\n"); return ret; @@ -610,9 +612,10 @@ static int ak8975_setup(struct i2c_client *client) } =20 /* Get asa data and store in the device data. */ - ret =3D i2c_smbus_read_i2c_block_data_or_emulated( - client, data->def->ctrl_regs[ASA_BASE], - 3, data->asa); + ret =3D i2c_smbus_read_i2c_block_data_or_emulated(client, + data->def->ctrl_regs[ASA_BASE], + sizeof(data->asa), + data->asa); if (ret < 0) { dev_err(&client->dev, "Not able to read asa data\n"); return ret; @@ -853,7 +856,7 @@ static void ak8975_fill_buffer(struct iio_dev *indio_de= v) */ ret =3D i2c_smbus_read_i2c_block_data_or_emulated(client, def->data_regs[0], - 3 * sizeof(fval[0]), + sizeof(fval), (u8 *)fval); if (ret < 0) goto unlock; --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C290332EC8; Mon, 27 Apr 2026 20:14:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320867; cv=none; b=EzbbcbT+rwkO7wrHzHSuZ1DU+EaySQLxLuouyNJOVxHOpf9gB+gC9JCbMcZ7T7ufIGooO8Diq5oaKHugJenvibR4l8wt7+xu0jdo9+7AUqekt0vpD+sXxDX7fezIWCrE5lms4Momm/BEB2H7Y60An0xbGT2TitPN1Sio3DmkgCY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320867; c=relaxed/simple; bh=MXgGfSVa8kgYgbv7NCsM8eBhNUmCowLhQjSuWcFltj4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DJ5lJcVzbgNxq37DtI5hGddQa06psY1mHoFrfuZnQE4znWJ/fMNqStGl+bFk22/t2qJKS/TLvJycvtbgISinUFH/aMVNSCnNc+/rxXppEPGBJIBhczx0diKtxHgt1yWCJG4Fhv7Vi3cOcs4T01rFApaDOR6sFKonbi9OAJtaUZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GNcrwBuQ; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GNcrwBuQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320866; x=1808856866; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MXgGfSVa8kgYgbv7NCsM8eBhNUmCowLhQjSuWcFltj4=; b=GNcrwBuQZ2btpwC8KnUUK/IgD3O5goq/GVGVaRCxXwh/r48XhrQWLcvR H8aJbPBbRtwS0fzFtVcu41RQpCnnDeAcbZ6QiVoHkS7QifEJQoZOfNzzq 7VYxHOks06hhge/O04aq03QqYalAPc91grN2bgOk9YyskdES7uLak/4IU iPWilq02OEc6BxnnMKc8FiZTWQrbMwFgZ+XIp7T8jjbc64izxRSQKwtR8 fmm8EsEjamoL/oTo+jLBw+fTDBjfrOaASmBbTg3jUiSyuqun7ryuqfnh7 743ZbZI+4ShSnQoLl6Vv4DO8G/0EBmzLwu14JMk1q1O7/fhdtiWvrn/74 g==; X-CSE-ConnectionGUID: 09Mv0OIsSdWduHOCjzKXcA== X-CSE-MsgGUID: PfwGVMyRRd2KfLvJu+/lSw== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="78138366" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="78138366" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: iox6gbJBT6Cz3idRsTO28Q== X-CSE-MsgGUID: 8OInR5v1RSSCXBS9UarngQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="238074770" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa004.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 6E3AFA5; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 09/14] iio: magnetometer: ak8975: Unify return code variable name Date: Mon, 27 Apr 2026 22:09:54 +0200 Message-ID: <20260427201412.3067235-10-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In one case 'rc' is used in the other 'err', the most use 'ret'. Make the latter use the former, id est 'ret'. While at it, drop unneeded ' < 0' checks. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 46 +++++++++++++++---------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index 7ec1d4848fca..53158ffd173b 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -573,8 +573,8 @@ static irqreturn_t ak8975_irq_handler(int irq, void *da= ta) static int ak8975_setup_irq(struct ak8975_data *data) { struct i2c_client *client =3D data->client; - int rc; int irq; + int ret; =20 init_waitqueue_head(&data->data_ready_queue); clear_bit(0, &data->flags); @@ -583,15 +583,15 @@ static int ak8975_setup_irq(struct ak8975_data *data) else irq =3D gpiod_to_irq(data->eoc_gpiod); =20 - rc =3D devm_request_irq(&client->dev, irq, ak8975_irq_handler, - IRQF_TRIGGER_RISING, - dev_name(&client->dev), data); - if (rc < 0) - return rc; + ret =3D devm_request_irq(&client->dev, irq, ak8975_irq_handler, + IRQF_TRIGGER_RISING, + dev_name(&client->dev), data); + if (ret) + return ret; =20 data->eoc_irq =3D irq; =20 - return rc; + return 0; } =20 /* @@ -895,8 +895,8 @@ static int ak8975_probe(struct i2c_client *client) struct iio_dev *indio_dev; struct gpio_desc *eoc_gpiod; struct gpio_desc *reset_gpiod; - int err; const char *name =3D NULL; + int ret; =20 /* * Grab and set up the supplied GPIO. @@ -931,9 +931,9 @@ static int ak8975_probe(struct i2c_client *client) data->reset_gpiod =3D reset_gpiod; data->eoc_irq =3D 0; =20 - err =3D iio_read_mount_matrix(&client->dev, &data->orientation); - if (err) - return err; + ret =3D iio_read_mount_matrix(&client->dev, &data->orientation); + if (ret) + return ret; =20 /* id will be NULL when enumerated via ACPI */ data->def =3D i2c_get_match_data(client); @@ -954,20 +954,20 @@ static int ak8975_probe(struct i2c_client *client) if (IS_ERR(data->vid)) return PTR_ERR(data->vid); =20 - err =3D ak8975_power_on(data); - if (err) - return err; + ret =3D ak8975_power_on(data); + if (ret) + return ret; =20 - err =3D ak8975_who_i_am(client, data->def->type); - if (err < 0) { + ret =3D ak8975_who_i_am(client, data->def->type); + if (ret) { dev_err(&client->dev, "Unexpected device\n"); goto power_off; } dev_dbg(&client->dev, "Asahi compass chip %s\n", name); =20 /* Perform some basic start-of-day setup of the device. */ - err =3D ak8975_setup(client); - if (err < 0) { + ret =3D ak8975_setup(client); + if (ret) { dev_err(&client->dev, "%s initialization fails\n", name); goto power_off; } @@ -980,15 +980,15 @@ static int ak8975_probe(struct i2c_client *client) indio_dev->modes =3D INDIO_DIRECT_MODE; indio_dev->name =3D name; =20 - err =3D iio_triggered_buffer_setup(indio_dev, NULL, ak8975_handle_trigger, + ret =3D iio_triggered_buffer_setup(indio_dev, NULL, ak8975_handle_trigger, NULL); - if (err) { + if (ret) { dev_err(&client->dev, "triggered buffer setup failed\n"); goto power_off; } =20 - err =3D iio_device_register(indio_dev); - if (err) { + ret =3D iio_device_register(indio_dev); + if (ret) { dev_err(&client->dev, "device register failed\n"); goto cleanup_buffer; } @@ -1011,7 +1011,7 @@ static int ak8975_probe(struct i2c_client *client) iio_triggered_buffer_cleanup(indio_dev); power_off: ak8975_power_off(data); - return err; + return ret; } =20 static void ak8975_remove(struct i2c_client *client) --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C31D3803D8; Mon, 27 Apr 2026 20:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320874; cv=none; b=AY1VsOz0Bk2OaSSkhLOH89ecAotmahLhJttWZNsEkpCNRagKDNmzpLJEduTk9P5YlJ7Ru1pTI9dLwpsSS1TUqAzGitfL2GFmROaEXuE59lHjc1/EFURfrQen3n0WxPOJTeSf3g3bbQdRVHRoV64Je5p8J07DUB9Xs+k3IkwkPO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320874; c=relaxed/simple; bh=vpZ8A2dXN0ClPhvlSu5M3FCdSJVbGw+/9Xqa6yh80v8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q+aVaQ5S9M6ty36A0w7yXWePuLrooo4qk4EYbCZ+L8e8Yk3dbeEkFbSrTQs4WjyDkbIxSIVvKf9NJCfWwV+69M39URwOKxoQmmcG3N4j7uoWEc1y8ceKz4HWcVZqe/7KaQlKxKFP3Sgr16a0bUKWNbIJrr2/C2yXEH87kSUwfx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TQqrbzZm; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TQqrbzZm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320873; x=1808856873; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vpZ8A2dXN0ClPhvlSu5M3FCdSJVbGw+/9Xqa6yh80v8=; b=TQqrbzZmP0jV+QQdcLfp0Om86PJnnKjVHAa0981eXn+6hVIjWvFUCjVs IoM3aOCRsBMTyusSV8ayOZVJy58TkhE9dpIrQ14fdkDIW8EHzygc3QFEf CDHobteRF48zvZMFL191Cxe5rV6COmCw0Jvrw8VWguyFiHlq/dqDkMJB0 lAJpKMxpbT9wTHpcLvoe/A4WJIQ5yewqQTd9D6X75rpybpRGTKew3z04O 6+u3eJAM8duyc9TjQyCyVL9jXC8Zij22c5fbeL2j42PlDeyB0j2ZApGAQ UTO0VIZ72ERARrUm3hQV45d0wFkgMsYkuKpH9J5of5LJ81UGYeR0mlAwY Q==; X-CSE-ConnectionGUID: 1HNwjjSzTviPK/ogVXtKmw== X-CSE-MsgGUID: nvVnWEMORfumgOU7/z7g7A== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384125" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384125" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: 7W0A/da2SfWMIc7lNaejVQ== X-CSE-MsgGUID: JaV8IeuRSVazQv+7m18DOQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857729" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 71D08A6; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 10/14] iio: magnetometer: ak8975: switch to using managed resources Date: Mon, 27 Apr 2026 22:09:55 +0200 Message-ID: <20260427201412.3067235-11-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch the driver to use managed resources (devm_*) which simplifier error handling and allows removing ak8975_remove() method from the driver. Note, on error path we now also set mode to POWER_DOWN state which is fine. Even if the device is in that mode, there is no problem to set that mode again, it should be no-op. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 59 ++++++++++++++----------------- 1 file changed, 26 insertions(+), 33 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index 53158ffd173b..d666d9d171bd 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -888,9 +888,16 @@ static irqreturn_t ak8975_handle_trigger(int irq, void= *p) return IRQ_HANDLED; } =20 +static void devm_ak8975_power_off(void *data) +{ + ak8975_set_mode(data, POWER_DOWN); + ak8975_power_off(data); +} + static int ak8975_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + struct device *dev =3D &client->dev; struct ak8975_data *data; struct iio_dev *indio_dev; struct gpio_desc *eoc_gpiod; @@ -958,10 +965,14 @@ static int ak8975_probe(struct i2c_client *client) if (ret) return ret; =20 + ret =3D devm_add_action_or_reset(dev, devm_ak8975_power_off, data); + if (ret) + return ret; + ret =3D ak8975_who_i_am(client, data->def->type); if (ret) { dev_err(&client->dev, "Unexpected device\n"); - goto power_off; + return ret; } dev_dbg(&client->dev, "Asahi compass chip %s\n", name); =20 @@ -969,10 +980,13 @@ static int ak8975_probe(struct i2c_client *client) ret =3D ak8975_setup(client); if (ret) { dev_err(&client->dev, "%s initialization fails\n", name); - goto power_off; + return ret; } =20 - mutex_init(&data->lock); + ret =3D devm_mutex_init(dev, &data->lock); + if (ret) + return ret; + indio_dev->channels =3D ak8975_channels; indio_dev->num_channels =3D ARRAY_SIZE(ak8975_channels); indio_dev->info =3D &ak8975_info; @@ -980,52 +994,32 @@ static int ak8975_probe(struct i2c_client *client) indio_dev->modes =3D INDIO_DIRECT_MODE; indio_dev->name =3D name; =20 - ret =3D iio_triggered_buffer_setup(indio_dev, NULL, ak8975_handle_trigger, - NULL); + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, + ak8975_handle_trigger, NULL); if (ret) { dev_err(&client->dev, "triggered buffer setup failed\n"); - goto power_off; + return ret; } =20 - ret =3D iio_device_register(indio_dev); + ret =3D devm_iio_device_register(dev, indio_dev); if (ret) { dev_err(&client->dev, "device register failed\n"); - goto cleanup_buffer; + return ret; } =20 /* Enable runtime PM */ - pm_runtime_get_noresume(&client->dev); - pm_runtime_set_active(&client->dev); - pm_runtime_enable(&client->dev); + ret =3D devm_pm_runtime_set_active_enabled(dev); + if (ret) + return ret; + /* * The device comes online in 500us, so add two orders of magnitude * of delay before autosuspending: 50 ms. */ pm_runtime_set_autosuspend_delay(&client->dev, 50); pm_runtime_use_autosuspend(&client->dev); - pm_runtime_put(&client->dev); =20 return 0; - -cleanup_buffer: - iio_triggered_buffer_cleanup(indio_dev); -power_off: - ak8975_power_off(data); - return ret; -} - -static void ak8975_remove(struct i2c_client *client) -{ - struct iio_dev *indio_dev =3D i2c_get_clientdata(client); - struct ak8975_data *data =3D iio_priv(indio_dev); - - pm_runtime_get_sync(&client->dev); - pm_runtime_put_noidle(&client->dev); - pm_runtime_disable(&client->dev); - iio_device_unregister(indio_dev); - iio_triggered_buffer_cleanup(indio_dev); - ak8975_set_mode(data, POWER_DOWN); - ak8975_power_off(data); } =20 static int ak8975_runtime_suspend(struct device *dev) @@ -1119,7 +1113,6 @@ static struct i2c_driver ak8975_driver =3D { .acpi_match_table =3D ak_acpi_match, }, .probe =3D ak8975_probe, - .remove =3D ak8975_remove, .id_table =3D ak8975_id, }; module_i2c_driver(ak8975_driver); --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AEFA36605D; Mon, 27 Apr 2026 20:14:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320867; cv=none; b=LtcMT+ZtYylLsAcCRv4IjjIoMLmTYc0uluxRiQKXa4Em8j+B4/9gxjE9HE+WajaGHwxyu49W/VWltSaRbR3zd11twOHGSeBIcTKxCv1Wvm6zkkU1vpPzHhqc0d7P/o34ftSkIolkllPdlwd1d9IQI1x3//DK+uZkkviLXBmAUak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320867; c=relaxed/simple; bh=bvAb3rmm2QsUxkx2+qv0zd/GFtfUEF4/M5sMzqm6L6k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kl06OAUc1dkRLJLaJ//5V/lRhgRJ5DTNkObEDE0HqlPPl8Kxg8A69yQ/ihJw2et5pMMrIMqLG914CtaUeJ0apkGqrVsWZHtiBqv8PPBoMdEK1crzwzu6E7crMxVrBJq2LM9bGsrwFX2swaIZdc3nD9XvfXBGo3N1w23/Bi0AGi0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W4Ub3EH8; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W4Ub3EH8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320866; x=1808856866; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bvAb3rmm2QsUxkx2+qv0zd/GFtfUEF4/M5sMzqm6L6k=; b=W4Ub3EH8Nfz+qro3LCf5ErbxbgAsATtWbSKlnSlWLY629ZJetYw5Ji2H q0QDnKgNUrZDjdSorHp7zcFOR7T7KymYKGvRvHyfWcA/MkW1gRHQaQqmb EOhxMhtSaibh6PQDQczr4dGEwW+GTxIMMWbd5dgM7oJiOkctwscUf6tZL hig4Q6D1EXEm85jhbgNFbe6S+KK1j6y81LndKl3fKMyBcdpOcLQbCmwsx UuW+CsI19iXlYWlwS4Sbb0bSGaUiEmkVJUpmBfaVzPRXhHjlSF8VtYl/m uJ5gQQ+8DwlVrcsj9+DYKUmlGPel5SGXUVdTVhlXqerCm0pwlvhqlS5Zh g==; X-CSE-ConnectionGUID: MTJ/T1qtTf62Qd1+bnBYQg== X-CSE-MsgGUID: iU+UK2OFTKGCSVJDZv1DZw== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="78138376" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="78138376" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: jhZeSeTHR5C+F9GrpyqlrA== X-CSE-MsgGUID: SJBfUn01TSWHPBSEj4sWlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="238074771" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa004.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 7692EA7; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 11/14] iio: magnetometer: ak8975: Consistently use 'data' parameter Date: Mon, 27 Apr 2026 22:09:56 +0200 Message-ID: <20260427201412.3067235-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some of the functions use 'client', some use 'data', and some use both. Refactor the driver to consistently use 'data' in all cases. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index d666d9d171bd..b734a5939f73 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -474,9 +474,10 @@ static void ak8975_power_off(const struct ak8975_data = *data) * Return 0 if the i2c device is the one we expect. * return a negative error number otherwise */ -static int ak8975_who_i_am(struct i2c_client *client, +static int ak8975_who_i_am(const struct ak8975_data *data, enum asahi_compass_chipset type) { + struct i2c_client *client =3D data->client; u8 wia_val[2]; int ret; =20 @@ -598,10 +599,9 @@ static int ak8975_setup_irq(struct ak8975_data *data) * Perform some start-of-day setup, including reading the asa calibration * values and caching them. */ -static int ak8975_setup(struct i2c_client *client) +static int ak8975_setup(struct ak8975_data *data) { - struct iio_dev *indio_dev =3D i2c_get_clientdata(client); - struct ak8975_data *data =3D iio_priv(indio_dev); + struct i2c_client *client =3D data->client; int ret; =20 /* Write the fused rom access mode. */ @@ -697,12 +697,13 @@ static int wait_conversion_complete_interrupt(struct = ak8975_data *data) return ret > 0 ? 0 : -ETIMEDOUT; } =20 -static int ak8975_start_read_axis(struct ak8975_data *data, - const struct i2c_client *client) +static int ak8975_start_read_axis(struct ak8975_data *data) { - /* Set up the device for taking a sample. */ - int ret =3D ak8975_set_mode(data, MODE_ONCE); + struct i2c_client *client =3D data->client; + int ret; =20 + /* Set up the device for taking a sample. */ + ret =3D ak8975_set_mode(data, MODE_ONCE); if (ret < 0) { dev_err(&client->dev, "Error in setting operating mode\n"); return ret; @@ -735,7 +736,7 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, = int index, int *val) =20 mutex_lock(&data->lock); =20 - ret =3D ak8975_start_read_axis(data, client); + ret =3D ak8975_start_read_axis(data); if (ret) goto exit; =20 @@ -846,7 +847,7 @@ static void ak8975_fill_buffer(struct iio_dev *indio_de= v) =20 mutex_lock(&data->lock); =20 - ret =3D ak8975_start_read_axis(data, client); + ret =3D ak8975_start_read_axis(data); if (ret) goto unlock; =20 @@ -969,7 +970,7 @@ static int ak8975_probe(struct i2c_client *client) if (ret) return ret; =20 - ret =3D ak8975_who_i_am(client, data->def->type); + ret =3D ak8975_who_i_am(data, data->def->type); if (ret) { dev_err(&client->dev, "Unexpected device\n"); return ret; @@ -977,7 +978,7 @@ static int ak8975_probe(struct i2c_client *client) dev_dbg(&client->dev, "Asahi compass chip %s\n", name); =20 /* Perform some basic start-of-day setup of the device. */ - ret =3D ak8975_setup(client); + ret =3D ak8975_setup(data); if (ret) { dev_err(&client->dev, "%s initialization fails\n", name); return ret; --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF21F37756F; Mon, 27 Apr 2026 20:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320870; cv=none; b=YPiiBtymnF2tnP1ZGFyax+tt9uYC+M3f0U1s13UAU2p2MV84wWpqPOy4qKpATBdcsU9J2kBLvSrBPJsZ9V2CAScZLkpJ17qHUA4vNMaxRAc231r1KecbyVEiHQ16hl0iazJUhusUMOau5qL9oSBTZIZc7RqYaIHbFZ/4VT3ej1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320870; c=relaxed/simple; bh=QXnPBK5SscAJkaUY7ARK2dsTnAChVGIyVqfliTIYWeo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RFR+T9cBoP35W7RmmB1wIAow+C0KWQ8F9ALPZgjD56vbGCv51PMzyckw9xg9F6B5G1xlu5iWuig6OwW9cL6J549VKDAbRzEBDMzgIIuoOAjuUQo2Nb5r++OMc4Zd5K+rmPmrjWkkgpWvOdKjNGGrEsOBFdT8/k2XV+y+o6BthiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AUNwjXaB; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AUNwjXaB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320869; x=1808856869; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QXnPBK5SscAJkaUY7ARK2dsTnAChVGIyVqfliTIYWeo=; b=AUNwjXaBksxTdHIKSHHkSUtIS9a3/45bxD8w0zUeF5rIlsbedn9kFCrH qRTuxXidXlFeJSadbkJDFFTwf/dik7yza/41fv10gn/2d2z4cAljmQ/gi OsreVlooDXIYgjdQG3FZVKTZVELMS4c3IOdI0Xcr1vqfD4k1oIRoiOE37 ynM4CNUr4ieifoOfD8pfO2KIE4Z1EJEpKh5ATwKnB2wm4MygrHnJUYc2b 3gR2GWicZK8xc9WYt4ei8bytzSpfq1PwspAz/4EOV6tuZLBRAyix6FDlP TwRJ8aVa1vQU9Z/IktDQ+R4LNNeacV0wyWZLhJ/5xtg4l4x0irN2tF43i Q==; X-CSE-ConnectionGUID: 59H6caA2SGavyBocF0C6ew== X-CSE-MsgGUID: LqYtq+guT4KCx36wtFtkBA== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384104" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384104" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: /NezYaYoQaKL7zgQOcKdZg== X-CSE-MsgGUID: IYfoDXzyQD6nBtRKnCfQ+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857728" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 7AEC8A8; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 12/14] iio: magnetometer: ak8975: Unify messages with help of dev_err_probe() Date: Mon, 27 Apr 2026 22:09:57 +0200 Message-ID: <20260427201412.3067235-13-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unify error messages that might appear during probe phase by switching to use dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index b734a5939f73..c2eb7b0d0da8 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -495,10 +495,8 @@ static int ak8975_who_i_am(const struct ak8975_data *d= ata, AK09912_REG_WIA1, sizeof(wia_val), wia_val); - if (ret < 0) { - dev_err(&client->dev, "Error reading WIA\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(&client->dev, ret, "Error reading WIA\n"); =20 if (wia_val[0] !=3D AK8975_DEVICE_ID) return -ENODEV; @@ -971,18 +969,14 @@ static int ak8975_probe(struct i2c_client *client) return ret; =20 ret =3D ak8975_who_i_am(data, data->def->type); - if (ret) { - dev_err(&client->dev, "Unexpected device\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Unexpected device\n"); dev_dbg(&client->dev, "Asahi compass chip %s\n", name); =20 /* Perform some basic start-of-day setup of the device. */ ret =3D ak8975_setup(data); - if (ret) { - dev_err(&client->dev, "%s initialization fails\n", name); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "%s initialization fails\n", name); =20 ret =3D devm_mutex_init(dev, &data->lock); if (ret) @@ -997,16 +991,12 @@ static int ak8975_probe(struct i2c_client *client) =20 ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, ak8975_handle_trigger, NULL); - if (ret) { - dev_err(&client->dev, "triggered buffer setup failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "triggered buffer setup failed\n"); =20 ret =3D devm_iio_device_register(dev, indio_dev); - if (ret) { - dev_err(&client->dev, "device register failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "device register failed\n"); =20 /* Enable runtime PM */ ret =3D devm_pm_runtime_set_active_enabled(dev); --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C3A83803F8; Mon, 27 Apr 2026 20:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320874; cv=none; b=R1h41viDusPuNYyS+2BLheymhrWO+buKpF30XG06vx2RcbOUgqMLb110LBmPigB+ZdX5dC8Xt19vDhKXYy+zOKAqZcw55UA5vJTTGqWXg88qXLfBO9geMxLvuuxheWtuvx+4sME6vkrQX/q+Lrp3YvdO11YFMfmRP19RKuyiwQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320874; c=relaxed/simple; bh=uyXiKPRuTDoLrBixbH1C7zwMYpbcc/R+ReU8VdvI3dw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MXzM+5VdElM6Y0b/9xO4WDIrNiVy7csyE2iSvfn1O3C8vmgH9Q+SQyKLGZwIHroWLozAuMn76AziFI1hfCx8PUPnsT0o4d71Cy5C3goxaF6uMCEq/5ix1WgALGuElbIzPthsEOsjyjzMZc3wjoLNq9DFUaaA1MLj+2Jy0Judr40= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iFFQNywo; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iFFQNywo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320873; x=1808856873; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uyXiKPRuTDoLrBixbH1C7zwMYpbcc/R+ReU8VdvI3dw=; b=iFFQNywoQBEGoBM4s4D2yYzEniKXRxuXz6360kGFL/vz1/LFSvLaPccJ /UiWst0hWbnyPlgcEq8nYPBgv51Bz+ZugTQ3EZqLaY5vOnDDe1RL86IyD T94lSyk0hcvZeC2u48OBKceIfcXb4DgNK2issoNbL3fvYSnfVZP9FL0z0 gCv6zZ8iNGSCAhstLf1nW2xzw0/Y7cvHysQuf4NvLfO7iITCIm81QuRbK wpN7QTBMPC298j49+IJMwt9B7Ktp9B1K8L902S1DgpPCfWjwyT6u1QG30 9O5em9VttO6ugIzRwTrNiOrowdjqa1POXfwSzedkkPOC2040PQVoJOmr9 g==; X-CSE-ConnectionGUID: AJqtwZ8ERw2BKnOWIavwiQ== X-CSE-MsgGUID: /51rYASWQQe3cEonJoNBEg== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="77384128" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="77384128" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: NzC/bzzNSACFrutxJFt2IA== X-CSE-MsgGUID: YnJpjv2GRUaP59muic/oBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="232857731" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa010.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 7F506A9; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 13/14] iio: magnetometer: ak8975: Use temporary variable for struct device Date: Mon, 27 Apr 2026 22:09:58 +0200 Message-ID: <20260427201412.3067235-14-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use temporary variable for struct device to make code neater. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 61 +++++++++++++++---------------- 1 file changed, 30 insertions(+), 31 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index c2eb7b0d0da8..e6ca30b36965 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -433,18 +433,17 @@ struct ak8975_data { /* Enable attached power regulator if any. */ static int ak8975_power_on(const struct ak8975_data *data) { + struct device *dev =3D &data->client->dev; int ret; =20 ret =3D regulator_enable(data->vdd); if (ret) { - dev_warn(&data->client->dev, - "Failed to enable specified Vdd supply\n"); + dev_warn(dev, "Failed to enable specified Vdd supply\n"); return ret; } ret =3D regulator_enable(data->vid); if (ret) { - dev_warn(&data->client->dev, - "Failed to enable specified Vid supply\n"); + dev_warn(dev, "Failed to enable specified Vid supply\n"); regulator_disable(data->vdd); return ret; } @@ -572,6 +571,7 @@ static irqreturn_t ak8975_irq_handler(int irq, void *da= ta) static int ak8975_setup_irq(struct ak8975_data *data) { struct i2c_client *client =3D data->client; + struct device *dev =3D &client->dev; int irq; int ret; =20 @@ -582,9 +582,8 @@ static int ak8975_setup_irq(struct ak8975_data *data) else irq =3D gpiod_to_irq(data->eoc_gpiod); =20 - ret =3D devm_request_irq(&client->dev, irq, ak8975_irq_handler, - IRQF_TRIGGER_RISING, - dev_name(&client->dev), data); + ret =3D devm_request_irq(dev, irq, ak8975_irq_handler, IRQF_TRIGGER_RISIN= G, + dev_name(dev), data); if (ret) return ret; =20 @@ -600,12 +599,13 @@ static int ak8975_setup_irq(struct ak8975_data *data) static int ak8975_setup(struct ak8975_data *data) { struct i2c_client *client =3D data->client; + struct device *dev =3D &client->dev; int ret; =20 /* Write the fused rom access mode. */ ret =3D ak8975_set_mode(data, FUSE_ROM); if (ret < 0) { - dev_err(&client->dev, "Error in setting fuse access mode\n"); + dev_err(dev, "Error in setting fuse access mode\n"); return ret; } =20 @@ -615,22 +615,21 @@ static int ak8975_setup(struct ak8975_data *data) sizeof(data->asa), data->asa); if (ret < 0) { - dev_err(&client->dev, "Not able to read asa data\n"); + dev_err(dev, "Not able to read asa data\n"); return ret; } =20 /* After reading fuse ROM data set power-down mode */ ret =3D ak8975_set_mode(data, POWER_DOWN); if (ret < 0) { - dev_err(&client->dev, "Error in setting power-down mode\n"); + dev_err(dev, "Error in setting power-down mode\n"); return ret; } =20 if (data->eoc_gpiod || client->irq > 0) { ret =3D ak8975_setup_irq(data); if (ret < 0) { - dev_err(&client->dev, - "Error setting data ready interrupt\n"); + dev_err(dev, "Error setting data ready interrupt\n"); return ret; } } @@ -727,10 +726,11 @@ static int ak8975_read_axis(struct iio_dev *indio_dev= , int index, int *val) struct ak8975_data *data =3D iio_priv(indio_dev); const struct i2c_client *client =3D data->client; const struct ak_def *def =3D data->def; + struct device *dev =3D &data->client->dev; __le16 rval; int ret; =20 - pm_runtime_get_sync(&data->client->dev); + pm_runtime_get_sync(dev); =20 mutex_lock(&data->lock); =20 @@ -748,20 +748,20 @@ static int ak8975_read_axis(struct iio_dev *indio_dev= , int index, int *val) /* Read out ST2 for release lock on measurement data. */ ret =3D i2c_smbus_read_byte_data(client, data->def->ctrl_regs[ST2]); if (ret < 0) { - dev_err(&client->dev, "Error in reading ST2\n"); + dev_err(dev, "Error in reading ST2\n"); goto exit; } =20 if (ret & (data->def->ctrl_masks[ST2_DERR] | data->def->ctrl_masks[ST2_HOFL])) { - dev_err(&client->dev, "ST2 status error 0x%x\n", ret); + dev_err(dev, "ST2 status error 0x%x\n", ret); ret =3D -EINVAL; goto exit; } =20 mutex_unlock(&data->lock); =20 - pm_runtime_put_autosuspend(&data->client->dev); + pm_runtime_put_autosuspend(dev); =20 /* Swap bytes and convert to valid range. */ *val =3D clamp_t(s16, le16_to_cpu(rval), -def->range, def->range); @@ -770,7 +770,7 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, = int index, int *val) =20 exit: mutex_unlock(&data->lock); - dev_err(&client->dev, "Error in reading axis\n"); + dev_err(dev, "Error in reading axis\n"); return ret; } =20 @@ -909,7 +909,7 @@ static int ak8975_probe(struct i2c_client *client) * We may not have a GPIO based IRQ to scan, that is fine, we will * poll if so. */ - eoc_gpiod =3D devm_gpiod_get_optional(&client->dev, NULL, GPIOD_IN); + eoc_gpiod =3D devm_gpiod_get_optional(dev, NULL, GPIOD_IN); if (IS_ERR(eoc_gpiod)) return PTR_ERR(eoc_gpiod); gpiod_set_consumer_name(eoc_gpiod, "ak_8975"); @@ -919,13 +919,12 @@ static int ak8975_probe(struct i2c_client *client) * deassert reset on ak8975_power_on() and assert reset on * ak8975_power_off(). */ - reset_gpiod =3D devm_gpiod_get_optional(&client->dev, - "reset", GPIOD_OUT_HIGH); + reset_gpiod =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(reset_gpiod)) return PTR_ERR(reset_gpiod); =20 /* Register with IIO */ - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (indio_dev =3D=3D NULL) return -ENOMEM; =20 @@ -937,7 +936,7 @@ static int ak8975_probe(struct i2c_client *client) data->reset_gpiod =3D reset_gpiod; data->eoc_irq =3D 0; =20 - ret =3D iio_read_mount_matrix(&client->dev, &data->orientation); + ret =3D iio_read_mount_matrix(dev, &data->orientation); if (ret) return ret; =20 @@ -947,16 +946,16 @@ static int ak8975_probe(struct i2c_client *client) return -ENODEV; =20 /* If enumerated via firmware node, fix the ABI */ - if (dev_fwnode(&client->dev)) - name =3D dev_name(&client->dev); + if (dev_fwnode(dev)) + name =3D dev_name(dev); else name =3D id->name; =20 /* Fetch the regulators */ - data->vdd =3D devm_regulator_get(&client->dev, "vdd"); + data->vdd =3D devm_regulator_get(dev, "vdd"); if (IS_ERR(data->vdd)) return PTR_ERR(data->vdd); - data->vid =3D devm_regulator_get(&client->dev, "vid"); + data->vid =3D devm_regulator_get(dev, "vid"); if (IS_ERR(data->vid)) return PTR_ERR(data->vid); =20 @@ -971,7 +970,7 @@ static int ak8975_probe(struct i2c_client *client) ret =3D ak8975_who_i_am(data, data->def->type); if (ret) return dev_err_probe(dev, ret, "Unexpected device\n"); - dev_dbg(&client->dev, "Asahi compass chip %s\n", name); + dev_dbg(dev, "Asahi compass chip %s\n", name); =20 /* Perform some basic start-of-day setup of the device. */ ret =3D ak8975_setup(data); @@ -1007,8 +1006,8 @@ static int ak8975_probe(struct i2c_client *client) * The device comes online in 500us, so add two orders of magnitude * of delay before autosuspending: 50 ms. */ - pm_runtime_set_autosuspend_delay(&client->dev, 50); - pm_runtime_use_autosuspend(&client->dev); + pm_runtime_set_autosuspend_delay(dev, 50); + pm_runtime_use_autosuspend(dev); =20 return 0; } @@ -1023,7 +1022,7 @@ static int ak8975_runtime_suspend(struct device *dev) /* Set the device in power down if it wasn't already */ ret =3D ak8975_set_mode(data, POWER_DOWN); if (ret < 0) { - dev_err(&client->dev, "Error in setting power-down mode\n"); + dev_err(dev, "Error in setting power-down mode\n"); return ret; } /* Next cut the regulators */ @@ -1047,7 +1046,7 @@ static int ak8975_runtime_resume(struct device *dev) */ ret =3D ak8975_set_mode(data, POWER_DOWN); if (ret < 0) { - dev_err(&client->dev, "Error in setting power-down mode\n"); + dev_err(dev, "Error in setting power-down mode\n"); return ret; } =20 --=20 2.50.1 From nobody Wed Jun 17 05:10:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2D53469EE; Mon, 27 Apr 2026 20:14:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320867; cv=none; b=fQgIyen57BGrr+ICK9pcTI6KsrHfgX6G+Y+181gMNI+W1X9VBD4l506REwpfLw8aKcs8qZHpddA+YNXaqVcVOU/7h2yg53daWaCYXBKtcwYoVLgC08iE8G6CS3k46qhkgAgrQbs33GBmfwSparGCicNSJpJBDCo8CUhtbTbkKF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320867; c=relaxed/simple; bh=VkVmyO1sLvnbDxjsT7g5r6+v42hON4p4F1cx/O8dadc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hkc/uywKQBcJ+ST9+5C44RYmBRzzxcz7H0j5ufgRQV236FIfUrKvjurdKS9OsO+FauUvrTnMCy/wpBvvCrHiFChgfYeB32EDo2rjH9KqAoHVKkwtTCiFVKbIgfaTXsBLu+LcgMikuAmLYhgsV1wBHw5+Fx+cWaZ0Rz3hMMqd040= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LvvUKDkd; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LvvUKDkd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320866; x=1808856866; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VkVmyO1sLvnbDxjsT7g5r6+v42hON4p4F1cx/O8dadc=; b=LvvUKDkdun8IJIgTVzaWyFhwh6bfrHKrt+obQkt6sZ/FccpclZMN0cp9 4KM8Mubzq/7c0y5MWJpTrt9eZXNmO35ah3xsqGaOSt92SEJCPtPUNTG3g vXhgBE2701rNYmvU8SOJ0RYupxK6Ty2lULBOekkyTzhQXNrmB5kiSiOiD BOgyxXZhNybtHb0gouzNb2JEIuQGsTDkk3RjEg5/T8rGvUyt4HRA8hlq3 VoEDuiWyaQ0DJMXbF0D+8WQ+fHerENt8/2cbiQnz1VK67M6e20YRUp84V lV5Opfq3YASesIdaihUd8Pyqo0gUGvv/3qFWGgDZW8/ZQcduBOXEyLL6T w==; X-CSE-ConnectionGUID: T8yx+tPtRGmHilq5shUUHg== X-CSE-MsgGUID: 2VyGv/HaRRmbIIQ5ovDjFQ== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="78138368" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="78138368" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: ht2je8quSRy5zrvVndXUKw== X-CSE-MsgGUID: WY+CS4wxTHKkPvfx0ZfF/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="238074773" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa004.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 83624AA; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 14/14] iio: magnetometer: ak8975: Make use of the macros from bits.h Date: Mon, 27 Apr 2026 22:09:59 +0200 Message-ID: <20260427201412.3067235-15-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make use of BIT() and GENMASK() where it makes sense. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/a= k8975.c index e6ca30b36965..4e53c61c8d69 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -46,7 +46,7 @@ =20 #define AK8975_REG_ST1 0x02 #define AK8975_REG_ST1_DRDY_SHIFT 0 -#define AK8975_REG_ST1_DRDY_MASK (1 << AK8975_REG_ST1_DRDY_SHIFT) +#define AK8975_REG_ST1_DRDY_MASK BIT(0) =20 #define AK8975_REG_HXL 0x03 #define AK8975_REG_HXH 0x04 @@ -56,14 +56,14 @@ #define AK8975_REG_HZH 0x08 #define AK8975_REG_ST2 0x09 #define AK8975_REG_ST2_DERR_SHIFT 2 -#define AK8975_REG_ST2_DERR_MASK (1 << AK8975_REG_ST2_DERR_SHIFT) +#define AK8975_REG_ST2_DERR_MASK BIT(2) =20 #define AK8975_REG_ST2_HOFL_SHIFT 3 -#define AK8975_REG_ST2_HOFL_MASK (1 << AK8975_REG_ST2_HOFL_SHIFT) +#define AK8975_REG_ST2_HOFL_MASK BIT(3) =20 #define AK8975_REG_CNTL 0x0A #define AK8975_REG_CNTL_MODE_SHIFT 0 -#define AK8975_REG_CNTL_MODE_MASK (0xF << AK8975_REG_CNTL_MODE_SHIFT) +#define AK8975_REG_CNTL_MODE_MASK GENMASK(3, 0) #define AK8975_REG_CNTL_MODE_POWER_DOWN 0x00 #define AK8975_REG_CNTL_MODE_ONCE 0x01 #define AK8975_REG_CNTL_MODE_SELF_TEST 0x08 @@ -96,7 +96,7 @@ #define AK09912_REG_ST1 0x10 =20 #define AK09912_REG_ST1_DRDY_SHIFT 0 -#define AK09912_REG_ST1_DRDY_MASK (1 << AK09912_REG_ST1_DRDY_SHIFT) +#define AK09912_REG_ST1_DRDY_MASK BIT(0) =20 #define AK09912_REG_HXL 0x11 #define AK09912_REG_HXH 0x12 @@ -108,7 +108,7 @@ =20 #define AK09912_REG_ST2 0x18 #define AK09912_REG_ST2_HOFL_SHIFT 3 -#define AK09912_REG_ST2_HOFL_MASK (1 << AK09912_REG_ST2_HOFL_SHIFT) +#define AK09912_REG_ST2_HOFL_MASK BIT(3) =20 #define AK09912_REG_CNTL1 0x30 =20 @@ -118,7 +118,7 @@ #define AK09912_REG_CNTL_MODE_SELF_TEST 0x10 #define AK09912_REG_CNTL_MODE_FUSE_ROM 0x1F #define AK09912_REG_CNTL2_MODE_SHIFT 0 -#define AK09912_REG_CNTL2_MODE_MASK (0x1F << AK09912_REG_CNTL2_MODE_SHIFT) +#define AK09912_REG_CNTL2_MODE_MASK GENMASK(4, 0) =20 #define AK09912_REG_CNTL3 0x32 =20 @@ -829,7 +829,7 @@ static const struct iio_chan_spec ak8975_channels[] =3D= { IIO_CHAN_SOFT_TIMESTAMP(3), }; =20 -static const unsigned long ak8975_scan_masks[] =3D { 0x7, 0 }; +static const unsigned long ak8975_scan_masks[] =3D { GENMASK(2, 0), 0 }; =20 static const struct iio_info ak8975_info =3D { .read_raw =3D &ak8975_read_raw, --=20 2.50.1