From nobody Wed Jun 17 06:05:12 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC4C34750B for ; Mon, 27 Apr 2026 15:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305278; cv=none; b=WHDuMoAUd4KNe0lFBe07fctB+TX+4m5vn0Ay/pAHf7qrnKnir425g3rZUluhEsXrvj959UFD/fDEp6CGW4SJrgjNRabOoSEsus8NjmrhX3zZ7z3tB9Moo616aTo+YjVr8mHFHXWGRQtLQQmCwvn+PPIOLtsxJrrUKhtDYGNvgqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305278; c=relaxed/simple; bh=I1nJbv81E72QLR9rTJJeT2/s+/pNz9TbaKu14lB08PQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rJswqIZ5F/5vClxpwt7mCNiCAH7kUDAiHWnt3GqOx1CUMLYItxgFJKpYASWftXXkm3ORcIOVER60PJ5+Jj9KfLbZtYqf2vEwxarh0irfNGYfjQjSNIpfBt82aZNung7qL+l0T5ahtaw9L+9wqE/LA1rRjn7dsYJ/UiGKwrMvHK8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jjFkGfbk; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jjFkGfbk" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82f8b60e485so4329308b3a.0 for ; Mon, 27 Apr 2026 08:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777305275; x=1777910075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wD4HSmg94+zoUy1wxNVzZHgBZRTgsbG2xCqBMkaVIkA=; b=jjFkGfbkCoXwlLCOCOHQGuZQHdT6WPKvifdwOxXaigUrfr7g46FyFG20fMJudZH4yN cTd8/J+gyEwl7j27ZO9xYub3mSUvgdWyZCY0o6pW2BTaYrI2IVNZdDdDsapGnd5wTW3L JtIFXd0H3lGr4xl+rHh4/T4qNw6EtrzLAYotpoNeJ4sxwuykcFF6X+Rjx6CO/OGVtm6e 1HgSaGppLqtopXiWDERk9+TaXJ3Rbr8qhXp0BxjOvslf1r+UM7exbuT2ZioD7YYELC8e hwNAfMB+pCSGC1ErsGdk+9ZLSaF9WWa1A2sjl9yBnRZG5S1wcWRvT0HF28NoKn8rqm9d epBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777305275; x=1777910075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wD4HSmg94+zoUy1wxNVzZHgBZRTgsbG2xCqBMkaVIkA=; b=CRfuVJipo66L+R+jXVxYFMiORHfnrBybDKIF9AHz1HvzvTWGBONPSnao4q3EtIF9nE Z/mlUSdjB2mwXeoNzjUoq3nd7+SoKGRFAfF5Yc6jSk/yO6xbCZyf8LTU0Hdyqt6F3n2Z ZPKPqy5QUP7ZN/F90ZwARv0SgqQ2fTUcfbUf0CnF7H9BirNWcsqnuxzQKeb5T1vI8tPC mzBZ6EfZAjmwvEx0NVG4A62Zbl/4VwizdcO+hw6Gm7PWhivxkiWNTkf/lr5Vakehcz8i +6oYSN2XXoimzRZIqAfV74m+36LM2Gt9vpmVpZAyKrQqDooT2S5amOgfTCLS4jneEjot lRAg== X-Forwarded-Encrypted: i=1; AFNElJ9MLpxQQrPAvoZzrFb9hiUXj5F3DZbXp8d4zT/UZFfP3e8DQj/8Kz3wDaaNZC15kyujDutkinm7ZvzF+vo=@vger.kernel.org X-Gm-Message-State: AOJu0Yyeo6Eu48RZM61UfWkiY6sp6Dtai/mhGxhNuuifM4zFLKOyo/bD VBuNr1kKIYEvJCfFr916vlB4lIe9scYPBpi1RDUgma0DNXapwdPVy3lP X-Gm-Gg: AeBDietXizvrS5/b4kJHou/H1Quu+qrhlVdfJTBX7CEO5Kt2LhK0+59EBOv2NL+ZhXP ode27/FCzsrEBoGnqzzHEAxvTbdZuTv7qrLuaQXXtSBTR3159a0zxdlYi5F2c3SLxWMO4Fc6VuE /GSeGDe+Dzs8SirBYNWoq30hU8F861upnLQTuDWNe3nfQrp7ioPKPLnE8RWa1gMeYM4/l3Oujl9 dWb7UXqUOFLZURhu+Yda4hKrXHUEWQHolF7Vw45uay6AktKc0IcffT7FDPaYGVnZj9eGknAf85k WuIlfQG1giWk4bfThYVu4NVP8dolDUQQJvvf6I64foSWVWskdSLPBZW2zfNvtUbgbdfn6QFlTGw 8PTNELR1TWoHCPfiXMTRFDwT8RjhAcSmnH0UmGYwd3+IPPGokujrJwDgnZaPR4LuVKfjTuV+4tU d4ohzyASUX6/9Groy2NVaVFPr389E2ddQcizJwuRWm X-Received: by 2002:a05:6a00:4186:b0:82c:212a:8023 with SMTP id d2e1a72fcca58-82f8c89e97fmr44338437b3a.11.1777305274625; Mon, 27 Apr 2026 08:54:34 -0700 (PDT) Received: from localhost (vps-e1cc9378.vps.ovh.us. [2604:2dc0:202:300::1365]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9d6adbsm40999484b3a.18.2026.04.27.08.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:54:34 -0700 (PDT) From: Eric Wu To: Thomas Bogendoerfer , Greg Kroah-Hartman Cc: linux-mips@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Wu Subject: [PATCH 1/7] staging: octeon: convert cvmx_spi_mode_t from typedef to plain enum Date: Mon, 27 Apr 2026 23:54:21 +0800 Message-ID: <20260427155427.668540-2-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427155427.668540-1-kunjinkao.jp@gmail.com> References: <20260427155427.668540-1-kunjinkao.jp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Linux kernel coding style discourages the use of typedefs for enums. Convert cvmx_spi_mode_t to a plain 'enum cvmx_spi_mode' and update all users across the MIPS Octeon architecture code and the staging driver stubs. This is part of a series converting all remaining enum typedefs in the octeon subsystem to plain enums, improving compliance with the kernel coding style. No functional change. Signed-off-by: Eric Wu --- arch/mips/cavium-octeon/executive/cvmx-spi.c | 16 ++++----- arch/mips/include/asm/octeon/cvmx-spi.h | 38 ++++++++++---------- drivers/staging/octeon/octeon-stubs.h | 6 ++-- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/arch/mips/cavium-octeon/executive/cvmx-spi.c b/arch/mips/caviu= m-octeon/executive/cvmx-spi.c index eb9333e84a6b..b6c0b3fa73ad 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-spi.c +++ b/arch/mips/cavium-octeon/executive/cvmx-spi.c @@ -102,7 +102,7 @@ void cvmx_spi_set_callbacks(cvmx_spi_callbacks_t *new_c= allbacks) * * Returns Zero on success, negative of failure. */ -int cvmx_spi_start_interface(int interface, cvmx_spi_mode_t mode, int time= out, +int cvmx_spi_start_interface(int interface, enum cvmx_spi_mode mode, int t= imeout, int num_ports) { int res =3D -1; @@ -147,7 +147,7 @@ int cvmx_spi_start_interface(int interface, cvmx_spi_mo= de_t mode, int timeout, * * Returns Zero on success, negative of failure. */ -int cvmx_spi_restart_interface(int interface, cvmx_spi_mode_t mode, int ti= meout) +int cvmx_spi_restart_interface(int interface, enum cvmx_spi_mode mode, int= timeout) { int res =3D -1; =20 @@ -192,7 +192,7 @@ EXPORT_SYMBOL_GPL(cvmx_spi_restart_interface); * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -int cvmx_spi_reset_cb(int interface, cvmx_spi_mode_t mode) +int cvmx_spi_reset_cb(int interface, enum cvmx_spi_mode mode) { union cvmx_spxx_dbg_deskew_ctl spxx_dbg_deskew_ctl; union cvmx_spxx_clk_ctl spxx_clk_ctl; @@ -308,7 +308,7 @@ int cvmx_spi_reset_cb(int interface, cvmx_spi_mode_t mo= de) * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -int cvmx_spi_calendar_setup_cb(int interface, cvmx_spi_mode_t mode, +int cvmx_spi_calendar_setup_cb(int interface, enum cvmx_spi_mode mode, int num_ports) { int port; @@ -427,7 +427,7 @@ int cvmx_spi_calendar_setup_cb(int interface, cvmx_spi_= mode_t mode, * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -int cvmx_spi_clock_detect_cb(int interface, cvmx_spi_mode_t mode, int time= out) +int cvmx_spi_clock_detect_cb(int interface, enum cvmx_spi_mode mode, int t= imeout) { int clock_transitions; union cvmx_spxx_clk_stat stat; @@ -505,7 +505,7 @@ int cvmx_spi_clock_detect_cb(int interface, cvmx_spi_mo= de_t mode, int timeout) * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -int cvmx_spi_training_cb(int interface, cvmx_spi_mode_t mode, int timeout) +int cvmx_spi_training_cb(int interface, enum cvmx_spi_mode mode, int timeo= ut) { union cvmx_spxx_trn4_ctl spxx_trn4_ctl; union cvmx_spxx_clk_stat stat; @@ -574,7 +574,7 @@ int cvmx_spi_training_cb(int interface, cvmx_spi_mode_t= mode, int timeout) * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -int cvmx_spi_calendar_sync_cb(int interface, cvmx_spi_mode_t mode, int tim= eout) +int cvmx_spi_calendar_sync_cb(int interface, enum cvmx_spi_mode mode, int = timeout) { uint64_t MS =3D cvmx_sysinfo_get()->cpu_clock_hz / 1000; if (mode & CVMX_SPI_MODE_RX_HALFPLEX) { @@ -630,7 +630,7 @@ int cvmx_spi_calendar_sync_cb(int interface, cvmx_spi_m= ode_t mode, int timeout) * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -int cvmx_spi_interface_up_cb(int interface, cvmx_spi_mode_t mode) +int cvmx_spi_interface_up_cb(int interface, enum cvmx_spi_mode mode) { union cvmx_gmxx_rxx_frm_min gmxx_rxx_frm_min; union cvmx_gmxx_rxx_frm_max gmxx_rxx_frm_max; diff --git a/arch/mips/include/asm/octeon/cvmx-spi.h b/arch/mips/include/as= m/octeon/cvmx-spi.h index d5038cc4b475..88f7e59a396b 100644 --- a/arch/mips/include/asm/octeon/cvmx-spi.h +++ b/arch/mips/include/asm/octeon/cvmx-spi.h @@ -36,35 +36,35 @@ =20 /* CSR typedefs have been moved to cvmx-csr-*.h */ =20 -typedef enum { +enum cvmx_spi_mode { CVMX_SPI_MODE_UNKNOWN =3D 0, CVMX_SPI_MODE_TX_HALFPLEX =3D 1, CVMX_SPI_MODE_RX_HALFPLEX =3D 2, CVMX_SPI_MODE_DUPLEX =3D 3 -} cvmx_spi_mode_t; +}; =20 /** Callbacks structure to customize SPI4 initialization sequence */ typedef struct { /** Called to reset SPI4 DLL */ - int (*reset_cb) (int interface, cvmx_spi_mode_t mode); + int (*reset_cb)(int interface, enum cvmx_spi_mode mode); =20 /** Called to setup calendar */ - int (*calendar_setup_cb) (int interface, cvmx_spi_mode_t mode, - int num_ports); + int (*calendar_setup_cb)(int interface, enum cvmx_spi_mode mode, + int num_ports); =20 /** Called for Tx and Rx clock detection */ - int (*clock_detect_cb) (int interface, cvmx_spi_mode_t mode, - int timeout); + int (*clock_detect_cb)(int interface, enum cvmx_spi_mode mode, + int timeout); =20 /** Called to perform link training */ - int (*training_cb) (int interface, cvmx_spi_mode_t mode, int timeout); + int (*training_cb)(int interface, enum cvmx_spi_mode mode, int timeout); =20 /** Called for calendar data synchronization */ - int (*calendar_sync_cb) (int interface, cvmx_spi_mode_t mode, - int timeout); + int (*calendar_sync_cb)(int interface, enum cvmx_spi_mode mode, + int timeout); =20 /** Called when interface is up */ - int (*interface_up_cb) (int interface, cvmx_spi_mode_t mode); + int (*interface_up_cb)(int interface, enum cvmx_spi_mode mode); =20 } cvmx_spi_callbacks_t; =20 @@ -94,7 +94,7 @@ static inline int cvmx_spi_is_spi_interface(int interface) * * Returns Zero on success, negative of failure. */ -extern int cvmx_spi_start_interface(int interface, cvmx_spi_mode_t mode, +extern int cvmx_spi_start_interface(int interface, enum cvmx_spi_mode mode, int timeout, int num_ports); =20 /** @@ -110,7 +110,7 @@ extern int cvmx_spi_start_interface(int interface, cvmx= _spi_mode_t mode, * @timeout: Timeout to wait for clock synchronization in seconds * Returns Zero on success, negative of failure. */ -extern int cvmx_spi_restart_interface(int interface, cvmx_spi_mode_t mode, +extern int cvmx_spi_restart_interface(int interface, enum cvmx_spi_mode mo= de, int timeout); =20 /** @@ -180,7 +180,7 @@ extern void cvmx_spi_set_callbacks(cvmx_spi_callbacks_t= *new_callbacks); * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -extern int cvmx_spi_reset_cb(int interface, cvmx_spi_mode_t mode); +extern int cvmx_spi_reset_cb(int interface, enum cvmx_spi_mode mode); =20 /** * Callback to setup calendar and miscellaneous settings before clock @@ -197,7 +197,7 @@ extern int cvmx_spi_reset_cb(int interface, cvmx_spi_mo= de_t mode); * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -extern int cvmx_spi_calendar_setup_cb(int interface, cvmx_spi_mode_t mode, +extern int cvmx_spi_calendar_setup_cb(int interface, enum cvmx_spi_mode mo= de, int num_ports); =20 /** @@ -214,7 +214,7 @@ extern int cvmx_spi_calendar_setup_cb(int interface, cv= mx_spi_mode_t mode, * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -extern int cvmx_spi_clock_detect_cb(int interface, cvmx_spi_mode_t mode, +extern int cvmx_spi_clock_detect_cb(int interface, enum cvmx_spi_mode mode, int timeout); =20 /** @@ -231,7 +231,7 @@ extern int cvmx_spi_clock_detect_cb(int interface, cvmx= _spi_mode_t mode, * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -extern int cvmx_spi_training_cb(int interface, cvmx_spi_mode_t mode, +extern int cvmx_spi_training_cb(int interface, enum cvmx_spi_mode mode, int timeout); =20 /** @@ -248,7 +248,7 @@ extern int cvmx_spi_training_cb(int interface, cvmx_spi= _mode_t mode, * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -extern int cvmx_spi_calendar_sync_cb(int interface, cvmx_spi_mode_t mode, +extern int cvmx_spi_calendar_sync_cb(int interface, enum cvmx_spi_mode mod= e, int timeout); =20 /** @@ -264,6 +264,6 @@ extern int cvmx_spi_calendar_sync_cb(int interface, cvm= x_spi_mode_t mode, * Returns Zero on success, non-zero error code on failure (will cause * SPI initialization to abort) */ -extern int cvmx_spi_interface_up_cb(int interface, cvmx_spi_mode_t mode); +extern int cvmx_spi_interface_up_cb(int interface, enum cvmx_spi_mode mode= ); =20 #endif /* __CVMX_SPI_H__ */ diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 291eaffd2543..289a2d41fdc5 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -215,12 +215,12 @@ enum cvmx_fau_op_size { CVMX_FAU_OP_SIZE_64 =3D 3 }; =20 -typedef enum { +enum cvmx_spi_mode { CVMX_SPI_MODE_UNKNOWN =3D 0, CVMX_SPI_MODE_TX_HALFPLEX =3D 1, CVMX_SPI_MODE_RX_HALFPLEX =3D 2, CVMX_SPI_MODE_DUPLEX =3D 3 -} cvmx_spi_mode_t; +}; =20 typedef enum { CVMX_HELPER_INTERFACE_MODE_DISABLED, @@ -1364,7 +1364,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_= sync(cvmx_pow_wait_t wait) } =20 static inline int cvmx_spi_restart_interface(int interface, - cvmx_spi_mode_t mode, int timeout) + enum cvmx_spi_mode mode, int timeout) { return 0; } --=20 2.43.0 From nobody Wed Jun 17 06:05:12 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37BEF3385BE for ; Mon, 27 Apr 2026 15:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305279; cv=none; b=IlLOa5FANRK3HKTbIYhy72/d/3Z007UeQFqbTIdX27aCytFCQffbp5dRNxVHPfzeq7sn3TxPoWfVZatfPBEj0iMk9ZEzO5ChaZs0KYsmdq440VaagYcp8Inn1fKbnw/0tArZvHO6RnugoTJ9NMB83Wx6ROn2YoEJuMNk102RU0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305279; c=relaxed/simple; bh=RFwtc+DWnFArVH3yDlpvTx4fUm7z+0DYCBQcxeZkztg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DgFQKATolKhPbkILdqni+xvvdE8Ywfb+Ybc/Lb2LVqemfCG9mGDorohJmc+KSipQqQd9UjfLbolltiEGfHA2KsRQvFHymzgDhXmsrFEWx1g4OpoBmJObm52hw5peqK7BPvMBblSsPVf8Wd6Zh5aDU/aKH7TaYtLClqa/JbyytJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jAjRY3Up; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jAjRY3Up" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ad4d639db3so51125445ad.0 for ; Mon, 27 Apr 2026 08:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777305278; x=1777910078; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AM2ciHe3IZQx3bTbi2nzxHzfQ0F42LMlFGioqZ6RPhA=; b=jAjRY3UpFLLPzqYxi0LjtNkDVl0VQOyUqzRQMWBNmSI84wBf549v5RLd99LxXafJDd vdALHIfPINb8Fl/wKX5079TS32+QZoHBZDMKrPRHDhhmQTn0N9pKnov37lTtbMSGZ28B cV+K/0XQ6JFC9iosVJvqpWgUugnm33DOlWxGhUC03o31j0xf/XKGrb7bt0KF3+ABUTPe M0GsFQm+ZLLg/bsZfmKEYEZUjLoPDdOehO30LcHZcCv3b7iNnvPTCF33PI4R8YI5bLcR eYhpXN5ngp/bvewOi6+pDo4XXnuDX5n85lzrceIjyyqvrpBs00HUiwHwX6lazvTbhE4V qhDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777305278; x=1777910078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AM2ciHe3IZQx3bTbi2nzxHzfQ0F42LMlFGioqZ6RPhA=; b=eZwwSm4fB/HOGouid0XH4ULxMRkrhHocJGtCtcB9vd2QfWmv8KtKpzw63/lPdi37dm SjJH+lRnHD6uB0oQlpaEGTYs+i6h2+p5/7cO6oc+JYi6DhP8JTBN5W51zVkzDSwYUFNV aTF9bwUborRE6G2QfxB0NbqxLQh+nr3NYLi1gt7O/y9fmgfQVYMJ/ECbjyWYEdtT6MoH 6YYEHEFg1NzIX8KUIMJCy54reDsqmPB3DuQV9BmJ6nkxDUdhETLjTl5xJhdC10oSVWqJ uEJ2LR6J+m2OnyDBALLS7/UfQeMa/8K1RwV0eyp3SCRM70gioMQGCKzaDmlwl53+J3wC SCtg== X-Forwarded-Encrypted: i=1; AFNElJ/N4zEMXsW0F2VwhTOTBRv/hkeQu45SCr+bQo/R2bl2q1teiVsq38JaOxjmuQhDyXumzmmZwSjG29vD8rs=@vger.kernel.org X-Gm-Message-State: AOJu0YzSLWZq76XfJZBu47/hCTKzMo6XL5T6v/KZxBLN76TYnudYjXl5 ekczi7uVMJwAzzKyzxMuRP9jCIeoh2zZlk50uxyI7ZMvqkErNlvmyYUp X-Gm-Gg: AeBDieuycaICT6W+MbezXLi73ut28/HiqAveiWt2Yex/OvxFiaRwK41U/MoWJogNaWc xOOwn41I32+nkQ2H+B7tQUwIJtvE+5Ledenl1KKASENpr8zqVLz/BIUWErydYpqd0vo6jhqHQHA +fpI7AxBfJYQ00wZC1Op3FXIGKNf1VtgiobxvQZrScfQ/kWRC7qX7naStl2591PxpMS6rnSIr4Q yecvj6/G6uSOEdkrmpfvGGxcEgsdNfJvGRGcBMd/yIof3MhUkS1RXyaEH0eMS3ixkSjTV5Vp14b q1clvPc23ryd0R333P5CIeg9VEp8WKqlvXn7pjFBDSaZY/z+NI5IGBJMz46umGj9jrQBiO+6xi3 pZ4uZGhWnITwMrfpwNLSbVJOyBW8cU4oO4Mm1KFC8ICoNOHwnUAVILLgXyKPtG8YToCErEwqNPD KN2DUrBMQ8kbHJ+vz8weDzku8aJUWWA29jPBxemu8fkYxxrJ8GMT4= X-Received: by 2002:a17:903:2acb:b0:2ae:450c:951e with SMTP id d9443c01a7336-2b5f9f08968mr469184115ad.17.1777305277630; Mon, 27 Apr 2026 08:54:37 -0700 (PDT) Received: from localhost (vps-e1cc9378.vps.ovh.us. [2604:2dc0:202:300::1365]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa2df0asm309250075ad.26.2026.04.27.08.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:54:37 -0700 (PDT) From: Eric Wu To: Thomas Bogendoerfer , Greg Kroah-Hartman Cc: linux-mips@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Wu Subject: [PATCH 2/7] staging: octeon: convert cvmx_helper_interface_mode_t from typedef to plain enum Date: Mon, 27 Apr 2026 23:54:22 +0800 Message-ID: <20260427155427.668540-3-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427155427.668540-1-kunjinkao.jp@gmail.com> References: <20260427155427.668540-1-kunjinkao.jp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Linux kernel coding style discourages the use of typedefs for enums. Convert cvmx_helper_interface_mode_t to a plain 'enum cvmx_helper_interface_mode' and update all users across the MIPS Octeon architecture code and the staging driver stubs. No functional change. Signed-off-by: Eric Wu --- arch/mips/cavium-octeon/executive/cvmx-helper-util.c | 2 +- arch/mips/cavium-octeon/executive/cvmx-helper.c | 8 ++++---- arch/mips/cavium-octeon/executive/cvmx-pko.c | 2 +- arch/mips/include/asm/octeon/cvmx-helper-util.h | 2 +- arch/mips/include/asm/octeon/cvmx-helper.h | 6 +++--- drivers/staging/octeon/ethernet.c | 2 +- drivers/staging/octeon/octeon-stubs.h | 6 +++--- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-util.c b/arch/mi= ps/cavium-octeon/executive/cvmx-helper-util.c index 53b912745dbd..abaf91f6ae7c 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-helper-util.c +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-util.c @@ -52,7 +52,7 @@ * * Returns String */ -const char *cvmx_helper_interface_mode_to_string(cvmx_helper_interface_mod= e_t +const char *cvmx_helper_interface_mode_to_string(enum cvmx_helper_interfac= e_mode mode) { switch (mode) { diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c b/arch/mips/ca= vium-octeon/executive/cvmx-helper.c index 9abfc4bf9bd8..1985cd66806a 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-helper.c +++ b/arch/mips/cavium-octeon/executive/cvmx-helper.c @@ -95,7 +95,7 @@ EXPORT_SYMBOL_GPL(cvmx_helper_ports_on_interface); * @INTERNAL * Return interface mode for CN68xx. */ -static cvmx_helper_interface_mode_t __cvmx_get_mode_cn68xx(int interface) +static enum cvmx_helper_interface_mode __cvmx_get_mode_cn68xx(int interfac= e) { union cvmx_mio_qlmx_cfg qlm_cfg; switch (interface) { @@ -147,7 +147,7 @@ static cvmx_helper_interface_mode_t __cvmx_get_mode_cn6= 8xx(int interface) * @INTERNAL * Return interface mode for an Octeon II */ -static cvmx_helper_interface_mode_t __cvmx_get_mode_octeon2(int interface) +static enum cvmx_helper_interface_mode __cvmx_get_mode_octeon2(int interfa= ce) { union cvmx_gmxx_inf_mode mode; =20 @@ -247,7 +247,7 @@ static cvmx_helper_interface_mode_t __cvmx_get_mode_oct= eon2(int interface) * @INTERNAL * Return interface mode for CN7XXX. */ -static cvmx_helper_interface_mode_t __cvmx_get_mode_cn7xxx(int interface) +static enum cvmx_helper_interface_mode __cvmx_get_mode_cn7xxx(int interfac= e) { union cvmx_gmxx_inf_mode mode; =20 @@ -289,7 +289,7 @@ static cvmx_helper_interface_mode_t __cvmx_get_mode_cn7= xxx(int interface) * Returns Mode of the interface. Unknown or unsupported interfaces return * DISABLED. */ -cvmx_helper_interface_mode_t cvmx_helper_interface_get_mode(int interface) +enum cvmx_helper_interface_mode cvmx_helper_interface_get_mode(int interfa= ce) { union cvmx_gmxx_inf_mode mode; =20 diff --git a/arch/mips/cavium-octeon/executive/cvmx-pko.c b/arch/mips/caviu= m-octeon/executive/cvmx-pko.c index 6e70b859a0ac..760abbe12479 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-pko.c +++ b/arch/mips/cavium-octeon/executive/cvmx-pko.c @@ -120,7 +120,7 @@ static void __cvmx_pko_port_map_o68(void) { int port; int interface, index; - cvmx_helper_interface_mode_t mode; + enum cvmx_helper_interface_mode mode; union cvmx_pko_mem_iport_ptrs config; =20 /* diff --git a/arch/mips/include/asm/octeon/cvmx-helper-util.h b/arch/mips/in= clude/asm/octeon/cvmx-helper-util.h index 97b27a07cfb0..103bb5b3142b 100644 --- a/arch/mips/include/asm/octeon/cvmx-helper-util.h +++ b/arch/mips/include/asm/octeon/cvmx-helper-util.h @@ -42,7 +42,7 @@ * Returns String */ extern const char - *cvmx_helper_interface_mode_to_string(cvmx_helper_interface_mode_t mod= e); + *cvmx_helper_interface_mode_to_string(enum cvmx_helper_interface_mode = mode); =20 /** * Setup Random Early Drop to automatically begin dropping packets. diff --git a/arch/mips/include/asm/octeon/cvmx-helper.h b/arch/mips/include= /asm/octeon/cvmx-helper.h index 0cddce35291b..98824ff6314c 100644 --- a/arch/mips/include/asm/octeon/cvmx-helper.h +++ b/arch/mips/include/asm/octeon/cvmx-helper.h @@ -38,7 +38,7 @@ #include #include =20 -typedef enum { +enum cvmx_helper_interface_mode { CVMX_HELPER_INTERFACE_MODE_DISABLED, CVMX_HELPER_INTERFACE_MODE_RGMII, CVMX_HELPER_INTERFACE_MODE_GMII, @@ -49,7 +49,7 @@ typedef enum { CVMX_HELPER_INTERFACE_MODE_PICMG, CVMX_HELPER_INTERFACE_MODE_NPI, CVMX_HELPER_INTERFACE_MODE_LOOP, -} cvmx_helper_interface_mode_t; +}; =20 union cvmx_helper_link_info { uint64_t u64; @@ -125,7 +125,7 @@ extern int cvmx_helper_get_number_of_interfaces(void); * Returns Mode of the interface. Unknown or unsupported interfaces return * DISABLED. */ -extern cvmx_helper_interface_mode_t cvmx_helper_interface_get_mode(int +extern enum cvmx_helper_interface_mode cvmx_helper_interface_get_mode(int interface); =20 /** diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/eth= ernet.c index eadb74fc14c8..5f9c29071fab 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -798,7 +798,7 @@ static int cvm_oct_probe(struct platform_device *pdev) =20 num_interfaces =3D cvmx_helper_get_number_of_interfaces(); for (interface =3D 0; interface < num_interfaces; interface++) { - cvmx_helper_interface_mode_t imode =3D + enum cvmx_helper_interface_mode imode =3D cvmx_helper_interface_get_mode(interface); int num_ports =3D cvmx_helper_ports_on_interface(interface); int port; diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 289a2d41fdc5..6c0329270464 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -222,7 +222,7 @@ enum cvmx_spi_mode { CVMX_SPI_MODE_DUPLEX =3D 3 }; =20 -typedef enum { +enum cvmx_helper_interface_mode { CVMX_HELPER_INTERFACE_MODE_DISABLED, CVMX_HELPER_INTERFACE_MODE_RGMII, CVMX_HELPER_INTERFACE_MODE_GMII, @@ -233,7 +233,7 @@ typedef enum { CVMX_HELPER_INTERFACE_MODE_PICMG, CVMX_HELPER_INTERFACE_MODE_NPI, CVMX_HELPER_INTERFACE_MODE_LOOP, -} cvmx_helper_interface_mode_t; +}; =20 typedef enum { CVMX_POW_WAIT =3D 1, @@ -1267,7 +1267,7 @@ static inline void cvmx_pko_get_port_status(u64 port_= num, u64 clear, cvmx_pko_port_status_t *status) { } =20 -static inline cvmx_helper_interface_mode_t cvmx_helper_interface_get_mode(= int +static inline enum cvmx_helper_interface_mode cvmx_helper_interface_get_mo= de(int interface) { return 0; --=20 2.43.0 From nobody Wed Jun 17 06:05:12 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FAB834BA5A for ; Mon, 27 Apr 2026 15:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305282; cv=none; b=dRY/rO3SzURPytap4BGa5O8AmG7RyJQ8Ehc4F+HZAgDw9SLD5XGM05NCxE8Wl65fIpOR0Yxz5sadW/Ud03rc2OmfVYhzegOGMUTS2ZZiHDg9TfKbUOaYwxcTfxjZmIqOdgfsEaCzJo58JPpWnQ6pCBe3e6n8hz2/umhSWRxJnNk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305282; c=relaxed/simple; bh=dPVmA4SAKvP8uttiAwiTIqfYjB1yylln+rbXAL0TOHw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gtUgRjaOo0zX9Xo54CuSsMsg0wENBL8KtlNhPylCyeG7Oa3rW0yMsgHm3uWDtevPvUVn7ZTciiA435GTSjiavx4uBxMsaKLXCUN0HthOUTl02Edo12dkB5RI1mgSErXl56FhDMapMM9+PT9tVNKOEaZEJu8Tyy//YDKDf6SdEPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NfmUBoSY; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NfmUBoSY" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-83178c0f29cso2974138b3a.0 for ; Mon, 27 Apr 2026 08:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777305281; x=1777910081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/nEwsx1IE37alek/UbFFJIAS/ZU1TO09DbXxHjDA5/4=; b=NfmUBoSYERI8Uk+PjJxdwhNl9UjFP3CjNR/8kIZxilZUuaGybt1owd8knTKwpmp673 DVKBXgnm/9fJqHLNzWZsfWYWygz9SfKYRmheTeKwGpm+NCY4wTukogGeFq/tBpAcFAEg AXRiV8WxD0aT+5gI2mpbLAW25EKgJYty9HWnaO3+2jqhJgV8+QE69ik+T3rQnrgJsANl eOoG99gfh+kUdFDhrZAbQh34uHMRrlQEJhgd9iDPw65fyabCoxqCCNb0NbmlGVpu7ufW AnS21LiJ4Zpfnd4cme4maw/SgdN6CVRR6B1sXSu5thRt2K2IihdBnoV854PZIAFyVywU 6Szg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777305281; x=1777910081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/nEwsx1IE37alek/UbFFJIAS/ZU1TO09DbXxHjDA5/4=; b=r+/F7shZ0vZa/XOuuqqMFBcyaknB7weivg8RHT744c38lfazDnj0uj99ANv/Tygp7m M9dL/VW5chC8Q7FsQC78XuWKpFQIkqy1KGnLPB4tSejbZjD5rQ3bBH4sftvMmSl5UAwJ Ga7PStzpUdrQs0SaXhF87P8yF3Mc426M1oXWa8rwgDiWhnM6KuPAmOEJtUkd+/h5NRFv rZ5cWaaAvzpTDfkky7BFdZrS4PaX6WxS4kjsIGMau9Ehuku2jDgek8osAimPdwRTBUNb kbW+1lEtuJg/Y80WpjWIJepvGBaoVbG2J6THVlmaHAs+Pdgk45/WUGC0QJtzYIW45IMt pTnA== X-Forwarded-Encrypted: i=1; AFNElJ/dt607uuk7mmoIa7dIt5+gS66gSyogOCOz/g5cTnpuPGF9KDxQGBd/Lr6VN1BJdyZv59mmyprrn8pRy1I=@vger.kernel.org X-Gm-Message-State: AOJu0YyTVI5U/jV/WzzDCAA4Xgln4jKNDOGuGyfvIf92JdxkorwrQkDE eOH8z4uOWN2bQ8oITzlNTIrCPdV2cZhmWcyR6zXalrdYvHsy1PycybH4 X-Gm-Gg: AeBDiesQd3uD3+ZXx5q44SZpfBLMoa0HeEEo+hFiAKKtScFjosfGOyxQaT0pWWIC7sL pgWQaPT74VemK7Av58H2GSpO8O9yiSFBHUCrnYWxN3vJHwcsx1VT52bx+Qyffe0zWCNRGav+c1E luWhZvZ9lTkhr8+vi350WcRfm3i6YrRvX3bieJusNpMDZQuUju7FTlitHmJSDrPu/lh1qWVMjbn 4icvOCqRIQbEYTv6NKcnECBvQh4VX2RDa5/LY9FCRo7Zw3+KiB/oh3o5GRLhRiXeg0uhYR9lk3U e80M4D+nOqpGMC+mgd7dRAXtRREpP0qJB+q0nWamLmVEAcgV1i5/eUlrTDVp+7V+zwo/IL0CkEq xrO7tIxVtX7luw+ayaOdoI+HzEax39OcAOjOSH3lbx1wS9aBxmJriSBX8u4avlM3oLnTKjbRQ8m GNKWldX/KbfZpUXBVIm9O/IqXJfnJ21hNffINGkdHp X-Received: by 2002:a05:6a00:1acc:b0:82f:4a4d:377e with SMTP id d2e1a72fcca58-82f8c8c2f8fmr48204285b3a.28.1777305280668; Mon, 27 Apr 2026 08:54:40 -0700 (PDT) Received: from localhost (vps-e1cc9378.vps.ovh.us. [2604:2dc0:202:300::1365]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f932daa68sm34339028b3a.49.2026.04.27.08.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:54:40 -0700 (PDT) From: Eric Wu To: Thomas Bogendoerfer , Greg Kroah-Hartman Cc: linux-mips@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Wu Subject: [PATCH 3/7] staging: octeon: convert cvmx_pow_wait_t from typedef to plain enum Date: Mon, 27 Apr 2026 23:54:23 +0800 Message-ID: <20260427155427.668540-4-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427155427.668540-1-kunjinkao.jp@gmail.com> References: <20260427155427.668540-1-kunjinkao.jp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Linux kernel coding style discourages the use of typedefs for enums. Convert cvmx_pow_wait_t to a plain 'enum cvmx_pow_wait' and update all users across the MIPS Octeon architecture code and the staging driver stubs. No functional change. Signed-off-by: Eric Wu --- arch/mips/include/asm/octeon/cvmx-pow.h | 12 ++++++------ drivers/staging/octeon/octeon-stubs.h | 10 +++++----- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/mips/include/asm/octeon/cvmx-pow.h b/arch/mips/include/as= m/octeon/cvmx-pow.h index 21b4378244fa..409029809639 100644 --- a/arch/mips/include/asm/octeon/cvmx-pow.h +++ b/arch/mips/include/asm/octeon/cvmx-pow.h @@ -84,10 +84,10 @@ enum cvmx_pow_tag_type { /** * Wait flag values for pow functions. */ -typedef enum { +enum cvmx_pow_wait { CVMX_POW_WAIT =3D 1, CVMX_POW_NO_WAIT =3D 0, -} cvmx_pow_wait_t; +}; =20 /** * POW tag operations. These are used in the data stored to the POW. @@ -1348,7 +1348,7 @@ static inline void cvmx_pow_tag_sw_wait(void) * Returns: the WQE pointer from POW. Returns NULL if no work * was available. */ -static inline struct cvmx_wqe *cvmx_pow_work_request_sync_nocheck(cvmx_pow= _wait_t +static inline struct cvmx_wqe *cvmx_pow_work_request_sync_nocheck(enum cvm= x_pow_wait wait) { cvmx_pow_load_addr_t ptr; @@ -1382,7 +1382,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_= sync_nocheck(cvmx_pow_wait_ * Returns: the WQE pointer from POW. Returns NULL if no work * was available. */ -static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t = wait) +static inline struct cvmx_wqe *cvmx_pow_work_request_sync(enum cvmx_pow_wa= it wait) { if (CVMX_ENABLE_POW_CHECKS) __cvmx_pow_warn_if_pending_switch(__func__); @@ -1436,7 +1436,7 @@ static inline enum cvmx_pow_tag_type cvmx_pow_work_re= quest_null_rd(void) * timeout), 0 to cause response to return immediately */ static inline void cvmx_pow_work_request_async_nocheck(int scr_addr, - cvmx_pow_wait_t wait) + enum cvmx_pow_wait wait) { cvmx_pow_iobdma_store_t data; =20 @@ -1465,7 +1465,7 @@ static inline void cvmx_pow_work_request_async_nochec= k(int scr_addr, * timeout), 0 to cause response to return immediately */ static inline void cvmx_pow_work_request_async(int scr_addr, - cvmx_pow_wait_t wait) + enum cvmx_pow_wait wait) { if (CVMX_ENABLE_POW_CHECKS) __cvmx_pow_warn_if_pending_switch(__func__); diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 6c0329270464..df0456417f15 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -235,10 +235,10 @@ enum cvmx_helper_interface_mode { CVMX_HELPER_INTERFACE_MODE_LOOP, }; =20 -typedef enum { +enum cvmx_pow_wait { CVMX_POW_WAIT =3D 1, CVMX_POW_NO_WAIT =3D 0, -} cvmx_pow_wait_t; +}; =20 typedef enum { CVMX_PKO_LOCK_NONE =3D 0, @@ -1344,11 +1344,11 @@ static inline unsigned int cvmx_get_core_num(void) } =20 static inline void cvmx_pow_work_request_async_nocheck(int scr_addr, - cvmx_pow_wait_t wait) + enum cvmx_pow_wait wait) { } =20 static inline void cvmx_pow_work_request_async(int scr_addr, - cvmx_pow_wait_t wait) + enum cvmx_pow_wait wait) { } =20 static inline struct cvmx_wqe *cvmx_pow_work_response_async(int scr_addr) @@ -1358,7 +1358,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_response= _async(int scr_addr) return wqe; } =20 -static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t = wait) +static inline struct cvmx_wqe *cvmx_pow_work_request_sync(enum cvmx_pow_wa= it wait) { return (void *)(unsigned long)wait; } --=20 2.43.0 From nobody Wed Jun 17 06:05:12 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F24B34E754 for ; Mon, 27 Apr 2026 15:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305285; cv=none; b=EmqkVcP9HpSy/YMbKb5ve8KX7EETuVWkJ6OxsCXs6bka4QIcFnlVm52/xmhw9uLhadC0qRB6Ee9xvcse/6qLY60F6lvqzj70mLrQR3TGIOLtlYg9ipR6N7NsJNwc5LZTm/2B4wwGNJj3JEfeFiCuPGFfXAV/Pn+io/QahtaSpdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305285; c=relaxed/simple; bh=Lx+FWdTX4CUROM4Gf843xRsUmieLSZtB1d7xcdZ8S/k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W6LVptxR4U23utdO6omaMcI/6Z/senq033wN0nR1IK2PwpbOqrLbzpH0h37iVLSOV3gZDZGPi7b/4dbjGTNYLPuXm6ZoIbXbeFq10vVNOjoYspZ09PR45TzCznFhnp9TlnfJzpOizW5gEnikApY1If5eJz04oljqU5QnX5Iehvw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=keOncsdr; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="keOncsdr" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8296dabef74so8625801b3a.1 for ; Mon, 27 Apr 2026 08:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777305284; x=1777910084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DgFqJGxTSWQ0zarrhY26FqAsVAR+FlyVmEuRhaiFjvY=; b=keOncsdrilFMMsGJE7Xg/r8PAzzsM1oD3meAoV3c893RCouE64f2CdunqhOg4SudQu gia6PKT0wswM9r4BRmLDhAGRyn10vSXER4ZuAYExXCi1P0mMYgICT4cgfA8+BA1N0ynh ggcwk/D5WzT9J/IDTMrvXIYtFSlv4RM1lMUA4acosD9jP3Fk3Rq54edNwpRMfuw/mgM9 tLbGmyC0+ZkpzyoEwPS/YVogUsWJCY+EiaSXmcj5M0Am1+c3CROPJQY6F2rwBrXi8I8p jzR2F9I6wvsWLqE7tqKVwXXq7jrwEQ6+fcyNf1QkGOismZLJtphrIq+70f3As8uuj4Sp 3Dow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777305284; x=1777910084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DgFqJGxTSWQ0zarrhY26FqAsVAR+FlyVmEuRhaiFjvY=; b=sI3r3qUux+4u6Zu2IlLWqJ2ES/V0vTg8ja63A/KwDHSnnI7xdxUoHle2E73aGHPPtS KFQHZpQFAXogz5nXN6rkomxZHo58ZK+NBFQhKQxcjabX+ox3giEAOnN73qMHkWHYWjNP C5yuKQtFo1g3pgK4yZVGtlPgK599/9y2G/zSWNiooV1GHM7/OzMCPuKw+UeIzpvDwi10 TY/QNeo+xF3hC23yEQHlyMX5J1+Xmb3jkOOfap/fJI7FAOlEoHxIcsrUnOh21T4REnQ7 f6DHRHDvD9oV5FqM8EVPV1G0Wdd5L/bBBK7+Li6ZlJKi8qtwiOsh0uXvRiWZ2p40dUqJ NURg== X-Forwarded-Encrypted: i=1; AFNElJ+dioI42pabZFkrjAzM+lHJH3N08G5koo8oNwH/FMUWJE2cXlgshFzPzmuZEW8WAQqpteX5JmB5CBvEOZg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywom2Jg31SMIhGEZP/JmjIJuE0Zrv/1D3TR0nNCavRNNWGtT7q+ gQbaiM8uUt+n3QwEBHp6A7Mz3tkC3rObfrLWryx3E9ZRHI9Nap5M4GY3 X-Gm-Gg: AeBDievo0HH879K8/hqD1PlU6Ya7n8tFVTSDrGRghczS1TJ2g9tdq5blsgvFXTv892G OAnsaEluPF7f+As7T8wsVjJhaM/CZ6j2FUTkIOLDrx18BtG8YNOV0J4EAUVDiy961ry/DI9bPgg hscZMCqcGJP0L6xk6YpQxwqQUmBaZG24k2p/sBqcIBiWU9RGGR3k1QG4eweBnoFDh+ChkJUv5yz LyyrZn+Yi5HhUgELFVl2vSbfzR1KKMlXUWsHZATWZZhHZqV6MePvucoDSm1xVnBOBSwy0bAcGOp 6hW48/8et/S6cMIH3HsLusrtMJjDIqIZCVAA5+Usg56Sp+Ue7ofulPOHkdBio0nPqph78p/vXFM JOKJoJOK1Iipq+l10CaYLUoH/iV1kk1dLiX5QS+YLe2Di4TbQTGRbS3y3RmYNkMQeQkDgmYpvft 44h9f/5IdFZX8a7vw9fvTDWt2LFvR1RnkSBDGcVGJFDZLFnSL/g+M= X-Received: by 2002:a05:6a00:2e15:b0:82c:d7c9:5479 with SMTP id d2e1a72fcca58-82f8c9024bamr47144381b3a.32.1777305283728; Mon, 27 Apr 2026 08:54:43 -0700 (PDT) Received: from localhost (vps-e1cc9378.vps.ovh.us. [2604:2dc0:202:300::1365]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb3829sm34445786b3a.31.2026.04.27.08.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:54:43 -0700 (PDT) From: Eric Wu To: Thomas Bogendoerfer , Greg Kroah-Hartman Cc: linux-mips@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Wu Subject: [PATCH 4/7] staging: octeon: convert cvmx_pko_lock_t from typedef to plain enum Date: Mon, 27 Apr 2026 23:54:24 +0800 Message-ID: <20260427155427.668540-5-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427155427.668540-1-kunjinkao.jp@gmail.com> References: <20260427155427.668540-1-kunjinkao.jp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Linux kernel coding style discourages the use of typedefs for enums. Convert cvmx_pko_lock_t to a plain 'enum cvmx_pko_lock' and update all users across the MIPS Octeon architecture code and the staging driver stubs. No functional change. Signed-off-by: Eric Wu --- arch/mips/include/asm/octeon/cvmx-pko.h | 10 +++++----- drivers/staging/octeon/octeon-stubs.h | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/mips/include/asm/octeon/cvmx-pko.h b/arch/mips/include/as= m/octeon/cvmx-pko.h index f18a7f24daf8..d8e74a305646 100644 --- a/arch/mips/include/asm/octeon/cvmx-pko.h +++ b/arch/mips/include/asm/octeon/cvmx-pko.h @@ -93,7 +93,7 @@ typedef enum { /** * This enumeration represents the different locking modes supported by PK= O. */ -typedef enum { +enum cvmx_pko_lock { /* * PKO doesn't do any locking. It is the responsibility of the * application to make sure that no other core is accessing @@ -112,7 +112,7 @@ typedef enum { * ll/sc. This is the most portable locking mechanism. */ CVMX_PKO_LOCK_CMD_QUEUE =3D 2, -} cvmx_pko_lock_t; +}; =20 typedef struct { uint32_t packets; @@ -374,7 +374,7 @@ static inline void cvmx_pko_doorbell(uint64_t port, uin= t64_t queue, */ =20 static inline void cvmx_pko_send_packet_prepare(uint64_t port, uint64_t qu= eue, - cvmx_pko_lock_t use_locking) + enum cvmx_pko_lock use_locking) { if (use_locking =3D=3D CVMX_PKO_LOCK_ATOMIC_TAG) { /* @@ -419,7 +419,7 @@ static inline cvmx_pko_status_t cvmx_pko_send_packet_fi= nish( uint64_t queue, union cvmx_pko_command_word0 pko_command, union cvmx_buf_ptr packet, - cvmx_pko_lock_t use_locking) + enum cvmx_pko_lock use_locking) { cvmx_cmd_queue_result_t result; if (use_locking =3D=3D CVMX_PKO_LOCK_ATOMIC_TAG) @@ -463,7 +463,7 @@ static inline cvmx_pko_status_t cvmx_pko_send_packet_fi= nish3( union cvmx_pko_command_word0 pko_command, union cvmx_buf_ptr packet, uint64_t addr, - cvmx_pko_lock_t use_locking) + enum cvmx_pko_lock use_locking) { cvmx_cmd_queue_result_t result; if (use_locking =3D=3D CVMX_PKO_LOCK_ATOMIC_TAG) diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index df0456417f15..06cb4f15d9d5 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -240,11 +240,11 @@ enum cvmx_pow_wait { CVMX_POW_NO_WAIT =3D 0, }; =20 -typedef enum { +enum cvmx_pko_lock { CVMX_PKO_LOCK_NONE =3D 0, CVMX_PKO_LOCK_ATOMIC_TAG =3D 1, CVMX_PKO_LOCK_CMD_QUEUE =3D 2, -} cvmx_pko_lock_t; +}; =20 typedef enum { CVMX_PKO_SUCCESS, @@ -1383,12 +1383,12 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi= 4000_check_speed(int interfac } =20 static inline void cvmx_pko_send_packet_prepare(u64 port, u64 queue, - cvmx_pko_lock_t use_locking) + enum cvmx_pko_lock use_locking) { } =20 static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(u64 port, u64 queue, union cvmx_pko_command_word0 pko_command, - union cvmx_buf_ptr packet, cvmx_pko_lock_t use_locking) + union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking) { return 0; } --=20 2.43.0 From nobody Wed Jun 17 06:05:12 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75BD34D4F9 for ; Mon, 27 Apr 2026 15:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305289; cv=none; b=Mr2I9+MwiLBWSyLMH6ZejGvS6wRSthKM87aHApgxOzk/agqY4EIMaB9bNLvdFNNPCgu+VnWxQdU9OhymNP/IGy/brqN4+Eo2flBvV6N7+7tDZQZe6m4CQfNcmCojMNLgCJKPAxEqWBDBIPjDkA+qp6UpVExo9tCAGURe480noqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305289; c=relaxed/simple; bh=Uw+6McxcbR1X0j5mklzKziZGlm8Wj4N2l8z9PIZdiy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NU3GFLYVexmqev6G6YroH32uWmNIb6+Vo1QUsLIUlJmjVosvBv9LcJXPpyYHb2fjFw1OehPo7gFkuXCdxTKvJvG1qwkzdS/GxEQEvcsotTdv2OQDUFvyXUWqWVsCWDKeLIoAblWwSdga1iPV0BNJkoXZnrF1pedSQEt3KXi5uig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bmnZ8vFu; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bmnZ8vFu" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so88541045ad.2 for ; Mon, 27 Apr 2026 08:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777305287; x=1777910087; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ThV84gm5Y5EtW/yF0FDrADPw1AaaVSJvSYelejtPtaE=; b=bmnZ8vFuj0UkQHx9IL7DB4naRu95la1a/S7mbFI5JWlc4hnA5fH9k+eL80DqjVAHZO 2nb7s169nK4b4b1mKVK+2ff+6kJBIOoJRs4929KU3zFRVuqQwe4MwiEjO8BbKQlfe77Z +CuK2FKEXwIiRKDyIyprvOxU2aKz+wNlZz6hC36kPzrzhCisPcq/9xii5MYexEIik1HK 7W3CgD20R3WMVms2VbtnyXzVOZZ4tGTeKji3YO05dmdaljCugLtM1KwxjtPOm0BEyhCf mx69QXnJPD7x9OBAghb/8gUCBpp+lDp/VVfRifvMdHGycMJvLqJjRB3+1Zp1YurTMNzt omoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777305287; x=1777910087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ThV84gm5Y5EtW/yF0FDrADPw1AaaVSJvSYelejtPtaE=; b=GMSB6EUwiFkBHtcSV8skJ79THyV7W1W5tUF7HPrq6ff0YR2+zVvo4rWqdefadoqZ7I LFsuOnwgekEVJTb+iTzv9IsbvT3MS/ulmdN654YFZ+6apJ6gfT6JGg6STiYgzpNLSGTx TuS1ZFjD9eRaGh/Qy+5GnbgSVzF8TQqSiJWEpumwvYhTdSuQ4hsu85G9SQfY3elbxCm4 hfDLkY4q6KRMdOvszO85QcCvt5X18sbtsFb6b349hgj0ZxFIMdcEEHFPMFdXZR1AjrER u/mnXo/nhjAM6IQjJgdBJO+YSaV6WQv4CjQgz+qPppbs0hrLJe7nvIqAdT2EHz/Lo+Er 0SDA== X-Forwarded-Encrypted: i=1; AFNElJ+DA79QMr68Z0nI550ZSEi2ETQt2HmCfFv+zItiI/GFqC6rv67KBAfbu7ApJaZuGNO3K3hEvLQT+Nl+usQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxcnMKfEiIx+jBnugnlj4e6eBRaZ9kv5iVfU8YXDaPsQyaqDf5k KnWeAVU59hJrw03hflwNADAyWB0fGfEVfRdLQb4FfTOT9vo5vxDBX4UI2/RcvhmpcWnizg== X-Gm-Gg: AeBDieuDNIAqCC/gg9D1RGzKsdm1RNIo2+fsrQT+WrgVOjHDmC+Av/jmZkY7R4PcRPU Oit7bNWJOpZmJ6OrIhqVFn/vvxzLY5MV/cC1aJk2szbtvDdIVqFWr3CBmIoyYRmwwq5h57rhw4V srM8i6WO7zqz1zbmdxFGfQEO+UC6aiCS4l/q1WK4TywNGbECf5YWotL4aIqDcnjRsZ9hr/U8U0g Oi7ouKLr6FwvjdImROpe8+a/Z9VfU3/uMl7STNmo+el+IIbXrmtRqxNWG+9sKyK7sFGsBDrLbzD K3oyY2stLdOcxdBbYTBMkH3CkrJl16diXppkgEfv4F9HzsIN3meVnOCPcvpmTHHo0ZamhC01cTl wL8QvoFlbGAyRNwyG7ba6LvdfPKln4qSVqWkJ5un0DyWP901r0YZXlQIXQsZ7KeWuRhIqdsTNKh /pQ4R3PYARNKfEoghV3LVsPrgejmHDg8qoGZep/OyK X-Received: by 2002:a17:902:7c0f:b0:2b2:b117:1e16 with SMTP id d9443c01a7336-2b5f9f7e95fmr332045605ad.20.1777305286937; Mon, 27 Apr 2026 08:54:46 -0700 (PDT) Received: from localhost (vps-e1cc9378.vps.ovh.us. [2604:2dc0:202:300::1365]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0caa9sm306493235ad.40.2026.04.27.08.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:54:46 -0700 (PDT) From: Eric Wu To: Thomas Bogendoerfer , Greg Kroah-Hartman Cc: linux-mips@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Wu Subject: [PATCH 5/7] staging: octeon: convert cvmx_pko_status_t from typedef to plain enum Date: Mon, 27 Apr 2026 23:54:25 +0800 Message-ID: <20260427155427.668540-6-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427155427.668540-1-kunjinkao.jp@gmail.com> References: <20260427155427.668540-1-kunjinkao.jp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Linux kernel coding style discourages the use of typedefs for enums. Convert cvmx_pko_status_t to a plain 'enum cvmx_pko_status' and update all users across the MIPS Octeon architecture code and the staging driver stubs. No functional change. Signed-off-by: Eric Wu --- arch/mips/cavium-octeon/executive/cvmx-pko.c | 4 ++-- arch/mips/include/asm/octeon/cvmx-pko.h | 10 +++++----- drivers/staging/octeon/octeon-stubs.h | 6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/mips/cavium-octeon/executive/cvmx-pko.c b/arch/mips/caviu= m-octeon/executive/cvmx-pko.c index 760abbe12479..b0199d5cb551 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-pko.c +++ b/arch/mips/cavium-octeon/executive/cvmx-pko.c @@ -323,11 +323,11 @@ EXPORT_SYMBOL_GPL(cvmx_pko_shutdown); * queues have higher priority than higher numbered queues. * There must be num_queues elements in the array. */ -cvmx_pko_status_t cvmx_pko_config_port(uint64_t port, uint64_t base_queue, +enum cvmx_pko_status cvmx_pko_config_port(uint64_t port, uint64_t base_que= ue, uint64_t num_queues, const uint64_t priority[]) { - cvmx_pko_status_t result_code; + enum cvmx_pko_status result_code; uint64_t queue; union cvmx_pko_mem_queue_ptrs config; union cvmx_pko_reg_queue_ptrs1 config1; diff --git a/arch/mips/include/asm/octeon/cvmx-pko.h b/arch/mips/include/as= m/octeon/cvmx-pko.h index d8e74a305646..a742c1d61d8f 100644 --- a/arch/mips/include/asm/octeon/cvmx-pko.h +++ b/arch/mips/include/asm/octeon/cvmx-pko.h @@ -80,7 +80,7 @@ #define CVMX_PKO_ILLEGAL_QUEUE 0xFFFF #define CVMX_PKO_MAX_QUEUE_DEPTH 0 =20 -typedef enum { +enum cvmx_pko_status { CVMX_PKO_SUCCESS, CVMX_PKO_INVALID_PORT, CVMX_PKO_INVALID_QUEUE, @@ -88,7 +88,7 @@ typedef enum { CVMX_PKO_NO_MEMORY, CVMX_PKO_PORT_ALREADY_SETUP, CVMX_PKO_CMD_QUEUE_INIT_ERROR -} cvmx_pko_status_t; +}; =20 /** * This enumeration represents the different locking modes supported by PK= O. @@ -306,7 +306,7 @@ extern void cvmx_pko_shutdown(void); * of a value of 1. There must be num_queues elements in the * array. */ -extern cvmx_pko_status_t cvmx_pko_config_port(uint64_t port, +extern enum cvmx_pko_status cvmx_pko_config_port(uint64_t port, uint64_t base_queue, uint64_t num_queues, const uint64_t priority[]); @@ -414,7 +414,7 @@ static inline void cvmx_pko_send_packet_prepare(uint64_= t port, uint64_t queue, * Returns: CVMX_PKO_SUCCESS on success, or error code on * failure of output */ -static inline cvmx_pko_status_t cvmx_pko_send_packet_finish( +static inline enum cvmx_pko_status cvmx_pko_send_packet_finish( uint64_t port, uint64_t queue, union cvmx_pko_command_word0 pko_command, @@ -457,7 +457,7 @@ static inline cvmx_pko_status_t cvmx_pko_send_packet_fi= nish( * Returns: CVMX_PKO_SUCCESS on success, or error code on * failure of output */ -static inline cvmx_pko_status_t cvmx_pko_send_packet_finish3( +static inline enum cvmx_pko_status cvmx_pko_send_packet_finish3( uint64_t port, uint64_t queue, union cvmx_pko_command_word0 pko_command, diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 06cb4f15d9d5..8496c60d647e 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -246,7 +246,7 @@ enum cvmx_pko_lock { CVMX_PKO_LOCK_CMD_QUEUE =3D 2, }; =20 -typedef enum { +enum cvmx_pko_status { CVMX_PKO_SUCCESS, CVMX_PKO_INVALID_PORT, CVMX_PKO_INVALID_QUEUE, @@ -254,7 +254,7 @@ typedef enum { CVMX_PKO_NO_MEMORY, CVMX_PKO_PORT_ALREADY_SETUP, CVMX_PKO_CMD_QUEUE_INIT_ERROR -} cvmx_pko_status_t; +}; =20 enum cvmx_pow_tag_type { CVMX_POW_TAG_TYPE_ORDERED =3D 0L, @@ -1386,7 +1386,7 @@ static inline void cvmx_pko_send_packet_prepare(u64 p= ort, u64 queue, enum cvmx_pko_lock use_locking) { } =20 -static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(u64 port, +static inline enum cvmx_pko_status cvmx_pko_send_packet_finish(u64 port, u64 queue, union cvmx_pko_command_word0 pko_command, union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking) { --=20 2.43.0 From nobody Wed Jun 17 06:05:12 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8257352F85 for ; Mon, 27 Apr 2026 15:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305291; cv=none; b=fnQgr8BArw7WVHkoIpFacWEHnYIpu70GPySSpPpF4+/btUSrVQOBSohztOGsrc5LMP9GaNuToPzwljYAAedgAVxIJXDJFe4OVYxL0xuSyodOBJMKO/DBKj2UeOLVSEHCIbUYbLnImyvJKuwanMVYiMOhnMYMszmDXGYdmJs+maE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305291; c=relaxed/simple; bh=3lMBDTmGVSzQWPgjOUuDoQlBGhvTrtUqoyElVhNjLfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K6q0Spvi3hGkdd4WS+8xD1hkPPUnauX/+68ntlqY74Kc+nhTDYFZMXdTyt3kV8hXUapaxFgI3edTj4o9Qz8LRG3sKN/tWk+hiklKzHH0Yij/rlBXBMoO8LvgxzyGecAd/7AUWvMxIz1IX9eJCoJN8EnfikjAmi+NXMy8C+90qoY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fOvXxPjH; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fOvXxPjH" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2b24fdac394so99599905ad.3 for ; Mon, 27 Apr 2026 08:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777305290; x=1777910090; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=thNCQIJeEhwAIcXi2kXr3H7Q3kP3X1CPFM6RiVR/dT4=; b=fOvXxPjHKrM8c3Vpr634sd7SFCE/Q1bWfZdVFDUuSE2BwOCMvrwRt0y2SXDQtnIPPq Oyd9sxH6oyK2nTUspIADvAnWE7FSGBG5vOE8uMdyU9X3Gs1S6Sf8af/BT521vsjBRXCw QPVX+o429w2Xp7Zkca9GQwsrgxmjkRkrcx/b1uVd0HATWrY7KDvmiRTrCSqwvV4UQBSN +jVZZDQJcFVkVG0wcP55Ckk5TcnLZw7rx7tZ3r1w8fyHJVxre1FrsJYusTfSi2N7mjvu Jdf+dY/rdaYC03+xHi1AT+CXEmiq0UMmsejJRn+QYEFmvFlGMqO7fYxDOpIX2gqiLfkx b7vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777305290; x=1777910090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=thNCQIJeEhwAIcXi2kXr3H7Q3kP3X1CPFM6RiVR/dT4=; b=qQWZIwAVAzx6+BncfBaQYxQYJG5ACuJwsBF+/qtty+/6fjY9EgdJmUbWgXN1Gge3IQ ekNhagL2VTBxZs0arUf6EV7orvMB3GCNZyd2OCZasME6D7tWvL5C+FY4YqtH6F8X1eNR tHs1kBNmcT7G3ASSWgAsGt4dky9TXBCCb1mY3xT0aKNGINlfrWnLvVn596YrVkEM7F9P BV4WguTSZfeSdoejWWybn4/2DaNmf8yQY7ThfRcbwlxUHqDd4tEuSwHsLmIZTGRQ1b9O jSN0dg4LsNEkPv/VYg4/AOIp7M1qOeBkc/9heGRerWiDKydkDTO02VQ9+2cAV+8O+KZO TC3A== X-Forwarded-Encrypted: i=1; AFNElJ+D9Bu1/VYbpLfWzNXa+rSk41cjqA6S0soRQ8Z2FuQ7h6YeLw2pMOG263Qsl6mJ62UtrJnj4Ull/ghJDEg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/OBoJqsauPesi41Kp0VqDikmdczUEwhWX9KE4HXWujzYKQsOJ FnJcBjmpF83v/kdGLxsQsRnycEVeQ6So0Mi2GmV6RyIksc0HqHbl9rsM X-Gm-Gg: AeBDietM9tawfOUxRl1wYagrjCRSuld0Jrf0enjTMxlu9OAllB6/4dv0q/PpJ1BHRNP vUGQI8mqbHbuglncSdpZx7WBBQyVhYKLB682uBdU2fGFZAR88GyWEeiJyZFatrgjum14awxJiE8 AFjJONcfB3BKASLieva+F+Gb4vGtGuQJns/slgTipO8zbXdzqL4C52LXK+agGegrqfZD4Kpva/n 2U49h/Cig6okkZ40eByxAhK82RioMUGbkVMOHe+51foBCkhxRjfd8KcC34mdkmFv3HvnQR018+d twTcFAi/Anl5PTf8q/QWhUQ3tpLQ2PcijMSYZaquRotkoQUR0sLMyu7YnW3HpaKUJ3UtY3S8E93 KFTTCtLbhUOX8gMh5p0bWla3MsGqHRJF4w6wYpgKn/aqOql412omY223wPheNEHgnT+h+DWYQ0n r7ETn62k1S0XsiaFFkat3j73KT6hbY96s0VViCP+Fh X-Received: by 2002:a17:902:efc1:b0:2b4:5dff:30fd with SMTP id d9443c01a7336-2b5f9eb0501mr315369565ad.4.1777305290006; Mon, 27 Apr 2026 08:54:50 -0700 (PDT) Received: from localhost (vps-e1cc9378.vps.ovh.us. [2604:2dc0:202:300::1365]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa30047sm320483735ad.28.2026.04.27.08.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:54:49 -0700 (PDT) From: Eric Wu To: Thomas Bogendoerfer , Greg Kroah-Hartman Cc: linux-mips@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Wu Subject: [PATCH 6/7] staging: octeon: convert cvmx_pko_port_status_t from typedef to plain struct Date: Mon, 27 Apr 2026 23:54:26 +0800 Message-ID: <20260427155427.668540-7-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427155427.668540-1-kunjinkao.jp@gmail.com> References: <20260427155427.668540-1-kunjinkao.jp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Linux kernel coding style discourages the use of typedefs for structs. Convert cvmx_pko_port_status_t to a plain 'struct cvmx_pko_port_status' and update all users across the MIPS Octeon architecture code and the staging driver. No functional change. Signed-off-by: Eric Wu --- arch/mips/include/asm/octeon/cvmx-pko.h | 6 +++--- drivers/staging/octeon/ethernet.c | 2 +- drivers/staging/octeon/octeon-stubs.h | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/mips/include/asm/octeon/cvmx-pko.h b/arch/mips/include/as= m/octeon/cvmx-pko.h index a742c1d61d8f..26cb26a7ff2b 100644 --- a/arch/mips/include/asm/octeon/cvmx-pko.h +++ b/arch/mips/include/asm/octeon/cvmx-pko.h @@ -114,11 +114,11 @@ enum cvmx_pko_lock { CVMX_PKO_LOCK_CMD_QUEUE =3D 2, }; =20 -typedef struct { +struct cvmx_pko_port_status { uint32_t packets; uint64_t octets; uint64_t doorbell; -} cvmx_pko_port_status_t; +}; =20 /** * This structure defines the address to use on a packet enqueue @@ -574,7 +574,7 @@ static inline int cvmx_pko_get_num_queues(int port) * @status: Where to put the results. */ static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pko_port_status_t *status) + struct cvmx_pko_port_status *status) { union cvmx_pko_reg_read_idx pko_reg_read_idx; union cvmx_pko_mem_count0 pko_mem_count0; diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/eth= ernet.c index 5f9c29071fab..448a4ec42d0b 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -202,7 +202,7 @@ EXPORT_SYMBOL(cvm_oct_free_work); static struct net_device_stats *cvm_oct_common_get_stats(struct net_device= *dev) { cvmx_pip_port_status_t rx_status; - cvmx_pko_port_status_t tx_status; + struct cvmx_pko_port_status tx_status; struct octeon_ethernet *priv =3D netdev_priv(dev); =20 if (priv->port < CVMX_PIP_NUM_INPUT_PORTS) { diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 8496c60d647e..7bb72e152f08 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -411,11 +411,11 @@ typedef struct { u16 inb_errors; } cvmx_pip_port_status_t; =20 -typedef struct { +struct cvmx_pko_port_status { u32 packets; u64 octets; u64 doorbell; -} cvmx_pko_port_status_t; +}; =20 union cvmx_pip_frm_len_chkx { u64 u64; @@ -1264,7 +1264,7 @@ static inline void cvmx_pip_get_port_status(u64 port_= num, u64 clear, { } =20 static inline void cvmx_pko_get_port_status(u64 port_num, u64 clear, - cvmx_pko_port_status_t *status) + struct cvmx_pko_port_status *status) { } =20 static inline enum cvmx_helper_interface_mode cvmx_helper_interface_get_mo= de(int --=20 2.43.0 From nobody Wed Jun 17 06:05:12 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C28C359A8B for ; Mon, 27 Apr 2026 15:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305296; cv=none; b=GWZlVJyXHhL7r+WV90/zolb2y02L/T151ADNS7bJspNNF6cxgWoaeMHNctvX2PxUaI3Ng3BvSBmpvfgFqMVpbv5BY92dT19Tk4IYL5Dc2xEf8GBeREZwAyfxjRDB9ws0lN0cN6YjGzXIBP9LFw9p+J2h3Jq17S+upMHJrpyKkKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777305296; c=relaxed/simple; bh=23evcU1TdjFjzg2aQNROqzfbxAgSpKxe6AK/+hAaEV8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Um1DTmqt9252Xh8pr0gRYYgiqyFH74WVT8RDGkCZRtKX95IAxegy8mdvmFEA5qpr/rwr6PUNya1rAOPVs1Nsy0cj6uINqAKN8OKtcjrnhfATlDI8lkbiZG4F2rqkVehzsS2cYvWXCAyntbMP3ijIEzpt7bQmR+Le0Cqapc2tiwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X6IOcJGP; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X6IOcJGP" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35da2d35eccso7030598a91.0 for ; Mon, 27 Apr 2026 08:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777305294; x=1777910094; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ir1hTXu7IWWfjs4gdRRexBIGEymH3qRIcAM1ZommSVw=; b=X6IOcJGPD2bcJe/flgqGXtUVZCmpAaG5c+7EuQW0LV9sr+7stAJdZJ9iIa5OxsLsYE 0l3TIdnQ00O+h8FSIVkvc2sy3tSOgfVT9LPt8yZWEUnhPKbfGKcjTYMkNuAMAzpBYAxT PU04/juUlm2wkUZaBZPguNj/LxSRDYyqObcQwDil2Xj9JENmiKJPEhzvRyYamUvZA7yf A8q6iU90hI8Ri/DeTwMmoasxn7Bu0SWKONk8MY2sc7r4vh7iqAXzkLJoT51j8mJuDmWs BAUc58A00jweuB+Tr/QTBSMvQ3MdPsDIKW9R9a12L+bXDKgNy7Uv0ZeCaFcO5oa6yPpw nTew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777305294; x=1777910094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ir1hTXu7IWWfjs4gdRRexBIGEymH3qRIcAM1ZommSVw=; b=RlleBbS4t7QgRPJ6bs6hb2dkIaIV7L/2m3so3PM/fZduYLw6Cc8szJQfk4OQPosWDi AhPd3FaaM5qQ8HHbXHhHUbEbojqN/+N38oMoGlZEJMBHEt6KQFSJ1pfSJXaA20a9CGLA VvBL2esKp/3R4XCAPrLxEvPx3LhVSpSRF1TN+LqOe2CptfoqMFqVE3Udu4IzYdZsRQPW nnGjHFKMAoRsX25lGT7oUEGChWu9/qad7OtQ1ymFnUnoxliuHojGQaTKb6SATxL/Xrgw rB5Z3W4JEuLzWIDmJu4WqALB3Ogbwt6Nm550Elt2L39KfJoGMeeaMq7STiJkyseNu6mR wp0g== X-Forwarded-Encrypted: i=1; AFNElJ+9uMYyLn7pf2FQjth5aKnPpwGshD9d/zBR64qfbELK0GaRJMVQB1+aGXA0XvuC1IaTkeR3skYS726t7tk=@vger.kernel.org X-Gm-Message-State: AOJu0YyR92OOMJCVwPhWIsyj8BNEzFlFV96jGj94Cym2by/BWQvxxP4r jlu4HKIqKFyTxg506VeJ+WMErJuy++cmryK2xo2lFxQenzFh9TpEXT0M X-Gm-Gg: AeBDievwNAQrJXYB8kK2+v1YEH5avrVe2GFsDz2Rotta0ZhXFfrEH+7AxKUu52uRe4w qTmWo91nOoQKPmXW1D/GXq27h2wvt1iMuDprsWxt7TvPmbHG9v5zMZ8v+5cbe6BcT+Np/GfZaHu xCwNA+8dU2D9j0B7xB3HJtuh5MUETp6vRrqnmd2uCaoVjkeiw6rSjNyB3rbNEF33blAelRNq8i9 /ycfGWnZeUWdxTHdI4FSDBaf318RllJukpiVSGrWpi1HfXa9MPXQ9cML5RnrO2Xwe0IZF9g/bw5 h9vf/ij3IQYtsFHaQUqhstz04fW5p2mElSIxBO4iezCi2bkpZxxDG8eLbcHg/VjoSSBi3dnO00J NqoZU+N8T2qD4GacacSJamWJIZkF+yTJO80H1NixBELr3A3oHFFetcpvZKnYX5KNmFjkyEVaNZR +hQc/wJvuF/D2cROS75/OXZQVTri8qJyTvAVe2RALCKl7euMVvHUY= X-Received: by 2002:a17:90b:3c0c:b0:35b:e690:c5ad with SMTP id 98e67ed59e1d1-361404a1ef6mr45500096a91.25.1777305293271; Mon, 27 Apr 2026 08:54:53 -0700 (PDT) Received: from localhost (vps-e1cc9378.vps.ovh.us. [2604:2dc0:202:300::1365]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614195a8f0sm31413787a91.12.2026.04.27.08.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:54:52 -0700 (PDT) From: Eric Wu To: Thomas Bogendoerfer , Greg Kroah-Hartman Cc: linux-mips@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Wu Subject: [PATCH 7/7] staging: octeon: convert cvmx_pip_port_status_t from typedef to plain struct Date: Mon, 27 Apr 2026 23:54:27 +0800 Message-ID: <20260427155427.668540-8-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260427155427.668540-1-kunjinkao.jp@gmail.com> References: <20260427155427.668540-1-kunjinkao.jp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Linux kernel coding style discourages the use of typedefs for structs. Convert cvmx_pip_port_status_t to a plain 'struct cvmx_pip_port_status' and update all users across the MIPS Octeon architecture code and the staging driver. No functional change. Signed-off-by: Eric Wu --- arch/mips/include/asm/octeon/cvmx-pip.h | 6 +++--- drivers/staging/octeon/ethernet.c | 2 +- drivers/staging/octeon/octeon-stubs.h | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/mips/include/asm/octeon/cvmx-pip.h b/arch/mips/include/as= m/octeon/cvmx-pip.h index 01ca7267a2ba..911276ee90c2 100644 --- a/arch/mips/include/asm/octeon/cvmx-pip.h +++ b/arch/mips/include/asm/octeon/cvmx-pip.h @@ -180,7 +180,7 @@ typedef union { /** * Status statistics for a port */ -typedef struct { +struct cvmx_pip_port_status { /* Inbound octets marked to be dropped by the IPD */ uint32_t dropped_octets; /* Inbound packets marked to be dropped by the IPD */ @@ -236,7 +236,7 @@ typedef struct { uint64_t inb_octets; /* Number of packets with GMX/SPX/PCI errors received by PIP */ uint16_t inb_errors; -} cvmx_pip_port_status_t; +}; =20 /** * Definition of the PIP custom header that can be prepended @@ -365,7 +365,7 @@ static inline void cvmx_pip_config_diffserv_qos(uint64_= t diffserv, uint64_t qos) * @status: Where to put the results. */ static inline void cvmx_pip_get_port_status(uint64_t port_num, uint64_t cl= ear, - cvmx_pip_port_status_t *status) + struct cvmx_pip_port_status *status) { union cvmx_pip_stat_ctl pip_stat_ctl; union cvmx_pip_stat0_prtx stat0; diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/eth= ernet.c index 448a4ec42d0b..d85a9991faf6 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -201,7 +201,7 @@ EXPORT_SYMBOL(cvm_oct_free_work); */ static struct net_device_stats *cvm_oct_common_get_stats(struct net_device= *dev) { - cvmx_pip_port_status_t rx_status; + struct cvmx_pip_port_status rx_status; struct cvmx_pko_port_status tx_status; struct octeon_ethernet *priv =3D netdev_priv(dev); =20 diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 7bb72e152f08..9c1968b7e2d1 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -386,7 +386,7 @@ union cvmx_ipd_sub_port_qos_cnt { } s; }; =20 -typedef struct { +struct cvmx_pip_port_status { u32 dropped_octets; u32 dropped_packets; u32 pci_raw_packets; @@ -409,7 +409,7 @@ typedef struct { u32 inb_packets; u64 inb_octets; u16 inb_errors; -} cvmx_pip_port_status_t; +}; =20 struct cvmx_pko_port_status { u32 packets; @@ -1260,7 +1260,7 @@ static inline int octeon_is_simulation(void) } =20 static inline void cvmx_pip_get_port_status(u64 port_num, u64 clear, - cvmx_pip_port_status_t *status) + struct cvmx_pip_port_status *status) { } =20 static inline void cvmx_pko_get_port_status(u64 port_num, u64 clear, --=20 2.43.0