From nobody Wed Jun 17 06:18:59 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB4B2351C0C for ; Mon, 27 Apr 2026 15:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777304225; cv=none; b=JYcX9gIw/u3761IlVvPKwVHfqjk+ys4bJT113Yl0MZlmF97mndL2X+OczVjlirBLnFvUXbf9L3zJcKUnv7/z7ucf5pfiqBoCZtUHwu9nHYLgBP5U3w7j4zHWUR/CeYUMWLI5w/rB51md9CQK0vv7CUUS7F9gjssja1aPv7og7gA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777304225; c=relaxed/simple; bh=k2eHeOh1ypEyik00unMmMsD3cRYTWKvd5TA7e2KeNHM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=m2JDUIiNeLTyygVrBCyWdq4vUlgxXqqqW1f5VNbBlAu19JnRuUmlYg/ZsljU2kb19N/0/aSBAyYWrLrIoEMzhqbWADGRXzgFQqfSpfcL6j1YXW3oDOQnl2EfEh5WojLDdtP+MZONNydjV/L7UOx/W6V3cnSn8O3JIHAK7niKaX8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lV5nh9+a; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lV5nh9+a" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35da2d35eccso7012790a91.0 for ; Mon, 27 Apr 2026 08:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777304223; x=1777909023; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0hpvNH1EUa3cOnUyhzEEF6VXuaHHXz+8JvdcA+bX2rM=; b=lV5nh9+aI7CTiI2BJitPX84JGqexpETdo34LW164BUweNX9rd00KscHIfEPpIEnwwn lUuokwwr0ONpxQP5V+0AwLn+DO3co9hmmyLtfTko06c4RGrOqfN7rskZOoQMoSBQ7Gis EWcWrK4w5loTbuI/yFT0uhrzuFw2dvs6WiNdTwwUiopbMRsfwgszV6V8Zh1WMRRJK2FJ +0SO5T7vpd2CD3tGSXZeAe0umhbELe9BnN9XRFZPWSxsf4jb5sZxZvfYPs5x/4cS6Syv xS6My8cYM1e9B6GFpEa+tvIQIWzth2TXX9D3A2PsEPFREp7J1igWEcigN4mvgrx+TOLR R6gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777304223; x=1777909023; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0hpvNH1EUa3cOnUyhzEEF6VXuaHHXz+8JvdcA+bX2rM=; b=pCQn7BnczXbuZXf0qR0kQVQJR/3xLShJqK9gGXhgOXcY9dCRz4DbjDOD69ODw4ZMBL SwWEh3SPBHT/qZDkZIqKro1GjUGmlJzo/YuvTyq1m9II/6H9TqacwMtdWDJtwpTY615L akFkC1dhSnEI2aX1MV7PGfRoPQvlFcgLNBH1QuCYJMY5FeztqlBD1iuELbKGC4xAgzak dTz7QlLsQ4ZmirUqGYa0y8KOSuy6d/+qeO4/uGd3EKAwkjih4kxjrbTIgKaoFTjfJo/s Xc1edLZWuOurlAiuLYfVfIumTm2+gCiBK6L2OnroDuwYSIC9tI8BSra6OfAkSdimPSFs I+Rg== X-Forwarded-Encrypted: i=1; AFNElJ+w2Hsb3LASpOhRd7Q1Fzk+B8tl7sJZ1N213MfE3ZJoiFP/fO56MjRR6+hdgi0FGS/9TTfu4u4zuHy3uV8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2xnfGqHKplVkjJWEs2WwmCsyNFXM/CZv4tn08N3Bic0eaSD4K 3KsOE/u/IijTE1KDMn/Id5RN1vIASM85lalK4hpIXobtk6jgKrnZkMXM X-Gm-Gg: AeBDietelUr/TebMQ7kbACaG32ALtm4ot8gKIRA4tU5eKrDQCNHkLeJLk6YdkXfhqnZ lMjbeIm+m+ew5BkFgXeSeqZy9ecgfrQPF7LLs1oxk3C7bqcCysWMiUwvL1FEfi+yYkHkiMJAu/v lybZ744B4elyNwq3qEq0G37EYl71VGlGCGrzg4Jfe5rYmJS6I0OA3nw2NEIQsi7G0+J5xTV3hg8 aH8eR5k64KdR9/NQw1zMKIF4ER3rKb5O+7YPn3M2itGVn/cx736PqBrHXd7+ydKQEgXg4dxy4MW u74if+/qe2rb1md/PxvePCwnCBI6IjYI3lGdZ3dNEVKRWmvBSRe0Hcx/pFIAOdrCOsbgcElqehq Rgz8oYriE5sFs9FatrMxS9aNljs2tkd2Y09GaDxpVtdAQOBC9+ikITcMb9cW/fTI1o5klzHybWv 3cH3IqD7Z6yKBKhEYwKZM5as+EwVFJHOk5QQI= X-Received: by 2002:a17:90a:f09:b0:361:4521:d311 with SMTP id 98e67ed59e1d1-362e8d70725mr10652817a91.18.1777304223057; Mon, 27 Apr 2026 08:37:03 -0700 (PDT) Received: from lgs.. ([2408:8418:1110:2369:e656:cc2d:236e:9079]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36146ae9cd8sm30014315a91.11.2026.04.27.08.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:37:02 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , Guangshuo Li , Kees Cook , Chen Ni , Alan Stern , Felipe Balbi , Peter Chen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH v2] usb: gadget: net2280: Fix double free in probe error path Date: Mon, 27 Apr 2026 23:36:51 +0800 Message-ID: <20260427153651.337846-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" usb_initialize_gadget() installs gadget_release() as the release callback for the embedded gadget device. The struct net2280 instance is therefore released through gadget_release() when the gadget device's last reference is dropped. The probe error path calls net2280_remove(), which tears down the partially initialized device and drops the gadget reference with usb_put_gadget(). Calling kfree(dev) afterwards can free the same object again. Drop the explicit kfree() and let the gadget device release callback handle the final free. This issue was found by a static analysis tool I am developing. Fixes: f770fbec4165 ("USB: UDC: net2280: Fix memory leaks") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Alan Stern --- v2: - Remove the unnecessary braces around the single-statement if block. - Correct the Fixes tag to f770fbec4165. drivers/usb/gadget/udc/net2280.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2= 280.c index d02765bd49ce..7c5f30cfd24d 100644 --- a/drivers/usb/gadget/udc/net2280.c +++ b/drivers/usb/gadget/udc/net2280.c @@ -3790,10 +3790,8 @@ static int net2280_probe(struct pci_dev *pdev, const= struct pci_device_id *id) return 0; =20 done: - if (dev) { + if (dev) net2280_remove(pdev); - kfree(dev); - } return retval; } =20 --=20 2.43.0