From nobody Wed Jun 17 06:26:54 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FC413128BE for ; Mon, 27 Apr 2026 13:31:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777296685; cv=none; b=WBsZ7zO+xp/eO1cv1QG8Pad2xbPTu0S2pW1sq7Gud15TSSDOvs21vGCiSOl6WOHPXPHhZTMwLB2FpHWR+aHvKwy0gG6oMfODMzNVNG2gWP4lFM03YWbEHEEtwAOeUiGjDi4IFNiJqr0v7+Gs3aa1MYN8sb+TPjN9Lrn2oSTismQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777296685; c=relaxed/simple; bh=iC4+ZkY03M5gg8goq8d1wfEoqcLzW2wBz06MOjrRHdY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GxRo51mIC7L0tUSFh69KC0FUrQ0cj+FQLk9yLo0gSkTMCKpch15KsrUmZ1ndOXSoWgbDyPWsKvFjEfuLsI0kYFGzs3xgYg80f+jl5l+mR7b2bkGDo+eIRm521yAcuu0WTXsRhqi+6MbYdTrPBEI/VOrhpTPJC2CdLPqGBH5zaH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kctUcvnO; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kctUcvnO" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35fb16e56efso6697604a91.2 for ; Mon, 27 Apr 2026 06:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777296683; x=1777901483; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ItUvJaUZi7auBuoRsMIotXuMOJtpxcTrtyLZSnWiKzo=; b=kctUcvnOCPZp7aI++oF2ayXJIbptkk0TShr/fWoxPBdXHKZn79HVtY8/dG3h44IiMH Yjp29r0sI9CgguawegfLkwUTy1OxPz1kUmW3p0ys22bauTWU3vxrNAGWmW/WpnykR39n Ld0BgG35N7rkiwpSAamcQre+zPhD2CBrNooTGJ0TdSw7iRbynpDM8Sy6biBI6a7pnNeC 55aeo+rRbCTQfns/Ht1Ir4ktxHYg9HXirJYZQ/iryn0tLIApLmsO0s4npShetSNIs6+n 5Rgd1v5RuAA+GliCwf9TPu9pl2vlXq7NsUvZU2a+ywJnBJd8R/QhKfYqf3WLeaAX4Lpj 8rSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777296683; x=1777901483; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ItUvJaUZi7auBuoRsMIotXuMOJtpxcTrtyLZSnWiKzo=; b=ezUSZkXqB1Xswc2WBWV9rtZwmMtu05S/UKtP27PLf6hpBKj9c9IxMI9L8RpiZXFPos aTWv161G6mLRA1/Cwch0QC3Qbu91JEQebNDk8azHLsz5cSHUJwDhIiVmyczCNjvQiyRp CXiyYWpa1AysSvL35pE5hrMzdIg8RDUpzyeJ6nza/G6bqkeo932byWeGikrLJie/33HT CWGEv/oecRs1ewI+SyuZ3To6WKzPAS991FAVQJB4TZf5FdecViwXvkGzMruSstcooEfr 7l+k83CWR3O0QVWyQxxvpcWaSJf+2+jnSOkRtDyLEBthTKIPPGp/rZWRd4E40JBej2Ow K0iw== X-Forwarded-Encrypted: i=1; AFNElJ/rRx+sVbwFCHuLltGTZdynP1D+mdwi39ieaFfXsdxLdaeOyNyd/piyqUhqK+uRtgRxRu8IIEaJS2jiQOo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt9BbPT1zjCw27UmafNmo3Ls5WyVtaq4l/jEnELf62tD/gNZZ4 0K9vGEynCNNQMWFZFZ+N6yE48lnFYEQZaHyd7cVNQVYRwC5tm9mkyOFi X-Gm-Gg: AeBDieuneIptG+X0vEgr59bwXPDnnkMj+/jvaYwjWLS/lEc0a6iJbj1SCEG9D9JAE81 Iybaujg9jIuIOKvr0eA2nB6L3DluMTb++xHSaLWpq3mEbB5/zGbICVgGN2iXy4LlLJGCcth6dL0 46hiD/ts6wZ6/MitCpEH/o+PmJIBPAT4vXS6dLQWgeTMXuNX9k7KhQibYKeoHUzod6ysU08luq4 UEL+hzpAKbm1Wsbw+IXl/25G1QS2xp3t3c1ckyG9dPHxlz/treh0zbAc3rC99KuzZhpfzCDHCKM jX8G2F0SB+gppcfHtVkhBuMbB8B0l9czuzIAdyHCMbLu07JDAyScNkb7HoZ1WCve0WcxAdi9U7w CNsz43nlUrLR6QGx8kdVYpxnCpWEK1cgzlh3fI7LgTXu7ZmAIFKc2pEu4pbwwi2UQUvd2hTRcKx CRt6S2fI9srFOHYMJg4VKZUvg2QxXdVJ3rLBg= X-Received: by 2002:a17:90b:3f4d:b0:35d:8f3d:c554 with SMTP id 98e67ed59e1d1-36140468b12mr45769609a91.13.1777296683517; Mon, 27 Apr 2026 06:31:23 -0700 (PDT) Received: from lgs.. ([2408:8418:1110:2369:396b:2f7b:1535:e7cf]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3613fba1bc9sm11812298a91.10.2026.04.27.06.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 06:31:23 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , Kees Cook , Guangshuo Li , Chen Ni , Evgeny Novikov , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] usb: gadget: net2280: Fix double free in probe error path Date: Mon, 27 Apr 2026 21:31:07 +0800 Message-ID: <20260427133107.334429-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" usb_initialize_gadget() installs gadget_release() as the release callback for the embedded gadget device. The struct net2280 instance is therefore released through gadget_release() when the gadget device's last reference is dropped. The probe error path calls net2280_remove(), which tears down the partially initialized device and drops the gadget reference with usb_put_gadget(). Calling kfree(dev) afterwards can free the same object again. Drop the explicit kfree() and let the gadget device release callback handle the final free. This issue was found by a static analysis tool I am developing. Fixes: 2468c877da42 ("usb: gadget: net2280: fix memory leak on probe error = handling paths") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/usb/gadget/udc/net2280.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2= 280.c index d02765bd49ce..90d678e6714f 100644 --- a/drivers/usb/gadget/udc/net2280.c +++ b/drivers/usb/gadget/udc/net2280.c @@ -3792,7 +3792,6 @@ static int net2280_probe(struct pci_dev *pdev, const = struct pci_device_id *id) done: if (dev) { net2280_remove(pdev); - kfree(dev); } return retval; } --=20 2.43.0