From nobody Sat Jun 13 00:06:42 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011071.outbound.protection.outlook.com [40.93.194.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3173B5842; Mon, 27 Apr 2026 11:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287802; cv=fail; b=LuJek/BZ6OvKUf6R1XxjMC0jig27Xw3J273+w1QFjVC7OKlnI9GzA2ZOxFjMFnqeB/Vp1Kf3NXxQYTyyAewJU4unYqZsE2SGy36wHl5gGpUmFxZzW7WBTwGhxKyOztHXzLzqlczIXY/tX3JjnFMrWCu8cAzYgSozlfOH8USM9Rc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287802; c=relaxed/simple; bh=jG4K3gWAL+oCtETuW+eR6WjLnBjgrjVn5MCcyIZ2jJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=GKreTEsdg8d4S0y+0Vno6cNm993603uBqllQpdjtnppfkVCg3mFwEH8fB1crvkTNXesI5hous0VnoeA4xtX6LTe+WC3wlIkXxKDGEYath1D8skczkPxx6z0rhJfF1jtDg0PxfSP8htLRx+iDYCL13upJQmMlo07XOYgAdRhs3xE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=apJHOGx9; arc=fail smtp.client-ip=40.93.194.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="apJHOGx9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TQLqli2ZwXyedEm6TGXwBoMwj7PZjKlybpAi4JZ/gyJFTuq9z9FvBVexP82pPwSxM54kePmGenWZ0qrT/CVMh+fvb3dKMVMlgJJHwr/ypC9BqYFGNVhZ/JzVFDOQnURYx11iuomQynankbeOWdeCYj6VsYKvA2EEMOtZRF0rqPFhwIywXRUw90itRdtJU6+jxYbz0BEFkk8W8r0U6itZJAPkzEjIOXghIV4P+btf225lxnDvQ2MX4ijt2q9uAc7/0/yx1G4d8/OCuvvmBg24SV+5hsuuRn3HT15F8xFV8PzTLsGXzJeSQMK1ZJTvIth+wx/cPhszvqDAejzoobCf8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W+AoaXP3WdW5VKzHFnzRo7fdCCcgWzp6Tzt4YTymfF0=; b=qUFYg2VoPY5zYsqvoS9qxDqf90Bq3WpCclh5QlbHm3bEtVNLqA3e2RnLBS7XWDkFB+Y6Nmekhx2yV70hWJzpWI6Qj4DEn6wPkcQI4bu/jnhNDe2obcpUHNPSB83CLO1MCeGZy4DA6Id6ewtdYBCJp3yTEULp0GfRQU9poLMkXsC40hhezsFm4RuywISsvsi19rAOFwELZQtXgCk9pOSyHhOQA4HXOtsqmBFtUEdS9GKUABwBKu+aZly/EjihfJI5q8i1fZddA7Sy30J927UcdUr04eiJylC4fdgG9iGdIA6qGG3tDFVMEYvoi5YFYQreneBl8POpAh/aq4r/mcuR7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W+AoaXP3WdW5VKzHFnzRo7fdCCcgWzp6Tzt4YTymfF0=; b=apJHOGx9FB13azjIcE3VxHbyvpXDERbk1qMY/eCdckbgSCsGQf7uTt06HSvAQ8P4rVkh3oIbOcSY1xPbgWUFj9aK8x3lN9ABcYu/kiewRLp5zxr1bxBRGW71jGyNrhg6LRlsry4xhax5iycl1pcqCjSRc+i8zcZdMtkinOoc3nkzSfL94umnH6J1/V9gEXw7n2cbnSzaVlRX9tP88asXYVHdVTgM4n+kWFK4C59GCjxgIcx/tYYg7ZJJfLQZB1EQnEgkacmB5PPO+sSFxrfVipHZg0TEAoaKgMFfS5g1WWv76Dm29D7vTBqt+6b8D35Xm8MTEzJo2iYy0Us3hixU8w== Received: from DM6PR06CA0086.namprd06.prod.outlook.com (2603:10b6:5:336::19) by CH1PPFDA34A4201.namprd12.prod.outlook.com (2603:10b6:61f:fc00::625) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.21; Mon, 27 Apr 2026 11:03:15 +0000 Received: from CY4PEPF0000E9D1.namprd03.prod.outlook.com (2603:10b6:5:336:cafe::31) by DM6PR06CA0086.outlook.office365.com (2603:10b6:5:336::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Mon, 27 Apr 2026 11:03:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D1.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Mon, 27 Apr 2026 11:03:14 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:02:54 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:02:54 -0700 Received: from [10.135.59.1] (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 27 Apr 2026 04:02:49 -0700 From: Edward Srouji Date: Mon, 27 Apr 2026 14:02:32 +0300 Subject: [PATCH rdma-next v3 1/5] RDMA/mlx5: Fix UAF in SRQ destroy due to race with create Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260427-security-bug-fixes-v3-1-4621fa52de0e@nvidia.com> References: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> In-Reply-To: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> To: Leon Romanovsky , Jason Gunthorpe , "Chiara Meiohas" , Dennis Dalessandro , Gal Pressman , Mark Bloch , Steve Wise , Mark Zhang , "Neta Ostrovsky" , Patrisious Haddad , "Doug Ledford" , Matan Barak , , Maor Gottlieb CC: , , "Edward Srouji" , Michael Guralnik X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777287764; l=3918; i=edwards@nvidia.com; s=20251029; h=from:subject:message-id; bh=jG4K3gWAL+oCtETuW+eR6WjLnBjgrjVn5MCcyIZ2jJY=; b=Ls9Yk6SOm7N+Ohrof8i29jaqrahc3xCfTNVQfi1Uo69b6JVJN2tUHeEhNfsKW3xwODamMj6Ic NmDiBHTZBFrAVO80kVSrcdyH0R/3FZu3DmtOE9paFWUGT89kkd3ROV5 X-Developer-Key: i=edwards@nvidia.com; a=ed25519; pk=VME+d2WbMZT5AY+AolKh2XIdrnXWUwwzz/XLQ3jXgDM= X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D1:EE_|CH1PPFDA34A4201:EE_ X-MS-Office365-Filtering-Correlation-Id: 046b7eea-96df-4482-ddab-08dea44c948d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700016|22082099003|921020|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: kekSu9Ap+sWFlUwOn0iZF0UiolZrFQ44axGQ1ihyOjGhWWmejvms0P1JnPySJfQi24L9O5syq5TI4lMQ/Vpu84TYtLzER14pvAsyox3U3fMFvkEyUzRkNre95ABOd57bwJ6hzbey5wmH+PVrAB/bohT7a37gsnIhYhzCsuLzb9jOy62kj8nVnW10cuYCuJCjUNeXVZbX6+rOzyI/tI4MVx695Hn/4r1y5dTUzxzOimzyO/h8rk4Pe0XuyL9JJbfUWzQkNV4vwgC0bnlVq1FrvewTqCWV8YsIrEoqrfYxWh6bI4wcQFPw9D1Db1VPVrpODt6Pg45Idj2T3azfrbggDUWt7S2XApYBqh+8RHsUfAQvcDcaiOr4uztGhMzBi7Kb5geQumKazvY4a2MQL5SlVDPTBFvwXgJPolXk/ZTG+5cqHqndWxBfZp8AarOu4Ayon0m0Ir9bztmpyETpA/SVdHZRze+DuLS7IJL+8wpTDXTlFeqdPZny5hswHCBpJd2C9x67dhAPGywUNhuxDyFegTRx8GpCQd9KNf65AzTv6Fa8OuVfKix/gYXjeLIWbKNuI/oTxiXZ33FcBO9xYQwun8C3kJvQOKN+6/jRHh6D4IAkLS6rIJ//FQhqPYiY1aloi2Hm9fHGzXMurtcMcwp9vnl6j/4I0OKcWyJBhlFswxrfY7+KA+BrNUKYs78sKyer9XBed8rcSpa/a8ZxDolN9iq7yXx2EN539xkYsa2UDJWYut+fNmpWmoJIdgs2ljHFWPJ5iSrx36XNjofB+XQ7SRSVCOQoczO8OzxrQll97SDtr+kFk0JaRDYNk9vFzrgo X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700016)(22082099003)(921020)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rr35dxfo+rxJSVmN21aw0RJrJ6LOGBo5I4ChyYxXc+UtC7oyeWcHx32hrkIMyIiLECnZy7vqaz6/izIQEgs6QvZBEfYjIi+PemiI8GrZk6yx0KyjG9386GjB4t0Gz0s7y3WLEQ2d+KTL4X6eqjSYfAhEsMFeJABxWJrGc628XNu7LS8CfxlPtPaVBMd5GU0O2vMTZ2RqnqxW5aB0uhf0mbIwjGkkpwBPSVw4j8nYK0udf8tWXW2aVnKED4tPy/R6eGU+IBqTziFLYSVgcPPcUwAeah8KELME5FzE7vfWxTFbYexJEoYRp6qcYyrATRnqizLbYUWXWEuX8hLTJ5NZ6WattqDULjQK2BxSiUjyVujWbhpv0WeQH8KFixn20EC6e3Fd7mxXf1WaIKwNRpfST8xk5xLI6HN6iMbWlV2dVN+Gx7lqDuGVrbo1gRAWtOBe X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 11:03:14.8865 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 046b7eea-96df-4482-ddab-08dea44c948d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PPFDA34A4201 A race condition exists between mlx5_cmd_destroy_srq() and mlx5_cmd_create_srq() that can lead to a use-after-free (UAF) [1]. After destroy_srq_split() releases the SRQ to firmware, the SRQN can be immediately reallocated for a new SRQ being created concurrently. If the create path stores the new SRQ in the xarray before the destroy path erases it, the destroy will incorrectly delete the new SRQ's entry. Later accesses then hit freed memory. Fix by replacing the unconditional xa_erase_irq() with xa_cmpxchg_irq() that only erases the entry if it hasn't already been replaced (still contains XA_ZERO_ENTRY), preserving any newly created SRQ. [1] RIP: 0010:mlx5_cmd_destroy_srq+0xd8/0x110 [mlx5_ib] Code: 89 e1 ba 06 04 00 00 4c 89 f6 48 89 ef e8 80 19 70 e1 c6 83 a0 0f 00 = 00 00 fb 5b 44 89 e8 5d 41 5c 41 5d 41 5e c3 cc cc cc cc <0f> 0b 48 89 c2 8= 3 e2 03 48 83 fa 02 75 08 48 3d 05 c0 ff ff 77 08 RSP: 0018:ff110001037b7d08 EFLAGS: 00010286 RAX: 0000000000000000 RBX: ff1100010bb9c000 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: ff110001037b7c90 RBP: ff1100010bb9cfa0 R08: 0000000000000000 R09: 0000000000000000 R10: ff110001037b7da0 R11: ff11000104f29580 R12: ff1100010e2ac090 R13: 000000000000000d R14: 0000000000000001 R15: ff11000105336300 FS: 00007fa24787c740(0000) GS:ff1100046eb8d000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fa247984e90 CR3: 0000000109d59005 CR4: 0000000000373eb0 Call Trace: mlx5_ib_destroy_srq+0x25/0xa0 [mlx5_ib] ib_destroy_srq_user+0x21/0x90 [ib_core] uverbs_free_srq+0x1b/0x50 [ib_uverbs] destroy_hw_idr_uobject+0x1e/0x50 [ib_uverbs] uverbs_destroy_uobject+0x35/0x180 [ib_uverbs] __uverbs_cleanup_ufile+0xdd/0x140 [ib_uverbs] uverbs_destroy_ufile_hw+0x38/0xf0 [ib_uverbs] ib_uverbs_close+0x17/0xa0 [ib_uverbs] __fput+0xe0/0x2a0 __x64_sys_close+0x3a/0x80 do_syscall_64+0x55/0xac0 entry_SYSCALL_64_after_hwframe+0x76/0x7e RIP: 0033:0x7fa247984ea4 Code: 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 = 0f 1e fa 80 3d a5 51 0e 00 00 74 13 b8 03 00 00 00 0f 05 <48> 3d 00 f0 ff f= f 77 3c c3 0f 1f 00 55 48 89 e5 48 83 ec 10 89 7d RSP: 002b:00007ffecfa79498 EFLAGS: 00000202 ORIG_RAX: 0000000000000003 RAX: ffffffffffffffda RBX: 0000200000000080 RCX: 00007fa247984ea4 RDX: 0000000000000040 RSI: 0000200000000200 RDI: 0000000000000003 RBP: 00007ffecfa794e0 R08: 00007ffecfa794e0 R09: 00007ffecfa794e0 R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000001 R13: 0000000000000000 R14: 0000200000000000 R15: 0000200000000009 ---[ end trace 0000000000000000 ]--- Fixes: fd89099d635e ("RDMA/mlx5: Issue FW command to destroy SRQ on reentry= ") Signed-off-by: Edward Srouji Reviewed-by: Michael Guralnik --- drivers/infiniband/hw/mlx5/srq_cmd.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/srq_cmd.c b/drivers/infiniband/hw/m= lx5/srq_cmd.c index 8b338539659933aef94a3e2c056e9400c3fb9bb0..c1a088120915c5741f37ed44fd2= e8139bcb6802e 100644 --- a/drivers/infiniband/hw/mlx5/srq_cmd.c +++ b/drivers/infiniband/hw/mlx5/srq_cmd.c @@ -683,7 +683,14 @@ int mlx5_cmd_destroy_srq(struct mlx5_ib_dev *dev, stru= ct mlx5_core_srq *srq) xa_cmpxchg_irq(&table->array, srq->srqn, XA_ZERO_ENTRY, srq, 0); return err; } - xa_erase_irq(&table->array, srq->srqn); + + /* + * A race can occur where a concurrent create gets the same srqn + * (after hardware released it) and overwrites XA_ZERO_ENTRY with + * its new SRQ before we reach here. In that case, we must not erase + * the entry as it now belongs to the new SRQ. + */ + xa_cmpxchg_irq(&table->array, srq->srqn, XA_ZERO_ENTRY, NULL, 0); =20 mlx5_core_res_put(&srq->common); wait_for_completion(&srq->common.free); --=20 2.49.0 From nobody Sat Jun 13 00:06:42 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010070.outbound.protection.outlook.com [52.101.201.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB2E3AC0FC; Mon, 27 Apr 2026 11:03:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287799; cv=fail; b=HLrsdJAjjKh1skm/xV7fFI3BJRQGV2LuOaaW7bPLcLRNK2CQLl8KOwIzNEDQ7NvmaNL0G3QjRbVRoe0mY2z1SlI1MnZPsBRoOZwNkMQM0UDmlcInBm7YYct5TvDQac5nEsODrC199NKglPXWJosWqEw0rxKXnO+HzJKOxZ54Cs4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287799; c=relaxed/simple; bh=fqOQHBTsMGDyYBanPsNjePtGmdZDn4173XYf0fqm5Jc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=fvp6YbgoabyWcSErINKwzHuVYZsLkfQ4EU+sKQiOJ0wPNdLu4Y2LaFW2PeTm0ssb8sSE8F+nKvYU+a9i4XW9wkn67Sc/2CuasBZINHQhjF94M1JHON4HP77VE+pFDx+UEOufy1qgMtxse+nj62shV+/T9eSIKqVFZWS8eoSTKaQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=lD5exI3e; arc=fail smtp.client-ip=52.101.201.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="lD5exI3e" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BS8/zdgbopz2SHIM1ES1QkLMf611xWb/S/NHyEDJLfKh9NjOiUYbEiTayzr5U2gNdPjTkEblP/5TDEGIvgOh0ELzy5Zv5N0AjJ+x9l3U65mOj9VgbHEqp1VdAqGx4I9zL2PqD32u9DCl7CoYwManXHnM7OF5C3CRxFKy557HMqwR2U0zBw8qBLdb201efzczRPMRxbB3EQKqS252UqFp+ULE/4hsvmBVimbT831uDMwP52bBDneSR+aFeHrB+tCpUjxnCiBP9Ci5D0/01BbSGMwoBeCgvdrBd5zK+PffobCOhhux4JNbrAiO/b8V8ujaYlJPnU/W6Jew5rPfaKicgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BdrlkJezMnENZVh5CigvNI2d54O86poiPpOc5lFYrsU=; b=qzwIR43mwqkY1Wfmv2TTi88jI0uoPig8eJ3N8f/5LLyhOAEu7ADDrh1tUNxgP+xFy1dtmQVL3SAVCtrs2z9Tz66JM8hWrc/gz1wX3vpVvyQgSbCZWKhg+goumASu0/XbSl2fw4p591zajv/xJyEMENKaZyQg8OowNsj9sDbfELUJfVtlih0AOVxDeOmvXZIiI/hUooLcx86Bx03LR2N8Ou4ICXg37gdLrI9P1Q/KmciKZyMkUWR4TalD0hspk/1jFBG+F2AAOkJrFkJRxDXyn1E0s/3+BglifIV127DLL1h58+s1xLZaFxsn8ClcrMkUQamaIgiKL7nsuaz5QR2WYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BdrlkJezMnENZVh5CigvNI2d54O86poiPpOc5lFYrsU=; b=lD5exI3eUZR5MuY7j4EFNwyDbZnwn/fRMSb+6MXq/8Y771ydsnaHJdg4Jf2GGE1fy3ta0xWj97/c53xoOMFZEfZy23+GyO0j9P0YwP9zHVgQ3o+RzKcW8xNrY5IUR59kaRnWLvm4o+ho/yXxL8mqNp3J9vJbIbGG5WNzfZDC6KIzb47pI2MjMt8zCMUmIQ8BaW0xwzgTuR0vd3Gf9gEZo0506Z9VfusD0CIuuKZwmH/17XKjbiXMvDwk/2Zyl7EeKPejQtyqj68ylxr4FgpTo/0KtY0x2MBoRorMwg9Lmkl6ZmtpnLONNp1FM5t69J0DLBszLk9nxB61lIwadTYC+A== Received: from SJ0PR03CA0354.namprd03.prod.outlook.com (2603:10b6:a03:39c::29) by PH7PR12MB8796.namprd12.prod.outlook.com (2603:10b6:510:272::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 11:03:12 +0000 Received: from SJ5PEPF000001C8.namprd05.prod.outlook.com (2603:10b6:a03:39c:cafe::83) by SJ0PR03CA0354.outlook.office365.com (2603:10b6:a03:39c::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Mon, 27 Apr 2026 11:03:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001C8.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Mon, 27 Apr 2026 11:03:12 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:02:59 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:02:59 -0700 Received: from [10.135.59.1] (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 27 Apr 2026 04:02:55 -0700 From: Edward Srouji Date: Mon, 27 Apr 2026 14:02:33 +0300 Subject: [PATCH rdma-next v3 2/5] RDMA/mlx5: Fix UAF in DCT destroy due to race with create Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260427-security-bug-fixes-v3-2-4621fa52de0e@nvidia.com> References: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> In-Reply-To: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> To: Leon Romanovsky , Jason Gunthorpe , "Chiara Meiohas" , Dennis Dalessandro , Gal Pressman , Mark Bloch , Steve Wise , Mark Zhang , "Neta Ostrovsky" , Patrisious Haddad , "Doug Ledford" , Matan Barak , , Maor Gottlieb CC: , , "Edward Srouji" , Michael Guralnik X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777287764; l=1831; i=edwards@nvidia.com; s=20251029; h=from:subject:message-id; bh=fqOQHBTsMGDyYBanPsNjePtGmdZDn4173XYf0fqm5Jc=; b=EA3QoFw6EKJzAY5HJbr6zHiHkUHEr0UiLZh8BA6ICC+yMdKnNtqM80DfHakhORc4G/98Y6hL8 GNeVh1o5zZ/CwayL8A6NkbvqcZ+pAvBQuGjJj+PtBOfrTluUmcQsd5Z X-Developer-Key: i=edwards@nvidia.com; a=ed25519; pk=VME+d2WbMZT5AY+AolKh2XIdrnXWUwwzz/XLQ3jXgDM= X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C8:EE_|PH7PR12MB8796:EE_ X-MS-Office365-Filtering-Correlation-Id: 18092cca-993e-4054-c01b-08dea44c931d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|36860700016|921020|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: J4O0W3+h1SlubMN+V5TkhSVmC7qovRP8+NjV2imEFzusg3gzzmLuO+4dXrsGVfFAU34qJkbR7S5LmPyfVw0vm7uWju2ab5F+KqE4o3D61U4PymERpPQ+ARvEDTWXmyCHgYXZ/xEbwW2Ras7PqjEbUzIX16F+aNmW4nTukDtAZd/uUkB0q9FUUnNEZdMuTM8T9hl4TA4gs7P0hoVXulopY5KZ+8jtqccUG9T/24+X0k89FZFo+Ey1A6EZOKFq47PNp3lkaQdaEuYbFgC+3nmN9hCPwVbmE1HaMerBSUIbyLd6nWKifjgz5ieE8f8bc2jiicGjQvL0lkajCBi78gKmEsqq17bzRD+DmT+u2PRGzRbF1acQmSCgYxasgbP2j7505rbfw0fI2B81kVY7n386pWGRrdeCvU8OHcKctm7ha4hVyUcSsJqj3wdhTz3m4MffGCLXZGmiYm0U5N80wFxPT80s4Xt86B/v7wdLVdpDnZSEbw/nLMz5vFWe5PfnjWjjM3K7ufvLB6RNSu2ivRFKv807GeiCGKK2/f0DgE1YmS9OHM21wPOeTm7mkvOBDFzoVKVrJCZBAzIc69lZiY9VmZTSp9DiyfzCrAsmrso2vufdoeLLrISmIefMpLxoKemgfx4jGvtQXbA2qlkrrCwQZJvtBJwS3gDVLAhVyYiKlLcjWrMKEr6dJ4SSW0cYgJid1XV0Q4JnKrFv3x7IyzzocNdUy+g9EZwONW1pd1iXQCd8vHDq7Y0qSF6UrICgdZyQ2414I0ZZAxDbSVXOHQ2vo2XE4YDtdOr+ASWmz94P4yH2n0k1PV+4qT31+HiceFXr X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(36860700016)(921020)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3qgTNbfNIUoPHtrdUQ6cWimzx3eSvTpG0gNZDBV8slgjQ4BBCxTvtzP1sPxW8UUFLc6mlNW4/H0HlQ4CEmXSapYc+nlDAzV4UBOK8XUa5ST3ainSOECptL+N6obV3HveAEIJR6rr0/3JwAixYvCsaW9E1mF3AFdB/GWt0OXafKiFCj4UXVarNoBpUnnWALz07d63V1uhG8fKRSljHZrCAM9RLBiT1inKxx/WpHvEfY/5g67Di35QpsLgk16mGFbMQEdDY7SQAfUwcLW9KZIGJRAuCbsmbZjLfaO7CyGFRf+UELC0JU49984KeQdgYfChGekPmNn4JZj6TvfBQYxh5uvQfRm/6c9/GrHaHj7PdXyop72A6u4VRsZkns7fZNm0ePjzPiPjzQdJLYkRu9SRlB0AGg4rz2oud/nkt9iNRCpov3q5prTncsvGa9d2Uw9/ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 11:03:12.4488 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18092cca-993e-4054-c01b-08dea44c931d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001C8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8796 A potential race condition exists between mlx5_core_destroy_dct() and mlx5_core_create_dct() that can lead to a use-after-free. After _mlx5_core_destroy_dct() releases the DCT to firmware, the DCTN can be immediately reallocated for a new DCT being created concurrently. If the create path stores the new DCT in the xarray before the destroy path erases it, the destroy will incorrectly delete the new DCT's entry. Later accesses then hit freed memory. Fix by replacing the unconditional xa_erase_irq() with xa_cmpxchg_irq() that only erases the entry if it hasn't already been replaced (still contains XA_ZERO_ENTRY), preserving any newly created DCT. Fixes: afff24899846 ("RDMA/mlx5: Handle DCT QP logic separately from low le= vel QP interface") Signed-off-by: Edward Srouji Reviewed-by: Michael Guralnik --- drivers/infiniband/hw/mlx5/qpc.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/qpc.c b/drivers/infiniband/hw/mlx5/= qpc.c index 146d03ae40bd9fd9650530fba77eb7e942d5fe79..a7a4f9420271a228e161aaac1ff= a432d304ce431 100644 --- a/drivers/infiniband/hw/mlx5/qpc.c +++ b/drivers/infiniband/hw/mlx5/qpc.c @@ -314,7 +314,14 @@ int mlx5_core_destroy_dct(struct mlx5_ib_dev *dev, xa_cmpxchg_irq(&table->dct_xa, dct->mqp.qpn, XA_ZERO_ENTRY, dct, 0); return err; } - xa_erase_irq(&table->dct_xa, dct->mqp.qpn); + + /* + * A race can occur where a concurrent create gets the same dctn + * (after hardware released it) and overwrites XA_ZERO_ENTRY with + * its new DCT before we reach here. In that case, we must not erase + * the entry as it now belongs to the new DCT. + */ + xa_cmpxchg_irq(&table->dct_xa, dct->mqp.qpn, XA_ZERO_ENTRY, NULL, 0); return 0; } =20 --=20 2.49.0 From nobody Sat Jun 13 00:06:42 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010061.outbound.protection.outlook.com [52.101.85.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6499A388E61; Mon, 27 Apr 2026 11:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287809; cv=fail; b=sOiBOnPeYKPknAmVMJ0CPhlgb9D6aMWmKXveyjsS9Uj9hiTtLcO1QfiTddD9e/FHeRSi5WoCH5LHDM9KaIWvmZFeP3PeuE5e93zcXirLmXd1I0u2h7hYpdnWHYIaXborx1HL+J+JvZ10dx9ofU1FBGmhc7Mcfj1ZOJonCw9u9rA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287809; c=relaxed/simple; bh=twhy6JvLcZfraQ6zhpNaCj49rByjd8hCm5kGrV+ih/E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=mTqkikElybnIGkq5KZu+D2MZV55BtFbmn9cs1k0uekaG1Vv6yAwCMG6jrxTKPt8gl4LPuAdzrs5EwSotsOGfxYFukuhyNCkur85Hwbl2GdtxvYg4weLpfE1l2+juV8l8ouCGWSQowgmNWrora9YxxRF64JtAKjGSleoj8f8DKrc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=YurG0LgS; arc=fail smtp.client-ip=52.101.85.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="YurG0LgS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HpBobOM62AFAh2tAqI3ks/DztpQV69MYJstzGD917CH1s0bdahCeQKXs4j6uHU5K6mue5SceGM6VUp11/e6owaXA04qHhFhQZLYmnjcfTRbJ3oH7MSy6IcbMVNDzIa4HJ4bkm+j6NWFvpmbT/PyioE4WNcI8PgN+OqPhMgFp13fcqYiPCdaxvo9EoPEFB74rEaCGHQudxCKeX7KKualJq3ehAPF32hMJfj51RRlh3L1ngoYBqQW4foLeEkMRdgrjH3PsTV4z1HRlZRqxFjQdGDDKGsbHnZgOJoTNCZWwvIcS6jHjt0Vc7AsKYUAbgBeSgyF4EWo7vqNB5x9+uK98Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Adc+71oSC3kEstgNHwRXQOB3tfLEMA6PwNu4D8iVjRI=; b=LUfYDVrfeSCIqe02xygzDNUunxCO/i9uY5Er/P0ub3V5kx8soQXP3mjoxpkQdXbF9HKG+mFZar1ce0OC5VzyPI14AsDLhYuf/IxwN61ceXps2+ym1VxpDoIn5yUItSMjUTJwHzg+h66aMSBzNVJzkRzGUISQgBnUWv1wblVfRYIfXV1dq1YANWGX8hpDWC3XRxOPEg85FTzxotWJbRmOqf+LZimxWNOkv2gn1lWdA2VKlfVqZDfsWuqrlNO5PpqZ8tN6udvZ3f20R0IhwdBLlkOhxGmNSKYCMDY/BaN29VllNj5C4Rhh1Z7a+JwwH6sSvMY7EacCFKAc0bb0f8wcBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Adc+71oSC3kEstgNHwRXQOB3tfLEMA6PwNu4D8iVjRI=; b=YurG0LgSY9CLl1Z3+PXSrRbyQGgQ5UfBqL0826MqxaGYqkJM3iPfS5HXc5kJW9zwzOtk8bHKSKmBhIWksmWC6pnx3C4E3H+Y/1bmdzc7gdzjWJMJ/wPu0JxfQ8DKqpXH6qTONzoYX4D1JjklvKGFBeNboNQNlPT+JRX1nnnYtSY7Tq9MXuXLyNYxlVefdiQIvI/iTEl1gYNdljSZpOOzD7/zBrPgylswsV5UfdMSNlaIbd6HJT9UKDkrK2/TGhitDQb1UfNh4OtFM2pm/cCg0P62wzPKXvODdDk1GfeHs06P0iDql4OwdimZJAxVUp/6s+C58mALStqOGu4sH5A1dQ== Received: from PH5P220CA0001.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:34a::8) by SA1PR12MB7248.namprd12.prod.outlook.com (2603:10b6:806:2be::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 11:03:24 +0000 Received: from CY4PEPF0000E9D2.namprd03.prod.outlook.com (2603:10b6:510:34a:cafe::fb) by PH5P220CA0001.outlook.office365.com (2603:10b6:510:34a::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Mon, 27 Apr 2026 11:03:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D2.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Mon, 27 Apr 2026 11:03:24 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:03:05 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:03:04 -0700 Received: from [10.135.59.1] (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 27 Apr 2026 04:02:59 -0700 From: Edward Srouji Date: Mon, 27 Apr 2026 14:02:34 +0300 Subject: [PATCH rdma-next v3 3/5] IB/core: Fix IPv6 netlink message size in ib_nl_ip_send_msg() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260427-security-bug-fixes-v3-3-4621fa52de0e@nvidia.com> References: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> In-Reply-To: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> To: Leon Romanovsky , Jason Gunthorpe , "Chiara Meiohas" , Dennis Dalessandro , Gal Pressman , Mark Bloch , Steve Wise , Mark Zhang , "Neta Ostrovsky" , Patrisious Haddad , "Doug Ledford" , Matan Barak , , Maor Gottlieb CC: , , "Edward Srouji" , Maher Sanalla X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777287764; l=1480; i=edwards@nvidia.com; s=20251029; h=from:subject:message-id; bh=dowc9GYbR6/8wK5VJ1yS3HHNzFTqRKqHxXN007YFpfs=; b=IjMx5jyw7HQWLZQmeLU7WM1BVjrP1s9eALBcCFDz5hvkjeRV1pCDr6w8JzxdgMC1l41NEEQ2u EH5AuslZNZCCNSw4IZIifY68KPKIBH1gwlhk8y91JZQMSUg3u+CJ5us X-Developer-Key: i=edwards@nvidia.com; a=ed25519; pk=VME+d2WbMZT5AY+AolKh2XIdrnXWUwwzz/XLQ3jXgDM= X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D2:EE_|SA1PR12MB7248:EE_ X-MS-Office365-Filtering-Correlation-Id: c1c26b94-f449-44a4-99fd-08dea44c9a17 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|36860700016|921020|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: S3o+6wpRJyad2+3C43ZR/KA/qnhTpM6S3eoo9X1dTnnAxMD+y21i03Ne6XMHvembzzydi+BkV/WN+vrPAB8OEznTRlJA0TPjQD986+2MOX+ti8lPHXFiYgLoKhwsbJZD+cC8JHT4QUj2/YLSGIpVaJ38/zEQouQcYL9jjPnadSld2SSfR3b1HMGMuwbJaXDYhFNUpWmVZ3TsePYMw4FCBEA5TMnn6W46eyP4Ts0yF2mN5P6Iw23mQXCHclYIXdfTw3l9cqK9NTuWWOUxvjju+AINSYXc3JKScytebaoAU+xprARCbmR9elp388/a7x2UaoXIOzORiscL46WeF9vwItpOaOjp0VgWEKg+XfHu0AnXU/+dUK5/Bfy9fV8Vweowe3woUdPaXJrrn7vSELPCmc28vXBbEERMAZblT5ZH4+4Kdb3jSBpnk/9T2FZgT+CtTj8m/4/rsBlllmF3ZSnWOyAMh7m2vK0BDogwDBnaQN36NYZrVkciZCeA4gc6zHFJZxmLy1DWTrQuawuSWCSoeRqjLKB5JYKJIb1fYNmze4C3AWYLEabC7WR2HziVZTvnce1FKDcjVg078c2uho8Dy5BgUGsqRoyDgoRW1z0q4hYp3RI9QUISOs8KC5tTNJceF/QD7ahyv2pyKKd9Ofx0sVWUnYfLJE88c1q3EY6T3+Upny2F4qXC6vm/NjIOAAH4IDE3pqKusMQZrBt6ILkGi0c8coZaXmxmmwQPWsCj8ffgB+zINUOq5HWSX3VRQkHPt7VYmAQ+07RshkkoblrYcATimfYibiBnm6X6pkCCW4hbxrWguxTEYgTzoj/JBOvL X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(36860700016)(921020)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: msswSRWVfXvCWDUUFHOACau3pJxhOZlloS1SfopCbjC+9OLCSoJQ4oRZUW+hmWcz2nAqL+l5PqGCU7BIHRMjtu7oIV11TB8+lff+TYOLAjtU3MBa9L5C1GVy4DI/kNecoOE5ZlirGlL2tJbtAcXZ5Gi7d/g81DLwN4gvWOI/y+jNKjHrx4e2FfihvImrCXy5wK8ryRB/5EFJ+aNWZZAgs40Pg3E1L5FozTEzyoMQybfMQ4LTGPxtOTTUl2lncEwRFSxCZsAEugTmsBNVeQso5mW4PQ0ggGqj4U6/+0FRGQNCaYaLUEGDG8VrKOHGL234aq4CFua4zoh5qmBegNb+wiEUmhzoNJoFYIiih+ceAJiB62SJI61QvVzZgRfCCZtf28rqjrFdDHAUBiG6tO6B41i27Sk4uZ7R4mGxBh7Cd7et9VMFpCR1Ly8KcEHk1fHe X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 11:03:24.1794 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1c26b94-f449-44a4-99fd-08dea44c9a17 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7248 From: Maher Sanalla When resolving an RDMA-CM IPv6 address, ib_nl_ip_send_msg() sends a netlink request to the userspace daemon to perform IP-to-GID resolution in certain cases. The function allocates the netlink message buffer using nla_total_size(sizeof(size)), which passes 8 bytes (the size of size_t) instead of 16 bytes (the size of an IPv6 address). This results in an 8-byte under-allocation. This is currently masked by nlmsg_new() over-allocation of the skb in its internal logic. However, the code remains incorrect. Fix the issue by supplying the proper IPv6 address length to nla_total_size(). Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload") Signed-off-by: Maher Sanalla Reviewed-by: Patrisious Haddad Signed-off-by: Edward Srouji --- drivers/infiniband/core/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index 6526fda8f9c0bbbcddcf54f5c953d3f7a9785d66..5cd930d47eae52d35db8657ab3f= c5993c5cd7770 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -150,7 +150,7 @@ static int ib_nl_ip_send_msg(struct rdma_dev_addr *dev_= addr, attrtype =3D RDMA_NLA_F_MANDATORY | LS_NLA_TYPE_IPV6; } =20 - len =3D nla_total_size(sizeof(size)); + len =3D nla_total_size(size); len +=3D NLMSG_ALIGN(sizeof(*header)); =20 skb =3D nlmsg_new(len, GFP_KERNEL); --=20 2.49.0 From nobody Sat Jun 13 00:06:42 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011003.outbound.protection.outlook.com [40.107.208.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435483B4EB4; Mon, 27 Apr 2026 11:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.3 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287813; cv=fail; b=hAVYrvYQZDYaKofzv9j1S6McoNUjfTvAqd+7nKJmpSX3OJ7iYksNpypMEldBRlHay9ALruZ2mVB1Slo/yD05bjjdAUudCaeNlP+/larkG+f3RplIISfrv/b8j2yjflJg5k4OR3yaHQNGFnrVKXUeQivtv+Oc9Vm1LUqBoaQpkvY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287813; c=relaxed/simple; bh=HpzpnaKGcCcSb+984F7Z60MPP9ReCcmxBfKAt0ez2yw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=JymBjrsde0hSB5rW469odFVJuWef2zjc06yUxHVYUseh8FuMmorEVyASdPAhWISLCWuNAbngTl3C1WEEBXURfcj8tBRZhMoiFQEqmE/2fBCtJoSTMQZGyRXheE21yy6guI/k3JzpMuYQ6t337dXTk1oS7cm3y+P460NLBTn7kfY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Hwe4PKdD; arc=fail smtp.client-ip=40.107.208.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Hwe4PKdD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WMnC9bxke+qhybZyR6nqtLngJfRJCw4DJ3JMMBTUXu/OeKzPOddVEHP1MzKFnSH+HEun3gveM0WDUzeZIksLt1rJMaFke/JGPB6W7KmWWsYEVkRbD9DiRUxdZ4takWAHaL43NP+YwuZX+tGuA7RYQiLnx4ko/AW473kRbcXPnnebt1YkWbi7hD/wRYAIUHhWUnAFAgzNnYyjhUJschK6Bserw3DSlPBYQoGS7+p+iWDJYGSGh17XgDOUAiROMzX+wSKc+hoVx3h6Deq5WLavBJpph/4ZvYnBqGp4DN0S/CVBNw+nI5ki93ClA1gOdvCwBXatwitxdCWpfwutzB6qDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dWNvwNU3G9i+nUe96uBuBDeWT+SjQAGZmET9NQQkc8M=; b=CiruCi2yApvSeL3+u9YIyZqqiw/nzRcMWgnkCEChwoI3Nr6uhmc8432jUNobydMkyiONQB9LOc2Gjkr8p0Lf4hRj2jVGPbwmjRVVNsFum7vDoLHI8b4nkmqhRZ3s8EZTU/DF+dB2LfR0F4gvMPW+W4mVHIqH8oeyqN1RQbqmf8JvaXJQuPN4BgqG1AwoY3zvAZwB9W5a4c32R8cOLW7JCIHTcqO28gSn9iMnVQIjWgMH13AzaB6JI7Aqa/3fgy5qa5ee9OKnNqDZpG/HkbJagYql1wPBpE2xz92ejHM/akZd1AVKo7yf10mEewZS7LgvbyQoSsD0Zy+zps6syw/6XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=cornelisnetworks.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dWNvwNU3G9i+nUe96uBuBDeWT+SjQAGZmET9NQQkc8M=; b=Hwe4PKdDKDvUAuR2bIUZGdNJ2DMHwLbsUYrsqENenOEhxo104QQ6FDP4frk+xyjKiWs7n8grPpFk+uSd9FveqLhAcAR32h7vaVkQj2S9srvu5Q6BQyVQwK+65V2Kzi3Um/UW7b9QoaS1XbUBZeAV2jVOl5x2JvyWwETjlpCZS//mc67ioUyqvChQ9WmR+NHW3lrAkWOS0b88YHVV8OvduolnjlcnKU1f8R04P4nvS+BfNYVussrpMPw5bwZOe8HT8qkqHGNROKqUjyt3qiqt6dOPUeWy9IKh89+25GQ9s15mCOE0dnzeluYqBr+l28sN83stvSNdYptsnYtvPzes9Q== Received: from BY5PR03CA0021.namprd03.prod.outlook.com (2603:10b6:a03:1e0::31) by PH7PR12MB7988.namprd12.prod.outlook.com (2603:10b6:510:26a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Mon, 27 Apr 2026 11:03:27 +0000 Received: from SJ5PEPF000001CE.namprd05.prod.outlook.com (2603:10b6:a03:1e0:cafe::71) by BY5PR03CA0021.outlook.office365.com (2603:10b6:a03:1e0::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Mon, 27 Apr 2026 11:03:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001CE.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Mon, 27 Apr 2026 11:03:25 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:03:10 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:03:09 -0700 Received: from [10.135.59.1] (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 27 Apr 2026 04:03:05 -0700 From: Edward Srouji Date: Mon, 27 Apr 2026 14:02:35 +0300 Subject: [PATCH rdma-next v3 4/5] RDMA/core: Fix rereg_mr use-after-free race Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260427-security-bug-fixes-v3-4-4621fa52de0e@nvidia.com> References: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> In-Reply-To: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> To: Leon Romanovsky , Jason Gunthorpe , "Chiara Meiohas" , Dennis Dalessandro , Gal Pressman , Mark Bloch , Steve Wise , Mark Zhang , "Neta Ostrovsky" , Patrisious Haddad , "Doug Ledford" , Matan Barak , , Maor Gottlieb CC: , , "Edward Srouji" , Michael Guralnik , "Maher Sanalla" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777287764; l=2925; i=edwards@nvidia.com; s=20251029; h=from:subject:message-id; bh=HD3aLo6Y2la0d4ALg5OXwr7GfoYNm3Y3+oMXGY0tChc=; b=utzIK+zSdBtiIrD5sn782ONr8EYW0InQgcs+L+YkFfgtkkeyjHdsRaosxeufQHpz9ws18MTd8 /ZdsO7GFCBxBFQ7dfVKxPgJXPi2ZX4+giGn5ria36sCQeHsffSc6OnT X-Developer-Key: i=edwards@nvidia.com; a=ed25519; pk=VME+d2WbMZT5AY+AolKh2XIdrnXWUwwzz/XLQ3jXgDM= X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CE:EE_|PH7PR12MB7988:EE_ X-MS-Office365-Filtering-Correlation-Id: e0830418-386f-491c-4519-08dea44c9b24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|1800799024|376014|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: 6xdPxzUKyyfRpXiGtc8kSf0TwrWthbO0/gkgKoFuoYSw9HOSk5Qb+Lib289yJ75ZuyJm6grfKLeGBMiDIEHCZ0vCXmCXwjSIg01xJjCMl5FBnnfNxEzHfWZSLEcJOZAVHiEDjU6XRUASsYegDjl2+M8kzpOEOaC9l+AG62xys4YKIVAPurPdMk/naXdftIOmyqDFZzOAm+zYgY8F/YpWMNcjJFoqTSnHmgU9nSc2W4AMtKCTK87houRCHfLBFiv8aexFz7xJUjW+jHJk4LqiuFo4pi78fxNOjUzWZd7/az9iKvFIjeBQlKS544+EBIBdxyqoeYk0xk8lS4WPW96fiGVnDcaBURw7L6ejlo91lGe4w58jFkTsBy+ov1YoTwjt0OvO/DMVdMvvnd8Y6cOHqNaJ9DPxQi84MfDrQEFFwt7xiulnRqDMJ9WLAEEQoNCsKmppK6d4qQeyXoN//zMLj5NX7ZXVSyOna7Ly+6i6cy7R4KAB6ds+R3Nz8L3o5aPOTSR58CiyUy0rvOl6KM0fcHlQQMCPQdk/5/QmqrmonKKmtQ9R1UEFKAFfBcSTniw5iPyDJRPvDMZ5jyAgf/aq5uuhDkdkE1doyze7M7Odv3L/xgGzy3UwbAEJ+ZzwSuGTPprzJTaIF4JtXkQ8e4clcVRWnCE/FEZN66Md2bAg5xICsfIe4wNjZizntgHDgh/EgbK7OC+Tk62tFCg/SKzt3LkJFGAtIh7J3a5A93AXPG0wwBhwnGl0gIzhCJuG9QWJfrObdmfpJA1/kAGPIKAFagQIdq58gGR4075sVZ2L0HIeRwJaovefwACxambzsIxH X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(1800799024)(376014)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 83LCoeI9j4xWClqDFTn+dqKFLXyAA8aZ11MgWTBQGuCD4NbmM4nDfAC0ILywRd8gK9eNMmdqDco6X9OQke/WiOs3Sa/MyLLI/YDWZD9ZYvImL1n6R4oby4IrRd7EShKhLc1pBTK2js0KUONsqG/p1iuh0R1w8M6SyM2mIS1Kv0K36CVhX5mwi17K93c3S+clmIfCEhGAB1PIEW2U43yC83JAoxslstHW+Hj3Zo++nmt+xqCRHX5C6mH7z/hyymdEOhdVX/SX5eOnwCSfx8mMxA121e3p/tKkRFAurdK4C1hL9DZPj43kq+0ch7R6plwxVRbA7rMEFvRQjqHMwJrFiZAhsC7zoM2TgCmnXlweg50EAUKEi+DOmYGoJ+YBE1kvgxSj3lX+C5yxVff+wl/GinYG8t8MCUFsyrIuxKLafAB1BhZlRA08QVpXqA4QYGEr X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 11:03:25.9073 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0830418-386f-491c-4519-08dea44c9b24 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7988 From: Michael Guralnik When a driver creates a new MR during rereg_user_mr, a race window exists between rdma_alloc_commit_uobject() for the new MR and the point where the code reads that MR to populate the response keys. A concurrent rereg_mr or destroy_mr could destroy the MR in this window and cause UAF in the first thread. Racing flow between two rereg_mr calls: CPU0 CPU1 ---- ---- rereg_user_mr(mr_handle) uobj_get_write(mr_handle) -> mr0 mr1 =3D driver=E2=86=92rereg() rdma_alloc_commit_uobject(mr1) // mr1 replaced mr0 and is unlocked uobj_put_destroy(mr0) rereg_user_mr(mr_handle) uobj_get_write(mr_handle) -> mr1 mr2 =3D driver=E2=86=92rereg() rdma_alloc_commit_uobject(mr2) // mr2 replaced mr1 and is unlocked uobj_put_destroy(mr1) // Destroys mr1! resp.lkey =3D mr1->lkey; // UAF - mr1 was freed! resp.rkey =3D mr1->rkey; // UAF - mr1 was freed! Fix by storing lkey/rkey in local variables before the new MR is unlocked and using the local variables to set the user response. Fixes: 6e0954b11c05 ("RDMA/uverbs: Allow drivers to create a new HW object = during rereg_mr") Signed-off-by: Michael Guralnik Reviewed-by: Maher Sanalla Signed-off-by: Edward Srouji --- drivers/infiniband/core/uverbs_cmd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core= /uverbs_cmd.c index a768436ba46805a81ab5a0b8acd4d64b4f2b1b51..91a62d2ade4dd0ce402604ec283= f8cdc70d2ef06 100644 --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -778,6 +778,7 @@ static int ib_uverbs_rereg_mr(struct uverbs_attr_bundle= *attrs) struct ib_pd *orig_pd; struct ib_pd *new_pd; struct ib_mr *new_mr; + u32 lkey, rkey; =20 ret =3D uverbs_request(attrs, &cmd, sizeof(cmd)); if (ret) @@ -846,6 +847,8 @@ static int ib_uverbs_rereg_mr(struct uverbs_attr_bundle= *attrs) new_mr->uobject =3D uobj; atomic_inc(&new_pd->usecnt); new_uobj->object =3D new_mr; + lkey =3D new_mr->lkey; + rkey =3D new_mr->rkey; =20 rdma_restrack_new(&new_mr->res, RDMA_RESTRACK_MR); rdma_restrack_set_name(&new_mr->res, NULL); @@ -871,11 +874,13 @@ static int ib_uverbs_rereg_mr(struct uverbs_attr_bund= le *attrs) mr->iova =3D cmd.hca_va; mr->length =3D cmd.length; } + lkey =3D mr->lkey; + rkey =3D mr->rkey; } =20 memset(&resp, 0, sizeof(resp)); - resp.lkey =3D mr->lkey; - resp.rkey =3D mr->rkey; + resp.lkey =3D lkey; + resp.rkey =3D rkey; =20 ret =3D uverbs_response(attrs, &resp, sizeof(resp)); =20 --=20 2.49.0 From nobody Sat Jun 13 00:06:42 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010056.outbound.protection.outlook.com [40.93.198.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86B4539B946; Mon, 27 Apr 2026 11:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287822; cv=fail; b=aDRsCCVIFwsQ48AwfzEWoBD8CwznVIXBlpyr5K8U7Cao8u44EVihoRBhyxxdWnPNqRxaD5XIdRg+nw+24mrnA5Keql/qpFbxbEtlnYOvIrbMlbPxMlTGEWyL+8p89eI5Zv6WrE7tbBOBa0Fi+VPXyy+CPh60BKrQEZJHrp6scpg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287822; c=relaxed/simple; bh=JSt2D6BkbHVyUIkrKwyd4D93NeyLBJNidZco93owStc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=gRpBzlaT6FYk/0pL+uimcXAlQTq21o3dmc8GLk7dO7ALqDfj7EL6YcxQrjF7S/wDsl6wrngI9lK6uom9LZiZ/8aEQXDk736lDZmESCwTYSyrg8vx209Kpb6Fi08BB8ocLc30vgp2fUF+RGKrs+sA76/e/yzGBR4XyGI6KhtUb/g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Aq860lTM; arc=fail smtp.client-ip=40.93.198.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Aq860lTM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZBSoMLmmNlzrrMDQ18AHyZbF9Cfjmysie/cUSvyYYwYuECOnDMiJuGKFZe9j04lhStkJPAl863FrojFA0j+jkaEGlYm1boLp21uWP6wQHRduwD7ESbN591t9aQO6qRmPx5KynnIOxOis5LQEudwYSVPuUTLQe6XRqKDy82acsRHgT2BFHTjOB1gMrfsY2lgaqPk1COCSqou/6GT0VH85sLBX/iDYTdmRzm+dp8tJ+8zlBH4HUm2OQGAOKdWw5h9DGeUXvzoBg2+Mk9nCHW9ucuS+nEy3+n9RmyFmcdyrFxOSA7mmTJhyViZqIBlBYGWNjsSIOy4pku5KVMgugy5EcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w+hX2rITV3WABuor/7B8LhrisF1Slldl6ms7NqJFzsM=; b=QRCmHdVmO8vIzF2YF5PYx4ehb8VvU2vr+dPvX7tk/z3xkVdmcUirigvcJY59MfNAVP4eTBAwFPR4YHin90LkbYpTqGrcBw+SlkI1N0gU34fdHmcSQYDlO3ydBjFcH0MbSmN0ly+oJRSYoGcVwQaGd9B1GhXTQ7jRZIXFLFqwRJX96dNjI5I/5FpOEmW8Ygfjvnr8PFEJOKfCmvxQ3bDx/D2DYVLgYXJdVk1T+WHjF3dFrl0XqgWCVz19pjJPwyX2Z1ZD+8leL6OhnkheM/c3vSrX5n3I1/7OAjadhGLGNB8JzblQjAuX+BRlN44tRII6LrnCvao90HZyp61RqEmHRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=cornelisnetworks.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+hX2rITV3WABuor/7B8LhrisF1Slldl6ms7NqJFzsM=; b=Aq860lTMIE74TeVQx52P28wr0MmnpXVBbNZOXDg4CRWWe5jxD1KhtA5rK+RlKvZutycP3E/GkpFPQI22ivAN7XA/teML5XGBjbog9JVGWwfaqnFUoLss1FdiM/0clgol78hZz2oWlBD76VA64f7ISjxnBwDvd8YnIVJAocfPratzQ5EZLmzQ8FUIwh7xGsI9lrb1B63g8lvTLcwTu+8YbTxkIh04g2sjAnZnauLe8KC/zhvLIbUr46AMBv8BO9Ip/fZUn9ZXFrRjsyIIKsjUlX2Et6K1nY3U7GYiPjorfmT0z26Qz36seuO0Vs8OHUFdwOOxVUJ6/bL4jIAIOKaG/g== Received: from BYAPR02CA0032.namprd02.prod.outlook.com (2603:10b6:a02:ee::45) by SJ5PPFDF5E260D0.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::9a6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.21; Mon, 27 Apr 2026 11:03:34 +0000 Received: from SJ5PEPF000001CA.namprd05.prod.outlook.com (2603:10b6:a02:ee:cafe::b7) by BYAPR02CA0032.outlook.office365.com (2603:10b6:a02:ee::45) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Mon, 27 Apr 2026 11:03:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001CA.mail.protection.outlook.com (10.167.242.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Mon, 27 Apr 2026 11:03:33 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:03:16 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 27 Apr 2026 04:03:15 -0700 Received: from [10.135.59.1] (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 27 Apr 2026 04:03:10 -0700 From: Edward Srouji Date: Mon, 27 Apr 2026 14:02:36 +0300 Subject: [PATCH rdma-next v3 5/5] RDMA/mlx5: Fix null-ptr-deref in Raw Packet QP creation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260427-security-bug-fixes-v3-5-4621fa52de0e@nvidia.com> References: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> In-Reply-To: <20260427-security-bug-fixes-v3-0-4621fa52de0e@nvidia.com> To: Leon Romanovsky , Jason Gunthorpe , "Chiara Meiohas" , Dennis Dalessandro , Gal Pressman , Mark Bloch , Steve Wise , Mark Zhang , "Neta Ostrovsky" , Patrisious Haddad , "Doug Ledford" , Matan Barak , , Maor Gottlieb CC: , , "Edward Srouji" , Michael Guralnik , "Maher Sanalla" X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777287764; l=5376; i=edwards@nvidia.com; s=20251029; h=from:subject:message-id; bh=h2517xFaD4h5RCJGmHRR+frjDveXS7FYvQ1dO6AnUfQ=; b=L1Au7eGw2GArI9wit43aX0ROKvL7wdH5BWHcJJqedhNTSvzvE6xpQqHEd2fRdm8zyvKo6Fl4m CfNZOye4S1rCYpU1ww8ldzwdd6Lft81wr+o5MTeS8OcK9XejDDbTBGC X-Developer-Key: i=edwards@nvidia.com; a=ed25519; pk=VME+d2WbMZT5AY+AolKh2XIdrnXWUwwzz/XLQ3jXgDM= X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CA:EE_|SJ5PPFDF5E260D0:EE_ X-MS-Office365-Filtering-Correlation-Id: aac30028-37b0-4e12-838a-08dea44c9fa4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700016|82310400026|921020|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: oA+9wm+OLKqIrApx1UpUsUH2skIfnPNySLQSUBa8/W6r9k6qdLewSzEKLISxDwRitg27RURG6s0jEk36PVR5qAou6IJylVrcFGY37u8bAsOAIypJWHqgIU9SICJfvRZPiNJcS0qD5aPk+dh0VQtKmPdB08ily3/m7F2XAXm6xxOCwME+uZQUXwTIpr86YBtZ2fhEOkIMEhgn678EQmfOX+Np0UC2akJOGnRGQaXmRO6YIKovUVMByA4q+txoiipMUs0FasOvE6kmmw9qg2KjcxGfJPVrzgnCOBnT4mtT9YV8YfP7CWQDl7CGKHnAsSs58OZzUVDJtR7dBXY7KCdjL2ZgGUy/oaAh5oGpamQ9aB+fynEseXhOv0NRkdujDNrQDbPYugPvhfiZ7w+Euo27EXwgQrTZgXFSEglftG2hx7vdkFqpWIzlOjgSaRipa5QohRil6H/2T26JLPbadI2Pb/YpsGL2KXyXI9aTCibXuZ4jppqYqwDEeHSoQ9oCHO2g/xF9Y4JaxxZMday4NwZx+lrpd7bS5FpD+ErokAehaSBauOuEfGuPvIDu+rUc0A12TDIIyyprU+7w3eFiik8Lxmn4/V9HTEmHbxEQpvFSfaemM++Fhxq03r7NyjEQkhucDrKKTfPtXQo9+d7CoMaKbK2hhi85syC0WxWmA7ouS4Pjp0KHg56nF8u2l0JG2YhdwHyx+RglAvg83mBI/9m6IRG8WvVsGsFEFOfa94OXAsu/WiPPzQj/h7jPJQU7CSIB9tfd+IBoqOfMeGvOGOL176xsGFWIHqqoXcQIe0dSiEXsKoiky54mVcjjjH9DV3pl X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700016)(82310400026)(921020)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4EeFvqH2ngPe+8733tcxdxhrJ9Ww1bel++/TB6Cfk2UV79Bz+PYZT3XEnIsV4Um2LQU+gteB31mb+TcaQpY2RFmzbhWkiJSiZgklxIG7iJB42QinF4WWUKYiuXh9Tr1ZVP42VCPcv8Y/KRXa7uaHTV7dVq+WK3ut8Umk0IwmAHVhhwAgvQFbQKUzlbeZAsHEF2DeHPwOZSiXtqyzljwRT3o+Wv9UUisyc4cKtVrvwl9WIM2VUP9pDzFiZ0vqpHnfRYaPSmUcFHmGyHOa+dguqXaxRTw2WNTDZUjLG5hK+JyUJyIE6xcZPhvUPyfLy70AHsew/8UT3QUKqJMPDgFTXc+6+W9uwCkWhGTXT9x0XOFmBmfrUktYUqc4ws11Nh9Mic8wXWwtKr9khVbutx7zGNJSVinA0lFumihJ+5qI1b6fYde2mlT1BHmyS4l1kyGT X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 11:03:33.4975 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aac30028-37b0-4e12-838a-08dea44c9fa4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPFDF5E260D0 From: Michael Guralnik Raw Packet QPs are unique in that they support separate send and receive queues, using 2 different user-provided buffers. They can also be created with one of the queues having size 0, allowing a send-only or receive-only QP. The Raw Packet RQ umem is created in the common user QP creation path, which allows zero-length queues. Add a later validation of the RQ umem in Raw Packet QP creation path when an RQ was requested. This prevents possible null-ptr dereference crashes, as seen in the below trace: Oops: general protection fault, probably for non-canonical address 0xdfff= fc0000000006: 0000 [#1] SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000030-0x0000000000000037] CPU: 6 UID: 0 PID: 3539 Comm: raw_packet_umem Not tainted 6.19.0-rc1+ #16= 6 NONE Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.3-0-ga6= ed6b701f0a-prebuilt.qemu.org 04/01/2014 RIP: 0010:__mlx5_umem_find_best_quantized_pgoff+0x37/0x280 [mlx5_ib] Code: ff df 41 57 49 89 ff 41 56 41 55 41 89 d5 41 54 4d 89 cc 4c 8d 4f 3= 0 55 4c 89 ca 48 89 f5 53 48 c1 ea 03 48 89 cb 48 83 ec 18 <80> 3c 02 00 44= 89 04 24 0f 85 01 02 00 00 48 ba 00 00 00 00 00 fc RSP: 0018:ff1100013966f4e0 EFLAGS: 00010282 RAX: dffffc0000000000 RBX: 00000000ffffffc0 RCX: 00000000ffffffc0 RDX: 0000000000000006 RSI: 00000ffffffff000 RDI: 0000000000000000 RBP: 00000ffffffff000 R08: 0000000000000040 R09: 0000000000000030 R10: 0000000000000000 R11: 0000000000000000 R12: ff1100013966f648 R13: 0000000000000005 R14: ff1100013966f980 R15: 0000000000000000 FS: 00007fae6c82f740(0000) GS:ff11000898ba1000(0000) knlGS:0000000000000= 000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000200000000000 CR3: 000000010f96c005 CR4: 0000000000373eb0 Call Trace: create_qp+0x747d/0xc740 [mlx5_ib] ? is_module_address+0x18/0x110 ? _create_user_qp.constprop.0+0x18e0/0x18e0 [mlx5_ib] ? __module_address+0x49/0x210 ? is_module_address+0x68/0x110 ? static_obj+0x67/0x90 ? lockdep_init_map_type+0x58/0x200 mlx5_ib_create_qp+0xc85/0x2620 [mlx5_ib] ? find_held_lock+0x2b/0x80 ? create_qp+0xc740/0xc740 [mlx5_ib] ? lock_release+0xcb/0x260 ? lockdep_init_map_type+0x58/0x200 ? __init_swait_queue_head+0xcb/0x150 create_qp.part.0+0x558/0x7c0 [ib_core] ib_create_qp_user+0xa0/0x4f0 [ib_core] ? rdma_lookup_get_uobject+0x1e4/0x400 [ib_uverbs] create_qp+0xe4f/0x1d10 [ib_uverbs] ? ib_uverbs_rereg_mr+0xd40/0xd40 [ib_uverbs] ? ib_uverbs_cq_event_handler+0x120/0x120 [ib_uverbs] ? __might_fault+0x81/0x100 ? lock_release+0xcb/0x260 ? _copy_from_user+0x3e/0x90 ib_uverbs_create_qp+0x10a/0x150 [ib_uverbs] ? ib_uverbs_ex_create_qp+0xe0/0xe0 [ib_uverbs] ? __might_fault+0x81/0x100 ? lock_release+0xcb/0x260 ib_uverbs_write+0x7e5/0xc90 [ib_uverbs] ? uverbs_devnode+0xc0/0xc0 [ib_uverbs] ? lock_acquire+0xfa/0x2b0 ? find_held_lock+0x2b/0x80 ? finish_task_switch.isra.0+0x189/0x6c0 vfs_write+0x1c0/0xf70 ? lockdep_hardirqs_on_prepare+0xde/0x170 ? kernel_write+0x5a0/0x5a0 ? __switch_to+0x527/0xe60 ? __schedule+0x10a3/0x3950 ? io_schedule_timeout+0x110/0x110 ksys_write+0x170/0x1c0 ? __x64_sys_read+0xb0/0xb0 ? trace_hardirqs_off.part.0+0x4e/0xe0 do_syscall_64+0x70/0x1360 entry_SYSCALL_64_after_hwframe+0x4b/0x53 RIP: 0033:0x7fae6ca3118d Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f= 7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff= ff 73 01 c3 48 8b 0d 5b cc 0c 00 f7 d8 64 89 01 48 RSP: 002b:00007ffe678ca308 EFLAGS: 00000213 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007ffe678ca448 RCX: 00007fae6ca3118d RDX: 0000000000000070 RSI: 0000200000000280 RDI: 0000000000000003 RBP: 00007ffe678ca320 R08: 00000000ffffffff R09: 00007fae6c8ec5b8 R10: 0000000000000064 R11: 0000000000000213 R12: 0000000000000001 R13: 0000000000000000 R14: 00007fae6cb71000 R15: 0000000000404df0 Modules linked in: mlx5_ib mlx5_fwctl mlx5_core bonding ip6_gre ip6_tunne= l tunnel6 ip_gre gre rdma_ucm ib_uverbs rdma_cm iw_cm ib_ipoib ib_cm ib_uma= d ib_core rpcsec_gss_krb5 auth_rpcgss oid_registry overlay nfnetlink zram z= smalloc fuse scsi_transport_iscsi [last unloaded: mlx5_core] ---[ end trace 0000000000000000 ]--- RIP: 0010:__mlx5_umem_find_best_quantized_pgoff+0x37/0x280 [mlx5_ib] Fixes: 0fb2ed66a14c ("IB/mlx5: Add create and destroy functionality for Raw= Packet QP") Signed-off-by: Michael Guralnik Reviewed-by: Maher Sanalla Signed-off-by: Edward Srouji --- drivers/infiniband/hw/mlx5/qp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/q= p.c index 8f50e7342a76949f7caf24f9ea32243ea60e2b83..1611a704c1b33231063f5ff0f15= 5ce7d5148e508 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -1603,6 +1603,11 @@ static int create_raw_packet_qp(struct mlx5_ib_dev *= dev, struct mlx5_ib_qp *qp, } =20 if (qp->rq.wqe_cnt) { + if (!rq->base.ubuffer.umem) { + err =3D -EINVAL; + goto err_destroy_sq; + } + rq->base.container_mibqp =3D qp; =20 if (qp->flags & IB_QP_CREATE_CVLAN_STRIPPING) --=20 2.49.0