From nobody Wed Jun 17 06:18:59 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5665F3B7744 for ; Mon, 27 Apr 2026 11:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777289198; cv=none; b=YSz+TZdikhon969JnGVSYQrygFjW1fUDmYsbyGuWHvXmKQ3o6khP/MNcWOGcHNzh1wtHqXiIUHyOugq4kxA0lijEZjxBQiKZyRHFV5/Xs8Qg9ZGv7lZfgUJC4/CqYiUEqblyj+TN+Ntoa+XcfeH7806UxhCaCFfeFRHbmn12Z9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777289198; c=relaxed/simple; bh=kEiZHKJqit4MGPY+b2Ld1n2nTYLDwv8qfRcBrOW6l7Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=XDrsSyqRzvBJRTjId29tnd56qIMq9Om5s+ghZ+8Izq+cMwzOFZLy+n5rwjSiMS9/RtSMUvOvi/v+TpsHxP8WYwIfFmmdkw2G6hmXzWVWL64ELo1lrt7/0VJC6ace3k6zyW7GvmjqrahZRZJd9W1BfgLIm7aGNRFhJxczj2Pd6T8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ouJHjCOZ; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ouJHjCOZ" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82f351ca23cso5104655b3a.2 for ; Mon, 27 Apr 2026 04:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777289197; x=1777893997; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=MRULM3iCCqXJE5g/4xg/Q1GMtMSkkTbAvywHS3WulkU=; b=ouJHjCOZsweVL9lNg2Usp4v33wgjXRnZuvFIyiuofEQdzgQjpsjxl+ogijdpPMIB3d W50c8GbxyjpiczmvXO21r0QMa2lvl1NUs3D4JU/7BP5AkSPZpGBrsytPbPJ3HNxSp9x2 Dc1a4rRU6iPHdg4ZHL9UYXONncG/u3Zrlowvhd9Z1jr5wMOCQ8JyDfhf1y9VcQsPxAHj nYC+Y/UsKIsbOCUh0JS9OL9/+j4u8CVUIrWM5hJgPkqrDG9MzE2aUE9t8riOI2oREsPg VapYhFTVVtg7Yj6MsaEQe7aC5wfO/t5/1wXOYBQ89FlCck6wlEhIrxSQG+fj4QJru1vG SUWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777289197; x=1777893997; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MRULM3iCCqXJE5g/4xg/Q1GMtMSkkTbAvywHS3WulkU=; b=IVvLgYLIxqOHDBWnA0V5h+hoXJhFuxiiRz4F053IWt3ne7awTxZqJp0jMyzSa+xKO1 kwOzFjolU8xYqqq18BrQc7traGFmCDEt0xCxBhqOt2IQPBQDPk5vE3yjpG3Gy319Si5x OrUAsisYwTQwmUfxkvDyLtSKjHEvTxyhNcU5QrpvNCIAOeZveztKLjIRvXB/GpHbqGOf VJnbxffsWkaIkVrTjkW19wi4oenA09lwBKrJhpVzP3cJu1N2HlX05kAAR+qQPIbuhJUM OuSUxO5C3d23jsJOKVz+NlqYj8CrEGxFFj9XR4az7Bq1O79Dw4CJm8D7qwIYFvd/SwG3 bUMA== X-Forwarded-Encrypted: i=1; AFNElJ/NBvzVoUNIZ6qbEYVUCvqlUzAk/7mKPQ2u0PJT6JRvBlN6jnmZ3DHrKbATN4f0sluG9wWQ8+uLQUSTKkw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywo0IjaHLavsnVv5KJ6+MPZQg696XlfEE1JWkedFRGLCIz10Tlr juWTCcp3SqyBFnxGUh2r6JTgIGRkjAZTpBMcqIEcbgIwq/4RgGH/8chc X-Gm-Gg: AeBDievkjRC+IggXD7mPRO1+Ej/bMNGL/wiGXC6t1zdk8VjBtElKrx3Ju2gOqTqGAcT lCIC6SKgQ/xhU4kNmtsPWsnzSZQRM337kMpESBZPrTZCjdJu5B2DziswkBi7r9jYlSz4W+KGxyi PwSUWQeM/fgespEbcjacKHCqV3QetRuEwOXPMKawaYhk1UAPmcLX13k6+AyWOL11tnnrzGxP2aZ cfvVCvrIeqQiLJ2wFST3f4t5y+zpRynOhgDIjWbaVOTL9tv6pWLi0fhHwQaa6RuyQTANG42LCLd AExY2OejkJEJdxtS027uDF5GUwUzvrCcqLj93xPMwG2F+1+hN1uOCnZ0wLU/lnWD05mKGX9/BV8 PAuGzNJQ0oJwdAZfCjVpoAk7gtqayK2ehDNP26Y+6psqrQGN8LKLrEAGttu10QM8Zws2eO3pI51 OgT713bF2NF7h5FGPBjReNjYMxO45Kkov5ITZWRFAunQx1Cp8BRn7w73A4oj1B5wDOm5C4jxysK RMEDAXFsz4bEgcqTDfxUagXWb3wwf0= X-Received: by 2002:a05:6a00:3019:b0:82f:8b84:50c0 with SMTP id d2e1a72fcca58-82f8c973bf6mr46567455b3a.45.1777289196476; Mon, 27 Apr 2026 04:26:36 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe40dasm31504074b3a.40.2026.04.27.04.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 04:26:36 -0700 (PDT) From: Felix Gu Date: Mon, 27 Apr 2026 19:26:31 +0800 Subject: [PATCH v2] iio: adc: meson-saradc: fix calibration buffer leak on error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-meson_saradc-v2-1-8981c56fd05e@gmail.com> X-B4-Tracking: v=1; b=H4sIAOZH72kC/1XMQQrCMBCF4auUWRtppkmwrryHFEmTsR2wTUkkK KV3NxZcuPwfvG+FRJEpwblaIVLmxGEugYcK3GjngQT70oA1mlqhFhOlMN+SjdY7oZXtnUbf9o2 Eclki3fm1c9eu9MjpGeJ717P8rj/I/ENZCikMtabH9oRONZdhsvw4ujBBt23bByPCEXmoAAAA X-Change-ID: 20260425-meson_saradc-54abc52d9b31 To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rosen Penev Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777289193; l=1435; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=kEiZHKJqit4MGPY+b2Ld1n2nTYLDwv8qfRcBrOW6l7Y=; b=OgBTJVEKI4XrARc7cMlcqcU7gP8GsABoiiF9yu7IVEyF9y6+My2J18Bx+/02Bvsj4MdK4S/nU QSfZVGrBreDD30Ae6PJwlEGnW3XjAo8m8gDqfw2XihWA8ZQPKwIUPfM X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= meson_sar_adc_temp_sensor_init() allocates a buffer with nvmem_cell_read(), but the old code leaked it if syscon_regmap_lookup_by_phandle() failed. Fix this by adding missing kfree(buf). Fixes: d6f2eac64403 ("iio: adc: meson: no devm for nvmem_cell_get") Signed-off-by: Felix Gu --- Changes in v2: - Switch to a minimal fix according to Jonathan's comment. - Link to v1: https://lore.kernel.org/r/20260426-meson_saradc-v1-1-6e96b298= 2c43@gmail.com --- drivers/iio/adc/meson_saradc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c index 23991a3612bd..000e39ca5c62 100644 --- a/drivers/iio/adc/meson_saradc.c +++ b/drivers/iio/adc/meson_saradc.c @@ -817,9 +817,11 @@ static int meson_sar_adc_temp_sensor_init(struct iio_d= ev *indio_dev) } =20 priv->tsc_regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "amlog= ic,hhi-sysctrl"); - if (IS_ERR(priv->tsc_regmap)) + if (IS_ERR(priv->tsc_regmap)) { + kfree(buf); return dev_err_probe(dev, PTR_ERR(priv->tsc_regmap), "failed to get amlogic,hhi-sysctrl regmap\n"); + } =20 trimming_bits =3D priv->param->temperature_trimming_bits; trimming_mask =3D BIT(trimming_bits) - 1; --- base-commit: 7080e32d3f09d8688c4a87d81bdcc71f7f606b16 change-id: 20260425-meson_saradc-54abc52d9b31 Best regards, --=20 Felix Gu