From nobody Wed Jun 17 05:16:16 2026 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4500F2D6E5C for ; Tue, 28 Apr 2026 02:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777343931; cv=none; b=q/eJHCZ4h6AEu79H2U35aSqtL3GY8ezfTpX3WsGPKpoGMnyw5V4Y35k8ka3jcH1eQBLSqburqxLLYB8HsOrDzfK5Goa29W+M6nQas0ripzWwZnPlPl/G7PwnZejZDqHKRClMdFKOEluuExUtr6oPKkOM68r8Bh4DzjhsIpDtI0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777343931; c=relaxed/simple; bh=HOcm4qkDWglYvDINF7knSwgT+XKsrEoWBufD27DaLn0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=M1ELjfbIy6igxydDlQxQsD0gk6KLdBXG9bI+LHCXd+d4OBFH/yRhbs6Wkib0l8JxZhNAoM/Ne9QhuUPimf5/0gBdVqHMMRQ8BRrN0HjUhNUkD7vzNNMxEzEPNX+Ywze/+nOv9mWqcX3+E3845xqJQfoFtdoV8jVIb+RLE6JcOZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kgB4FoWG; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kgB4FoWG" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-6587cee8b57so2554033d50.2 for ; Mon, 27 Apr 2026 19:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777343929; x=1777948729; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=GmbWusNrp2+62MHdadegYDv0GRGbm1Yqlz33D4lYo60=; b=kgB4FoWG6nEoI6bfCMt6yj+v2FdTWdQJ+iUM55CMSPioVRi9gv+vQOXnPLJfwLwutY D7Be0Pshx+Lu7SqF91X6i8+koDaEQWgyVhwY3VRf6BavuD5vC92VnDntFkEPXdyqLPoC C0XpMyJwXUVhtezeS4jykoAr/Fnz0GqXLctk5AYTCOuoaOSLJUmfu3MYNN6+V3Ba1yV+ J/IUbaHIkoSMJBImtemFtoCtHV8p8kptjoP2MhMB3CiluvX9IKEtA/CueRyMBgYM03ld LPcB7iTmHp2DgizSDSH4W9Mfp6j5ZC6Ua8QekrXFPUX9YkpXpXbpq8F76tK630z+Wc5Z Av6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777343929; x=1777948729; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GmbWusNrp2+62MHdadegYDv0GRGbm1Yqlz33D4lYo60=; b=mIGLOGX6y3vi0wR5rYwGjowK2MhLy2eyXWhNLY4WPVsi2vdzEIaEO3J3oc/TwJWKQm pX9DxjDmu0EitVOl67yjqfmQkUnyH56Epu1mSSBHqj+xDV+OFxgouz5BOtBGpLYCb6sC EmFgZDRHFdgEr0T5bcUeF4ZCfj1Y1pPVBz5F4rw1iHouJ9l1OaxwDUdMy+CUEaYBM//i uNiscJyeQAWYzmY1QpPveJrJEd96E1zsyt0lD/KEPGrqlgjHr12/ZC8Quc50m/tz8cRe DmUCaXXOcjRdWVra0YHUdnS8nKyf0VJtz4JTho2jIJD7XSgk6Z6aXvGxR01LzTsw/ZyX /oIA== X-Forwarded-Encrypted: i=1; AFNElJ+SOX5qIzuWbr+yPoHh+MMf7PJasBgTIdL7XPgXJKB/vAjpk4RuLUzuR+u3Hv8zz/lP+uSPe4u+04FrUU0=@vger.kernel.org X-Gm-Message-State: AOJu0YwArmnrQGPmTu8Hvs4tYiVGZXWzoFEtlw9X3tvmDS4iV/3By7GW tmiBW/fE8/4xNyHrxE6zeTqT52QXOk30mwXBecyCzKuspCG+LpUocrSgMsxEZRd6 X-Gm-Gg: AeBDieulaouSxPjLOLWw6keWZu7lOaoP5OygooElmgGizZt4mww5cV/UOO8gaapQw1o 1zJmIDO6ewjPREgv5NtSU5hnlrYFcNh2GFCYJS+sgA2JtY5SvFzA8v4HMZzH/iWMkZlLcLhD11w SzlMitMs2SxlEU8Q3814btgwNl9XLVBTFbdAwfrs9m0J7f0LDezJ1dU7IhOy3m+7E/wI7X88+nS F5teH59PuEy0VOiFXhT43V0B1+60BaqJm8qhuhhQbgQfMihMyZcz3+Wl4jU7skhgUuzvWF9RNEB D3jFlvbZFkzvQcUmHfTxcAAtwR9Y8HRttRVQ5/kkT8Ouj8To93RIR9Gf7a240v2nmfgdi36aLGx dMgonu+nLbxukX/c/2aAecw0XE/IAcjn+Ly9j6G6TtNitGx5MFS3FkTCKGIscFDLpxOB5Pjb7p2 Izej2laB2fv3APHuNg01Yjob5BYxXQm2F1FSar8ySuOlN7n9mVZ/m4ruf5IJ5yBE5rX+6VIwtKZ J0/ODCP2qGj X-Received: by 2002:a05:690e:1289:b0:651:b7e7:eff3 with SMTP id 956f58d0204a3-65beed93be7mr976664d50.19.1777343929142; Mon, 27 Apr 2026 19:38:49 -0700 (PDT) Received: from [192.168.1.18] (177-4-161-87.user3p.v-tal.net.br. [177.4.161.87]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65bee2afb03sm710987d50.8.2026.04.27.19.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 19:38:48 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Mon, 27 Apr 2026 23:38:41 -0300 Subject: [PATCH] ASoC: Intel: bytcr_wm5102: Fix MCLK leak on platform_clock_control error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260427-bytcr-wm5102-mclk-leak-v1-1-02b96d08e99c@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMTQ6CQAxA4auQrm3SqToQr2JcDLVq5Ucyg4Ih3 N1Rl9/ivQWSRtMEh2KBqC9L9ugz3KYAuYX+qmjnbGBiTzsusX6PEnHq9o4YO2kbbDU0WFXkPJU c/FYgx0PUi82/8fH0d3rWd5Xxe4N1/QCEw0s+egAAAA== X-Change-ID: 20260427-bytcr-wm5102-mclk-leak-88016072a63c To: Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Pierre-Louis Bossart , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hans de Goede , Andy Shevchenko , Charles Keepax Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1394; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=HOcm4qkDWglYvDINF7knSwgT+XKsrEoWBufD27DaLn0=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDJkfZDe/Su9pc417zDl/mqKizyx9MRHVP5eEPq3YlcV4c 9uOh7t8O0pZGMS4GGTFFFlWJy2y3NP14Gp93AoPmDmsTCBDGLg4BWAi628xMiwXin4fry7OrWWd //97TNlxo8cHzm4VcRFKLjrSfGmOsyIjw09xvehKlZn6h7n9n9aKXTyczv7c47XO3HuhzR6Vk1x +sAAA X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 If byt_wm5102_prepare_and_enable_pll1() fails in the SND_SOC_DAPM_EVENT_ON() path, platform_clock_control() returns after clk_prepare_enable(priv->mclk) without disabling the clock again. This leaks an MCLK enable reference on failed power-up attempts. Add the missing clk_disable_unprepare() on the error path, matching the unwind used by the other Intel platform_clock_control() implementations. Fixes: 9a87fc1e0619 ("ASoC: Intel: bytcr_wm5102: Add machine driver for BYT= /WM5102") Cc: stable@vger.kernel.org Signed-off-by: C=C3=A1ssio Gabriel Reviewed-by: Cezary Rojewski Reviewed-by: Hans de Goede --- sound/soc/intel/boards/bytcr_wm5102.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards= /bytcr_wm5102.c index 4879f79aef29..4aa0cf49b033 100644 --- a/sound/soc/intel/boards/bytcr_wm5102.c +++ b/sound/soc/intel/boards/bytcr_wm5102.c @@ -170,6 +170,7 @@ static int platform_clock_control(struct snd_soc_dapm_w= idget *w, ret =3D byt_wm5102_prepare_and_enable_pll1(codec_dai, 48000); if (ret) { dev_err(card->dev, "Error setting codec sysclk: %d\n", ret); + clk_disable_unprepare(priv->mclk); return ret; } } else { --- base-commit: 98421d94a1a6dcc3e8582eb62bedeccecda93339 change-id: 20260427-bytcr-wm5102-mclk-leak-88016072a63c Best regards, -- =20 C=C3=A1ssio Gabriel