From nobody Fri Jun 19 08:41:21 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22C71F4631 for ; Sun, 26 Apr 2026 21:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777239785; cv=none; b=aLHeYuq1sBKHxfaCjMI6M835TrUyfE9VK/HMEoZ9eaaO+hpKCk/p+8+HkJyp+aqDcjJRHUwlOPKOleoH+b12jK1e7epPDMATCkEkCAiVTfJe3m+46FQL9yy/lGfJeYXY7uOAkllnAaLkTdJqlmmPB/yNxlilDX9t8BJBAC3VqVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777239785; c=relaxed/simple; bh=+NDDl6FC/lFcy4ZJCUql720fhof7233AtLZRb2lm4Lk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gjNxrHOCbEYT07UHK3RoGINhLYAUzzc6sYUxXLWOzDM7JJMdlFGq6HGCSzc8Ep2el3kJaOvUgL8JuCnt0i4oV4jJ19ipB0xqzcxyqgBFSwEq5PlknGfrY5R0pUrDBcwM3jTjMg+cfgEJozz0pWaxCPQJnYuYKKN6/E5MzNnsxsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HqrDHMr8; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HqrDHMr8" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488ba840146so86279455e9.1 for ; Sun, 26 Apr 2026 14:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777239781; x=1777844581; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pyO/fIf9mlptgfmwEFv0+iVbuqCap8jpTzF1uKuXdKk=; b=HqrDHMr8xqQVhuBmThAfihjRhrBcLyrlxFV/mgZ9sQmTNZGSvk+sBKeCETXQCPfID6 SRo36cgrSJotI00m4ibdWzp+MZkBgLX+SKw9HJMl05f4Xk3SW3pDlLoHmKVH4e8t1BLq I8H9OiCMs1jwS839Ig3LObvBjk96w7+7eTgGVpiDkB+YJYRUyuuVu1zNpJmDQPDZxCu9 DZMPwoduWFQrzSO95qMClsnZkgfO5wMofGeEiWeEo8LmLXT9IZysSOAd/E+LvPRbJIED u9aSAQg37Nbk7QGbyyM6+Id1QVbXExS+YU5+z+iNODrhGFEuNkDCYbYRy+wH9I9KvJSa J6lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777239781; x=1777844581; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pyO/fIf9mlptgfmwEFv0+iVbuqCap8jpTzF1uKuXdKk=; b=nA30mK0pr+nKIAWq2o+VKk+u6jeVS9fENWcrN3rMNQqF3f1K2RFwTyxMvFscdbKGrR fWD0NCMLD5sba2AHUdH5Bbz+aDUCoyMvINCPQRHGwBeyl1DnK6Ra7+0puuDAuBQqP4Xa jBk3JmJBIB/UDARtbecKVLXRzvmyl2pa4vQb9zUY/gTDRnXcWZxdrpku+xsERhgQ+OAG 4R3dC8V1hX+dN6xARHpv8VioykUuzNjicwqqGW65dL2zXtFm78Q4+mE5fHYCCvZl3H3Q /QKGVSwx/ApbpecqxFEbObyLt9gC5ShGXLPfpKl8iZflYm1Kixp//skvx0IT4O6uG+RZ vg2g== X-Gm-Message-State: AOJu0YwvOHh43OftZ5CAsSCLy+bV1dXV1+WilYNyCm3ADK4xY5pIWULx IPToOw7zK9b6ocV40pK+VLrouo+aTC9Rw01Sd73nW3yx2ArCpZKsMcEU X-Gm-Gg: AeBDiesN/c68QZEeLeO6jZU8EMgXhSgEtfoEy1ca2rJZnj8UzCSDRspBafcopJSONAn pAdk7YLNFGdkipTTbJp1EtOsYc+b3Yd1es5PbyZr9Sezgc2H5MlLkYq1SsF6ZIJRyfOwFVokOdT 5Cwi5eFhs0irBWHm6Nm9p+gHEMUzZaGfZmlrTRgSFI7ngfNYgKrHMQ1y7kY24CQOv8DHrrLuqxW F+3ntNG2BKX2501PqxO/VnHpKkkPGlWautWEdRCQzDD8XiSbpQTpiTKAWWXC+aSy+fYJOK5PMi3 n+NEN9Ri9mjVuziCYgBEFrkFriCXP6flKHQ1FM41lkJolMphWcBAn5ZYLjDNwpVJB1j3EyAwu8Z F2OSPWI3fs6tPqEU8ZFVnMjNxwjzd7fNpArhrKfKgqY6Sx163h5hj9h0M+tszpu2MSIdrWAnjvZ 8YZgN2v0MGEhIo1n1obLBr4W2D1ekx0g== X-Received: by 2002:a05:600c:a31a:b0:488:b241:2c5f with SMTP id 5b1f17b1804b1-488fb785b7emr432470225e9.26.1777239781269; Sun, 26 Apr 2026 14:43:01 -0700 (PDT) Received: from fedora-dev ([46.10.223.24]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1cfbf2sm782831725e9.15.2026.04.26.14.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 14:43:00 -0700 (PDT) From: "Nikola Z. Ivanov" To: gregkh@linuxfoundation.org, jirislaby@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, "Nikola Z. Ivanov" Subject: [PATCH v2] serial: mxs-auart: replace hardcoded 1 with predefined macro GPIO_LINE_DIRECTION_IN Date: Mon, 27 Apr 2026 00:42:50 +0300 Message-ID: <20260426214250.781151-1-zlatistiv@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The GPIO_LINE_DIRECTION_* definitions have just recently been exposed to gpio consumers.h by breaking them out in a separate defs.h file. Use this to validate the gpio direction instead of the hard-coded literal. Signed-off-by: Nikola Z. Ivanov --- Changes since v1: - Commit title change https://lore.kernel.org/all/26cd0656-ca76-4cb7-9f1e-b8c042a7e2cb@gmail.co= m/ drivers/tty/serial/mxs-auart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c index 693b491f1e75..697318dbb146 100644 --- a/drivers/tty/serial/mxs-auart.c +++ b/drivers/tty/serial/mxs-auart.c @@ -1520,7 +1520,7 @@ static int mxs_auart_init_gpios(struct mxs_auart_port= *s, struct device *dev) =20 for (i =3D 0; i < UART_GPIO_MAX; i++) { gpiod =3D mctrl_gpio_to_gpiod(s->gpios, i); - if (gpiod && (gpiod_get_direction(gpiod) =3D=3D 1)) + if (gpiod && (gpiod_get_direction(gpiod) =3D=3D GPIO_LINE_DIRECTION_IN)) s->gpio_irq[i] =3D gpiod_to_irq(gpiod); else s->gpio_irq[i] =3D -EINVAL; --=20 2.53.0