From nobody Fri Jun 19 07:51:45 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C7835F607 for ; Sun, 26 Apr 2026 14:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777214260; cv=none; b=W2MA+XJtlP1koviCL0omJ1wIT/42QqtOPpeW4Kv+VHg3nyfXC691An5KCeINXivEsfJvxdy4DV6LDAx/Z2/P1neGDxZCVuaEnzvJ0SmK+9tRtkAzq5ZX44pm5whiDs+QjfdCy3SGTQqIm4fAsLpGnXn4NsztKIaYZVjPOxG0YKA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777214260; c=relaxed/simple; bh=gGpxLTxMrG6yvK1ojoAShxQL3Kf8sRp4c0UBA/ejRF4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AQFAaRBo7Fak58JLPXdeCNTujtc8sZeQ8RUszKFF169Vdr03kftJUz/TjlYtUhCzwnR5cOmlRQLNdkbX/ifYF7m+e3ZdF6t5hbTDviDrAhy2X9fqWbO8c+p6u9TQ2FGd1/MlZzBt7nxPHRvXgoHvs2sIQH3iUKQt8tnEoGH8ess= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iIVLIxu1; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iIVLIxu1" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-82418b0178cso5730172b3a.1 for ; Sun, 26 Apr 2026 07:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777214257; x=1777819057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Zp95h01o2/Wl98SnFb+AukwrIEiz+o1jaPsbSAEFOD4=; b=iIVLIxu1nA9aVXC6HOpxIVY07VpdUKLtbTrB4QdIFuBgdYu3laObCyZ2ydpSOMZbvs zkIraWbMBptowIO3Vi3V4ZTy8BaXV5f70CH0KjfFGkMN5p6JxjE04sTT7RPeVXD5Kg+F yzVNFcRrBJsnYle7E0+9XLEe/CGkaBiK5zZRz7MuTenlxCen7ze/3ZIds814HV1+Z+sl 8DsoP26ZxaFb2eHsXkj5YZfZesRnr+jZ8/d3e2h9pIFkuZV7up3FcCbmQ6mBsPeenVr6 pW1D+iPmosg67TubKuSMiATJToJKVw8vyLwzRe9GUg8iF4CpDb+30BfFcQcfNgB4xVaq fFVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777214257; x=1777819057; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zp95h01o2/Wl98SnFb+AukwrIEiz+o1jaPsbSAEFOD4=; b=Npfbkl2xA9FvMfHMEhvbm/4ZEWeIgaLY3CYqNKgsT3nfbgi0EIh/dKk7tr0ITsGw97 7sXlTujEWsNHFJpM8vr5FzMRsgK0OOrgMs/OHb7b9CE68mddLv2sSDS2VTyFRBdIwxxU ouLm57s4KSxV4Rx67Pn+Q1qxTchqvZqYV+WxLyUjVDs66yLSjcmzsk59Vncp82/UV0ep LDQ3IeDKtR9QqVqAw8HBiTjTrVQLOKHJeVN+9MvCe9N24frCoJKe1wpJGU/OfonFH5/G 72/miaG0jmsWIPBtyiRLjXDxnQilOxyhDAbCGzUqpUljqIZHx8PMMJKaZn28wkFr4Mc3 sc1Q== X-Forwarded-Encrypted: i=1; AFNElJ/c0XgxViHH4vUpaE+0i7Y9ETeWCVWKvJx9yOFe+fPJd0BTA6v+SDfk9pN/RydwED+vic/rITvmUkDdSB0=@vger.kernel.org X-Gm-Message-State: AOJu0YyuIgvLAiRQzFezSjM1PmZ0eBAlRBQHgFhfmkYWJO9rnW89CeAN aOs21igH4dcAOyTYKRCR8Q8nJGnaiHzWf1/qjSSqpqGYIql7PEG7Qoc= X-Gm-Gg: AeBDietm4MkRylHpum33sBOMglan4HDTWBPQN/55l6UCtl65ATzuo6+kY5YZsLIxgsj g+2W67yufWph9s7gOBZLFjtyhAl/LG/kowJqOHBgS9fKAJ+In6XAcCzNX6DZ63tjNFMZjaUZSDa CViQWQ/Y5VfsGzTFX4bK6tOjSECn4SBpoOVssziUPD+XydbefPvvxYuyB+zuMPDG+CSP68RnFYJ TyjwshtsKxq47KE8mpH08HanRRIIqGdp/JScqM1u5IK+Yzboh/bjbYKzFAvhRcQpq1bxj49llZb O3NC7QSNq52qshAwBLHWspWxXUQGOHhAGx+2pnsTlYFiEOiBmexXK/xY43/my+NAhq3hCErPKDX ilciQTLc3Khe7zRv3p2tQPQrr+eZPMZfCaRgVNVNyxD92VzlQDSJyOUKvDEn//TvFG8Xnnr3/aH pKhagH8Q/zivNse0ysp6ZK4Dr7yv1DEpGUjoG7j32kHXeBClS7+NPAONrAOwz1L7+Ks0thnjdpV 7MrylUq0wu9/NamnAB1BvbdFqauqqXMKkZzgdKIYl+/kl4= X-Received: by 2002:a05:6a00:7484:b0:82f:4a4d:3792 with SMTP id d2e1a72fcca58-82f99814b42mr31000118b3a.4.1777214257392; Sun, 26 Apr 2026 07:37:37 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9d35acsm30061828b3a.15.2026.04.26.07.37.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 26 Apr 2026 07:37:36 -0700 (PDT) From: "=?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?=" X-Google-Original-From: =?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?= To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Ijae Kim Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Myeonghun Pak Subject: [PATCH] wifi: mt76: mt7925: clean up DMA on probe failure Date: Sun, 26 Apr 2026 23:33:36 +0900 Message-ID: <20260426143728.41534-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Myeonghun Pak mt7925_pci_probe() initializes DMA before registering the device. If mt7925_register_device() fails, probe returns through err_free_irq without tearing down DMA state. That leaves the TX NAPI instance enabled and skips the DMA queue cleanup that the normal remove path performs through mt7925e_unregister_device(). Add a dedicated unwind label for failures after mt7925_dma_init() succeeds. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt= 7925 chips") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/net/wireless/mediatek/mt76/mt7925/pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/pci.c b/drivers/net/= wireless/mediatek/mt76/mt7925/pci.c index c4161754c0..4883772302 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/pci.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/pci.c @@ -415,10 +415,12 @@ static int mt7925_pci_probe(struct pci_dev *pdev, =20 ret =3D mt7925_register_device(dev); if (ret) - goto err_free_irq; + goto err_free_dma; =20 return 0; =20 +err_free_dma: + mt792x_dma_cleanup(dev); err_free_irq: devm_free_irq(&pdev->dev, pdev->irq, dev); err_free_dev: --=20 2.39.5