From nobody Fri Jun 19 09:08:19 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F401286425 for ; Sat, 25 Apr 2026 16:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777133262; cv=none; b=SWDBJ/+SDRZXefv13jRtWhmKCBj7SRQnA82lRgmFzKw2tJ6ql+cpBCLP72Q+hBPzRceab0vEt1/odiyo/pWWGwCRErhEpy4Ws+v8aEzvdGIHcqWJQgyE9MC0YcHKen9uB/TRXDbi6Qwz2lRHRz6sL4V/JFnmKQVZm1BAGoFWuvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777133262; c=relaxed/simple; bh=KjIIBYWTn6p4BuyO0upgqtz3U+Oi6OBq7Ml4SOzFSuc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=YJpJ1J//CGuFX0pVMEFQGTBTomGdBBXG22yz6VCLfsiacCOZAnIfON/7sD+8uQum4nPrW4AYtb/zGdd14hjtFpUgFgWkI65ygsNtFxJtazCOhpNexYWcPLBbRk5GOp6/nUC8GJrlhFrMkbT4yaO6Y4gUISeAP0+GuQp/9mILMbs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dwnx4Kg4; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dwnx4Kg4" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35fc258aaa4so5566838a91.2 for ; Sat, 25 Apr 2026 09:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777133261; x=1777738061; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=iD/M1fyNXTAwfQKzUaSJw2dnydcQ7vF9bXiqIToJulA=; b=dwnx4Kg4oL3qsm8cQOj/jwHWPOd81knQl7YAhSXlCG/YsH//95lkIC5TV+mFDgeTM6 Cmre13h0OkpQTc80DBDNVeSFxGF0dP8PXSkXsdTjWPku8MT30n+KB2U594aXCIfngtq9 wPEnin3f6hFf7uN8Hs01x0lQptUEY07FjNTvjmXGu0ZAyXeWgEXwq7rpGEsdqsZ5lcAE aIQZk4UkHmGG8FAvX1As6tFHvZCQYz3ROG7r9v1voQWChNgTpJAvi64r9khNpqKZHGlI //vBKtdBc79EDGwaHpIEOVg34zWSbVJvKY06CCM1rXDmq5+EMFIlxt0FAk1f9Il1eBpK H9Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777133261; x=1777738061; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iD/M1fyNXTAwfQKzUaSJw2dnydcQ7vF9bXiqIToJulA=; b=Kn6bzpDxDU7/xZIe3BlpPJmV3KZdcm8jebvhpyIsbGUwQxsCWT+mXuxQGb9m57LHkZ nIlRJQV0MA+s1S7nUzPTPUYhLKyJDtBFiVLbbw4n9rjNyyHz4ir+8y/kNsmXDNzhfM5Q 69wXGc3b+Ru9Aj4NGY2Zd4p4M+hnzcFGuXmwW1U5N/G//g/qRinWDCfRSGZe1JknrPFp TDN7GFN4akHRnm4k+iLQPrx5vIha+E0/DVctvPbcCfqMYR7AUWNh4+KqL/ySG1z4TaGo DKC/UX2YRcnHCjECVMHlcM/CKQEXwnlsbCBtSvLUKrgXIVVhOQO61H1ZgUtrwJ1XJFOI MlMQ== X-Forwarded-Encrypted: i=1; AFNElJ/S449YrM9yn67kE5KMc+2t+ONVhgrAd4dy1/LerCOGMkJmFdce2MiIJdK+yuANi2MXo2mf3UNofxyS/hQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz86mSQGBofWg2zJ0w4oCRPYsnR5Qthetmdh/KR3j+xEXUhwlu1 XtgzvJSVP7/ceo19OrS4RU9WLsOA4pm4w9yLFOdukBVFzfB39eapHauFF51fp9+/gZA= X-Gm-Gg: AeBDiet5EsBGaNoKuLUIIrQk3oAriluT2nkdJflVVzGEACYOWlrdyQEV0cYVocNr10B HZhZWuy1Hv7rx7U6iDIhrw58+CgaNlUjFQiyUJtd1G0aLSHEuQZ9iezu1doMiVMOtoeOtnoUt7Z r+yHmXbg6GrdOjJCS0AOzCfkVYFckqklsSa3HiXDnN/9wRdtCjZhoJKBFgef7B2PRreNdjwa2Rs 5C0aVo755MkyAB4ZSszLlOmvBUTMBnQDAj/pVQAYLQP3eCm9l9HuWQmjroW1TwisilLyov/TbUN h5xUp3lVryNPNOaCoQNXv3LEnKP8orl0H3F2qe5S4h60Ag139CtcLp0i9M4iEXLtt2l1x3/Ju21 r5BT+eT4my79AufHPPiYBa+VvERhgZUgHNvsmHkm5TFkwWNopgZBcuLsfSDH6AcH8fdo9HY+yVD aKruPkt7Ey/ogt/REp78LVx/mxzjX3FHTve4qF5N5NsyC4FkLLnD/kW2hsev/UewT5Vni3Q0SzT gzgrZWM3Lxni3Sw7WERnLNV4hgFalU9eIIrISPh8Q== X-Received: by 2002:a17:90b:35d2:b0:35f:bbc0:e570 with SMTP id 98e67ed59e1d1-36140228e16mr38201383a91.0.1777133260516; Sat, 25 Apr 2026 09:07:40 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7976f8f3e5sm21431182a12.5.2026.04.25.09.07.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 09:07:40 -0700 (PDT) From: Felix Gu Date: Sun, 26 Apr 2026 00:07:24 +0800 Subject: [PATCH] iio: adc: meson-saradc: fix calibration buffer leak on error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260426-meson_saradc-v1-1-6e96b2982c43@gmail.com> X-B4-Tracking: v=1; b=H4sIALvm7GkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDEyNT3dzU4vy8+OLEosSUZF1Tk8SkZFOjFMskY0MloJaCotS0zAqwcdG xtbUA8wWlq14AAAA= X-Change-ID: 20260425-meson_saradc-54abc52d9b31 To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rosen Penev Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777133256; l=2229; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=KjIIBYWTn6p4BuyO0upgqtz3U+Oi6OBq7Ml4SOzFSuc=; b=Vjn5Dax+7/hZTXWQgOoS9q3jBjBGAaFI0EgVquwXjkkRPefUzhwtIOndDXMCrGBT4d0Tqueia Q0c34yJMIvXARu6F1W6/gneXeBQgC3XHQ9lvOdScnQGncIwqotb2Oua X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= meson_sar_adc_temp_sensor_init() allocates a buffer with nvmem_cell_read(), but the old code leaked it if syscon_regmap_lookup_by_phandle() failed. Switch buf to __free(kfree) so all return paths release it. Fixes: d6f2eac64403 ("iio: adc: meson: no devm for nvmem_cell_get") Signed-off-by: Felix Gu Reviewed-by: David Lechner --- drivers/iio/adc/meson_saradc.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c index 23991a3612bd..9708ddcc4919 100644 --- a/drivers/iio/adc/meson_saradc.c +++ b/drivers/iio/adc/meson_saradc.c @@ -786,7 +786,7 @@ static int meson_sar_adc_clk_init(struct iio_dev *indio= _dev, static int meson_sar_adc_temp_sensor_init(struct iio_dev *indio_dev) { struct meson_sar_adc_priv *priv =3D iio_priv(indio_dev); - u8 *buf, trimming_bits, trimming_mask, upper_adc_val; + u8 trimming_bits, trimming_mask, upper_adc_val; struct device *dev =3D indio_dev->dev.parent; struct nvmem_cell *temperature_calib; size_t read_len; @@ -807,14 +807,12 @@ static int meson_sar_adc_temp_sensor_init(struct iio_= dev *indio_dev) } =20 read_len =3D MESON_SAR_ADC_EFUSE_BYTES; - buf =3D nvmem_cell_read(temperature_calib, &read_len); + u8 *buf __free(kfree) =3D nvmem_cell_read(temperature_calib, &read_len); nvmem_cell_put(temperature_calib); if (IS_ERR(buf)) return dev_err_probe(dev, PTR_ERR(buf), "failed to read temperature_cali= b cell\n"); - if (read_len !=3D MESON_SAR_ADC_EFUSE_BYTES) { - kfree(buf); + if (read_len !=3D MESON_SAR_ADC_EFUSE_BYTES) return dev_err_probe(dev, -EINVAL, "invalid read size of temperature_cal= ib cell\n"); - } =20 priv->tsc_regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "amlog= ic,hhi-sysctrl"); if (IS_ERR(priv->tsc_regmap)) @@ -835,8 +833,6 @@ static int meson_sar_adc_temp_sensor_init(struct iio_de= v *indio_dev) priv->temperature_sensor_adc_val |=3D upper_adc_val << BITS_PER_BYTE; priv->temperature_sensor_adc_val >>=3D trimming_bits; =20 - kfree(buf); - return 0; } =20 --- base-commit: 7080e32d3f09d8688c4a87d81bdcc71f7f606b16 change-id: 20260425-meson_saradc-54abc52d9b31 Best regards, --=20 Felix Gu