From nobody Fri Jun 19 09:06:01 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B38A881724 for ; Sat, 25 Apr 2026 13:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777124148; cv=none; b=SlmY48+mcCrzcrCJxP8du4wiDAkktxPRKk+DitT0+Aaxm1/l42nFqMjnz3Z+mcz1e+x8jJgKXynHN8kwprDPoeB3JhSYHPZPxfiUJ7zsDiYLQMgIytdWpjAuU6BLDncnVdCbLmwVpm9xM3zuukXUzCXe4slsrdP/vTFndCDDv60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777124148; c=relaxed/simple; bh=ZpnFegTD+b8erEgnp2IeU0Ys9ggP2EiX+kvTM6f6nc4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QTrCU/5oMKruRS/ObVqAGDMiItGJZM+SHwMoPBAtjszB9h35C1+Q8ziAiz47deE3vJAmSw6KLkd77losqtkAWDPvinyQ+lU18Ny+/gANYTobM+WAeu1p4CwWIQ+1tHDFFJmiU0M0IkP+x+f2M3YRo+c16os3RnH8OGxA0w4t7RQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pQl97rL+; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pQl97rL+" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35fb166b0c6so4788422a91.0 for ; Sat, 25 Apr 2026 06:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777124147; x=1777728947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vpwIC0RWNTe0eNIqJqmJM6/NO7cdVeVw+YILoj5Qmpc=; b=pQl97rL+TyiCP+E87KlK2sHOlQgm7kUbEXOj7Z+ZOg73GqHb8Dtx6z7t7VeEvgbe5U sb8s6LVrfLpyDX/xm6qimZO4CRMRvKSxgYfm32Uf5ADBDTDh3tQQKFJFp/NJ9CqQvZV4 +x9HsJou7K9pzeQWa6Fx2YQc7Poli5rva4E+TAVIypYIBVKDFcEbz7Of5uOW3FljqcRM BYUucXmsz3bngl/OOgZYYcEcFRkpBc1axgvwuQrTBBlFQj9ZuC1/cf7/oZCICfHJ+SpR WYUknS6K1xH1hzPBhvk68CiD700/+ZmbJ6cHFy/snztuMWOqTOT3keNyYEFycsAmqHmE PMOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777124147; x=1777728947; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vpwIC0RWNTe0eNIqJqmJM6/NO7cdVeVw+YILoj5Qmpc=; b=cqd3FEz2gEqu7SHwWWAWZ90FVjaxWT8E0qjCpeHpt6adEhNIRgSDRltut7dG2QLa0R wMyzhsFM0XT4ZYvAfeNF/I5CyWafVRppEerEb447h8QScjX73dTjHWrqiPWecbtpMOTl Q/8AwWshOC3bCC3Rx4NbAr6X7wWvm/AH6rgPAAswV76xLYDoO+Hxt+uPF6TZ5OvJ6p4S S9ONS2oy6mrtZg03XP/Nf4xfEg6RiBniBieIK9QI+m1lIfMF/clRbn1jEaSeBLunzMgA 1yUxhpXXiIbfevsSBdAZUsMLZxcU1vUa6gWqGNhoEGbUtsL6UO07GzVr9y3e9VQw4ntC Sk2Q== X-Forwarded-Encrypted: i=1; AFNElJ+olAn5DP0xvwuJx7DS47KzBXwqPk0wVOlL6KIOrp6B+WPFb/Ft5y0RHohTCEPJXHZvQvipx56xs8o9bwk=@vger.kernel.org X-Gm-Message-State: AOJu0YxRqG/thfx49l0VG3JeDdgYfui1pyt1EWiMHrjiGWUzLGvkn66O sGuHssJDa9owExHuA4qU+3wUkZ00Scu9r+xU2tkQUqNst9m7sFnNXuSY X-Gm-Gg: AeBDietwEtLK3Pk4PDzE/V5zpmmg6ls2vXVLyNBJRvSou7YzXUtXdJ173kvwhHD7jqv NqCFoMdt5YuqRL9KrZGLWyf/WGiT3nXr6A2NJqEaVrM8d9vEoSPE6r88M/y6oMrsTOreFTES8bJ nsw5FIWf6gSQVj1+eodVRKfvIBNCZkWA0URRxm6QzElaJ3pubeC0ejWwKuHkXu4gZH09eQKRYla Q0HXBzr6a0V9E2Pm0dWvRF/T3Yv2Ns3AeTg7Cb+wAIenNzshb9ivak051z6hwmmCoMxGDebs2Oo fqRAYK+GF3nsN7HTtPgzb5dnP+cS2Lh/uz3+RyTeY5NfFFx7xukSH+xtasrE/Ydu7QsF9WeLaWl tAJn6bPMXKUZmOgxex+Gkpv84PIgu9H6g4vTX70mkreuNa0fo3gAObokDyuZrt/LUsttK7jMJoK DpFjRoq1IBplkJVOTWJ+YOTY1Ctcyn6bkZ7VlZMzHavK1E+Z4KBPJb6UvI X-Received: by 2002:a17:903:1110:b0:2b4:636b:dc4f with SMTP id d9443c01a7336-2b5f9e950a0mr312507355ad.15.1777124146754; Sat, 25 Apr 2026 06:35:46 -0700 (PDT) Received: from tech-Alienware-m15-R6.. ([122.171.21.105]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab4cc47sm259868065ad.82.2026.04.25.06.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 06:35:46 -0700 (PDT) From: Sunny Patel To: Andrew Morton , David Hildenbrand Cc: Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sunny Patel Subject: [PATCH] mm/migrate_device: fix spinlock leak in migrate_vma_insert_huge_pmd_page Date: Sat, 25 Apr 2026 19:05:27 +0530 Message-ID: <20260425133537.17463-1-nueralspacetech@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When check_stable_address_space() fails after the PMD spinlock has been acquired via pmd_lock(), the code jumps directly to the abort label, bypassing the spin_unlock() call in unlock_abort. This causes the PMD spinlock to be permanently held, leading to a deadlock. Change the goto target from abort to unlock_abort to ensure the spinlock is always released on this error path. Signed-off-by: Sunny Patel Acked-by: Balbir Singh Acked-by: David Hildenbrand (Arm) Acked-by: Zi Yan --- mm/migrate_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/migrate_device.c b/mm/migrate_device.c index fbfe5715f635..ab49d4dcdb60 100644 --- a/mm/migrate_device.c +++ b/mm/migrate_device.c @@ -850,7 +850,7 @@ static int migrate_vma_insert_huge_pmd_page(struct migr= ate_vma *migrate, ptl =3D pmd_lock(vma->vm_mm, pmdp); csa_ret =3D check_stable_address_space(vma->vm_mm); if (csa_ret) - goto abort; + goto unlock_abort; =20 /* * Check for userfaultfd but do not deliver the fault. Instead, --=20 2.43.0