From nobody Sun Jun 21 09:11:30 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D249C35C1A2 for ; Sat, 25 Apr 2026 11:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777116230; cv=none; b=SBTGhUNk8hl31SVdHW96ydrmYEZVtAH93tv9pc1QB1wEw5KtoTj3IdNz+aHrWtnqFjpdZrmdXmuEoBUm8PN5xCtJsp1E8gyMLNAUDdnSu1QIllgFWlW6e0Ekof6nXWmzgYDg0Zo9/tWRBUi34ePbmXBJhMgDq0O47Ag2Xb7RAfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777116230; c=relaxed/simple; bh=Nd2YpYXkYwsT9Hqnikd//G9zwL81moaGyRyEtae5hzE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V2IBF2S0D1XUOBAOMGyTV8a6XFEbUnbhmKbWtzmxQZLVKUAHFK2IyJmnVRq8FDwUylXH6U1iKqSLjWAl3QFFjqx+jMKsbomtOsD1W/IJEwpjmkMn73EeRrKpIORrSlcmwJQPWs7x5bJBqyTDudfC14kGpGQe/sR4ZOeF0vaUa7Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A3sIAHjt; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A3sIAHjt" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-362bb3260f1so3703924a91.2 for ; Sat, 25 Apr 2026 04:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777116228; x=1777721028; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EC5GCYSicRRMb4FQaPYtSGQC3GW6bBL73dVA9vXac2I=; b=A3sIAHjtCaWxWgrqmrmk1hoAxIBxHni7/tX9enOlsg5FOeDeGqQtFXicZtgDFvG2SJ L6A2QHyHZXWKsbKEGraNQqBMr5SQV2mesMOBgPDCyaJq3/4x5fBRQHq/s9HDpDTHxrJx 5UqMM8VefpIP1K/wmnAFvSH0MR5Ef+GEBrcU0dT/uOfjimVjEUusQZMrsuVer9cjP+RC phSFGqSeM7ujBLPswrxv2vkh7edmgxo5knnjruHmg1Zr5mCnFhX77j7FYFLf38BEAQ1H bo5xJycfA1dfFWtmaf2D5sBEMgf/yPX59OFP/IXQc8XARmMqQxcdh4NES7WCsCC8RQe8 U+Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777116228; x=1777721028; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EC5GCYSicRRMb4FQaPYtSGQC3GW6bBL73dVA9vXac2I=; b=Fv0J/9NA0jo4HhMj61TigPWP7qabWipOmS9Pb+7l5QycSHMsdIJlVnldmI7dOjkO6p qNaVS8Y+cE2c4XwRvDpwxk0UtLwilvZmKBeIKCUp6nQfyShTy+avEJfDUour2fWpWr7V wEO4ORj7qK662vgWFSWTelku9au5pSW1DBI0SeS5obQ/rOIAnzlaMXR03+4gMpSDYu5u BtcL1aDgmAgCmzZplo76OBkUtGLdtmp3f4Y8ImTNeGCSlBxFt7x0P4ZHlt7wwtyqJuy5 jxGbYwhZvrH/sTrBaouZ3Bh8m7dAwv7azwPxzjY0TYn9oWPG7Sea2KgdQtFmPJCcH0Sj 40xw== X-Forwarded-Encrypted: i=1; AFNElJ/3qgimKz+cJJBXZfHv5MvENCZNBiBKlSiq9H8W39EsVeYi+PPlbW2Iwgxgt6OdxQLKUk43FiU0Bm5vY70=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn0ydawpYYNUn0L/0xm49JjXcuk3vfCJ+G+JPlOVNeuBfFsMNu 8fFozC9QIrIToLIM3FCkkeh9QHdVUSzKrHifxqLT6Zkp/KbNdtJnYL5MywNraAJkpf28oA== X-Gm-Gg: AeBDievroKpj1SHE5QgIaja/CsRBohPbNuf++Y2CrlvdePgI6D3KXtUGSmdI8b8JVjb GFdozGPEjYBHlaujav7d488CNQgyVOX7tEIw3Sw2qh8ZGvw2HEofPdVnygMbL+ZNRZb9wpgeRcT F6Ub+8WPDteWIqHEd16ZM8gDvc6vShY4D0G2v3Tsnc2RyxEA1PGh55wK2BWraHODw8JEM2XEuf5 8PJJCmwLbKX2JZhEaHmKXqr0pMfOqtD3Of6UvG3wr3oUh5F+H+gIfTwx1FxjD5F+ZYlOqpUjuyW RPqwzf2xrx6igvz93RP84QoVse7AfNRaP1PQMo/b7gtqvPriI2jzsyxskQ5/yQ6XrwkVyG4sm7H gZU2gsmYWdt1mYoj0fN7194Xu5q5aoArdF/Hlpn31jc1PZZSeElwtPqCwc5jFD7yJrw9eGrV0ME MdXCmTPpMZ1NRAZphd0naL06NXByuIO18tYBM1P5lOLOWKg/XrF6rEpvFrHNobWy0jbA== X-Received: by 2002:a17:90b:55cf:b0:35d:9c43:57fe with SMTP id 98e67ed59e1d1-3614046583dmr36594785a91.13.1777116227957; Sat, 25 Apr 2026 04:23:47 -0700 (PDT) Received: from mohammed-rizwan-HP-Laptop-15-bs1xx.. ([2406:7400:63:37af:8b14:a97e:deba:1a93]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614195a9f0sm25727999a91.9.2026.04.25.04.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 04:23:47 -0700 (PDT) From: Mohammed Rizwan Kaniyate To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Mohammed Rizwan Kaniyate Subject: [PATCH] staging: rtl8723bs: remove multiple blank lines in core/ Date: Sat, 25 Apr 2026 16:53:27 +0530 Message-ID: <20260425112327.215355-1-mrizwank004@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove multiple consecutive blank lines. Issue reported by checkpatch.pl Signed-off-by: Mohammed Rizwan Kaniyate Reviewed-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 1 - drivers/staging/rtl8723bs/core/rtw_efuse.c | 1 - .../staging/rtl8723bs/core/rtw_ioctl_set.c | 1 - drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 48 ------------------- drivers/staging/rtl8723bs/core/rtw_recv.c | 25 ---------- .../staging/rtl8723bs/core/rtw_wlan_util.c | 1 - 6 files changed, 77 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/= rtl8723bs/core/rtw_btcoex.c index 0191a943f..27dfd00b4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c @@ -65,7 +65,6 @@ void rtw_btcoex_LPS_Leave(struct adapter *padapter) { struct pwrctrl_priv *pwrpriv; =20 - pwrpriv =3D adapter_to_pwrctl(padapter); =20 if (pwrpriv->pwr_mode !=3D PS_MODE_ACTIVE) { diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 099320e4e..0cd7ce242 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -232,7 +232,6 @@ void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8= efuseType) /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */ } /* EFUSE_ShadowMapUpdate */ =20 - /*------------------------------------------------------------------------= ----- * Function: EFUSE_ShadowRead * diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index c70541f95..32c0af6af 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -340,7 +340,6 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *p= adapter, return true; } =20 - u8 rtw_set_802_11_disassociate(struct adapter *padapter) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 5f00fe282..6e149f166 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -520,7 +520,6 @@ unsigned int OnProbeReq(struct adapter *padapter, union= recv_frame *precv_frame) p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _PROBEREQ_IE_OFFSET_, WLAN_EI= D_SSID, (int *)&ielen, len - WLAN_HDR_A3_LEN - _PROBEREQ_IE_OFFSET_); =20 - /* check (wildcard) SSID */ if (p) { if (is_valid_p2p_probereq) @@ -773,7 +772,6 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) if (pstat->auth_seq =3D=3D 0) pstat->expire_to =3D pstapriv->auth_to; =20 - if ((pstat->auth_seq + 1) !=3D seq) { status =3D WLAN_STATUS_UNKNOWN_AUTH_TRANSACTION; goto auth_fail; @@ -822,7 +820,6 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) } } =20 - /* Now, we are going to issue_auth... */ pstat->auth_seq =3D seq + 1; =20 @@ -831,7 +828,6 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) if (pstat->state & WIFI_FW_AUTH_SUCCESS) pstat->auth_seq =3D 0; =20 - return _SUCCESS; =20 auth_fail: @@ -958,7 +954,6 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) else /* WIFI_REASSOCREQ */ ie_offset =3D _REASOCREQ_IE_OFFSET_; =20 - if (pkt_len < sizeof(struct ieee80211_hdr_3addr) + ie_offset) return _FAIL; =20 @@ -988,7 +983,6 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) pstat->state |=3D WIFI_FW_ASSOC_STATE; } =20 - pstat->capability =3D capab_info; =20 /* now parse all ieee802_11 ie to point to elems */ @@ -1124,7 +1118,6 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) else pstat->flags |=3D WLAN_STA_MAYBE_WPS; =20 - /* AP support WPA/RSN, and sta is going to do WPS, but AP is not ready = */ /* that the selected registrar of AP is _FLASE */ if ((psecuritypriv->wpa_psk > 0) @@ -1159,13 +1152,11 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) copy_len =3D min(sizeof(pstat->wpa_ie), wpa_ie_len + 2u); } =20 - if (copy_len > 0) memcpy(pstat->wpa_ie, wpa_ie-2, copy_len); =20 } =20 - /* check if there is WMM IE & support WWM-PS */ pstat->flags &=3D ~WLAN_STA_WME; pstat->qos_option =3D 0; @@ -1238,13 +1229,11 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) } else pstat->flags &=3D ~WLAN_STA_HT; =20 - if ((pmlmepriv->htpriv.ht_option =3D=3D false) && (pstat->flags&WLAN_STA_= HT)) { status =3D WLAN_STATUS_CHALLENGE_FAIL; goto OnAssocReqFail; } =20 - if ((pstat->flags & WLAN_STA_HT) && ((pstat->wpa2_pairwise_cipher&WPA_CIPHER_TKIP) || (pstat->wpa_pairwise_cipher&WPA_CIPHER_TKIP))) { @@ -1285,13 +1274,11 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) =20 goto OnAssocReqFail; =20 - } else { pstapriv->sta_aid[pstat->aid - 1] =3D pstat; } } =20 - pstat->state &=3D (~WIFI_FW_ASSOC_STATE); pstat->state |=3D WIFI_FW_ASSOC_SUCCESS; =20 @@ -1485,7 +1472,6 @@ unsigned int OnDeAuth(struct adapter *padapter, union= recv_frame *precv_frame) associated_clients_update(padapter, updated); } =20 - return _SUCCESS; } =20 @@ -2115,7 +2101,6 @@ void issue_beacon(struct adapter *padapter, int timeo= ut_ms) pframe =3D (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; pwlanhdr =3D (struct ieee80211_hdr *)pframe; =20 - fctrl =3D &(pwlanhdr->frame_control); *(fctrl) =3D 0; =20 @@ -2204,12 +2189,10 @@ void issue_beacon(struct adapter *padapter, int tim= eout_ms) pframe =3D rtw_set_ie(pframe, WLAN_EID_ERP_INFO, 1, &erpinfo, &pattrib->= pktlen); } =20 - /* EXTERNDED SUPPORTED RATE */ if (rate_len > 8) pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (rate_len - 8), (= cur_network->supported_rates + 8), &pattrib->pktlen); =20 - /* todo:HT for adhoc */ =20 _issue_bcn: @@ -2281,7 +2264,6 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p pattrib->pktlen =3D pattrib->hdrlen; pframe +=3D pattrib->hdrlen; =20 - if (cur_network->ie_length > MAX_IE_SZ) return; =20 @@ -2405,19 +2387,16 @@ void issue_probersp(struct adapter *padapter, unsig= ned char *da, u8 is_valid_p2p pframe =3D rtw_set_ie(pframe, WLAN_EID_ERP_INFO, 1, &erpinfo, &pattrib-= >pktlen); } =20 - /* EXTERNDED SUPPORTED RATE */ if (rate_len > 8) pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (rate_len - 8), = (cur_network->supported_rates + 8), &pattrib->pktlen); =20 - /* todo:HT for adhoc */ =20 } =20 pattrib->last_txcmdsz =3D pattrib->pktlen; =20 - dump_mgntframe(padapter, pmgntframe); =20 return; @@ -2449,7 +2428,6 @@ static int _issue_probereq(struct adapter *padapter, pattrib =3D &pmgntframe->attrib; update_mgntframe_attrib(padapter, pattrib); =20 - memset(pmgntframe->buf_addr, 0, WLANHDR_OFFSET + TXDESC_OFFSET); =20 pframe =3D (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; @@ -2593,7 +2571,6 @@ void issue_auth(struct adapter *padapter, struct sta_= info *psta, unsigned short pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); =20 - if (psta) { /* for AP mode */ memcpy(pwlanhdr->addr1, psta->hwaddr, ETH_ALEN); memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); @@ -2654,7 +2631,6 @@ void issue_auth(struct adapter *padapter, struct sta_= info *psta, unsigned short le_tmp =3D cpu_to_le16(pmlmeinfo->auth_seq); pframe =3D rtw_set_fixed_ie(pframe, _AUTH_SEQ_NUM_, (unsigned char *)&le= _tmp, &(pattrib->pktlen)); =20 - /* setting status code... */ le_tmp =3D cpu_to_le16(status); pframe =3D rtw_set_fixed_ie(pframe, _STATUS_CODE_, (unsigned char *)&le_= tmp, &(pattrib->pktlen)); @@ -2683,7 +2659,6 @@ void issue_auth(struct adapter *padapter, struct sta_= info *psta, unsigned short dump_mgntframe(padapter, pmgntframe); } =20 - void issue_asocrsp(struct adapter *padapter, unsigned short status, struct= sta_info *pstat, int pkt_type) { struct xmit_frame *pmgntframe; @@ -2708,7 +2683,6 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i pattrib =3D &pmgntframe->attrib; update_mgntframe_attrib(padapter, pattrib); =20 - memset(pmgntframe->buf_addr, 0, WLANHDR_OFFSET + TXDESC_OFFSET); =20 pframe =3D (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET; @@ -2721,7 +2695,6 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i memcpy(GetAddr2Ptr(pwlanhdr), myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(GetAddr3Ptr(pwlanhdr), get_my_bssid(&(pmlmeinfo->network)), ETH_AL= EN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; if ((pkt_type =3D=3D WIFI_ASSOCRSP) || (pkt_type =3D=3D WIFI_REASSOCRSP)) @@ -2880,7 +2853,6 @@ void issue_assocreq(struct adapter *padapter) if (pmlmeext->cur_channel =3D=3D 14) /* for JAPAN, channel 14 can only u= ses B Mode(CCK) */ sta_bssrate_len =3D 4; =20 - /* for (i =3D 0; i < sta_bssrate_len; i++) { */ /* */ =20 @@ -2889,12 +2861,10 @@ void issue_assocreq(struct adapter *padapter) break; } =20 - for (i =3D 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) { if (pmlmeinfo->network.supported_rates[i] =3D=3D 0) break; =20 - /* Check if the AP's supported rates are also supported by STA. */ for (j =3D 0; j < sta_bssrate_len; j++) { /* Avoid the proprietary data rate (22Mbps) of Handlink WSG-4000 AP */ @@ -2916,7 +2886,6 @@ void issue_assocreq(struct adapter *padapter) goto exit; /* don't connect to AP if no joint supported rate */ } =20 - if (bssrate_len > 8) { pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, 8, bssrate, &(pattrib= ->pktlen)); pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (bssrate_len - 8)= , (bssrate + 8), &(pattrib->pktlen)); @@ -2973,7 +2942,6 @@ void issue_assocreq(struct adapter *padapter) if (pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_REALTEK) pframe =3D rtw_set_ie(pframe, WLAN_EID_VENDOR_SPECIFIC, 6, REALTEK_96B_I= E, &(pattrib->pktlen)); =20 - pattrib->last_txcmdsz =3D pattrib->pktlen; dump_mgntframe(padapter, pmgntframe); =20 @@ -3070,7 +3038,6 @@ int issue_nulldata(struct adapter *padapter, unsigned= char *da, unsigned int pow struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; struct sta_info *psta; =20 - /* da =3D=3D NULL, assume it's null data for sta to ap*/ if (!da) da =3D get_my_bssid(&(pmlmeinfo->network)); @@ -3120,7 +3087,6 @@ s32 issue_nulldata_in_interrupt(struct adapter *padap= ter, u8 *da) struct mlme_ext_priv *pmlmeext; struct mlme_ext_info *pmlmeinfo; =20 - pmlmeext =3D &padapter->mlmeextpriv; pmlmeinfo =3D &pmlmeext->mlmext_info; =20 @@ -3289,7 +3255,6 @@ static int _issue_deauth(struct adapter *padapter, un= signed char *da, =20 pattrib->last_txcmdsz =3D pattrib->pktlen; =20 - if (wait_ack) { ret =3D dump_mgntframe_and_wait_ack(padapter, pmgntframe); } else { @@ -3611,7 +3576,6 @@ static void issue_action_BSSCoexistPacket(struct adap= ter *padapter) pframe =3D rtw_set_fixed_ie(pframe, 1, &(category), &(pattrib->pktlen)); pframe =3D rtw_set_fixed_ie(pframe, 1, &(action), &(pattrib->pktlen)); =20 - /* */ if (pmlmepriv->num_FortyMHzIntolerant > 0) { u8 iedata =3D 0; @@ -3622,7 +3586,6 @@ static void issue_action_BSSCoexistPacket(struct adap= ter *padapter) =20 } =20 - /* */ memset(ICS, 0, sizeof(ICS)); if (pmlmepriv->num_sta_no_ht > 0) { @@ -3663,7 +3626,6 @@ static void issue_action_BSSCoexistPacket(struct adap= ter *padapter) =20 spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); =20 - for (i =3D 0; i < 8; i++) { int j, k =3D 0; =20 @@ -3691,7 +3653,6 @@ static void issue_action_BSSCoexistPacket(struct adap= ter *padapter) =20 } =20 - pattrib->last_txcmdsz =3D pattrib->pktlen; =20 dump_mgntframe(padapter, pmgntframe); @@ -4170,7 +4131,6 @@ void start_clnt_auth(struct adapter *padapter) pmlmeinfo->link_count =3D 0; pmlmeext->retry =3D 0; =20 - netdev_dbg(padapter->pnetdev, "start auth\n"); issue_auth(padapter, NULL, 0); =20 @@ -4178,7 +4138,6 @@ void start_clnt_auth(struct adapter *padapter) =20 } =20 - void start_clnt_assoc(struct adapter *padapter) { struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; @@ -4225,7 +4184,6 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid u8 channel; u8 i; =20 - pregistrypriv =3D &padapter->registrypriv; pmlmeext =3D &padapter->mlmeextpriv; =20 @@ -4505,10 +4463,8 @@ void report_join_res(struct adapter *padapter, int r= es) memcpy((unsigned char *)(&(pjoinbss_evt->network.network)), &(pmlmeinfo->= network), sizeof(struct wlan_bssid_ex)); pjoinbss_evt->network.join_res =3D pjoinbss_evt->network.aid =3D res; =20 - rtw_joinbss_event_prehandle(padapter, (u8 *)&pjoinbss_evt->network); =20 - rtw_enqueue_cmd(pcmdpriv, pcmd_obj); =20 return; @@ -4600,7 +4556,6 @@ void report_del_sta_event(struct adapter *padapter, u= nsigned char *MacAddr, unsi memcpy((unsigned char *)(&(pdel_sta_evt->macaddr)), MacAddr, ETH_ALEN); memcpy((unsigned char *)(pdel_sta_evt->rsvd), (unsigned char *)(&reason),= 2); =20 - psta =3D rtw_get_stainfo(&padapter->stapriv, MacAddr); if (psta) mac_id =3D (int)psta->mac_id; @@ -4784,7 +4739,6 @@ void mlmeext_joinbss_event_callback(struct adapter *p= adapter, int join_res) /* update bc/mc sta_info */ update_bmc_sta(padapter); =20 - /* turn on dynamic functions */ Switch_DM_Func(padapter, DYNAMIC_ALL_FUNC_ENABLE, true); =20 @@ -5097,7 +5051,6 @@ void link_timer_hdl(struct timer_list *t) struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 - if (pmlmeinfo->state & WIFI_FW_AUTH_NULL) { pmlmeinfo->state =3D WIFI_FW_NULL_STATE; report_join_res(padapter, -3); @@ -5283,7 +5236,6 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf) /* set_msr(padapter, _HW_STATE_NOLINK_); */ set_msr(padapter, _HW_STATE_STATION_); =20 - rtw_hal_set_hwreg(padapter, HW_VAR_MLME_DISCONNECT, NULL); } =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index f78194d50..e81fcfe88 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -60,7 +60,6 @@ signed int _rtw_init_recv_priv(struct recv_priv *precvpri= v, struct adapter *pada =20 precvframe =3D (union recv_frame *) precvpriv->precv_frame_buf; =20 - for (i =3D 0; i < NR_RECVFRAME; i++) { INIT_LIST_HEAD(&(precvframe->u.list)); =20 @@ -180,9 +179,6 @@ int rtw_free_recvframe(union recv_frame *precvframe, st= ruct __queue *pfree_recv_ return _SUCCESS; } =20 - - - signed int _rtw_enqueue_recvframe(union recv_frame *precvframe, struct __q= ueue *queue) { =20 @@ -192,7 +188,6 @@ signed int _rtw_enqueue_recvframe(union recv_frame *pre= cvframe, struct __queue * /* INIT_LIST_HEAD(&(precvframe->u.hdr.list)); */ list_del_init(&(precvframe->u.hdr.list)); =20 - list_add_tail(&(precvframe->u.hdr.list), get_list_head(queue)); =20 if (padapter) @@ -257,7 +252,6 @@ u32 rtw_free_uc_swdec_pending_queue(struct adapter *ada= pter) return cnt; } =20 - signed int rtw_enqueue_recvbuf_to_head(struct recv_buf *precvbuf, struct _= _queue *queue) { spin_lock_bh(&queue->lock); @@ -405,7 +399,6 @@ static signed int recvframe_chkmic(struct adapter *adap= ter, union recv_frame *p bmic_err =3D true; } =20 - if (bmic_err =3D=3D true) { /* double check key_index for some timing issue , */ /* cannot compare with psecuritypriv->dot118021XGrpKeyid also cause t= iming issue */ @@ -772,8 +765,6 @@ static signed int sta2sta_data_frame(struct adapter *ad= apter, union recv_frame * } else ret =3D _FAIL; =20 - - if (bmcast) *psta =3D rtw_get_bcmc_stainfo(adapter); else @@ -817,7 +808,6 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p goto exit; } =20 - /* check BSSID */ if (is_zero_ether_addr(pattrib->bssid) || is_zero_ether_addr(mybssid) || @@ -858,14 +848,12 @@ static signed int ap2sta_data_frame(struct adapter *a= dapter, union recv_frame *p /* */ memcpy(pattrib->bssid, mybssid, ETH_ALEN); =20 - *psta =3D rtw_get_stainfo(pstapriv, pattrib->bssid); /* get sta_info */ if (!*psta) { ret =3D _FAIL; goto exit; } =20 - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { /* Special case */ ret =3D RTW_RX_HANDLED; @@ -1109,7 +1097,6 @@ static union recv_frame *recvframe_defrag(struct adap= ter *adapter, pnextrframe =3D (union recv_frame *)plist; pnfhdr =3D &pnextrframe->u.hdr; =20 - /* check the fragment sequence (2nd ~n fragment frame) */ =20 if (curfragnum !=3D pnfhdr->attrib.frag_num) { @@ -1197,7 +1184,6 @@ static union recv_frame *recvframe_chk_defrag(struct = adapter *padapter, union re /* free current defrag_q */ rtw_free_recvframe_queue(pdefrag_q, pfree_recv_queue); =20 - /* Then enqueue the 0~(n-1) fragment into the defrag_q */ =20 /* spin_lock(&pdefrag_q->lock); */ @@ -1236,7 +1222,6 @@ static union recv_frame *recvframe_chk_defrag(struct = adapter *padapter, union re =20 } =20 - if ((prtnframe) && (prtnframe->u.hdr.attrib.privacy)) { /* after defrag we must check tkip mic code */ if (recvframe_chkmic(padapter, prtnframe) =3D=3D _FAIL) { @@ -1349,7 +1334,6 @@ static signed int validate_recv_data_frame(struct ada= pter *adapter, union recv_f if (ret =3D=3D _FAIL || ret =3D=3D RTW_RX_HANDLED) goto exit; =20 - if (!psta) { ret =3D _FAIL; goto exit; @@ -1359,7 +1343,6 @@ static signed int validate_recv_data_frame(struct ada= pter *adapter, union recv_f /* psta->signal_quality =3D prxcmd->sq; */ precv_frame->u.hdr.psta =3D psta; =20 - pattrib->amsdu =3D 0; pattrib->ack_policy =3D 0; /* parsing QC field */ @@ -1377,7 +1360,6 @@ static signed int validate_recv_data_frame(struct ada= pter *adapter, union recv_f pattrib->hdrlen =3D pattrib->to_fr_ds =3D=3D 3 ? 30 : 24; } =20 - if (pattrib->order)/* HT-CTRL 11n */ pattrib->hdrlen +=3D 4; =20 @@ -1827,7 +1809,6 @@ static int enqueue_reorder_recvframe(struct recv_reor= der_ctrl *preorder_ctrl, un /* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */ /* spin_lock(&ppending_recvframe_queue->lock); */ =20 - phead =3D get_list_head(ppending_recvframe_queue); plist =3D get_next(phead); =20 @@ -1846,7 +1827,6 @@ static int enqueue_reorder_recvframe(struct recv_reor= der_ctrl *preorder_ctrl, un =20 } =20 - /* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */ /* spin_lock(&ppending_recvframe_queue->lock); */ =20 @@ -1962,7 +1942,6 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor /* error condition; */ } =20 - /* Update local variables. */ bPktInBuf =3D false; =20 @@ -2037,7 +2016,6 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * goto _err_exit; } =20 - /* s4. */ /* Indication process. */ /* After Packet dropping and Sliding Window shifting as above, we can no= w just indicate the packets */ @@ -2065,7 +2043,6 @@ static int recv_indicatepkt_reorder(struct adapter *p= adapter, union recv_frame * return _FAIL; } =20 - void rtw_reordering_ctrl_timeout_handler(struct timer_list *t) { struct recv_reorder_ctrl *preorder_ctrl =3D @@ -2073,7 +2050,6 @@ void rtw_reordering_ctrl_timeout_handler(struct timer= _list *t) struct adapter *padapter =3D preorder_ctrl->padapter; struct __queue *ppending_recvframe_queue =3D &preorder_ctrl->pending_recv= frame_queue; =20 - if (padapter->bDriverStopped || padapter->bSurpriseRemoved) return; =20 @@ -2221,7 +2197,6 @@ static int recv_func(struct adapter *padapter, union = recv_frame *rframe) return ret; } =20 - s32 rtw_recv_entry(union recv_frame *precvframe) { struct adapter *padapter; diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4..cc8c323c1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -340,7 +340,6 @@ void set_channel_bwmode(struct adapter *padapter, unsig= ned char channel, unsigne =20 center_ch =3D rtw_get_center_ch(channel, bwmode, channel_offset); =20 - /* set Channel */ if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex))) return; --=20 2.43.0