From nobody Fri Jun 19 09:26:08 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9694A35B12B for ; Sat, 25 Apr 2026 09:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109426; cv=none; b=HeeDD54y9owN6tWIw4SXalL0J3zCeaYSlDcIgT+zqh0UOfTdFLEWtTsv9LLrkQjQjTfy9O8Tg4A/uHubByJzpLuNuKsa4sbxeKftAN7N9LuZtDT6+wRvn++S12wvG7jJWF+dE6YyfyqspEk0knmTgqYxgOJYXEzXsGYIe6pZQPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109426; c=relaxed/simple; bh=XRwvQOJ2yl+WUlOR6pV8FzMv8Q8eNYsuggKIjYllsss=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q3H1v6KRhATZxqmzuE8qxMRciONRP/CBe1t7gE9Sus2lleISZjSpMq0pQlzO55Zsopwft6zczRvL9ScwjidqY0xSDFKE00fNK6RM+D1q8KvxLDthq56m2KsLVbwUtQAm/bqOp83I5HufPiMzrmKKMEUpSNtl2j8APUdKKqbOyUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mtpXoBx5; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mtpXoBx5" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso118571685e9.3 for ; Sat, 25 Apr 2026 02:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777109423; x=1777714223; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wdzu/OjVJDdorng+o0yxXBdxT5kIS9RVZ5Y0mWK92GQ=; b=mtpXoBx5MSHMq6DV90eVGOPgXyIlK0Cc/OiF/v3Wu3p8gPYa+KEIkNOX/4wrIZE9H4 zbQcX/sBSR0e7YY/xxoNFz+p54w2adBkw/tg5A5UB4YT8SyuoGgReKgN4ZFmXIRAWD86 KdNqmpuMiO49LMqDr/dn7DjyfM4mkurqPzWDmNO+PJYHuEzxrdxPO0kUqqKWc2Y4G8VW bVYJC3baFVJo2PmOIVBscEqRQJPXJDGLcdcrX8g8PO2Jz9icV+FPsaS1OIS1DDDGmuT3 P+11W6a6gViJWjQG0DfO5hmYXEt0mph/u+uX69MCjEmE1ggIiuYrRG6FaMCeghacIZfc lfOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777109423; x=1777714223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Wdzu/OjVJDdorng+o0yxXBdxT5kIS9RVZ5Y0mWK92GQ=; b=k42Rv5In8BZGQ1+kFXVPl0Li2WnWJj2xzTc3jHd/6Xznx4rp+f2bGfjjdX4pw7VwJp C2iNN6VNFmECPBP2JA5l4xGxkS0RTosbuLIfayE+ZF98urOAB/tIPGhAMGarCmpmDI+e 3x6zrfEyFEhj9qqFKIhO11KtbNxnIURxp/2gLpN4/kGAGBrPlMldULXO4TU/YSNXtn3m HloG1vll+InGGLLsu0FI70Hni6/JUwbJ1bESMeEZx+zeY+RCP+cQini/V7SgohiCInwX Rbd+vZNg3gfvSKl22neaxGmPJ5+UChQ6CE5QFzLZKu8k1MSSQcOFXwdKBXHRWQEXGSsd 2uXQ== X-Forwarded-Encrypted: i=1; AFNElJ+HOXZ5+mAH55FmgTSzCUsvfEZN0GV75bbK51/i1GY8iX+Fb2aiosx09w14Gb6b7PSbGISDAmkjm8aG4Wk=@vger.kernel.org X-Gm-Message-State: AOJu0YzjhBgxBtMPR80sWKat3zBIONDlz7l3i0W30ZSTdfdrhxOYNSPN 4mkwT1SoksRDM3XrqV/8BXV4dlB6vUTupdh3xwPM6xZfDYxUUAmELD/l X-Gm-Gg: AeBDievcLyvHwhNNzjgg3e/yOR3SoUhPAO2hlwkc/l+55Vlqzh/IPj+aM/OYWFQ9C/6 KLRrSRsWCmnCDUBqZ1qvp0XTrC9BUEPZxQC/ZULGiFCATKARwoPHY/iyCA4a7kZJsW9Nd/ZHrW6 Mz8FuqkPRrpBidG+aFF94K0Jeg45VHcSlstW02JmAs72f+3OqpYjVyTe9Yf/EWSib8JCPQIGvP5 VE3pmSm/5HwlPYrItPwdtUYRWBS6PoOcyzvbfCiDExIlXJ/6aJoBcWhJX6S6uQqiWSm9v84w9o2 81SQt8Bmdy5k8sJmGXUvhONYQacO0bwYDGXWbHVSxPG9EvAzMFJssd5jh8nGTpo8dBdcT5WKWx7 3IvG9qVgW8x34aJFB9e3grXRfGVdawSiCi1G8TTSVYgfOSXMwat1jdm4HIghKyRBZ+oqljxOF+F 0A7jtuk3k4TtwHGukxzZwXiS6khDndlZpiCGCk4/JuAVOV6aV/cEXilHEM0yMiRbiid7q+fmftp Eg2 X-Received: by 2002:a05:600c:8183:b0:488:b187:3c with SMTP id 5b1f17b1804b1-488fb765ab5mr507183895e9.14.1777109422978; Sat, 25 Apr 2026 02:30:22 -0700 (PDT) Received: from localhost.localdomain (ns31537009.ip-141-94-163.eu. [141.94.163.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7b2716sm204422615e9.30.2026.04.25.02.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 02:30:22 -0700 (PDT) From: John Madieu To: broonie@kernel.org, heiko@sntech.de Cc: jon.lin@rock-chips.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, John Madieu Subject: [PATCH 1/3] spi: rockchip: Read ISR, not IMR, to detect cs-inactive IRQ Date: Sat, 25 Apr 2026 09:29:34 +0000 Message-Id: <20260425092936.2590132-2-john.madieu@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260425092936.2590132-1-john.madieu@gmail.com> References: <20260425092936.2590132-1-john.madieu@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rockchip_spi_isr() decides whether the current interrupt was the cs-inactive event by reading IMR: if (rs->cs_inactive && readl_relaxed(rs->regs + ROCKCHIP_SPI_IMR) & INT_CS_INACTIVE) ctlr->target_abort(ctlr); IMR is the interrupt mask register: it tells which sources are enabled, not which one fired. In the PIO path, rockchip_spi_prepare_irq() enables both INT_RF_FULL and INT_CS_INACTIVE in IMR when rs->cs_inactive is true: if (rs->cs_inactive) writel_relaxed(INT_RF_FULL | INT_CS_INACTIVE, rs->regs + ROCKCHIP_SPI_IMR); so the IMR check is always true once cs_inactive is enabled, and every PIO interrupt - including normal RF_FULL completions - is dispatched to ctlr->target_abort(), aborting the transfer. The bug is reachable on ROCKCHIP_SPI_VER2_TYPE2 in target mode with a DMA-capable controller when the transfer is short enough to fall back to PIO (rockchip_spi_can_dma() returns false below fifo_len). Read ISR (which is RISR masked by IMR) so the check actually reflects which interrupt fired, and parenthesise the expression for clarity while at it. Fixes: 869f2c94db92 ("spi: rockchip: Stop spi slave dma receiver when cs in= active") Signed-off-by: John Madieu --- drivers/spi/spi-rockchip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 14cd1b9d9793..de39f5da62cb 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -357,7 +357,8 @@ static irqreturn_t rockchip_spi_isr(int irq, void *dev_= id) struct rockchip_spi *rs =3D spi_controller_get_devdata(ctlr); =20 /* When int_cs_inactive comes, spi target abort */ - if (rs->cs_inactive && readl_relaxed(rs->regs + ROCKCHIP_SPI_IMR) & INT_C= S_INACTIVE) { + if (rs->cs_inactive && + (readl_relaxed(rs->regs + ROCKCHIP_SPI_ISR) & INT_CS_INACTIVE)) { ctlr->target_abort(ctlr); writel_relaxed(0, rs->regs + ROCKCHIP_SPI_IMR); writel_relaxed(0xffffffff, rs->regs + ROCKCHIP_SPI_ICR); --=20 2.25.1 From nobody Fri Jun 19 09:26:08 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA0693859D4 for ; Sat, 25 Apr 2026 09:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109428; cv=none; b=R/wKSk9M5SdmBLc26hlKenTj24r+j6Z3In2hMZKoA3rP5qS6wRDx1PXJZ8DCEYh0Fj+/tlbrIdqhMG6pLEe3wgz6y3aKErT8xACJMwDYRGNVvz3NWx2MTKF3fM63finvWKkUA2niD3sARNFsNk/BDCRnD7LuUUSOo0XcJoT2XyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109428; c=relaxed/simple; bh=FESLfCoxU9M/CkHD+IrL0BjuHbYP5gH9OqdMVYJHqjM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EPWIOHJzLv4PThaKX3m6l7YUuk2NvQaIPm3Tz2FK9CGX241ojU8+F83WnOiuITdxON8RD+YPkvGzzyojXsRtKadJl+/bA6tHUQFz4g5VEVyR5oLCtEfZWUqGLEdniV4VwN+C+H4mqA+cBwPbomPuw0/skoEPqF6g4NbXPqU4Xdo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZSRiB2VI; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZSRiB2VI" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so61866625e9.3 for ; Sat, 25 Apr 2026 02:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777109425; x=1777714225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NFcunWIpYnqUnWj/RVVTZn+6mdgY5gobPpPfEuSRWIU=; b=ZSRiB2VI3I59sfZPAWHqqPp+aR8clSDYJCeshVIavbL1674kcXqLieagMrQQdD+ADb HrpNP196JrNZZLPPja1lFiukfUxxICQOmQYmEgGiRjxbSjp2CC9prmNUdHP8egVla+Ql ufeIwvbeFIK2nyZrSKHqpJOjrjUGC7LJgYGe3MhyKgZwlXGwHlXngKS9xzF13/n6dVJI DFxEbK/adzuzGYdRdSKx7/kb/4TvZ2j8XSardFaBjJ9c9FVv5f+dAAgOuwCN5V7q4nwP bgQ51FJrBA9HO12p8XYk7D1AVIJpFXQQqCS+X4By6SajFEBsEpiTfdhSFTthSLDE9SPD k3SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777109425; x=1777714225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NFcunWIpYnqUnWj/RVVTZn+6mdgY5gobPpPfEuSRWIU=; b=SGIx0cutjgkZKcBZlj+/5kd/Cp4h+ZWjDhL40pIJBCB9vKWFmcr0fNOQZDcLcsoBUf ZvpXKjeZwQbzSAKL23lUuoHFgwi7QPgqP7xKbBFFfm9+Z0nbqS9Xik0pZ5XtGdpSlTzq GzDLvdlwP4DTkJNcuVRfJ7oIWwDeP80ldSRujzBmUVILhFqv+87NIUcggsvqfYQOfYoR I1APYb+T5F2Asy6+pFKC63+uUla6bKktceiPEuaMloORJAUxSUKIT5eo3f8o1mKBT5Dt q35ydd1kCdmIO+5+dWvU23Te3styOdaUrN2MhkTjwZmXCcIhONsE07v5T/WS+aL93sE+ XK3Q== X-Forwarded-Encrypted: i=1; AFNElJ9h6ygeAxcsNG17ckUiHgZUj9rAYskbB05QYk8QYH/B+OjfdIoTXVylX+hRra4J6X/RWpUsk0Ha2G38v9I=@vger.kernel.org X-Gm-Message-State: AOJu0YzHy2FsN/m2+zBl/DEY1htQQIki6Div8dy7Jnjyd5ANpdlC0n5o 1QGCdL1UA33SiKIXReuov6QGMBjQ9NAhAdn6QIumZffw9QuvRcn2W+Wm X-Gm-Gg: AeBDievVVd3sZumRpblLSUS//wscQY3yj2fSLWw3Xy78Uww0QtBN93k3GteFVbmd3U3 ntvOqtbLlpVWg4NGFhgQYuiSpkd2syR4d4LNHkLhArP82goTjHTZRevLVWaijBRGpqDJced3p/G 401C4JtwRp77XhhXtOTHFYA+9oSiz54rBHt/6iVZAr3iSFoqGaInFtpX0x84pd6NAcMvKVwMhfQ gR4+8GYLGxW1HkMJ5Gel/2zxYM2EUbUREeTiOB/HvsNw5OplynQm7/Ngg++vYZrSoHZgjDq3MBJ CC/ERlsMpFu/hPWZibzoEQr6BU3Dj8awmSYgAYvRSaY1d3+KCvkOfM9AaCzh2SOeWIb5rzjQBN9 czJ6koxtOQImSE2adPe6ah7Lg/6ppDp/o/A4+/FW6+6xOTyx1iDgSLEvqbn+pMRryxu5UMjdK2c u30cUorSnaffCZbYlHjzD06jRk6fNLX9P5rBT1nGQiV/B4U1ZA9fp4wlqw9T1xU8oFJ2/sk7PN3 IBK X-Received: by 2002:a05:600c:858c:b0:48a:55d8:7882 with SMTP id 5b1f17b1804b1-48a55d87a58mr238596535e9.9.1777109424887; Sat, 25 Apr 2026 02:30:24 -0700 (PDT) Received: from localhost.localdomain (ns31537009.ip-141-94-163.eu. [141.94.163.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7b2716sm204422615e9.30.2026.04.25.02.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 02:30:23 -0700 (PDT) From: John Madieu To: broonie@kernel.org, heiko@sntech.de Cc: jon.lin@rock-chips.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, John Madieu Subject: [PATCH 2/3] spi: rockchip: Drop unused and broken CR0 macros Date: Sat, 25 Apr 2026 09:29:35 +0000 Message-Id: <20260425092936.2590132-3-john.madieu@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260425092936.2590132-1-john.madieu@gmail.com> References: <20260425092936.2590132-1-john.madieu@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Two CTRLR0 macros are defined but never referenced, and both are wrong: - CR0_XFM_MASK shifts by SPI_XFM_OFFSET, which does not exist anywhere in the tree. The intended symbol is CR0_XFM_OFFSET. - CR0_MTM_OFFSET is defined as 0x21, i.e. bit 33 of a 32-bit register. The value is meaningless and the macro is unused. Drop both. They can be re-introduced correctly when an actual user appears. Signed-off-by: John Madieu --- drivers/spi/spi-rockchip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index de39f5da62cb..231fbcf0e7aa 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -98,7 +98,6 @@ #define CR0_FRF_MICROWIRE 0x2 =20 #define CR0_XFM_OFFSET 18 -#define CR0_XFM_MASK (0x03 << SPI_XFM_OFFSET) #define CR0_XFM_TR 0x0 #define CR0_XFM_TO 0x1 #define CR0_XFM_RO 0x2 @@ -109,8 +108,6 @@ =20 #define CR0_SOI_OFFSET 23 =20 -#define CR0_MTM_OFFSET 0x21 - /* Bit fields in SER, 2bit */ #define SER_MASK 0x3 =20 --=20 2.25.1 From nobody Fri Jun 19 09:26:08 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C26E2DB7B7 for ; Sat, 25 Apr 2026 09:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109432; cv=none; b=NtkXeL4osLQKZWG3BJVCIB8tF4fZmf9kIG5L3eHgAqC5K9GArZUkfyTFEfGSkdrWnazuBifpTKHNZXr+UE7jWt/iIbZp+6UYeLxf40iqXQzDa2ykJnKl/7yJGMR9aS3o5GycIElfHJ2VAUUijV8PcEb1noowTbcrnd6Ot95CbrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109432; c=relaxed/simple; bh=N9ijW3AsBy/p+PwIdQE2e41ehaiY4fwBhwF0z5uyDWk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RDRaoQEwTss9yrdTwJxD3lSVL1MuWoO90jGsoy29VBs07KtKs67UAzscq8HVSFF1X3F9O/BXCtTBZtChNi87pa9Pr5AbM+VAkGgNmKJHwd6i5Zs2C7b8te/Fj+f8lTlyzouZyWg1wu1UGXBSlfr8wSWb9AKNh9vFIrwq8C44H0o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fuWsAWxP; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fuWsAWxP" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43cfd832155so6339853f8f.1 for ; Sat, 25 Apr 2026 02:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777109428; x=1777714228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xyL6eQDTOa83HsK8N08HXtdZVDzA0HoYcQ2NsR08O3Q=; b=fuWsAWxPkUdjkzeiJ+pBcluWKajhMmK/d4loORNHDQ9r6NHUCuzOfVthwCYYErxWgK S6cSYUUFSFBulw9BnswZ5A1IG3LlkKGUuEqqKdmJevs3f+VtspJ1izJ1tZ3ZTaJCE4nl DT5zL7+v1W4KcksmIiXEVvFti2VdkuTm5mkVp0NsvHqATNio1wiPFBG2InkrUKeoivS+ DJSr2vvMtKYdWBjYoXLdG9sxGstPXq8M9wC9sRlg1fDGMd5yXkQRSJGxMUljD1+Jg1fY ANyqEABVleHZdYybIfgL2h6fUNScop51w7yme/3c07oKtt7NQtXxE589bs+QW4NGlU0M R4qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777109428; x=1777714228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xyL6eQDTOa83HsK8N08HXtdZVDzA0HoYcQ2NsR08O3Q=; b=NziH0yU9yBqHI13yjaPTA+NVtV2Sfwja1FlKBm+X4e158wE9pH0xJ96+RUshNR2lwc UIf68I9RYzeOXYp6QyOvrw5zfwyrpLPx91ruzqatYPc1vqxJ6vVcfzjjhv/a8gzvTCRm AeWFDQaJ6wAkD8Av21IHGdrgUf2Ug/+70vQrlkhcktHJ97l6dzSeQZcIKshqFZs5MF1i KgE7/m3oiZhdsS2Ga1MIO4YEK76yZ2iILgf7RX3t9CuaMWtC3cFAVRSpInYqG3xfQWRJ eoEAZee6XvwnGcI2ZoVjAaLYMErm81RLKWa5Ceefxih/f0i93OxMlzVrpn90i9OFpfef 1wQA== X-Forwarded-Encrypted: i=1; AFNElJ85D9mtMPTKYy7TzrPrJS5WOywCRf4FKqDYPg4x2cnybLBLWSzHWT9dhA8tbDwtZ8NakowhKx8of/B/j8E=@vger.kernel.org X-Gm-Message-State: AOJu0YwriwsFSQZaqNdMNDHno/FBsKJC/c4WqY8p8wbzg/4U7H91Wt8n NDyx9FFHIlJCPJVUfaP4MoN4LeShcAD6uda2E2x9L5Q7G/kC1nxQTYfF X-Gm-Gg: AeBDieuHypGx0wF5bIh+rCO3SZ3xr5dkJR3xkkmvGzS2cO4wf8FDBJTJlksICB+6eHM +21I1IBD2PcUirNFUVTxOeuLK0z67DP91nsO2UtCoc46QOdjHDAJ87E5K1LirjMelzDNUbAUkWN M559LGauGQEq/ooclUXiRlI83dpwODUrcWWKXr7YSqxCn009rFnw/VXx8sMOzyL61O0/0IdHM2q hufpY9ZI/vKHIBQiGrdu5vsMz7mFZjMFAf8f97zJr0XEJSSje4llmeQ2+3qhf7nNLY7AGzQsMMK E7Cgbkx6LzfYfVMcnNYEKdIxsmEvONaML/9cW0qavVAkfXyAAhntEe6sAoYj+SCCjVjNXhO3pIK Hx1XwLNT/npXI7+MsbJl5X9oWmMjfE0ZEyQnT68KbTLD6m3bo5GzWv3W16g0nr1HQiMMiNjE3iA oy/ltqVnbQdFiD56pO6tfNu/epymnDl4ilp3zIouYQSGkk+/ZSWN2Zsj2POM2P0dNTDYSmJcSJD Tv1 X-Received: by 2002:a05:600c:468f:b0:489:1cd2:610a with SMTP id 5b1f17b1804b1-4891cd2624fmr339312755e9.9.1777109427813; Sat, 25 Apr 2026 02:30:27 -0700 (PDT) Received: from localhost.localdomain (ns31537009.ip-141-94-163.eu. [141.94.163.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7b2716sm204422615e9.30.2026.04.25.02.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 02:30:26 -0700 (PDT) From: John Madieu To: broonie@kernel.org, heiko@sntech.de Cc: jon.lin@rock-chips.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, John Madieu Subject: [PATCH 3/3] spi: rockchip: Drop dead zero-check on fifo_len Date: Sat, 25 Apr 2026 09:29:36 +0000 Message-Id: <20260425092936.2590132-4-john.madieu@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260425092936.2590132-1-john.madieu@gmail.com> References: <20260425092936.2590132-1-john.madieu@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rs->fifo_len is assigned from get_fifo_len(), which returns 64 for the two known SPI controller versions and 32 for everything else - never 0. The subsequent if (!rs->fifo_len) return dev_err_probe(...); is therefore unreachable. Drop the check. If unknown controller versions ever need to fail probe explicitly, that should be expressed in get_fifo_len() itself, not through an impossible post-condition. Signed-off-by: John Madieu --- drivers/spi/spi-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 231fbcf0e7aa..1bd48376498a 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -824,8 +824,6 @@ static int rockchip_spi_probe(struct platform_device *p= dev) } =20 rs->fifo_len =3D get_fifo_len(rs); - if (!rs->fifo_len) - return dev_err_probe(&pdev->dev, -EINVAL, "Failed to get fifo length\n"); =20 pm_runtime_set_autosuspend_delay(&pdev->dev, ROCKCHIP_AUTOSUSPEND_TIMEOUT= ); pm_runtime_use_autosuspend(&pdev->dev); --=20 2.25.1