From nobody Fri Jun 19 08:53:22 2026 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE7C22BDC16 for ; Sat, 25 Apr 2026 05:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094055; cv=none; b=mwiljWMgdkjA3KhF1lcZpeDmid4/3tgrk9n+yNEoqPil4UVcnZE7KKDiBUq4sJqS/YyhVk36tnuMyqIGqZAXvztVcrLmaFUflhnrrBaCwcza7R+7CYCyF4N3YbSW0ENRcJfbs7qFQget0qB1jEH8dxDAhHwmrNLGQWKuGMjYvPg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094055; c=relaxed/simple; bh=jGEqquZ2fD8KfC6B3eKEDe79Xup6NmyDIFmkXgCEm9k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VIlqyGEeE9of20QPL4FvblfhbSd77r4tTzYP95yzeP5pP7gFESePrDJa5vAhhAuR08LzYZ1zff4TCFzAQOlptyyTl9pLpBWWZOP795gzXCH5cWGvUVvbULBXN9ry6AzOLvwGMhiYQagIZiugVCxtmunc2P6MzOfSuKTrix/w1eU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=axqdTBAu; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="axqdTBAu" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2d868d014a5so8389075eec.1 for ; Fri, 24 Apr 2026 22:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777094053; x=1777698853; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Njwz4GpR6Lsmc9++a5m2bWV+NAXHXBWZE5m0XlH/aas=; b=axqdTBAu6myUraMjj6T0eoSQSPSODn/wTMwlqAVVZ+nazlnSAFxt3vXilbhLcxoRS2 6Ow9gO2rAQoSvcsjRuzzC+j5k+tsW5W/uBy+X9mMp4GntUIYWZrVzCUI01QXFTMFH6Ev DcR/VmFRNE6rBfk8sBduPiuehPF3xNETZVa/vMRgeg9op0w7r29x0Lp3uH3T0DZd90+7 GbB+6YA7IkaThtbPTjWyONFskhYO4EDjObliQX0BTQ+z+/3wzD7Sy0ycipsDfVvZIpmI pLzaUo+ZhUQZ7nNAAQBvkTOpzZFz4H7HGducXwHW2yYByoEunTDv++GJy/awie4kUiab cg+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777094053; x=1777698853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Njwz4GpR6Lsmc9++a5m2bWV+NAXHXBWZE5m0XlH/aas=; b=GxQKoOT7p/y2oa8wpOAb1T8u9+SpEK/6KBysI8IZM0eJxyYvApNPDGk5yFcWsRxgSL NL+ZcZjdmvVKUKdO9ttBYAhrlgeDiTvaVvwPRMvhPGbRDBkWlDE+tUuN2LnmeIs2vr4j rhg6oxyOu7m37O65sCJfLWj3BP9EjpvJ0CkdB2TFumujpGHaUZ/3Bbnoy+4x7XY5u4kx ji0afhUC8HP95GZHAsc+3w+AJeKMySLhiXDvisULSWuG7erXIbXvu53mnT2YhHD7BkkM pZtH7u488CoDkS64yZ3cAu4GEWjrUZcBb0kKaHcp0WXGeSUCjDIteadFF+OwJWJF/ubf LKcg== X-Gm-Message-State: AOJu0YzioJm2+1iV2LbClm3C8KCDpuF2nDlPH9ZpcirRsQ0/5xLSGfok 9ortXr3/Sny8JGcrCHNJsJGmh6A2zjVbtljk+BCZqq0AJ2gcbRDJKEfGkUyq+nEy X-Gm-Gg: AeBDievMnItRgdMTe18a3q80V7lWi4xxkbcU6NTWPjDoNBN1fmN1HO6C/AynW9+PJ++ s8J8wEF5Bj5WdKYyZeXLB58ItUkZfMx/iuqHrJzled0GZQegeiGN87l/nAvfxvYuWzTJ7xySEMa hxgpIUG0vjTKJ/xahzkRK2zo1UcdrvStfQAMSxWNqtdP8rGZd8qI+GGS/hPxVDlHbYqd1ex7IVs DSdJdy4LNrFo75NK7VWSJHldsVJ8nY2NQjxNKGxGKHeeCKC9f4HmOayFEstXeWO4hBuBUf+bjM6 g9p3w8kngv2APv9iGEUY/IlYhDjzPHo90lAkOz0HEVAFOucaG1GEryRDNU9ow1E+xY/ajcCxsPS +dwhFCSnQ3528KTPIAPflrZvV9tRxEPPY+QqJe1VkMjms9M7i0N1FJjbaKCx/lFrAPE+eibP5Il o24VZO1Wm7/q060O45MTRm0DUyqV3c56/EIQ== X-Received: by 2002:a05:7301:6793:b0:2ca:7eb4:3e0f with SMTP id 5a478bee46e88-2e464dafc32mr18035970eec.5.1777094052651; Fri, 24 Apr 2026 22:14:12 -0700 (PDT) Received: from TC-LAPTOP.lan ([66.142.131.45]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ac84c38sm35973806eec.13.2026.04.24.22.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 22:14:12 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v5 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Date: Fri, 24 Apr 2026 22:13:38 -0700 Message-ID: <20260425051342.8960-2-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260425051342.8960-1-tchatard@gmail.com> References: <20260425051342.8960-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dell Latitude 5285 2-in-1 has a BIOS bug where the ACPI GEXP device and the I2C4 controller (INT3446) both claim the same MMIO region via the shared SB04 variable. This causes intel_lpss_acpi to fail binding to I2C4 with -EBUSY, preventing the front camera (OV5670) sensor from being registered. Add a DMI quirk that selects IGNORE_RESOURCE_CONFLICTS for INT3446 on this machine, matching the existing pattern used by other LPSS quirks. Signed-off-by: Thierry Chatard --- drivers/mfd/intel-lpss-acpi.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 63406026d..f08b41970 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -13,6 +13,8 @@ #include #include #include +#include +#include #include #include #include @@ -52,6 +54,16 @@ static const struct intel_lpss_platform_info spt_i2c_inf= o =3D { .swnode =3D &spt_i2c_node, }; =20 +/* + * Same as spt_i2c_info but with QUIRK_IGNORE_RESOURCE_CONFLICTS for Dell = 5285 + * where ACPI GEXP device conflicts with I2C4 (INT3446) MMIO resources. + */ +static const struct intel_lpss_platform_info spt_i2c_info_ignore_conflicts= =3D { + .clk_rate =3D 120000000, + .swnode =3D &spt_i2c_node, + .quirks =3D QUIRK_IGNORE_RESOURCE_CONFLICTS, +}; + static const struct property_entry uart_properties[] =3D { PROPERTY_ENTRY_U32("reg-io-width", 4), PROPERTY_ENTRY_U32("reg-shift", 2), @@ -172,6 +184,16 @@ static const struct acpi_device_id intel_lpss_acpi_ids= [] =3D { }; MODULE_DEVICE_TABLE(acpi, intel_lpss_acpi_ids); =20 +static const struct dmi_system_id dell5285_lpss_dmi[] =3D { + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + }, + { } +}; + static int intel_lpss_acpi_probe(struct platform_device *pdev) { const struct intel_lpss_platform_info *data; @@ -182,6 +204,18 @@ static int intel_lpss_acpi_probe(struct platform_devic= e *pdev) if (!data) return -ENODEV; =20 + /* + * Apply IGNORE_RESOURCE_CONFLICTS for I2C4 on Dell Latitude 5285. + * The ACPI GEXP device conflicts with I2C4 (INT3446) MMIO resources + * due to a BIOS bug where both use the same SB04 variable. + */ + if (acpi_dev_hid_uid_match(ACPI_COMPANION(&pdev->dev), + "INT3446", NULL) && + dmi_check_system(dell5285_lpss_dmi)) { + dev_info(&pdev->dev, "Dell 5285: applying IGNORE_RESOURCE_CONFLICTS for = I2C4\n"); + data =3D &spt_i2c_info_ignore_conflicts; + } + info =3D devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL); if (!info) return -ENOMEM; --=20 2.51.0 From nobody Fri Jun 19 08:53:22 2026 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E46929CB24 for ; Sat, 25 Apr 2026 05:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094057; cv=none; b=HkTseD6UjZiRzFiSmp3UbtLgXoZt6rcx5FOuJeWt6vgwb1GdfnOrrQJk1jNXS2Yiy/vHurV8/XnSDpACAQnNPBO1HncRefZcVW8u0UTFL8KTd5g9dv987/+7A+6lpiNJZIR2Bg0URORa6AE+Ylst6s7ljh3fE5P5EViVFSRXHZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094057; c=relaxed/simple; bh=OHzbodFEY9XsX/j0bYvyJY/ulMoblMKGEPhSTs/cpEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hhOOarKFa5lveYIYyQw5aB0RuAO6R9gtlrg1cWN1YLVTGgBN5sUyz4Kd/W9QM3ZQ7IrG9ZMo9WQJRBCGxx42Os6Q/qIq39Xbc1Jp8Gh9gkIQe1tdaSz1jaLC0k9QImlZAlttft9LQvW8UYdX/qY3w7PzkQKPtY5/rDaadlclMm0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VX9BSdnw; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VX9BSdnw" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2dee127b3c5so12276218eec.1 for ; Fri, 24 Apr 2026 22:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777094055; x=1777698855; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b19XW2BL5kvqhEId+iwDdtSDQMuam1C47LzXsM6NykA=; b=VX9BSdnwNj/h0MF4LT/18RTFks+0LbENNMqLGJSFsmL+epmQBjxy4k/Ij43lIAfXEU Tf0o97d0BAjqLuDCkjjTjGKU/Kz+vWr2hdRNmElauznzy+hEHlrvQsdimzDcwvRlhFDZ En3DGQWKj1qErFDnoxGG3noCqNYhW01CJf2bflCoa3OG/7qd64JYdbMA8UjDUulvXHDw 6GpO+DrZUzb7nMS243eV7fH4/iQBgIrKcQNpVng67G8a/8UirogOp+c4embYQZEDlLuv Kk+s6op62qTZOHF21nRuOsriuDHAcCkAiSlq5T8taN6wkRd6FnR5EpdiDFyo32DtG0GL A4RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777094055; x=1777698855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=b19XW2BL5kvqhEId+iwDdtSDQMuam1C47LzXsM6NykA=; b=rXLQW2O/mpuTcr3ixDsnkBGRr1tYfEZjpY94qAQWyEpYpqOAzjzHieFokDS+TzJhU/ V+rvWrR3pl8yFAqGGv4wjnMGpbr7PMEiETy6J68WPrtyinziXbqZuRQcE9p6qALIl3kl IZpm3Tou4Omfs/uqPB3BcnVJxRbnHx+RfBIXe12Gp+ac2OHf/JXnpRU1J3vpi9fCZgJg 0S73e8fS4cWWjLAXkM3vM0WaxL/iRO8AK3Woi+6U55j45Lsg+qf2xHLLXJzqDDP2KmWk FbtUh9H5gUzGHl1P6MiVSMgJxdL+4Ue8p2PRL1h5yPuTX45EPllydc3X5QmOOzFXIxOI i42w== X-Gm-Message-State: AOJu0YxvGUkfley/8Y2EX8h7PxTIpSOJlHS04OVM3+OAzo70/HZ+17Pn bQ7Ry2SSVN13wl0aRgu0tHQHFP+Hdlfiq62rbyO5ry8g/yyCc/CV1qHf2piJAumO X-Gm-Gg: AeBDievRuj9JGE9JSt7jZrkpyl29+jaMIqJHmwAsTtJ5l0pnf3xKlDeABxRjqZaTMYc ZgqUKAgqelIPKb0hYGoRnVm7s866UdR5tqHttFrIf21c43reyqbu1no7bvAQhZtI4sssKRbpFeA i9NSS/iZHXKzzPsFyMjFK/MPqbMKOH3qlUafTeLocm2V9YxRCv2ceQExLD/hX0IuPceZUcPi+83 yI0mLtOIAx/et5ND+80LxnSB43wFz1UpgFp+9Tg3KppcLXnz3FIEC7J2TxpbWLHIuWQG3nsWYF0 gx6jlzVhVY6KYJmmjhXubMXWL2M1+IteLRzQ2CODRE9N8CiMLtszVFHM+6rFQ6kLPfSlMXGqnN0 1UTa1xWz6lNt+q+tpgm8VwRbSWcvl+K4rFuALTt/xtG2V7C06w4L5rHKOfaZ+SS51RZH6Lm8fNN KzUs3XTX48L15IELil0VeIy7Gz436l5Zs1Fg== X-Received: by 2002:a05:7300:2327:b0:2d8:97d6:6ac8 with SMTP id 5a478bee46e88-2e478c1ff0cmr22162963eec.21.1777094054937; Fri, 24 Apr 2026 22:14:14 -0700 (PDT) Received: from TC-LAPTOP.lan ([66.142.131.45]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ac84c38sm35973806eec.13.2026.04.24.22.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 22:14:14 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v5 2/5] platform/x86: int3472: tps68470: fix clock consumer registration for Dell Latitude 5285 Date: Fri, 24 Apr 2026 22:13:39 -0700 Message-ID: <20260425051342.8960-3-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260425051342.8960-1-tchatard@gmail.com> References: <20260425051342.8960-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The BIOS on the Dell Latitude 5285 leaves GNVS field C0TP at zero. With C0TP=3D0 the ACPI _DEP method on INT3479 (OV5670, front camera) resolves to PCI0 instead of the INT3472 (TPS68470 PMIC) device. Because for_each_acpi_consumer_dev() walks the _DEP reverse-mapping, INT3479 is invisible to it: the clock consumer lookup entry for the front camera is never registered with the tps68470-clk driver, and the OV5670 sensor driver cannot acquire its MCLK. Fix this without touching ACPI tables by adding optional static clock consumer fields to struct int3472_tps68470_board_data: unsigned int n_clk_consumers; const struct tps68470_clk_consumer *clk_consumers; When board data is present and n_clk_consumers is non-zero, probe uses the static list instead of for_each_acpi_consumer_dev() to populate tps68470-clk platform data. Platforms that do not set these fields continue to use the existing ACPI traversal path unchanged. The board_data lookup is moved before the clock-pdata allocation so that it is available for both the static and dynamic paths. Signed-off-by: Thierry Chatard --- drivers/platform/x86/intel/int3472/tps68470.c | 113 +++++++++++------- drivers/platform/x86/intel/int3472/tps68470.h | 10 ++ 2 files changed, 79 insertions(+), 44 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platfo= rm/x86/intel/int3472/tps68470.c index a496075c0..e148b4532 100644 --- a/drivers/platform/x86/intel/int3472/tps68470.c +++ b/drivers/platform/x86/intel/int3472/tps68470.c @@ -150,14 +150,37 @@ static int skl_int3472_tps68470_probe(struct i2c_clie= nt *client) int n_consumers; int device_type; int ret; - int i; + unsigned int i; =20 if (!adev) return -ENODEV; =20 - n_consumers =3D skl_int3472_fill_clk_pdata(&client->dev, &clk_pdata); - if (n_consumers < 0) - return n_consumers; + /* + * Look up board data before building clock platform data. On + * platforms where a sensor's ACPI _DEP does not list the INT3472 + * device, for_each_acpi_consumer_dev() misses that sensor and its + * clock consumer entry is never registered. Board data can supply + * a static consumer list to use instead, bypassing the broken _DEP + * traversal. + */ + board_data =3D int3472_tps68470_get_board_data(dev_name(&client->dev)); + + if (board_data && board_data->n_clk_consumers) { + clk_pdata =3D devm_kzalloc(&client->dev, + struct_size(clk_pdata, consumers, + board_data->n_clk_consumers), + GFP_KERNEL); + if (!clk_pdata) + return -ENOMEM; + clk_pdata->n_consumers =3D board_data->n_clk_consumers; + for (i =3D 0; i < board_data->n_clk_consumers; i++) + clk_pdata->consumers[i] =3D board_data->clk_consumers[i]; + n_consumers =3D board_data->n_clk_consumers; + } else { + n_consumers =3D skl_int3472_fill_clk_pdata(&client->dev, &clk_pdata); + if (n_consumers < 0) + return n_consumers; + } =20 regmap =3D devm_regmap_init_i2c(client, &tps68470_regmap_config); if (IS_ERR(regmap)) { @@ -176,52 +199,54 @@ static int skl_int3472_tps68470_probe(struct i2c_clie= nt *client) device_type =3D skl_int3472_tps68470_calc_type(adev); switch (device_type) { case DESIGNED_FOR_WINDOWS: - board_data =3D int3472_tps68470_get_board_data(dev_name(&client->dev)); - if (!board_data) - return dev_err_probe(&client->dev, -ENODEV, "No board-data found for th= is model\n"); - - cells =3D kzalloc_objs(*cells, TPS68470_WIN_MFD_CELL_COUNT); - if (!cells) - return -ENOMEM; - - /* - * The order of the cells matters here! The clk must be first - * because the regulator depends on it. The gpios must be last, - * acpi_gpiochip_add() calls acpi_dev_clear_dependencies() and - * the clk + regulators must be ready when this happens. - */ - cells[0].name =3D "tps68470-clk"; - cells[0].platform_data =3D clk_pdata; - cells[0].pdata_size =3D struct_size(clk_pdata, consumers, n_consumers); - cells[1].name =3D "tps68470-regulator"; - cells[1].platform_data =3D (void *)board_data->tps68470_regulator_pdata; - cells[1].pdata_size =3D sizeof(struct tps68470_regulator_platform_data); - cells[2].name =3D "tps68470-gpio"; - - for (i =3D 0; i < board_data->n_gpiod_lookups; i++) - gpiod_add_lookup_table(board_data->tps68470_gpio_lookup_tables[i]); - - ret =3D devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE, - cells, TPS68470_WIN_MFD_CELL_COUNT, - NULL, 0, NULL); - kfree(cells); - - if (ret) { - for (i =3D 0; i < board_data->n_gpiod_lookups; i++) - gpiod_remove_lookup_table(board_data->tps68470_gpio_lookup_tables[i]); - } - break; case DESIGNED_FOR_CHROMEOS: - ret =3D devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE, - tps68470_cros, ARRAY_SIZE(tps68470_cros), - NULL, 0, NULL); - break; + return devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE, + tps68470_cros, + ARRAY_SIZE(tps68470_cros), + NULL, 0, NULL); default: dev_err(&client->dev, "Failed to add MFD devices\n"); return device_type; } =20 + if (!board_data) + return dev_err_probe(&client->dev, -ENODEV, + "No board-data found for this model\n"); + + cells =3D kzalloc_objs(*cells, TPS68470_WIN_MFD_CELL_COUNT); + if (!cells) + return -ENOMEM; + + /* + * The order of the cells matters here! The clk must be first + * because the regulator depends on it. The gpios must be last, + * acpi_gpiochip_add() calls acpi_dev_clear_dependencies() and + * the clk + regulators must be ready when this happens. + */ + cells[0].name =3D "tps68470-clk"; + cells[0].platform_data =3D clk_pdata; + cells[0].pdata_size =3D struct_size(clk_pdata, consumers, n_consumers); + cells[1].name =3D "tps68470-regulator"; + cells[1].platform_data =3D (void *)board_data->tps68470_regulator_pdata; + cells[1].pdata_size =3D sizeof(struct tps68470_regulator_platform_data); + cells[2].name =3D "tps68470-gpio"; + + for (i =3D 0; i < board_data->n_gpiod_lookups; i++) + gpiod_add_lookup_table( + board_data->tps68470_gpio_lookup_tables[i]); + + ret =3D devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE, + cells, TPS68470_WIN_MFD_CELL_COUNT, + NULL, 0, NULL); + kfree(cells); + + if (ret) { + for (i =3D 0; i < board_data->n_gpiod_lookups; i++) + gpiod_remove_lookup_table( + board_data->tps68470_gpio_lookup_tables[i]); + } + /* * No acpi_dev_clear_dependencies() here, since the acpi_gpiochip_add() * for the GPIO cell already does this. @@ -233,7 +258,7 @@ static int skl_int3472_tps68470_probe(struct i2c_client= *client) static void skl_int3472_tps68470_remove(struct i2c_client *client) { const struct int3472_tps68470_board_data *board_data; - int i; + unsigned int i; =20 board_data =3D int3472_tps68470_get_board_data(dev_name(&client->dev)); if (board_data) { diff --git a/drivers/platform/x86/intel/int3472/tps68470.h b/drivers/platfo= rm/x86/intel/int3472/tps68470.h index 35915e701..1d3d67459 100644 --- a/drivers/platform/x86/intel/int3472/tps68470.h +++ b/drivers/platform/x86/intel/int3472/tps68470.h @@ -12,11 +12,21 @@ #define _INTEL_SKL_INT3472_TPS68470_H =20 struct gpiod_lookup_table; +struct tps68470_clk_consumer; struct tps68470_regulator_platform_data; =20 struct int3472_tps68470_board_data { const char *dev_name; const struct tps68470_regulator_platform_data *tps68470_regulator_pdata; + /* + * Static clock consumers. When n_clk_consumers is non-zero these + * are used in place of for_each_acpi_consumer_dev() to build the + * tps68470-clk platform data. Needed on platforms where a sensor's + * ACPI _DEP does not list the INT3472 device, causing that sensor + * to be missed by the ACPI dependency traversal. + */ + unsigned int n_clk_consumers; + const struct tps68470_clk_consumer *clk_consumers; unsigned int n_gpiod_lookups; struct gpiod_lookup_table *tps68470_gpio_lookup_tables[]; }; --=20 2.51.0 From nobody Fri Jun 19 08:53:22 2026 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CE8522ACEB for ; Sat, 25 Apr 2026 05:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094059; cv=none; b=q3XXRluj5CWExwx9dNwjpHLYEZPuePddghCyqEDCcdOC0cLACm9aNmrwqRV2GxIIYhFweoyTes56D5C0Spzo54SeBGnnfA3Ygtjiry+yDCB2awMt3koPU+uKNbXBrD0A2i5XsB50w7tDiaVr3ike34xlEdHriTeKNVOZXae4JDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094059; c=relaxed/simple; bh=Jo35nUVpFuuvplLkNQ65nC4OzcNBauFAgNcv7iCnNRA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JTqKyV45e1gJPVOQJKlyserEKGPqGM73yUFrpAmor75emc4gPE5szGrcJBoMe57eA7A5P9k1Zw/fCBGBL41f7BCrx/FIxdTycC9MA/fqXKIfGM5s/sxFhuOSIIltaOpbStIKDGgEIx6ALIlYP+NCJZd6K/r9XTlaFUuqby5Z+Qw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TAeaRJfz; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TAeaRJfz" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2c15849aa2cso11471191eec.0 for ; Fri, 24 Apr 2026 22:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777094057; x=1777698857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B0sxDKU+IkjcN2cU/bEwl/wkozuXgsxyIrIJzKc/SV4=; b=TAeaRJfzRTNNxSTDS29/CWJxf5DVpXyMAbZ8RR8RRDMyPAVeIzoIm/1Tjat913APnQ MEeznWRU9Y/20GPr5Qj2SEHytQMV2S3kxZD/BvqrPAdOrbdJa7LlUT2JuVg072WQQRjS VM0S76x3i3mSStlhwIK+w6L/dfS6hSWpOo/T7XDiPzoY63jKWm7H5PjLfPSEPf2O9ZFy kCJWSCHiHjwUSq6pkEWfcII8s0Ab/xq/pyf63wJWOqM3YyYt2dlCgbAEES1n3BqJtTNY QKW5qUwQRjR0hLwywHnY7yexNy8gvHIK6Z0Vut2G3mmdRkC0t19NyMrRxg3Y1fdY9lMn MPpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777094057; x=1777698857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B0sxDKU+IkjcN2cU/bEwl/wkozuXgsxyIrIJzKc/SV4=; b=XWX8z/kkhPm4EtEQ26ifyb/IwD+zVq6YIv8KkYYwrHeJHDZ/schzzwR2wrB/0t0JbI fRtGD3YU/JN0cQdb5HOWkoMgeOCMuXb4MM5Viwv9mRhoDzjWrE1vhqg8n0gADOv6bjtb HdbslIJZHcchSy516eRXqm+uyH6p7GzMxmvj0fywPwubkCCd4R/yCSGWgoT0Eu0b3Wo/ CCJh425Po42KcGXlFHjxi8pgfdsnXQ+CrG31qwk6wgGNI+PzIBmZVlOG6qk8Muao6Krx AuaUuW/9wo34w9JSA6Q35a9/+rABrFM9UDU6vEoyaxiKk3qxPppynj+5y+K9pnquAJqG /S8w== X-Gm-Message-State: AOJu0YwDst9IVLxw2+MHiFBZ/OxxUJpbKfnKOWRLGpsPCNl7XokE2+Wv quKkITKlKNJtMu4Kl10a3GMe88UpMOMsYgazPuDhvdWZQ+X/NWrfUHfV+GxDL2Tb X-Gm-Gg: AeBDievfvvqZzcCo058nB6T/v+1l1f5QseqoMdmoPGRbgHjS6zzdjuq5bJGT8LCIMyV q9oaNBbKBxYbTwmOhLiL99NUZDW9S+LK07OEUKind1MaNsPt6NHQGif7fyEVv+e9LFYK67xeGl0 8DQbJgEFpo3R//9iQgG105PsgUFxty8wn+5O+WLdj34/Lhj8I43K4omgcFsA7e/+LvvthZr2zd1 2IWBFCwuCJoAJZ0FOwc5SWKMGkc8YH1zewg1jO48iWpmCeGckB7uDoVvQ/8KIMAsrT+YeDk2XzK dWFK9jH/Vh8euGhoxlapbBiPwo885/8mpw5oEHwdQdRn7/LbRVVrhonfKmL85CQ2GfO0+GL+XAD LZDU/DOq3JIbMKIxpr7ETP/ta+F021zlsrRI37Z2qRahgKe+srJ63fbwXL73QvHDC39J+WVvCMf rpu/QE13nF9zgsARpzQFD35CtcQXv5uZHXhQ== X-Received: by 2002:a05:693c:2c09:b0:2cb:4b8f:b2bd with SMTP id 5a478bee46e88-2e4646cd2bemr18275255eec.6.1777094056952; Fri, 24 Apr 2026 22:14:16 -0700 (PDT) Received: from TC-LAPTOP.lan ([66.142.131.45]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ac84c38sm35973806eec.13.2026.04.24.22.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 22:14:16 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v5 3/5] platform/x86: int3472: tps68470: add board data for Dell Latitude 5285 Date: Fri, 24 Apr 2026 22:13:40 -0700 Message-ID: <20260425051342.8960-4-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260425051342.8960-1-tchatard@gmail.com> References: <20260425051342.8960-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dell Latitude 5285 2-in-1 has two cameras connected through a TPS68470 PMIC/clock/GPIO hub: Front: OV5670 (ACPI INT3479) on I2C4 Back: OV8858 (ACPI INT3477) on I2C2, daisy-chained behind TPS68470 S_I2C port (controlled by reg 0x43 S_I2C_CTL) GPIO mapping (TPS68470): INT3479 (OV5670): GPIO3 =3D reset, GPIO4 =3D powerdown (both active-low) INT3477 (OV8858): GPIO9 =3D s_resetn, GPIO7 =3D s_enable (both active-low) GPIO9 and GPIO7 are the TPS68470 secondary-port GPIOs (SGPO reg 0x22 bits 2 and 0), not regular GPDO outputs. Regulator mapping: CORE -> dvdd / INT3477 ANA -> avdd / INT3477 VIO -> generic (kept always_on; no direct consumers) VSIO -> dovdd / INT3477: enabling VSIO sets S_I2C_CTL (reg 0x43), opening the I2C passthrough to OV8858; the ov8858 driver enables dovdd at probe time, which naturally activates the passthrough before any I2C transaction to the sensor. -> avdd / INT3479: OV5670 analog supply (shared 1.8 V rail) AUX1 -> dvdd / INT3479 AUX2 -> dovdd / INT3479 A static clock consumer list is provided for both sensors (INT3477 and INT3479) to work around the broken ACPI _DEP on INT3479 described in the previous patch. Signed-off-by: Thierry Chatard --- .../x86/intel/int3472/tps68470_board_data.c | 170 +++++++++++++++++- 1 file changed, 167 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/dri= vers/platform/x86/intel/int3472/tps68470_board_data.c index 71357a036..6961e2926 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -74,8 +74,12 @@ static const struct regulator_init_data surface_go_tps68= 470_vcm_reg_init_data =3D .consumer_supplies =3D int347a_vcm_consumer_supplies, }; =20 -/* Ensure the always-on VIO regulator has the same voltage as VSIO */ -static const struct regulator_init_data surface_go_tps68470_vio_reg_init_d= ata =3D { +/* + * Keep VIO always_on. Its voltage must exactly match VSIO on any board + * using the TPS68470 I2C pass-through, and must never have direct consume= rs + * (all I2C-path outputs are gated through VSIO). + */ +static const struct regulator_init_data generic_tps68470_vio_reg_init_data= =3D { .constraints =3D { .min_uV =3D 1800600, .max_uV =3D 1800600, @@ -122,7 +126,7 @@ static const struct tps68470_regulator_platform_data su= rface_go_tps68470_pdata =3D [TPS68470_CORE] =3D &surface_go_tps68470_core_reg_init_data, [TPS68470_ANA] =3D &surface_go_tps68470_ana_reg_init_data, [TPS68470_VCM] =3D &surface_go_tps68470_vcm_reg_init_data, - [TPS68470_VIO] =3D &surface_go_tps68470_vio_reg_init_data, + [TPS68470_VIO] =3D &generic_tps68470_vio_reg_init_data, [TPS68470_VSIO] =3D &surface_go_tps68470_vsio_reg_init_data, [TPS68470_AUX1] =3D &surface_go_tps68470_aux1_reg_init_data, [TPS68470_AUX2] =3D &surface_go_tps68470_aux2_reg_init_data, @@ -287,6 +291,159 @@ static const struct int3472_tps68470_board_data dell_= 7212_tps68470_board_data =3D }, }; =20 +/* Settings for Dell Latitude 5285 2-in-1 */ + +/* + * The BIOS leaves GNVS field C0TP at zero, which causes INT3479's _DEP to + * resolve to PCI0 instead of the INT3472 device. Provide a static clock + * consumer list so probe registers MCLK lookups for both sensors regardle= ss + * of the broken _DEP traversal. + */ +static const struct tps68470_clk_consumer dell_5285_clk_consumers[] =3D { + { .consumer_dev_name =3D "i2c-INT3477:00" }, /* OV8858 rear camera */ + { .consumer_dev_name =3D "i2c-INT3479:00" }, /* OV5670 front camera */ +}; + +static struct regulator_consumer_supply dell_5285_int3477_ana_consumer_sup= plies[] =3D { + REGULATOR_SUPPLY("avdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3477_core_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dvdd", "i2c-INT3477:00"), +}; + +/* + * VSIO controls the S_I2C_CTL passthrough; its voltage must match VIO + * (both 1800600 uV). dovdd/INT3477 enables the passthrough when OV8858 + * opens its I2C path. avdd/INT3479 provides the OV5670 analog supply. + */ +static struct regulator_consumer_supply dell_5285_int3477_vsio_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dovdd", "i2c-INT3477:00"), + REGULATOR_SUPPLY("avdd", "i2c-INT3479:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_aux1_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dvdd", "i2c-INT3479:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_aux2_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), +}; + +static const struct regulator_init_data dell_5285_tps68470_core_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1200000, + .max_uV =3D 1200000, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_core_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3477_core_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_ana_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_ana_consumer_supp= lies), + .consumer_supplies =3D dell_5285_int3477_ana_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_vcm_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D 0, + .consumer_supplies =3D NULL, +}; + +static const struct regulator_init_data dell_5285_tps68470_vsio_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_vsio_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3477_vsio_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_aux1_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1213200, + .max_uV =3D 1213200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_aux1_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_aux1_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_aux2_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_aux2_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_aux2_consumer_supplies, +}; + +static const struct tps68470_regulator_platform_data dell_5285_tps68470_pd= ata =3D { + .reg_init_data =3D { + [TPS68470_CORE] =3D &dell_5285_tps68470_core_reg_init_data, + [TPS68470_ANA] =3D &dell_5285_tps68470_ana_reg_init_data, + [TPS68470_VCM] =3D &dell_5285_tps68470_vcm_reg_init_data, + [TPS68470_VIO] =3D &generic_tps68470_vio_reg_init_data, + [TPS68470_VSIO] =3D &dell_5285_tps68470_vsio_reg_init_data, + [TPS68470_AUX1] =3D &dell_5285_tps68470_aux1_reg_init_data, + [TPS68470_AUX2] =3D &dell_5285_tps68470_aux2_reg_init_data, + }, +}; + +static struct gpiod_lookup_table dell_5285_int3477_gpios =3D { + .dev_id =3D "i2c-INT3477:00", + .table =3D { + /* + * TPS68470 GPIO9 =3D s_resetn (secondary camera reset, active-low) + * TPS68470 GPIO7 =3D s_enable (secondary camera enable/powerdown) + * These logic outputs are specifically designed for secondary + * camera control on the TPS68470. Matches Surface Go pattern. + */ + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 7, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + +static struct gpiod_lookup_table dell_5285_int3479_gpios =3D { + .dev_id =3D "i2c-INT3479:00", + .table =3D { + GPIO_LOOKUP("tps68470-gpio", 3, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 4, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + +static const struct int3472_tps68470_board_data dell_5285_tps68470_board_d= ata =3D { + .dev_name =3D "i2c-INT3472:05", + .tps68470_regulator_pdata =3D &dell_5285_tps68470_pdata, + .n_clk_consumers =3D ARRAY_SIZE(dell_5285_clk_consumers), + .clk_consumers =3D dell_5285_clk_consumers, + .n_gpiod_lookups =3D 2, + .tps68470_gpio_lookup_tables =3D { + &dell_5285_int3477_gpios, + &dell_5285_int3479_gpios, + }, +}; + static const struct dmi_system_id int3472_tps68470_board_data_table[] =3D { { .matches =3D { @@ -316,6 +473,13 @@ static const struct dmi_system_id int3472_tps68470_boa= rd_data_table[] =3D { }, .driver_data =3D (void *)&dell_7212_tps68470_board_data, }, + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + .driver_data =3D (void *)&dell_5285_tps68470_board_data, + }, { } }; =20 --=20 2.51.0 From nobody Fri Jun 19 08:53:22 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11AE42472A2 for ; Sat, 25 Apr 2026 05:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094061; cv=none; b=nJnP+lsYqf2ha//Bo/eJgPYICnlxa4MEJJvSFRYhj3FoT80Lnjum3eaK8GA00XMr6AKwVWdxQ5s6Cck3W+JiI7G8eIf9Kwgvh81zTe+7x75ihLUtU0h/vK2sNrbOPwJV8LqGjsl7Q6bmpJTn7qEELl9Zf9DS3knMmhQChMHpcpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094061; c=relaxed/simple; bh=wde4TF8CgNzn8si/JL9P12OCZloroRuFEPIxq/TcvgI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U5eYWmYpU/lKIyGDCcENqs6Lzj94lcBblBSzocys3XWWysgZQSuPHUG0Ddk7B7PWb7EZG5CZ37VIapblJ7PZYwr6bWRHkGUMcjz4eHmkVHErdTY4iOx1LXG9wjCiDtC1vWxM0+wcF4sxtIbHVkGMCJdpMhyRQHvKqaMgV6fQ+Ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bE0tNSjI; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bE0tNSjI" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2dee127b3c5so12276303eec.1 for ; Fri, 24 Apr 2026 22:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777094059; x=1777698859; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TVHeDChmbK7H9JMCFb+9pqFytvxF0fdzrozCeGR4L7s=; b=bE0tNSjIQLjK1jV8fqg0eFzXobNvnWukshZl0P2CgeIyKQw0p/pFWMx1EGztGbcZWj TIIzm9yUdYxWC5y2YEXtvOcJNzFT3pblMeVPdbcI4vgTOewuMS5oRLiy0dBi031Jgfb7 lVaPDd0t5BD25OKsxcvbCEfshlLnQrQCU6mZD08bDKvLPk2X6/J21gogQfQk6oG7gCCg 1Tichz2/rSdIGLz0RYVUmdPncSubhAtj0TCoE0SBxGnt1UwldiEKcNkZhQor04Ja2KQN 0Izx1KgNePPFemfZHZYY8a24RTQAxuNm8odZBAwhao/Tr0JhxZj5D2cW7RLed3j8fQYq sP5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777094059; x=1777698859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TVHeDChmbK7H9JMCFb+9pqFytvxF0fdzrozCeGR4L7s=; b=L+LMHL7pkyRsO0kmHdW1kelueP6bTgGo6oHm8P6mKR28dG30x2Yi9ClNiT10DGWyRc RLBDi3P+pXfNr+C3a0gKbc5lWCqAouRo/W11OCysOL8xpy9Z/KDyOx8PuinjIS7CNwHu SPJ4vpTurkmT0Lv9jAnOdRpfSJ7oDoTkXOhI9W1s4ydrYY2VGIyU9PZaZsZg1yjaGCAo 34LeTVwH9RaSZIVYuvtaBabOHqTaKvIxSCuDvmHVLgmRUeeOA1LwcmJk2rjnOJXJaDTj 7Fl5jkZ7sS3Z44lpiR7oL6ajFJVmHOWSeTGon6ntpib2JUgPoSVDUTzGOpAp8SMThQS7 gm/w== X-Gm-Message-State: AOJu0YzyqI6Q2eEPcwPRFuwSfxqPQ/rgiZBz0u1FdH1Zcyhh9lfTpJnn xTAzGzI4Y7XdKUfnwMLkc7wnfeU6nG50RRD93IoC5lC31xWElMw/+dHsQI0CnTSo X-Gm-Gg: AeBDievCa+oTSCcHgM4UqDeakA/GVCR+++YFt3i9AHGwFVtZwsGvLzC0kIkaM9JdjFq wpADxsurzdayGHFnTx3ctwfnpm4UYWx4MOEwh69vmWN7uU1ZdDkS+h2RHbEkDOWy2Fy73hASHL+ 72D3lLT6Jg80Az8L8QESzUm4VNm/CY/KqYT8l6j/8nfR8gpy9NN+Kq93Ws9DDg/Hr7Nyw2qcyqo e+u3LwPT/cHYCm5hpistdmC/lEDfNjsmovg6NPmF72h43imKLS5KcM13L4YOc1RP43IQSiRhtoI ZmnkXcG9uAEmUej2AjMmLZKTCOAdN+RSYEOK7dmTefFEwc09tTb/XHLp9vuO77j6hwKXssGLtxA Z7TgLjUwp5v3IMKFOAlX5ZZ023hQ/sjF/cgoW0PkxrYcrFn8kdlgs09QMzDMU4v2eFKKe1eWUPv 0PYwusODGIkq1dkP/qtM2FYOHHh3fehqOMyQ== X-Received: by 2002:a05:7300:bc97:b0:2de:6fac:f666 with SMTP id 5a478bee46e88-2e4792151e8mr20448732eec.27.1777094058926; Fri, 24 Apr 2026 22:14:18 -0700 (PDT) Received: from TC-LAPTOP.lan ([66.142.131.45]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ac84c38sm35973806eec.13.2026.04.24.22.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 22:14:18 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v5 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Date: Fri, 24 Apr 2026 22:13:41 -0700 Message-ID: <20260425051342.8960-5-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260425051342.8960-1-tchatard@gmail.com> References: <20260425051342.8960-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Omnivision OV8858 is used as the rear camera in several Intel IPU3-based devices (e.g. Dell Latitude 5285 2-in-1). Its ACPI HID is INT3477. Add a sensor configuration entry with a link frequency of 360 MHz to allow ipu_bridge to create the firmware node for this sensor. Signed-off-by: Thierry Chatard --- drivers/media/pci/intel/ipu-bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel= /ipu-bridge.c index fc6608e33..f51749d0f 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -63,6 +63,8 @@ static const struct ipu_sensor_config ipu_supported_senso= rs[] =3D { IPU_SENSOR_CONFIG("INT33F0", 1, 384000000), /* Omnivision OV2740 */ IPU_SENSOR_CONFIG("INT3474", 1, 180000000), + /* Omnivision OV8858 */ + IPU_SENSOR_CONFIG("INT3477", 1, 360000000), /* Omnivision OV5670 */ IPU_SENSOR_CONFIG("INT3479", 1, 422400000), /* Omnivision OV8865 */ --=20 2.51.0 From nobody Fri Jun 19 08:53:22 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EE4A2BDC23 for ; Sat, 25 Apr 2026 05:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094067; cv=none; b=u/oYEdjh5Le6rqqQ07fPim9/vz6UwJwlovFZuFYRwr8fbSHcwx1DoKcV0vuwqWCGERVubtvwnUdCh9WMdTuT/VktMfSC8Ax/oyGjJcmblWu3a731/6rEqc+pmDtXZc2ggbPHwtVwKEPuG/zazv7QVVaLlR0/IQu4qf6Z650Y7+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777094067; c=relaxed/simple; bh=JeFAGlclU046JIgSg4OVyBoSGPhLkEXsWzJ0ES221g0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H+6/bHfJ54egrc5dqMzGL6LIG3+NW52KOQbSvkee/m2CEoujsrs5vh7yQd8O16Cq4OZw4U3c2qmAzk8IqykV1HPPvT0oTqVLBPFICpekjGbkaGrEEoGTAAlFoRa3QG6ENHn+U6lwp9JR9Hv7n+B6sn5rxpgZjlbLNA4ouVk6gw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SVV1R5+G; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SVV1R5+G" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2d8ffdc31d0so2289143eec.0 for ; Fri, 24 Apr 2026 22:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777094061; x=1777698861; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CDF8n/DtizrT4QllCHI1cUw7JqDkCzaU+Ja6VBXSysk=; b=SVV1R5+Gzq15bpmV1aPLDHLsU4agB3GI7Q+b4K2Oiyi29MenjdLQt4dQ338YBy06WY eOINBK1UXsfwpKDHI+cIG/st4azyzyubBql9kQKzfIQ7EMjFuGnNi/udoH9FDagLBlXw zRDdim+fOExHtBcMoFCIFSh5k+0h8D1h/lMuDYKmdKdn0BNBBMpjGZznvhuP9UlGvTBM pRz33W0MiRkjfhodHinzsffA5hm9LC7fGugjpjAwssIDvXJR+WKtg889ISrNHYLeXowK xNPI0vjGAwptRE09samJN8B+k+e5wL8O5zP1z5jo+AqOkl/B3G43zDiVxIh75uXN3PGh Bc5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777094061; x=1777698861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CDF8n/DtizrT4QllCHI1cUw7JqDkCzaU+Ja6VBXSysk=; b=eUeHGXBdNt8sZY5n1mgeOXjE/j1STiKzSK+cnnwUEMnZ0wpCud2KUGjYf3apUE+Czj GpoZyahEaSmxQXqFb8tSEvIrj3pd9gvCqVRRxzyPpVjMa73Zxb5lw89IHTPGp4WAWtVv HKpHt0UB6tkzzU6h0nR2qUbNgHULzqDXfodxXHyGStFkEuGkpAwFy/wwf8nBOepHjS+S TZhXwNYNr5VIq+T1+xHjQY0recgJkBiGPDrnN495r9BxxGlh/XEWcUIJmz5dfh7haSFY T1VWSquEz42MJ2SDqGw0aqLfBiauUjy8J66KZfUTseusGcYBbO01pw1lU7Hg3Vm81ESG n4uw== X-Gm-Message-State: AOJu0YxrrplNiAYZQ2jV5Cpr12eCXRsKiNZbadn+yD0TSWu+9OXb3E2E e86SPo00xWfRZvlJbmVGfWTSjG4EXoV1w0XQCh7j3GpZyi9f3Ynrwiyt/DV4VioJ X-Gm-Gg: AeBDietnbcNnz8OzmKtzOlHcVISGnrSG455+l2to1RvPJH67SI3OpiO33YpUyaYCWgy Ko6tmfOO8sZFck9uPWB1AyD9s0vtXyHC4nyUdQMbBYOwRAO0lM2zFJayxqUb+4dzw+qt+/TvFpK e8ikIvdyDXAVpgyT/ZdLGaoDOtYe+u9rbx3vnJUpbPRmdReJOzm/yPU7zh15oug4IgxUrv+jli5 /CiqD88x+UvC81tZlsZv04EO+nnjW9gctrZJerKVoaV5xEeXCXDR3wlvX5OcYKZ4vNZ/yqD+ly+ lEqWf5lLWXxM1JeYqtAtdqfRa8YixaBO6OlVRm/SVIndM6hz1S5lxBVUo0+CS0wtiZ/VjQehv0I dflfJFsJiW38hlDBV3Z1Z1zzRzWvrIAgPSdIbi5+/8Ni1wJR6NbPPTjmXj3XMynJMXf5q1lqcHK JyaRDFa9WeXnzOqZQnYKR4FpHsIkO5wTYsAZRPpR7lCIdH X-Received: by 2002:a05:7301:4586:b0:2c8:7172:3b7b with SMTP id 5a478bee46e88-2e478646190mr21819283eec.18.1777094061175; Fri, 24 Apr 2026 22:14:21 -0700 (PDT) Received: from TC-LAPTOP.lan ([66.142.131.45]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ac84c38sm35973806eec.13.2026.04.24.22.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 22:14:20 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v5 5/5] media: ov8858: add ACPI device ID INT3477 Date: Fri, 24 Apr 2026 22:13:42 -0700 Message-ID: <20260425051342.8960-6-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260425051342.8960-1-tchatard@gmail.com> References: <20260425051342.8960-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Omnivision OV8858 appears in ACPI firmware under the HID INT3477 on Intel IPU3-based platforms such as the Dell Latitude 5285 2-in-1. Add INT3477 to the ACPI match table so the driver binds when instantiated by ipu_bridge. The supply names are reordered to dvdd before dovdd so that core power is stable before the I2C passthrough opens (on this platform dovdd maps to the VSIO/S_I2C_CTL regulator, which gates I2C access to the sensor). Signed-off-by: Thierry Chatard --- drivers/media/i2c/ov8858.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov8858.c b/drivers/media/i2c/ov8858.c index 3f45f7fab..a1fa0be52 100644 --- a/drivers/media/i2c/ov8858.c +++ b/drivers/media/i2c/ov8858.c @@ -79,8 +79,8 @@ =20 static const char * const ov8858_supply_names[] =3D { "avdd", /* Analog power */ - "dovdd", /* Digital I/O power */ "dvdd", /* Digital core power */ + "dovdd", /* Digital I/O power */ }; =20 struct regval { @@ -1981,11 +1981,18 @@ static const struct of_device_id ov8858_of_match[] = =3D { }; MODULE_DEVICE_TABLE(of, ov8858_of_match); =20 +static const struct acpi_device_id ov8858_acpi_ids[] =3D { + { "INT3477" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(acpi, ov8858_acpi_ids); + static struct i2c_driver ov8858_i2c_driver =3D { .driver =3D { .name =3D "ov8858", .pm =3D &ov8858_pm_ops, .of_match_table =3D ov8858_of_match, + .acpi_match_table =3D ov8858_acpi_ids, }, .probe =3D ov8858_probe, .remove =3D ov8858_remove, --=20 2.51.0