From nobody Fri Jun 19 09:06:00 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F2B117BEBF for ; Sat, 25 Apr 2026 01:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777081737; cv=none; b=hlQuV/+XgBIwhLCUv2FAquEMIGAz/E1ycOPtJSy+PMY9sVxOuey/ag40WhxCfAoOakn5kMUhK3+FH8KLBJdriZuU7lRgR7+qCO1HjbhQJxxtjU4m9Fi0MkAwSsxIxlmfsvswr6DJk57ZmGXOtrIKwIzjNsKFXbCPengqUZzc6Es= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777081737; c=relaxed/simple; bh=7NBLBNCgaPeu8Rt4l2UvtDHFYQtjS37GZUbNuqPQoyg=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=EiVzy3siyt5kcDEBqzTActdC1Rkc5tylol0DPUmq3vtCMkI/7B18INmdn3isDzxCvpI1uRXCKYjFH4JMWHM3SDUmqyicwOtB8duDS1NLbIWFxYoUabu3lneEwqAyrQlizKYdudiH6z/oeu2hs15IQjGddp/EoQ2GSbS2Ji+n1Wc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=K4XL1BPe; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="K4XL1BPe" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-12c91ef7009so21355758c88.1 for ; Fri, 24 Apr 2026 18:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777081735; x=1777686535; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=81CODhtfCeY5gOXc4AcZuOqtvysUpw25zIQcp3J/FQg=; b=K4XL1BPeItq311U22poeRHn+C2FQck7Te8YLayTJ8GIDWjK/C7Z9bG5Iob7zdjtvEP FLAvcZjJAtzXo0HLYhx7QK9MNLQK9Vp0ZAyCCq8tlCfm4bP5nWKrNRu9KCR3uo3xHk48 My4hUTtlkvAw3yLAclW5J5ghm9zOPydXpOikn5UnMx7YylYtOH987Y0gXEPasZMiNigj GT5BUJ+CXmtOPC0OLGmJfWvxayCEQSkGqxD7VpFWL3210SxWMQwDxqPyqaYBseN8fvTT CYsSRlbe2IyAp0qlN0/auBp3o3bkCpsho2S0OGyt7fXDjpeOYqAZg7D14PaXmufHS6HP +5zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777081735; x=1777686535; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=81CODhtfCeY5gOXc4AcZuOqtvysUpw25zIQcp3J/FQg=; b=Rmedoh+Uq/Bdy3AFnh3JwcQ1NIVgTds/Lb/FvUGYD+ZdTnzxj7UAe/cm0KJmjGPO+M jzufkH2cn37ZZdEWMeOB5PRnZ0RYhEO2TmQACWlNl9zrN5HJhvlLuKUHh9mOMST70ON+ Bjxn01rPIhhtsLpGjHmkqYan6/7hAIM39KWvOoLl1djQ7bTF1CA6lt2oXxQjcmORzLcL 0AXa4hgZDY4EeNgFi0QmmUrgAWkYCe8urK0+vNtDzFo4MZnoLZCMSjbEBCoFrXneAoQS n8vvpSoytubpE2D0MS5YlOeHGBGBGHZRIlmVa3Gwmwt3pvgVAbdXJyNJRrCtaxhWnzAG OdTw== X-Forwarded-Encrypted: i=1; AFNElJ+wj0J92vHRyryizpd6ZHEIKM6jm95WtxT/1scidIs7W4sINGQr0Rkpxq3Rf1A2nfuPVktlvUX3wp90iOc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzz41oEX0EGaGiS3iMESQYCneKZaP2pWEqocsKYlWiBKaA7lNvV tWXRIN9kB2uX3Z1IdBvqZ4GXZVnZeCtmVHarqRJAhGtFYnRjj6VUFdleezGX0Aw2UosL0hu22xy qCP/qzA== X-Received: from dlea14-n1.prod.google.com ([2002:a05:701b:420e:10b0:12c:49a5:e4a4]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:60c:b0:12a:713b:8958 with SMTP id a92af1059eb24-12c73f7596bmr17260924c88.10.1777081735213; Fri, 24 Apr 2026 18:48:55 -0700 (PDT) Date: Sat, 25 Apr 2026 01:48:42 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.54.0.rc2.544.gc7ae2d5bb8-goog Message-ID: <20260425014842.1036981-1-boolli@google.com> Subject: [PATCH iwl-next v2] libie: log more info when virtchnl fails From: Li Li To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , Brian Vazquez , Li Li , emil.s.tantilov@intel.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Virtchnl failures can be hard to debug without logs. Logging the details of virtchnl transactions can be useful for debugging virtchnl-related issues. Tested: Built and booted on a test machine. Signed-off-by: Li Li --- v2: - Use dev_warn_ratelimited instead of dev_notice_ratelimited based on reviewer feedback. drivers/net/ethernet/intel/libie/controlq.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethe= rnet/intel/libie/controlq.c index ebc05355e39d..bf200fea1e12 100644 --- a/drivers/net/ethernet/intel/libie/controlq.c +++ b/drivers/net/ethernet/intel/libie/controlq.c @@ -762,6 +762,16 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_p= arams *params, status =3D ctlq_msg->chnl_retval ? -EFAULT : 0; =20 xn =3D &xnm->ring[xn_index]; + + if (ctlq_msg->chnl_retval) { + dev_err_ratelimited( + params->ctlq->dev, + "Non-zero virtchnl ret val (msg op: %u, ret val: %u, msg_cookie: %u, da= ta_len: %u); xn op: %u, id: %u, cookie: %u\n", + ctlq_msg->chnl_opcode, ctlq_msg->chnl_retval, + msg_cookie, ctlq_msg->data_len, xn->virtchnl_opcode, + xn->index, xn->cookie); + } + if (ctlq_msg->chnl_opcode !=3D xn->virtchnl_opcode || msg_cookie !=3D xn->cookie) return false; @@ -1011,6 +1021,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_par= ams *params) params->recv_mem =3D xn->recv_mem; break; default: + dev_warn_ratelimited( + params->ctlq->dev, + "Transaction failed (op %u, xn state: %d, id: %u, cookie: %u, size: %zu= )\n", + params->chnl_opcode, xn->state, xn->index, xn->cookie, + xn->recv_mem.iov_len); ret =3D -EBADMSG; break; } --=20 2.54.0.rc2.544.gc7ae2d5bb8-goog