From nobody Fri Jun 19 09:10:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E73540DFD5; Sat, 25 Apr 2026 12:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777120723; cv=none; b=WhLqIPjAheA/2/4VgrLd5k+lK3Y/xaP9VbH9yrp9tu5lip7WgBAfQTH67Y7iDZCCRDpudH6N+Z/najczhN4IOYgxIaVSytEdI1QKxQ4vzisB2tWNIhexF6gBdGPkwyLmRuONJCXHlkROXD21bNRgmEZd6/gjb8Rdi8ymmZKkFgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777120723; c=relaxed/simple; bh=Ind4ewbTlV0VMaMhRBhUOAJ51ivGX/THmUva9v/9gmM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=V3ieoTl9976kdPZEMiAJHLv/72PTAzuTebFBLLyCsWsNcPsQ5LNDgzQE5nfbdhSwmjz+Xl0vMwoNSDvU+evyxAxe9ykHOIsKJRk2QqIYLzzh3DE3b2b4qIA2CANOgDktuzircrjct97l38D+zIYkTZcEohLuOpi0cwo0L42CRwg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kM7gWoJA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kM7gWoJA" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1C958C2BCB0; Sat, 25 Apr 2026 12:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777120723; bh=Ind4ewbTlV0VMaMhRBhUOAJ51ivGX/THmUva9v/9gmM=; h=From:Date:Subject:To:Cc:Reply-To:From; b=kM7gWoJApE75qJV/GMLkMtKlPQti+IbS5dir8eZXg8vc4a+WDzunSPTzQMNkZaVWy r89J97mlPj1uXpgaHQJVe9TGctiAFPTEuSvFV/i2YMDQI0nHz2Xy6JhSnI0wxR1Us5 nX+fDiKU3i1YUfd3ZxCLScAY4smiTuWHHcHCF2DgZNB1Nv/6nMAV1+bpMRLx4HuX3A P8Q+P+tbNMgxbvKMAPADDdGfMB0jIl59/3MmsdWzXGfjFKTZH91fwU80RjSDBvPdU0 dwobEhpul06D58KHXahHPqjsVF6BANWvHaQUJsm/E+lNJr9WRpZVMgE22aW9VPe5Pf Vli0FxDwA3KIQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 124F3FF8861; Sat, 25 Apr 2026 12:38:43 +0000 (UTC) From: Abid Ali via B4 Relay Date: Sat, 25 Apr 2026 12:38:34 +0000 Subject: [PATCH] net: stmmac: fix RX DMA leak on TX alloc failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260425-stmmac-rx-desc-cleanup-v1-1-1a18a704c422@gmail.com> X-B4-Tracking: v=1; b=H4sIAMm17GkC/x3MQQqEMAxA0atI1gZqScXxKoOLUqMGtCPNKELx7 haXb/F/BuUkrNBXGRKfovKLBU1dQVh8nBllLAZrbGvIOtT/tvmA6cKRNWBY2cdjRyIzGdeRo4+ FEu+JJ7ne8Xe47we0+LlFaAAAAA== To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abid Ali X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777120721; l=998; i=dev.taqnialabs@gmail.com; s=20260425; h=from:subject:message-id; bh=6KNXYVuQw7qzkBuKkHzTHDqB5iOSzE7NC8yleiDYCcg=; b=EahVl7YbST7PFQZTcka11Q36pigH8utz9YqMXE8P+DU+sn23jzKVHG85DfrDfWEzR+sWFhWOw /h/aEKBo3ucCFAMZBnSU4000q8fFB8aF7BvvRihgWI7wK5bi7GsKhhe X-Developer-Key: i=dev.taqnialabs@gmail.com; a=ed25519; pk=4Syx51HH/MOySSUpi79M2ToLOdwt1yiNb338eKZBJNk= X-Endpoint-Received: by B4 Relay for dev.taqnialabs@gmail.com/20260425 with auth_id=752 X-Original-From: Abid Ali Reply-To: dev.taqnialabs@gmail.com From: Abid Ali Free RX DMA resources when alloc_dma_tx_desc_resources() fails in alloc_dma_desc_resources(). Signed-off-by: Abid Ali --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/ne= t/ethernet/stmicro/stmmac/stmmac_main.c index 13d3cac05..8bb843b55 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -2370,8 +2370,12 @@ static int alloc_dma_desc_resources(struct stmmac_pr= iv *priv, return ret; =20 ret =3D alloc_dma_tx_desc_resources(priv, dma_conf); + if (ret) { + free_dma_rx_desc_resources(priv, dma_conf); + return ret; + } =20 - return ret; + return 0; } =20 /** --- base-commit: 028ef9c96e96197026887c0f092424679298aae8 change-id: 20260425-stmmac-rx-desc-cleanup-440f05845492 Best regards, --=20 Abid Ali