From nobody Fri Jun 19 07:51:32 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88DA0260566 for ; Fri, 24 Apr 2026 12:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777034771; cv=none; b=Je34W37ZJ8+DJF6w4VERK3mwZiINiSCePnmgUZ0CLwA3JabGB3Quq+WZtL9+tYM/GPvpjwsHNSwt4ZZcy3yxoXxTHqvjruLRqEi2F1ySFhGpR5LV5FyPu+pb0asBPsqg3VvF6CdhZHJpnYgGFwCc0qKjRyi/0pd041yzADMFOg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777034771; c=relaxed/simple; bh=3uyOJsnKokCQyqlEyJClcdUU0NGgMfuB/CmjSE9vRvw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a7/KxBaB7Yh9XN3amhkgQaHjffPFWr/ZRR+yYs5c6DQQvgnuTO5vsxTQ+KXJwcQVNbDYMFgQUwzM1U5Ki/A9R1oD82HWUOFRKPyylQammu9tJPqBeKPBS5gPJmyxYQAp4Q4HTIL9V+YMHnpdBf3VA38Jo1e43QNLG5c9WR32QgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=KHzSF6tl; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="KHzSF6tl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=5r 0o7mLKi250C8auX2QzQkF3sv+tYItmksBtWh9gy6E=; b=KHzSF6tljpR9gH9CwO D68jxylwibcSyIPVr1vLnOc94iqRz9qIxKG/FnQBx85jU7FqNYpq5ScKOJJ8uiTf vI6QY5pTt9W4fzup/qSAaRi3OYUd5ydK3o+q2WRsND+VNEWEwBLt9lv54HJrcq/f MiePjuS32Je+l9URJ6+zmXMsM= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g1-3 (Coremail) with SMTP id _____wAXzs63ZetpEjsBBg--.49385S2; Fri, 24 Apr 2026 20:44:40 +0800 (CST) From: Shixiong Ou To: Dave Airlie Cc: Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou Subject: [PATCH v3] drm/udl: Increase GET_URB_TIMEOUT Date: Fri, 24 Apr 2026 20:44:27 +0800 Message-ID: <20260424124427.657-1-oushixiong1025@163.com> X-Mailer: git-send-email 2.47.1.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wAXzs63ZetpEjsBBg--.49385S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WFyUtrW3ZrW5WFWUJrWfuFg_yoW8try7pF srJrWjyrW5ZFWDta17tF4vya43Jay3GaykGrZ7Gas3u3WUtrn8J34kAryYgFy8Z3srCF1a qrs2vrZ0vF45Ar7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Uq385UUUUU= X-CM-SenderInfo: xrxvxxx0lr0wirqskqqrwthudrp/xtbC-hjc62nrZbjkCwAA3h Content-Type: text/plain; charset="utf-8" From: Shixiong Ou [WHY] A situation has occurred where udl_handle_damage() executed successfully and the kernel log appears normal, but the display fails to show any output. This is because the call to udl_get_urb() in udl_crtc_helper_atomic_enable() failed without generating any error message. [HOW] 1. Increase timeout of getting urb. 2. Add error messages when calling udl_get_urb() failed in udl_crtc_helper_atomic_enable(). Signed-off-by: Shixiong Ou Reviewed-by: Thomas Zimmermann --- v3: Remove GET_URB_TIMEOUT macro and pass 2 * HZ directly. drivers/gpu/drm/udl/udl_main.c | 3 +-- drivers/gpu/drm/udl/udl_modeset.c | 5 ++++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c index bc58991a6f14..b4c23dbcf3e3 100644 --- a/drivers/gpu/drm/udl/udl_main.c +++ b/drivers/gpu/drm/udl/udl_main.c @@ -285,13 +285,12 @@ static struct urb *udl_get_urb_locked(struct udl_devi= ce *udl, long timeout) return unode->urb; } =20 -#define GET_URB_TIMEOUT HZ struct urb *udl_get_urb(struct udl_device *udl) { struct urb *urb; =20 spin_lock_irq(&udl->urbs.lock); - urb =3D udl_get_urb_locked(udl, GET_URB_TIMEOUT); + urb =3D udl_get_urb_locked(udl, HZ * 2); spin_unlock_irq(&udl->urbs.lock); return urb; } diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_mo= deset.c index 231e829bd709..1ca073a4ecb2 100644 --- a/drivers/gpu/drm/udl/udl_modeset.c +++ b/drivers/gpu/drm/udl/udl_modeset.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include =20 @@ -342,8 +343,10 @@ static void udl_crtc_helper_atomic_enable(struct drm_c= rtc *crtc, struct drm_atom return; =20 urb =3D udl_get_urb(udl); - if (!urb) + if (!urb) { + drm_err_ratelimited(dev, "get urb failed when enabling crtc\n"); goto out; + } =20 buf =3D (char *)urb->transfer_buffer; buf =3D udl_vidreg_lock(buf); --=20 2.47.1.windows.2