From nobody Fri Jun 19 16:02:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF0AA36404E; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026538; cv=none; b=mkB1dOEuKnf+VySNnrTLZpAsLOhFOTbUMccInMBzAfrHEMinrYie0sB2A9JMVFWQE1Ae6SsK3oFPM9I4P8C7V3eynWQmucyxls5k3+vvAJ410dW+y5GiMfiwy2UbV26mUnXZRGnvxSZ0wLZTeiQZcIwV6eayDzQTsEZUPKlmKxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026538; c=relaxed/simple; bh=mBLk79tpLvFZr9NTaxRLYUufLtc4UoesdD3r8nUWZ38=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OEcqfUVqQ0euZ0jRufT6F94ZF6KIaquEwimkxG5kItRBUpy+xbih001++txby7gJXSeId4ll9fox247nvxhZDN4SOnJOjIHnwXJ5DMXECuZlPEsQEeE0K16en/noiN3HPFpAzcWhodo4LmBnSA4NJMH5OvP4EpJOqjU0NOzQKIM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=To/ca2/u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="To/ca2/u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88884C2BCB5; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777026538; bh=mBLk79tpLvFZr9NTaxRLYUufLtc4UoesdD3r8nUWZ38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=To/ca2/ujYPSc773yko2Uu2VCOCbQLsbwqbC0jR8Tp/Vmdq5H6bRQ3SUF9DTqKmq1 XIvaiQ5pas6PHlZhzNaSZU8+0BFf+JS/6BdL18JEYJaCISwSIOe3hhk4tNbPPIRW8T EQleT1dwZicQaDa/qaWp2nanlaBYhym4MaRaGAbjaao/2aGMyttK9N8Sni+0mRusM9 gRO0KAA33edI/1WFdcEvuk4e7FLHLXUmG/Wevf8QPop5z+hHVd/eJF2EpPWnuGy6dr zTmJL5mi5tsCXnMw4tJHDmXJiI8/luvxw54KYtr476aN4UEKpEblYW6ikITQj81hZ3 l3YaENhvZGljA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGDmK-0000000AyYU-1k5c; Fri, 24 Apr 2026 12:28:56 +0200 From: Johan Hovold To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Levente Kurusa Subject: [PATCH 1/5] MIPS: ip22-gio: fix kfree() of static object Date: Fri, 24 Apr 2026 12:28:45 +0200 Message-ID: <20260424102849.2616035-2-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424102849.2616035-1-johan@kernel.org> References: <20260424102849.2616035-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The gio bus root device is a statically allocated object which must not be freed by kfree() on failure to register the device or bus. Fixes: 82242d28ff8b ("MIPS: IP22: Add missing put_device call") Cc: stable@vger.kernel.org # 3.17 Cc: Levente Kurusa Signed-off-by: Johan Hovold --- arch/mips/sgi-ip22/ip22-gio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c index 9eec8842ffb7..a574441fa44b 100644 --- a/arch/mips/sgi-ip22/ip22-gio.c +++ b/arch/mips/sgi-ip22/ip22-gio.c @@ -30,7 +30,6 @@ static struct { =20 static void gio_bus_release(struct device *dev) { - kfree(dev); } =20 static struct device gio_bus =3D { --=20 2.53.0 From nobody Fri Jun 19 16:02:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E77DF366816; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026539; cv=none; b=PAjMrbvZE7Z4Lb4loxEw6b2ysI1ZgNzSxoCd1B+N6ybgB9syHaHhkOwzIDYHnSjrxq+cZh1VDFTYAL47+WsN8Ucuxy5PDQcT6ArhlEm8Vg65QBwvWweudFYc19LbHIieVPLCWTs8S2G5LCx5U6ItdI/i6spkDcJ5o07gYsuEIdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026539; c=relaxed/simple; bh=RMhz1PsBiyG4tTItzIZDeqBjCCwN+4jIIJ/RtVNaaHE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rdyp05j0pT2GSn7AhB9+rqdMr74NXx9hffDYc+R6rDn16gAHEUpP5X/84BA7ydMRtcfDBU9BKUrwtCcrPBcqZP1Loi+Ceo0LoUp5IbuX6KcpWsOV1ZvQFuQEFw1vgwDSnRRS2QHxeW7cU/6ppsFXB7zj8CYn9+q42NqvIMCXiuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Uy2u3pVV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Uy2u3pVV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90C17C2BCB8; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777026538; bh=RMhz1PsBiyG4tTItzIZDeqBjCCwN+4jIIJ/RtVNaaHE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uy2u3pVVHvGZIARSbxdEoVorSbDUpeOs1HzbWc9hY93PNpTsr1HcbURf+uMxIFb5X ZAuWuw0ugN3lDveS7Zn/nOXXCDZqkidVfzkJmYjoJYd50tcAfg/GukmKnktRl5rONt LfT3zFmo1VXQsucuGSpvj0ipHcc69Qdl5FUSUTx9SDLNKMPtZ6ZqHJxgTukQmwNArv xgiMDN5X+2V/lJNSjiG/RCQ2qe1pcc5hTy9BUK6JbfISTpRc2Q2sGsnN4CGwG/SVK0 3GhL/siVu0suU4BDdiKWJvIj6+B0Jp611ny099ShpoCk/bRstJ0IHlL/pNAqeYDMLF ro0qfsKhs+JmQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGDmK-0000000AyYW-1mO4; Fri, 24 Apr 2026 12:28:56 +0200 From: Johan Hovold To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/5] MIPS: ip22-gio: fix gio device memory leak Date: Fri, 24 Apr 2026 12:28:46 +0200 Message-ID: <20260424102849.2616035-3-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424102849.2616035-1-johan@kernel.org> References: <20260424102849.2616035-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The gio device release callback was never wired up so gio devices are not freed when the last reference is dropped. Fixes: e84de0c61905 ("MIPS: GIO bus support for SGI IP22/28") Cc: stable@vger.kernel.org # 3.3 Cc: Thomas Bogendoerfer Signed-off-by: Johan Hovold --- arch/mips/sgi-ip22/ip22-gio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c index a574441fa44b..2f5c6c6f8254 100644 --- a/arch/mips/sgi-ip22/ip22-gio.c +++ b/arch/mips/sgi-ip22/ip22-gio.c @@ -100,6 +100,8 @@ int gio_device_register(struct gio_device *giodev) { giodev->dev.bus =3D &gio_bus_type; giodev->dev.parent =3D &gio_bus; + giodev->dev.release =3D gio_release_dev; + return device_register(&giodev->dev); } EXPORT_SYMBOL_GPL(gio_device_register); --=20 2.53.0 From nobody Fri Jun 19 16:02:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF241365A07; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026538; cv=none; b=Yaaw83IDLZhQw1NBGi7cVoS1+eaJeHvj/0QG0GqbiaiOGDsxt93naYzJr55OamTEYLIqoc1Fs/XdoBScs794ktHPjj6nSjdIPQGmj4Cul40DsmvkoeabXIU7qr3/EWpoLLvnIOB3csled8rTxn0sP40zXGwpT8lcsZvXtl7e/0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026538; c=relaxed/simple; bh=5fSbprhbuJCT7074gb9C0N4PXZSwAueInjsh8DXULfw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X8k/UU17YnG962fsRBKsoVBTgrGeSp8sYubQ5d67FagJaSH8KItBH4yj6xKjrdqAEhp3T2m6N4fnKjfzbShbVj+de27jIkl+8y/jpxtnHMXMVXW/ATRSCH3BJtQ+xX5F1vyUbkwf6BIcdoT5Xnk+DjnRqcxg7d8qfQWPWNLK4+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eEWKR/aF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eEWKR/aF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81B65C2BCB4; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777026538; bh=5fSbprhbuJCT7074gb9C0N4PXZSwAueInjsh8DXULfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eEWKR/aF6TVvXD+vKd9S7NrAJohlWN4rQQNRcgvmWQQo36wtYhB+efmVh5UdSm7p+ MCI6WZoeL/VDL/Cg0bTfpcT2UIZAdju1RKP6Ln08j/r6uI3NVVIXPEdVHpxkSB0/i+ /rB5JQ3J3hp/1TfXGEF8Du69wrzJJYGEzwuJlae/9tvQazOIOacK+YnOeiF/nhKaZH 8qe7dBoLizAVgDMLrSgk3bYs5I6FhpUXNxO4a4Z9JgzGtyrqhncXSptlArRufIRHIZ IWo0pSj6P0HcJGs1VWHqpsOjXJZcywgT2Q08S5gyXGByh1Al+MsYJR3ZJ4R1r2fDRF FDN/iSpfPV0xw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGDmK-0000000AyYY-1ojd; Fri, 24 Apr 2026 12:28:56 +0200 From: Johan Hovold To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 3/5] MIPS: ip22-gio: fix device reference leak in probe Date: Fri, 24 Apr 2026 12:28:47 +0200 Message-ID: <20260424102849.2616035-4-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424102849.2616035-1-johan@kernel.org> References: <20260424102849.2616035-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The gio probe function needlessly takes a device reference which is never released and therefore prevents unbound gio devices from being freed. Fixes: e84de0c61905 ("MIPS: GIO bus support for SGI IP22/28") Cc: stable@vger.kernel.org # 3.3 Cc: Thomas Bogendoerfer Signed-off-by: Johan Hovold --- arch/mips/sgi-ip22/ip22-gio.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c index 2f5c6c6f8254..7b7572d11250 100644 --- a/arch/mips/sgi-ip22/ip22-gio.c +++ b/arch/mips/sgi-ip22/ip22-gio.c @@ -133,13 +133,9 @@ static int gio_device_probe(struct device *dev) if (!drv->probe) return error; =20 - gio_dev_get(gio_dev); - match =3D gio_match_device(drv->id_table, gio_dev); if (match) error =3D drv->probe(gio_dev, match); - if (error) - gio_dev_put(gio_dev); =20 return error; } --=20 2.53.0 From nobody Fri Jun 19 16:02:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEF693624CE; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026538; cv=none; b=X83xGWyxEkCwznT1y+imPT3ctybQogKWoDAndIq9m7Sy2iL4fLZUefQ87tZDRwKpWtiF9n84nv9vxd5O7lgZK6kVHZRXxbRPZv/wo1j5iIuQNbMYz3IE0J/Qtw19LgkLNuW0uUNlcvlwYx+9tbdBjEDJNj4dSN+iji/ha8uPxrM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026538; c=relaxed/simple; bh=w2OdcUuGvAFcyC3dr2r29R4Hfc3DtTG6425fV8EP2nk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UQTmGtv6v6C0eF9JY2k1N8VPmGe0mNYN+L7k1BhjyuryGbhsr1OyRdxuQ8GkTkjHe45veEwHGy2sCxjghGMNNE2j6hwZEe0Xx+S8GQ1Q41fDg1FVPevFFjeh8ZbqjEm2X6TSXPKbs/uVxTvYeZdtrr7306ZdwC2UZzWKRWsho1o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u1cQZVVt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u1cQZVVt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EA70C19425; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777026538; bh=w2OdcUuGvAFcyC3dr2r29R4Hfc3DtTG6425fV8EP2nk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u1cQZVVtUqXL+qlNNKyr0huDlM4Y68ifhhXMv28MdrQm6C1R6iq6qBeG2PAHZX4HP 0+Bh/KVtmX06Ga9ire2xTXeEqew5MCQYs2AnRKxDaXhQ2eXZvoarFHQNJJ0WbYidxu D5noZ0dbqZkNNMzuFIiMcYocU60JeHIc45aBECGHaKlmfSlo6rsPn+o7qNQ4N018or 6S/vplFWG2PTg1Bkbd8rK1wwTvbcJ+zUOq/AeF6reXreK5F0FFjxqHe+o+ggudrmCK qjRF0atPQWNOfmDFkrYrr573VaawzL/bhYEBU3m+xXstr1RSxq22qKALzpAJvbxX+z 8xsGB+jwfdS/w== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGDmK-0000000AyYb-1r3g; Fri, 24 Apr 2026 12:28:56 +0200 From: Johan Hovold To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 4/5] MIPS: ip22-gio: switch to dynamic root device Date: Fri, 24 Apr 2026 12:28:48 +0200 Message-ID: <20260424102849.2616035-5-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424102849.2616035-1-johan@kernel.org> References: <20260424102849.2616035-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core expects devices to be dynamically allocated and will, for example, complain loudly when no release function has been provided. Use root_device_register() to allocate and register the root device instead of open coding using a static device. Signed-off-by: Johan Hovold --- arch/mips/sgi-ip22/ip22-gio.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c index 7b7572d11250..d29067430b44 100644 --- a/arch/mips/sgi-ip22/ip22-gio.c +++ b/arch/mips/sgi-ip22/ip22-gio.c @@ -28,14 +28,7 @@ static struct { { .name =3D "SGI GR2/GR3", .id =3D 0x7f }, }; =20 -static void gio_bus_release(struct device *dev) -{ -} - -static struct device gio_bus =3D { - .init_name =3D "gio", - .release =3D &gio_bus_release, -}; +static struct device *gio_bus; =20 /** * gio_match_device - Tell if an of_device structure has a matching @@ -99,7 +92,7 @@ EXPORT_SYMBOL_GPL(gio_release_dev); int gio_device_register(struct gio_device *giodev) { giodev->dev.bus =3D &gio_bus_type; - giodev->dev.parent =3D &gio_bus; + giodev->dev.parent =3D gio_bus; giodev->dev.release =3D gio_release_dev; =20 return device_register(&giodev->dev); @@ -397,11 +390,9 @@ static int __init ip22_gio_init(void) unsigned int pbdma __maybe_unused; int ret; =20 - ret =3D device_register(&gio_bus); - if (ret) { - put_device(&gio_bus); - return ret; - } + gio_bus =3D root_device_register("gio"); + if (IS_ERR(gio_bus)) + return PTR_ERR(gio_bus); =20 ret =3D bus_register(&gio_bus_type); if (!ret) { @@ -420,8 +411,9 @@ static int __init ip22_gio_init(void) ip22_check_gio(1, GIO_SLOT_EXP0_BASE, SGI_GIOEXP0_IRQ); ip22_check_gio(2, GIO_SLOT_EXP1_BASE, SGI_GIOEXP1_IRQ); } - } else - device_unregister(&gio_bus); + } else { + root_device_unregister(gio_bus); + } =20 return ret; } --=20 2.53.0 From nobody Fri Jun 19 16:02:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF1A03659EE; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026538; cv=none; b=iSUUeJH36AZ6fMm9HdtptdxoB2hDaoLz69YV3VxzA1C6grkwDtjXdqGA6cnim5Pk1lqh3Qc+p2aTRepGjwkWo7CTojsveqhNIjVzxWcn1UAv1BxxLTYSy/1d9uLLRSIFqe/ww/cp3d2K9cnCNnZh6iLQpX5PXJ92nrY3SzfsiAw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777026538; c=relaxed/simple; bh=z6jQiS7MBBek79gvin91VtA4F7jVQKv7lYbFngaMz8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lM5VMatyOyKviI6vmm8Pck6+UI0I5nH4u1G/w9t8+G1oEdTmNIosOKKRLjB850rZA/GmUlYFc/Ue4S6ReRZ8XvgCpOjvipK6U4n8tUaLfqERU5wHX1ElY567LYgP1SmWMAtAtENXonISKtcaQkBminJeNNBeo8LnsOWiLti7TCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=phMuGqey; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="phMuGqey" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86758C2BCB7; Fri, 24 Apr 2026 10:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777026538; bh=z6jQiS7MBBek79gvin91VtA4F7jVQKv7lYbFngaMz8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=phMuGqeyha5WGtbZskVC2dfkaVg1Q0IJDuUBLwxr2N1Rj/RybqcqL5AJ3/QQ2qU84 gW73bjHiwO9+dmmK2o7LC2fk27gM/ySDmhkRLeu1xp0DLBpY6sf5SM+vFRaP8JkO6O OX8RZlUj1OuMscYDNAmF6D0XFiFwr7fr/oGwqemUWfJsrdZ8tvH8/u4FmlXC1L/vyw 0nL038SuihLxTe4fvf6k7b+EeA03WcL/d1LlaJxnVbI3Yhy4xlU40nTSbCAoETAQM5 +e5Ut+kdAGdwA75fx2WM5bNjmMicik7DsaXQDoIn0MIdWTDe238LpOEthhLRrr9fvr J85GlzVktiFMw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wGDmK-0000000AyYd-1tQk; Fri, 24 Apr 2026 12:28:56 +0200 From: Johan Hovold To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 5/5] MIPS: ip22-gio: do not export device release function Date: Fri, 24 Apr 2026 12:28:49 +0200 Message-ID: <20260424102849.2616035-6-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424102849.2616035-1-johan@kernel.org> References: <20260424102849.2616035-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is no need to export the gio device release function as the devices are reference counted. Drop the export along with the unused inline wrapper. Signed-off-by: Johan Hovold --- arch/mips/include/asm/gio_device.h | 6 ------ arch/mips/sgi-ip22/ip22-gio.c | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/arch/mips/include/asm/gio_device.h b/arch/mips/include/asm/gio= _device.h index 159087f5386e..f9c102f038d6 100644 --- a/arch/mips/include/asm/gio_device.h +++ b/arch/mips/include/asm/gio_device.h @@ -37,12 +37,6 @@ extern void gio_dev_put(struct gio_device *); =20 extern int gio_device_register(struct gio_device *); extern void gio_device_unregister(struct gio_device *); -extern void gio_release_dev(struct device *); - -static inline void gio_device_free(struct gio_device *dev) -{ - gio_release_dev(&dev->dev); -} =20 extern int gio_register_driver(struct gio_driver *); extern void gio_unregister_driver(struct gio_driver *); diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c index d29067430b44..54e17c8693e2 100644 --- a/arch/mips/sgi-ip22/ip22-gio.c +++ b/arch/mips/sgi-ip22/ip22-gio.c @@ -80,14 +80,13 @@ EXPORT_SYMBOL_GPL(gio_dev_put); * Will be called only by the device core when all users of this gio devic= e are * done. */ -void gio_release_dev(struct device *dev) +static void gio_release_dev(struct device *dev) { struct gio_device *giodev; =20 giodev =3D to_gio_device(dev); kfree(giodev); } -EXPORT_SYMBOL_GPL(gio_release_dev); =20 int gio_device_register(struct gio_device *giodev) { --=20 2.53.0