From nobody Fri Jun 19 08:04:35 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B62F37E2FB for ; Fri, 24 Apr 2026 09:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777022999; cv=none; b=YwBrMkHU9r8L7MGgOMZNpHQK2kod6ESGTaXTo81VAVb3JO/zUvZPnrza1YauAmb5m1J9wL0kj6vhetQI6UJfg8J5XYOu6eaduvMlld/gomAXPrdsti9FgXbGMDJosyJD0q4q9bfhjO+MYrfWG/rzQAEBbf+FRWjtB2MH59ZaRkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777022999; c=relaxed/simple; bh=/l2cqmROFQs33BLokVYKJp8GESRrYrFjRXiK33lecRg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SZB9g0I57SneDF9i684wd26IlNSIivjpZe97Qe0zKOpJScIT7pRZpPA5BPzwPH1fgD/YToEXW5Dp+RNmSyyya/vgFujUI1Q7I1eRtzExotfu3lRD+bb2lMiCAQHs2zjGzOgssuX6nzUVWQmJWVVv0u59vQprFpn1fIH/bwmlI18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rUNTdQks; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rUNTdQks" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4891f625344so62448465e9.0 for ; Fri, 24 Apr 2026 02:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777022997; x=1777627797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PRmQYDLWnbQPdXE28Inb8Q/Xi2npOv1Gc9ccDpPNZg0=; b=rUNTdQksieiKJpY9dx96Aa/onR4mw6IjN2HXvyl98BHzEAnXgDcca2S3DlKJrUNoBZ 023OXmVqGdrE+y6DR5Edq0UVytwBGoVVF767e3Tqy7uAKrDRfVqxpyJ3hOVwJ8riqX+f dF7HiZNJF4A/jM3JMJZ857iRuhXT6JjDpk94oEE6Cp/Hg6G/UM9zTjxtaxYRdZ3sCzzp v1ZFbYXkdLVkqvQEjxpvFjdud38f4sAPY8r8TOudKDMQ5x3BiHa5vnC8XiBh7u0lr72c 32cWC60SskFBIuZp3e0JyrEvt0jZdNL3w+9AYnNelgN3GvGJhOVdtsdV3e5Src7drp37 fCYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777022997; x=1777627797; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PRmQYDLWnbQPdXE28Inb8Q/Xi2npOv1Gc9ccDpPNZg0=; b=LTXO+YpfaWUDL0oO5Y0mk+PSzZL8Kx79wYQQeHg9sGfNjpB217pWbnJEHKzc7UK6i/ 9HdOP6dXPZeUYNmSAHshqaLTnHjHu9VACq8Jt2OOQiGbnXIFHvMyXUM+EVGpSUci2nUq w5zBk0Cc1/sGl0AZtbHbzuhpvXyn48m3g2KuumLUPK8ezp7dDSMa+QLd105VAlWKVbjD tmSZGxNpCA8FC+14vyN5rUjocpu1fmsXBWDDdeWfNrgW3ZlbpVRARDRMJHhkWY+SroZn VVgBcIsoDke8Hrls/Qno9L78tqaVvK2gkQ89+6dpnaowpDmUHowl1VKaoETPv/qrfapo Bq0A== X-Forwarded-Encrypted: i=1; AFNElJ+GUEP7/PWpZ6FJDpKPeKlBs8eWBQJwtjUZxywvnoNMiDfMgURn9rNEEXWTG8PV9o7/W9pSGCOj9Id6x/0=@vger.kernel.org X-Gm-Message-State: AOJu0YyShl3spHrFc3/naIiNvece7PQQg3hxUXKePXc4UCSuf+Rjb08b ZFXWAoAAbk0YPH8p1IbT4I4CmgveHjUUiwh8cNa0lfdcp8ucQN7MS76RHpU6LH6aljI39w== X-Gm-Gg: AeBDieu1FoNUaRUuEevLEOOTysCgt0NQUolIhpO+mQj5RzK/1GMxuE52Amg1lSWsNkJ CPlA3//u4xq5Ec0mrJsjSfSxaNEsvL/8tROWCcWPftdadVVYTCVPyDDrKbgZKo3fInQxTRYMs9r YCaJyFjJI0hBtRz5oQ6O2lQ/fJ2hfJOXVjFQGy/C/Hk+BhigNKPeuk5yHnkhLs8SYimrK/t+LaP t8yHhoET+BqviKO7BV2ZDFjhT824oAfGgRQ4bzXbyS6i8FKPTkOJyZR74Uk9bmc+3pYhCivubYO +Qh2VGMxKdzxQrogLTh3ctPPo+a42rBjxeeBScjRhHBYatNc1dlImStuh515Yym07VhtrO/VPmK DhYB7qjN3ji2x/koe20p0kGQHiF8SmtPZjjrW1YPt7BPbw/aajkXqEAVjD2p+ZqLdTL/SSrEzVq YFfB0hsBxTFII0uf+Qp1bzADB4M1HAnuW/TXo0iR07XpFB0uXhKAj8/8AjwxEH55x2NzZl4Wmvu 4x85k668oxfFKXttnzLmNIooctede/zaJgsjUOiQ5n+9QXqiw2fv7FupcCzpq9omoWS X-Received: by 2002:a05:600c:4e0c:b0:489:1d7a:4537 with SMTP id 5b1f17b1804b1-4891d7a463emr288514125e9.3.1777022996567; Fri, 24 Apr 2026 02:29:56 -0700 (PDT) Received: from ahossu.localdomain ([5.14.129.42]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a52d232afsm97787865e9.31.2026.04.24.02.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 02:29:55 -0700 (PDT) From: Alexandru Hossu To: andy@kernel.org, gregkh@linuxfoundation.org Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alexandru Hossu Subject: [PATCH] staging: fbtft: fbtft-bus: replace function-defining macro with concrete functions Date: Fri, 24 Apr 2026 11:28:18 +0200 Message-ID: <20260424092818.3322248-1-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The define_fbtft_write_reg macro defines full function bodies including a goto statement and a trailing semicolon on EXPORT_SYMBOL(), which violates kernel coding style (checkpatch reports 2 ERRORs, 2 WARNINGs, and 5 CHECKs). Replace it with three concrete C functions that are semantically identical to the macro expansions: - fbtft_write_reg8_bus8 (u8 buffer, u8 data) - fbtft_write_reg16_bus8 (__be16 buffer, u16 data, cpu_to_be16) - fbtft_write_reg16_bus16 (u16 buffer, u16 data) The function declarations in fbtft.h are already present and unchanged. Signed-off-by: Alexandru Hossu --- drivers/staging/fbtft/fbtft-bus.c | 191 +++++++++++++++++++++--------- 1 file changed, 137 insertions(+), 54 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtf= t-bus.c index 30e436ff1..acd035203 100644 --- a/drivers/staging/fbtft/fbtft-bus.c +++ b/drivers/staging/fbtft/fbtft-bus.c @@ -11,60 +11,143 @@ * *************************************************************************= ****/ =20 -#define define_fbtft_write_reg(func, buffer_type, data_type, modifier) = \ -void func(struct fbtft_par *par, int len, ...) = \ -{ = \ - va_list args; \ - int i, ret; \ - int offset =3D 0; \ - buffer_type *buf =3D (buffer_type *)par->buf; \ - \ - if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { \ - va_start(args, len); \ - for (i =3D 0; i < len; i++) { \ - buf[i] =3D modifier((data_type)va_arg(args, \ - unsigned int)); \ - } \ - va_end(args); \ - fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, \ - par->info->device, buffer_type, buf, len, \ - "%s: ", __func__); \ - } \ - \ - va_start(args, len); \ - \ - if (par->startbyte) { \ - *(u8 *)par->buf =3D par->startbyte; \ - buf =3D (buffer_type *)(par->buf + 1); \ - offset =3D 1; \ - } \ - \ - *buf =3D modifier((data_type)va_arg(args, unsigned int)); \ - ret =3D fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset, \ - 0); \ - if (ret < 0) \ - goto out; \ - len--; \ - \ - if (par->startbyte) \ - *(u8 *)par->buf =3D par->startbyte | 0x2; \ - \ - if (len) { \ - i =3D len; \ - while (i--) \ - *buf++ =3D modifier((data_type)va_arg(args, \ - unsigned int)); \ - fbtft_write_buf_dc(par, par->buf, \ - len * (sizeof(data_type) + offset), 1); \ - } \ -out: \ - va_end(args); \ -} = \ -EXPORT_SYMBOL(func); - -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) -define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16) -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) +void fbtft_write_reg8_bus8(struct fbtft_par *par, int len, ...) +{ + va_list args; + int i, ret; + int offset =3D 0; + u8 *buf =3D (u8 *)par->buf; + + if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { + va_start(args, len); + for (i =3D 0; i < len; i++) + buf[i] =3D (u8)va_arg(args, unsigned int); + va_end(args); + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, + par->info->device, u8, buf, len, + "%s: ", __func__); + } + + va_start(args, len); + + if (par->startbyte) { + *(u8 *)par->buf =3D par->startbyte; + buf =3D (u8 *)(par->buf + 1); + offset =3D 1; + } + + *buf =3D (u8)va_arg(args, unsigned int); + ret =3D fbtft_write_buf_dc(par, par->buf, sizeof(u8) + offset, 0); + if (ret < 0) + goto out; + len--; + + if (par->startbyte) + *(u8 *)par->buf =3D par->startbyte | 0x2; + + if (len) { + i =3D len; + while (i--) + *buf++ =3D (u8)va_arg(args, unsigned int); + fbtft_write_buf_dc(par, par->buf, + len * (sizeof(u8) + offset), 1); + } +out: + va_end(args); +} +EXPORT_SYMBOL(fbtft_write_reg8_bus8); + +void fbtft_write_reg16_bus8(struct fbtft_par *par, int len, ...) +{ + va_list args; + int i, ret; + int offset =3D 0; + __be16 *buf =3D (__be16 *)par->buf; + + if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { + va_start(args, len); + for (i =3D 0; i < len; i++) + buf[i] =3D cpu_to_be16((u16)va_arg(args, unsigned int)); + va_end(args); + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, + par->info->device, __be16, buf, len, + "%s: ", __func__); + } + + va_start(args, len); + + if (par->startbyte) { + *(u8 *)par->buf =3D par->startbyte; + buf =3D (__be16 *)(par->buf + 1); + offset =3D 1; + } + + *buf =3D cpu_to_be16((u16)va_arg(args, unsigned int)); + ret =3D fbtft_write_buf_dc(par, par->buf, sizeof(u16) + offset, 0); + if (ret < 0) + goto out; + len--; + + if (par->startbyte) + *(u8 *)par->buf =3D par->startbyte | 0x2; + + if (len) { + i =3D len; + while (i--) + *buf++ =3D cpu_to_be16((u16)va_arg(args, unsigned int)); + fbtft_write_buf_dc(par, par->buf, + len * (sizeof(u16) + offset), 1); + } +out: + va_end(args); +} +EXPORT_SYMBOL(fbtft_write_reg16_bus8); + +void fbtft_write_reg16_bus16(struct fbtft_par *par, int len, ...) +{ + va_list args; + int i, ret; + int offset =3D 0; + u16 *buf =3D (u16 *)par->buf; + + if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { + va_start(args, len); + for (i =3D 0; i < len; i++) + buf[i] =3D (u16)va_arg(args, unsigned int); + va_end(args); + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, + par->info->device, u16, buf, len, + "%s: ", __func__); + } + + va_start(args, len); + + if (par->startbyte) { + *(u8 *)par->buf =3D par->startbyte; + buf =3D (u16 *)(par->buf + 1); + offset =3D 1; + } + + *buf =3D (u16)va_arg(args, unsigned int); + ret =3D fbtft_write_buf_dc(par, par->buf, sizeof(u16) + offset, 0); + if (ret < 0) + goto out; + len--; + + if (par->startbyte) + *(u8 *)par->buf =3D par->startbyte | 0x2; + + if (len) { + i =3D len; + while (i--) + *buf++ =3D (u16)va_arg(args, unsigned int); + fbtft_write_buf_dc(par, par->buf, + len * (sizeof(u16) + offset), 1); + } +out: + va_end(args); +} +EXPORT_SYMBOL(fbtft_write_reg16_bus16); =20 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...) { --=20 2.53.0