From nobody Fri Jun 19 07:44:00 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A195C246783 for ; Fri, 24 Apr 2026 03:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777001640; cv=none; b=D2XocGtCFy3p4dW0lQMOyo8ZHJx4spB5SawiWq/cOYN1qlQx6a9RaK+yJqZrMesK7aV6Hjt6nTXMGiVofQESI3FvzwVXnaPhRTYQDmj86pb4DXNLA+MpDBZO3mcxVCIqZJK0tZohWbbnnZKYRlRKklo3XNA4u6D2QCkfyk2FTK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777001640; c=relaxed/simple; bh=3g6vPL5+/PxV4UaI5AcFZF+A9nSA/8Iqy3bMWU0IT9c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h5ly6SrRbHwk2X/Aklm18UcLZ3CGhUO/4IWZFlPHSX7MvJ+F8ytL3PONFKcYJruiyCGOgd4c0OFLN94FNR0X0DUJAV4K31x8pWgAfCEdsKLHAJeEdU4gleeRVoIMKUsNzhiT80R/rBtS6vmtO4FHLjDjg8VthhzWBIdnQMe2d6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ipGVJrgs; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ipGVJrgs" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c76b9efc299so2982380a12.0 for ; Thu, 23 Apr 2026 20:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777001638; x=1777606438; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HjcmI+vdIFbJbnXF21GNXemf/C/ERw0Tr8dDCWxWsys=; b=ipGVJrgs6/ZJZaaFA8ghhLEcqSDnfMJOEi2e6Y6jGCjvy74rj8ccCzMEQrSauIlR2R pNPigBXr7s6kPasx9KntXU7v7BDpFrV/KEB815gacpT3tYUs1zd1ZEtUmQFsL2n28CBM yB86gf/wxO/9EwYgCxad3QeLF2X8GI7s340O1Qak6mVJwtAaeCj0y7JcKDuCn7JlpDM5 EGhKCJgpppvUtp2kAaOIzvzwePySugRfiyxlg5s1OCRDljP4TGoQJUoQOTW4cxXqzdwY si31WZOet0KO+R7nS0PhD5M+w2G/jdyKIu9OnzXepS9916awvViAM/SEMxV18fU24IgU YJqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777001638; x=1777606438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HjcmI+vdIFbJbnXF21GNXemf/C/ERw0Tr8dDCWxWsys=; b=a4mrYVdhA2UgiHt+O+f9UihLxIKmhY7sDO7sMO/3n/W7OGbYsLjH5tdS3cda5HnHxT cFTHVigVrdmsiIJ3PmVRW4ckQmcL5U2AYrJ8R0vKNbEQWEvxKfR4piRmYZx4OYypGWGw eaqdyEkwOMYRK+gKWw5cT6sbIp1Zqj1O5LrxCBN/EX/DsJbUNPC4ccmg4cYxMPmydSZ6 UvoWzkEHDABLXgg0vDFtKKet8KcIUxeUh5ZFrG9E3Rd27FzhS7Tymqy97Vqc6ydu6Emr vOW7acTQkJLDLuTwR4mOzhexYZS+rmVvBVF1JT5rMNUTp6IkaHoHcNdZ/qkdLdxNcVI/ v0cA== X-Forwarded-Encrypted: i=1; AFNElJ9UBCkVNh96Zzl9Kc3kWhu7uE4/5y5V6Z3Y/vsK/gGvyVBFrqdcAoDry2QxN4vqu9AmdLWxWZOxiC0TWGU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxxf3hCUXaKB079pe4ZuVuCgIImteHKVtf9ipcb9wXbr6kwYYC+ BUEJWbnOKtfB46ikcopUSWk7yeEU1g63vjAjO3qcAkbYv/348YY61Koo X-Gm-Gg: AeBDiet1JDVs50YlRNoZSbdawT2+TAgUvAcwmh9E7rn3afXELyu4MUzYTc3Mf2okfUX 0ICpibxz+mhTFDPSvotJ325grfCzm/S6d1WJvmFOoo2VmN2Y6g6UdpocC1ZD6uF+QB7nkQKVJEM Q72DZ3MTVeuFQ79HjzzIhMMG9qQxcaSnrfoybUWC+i3U0eW3tDIb1EZR5FRBPMUt2CoRnn9XGU8 WM80tQS10kKhQ+cv8eU1hzUbkvIDsa/cEKNPIyMab0//BAMz+DZ/mnTWb5aI91yZ+C/al1+FJbM aRb1RzvI2Uh+voFHlGrQlaN2KJDt/wB2o+C76bmM8H8V33vvx9a0Das2N53GzrfBUuXuBCs3DDH swirO6aJ5HXLMvVgQt0tQR82FlKaPCETlu5+v371ZXmLq6ytC7aAKM+OPa2ID8ZptA2nugg0PVn 8tqmw5wI5e6ZwhEbZZs5TDmSaAKsNvns49VeH3QIuMLLgwt6xOeGZBqe+CAAdhZP2XOSU0t7Rb X-Received: by 2002:a05:6a00:2993:b0:7e8:4471:ae55 with SMTP id d2e1a72fcca58-82f8c92a621mr30886720b3a.33.1777001637956; Thu, 23 Apr 2026 20:33:57 -0700 (PDT) Received: from ubunut-vm.. (c-73-240-82-137.hsd1.or.comcast.net. [73.240.82.137]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9cbb1dsm23797624b3a.14.2026.04.23.20.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 20:33:57 -0700 (PDT) From: Joel To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Subject: [PATCH v2 1/2] sungem: fix pointer formatting and indentation Date: Fri, 24 Apr 2026 03:33:47 +0000 Message-ID: <20260424033348.1917-2-joelcrouch@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260424033348.1917-1-joelcrouch@gmail.com> References: <20260424033348.1917-1-joelcrouch@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Align with Linux Kernel Coding Style by placing the asterisk with the varia= ble name and correcting indentation in bcm54xx_read_link. --- drivers/net/sungem_phy.c | 53 ++++++++++++++++++++-------------------- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c index c10198d44..44cbe1938 100644 --- a/drivers/net/sungem_phy.c +++ b/drivers/net/sungem_phy.c @@ -44,27 +44,27 @@ static const int phy_BCM5400_link_table[8][3] =3D { { 1, 0, 1 }, /* 1000BT */ }; =20 -static inline int __sungem_phy_read(struct mii_phy* phy, int id, int reg) +static inline int __sungem_phy_read(struct mii_phy *phy, int id, int reg) { return phy->mdio_read(phy->dev, id, reg); } =20 -static inline void __sungem_phy_write(struct mii_phy* phy, int id, int reg= , int val) +static inline void __sungem_phy_write(struct mii_phy *phy, int id, int reg= , int val) { phy->mdio_write(phy->dev, id, reg, val); } =20 -static inline int sungem_phy_read(struct mii_phy* phy, int reg) +static inline int sungem_phy_read(struct mii_phy *phy, int reg) { return phy->mdio_read(phy->dev, phy->mii_id, reg); } =20 -static inline void sungem_phy_write(struct mii_phy* phy, int reg, int val) +static inline void sungem_phy_write(struct mii_phy *phy, int reg, int val) { phy->mdio_write(phy->dev, phy->mii_id, reg, val); } =20 -static int reset_one_mii_phy(struct mii_phy* phy, int phy_id) +static int reset_one_mii_phy(struct mii_phy *phy, int phy_id) { u16 val; int limit =3D 10000; @@ -88,7 +88,7 @@ static int reset_one_mii_phy(struct mii_phy* phy, int phy= _id) return limit <=3D 0; } =20 -static int bcm5201_init(struct mii_phy* phy) +static int bcm5201_init(struct mii_phy *phy) { u16 data; =20 @@ -101,7 +101,7 @@ static int bcm5201_init(struct mii_phy* phy) return 0; } =20 -static int bcm5201_suspend(struct mii_phy* phy) +static int bcm5201_suspend(struct mii_phy *phy) { sungem_phy_write(phy, MII_BCM5201_INTERRUPT, 0); sungem_phy_write(phy, MII_BCM5201_MULTIPHY, MII_BCM5201_MULTIPHY_SUPERISO= LATE); @@ -109,7 +109,7 @@ static int bcm5201_suspend(struct mii_phy* phy) return 0; } =20 -static int bcm5221_init(struct mii_phy* phy) +static int bcm5221_init(struct mii_phy *phy) { u16 data; =20 @@ -132,7 +132,7 @@ static int bcm5221_init(struct mii_phy* phy) return 0; } =20 -static int bcm5221_suspend(struct mii_phy* phy) +static int bcm5221_suspend(struct mii_phy *phy) { u16 data; =20 @@ -147,7 +147,7 @@ static int bcm5221_suspend(struct mii_phy* phy) return 0; } =20 -static int bcm5241_init(struct mii_phy* phy) +static int bcm5241_init(struct mii_phy *phy) { u16 data; =20 @@ -170,7 +170,7 @@ static int bcm5241_init(struct mii_phy* phy) return 0; } =20 -static int bcm5241_suspend(struct mii_phy* phy) +static int bcm5241_suspend(struct mii_phy *phy) { u16 data; =20 @@ -185,7 +185,7 @@ static int bcm5241_suspend(struct mii_phy* phy) return 0; } =20 -static int bcm5400_init(struct mii_phy* phy) +static int bcm5400_init(struct mii_phy *phy) { u16 data; =20 @@ -214,7 +214,7 @@ static int bcm5400_init(struct mii_phy* phy) return 0; } =20 -static int bcm5400_suspend(struct mii_phy* phy) +static int bcm5400_suspend(struct mii_phy *phy) { #if 0 /* Commented out in Darwin... someone has those dawn docs ? */ sungem_phy_write(phy, MII_BMCR, BMCR_PDOWN); @@ -222,7 +222,7 @@ static int bcm5400_suspend(struct mii_phy* phy) return 0; } =20 -static int bcm5401_init(struct mii_phy* phy) +static int bcm5401_init(struct mii_phy *phy) { u16 data; int rev; @@ -270,7 +270,7 @@ static int bcm5401_init(struct mii_phy* phy) return 0; } =20 -static int bcm5401_suspend(struct mii_phy* phy) +static int bcm5401_suspend(struct mii_phy *phy) { #if 0 /* Commented out in Darwin... someone has those dawn docs ? */ sungem_phy_write(phy, MII_BMCR, BMCR_PDOWN); @@ -278,8 +278,9 @@ static int bcm5401_suspend(struct mii_phy* phy) return 0; } =20 -static int bcm5411_init(struct mii_phy* phy) +static int bcm5411_init(struct mii_phy *phy) { + int val; u16 data; =20 /* Here's some more Apple black magic to setup @@ -408,14 +409,14 @@ static int genmii_read_link(struct mii_phy *phy) return 0; } =20 -static int generic_suspend(struct mii_phy* phy) +static int generic_suspend(struct mii_phy *phy) { sungem_phy_write(phy, MII_BMCR, BMCR_PDOWN); =20 return 0; } =20 -static int bcm5421_init(struct mii_phy* phy) +static int bcm5421_init(struct mii_phy *phy) { u16 data; unsigned int id; @@ -548,7 +549,7 @@ static int bcm54xx_read_link(struct mii_phy *phy) u16 val; =20 if (phy->autoneg) { - val =3D sungem_phy_read(phy, MII_BCM5400_AUXSTATUS); + val =3D sungem_phy_read(phy, MII_BCM5400_AUXSTATUS); link_mode =3D ((val & MII_BCM5400_AUXSTATUS_LINKMODE_MASK) >> MII_BCM5400_AUXSTATUS_LINKMODE_SHIFT); phy->duplex =3D phy_BCM5400_link_table[link_mode][0] ? @@ -568,7 +569,7 @@ static int bcm54xx_read_link(struct mii_phy *phy) return 0; } =20 -static int marvell88e1111_init(struct mii_phy* phy) +static int marvell88e1111_init(struct mii_phy *phy) { u16 rev; =20 @@ -592,7 +593,7 @@ static int marvell88e1111_init(struct mii_phy* phy) =20 #define BCM5421_MODE_MASK (1 << 5) =20 -static int bcm5421_poll_link(struct mii_phy* phy) +static int bcm5421_poll_link(struct mii_phy *phy) { u32 phy_reg; int mode; @@ -616,7 +617,7 @@ static int bcm5421_poll_link(struct mii_phy* phy) return 1; } =20 -static int bcm5421_read_link(struct mii_phy* phy) +static int bcm5421_read_link(struct mii_phy *phy) { u32 phy_reg; int mode; @@ -644,7 +645,7 @@ static int bcm5421_read_link(struct mii_phy* phy) return 0; } =20 -static int bcm5421_enable_fiber(struct mii_phy* phy, int autoneg) +static int bcm5421_enable_fiber(struct mii_phy *phy, int autoneg) { /* enable fiber mode */ sungem_phy_write(phy, MII_NCONFIG, 0x9020); @@ -665,7 +666,7 @@ static int bcm5421_enable_fiber(struct mii_phy* phy, in= t autoneg) #define BCM5461_FIBER_LINK (1 << 2) #define BCM5461_MODE_MASK (3 << 1) =20 -static int bcm5461_poll_link(struct mii_phy* phy) +static int bcm5461_poll_link(struct mii_phy *phy) { u32 phy_reg; int mode; @@ -691,7 +692,7 @@ static int bcm5461_poll_link(struct mii_phy* phy) =20 #define BCM5461_FIBER_DUPLEX (1 << 3) =20 -static int bcm5461_read_link(struct mii_phy* phy) +static int bcm5461_read_link(struct mii_phy *phy) { u32 phy_reg; int mode; @@ -720,7 +721,7 @@ static int bcm5461_read_link(struct mii_phy* phy) return 0; } =20 -static int bcm5461_enable_fiber(struct mii_phy* phy, int autoneg) +static int bcm5461_enable_fiber(struct mii_phy *phy, int autoneg) { /* select fiber mode, enable 1000 base-X registers */ sungem_phy_write(phy, MII_NCONFIG, 0xfc0b); --=20 2.43.0 From nobody Fri Jun 19 07:44:00 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F6ED2264A9 for ; Fri, 24 Apr 2026 03:34:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777001641; cv=none; b=Brnfli2xtaI2esEuirqMHOacdiQd3LtAwQgbkDArXPMdAf84ZVrtGR+ynSoI9NLEuuAjTSLw6AcRINF+bH9XeRs629bLp+0yTXC7fgBPCm42d9BGisXfbjb9GFkqGLEW40jFB3K7+R+ru9YRtdo/qs9de8gaEsPrPF9m0dc9Z60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777001641; c=relaxed/simple; bh=0QosxY/o8tb5B1JTDe6dmHhKbgTsbsBuSRx2bY8e0xQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O/MWf9sFYwOG35GNHcTUWdFzXDyI9p0f4yRcOowbl2raQmaGXwkEoSwcQ5UX5V3gtWSFl5jSK9DXVxlSCL83cfCvpvv4BmNHsYs9lBw/rQT5TOvd74vRklOndEmwfsqMmjDk0SqoXzlWqXO4aCpy9ejbhcwxA5rV1yJiL4H+0dQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qTB8tU3i; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qTB8tU3i" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c795f441ff7so5036396a12.2 for ; Thu, 23 Apr 2026 20:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777001640; x=1777606440; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gKZeI69AMY1zWybSYtDN8RDRjMihnobL/AcJ00QScLc=; b=qTB8tU3i60ZkW0mNwY+wvqEU3BSm/bxn2dh1BD0nCst9sg5To596uy4Wlnhj7AC7R5 PQWHPiBeCXL4b4sI+GFIb0SoA1LahNNz9IbLZyUWszH+EqIG+BzvBQTsy6IsJfSuGk7w jPPcgHNl/qwB2NeNXAd35QMgF0fySWcNWt/vyfmX/Z1EDMF7v3F9ciovH5BRU4ZeKO/1 80LCS9iEKHFgKO4Q+/NKMfsSJ33MVKlvJPb1vr1yTIZsK6e3XUfDaOGpO+mHr8w7cmeK 4AnW4Hm9wW/x9hgHABjY5X5aUJPQsFvKtfnK6qfV65xMdx2PNKM48MCynSUWD6cLkQd+ IzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777001640; x=1777606440; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gKZeI69AMY1zWybSYtDN8RDRjMihnobL/AcJ00QScLc=; b=je0SwiNFRvhUM4pYb/HC8tg3EHQQ4Qf8UQZRaggqgOs/fIdi4OITx49cYUGiKMl36+ k5KccQqRKEZaVdw7DA3TE6p6/xzsCh4SU5HT/QGuAUiOcAysFwUR3r1+2mY0mfFfRrqv byzFRV5vkJUPPrZFUGwiPl/TarTUJDFUS9TD7nkj6P2NqWmMa7dvdAsMeOYk3IKuRwS7 fL2nQ5hIUlOa+pIXdrew/7abzZapUG1/4yTHIp3rtoIT5JZ1q/Oorney2D+xbFP7GuzF S7tv8RuabDmVPY3b9J1XvBrUkDgLnNBdH10vee2j7kNN5pGnnizsPj0HmaFBZeKtAaF2 GOBw== X-Forwarded-Encrypted: i=1; AFNElJ+Dg1E7g+60G+ApeKS1rYsm4nrL4R+6MH9qQFxsuMbetc1s1lOdMUuB5eehmB0/pObS15UEd6xa6//coFs=@vger.kernel.org X-Gm-Message-State: AOJu0YypnVg/lfciUQr1C+9oWbIg6vMlPKR6BQWu0rQ27EY28r8Vbzuj MvEkuThVN5bwMAL76lTwbA1otU0GaaQ6+nyXKSs2wOemEwhEUMQnKFvV X-Gm-Gg: AeBDievAlRhpuuxsiC4VZW5zQhHTUdHBXF04mGedyt8uWkQL4OHKpA7P4bav1oTWRhc bFROdI8P37EfcRP0Nl4XYebFWcHfpZ7spXHyGTtlyRSAPJu9oAEikoYG/bPNUsrFzBM1W9OM3KD 0DsOtsBBU1YKoedwl1dZZ/B8UFY/6hQK9tzGBjpwPF3PEv8gF5Usb46iq5jL6wv++DK2b4p1ccA kxpeJ7s+5XAsMYsT/xKmyBKO8qQVwE3U8l1dG6HRSRw0Yj4BQxFk5gRvCuhZC98uXCT3VGkImfF ieUHYcIb8Q+G+a9LWwguGMJCYIhQk+wCUy87lUZ8B7/rnL6CthteeYphe56xPgMAOmLVcH9imWG Y0LlIbffvS4CUByu2UvxagDt3dXtJLFfB9voLPxbRxvs7bSC2LWM2mL760wllE2jHgAYfljwLUR dF0B7iahG8WnCpCMRR4HARjV4E0nwc4O1u9qQGNRd7cKd7d56A/gyphBf4syL7Qd6/XKyU58P+ X-Received: by 2002:a05:6a00:928b:b0:82f:6dad:7b75 with SMTP id d2e1a72fcca58-82f8c8ebc91mr33576208b3a.33.1777001639902; Thu, 23 Apr 2026 20:33:59 -0700 (PDT) Received: from ubunut-vm.. (c-73-240-82-137.hsd1.or.comcast.net. [73.240.82.137]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9cbb1dsm23797624b3a.14.2026.04.23.20.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 20:33:59 -0700 (PDT) From: Joel To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Subject: [PATCH v2 2/2] sungem: validate BCM5411 PHY register reads Date: Fri, 24 Apr 2026 03:33:48 +0000 Message-ID: <20260424033348.1917-3-joelcrouch@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260424033348.1917-1-joelcrouch@gmail.com> References: <20260424033348.1917-1-joelcrouch@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Check for -EIO and 0xffff during initialization to prevent silent failures.= Add error logging to gem_init_phy to report failures. --- drivers/net/ethernet/sun/sungem.c | 8 ++++++-- drivers/net/sungem_phy.c | 7 ++++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/s= ungem.c index 8e69d917d..525aba527 100644 --- a/drivers/net/ethernet/sun/sungem.c +++ b/drivers/net/ethernet/sun/sungem.c @@ -1707,8 +1707,12 @@ static void gem_init_phy(struct gem *gp) sungem_phy_probe(&gp->phy_mii, gp->mii_phy_addr); =20 /* Init PHY */ - if (gp->phy_mii.def && gp->phy_mii.def->ops->init) - gp->phy_mii.def->ops->init(&gp->phy_mii); + if (gp->phy_mii.def && gp->phy_mii.def->ops->init) { + int err =3D gp->phy_mii.def->ops->init(&gp->phy_mii); + + if (err) + netdev_err(gp->dev, "PHY init failed: %d\n", err); + } } else { gem_pcs_reset(gp); gem_pcs_reinit_adv(gp); diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c index 44cbe1938..ec8800c93 100644 --- a/drivers/net/sungem_phy.c +++ b/drivers/net/sungem_phy.c @@ -296,7 +296,12 @@ static int bcm5411_init(struct mii_phy *phy) sungem_phy_write(phy, MII_BMCR, BMCR_RESET); sungem_phy_write(phy, MII_BMCR, 0x1340); =20 - data =3D sungem_phy_read(phy, MII_BCM5400_GB_CONTROL); + val =3D sungem_phy_read(phy, MII_BCM5400_GB_CONTROL); + + if (val < 0 || val =3D=3D 0xffff) + return -EIO; + + data =3D (u16)val; data |=3D MII_BCM5400_GB_CONTROL_FULLDUPLEXCAP; sungem_phy_write(phy, MII_BCM5400_GB_CONTROL, data); =20 --=20 2.43.0