From nobody Fri Jun 19 09:06:06 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ACE433B6F9 for ; Fri, 24 Apr 2026 16:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777049937; cv=none; b=ca4VhhlTj0ahXqP2BeecuLrxl5FHtQld26cOkd5mQ6BUqQhwcwJwyCHoa00OTPkDUAKtj1vSbYPtchu5EiKsHJU5Q9mG7MepvDYX6RN5ZGPA5J9//xiuiL1RFQKeP/WkpZPixZVe6U1S0/bfAOEoccBEMuKcM9LUFpy94K1ny/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777049937; c=relaxed/simple; bh=AzOjxNZrv+J9Fly0aItH1+BiGcAPcSLRn572rDJv24g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=aDsXrLQH2etCALVKEQSrDIexD6gz8euOzFf01mG7XXvlRgVor+5XXI5E3JD70u+vwDVW/Kiz24KzS4ydRlPw/XLSmHs5YFmxrVbD/RO1W8CucYKVKe4Ga8U2Z1WFzcDI+CPmsr8hS6vOwv1zJWaVbED8jrCqzKCuL4oFqeMgdNs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J/nnZDXa; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J/nnZDXa" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-82f69adeecbso3411219b3a.2 for ; Fri, 24 Apr 2026 09:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777049935; x=1777654735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2RXCXJGDvOh2rTTR70eKdmZmyxI9wZ3/3Yn4C43EO+c=; b=J/nnZDXafChGaX9sdDegZJufznr5oB934qAOeMq6p6GOYfc3W2I/nVk60kBL+DM+6X mIesI5psoxFv1DPECRDcFbxN6dTSyTIB4RU8OxGlST2Nwqno3Lkgc8dYb+Gncp9qOEFF BiUHraC7kk6UgKiiliUh3VWnDOiLUTbZyC/yTIAbcBwMPoEUEXn/QPenIa0fm2uaGPZI 69VyphUJXCXUfR5k5bsoYkaEuEP01qPfY8lpY6uCsHFz2T5qlG2woA0x2SJiyGdpd9Dn AmsiSdCvxRGy2r7sTBpoKX6egmN/udaQlXTX8ga3GyYmikRBONV3xeOmVPlNgrElAkB/ P+dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777049935; x=1777654735; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2RXCXJGDvOh2rTTR70eKdmZmyxI9wZ3/3Yn4C43EO+c=; b=QrN6Cdecly0dunEqZPaKk5I42+Q1xH6FyA1oh/wgGqf6x7vwP1vYnXuWDoh6+YyGbk PWQmGffny0pNbLG7lnEdbnY35zllGO2JElu1l9CUjvLjfPqH0AkyDMyOxBhZeCpYmrb5 F7P8JwCRrRxCNPRnn+JbspzPe88ot9+R4YyAuXH4wzaZRJYVaNzlRVRqBjF000r11Rov bu/H4bImJ6JU4fo0OzUDGn59F0DJDmmPosQgxM6XTPPAJMVSByLAy8h8g7OwwkdpKZTT +/xrW7XS/FV41ZPlk1RjwyvQbjBuLon5IRpa9fsEPGXieTQbkvq6aRVEzQO/eOqoMDTV uJrg== X-Forwarded-Encrypted: i=1; AFNElJ97FLENq6tGm7mwUCvBa9zQT01f8sAo90zTrcsAh01ddWm3TyNiXYKsUmaxQ4Z7+yk57z8QZL+BFh2mLHM=@vger.kernel.org X-Gm-Message-State: AOJu0YxU7ngVay4p7fpf5ya/re55uLu3hmXnbL59/LRZ8jNHbuFEMwBK GebYOHqzy2Njb1owJdgpYt12bOvtsSJTp9fVzndsJBAn5xPGU6/lHPSY3/QaVgCJwA== X-Gm-Gg: AeBDieuVlbObYEY87e25Jwk8FRGoa+toIJ1rgC1gzsqF1lTObcBa1GgOFr+ag/SIjTF 1EvqEwomMlW1hwY7qQt3juJFa89tey5o8wAZ+hgvSIfTpNu8w4LsxflCFwW1wwBjqNhIj1kP/0d MHlBMgd8iBCeXEw+6XQh5Wl47svFUrhNg7iDSjXZ0fZTh56+hJVT2RQB1ML/tfV/QJidWqmkAEm 8IRIh+BaZSPxeHpga8WJZbTevdzSMjkkGZE/z8GVvvExy8Zy54D8cW6dJd+y1bn+1k9l5y+OLpp Rk/L8SvjH0KNphWHwjm1zcGUjw6oOxRJUSpsvS+36vW3eWe4XQxXmjYnKbs/pNdWemxiAMjCjmA tako1Gg/6B8FjhZ8D+Tazj6DOpun0YTtUyuPUdRSNbcWCJGE+I++pSIdCXnH4kDy50rACq8bs5y oGnbzZF/JwppB0bseGzCTY0EDcmZQiJaimHUpr36SM3INR59mIvSBm+mB/FL4lV5zxOeLD5D7wf dh8zFdSgAr1p1OwoxyZ1VoxzUqFdWsX6R7lEfdU0ztyo/Y= X-Received: by 2002:a05:6a00:c8f:b0:82c:26a4:df02 with SMTP id d2e1a72fcca58-82f8c9bad60mr35494584b3a.42.1777049935465; Fri, 24 Apr 2026 09:58:55 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9d6adbsm30739984b3a.18.2026.04.24.09.58.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Apr 2026 09:58:54 -0700 (PDT) From: "=?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?=" X-Google-Original-From: =?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?= To: Devarsh Thakkar , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak , stable@vger.kernel.org Subject: [PATCH] media: imagination: e5010: release m2m device on probe failure Date: Sat, 25 Apr 2026 01:58:43 +0900 Message-ID: <20260424-e5010-m2m-probe-unwind-v1-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Myeonghun Pak The probe path allocates the mem2mem device with v4l2_m2m_init(), but several later failures jump directly to the v4l2_device_unregister() unwind path. Since the driver core does not call .remove() after a failed probe, those paths leak the m2m device. Route post-v4l2_m2m_init() failures through the existing m2m release step before unregistering the v4l2 device. Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver") Cc: stable@vger.kernel.org Signed-off-by: Myeonghun Pak --- drivers/media/platform/imagination/e5010-jpeg-enc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/= media/platform/imagination/e5010-jpeg-enc.c index 42ad9ee399..4c250e2275 100644 --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c @@ -1072,14 +1072,14 @@ static int e5010_probe(struct platform_device *pdev) if (IS_ERR(e5010->core_base)) { ret =3D PTR_ERR(e5010->core_base); dev_err_probe(dev, ret, "Missing 'core' resources area\n"); - goto fail_after_v4l2_register; + goto fail_after_m2m_init; } =20 e5010->mmu_base =3D devm_platform_ioremap_resource_byname(pdev, "mmu"); if (IS_ERR(e5010->mmu_base)) { ret =3D PTR_ERR(e5010->mmu_base); dev_err_probe(dev, ret, "Missing 'mmu' resources area\n"); - goto fail_after_v4l2_register; + goto fail_after_m2m_init; } =20 e5010->last_context_run =3D NULL; @@ -1089,14 +1089,14 @@ static int e5010_probe(struct platform_device *pdev) E5010_MODULE_NAME, e5010); if (ret) { dev_err_probe(dev, ret, "failed to register IRQ %d\n", irq); - goto fail_after_v4l2_register; + goto fail_after_m2m_init; } =20 e5010->clk =3D devm_clk_get(dev, NULL); if (IS_ERR(e5010->clk)) { ret =3D PTR_ERR(e5010->clk); dev_err_probe(dev, ret, "failed to get clock\n"); - goto fail_after_v4l2_register; + goto fail_after_m2m_init; } =20 pm_runtime_enable(dev); @@ -1113,6 +1113,7 @@ static int e5010_probe(struct platform_device *pdev) return 0; =20 fail_after_video_register_device: +fail_after_m2m_init: v4l2_m2m_release(e5010->m2m_dev); fail_after_v4l2_register: v4l2_device_unregister(&e5010->v4l2_dev); --=20 2.50.0