From nobody Fri Jun 19 08:13:54 2026 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D45A37474E for ; Thu, 23 Apr 2026 22:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776983554; cv=none; b=kKukvQhVth+AIavgRu5Z4NQhUfyCu4TR9Nx7WT8R99Q2+qqjU3CdIZr8+mBZPTu93pWQPapk6LtP3t2ep3sgu0PieivogxMwyuZ7qw1A/fp5FFZC8wtMndoCBqz8ay0KSQzPtk8VEPLNE3ksXEfdo2+YwBOgb3aqKwbroZLhJhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776983554; c=relaxed/simple; bh=/65LLKhf8fHmkiinSAqwH23iLQo4ufUYTqSFcN1S6EE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=C6aDH/m/yUdMl3L3VfOXt0aij3ur51sXIs1eDK1v0MRBx87T4y9Ew9Eloi4Vz3TgoOuRqrp8zYIarrFcTzXHOag7+IGjvkaFO2uvItbnXp4jBPODBT2hoqNM801cHNAuJr0qNxEJCulSYtI87y4Wsd4ocEc8Hun/jMN3+uL9oZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FglnwS7R; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FglnwS7R" Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-6948e6bc30cso1671477eaf.0 for ; Thu, 23 Apr 2026 15:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776983552; x=1777588352; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DG9zEpUh2A48NeB6NntsKd5rpo1+3n1vamCAhwseVcM=; b=FglnwS7RiNLFnARc4cVHTcv0fNt9NsUv/+WIzmn38cLWBnaD5lz1Prxb1lrl24NAOI zoeBopxOD+uxwJzGqWLTzPM94y/YP7bSBKuMbMib2jpGvo3ks+OTXaf2P2c3HildiJ2p plmir/CVghl3G7dcJgxxxoxZB9R13+HppPSkemXan2sO0XIEpD+37Y6d5yrcFwAAwM7l FhPtnpGL5INOQGzTm8xo2BlhsTXdxM4lVexjsRYJOFEG9B/4sNSu8VPYnsX5i3ekmb4V iJy+ZEZYbgyL5pjw0d/LaoKlkWe0dzT2nJo96e0fllXq4UFo3aCym68A0wHCzbGl8cfZ S8dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776983552; x=1777588352; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DG9zEpUh2A48NeB6NntsKd5rpo1+3n1vamCAhwseVcM=; b=jM5gXHHW5qn8tO3TWkMNCdHM9Cyp38EtJ0CAL/c+gvLNE1th6l9WyeRK424IHBo/Wh OH2QsWZKNNZ3SmkFdRAvuxJ1jxu+qyLOhDkLocNiPbZaEXnpk0zOA8+p5SUEwHw2NuU7 7B+kCgs8gsOMuv+daz/T4SV/Qw003o8gB24d2micmKwJjMiP6AXJQalFx+DFIq0jE/cO gxh4r+Rwu23hyFrHMA9+0O8RX61A+bY3EFs9pR49F2HgAT/mukAFPo5pXTFtUx9lh+Fx Z9ao2uBel45ROHNJ4ez7MrfKYI+9ZJSAHb9hEDAc9dK2H2ZufulRJolYJz+bH18ibqhJ PX+w== X-Forwarded-Encrypted: i=1; AFNElJ87g9S8N+HDxfH+obUuGSTgjWqjeMVPhusie6iomeZT9Fjm2qk0ERxWwG7j9DLHoEx0pJlksNVI5YCx4qc=@vger.kernel.org X-Gm-Message-State: AOJu0YzhBs1IeyQ/OKXT3ScMClzxckiYzKZbejm+6I2A6oTMFqw5Tx7+ /43fomR1JAId0EHrPqlYIfRVoJFr7luAtvdgdPv/DyOijDN+2jGGmyGYeOdYTw== X-Gm-Gg: AeBDieutMXByLgO89b9j3NmrIXpELkfyfl6WEhfe10tV7qdvjpHYbU0sCZ/MTQEu8tb 8FBo9baWaOpPuRjwRa9SiznYl6kUGG3aHiBB4YAgUpfukIsotHeTdpAMc7DNjV1ONcNGwrccGKD k6Uqcp1DvFzi65W+IJ4GC3mkK4+U1Mo8l0QUOdcdjZeaYFuwDzO/HnPtSPNo+kfp8kmbgW6TwTc /htrrzE1VE6kZh/BAs+FLptmardosQrQEqcmDtKYqW5T+pQ67CggCthQNdpapb97JOzNGWbY14O LPJMPNaF7Lo1TmRLBy9vNaGJfcz1mlOCfBJK0wsxW4NHMULwufauU1M/9bI7jW5cHsF/bLOeZRG uB7wfx9vx75d8QlacEMDHpDUhcQQquQd9tNhnWpDnq2zYRuZ4ywiQHnUouZWsKp6Dc8kL9wBif7 wWXNE/sJvo9dfs/zLdqCFAo9YW3aOFj4H0CkswmG0PLXStYTSUNaxxA5539QnLkTdggsu6 X-Received: by 2002:a05:6820:81cf:b0:68e:3db1:bdb9 with SMTP id 006d021491bc7-69462e6450cmr16334071eaf.22.1776983552280; Thu, 23 Apr 2026 15:32:32 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-42ff2b6b2cdsm2472021fac.1.2026.04.23.15.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 15:32:32 -0700 (PDT) From: Maxwell Doose To: linusw@kernel.org, brgl@kernel.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: sim: Remove intermediate pointer variable and harden function Date: Thu, 23 Apr 2026 17:32:30 -0500 Message-ID: <20260423223230.47001-1-m32285159@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the *pdev intermediate variable and directly dereference the pointer. While at it, replace sprintf() calls with sysfs_emit() to harden the driver. Signed-off-by: Maxwell Doose --- drivers/gpio/gpio-sim.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index 13b87c8e6d0c..3c230f94eea2 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -691,15 +691,13 @@ static ssize_t gpio_sim_device_config_dev_name_show(s= truct config_item *item, char *page) { struct gpio_sim_device *dev =3D to_gpio_sim_device(item); - struct platform_device *pdev; =20 guard(mutex)(&dev->lock); =20 - pdev =3D dev->probe_data.pdev; - if (pdev) - return sprintf(page, "%s\n", dev_name(&pdev->dev)); + if (dev->probe_data.pdev) + return sysfs_emit(page, "%s\n", dev_name(&dev->probe_data.pdev->dev)); =20 - return sprintf(page, "gpio-sim.%d\n", dev->id); + return sysfs_emit(page, "gpio-sim.%d\n", dev->id); } =20 CONFIGFS_ATTR_RO(gpio_sim_device_config_, dev_name); --=20 2.53.0