From nobody Tue Jun 16 10:01:09 2026 Received: from mail-ot1-f97.google.com (mail-ot1-f97.google.com [209.85.210.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E94C3909B8 for ; Thu, 23 Apr 2026 19:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776972071; cv=none; b=Ml6R8xK7cuI2tqvGuPMzWzYyOSMFx1wJNdqBaBw4cx+TxgNx5+jFHewXDjhOxIaMwJg9coE2zq3q7fIGwHvnXodNtqn3wcTwew61TONH8jUDadhSUip9xA8YmqArZFw/8tmcNKXtsT41vTKyGu9J+DZwpQJuaeS3GuTtOnKoei4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776972071; c=relaxed/simple; bh=PClqCK07Ka0R4xHcNh3toinjUIw4MEIfybat0KZ60dE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=TZLrU0o2pVJD7+4fwFJaAx8Te/o5111VEQ1KK86rXDntP9h1uTCmT0Bh0WjvKvegx71w6srumu/okYZMHSkNvtkNooMhzzAzz1pB1FjmW7IuePdbNGEYBeoynvEBKRhA7l5MUjIbOc3G1LD7MCrJJ5WLVpVTdZCVPG/om0xgTfE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=RBlztS1T; arc=none smtp.client-ip=209.85.210.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="RBlztS1T" Received: by mail-ot1-f97.google.com with SMTP id 46e09a7af769-7dcdd23fcdfso1790022a34.3 for ; Thu, 23 Apr 2026 12:21:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776972069; x=1777576869; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PML/WCuMNBActDXtR6UnIdfaKpFVfv955aq7RWvn5cI=; b=XiPp/5aQP2uT3gPW9D++3Ka4ozs2XAn5TpCeemGrH60HU2cNs4t/4KKfsKk0cvdE99 3/tJWMSKyikMfpPRWCkeasud/g0VuVOkIDXYrX5D21BMzZ2xBn43IpUgv3+RKrgd2/Dn XlvZeEou4KnOF0uDwtzWc7tGLYMJR19clOCnRrPlOPXjhX4XWUlIRzVTfUOk97v4BTd/ 8PBMatd3qN9q5F0H7FMUCf9KAqo+Mvz7B4DZ+ZgFQB0JEEWnwIZNfACd9FStrwxM15R7 MYHWR04+7wbzF1rLTnS1npbq54lI6V5zy60dEcPie3lEoDQnJW9cOjobpFddYPof7ZrS ys7w== X-Forwarded-Encrypted: i=1; AFNElJ/8UxThyX4YuVRb56dYOCAgKRPtrlNfTbVOObhUjGNjDo6+yHedx1eI+LzN/UlB6Au1Nb+zuqvd9/IP0lY=@vger.kernel.org X-Gm-Message-State: AOJu0YxmOKG/hH8+p4ItTVIAzsn2UqOrJy8U+u7ePDoRSbcrWv1PCeGb 7WXW2taooHXJDfMiQmpkmLKO95iJP6tMmesjnSU+iKP+NTLN9Pm2q2akEjgXEvuHVMNGGszKPlx GE1XoAV1JOKeqldatGdiM3htbkMxIXQda2ZvP8zzxMHSjgGH1stxC8fZ1I36WtcRWCS71kVBZH4 3KX2Pbn0U/2HM45fgMp2hzqDK6bftdXfFCm4jZVNdMH6q8l32UVppsGFRVAg7NjxnP08eaU7Wmu eRsD8uPF+3KejNl X-Gm-Gg: AeBDievdW7nUkVonQR5HieEgmlzOUmtJ2JlOjZH9t6aLo/J1PC3N2uI7mNRV2pIchgA Wiy9tbQ6I3Y7/Ij3M7AU73aEZX0hVFU3zQqwAb64Fxx/8FPX0C55ZznKyyK390ZX9g4stMxxwaf fkSzqDom2pJeWMrGLof8lZ89NXxkGEbkbky0cuRL6ajuDIHFMN/J84rtlY65jzuB4UbjO6/1hhF W7Q4mw6f5it31AWUlNyN69Ywi5J693PEpvvtpEzKnsyC93Ls+3Rx93iUymlNKqUEOzQbe8ZozhU GxaMHlCIetevoc10bel5vNZ7J9JSvS0+cKdbH/fRaZ1gJAyfwnuZiJqD1S/8IUN0Cm7sxVdKbY0 DvPlO22Z7gupHvN8+q09jU54jOrcg+9K3y/W01YgLURJeqcW+9r+RwByM2jbKENTiQm4WqQPEjG RqNKz6+svPWo8P X-Received: by 2002:a05:6830:43ac:b0:7dc:cd0b:58b0 with SMTP id 46e09a7af769-7dccd0b6c32mr12180907a34.3.1776972069010; Thu, 23 Apr 2026 12:21:09 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com ([144.49.247.127]) by smtp-relay.gmail.com with ESMTPS id 46e09a7af769-7dc975ad2b5sm1304284a34.8.2026.04.23.12.21.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2026 12:21:09 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8aca6420fe3so107211126d6.0 for ; Thu, 23 Apr 2026 12:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1776972068; x=1777576868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PML/WCuMNBActDXtR6UnIdfaKpFVfv955aq7RWvn5cI=; b=RBlztS1TxiQJ+hqZ4dYNAXyQwkXdr/4f+6LJgtIvlqIaxH1zyvV6JsrwAV2/vwmTHK JuMfIwiW4QWOnIrs2Cvxlyiqb39jG9DgPSGTVBUob8SUdycyKebCI3bmL1pPPtHOE/s5 HqeV97Vrp1+fWm5kI+iD9VT1wEqzE1qHjNtEs= X-Forwarded-Encrypted: i=1; AFNElJ8cRKEdNefLNTzGvjKD91JxMl6FojdneyurVqTQdHMzhOQQyLJ6h0fCU7uQTdSz47bS2hF80v6gBC6seMo=@vger.kernel.org X-Received: by 2002:a05:6214:2f07:b0:8a4:58ff:f0f7 with SMTP id 6a1803df08f44-8b03addd7a4mr366513166d6.44.1776972067886; Thu, 23 Apr 2026 12:21:07 -0700 (PDT) X-Received: by 2002:a05:6214:2f07:b0:8a4:58ff:f0f7 with SMTP id 6a1803df08f44-8b03addd7a4mr366512406d6.44.1776972067326; Thu, 23 Apr 2026 12:21:07 -0700 (PDT) Received: from mail.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02aa4f1f9sm163260006d6.0.2026.04.23.12.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 12:21:06 -0700 (PDT) From: Kamal Dasu To: Ulf Hansson Cc: Wolfram Sang , Avri Altman , Florian Fainelli , Shawn Lin , bcm-kernel-feedback-list@broadcom.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Kamal Dasu Subject: [PATCH v2] mmc: core: fix host controller programming for fixed driver type Date: Thu, 23 Apr 2026 15:18:55 -0400 Message-Id: <20260423191853.1053936-1-kamal.dasu@broadcom.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" When using the fixed-emmc-driver-type device tree property, the MMC core correctly selects the driver strength for the card but fails to program the host controller accordingly. This causes a mismatch where the card uses the specified driver type while the host controller defaults to Type B (since ios->drv_type remains zero). Split the driver type programming logic to handle both fixed and dynamic driver type selection paths. For fixed driver types, program the host controller with the selected drive_strength value. For dynamic selection, use the existing drv_type as before. This ensures both the eMMC device and host controller use matching driver strengths, preventing potential signal integrity issues. Fixes: 6186d06c519e ("mmc: parse new binding for eMMC fixed driver type") Signed-off-by: Kamal Dasu Reviewed-by: Shawn Lin --- drivers/mmc/core/mmc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 8846550a8892..05444ecf3909 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -1371,7 +1371,9 @@ static void mmc_select_driver_type(struct mmc_card *c= ard) =20 card->drive_strength =3D drive_strength; =20 - if (drv_type) + if (fixed_drv_type >=3D 0 && drive_strength) + mmc_set_driver_type(card->host, drive_strength); + else if (drv_type) mmc_set_driver_type(card->host, drv_type); } =20 --=20 2.34.1