From nobody Fri Jun 19 18:35:40 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E4A4310645 for ; Thu, 23 Apr 2026 14:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776953542; cv=none; b=MXasMzDyrI3ui6HwPy2hmKcxRgLopceuix6bNnkqBw6RUI9B49T/AH3TXcR8szsx3TSI9hyF+vyQPR+w550RbJJp214qSvEat+BVfBpRd8qzmOhPNq6IvgY5kifGaLnSv4UO0TcBZYyZ94sL/4W122G+aVzVhntKBBYkjrwtKHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776953542; c=relaxed/simple; bh=iVrkHiNJtk11/d6znu434sP8113VKra75dP0FGhd3Xw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Cz6ljnU6iJveCo8w6rei0qUJB1PTZHSPthZMQ0V6r8KEbiAq4C2AsfEV921MB44iczM4q+VSYz7zFGe8GGQ0tyVaKwSNQeY5uttCH4VSorgkTf/LHPAxL0roiCC6b82LANzTEOAmJ+QpBLOGIHODYOMvh/YgfCvdEu6jSlu62O0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=crimson.net.eu.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=crimson.net.eu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488af9fdaa7so40743195e9.1 for ; Thu, 23 Apr 2026 07:12:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776953539; x=1777558339; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zkYiVKOb59tbNbvDJQOayIgdouD2dKpDo5ApOq9VXn8=; b=dghL0K57xjQm1FUuKO2ogA2rP2Vi0Zo45Trbhoj0Fg9U2QovpqTk2kWlKOrh/QSWU+ O0N+qHtQJfpgYaVM/is0mKGHBeA7j4IUKAtwpPWE4hA1Fv6ovpByjE/8y/iaSDjIEiAu wMJlB7eevXDh4skLJm+oAPqD4Jnm6F+AdHX5dQw2IUG3dOa+vnGzTZfcfNc6N+ecmDu2 6niMeoVcPYn6jFgzlHdHt5C5SV4+0rP5K2VajD5dZHqCk6q1gkaIvVG2aAav2Ycd64oZ +asJGp0a5zVdVQzIzNNwFkbcT83iCHN4iiGXLDDmMPItcStQGyHTxPdPXYNrRNOvF2Q0 QEfg== X-Forwarded-Encrypted: i=1; AFNElJ9rh2n+f3pogcGXdkD/SxrydnQV50O3l83PSEFa1k2XjlPxOQIQHg/Oxfci1jdFW07EnvugZVDA9q2VPfI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnun/Vas0JnXvy77lwVQck8FSc6M9wPhMiHlTI07HtiQZeEPyf rAIHtSqglcpPNEJHV2aPgMeE5aanSrx1ooB646FxzH8NfpWSEpvxo3Xf X-Gm-Gg: AeBDieuC00+ZMVaaAxDjycGrTPqCaRinFK08n07fuKOgcOSiy3y8pvB0GeOr9baPyEl hrjkic1UZVHJ+qsNTXInuZTEx3kd5AavrcoFVkrV+vD8wot0IzjKQlEj0lPLQ/8/Ug5rwotkZ3v EtP6+jDGZ7auG7h5I2ppkyJJFWzoE/RbMaOzSezfflJKxQY+7Mm+kC3bgXn5fmaTUfjgQ3U8N+m g/yVTk1ro5b4Jcv7BOeEUu09GWpO6qRiZza7ojhH3rHVXYdCNIdMJ+cqTximWfq9BOcLJ8VATua NibQynAezraG9INlRtb07F4Tghaor+lL0C+0PENFkOy3xrFDKHTce1ONgO9ZN4tRQTYM4xtu5ZH BLsRHQGMBP2QPbEz9jOLPzx1UMttAZis9hxVWQwcxLP+jthPivI4xsr+fZZLrzAOhxI2Wm8Ulf0 hmplIXxFUz6HlI/hR5iDcSea4p3/QNCrcA6yh6VkVIpdEDtX4cxO0+0J9PFu/kz9PoMQQjPh+GB dCtn9UqSqbKtWE/pu2mSL/M+ndBTVN0PjYwUBMOevQQ X-Received: by 2002:a05:600c:8b84:b0:480:1c69:9d36 with SMTP id 5b1f17b1804b1-488fb76e4aamr426214135e9.17.1776953538310; Thu, 23 Apr 2026 07:12:18 -0700 (PDT) Received: from localhost.localdomain ([151.41.34.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a55dc9f58sm452394575e9.6.2026.04.23.07.12.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 07:12:17 -0700 (PDT) From: deep@crimson.net.eu.org To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kenet Jovan Sokoli Subject: [PATCH] staging: rtl8723bs: replace TBTT magic numbers with macros Date: Thu, 23 Apr 2026 16:12:13 +0200 Message-ID: <20260423141213.720643-1-deep@crimson.net.eu.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kenet Jovan Sokoli Replace magic numbers related to the TBTT prohibit settings with descriptive macros in the header file Signed-off-by: Kenet Jovan Sokoli --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +++---- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 6 ++++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index e794fe3caf9d..1461166c5231 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -878,8 +878,7 @@ void rtl8723b_InitBeaconParameters(struct adapter *pada= pter) =20 rtw_write16(padapter, REG_BCN_CTRL, val16); =20 - /* TODO: Remove these magic number */ - rtw_write16(padapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ + rtw_write16(padapter, REG_TBTT_PROHIBIT, BCN_TBTT_PROHIBIT_VAL_8723B);/* = ms */ /* Firmware will control REG_DRVERLYINT when power saving is enable, */ /* so don't set this register on STA mode. */ if (check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE) =3D=3D false) @@ -928,7 +927,7 @@ static void ResumeTxBeacon(struct adapter *padapter) =20 pHalData->RegFwHwTxQCtrl |=3D BIT(6); rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl); - rtw_write8(padapter, REG_TBTT_PROHIBIT+1, 0xff); + rtw_write8(padapter, REG_TBTT_PROHIBIT+1, BCN_TBTT_PROHIBIT_RESUME_8723B); pHalData->RegReg542 |=3D BIT(0); rtw_write8(padapter, REG_TBTT_PROHIBIT+2, pHalData->RegReg542); } @@ -939,7 +938,7 @@ static void StopTxBeacon(struct adapter *padapter) =20 pHalData->RegFwHwTxQCtrl &=3D ~BIT(6); rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl); - rtw_write8(padapter, REG_TBTT_PROHIBIT+1, 0x64); + rtw_write8(padapter, REG_TBTT_PROHIBIT+1, BCN_TBTT_PROHIBIT_INTVL_8723B); pHalData->RegReg542 &=3D ~BIT(0); rtw_write8(padapter, REG_TBTT_PROHIBIT+2, pHalData->RegReg542); } diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/sta= ging/rtl8723bs/include/rtl8723b_hal.h index ffd03927841c..13f77c2bf442 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h @@ -72,6 +72,12 @@ struct rt_firmware_hdr { #define DRIVER_EARLY_INT_TIME_8723B 0x05 #define BCN_DMA_ATIME_INT_TIME_8723B 0x02 =20 +#define BCN_TBTT_PROHIBIT_INTVL_8723B 0x64 +#define BCN_TBTT_PROHIBIT_OFFSET_8723B 0x04 +#define BCN_TBTT_PROHIBIT_RESUME_8723B 0xff +#define BCN_TBTT_PROHIBIT_VAL_8723B \ + ((BCN_TBTT_PROHIBIT_INTVL_8723B << 8) | BCN_TBTT_PROHIBIT_OFFSET_8723B) + /* for 8723B */ /* TX 32K, RX 16K, Page size 128B for TX, 8B for RX */ #define PAGE_SIZE_TX_8723B 128 --=20 2.43.0