From nobody Wed Jun 17 06:11:14 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7A6223AB9D for ; Thu, 23 Apr 2026 10:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776940539; cv=none; b=Ppj8iEFk6IpGNdRHZFbQhjNfRvOTAvBk/g70Uus+gg0vamjrE/xhCJ45n4HXlKAcjbag4LpcjBF6kD9kXoMnNpHj+Lhw2WGoOWFlL9Ck5j35Tu8cFkviamjuSg6NAhWR7iV4x5yuxvwxuwhahGtI98S4PXGlSgEr3IqwCV+htso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776940539; c=relaxed/simple; bh=xJ6Bk7I5SF1vqoFR5e+KmB+y6SkLYL+ygQiSFoOCb9A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OEumC56muBA37kBJad+yYdsisswpNUwiGkOKziuvoycz2WbggvpF/aFfBEA5PWO0kkhpscbbmvNY00/77fP7gJNyMrWDdy031zeNGK5YbfV8qjivoQQKP2rF10QDA9rqBf9BvNsediZJECyeDIVlIXPlLW2/R5lUAtMuhiXxDf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K29FHxU0; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K29FHxU0" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82f1bfc9b8fso2963347b3a.1 for ; Thu, 23 Apr 2026 03:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776940537; x=1777545337; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MTOiYWe3w6Vu7hnJzTQ5ZvV3Qw4Abvs4TqqonSRF/2M=; b=K29FHxU0lSIKoIjXxp9yaGJNDlzI6KKqUix0JiXS21JXcr2GrysNb5TlGb0rgbAkb4 EXRafH2sOQaacB1UPlNUCvet1/AVTzBLHaaf3nadvWoALvFMLvzTKLdVCj7y273wwXQk ngkoVRxcXdjKCK7N7xHuoZQNAS4dpQnSUmjddLOFqeeDpBgOJTC+Eh09Kj4+omlLGoZK d0OKTB2FT1/j/woDrfBMfIxl3ftjYh5+FaR4WkN2qbEmB/0jRzhn/ans1ERexKXArS0C ILzvPGaqQjbirDtrtgQ+422jZJYjZht0di2Vcw31HlpjfhoQzK+LWXJKMwhze5ouDzB7 U9tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776940537; x=1777545337; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MTOiYWe3w6Vu7hnJzTQ5ZvV3Qw4Abvs4TqqonSRF/2M=; b=IzqkzMf8WdI257pSr1U8XvsaxV6HQdINywIDp51ZdadVbcWbVQHueCdUfBRNyZu//a V0tBX2JROPEr5HJiuukvPHaHak63Z2hIgXgqxXlsHeefRGZV8aExLzI24bfNXe3j5W3s JqzQGoGgHy83UUc1SJ+Pk3kVhK4TdYdfECJqCxH8Wck1h02J+9Nmh2i0q+HvybG5a22q Y9Pvi0jw4Sy+l/yQYeY93152Qi5c9xaggYlzGsLVxZuwVEMO9xCRL6kloXoet4TU03TG rVhjJrqRG4im6j2pYn0bFAEJOBlJfO+SVlei+j6z7mwbK5KPX1wblnvk56QJ342nxNV1 p+ow== X-Forwarded-Encrypted: i=1; AFNElJ8r7DsWDY42n0RGxmyJ1IQVKHkpGHCjBcOhCzMLbrwimtXyHrYZBW4W2llQ2XNzI0QUezcTraj2LGg1Up4=@vger.kernel.org X-Gm-Message-State: AOJu0YxdOk4rgWwk0x/2DAj+tdUsnR5PgTf5Qs9pPNefl/PogGJ/KiqI HYj4xGm51PFyErn6ZWBu+YrIkaY3me6SgllPNTLabFrotDGSS9WGCgDq X-Gm-Gg: AeBDietH7ThiNR465xLg1qiMq8ju5X46zRG+XyGO2h2UzdLwTMuVL2Cb5VJGjC1TczO vw5lBWl9vkJumfiAAKW1yYx3yJugoJoCh9RLSN3gng306PsgGHQXsnZOhSKVwelpVn2ew+FfTWA qMB5RRrBGN5kYyaGXEA2YlHMNgoAxnmxDZU6be/BGBt3cNBZ4hK+gNOLw4S8DZl6yfl6rXeL4Xc vwEe8UkMt5jchHIH2IYa91zflFqL5Q8nmd4CRpdLA1QLgIvDxYc5f7W37VQ/g1TqDc9Dfdc63h/ b7fTUAHkjUGo61iuvzT7vGoYPUZpG41e2Jm0RDLfEecg+nlOxnSm+MyBf4NytNv0qWEyu/wnmQW rPG52OXgORTM1mP/6nMkS6AhkXfyIUwiafFb91WRvr8zzy7HqAIRzgTLg5mbBD8R9jJ1ZZShSXO rAnXU4HuD97lwTuHZSHw5yntplc6MbE6U6CTl3AucZ0qMzZSvgz8jhBuI= X-Received: by 2002:a05:6a00:1749:b0:82c:d7c4:4c6b with SMTP id d2e1a72fcca58-82f8c81dd75mr27533723b3a.11.1776940537240; Thu, 23 Apr 2026 03:35:37 -0700 (PDT) Received: from localhost.localdomain ([14.116.239.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb38f2sm19099318b3a.30.2026.04.23.03.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:35:36 -0700 (PDT) From: Jianping Liu To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, wangming01@loongson.cn, wangrui@loongson.cn, frankljpliu@gmail.com Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Jianping Liu Subject: [PATCH v2] perf annotate: Fix NULL pointer dereference in loongarch_call__parse Date: Thu, 23 Apr 2026 18:35:30 +0800 Message-ID: <20260423103530.3938202-1-frankljpliu@gmail.com> X-Mailer: git-send-email 2.43.7 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jianping Liu loongarch_call__parse() dereferences the return value of strchr() without NULL check: name =3D strchr(endptr, '<'); name++; When objdump output for a 'bl' (branch-and-link) instruction does not contain a symbol name delimited by '<' and '>' (e.g., when the call target has no associated symbol), strchr() returns NULL, and the subsequent name++ produces a wild pointer (0x1). This leads to a segmentation fault when strchr() is later called with this invalid pointer: #0 __strchr_lasx () from /lib64/libc.so.6 #1 loongarch_call__parse () at arch/loongarch/annotate/instructions.c:29 #2 disasm_line__init_ins () at util/annotate.c:1205 ... The objdump line triggering the crash looks like: bl 98824 # 0x9000000000641ea0 Note the absence of "" after the address. Rather than aborting parse with -1 (which would clear dl->ins.ops and lose the is_call attribute, preventing the TUI from drawing branch arrows and navigating the call), follow the same pattern as the generic call__parse() in util/disasm.c: when the symbol name is absent, jump to the address-based symbol lookup so that ops->target.sym can still be resolved via maps__find_ams() using the already-parsed target address. This preserves is_call semantics and keeps TUI navigation working. Reviewed-by: Ming Wang Tested-by: WANG Rui --- Changes from v1: - Instead of returning -1 when the '' token is absent jump to the address-based symbol lookup so that maps__find_ams() can still resolve ops->target.sym from the already parsed target address. - Link to v1: https://lore.kernel.org/all/20260423053102.3717015-1-frankljp= liu@gmail.com/ --- Fixes: 4ca0d340ce20 ("perf annotate: Fix instruction association and parsin= g for LoongArch") Signed-off-by: Jianping Liu Reviewed-by: Ming Wang --- tools/perf/util/annotate-arch/annotate-loongarch.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/util/annotate-arch/annotate-loongarch.c b/tools/per= f/util/annotate-arch/annotate-loongarch.c index c2addca77320..a949b4392dd4 100644 --- a/tools/perf/util/annotate-arch/annotate-loongarch.c +++ b/tools/perf/util/annotate-arch/annotate-loongarch.c @@ -29,6 +29,9 @@ static int loongarch_call__parse(const struct arch *arch,= struct ins_operands *o ops->target.addr =3D strtoull(c, &endptr, 16); =20 name =3D strchr(endptr, '<'); + if (name =3D=3D NULL) + goto find_target; + name++; =20 if (arch->objdump.skip_functions_char && @@ -46,6 +49,7 @@ static int loongarch_call__parse(const struct arch *arch,= struct ins_operands *o if (ops->target.name =3D=3D NULL) return -1; =20 +find_target: target =3D (struct addr_map_symbol) { .ms =3D { .map =3D map__get(map), }, .addr =3D map__objdump_2mem(map, ops->target.addr), --=20 2.43.7