From nobody Wed Jun 17 06:03:30 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC36B37B028 for ; Thu, 23 Apr 2026 10:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939207; cv=none; b=tbUAk92yHtzfCJ5FZD4RbREbYWWOMCAIKfOBMKNmISYHbkC+6FO151WCsUQOp/ngNtMPlmj/SIQm2GPo3wCOCr6MyHNau6ge96axpGF2TPuSLfFEhRURv6xm5YiOKj81M5f5+VPCzykT3iGEYPQ0TdH6obUKcz8jnXinVXcxl68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939207; c=relaxed/simple; bh=EZFMmfcPHnnPRRl1qIvsTma60zQYclkMF5a2PdQBHRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ADMoTUD/LqCZCINdYN/12Qe2c8N8YyOR2t4BBXqVbdx1aPT8QwDNkwueZeVtYwdEAPnmpe5BFKgItZ5eus7El9GvsPzDui+y58Rbdr/3CS2D/MGBK848jQav997iczQQ6qe+S7Zg0d7d4DFTZEW3ObQiYqj2kR3DJY7P5RBY9ow= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gGJFdFHJ; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gGJFdFHJ" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43cfde3c3f3so6644515f8f.3 for ; Thu, 23 Apr 2026 03:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776939203; x=1777544003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NQFI/pBHIyp1CLRqL7clSduoa3aCGTrnoSWGD/QtaJY=; b=gGJFdFHJGTABVl82ALeMDHt5TxDouVE5CsmtRQflA1HEzSrUCq05/VmrZC1vJZyCGK yamPgjg6RDySzwN9qerkeaxO4jHc8Z51S9qFhMANYtT+XjmL9eNmu8EN5apyBMdCzydK xoD5tei3qrWMKOv0hQBtKLEdpzTULVSIoTON0xGJMkEnI1RqHGokLiM9vIfybHDbf10D v2meImDZCiAKTpdU2n3o4DBlhCNBrAR8UfnC/kKg+IKaBH50Xn5oxZ4lOSLy81SQRSYk eDabX4dBuvzGgSDKjtxy1F8pkrLJSVgQsnR2afUCpsJY0sPDeVP6U0Udhl75wCybblVz u8MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776939203; x=1777544003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NQFI/pBHIyp1CLRqL7clSduoa3aCGTrnoSWGD/QtaJY=; b=LEGb1dM3bWdPO0mMrcO+o3idOpdgN4b44t0mmpoqPdE1LobPHTgfkHtLH2/GBmba/Z r2z5se50oZMpWhOJ8+thNGEK98TJO0S7ax6ozy68GXHH6cFsQHOSgfPK2BSjOt1tjtFD EVEPj6IJclkblI4j8upxvSh3RGC5F6YG4g9WNU8C3xAjbPbw6J3mOxs/IrMYBcq1THgL oKbiP4Jq0kHOtI7CXkfkje7J2qWZdCMBXyFhn/MpTBadIjJgPcmPDCMEnD+tXqtBW+rG wKtP5IjonTQ+315JjLRcIL8YqIk2HSpnQx41jamS0KLu4fkSnv7nnvGeoKjOrrWIXnvu kKyg== X-Forwarded-Encrypted: i=1; AFNElJ+rmacA4m2sVzQBm1lJUYIXc9WEoW88QIz10ZpfuecMq04DLgAf8kjaHVzgMomsmHIftz0pwDbpMbc8JLw=@vger.kernel.org X-Gm-Message-State: AOJu0YzCnmwXOUSEC5I80imYCLQkrllvrucSSYKGaipZHmh2pN6dANY0 RxyIWVsLgGSO6l7GI5WSYjNcgrV01ewCy5GYiPcSant/I4SdGwuI4dVK X-Gm-Gg: AeBDieufnJjn3kcMt5kr/DDS+0WomY2aETGP/mGE0boRoUHii/A8lIVZCrKcI34ClVa QPnHsT7fq0ITLlL4j02b5PIUoBgguHmi6ak0uypOkJs8MQMIWTOS7/Lb5YmZVX4KvlAwykV7l2k lY+pBrASO1Q15Gg+IAagsTli2OLYwZvZtnWS/wpuBisjOpBJ6FaBFOFgSERzq51veUcPSj8Bbf1 8iwRD8sWQIfTKa34uhh/DuplVh9WBpwx6T8UE4uLhnz9m1ZKU1iaemIrbI/W9nW2CG5qG7ypk3W ajPW2aq3RA3+Zd/czhHYbOM5+pv4CmiFaLsZdbnFx9zp5ch/7rjNCBddTL7yViYz99R9o10UjMf LT4WSrUP9cyoMSb0mrBw1RxpqREf35BWUNgXy86hZdVouYzjEThIkgtZBtGPBE2Jk5wo+AqfRzq TiBeASBX3gx/BVHyAlPYdDcSQtCNXoJSboSMNnP9mLO+FS X-Received: by 2002:a5d:5d88:0:b0:43d:73de:abd3 with SMTP id ffacd0b85a97d-43fe3e0bdd8mr40038135f8f.30.1776939203126; Thu, 23 Apr 2026 03:13:23 -0700 (PDT) Received: from yocto.. ([2a02:3037:60e:ee7d:34af:34c4:890b:2c47]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d525sm49741217f8f.31.2026.04.23.03.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:13:22 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fnnas.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Abd-Alrhman Masalkhi Subject: [PATCH 1/3] md/raid1: replace wait loop with wait_event_idle() in raid1_write_request() Date: Thu, 23 Apr 2026 12:13:01 +0200 Message-ID: <20260423101303.48196-2-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260423101303.48196-1-abd.masalkhi@gmail.com> References: <20260423101303.48196-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The wait loop is equivalent to wait_event_idle() and can be simplified by usaing it for improving readability. Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/raid1.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index cc9914bd15c1..b549be9174bb 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1488,21 +1488,14 @@ static void raid1_write_request(struct mddev *mddev= , struct bio *bio, mddev->cluster_ops->area_resyncing(mddev, WRITE, bio->bi_iter.bi_sector, bio_end_sector(bio))) { =20 - DEFINE_WAIT(w); if (bio->bi_opf & REQ_NOWAIT) { bio_wouldblock_error(bio); return; } - for (;;) { - prepare_to_wait(&conf->wait_barrier, - &w, TASK_IDLE); - if (!mddev->cluster_ops->area_resyncing(mddev, WRITE, - bio->bi_iter.bi_sector, - bio_end_sector(bio))) - break; - schedule(); - } - finish_wait(&conf->wait_barrier, &w); + wait_event_idle(conf->wait_barrier, + !mddev->cluster_ops->area_resyncing(mddev, WRITE, + bio->bi_iter.bi_sector, + bio_end_sector(bio))); } =20 /* --=20 2.43.0 From nobody Wed Jun 17 06:03:30 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E482737B3F2 for ; Thu, 23 Apr 2026 10:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939210; cv=none; b=h72xm9JYCLvFV8Yzu11kuxpImWAFa1bLHkkLFw7dyZybkylVYstwTr8aGbLs/oJ253w8dQE98TjPuuCIjEs+Aaw5iuPYHpqOkx8yVvTrq0p7lMiGOXpnhvydKx9yu6nzUOcgjP6or7Z0cnNDsRuOEJL/GNkFn7EHq5r9kDnSQt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939210; c=relaxed/simple; bh=Cw61duZfFIwzmmP7y0PuI4JNe8BOIr1dpdcSwvCPyDU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=itEj5vBOF+/+CUB9UPDnUKUv/UWQpTCUayGX72DJIwA3dp4sAdcnEXosOy/NymubasaBAK5avXvULYNgqvPNeq1cwdJBaSck07J5qlndfF1Iw7HyQg5Thq+1migfeLa3YicUFISMflPP/WNhW8nOGhjalgWltYLPWFM6GOsm908= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RA6ZV/3f; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RA6ZV/3f" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43cfbd17589so5150980f8f.0 for ; Thu, 23 Apr 2026 03:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776939206; x=1777544006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pj86MgheDegBTfpeKib/dIuz8OT3FvkhbCKW6+m/FTg=; b=RA6ZV/3f13KpvpmCbAHtWXMSZgCiPXxpfYqgCNT42JVCwyEFJZIh2JnJ6Nup6+Fgfu mAemOMAY3CII0+D2/m3Q5DIyF8KtwtFoU3OwrKrP5MV1yVxTtmNJ3BDMVgQbOcXLNSV9 Lzhn5ezJbZK50r7OjGQV+Zy6idacV1jNrbxdZ9FfbHq1KJWugfJd0NbgVORo8hLeVi54 t4CJFcSWUJvp6I4BfQdWQgN5TbJwPfyYgwFnxI1apTjPbhiSNg3eNlbrZw70Oi17wt55 6TPKSB19QGEeRuRFjBN93lUVP0JFyV/hR0CifEsQS5y3OS7xHbTq4iAfl/qhP1kexbpM ZasA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776939206; x=1777544006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pj86MgheDegBTfpeKib/dIuz8OT3FvkhbCKW6+m/FTg=; b=p6TNTcE9K5eCd01kmIC6jecs6NPsk/V/7piYxDkjN6vrIW40AHCG3lgT0zlyS0/bme 9w/x+odM6z29+M8OyWnUTX6c7Coa0IDBrgrUExca4S7SieHnZ5hSAq4lf+WrM4xF6GSr AFLtfUFS1a41kayK3sSe4XwpHbE7hsiEZhTHzgmaiyWOtLXHGLuhAi7rqJ7IEG6oH1pJ hSWsk3+NGZo3M1hhl76BNvouAoFmKSaI4BI224w4HlqMZnJ2AKgVC1x5wKWeImyZrjED z+rXFLjJ9Ggodocqa3++GUhXgi9KCJ9Cfc7LFYvX8umnPVJu9xKDbRVWTXkzRMEwbyZo kKMg== X-Forwarded-Encrypted: i=1; AFNElJ9veOuHP4ZdAY8N94FtxxKhuPiuLCr4nTSzOr8UAI0VV0BMJqNsI5bnXeJ03Ycabov+hsEfXoUGTEoXmc0=@vger.kernel.org X-Gm-Message-State: AOJu0YwljwhdDjadQzRNEKzNJN2lrT1Q97PO++pMo1dzpTnY6rpOw+Lh w4Cm2b2GSbRI0mwD+xj3gMHOmQi3BWZIdtrFzL2oCoxOJQk8rXOTPPOZ X-Gm-Gg: AeBDietyT1ZrZuQpJrXtfJa4RdvxWrbQznk9E9UzPtlf4DYrCQBe2bjBFvgH6DTjazl 0Bl9t67M3YtcWUa+HZO56CMmT+3+1ig68hleE8dlDQQJ08pTKBjnwdgdBg3rqdBJHUoR5JFdLF0 svBU0Sx9X8RAZ0xSZPuxcJkYg4wQwPlY5GVlro7WCHaVpq76HuKg7mrQqcLuF+MRHbn7DHSOFTI NKTAS24fqvlEhcgIqZrvbWoRN8zhcHpA34YsJJl/Oa1m8H8wwGWUx2LVMisM8BmUTzXPQ/JgPul 4cpG+XwrImf3mWTQHSFxkhRBtRP0ecP+LkV6iH6hoop2g4pHdOhrElZfxGbxj9qV/t0I0cn0xEU j+ukcovm0xdp/piRXL/Wey1wS3DBJwB0u3tD899wHuR07qP2DI4O41/NrAVTUdbmn7sn9r98mJB 9zweXoAYkUMlmDPS83PFO0vHJwIdpLhRTiT88KXwqk1bXk X-Received: by 2002:a05:6000:1a8c:b0:43e:b0f8:66f1 with SMTP id ffacd0b85a97d-43fe3e0b86emr40376264f8f.43.1776939205953; Thu, 23 Apr 2026 03:13:25 -0700 (PDT) Received: from yocto.. ([2a02:3037:60e:ee7d:34af:34c4:890b:2c47]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d525sm49741217f8f.31.2026.04.23.03.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:13:25 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fnnas.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Abd-Alrhman Masalkhi Subject: [PATCH 2/3] md: use mddev_is_dm() instead of open-coding gendisk checks Date: Thu, 23 Apr 2026 12:13:02 +0200 Message-ID: <20260423101303.48196-3-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260423101303.48196-1-abd.masalkhi@gmail.com> References: <20260423101303.48196-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace direct checks on mddev->gendisk with mddev_is_dm() in md_handle_request() and md_run(). Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/md.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index ac71640ff3a8..346d071c1b8e 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -417,7 +417,7 @@ bool md_handle_request(struct mddev *mddev, struct bio = *bio) =20 if (!mddev->pers->make_request(mddev, bio)) { percpu_ref_put(&mddev->active_io); - if (!mddev->gendisk && mddev->pers->prepare_suspend) + if (mddev_is_dm(mddev) && mddev->pers->prepare_suspend) return false; goto check_suspended; } @@ -6584,7 +6584,7 @@ int md_run(struct mddev *mddev) } =20 /* dm-raid expect sync_thread to be frozen until resume */ - if (mddev->gendisk) + if (!mddev_is_dm(mddev)) mddev->recovery =3D 0; =20 /* may be over-ridden by personality */ --=20 2.43.0 From nobody Wed Jun 17 06:03:30 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C906137B41B for ; Thu, 23 Apr 2026 10:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939212; cv=none; b=VUqDh5SbzF+zcuF5ZwE7hUTW9ZOPCeTVcOJ9BvIYqOBh7bccU5r1MQAgKUpW2pThviXrdic0c2kzdYqoYy2ci5P3yngQhK2s/3brWU37/RU3uqvopf9t3y/BN71PQHuvaNrDcRzy7HCh+0tKmBEZenOQyFPiCx/sEyhpBxnl/hM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776939212; c=relaxed/simple; bh=BFgSLuyGF45cFZJ5kjot3K10/DX2p6hJz1boGY1v0Nk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dbUhLOONLfzZrreKuSJ+gOdNTC7nsspNP8HILp5l5OWd6PTGkGSWRFH3zYAqoAfFiH9cITqvCOBluujsK0nXHYroEu/U6sHe+zoK6ksJa/B7MZpXzwcg8B3sjE8CbMyarvZ8JyTA7lQ9LjThngDZXWsUPGhb/QWMt6RJlrpaLtQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VZZrapHR; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VZZrapHR" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488b0046078so58386425e9.1 for ; Thu, 23 Apr 2026 03:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776939208; x=1777544008; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QJJoHWfjIYcyVr3kqYM2gLBS1v38HSn5RQ7YXMRbXlc=; b=VZZrapHRK74utgJ8+S4HLSoOj6j1Q2KrEFJOjUH6h51OCdTVVfpOOzfABZJ8fkDszq lVQ3WO453FOh3Xr5Q3v3lPaZukeOQWzyw/HeFcN1Fr39QEw5CCO6dXCOW6drT73lQsQS QhySNGgl6+9hYpmdbquHHEytg495qPi1vyEBEPBUYfN/hVkoYJXgK1AuTZeVbUSMN3u2 ev0QT66Qo95qfWnHTaUTxsLyWmwUROg7MLmP7T/E6NWVKv6j4SsGvu2W1H/WGtihnWqb hc+ghd1PwElGJXmuVCH+VOtrAOBqazStTYESzsqSxArMFKeEWfkPAoAd+QMvMRLA/XNY I0YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776939208; x=1777544008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QJJoHWfjIYcyVr3kqYM2gLBS1v38HSn5RQ7YXMRbXlc=; b=jm1EYVOSCGD12C/dkyWnnNusUrk+fEkg5NJzNwiGnHrbfW/sw2glQpjYlwuXG+flY8 pECZtmCrgQUwcP0KQ6lsxEAjyj5jcvidMTPTSGTXubNx0uv2oBGams/LUygfnWAtyoam u7cSXLpdbDLvpCywsHCgbKBzuXb+2Nzvp6iBXVDmAvr/5vGnjKO/mmpN0p7nbAavhRVu Uq0gXfvwT9xyYDVmL2kZdY+IqYfR7sXe4tUJQKQOb1rxbK3cYsQ7mbxjPfSWNHm9hcIq ShzOy/fhPxIGPXy4Av9zyo+kZPkk3wp57JlvRUIhisA7qFKLoLC0MeZdffTfamca3PlV 9qkg== X-Forwarded-Encrypted: i=1; AFNElJ+exUH1sFUqBNEEvl1k9EVc7GNzmJ9bgMu7yrqLmnt4M6COJdBHbB+FnL0Mi/mKBpPDEML1ry310uHb5Ds=@vger.kernel.org X-Gm-Message-State: AOJu0YwcFq1KTxlm43HcbYSyJiup4nykRcX2aY34jCrp8hEK5KHvVgDA QzapjRydpq8cCmKeWraSOW65sWbOi038OB+xMBzuN3fvs79XEI2GQNtw X-Gm-Gg: AeBDievfedMj2NXaSA7tHDaYEOhRlsj4ypV0eo8QywJbbcYecGkkslsyxrcGZ8m9Fia uc4yOlf+UhSYx0xk6zK5SsSSvUj8QbAWC1w8rKiIsCleDM7efa2l33yBtMvR42kD8LdFIs2r2rK HvaccFuY8B15wq/ZXr90jdKnkAYhmk6olJ/7fQxl95bmWcLDhPfkLy32N+FEjtH4VafdvgeQtJd Lr1rJ3+i6mzyGJ+fI7+WoEApYJbCnP+faCNKvfOwX+73mzArwHtWH5iPXT8SqsmxBZ/JgLoezqY XtohKYwdsWXxq6JfiFu+N4lpdO8+uA4Y45o+gj9VqcbuUXGmItKGSFK4p+ysH9WoFC0mXYdyeKv aB44yFzadRg5YzXcnPvkvRuiGW6JMSU6jKPdk5CFaZedoHGK8YTyhNclZP4SfMGOf9vYMLGX1gG G25057BkOMnC9AtS+USDjZ89NHLKedF15QoLN+2VettLHN X-Received: by 2002:a05:600c:5294:b0:486:fa35:aef2 with SMTP id 5b1f17b1804b1-488fb73d53bmr349782545e9.4.1776939208169; Thu, 23 Apr 2026 03:13:28 -0700 (PDT) Received: from yocto.. ([2a02:3037:60e:ee7d:34af:34c4:890b:2c47]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d525sm49741217f8f.31.2026.04.23.03.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 03:13:27 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fnnas.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Abd-Alrhman Masalkhi Subject: [PATCH 3/3] md: use ATTRIBUTE_GROUPS() for md default sysfs attributes Date: Thu, 23 Apr 2026 12:13:03 +0200 Message-ID: <20260423101303.48196-4-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260423101303.48196-1-abd.masalkhi@gmail.com> References: <20260423101303.48196-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the md_default_group and md_attr_groups with ATTRIBUTE_GROUPS(). Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/md.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 346d071c1b8e..0e55639211f2 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6045,10 +6045,7 @@ static struct attribute *md_default_attrs[] =3D { &md_logical_block_size.attr, NULL, }; - -static const struct attribute_group md_default_group =3D { - .attrs =3D md_default_attrs, -}; +ATTRIBUTE_GROUPS(md_default); =20 static struct attribute *md_redundancy_attrs[] =3D { &md_scan_mode.attr, @@ -6073,11 +6070,6 @@ static const struct attribute_group md_redundancy_gr= oup =3D { .attrs =3D md_redundancy_attrs, }; =20 -static const struct attribute_group *md_attr_groups[] =3D { - &md_default_group, - NULL, -}; - static ssize_t md_attr_show(struct kobject *kobj, struct attribute *attr, char *page) { @@ -6154,7 +6146,7 @@ static const struct sysfs_ops md_sysfs_ops =3D { static const struct kobj_type md_ktype =3D { .release =3D md_kobj_release, .sysfs_ops =3D &md_sysfs_ops, - .default_groups =3D md_attr_groups, + .default_groups =3D md_default_groups, }; =20 int mdp_major =3D 0; --=20 2.43.0