From nobody Wed Jun 17 05:12:34 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B20641E5724 for ; Thu, 23 Apr 2026 05:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776921378; cv=none; b=CpdbpgIAkLtlnZHik5Gj8N5uZzCIdqPVSDgT8pl0zIbzioFRFiW2cZG+39i/C3sfh79BXwtrKONTQJipTkiY4hihoVUQaBVMAEIkXGEa7G+DnBgMEERWrJphCYXJFetxwgluzdghoDkZSvpVPCoP0ms/Wu7p6wLYLIr9a4vKx2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776921378; c=relaxed/simple; bh=vVmUc6BHhzs+fV8O2rHNsLH+X7k/U7RbLkyQO4qhSZw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=cSfneWa2X7Sg/K2e85pW4nrzmQUq/LFaCJ7OGZWcO8N4f+5e99A+pN0Dzxm8Whm5CHuwLxMPBPx3pE1wctpjOC1dBk26paEBKnmw4E/hRMm4Mz/rlbQSE7siAwlinyvVBVZ9rX53C03LXJgUy7JIEpR6d/djTYDl9zYhKEmqSXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VSt8DCzG; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VSt8DCzG" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82f83bd32efso4890583b3a.2 for ; Wed, 22 Apr 2026 22:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776921377; x=1777526177; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lmd0+i3zyfUooe2qBex0I9Uy4jA43VCAP6YM0wisfD4=; b=VSt8DCzGmGUep8OI6ug+V0T+RHqjQ+6reg95e5SO9FHFe2TJ3fsJ7iVm7TmEz+CEEG kZicP6FXfylZisJurLicBs3NcbzIrV8kaxcELmA/Jlrmrc98n4p4S0LFnFnlgBwv/5JI CmanjdANw4cP5sJ0KeNKUWEfplg+atKXN1yXy30+cq2y7l1QNUgkVe1/07SAOonVbat1 lcl4fOXzzBCLd8s8iuVpzmdWHDqROPjjWyGC37FwV3sQ1GvXYRTbd5JAKRF00dy5L7Tz kYbEHk2s+FlBmdNipflOO/SuEzqqL3stVA0SIr48yeOZ8iapYHXPU8UwtxFtKr2Cb0kw wzJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776921377; x=1777526177; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lmd0+i3zyfUooe2qBex0I9Uy4jA43VCAP6YM0wisfD4=; b=DQJjxox+9eepvu7ecuWIVbp1/xv4TUhlo5zk+dElxrbB+3FB+HcwmI+xD4b5gwrxis XRl3FkBF8rs2M5UmAyZL5/szyr6E0oSjOQJICV/Wnas6yGZo3J63grFQ49cdJK17Ak+A bDlCoJ+pADOJ4WIxT7q/Pm5f/Gpm79x909aBCxlX4sbKrf1VRp/BQhi7AWGvsF67lxir inHsYUKJkyHHMx8W29h3q2fvbE/7CRwlIsgAr5XUryjBkk8ZzNviT6hspk2LiavXvVCa entzYZVsrom5C/TnSHSlHfcF7t5YZbki6KVht1XH4nirPRZDzD9r0oQe77FeeTGCfz2Q pzow== X-Forwarded-Encrypted: i=1; AFNElJ9C6gLvutKXUKsLZG9GFpyWKzx0D92qBzkiWsbF9jMWqV1ITD6VOsiMB5yNhU2JFWBXWrSOULGw5RYrL6U=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk5oScTLljJ7KdgBfNYJQtjn3kLjJ+FLPKAPSPcEvVsBIPEjls OcfjnQBBkdf8qlL/I46gDhvXfE66hYBbGEYypgggCGyRQbDteapTKa0L X-Gm-Gg: AeBDiev8wfmMgwWI1E/6PqEb7HC7SyFSGT9fWnU67ffoQYOy7nTJQoc8L9MTgREYnuT d/zqQoHF962IpSrM9BQOFpitYImoUEGygL8ZDMY3rfgoHla7cES8uvFK7TuyGxxdD9BFlXl8RtI a71iXWdH9rc7Q9F0qsqxETNkOFDSRvHXvuAcXcDu1bKIj+nHrCBBWyF0KktN5DYF0iLxmnIGrYZ KfxBkWUrodTdVqSaF6ILlMfdJWJ/cK0BjOCmfEXy1ZW1mB8V7VvtK/Ae1ciTA3VXiypULEMI2Ey DjHfDdxIci2LD3xE0duqhCA5h1aMC74Av+Dla1JBV2dFW5BUxU3FaGCfB3Okw4EEoR4+/2guWtH k0udJUHqrkGrLrs7ha8Tkh0T20M1xT3MEBtxluDR8+3mQpBJkVUCtZPz4241Tgc5Igcn575uLNU 4sQ4aaE9+ziWqYQu5Hu6UG3kXAB2yD7oQ/IilglVxDs+K/MG6m0I3xiDc8ISlIE9psT9GnIHCrx xzdCE21rx33d6bJel2ibE+jVHC9U15qvpII X-Received: by 2002:a05:6a00:4094:b0:82f:6e9:d1ba with SMTP id d2e1a72fcca58-82f8c90b253mr29372382b3a.37.1776921377084; Wed, 22 Apr 2026 22:16:17 -0700 (PDT) Received: from DESKTOP-87O68R1.hsd1.or.comcast.net (c-67-189-53-77.hsd1.or.comcast.net. [67.189.53.77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec037e1sm22517658b3a.54.2026.04.22.22.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 22:16:16 -0700 (PDT) From: Nikhil Nagarkar To: sre@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] power: reset: ltc2952: remove global ltc2952_data structure Date: Wed, 22 Apr 2026 22:16:01 -0700 Message-Id: <20260423051601.250932-1-nikhilnagarkar97@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently uses a global pointer (ltc2952_data) to store its entire state structure just to access the gpio_kill descriptor during the power-off sequence. Refactor the driver to use a specific static gpio_desc pointer for the kill signal. This addresses the existing TODO in the function. Signed-off-by: Nikhil Nagarkar --- drivers/power/reset/ltc2952-poweroff.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/l= tc2952-poweroff.c index 90c664d344d0..f07283d38cbd 100644 --- a/drivers/power/reset/ltc2952-poweroff.c +++ b/drivers/power/reset/ltc2952-poweroff.c @@ -77,12 +77,7 @@ struct ltc2952_poweroff { =20 #define to_ltc2952(p, m) container_of(p, struct ltc2952_poweroff, m) =20 -/* - * This global variable is only needed for pm_power_off. We should - * remove it entirely once we don't need the global state anymore. - */ -static struct ltc2952_poweroff *ltc2952_data; - +static struct gpio_desc *ltc2952_poweroff_gpio_kill; /** * ltc2952_poweroff_timer_wde - Timer callback * Toggles the watchdog reset signal each wde_interval @@ -154,7 +149,7 @@ static irqreturn_t ltc2952_poweroff_handler(int irq, vo= id *dev_id) =20 static void ltc2952_poweroff_kill(void) { - gpiod_set_value(ltc2952_data->gpio_kill, 1); + gpiod_set_value(ltc2952_poweroff_gpio_kill, 1); } =20 static void ltc2952_poweroff_default(struct ltc2952_poweroff *data) @@ -274,8 +269,7 @@ static int ltc2952_poweroff_probe(struct platform_devic= e *pdev) if (ret) return ret; =20 - /* TODO: remove ltc2952_data */ - ltc2952_data =3D data; + ltc2952_poweroff_gpio_kill =3D data->gpio_kill; pm_power_off =3D ltc2952_poweroff_kill; =20 data->panic_notifier.notifier_call =3D ltc2952_poweroff_notify_panic; --=20 2.34.1