From nobody Wed Jun 17 06:26:39 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02206378826 for ; Thu, 23 Apr 2026 12:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776946345; cv=none; b=fZSuxhi3ErdINHQeBE0s5++SccM/IescAsyVJL1AcbCRBiznAeW7vDqcAYMxlpctenIBqoD6yDH9a0TfH93hrZVIL4nlTMR5tzEO3xbPSi6WtRxAG1vojwFpiSICl57oLPSP7SJnRXFzGbSvbY/CyPidbeOascGAEHO+f3/heqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776946345; c=relaxed/simple; bh=Z5Ah5+zyjgUIowchJf0oKYWytwiEw0ZLXjONRjD4ydc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dIi292YMagbGh7FpL4+7mQkUg12+q8gg6b2v2l5GVU4Y4oS/rtSQCR4t5BlKDT8rcRMxLJSovLKzM3Qbn9U4JoOn4gVpsKkzGMX4cGTR0eTlydEC+UERz/F1xcLI7poX4JhykuTSBMLx/WjinOcmFm82vcfroVKyBUpLmoQ8FyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PaL5obF+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RXT9fuG7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PaL5obF+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RXT9fuG7" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8u44Y3769013 for ; Thu, 23 Apr 2026 12:12:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j1/l4zkCa5WUec0T7M2clK+8oAp4jlm4b6G4GuYEZaY=; b=PaL5obF+VmPEeVdk PIn9tUqsYNkXghkv4jQVevu4LphVVP1CfApsx+rQG8nV1q8iG3mB2BBn7hTRJ29j trG2F910t+WAfMcU9hYloO6v349sShlwYu1RGlCWVjsoQJzJhUgpXdC6rp3jOmvo GVwTiqsHSy/2dhekLhA1TR+DLm8ZjuvkNwN/RA2M7heAWJgmuYFIUwlarDnLy1jt bEPJ08dznH2XOYRVZ1TaF9TFeZourg092OjXgQZop/j/kFNCPXzi3xXSsulR7W8x 8rvSRx91QWZPnxrQKu37Jt6LyJ4yUGa/R3KSDT6XqqDZqE5LgzJM5dmrlcBo2Xru gXtqAg== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1hq3su4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:12:21 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-56f66493ef1so3379950e0c.0 for ; Thu, 23 Apr 2026 05:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776946341; x=1777551141; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j1/l4zkCa5WUec0T7M2clK+8oAp4jlm4b6G4GuYEZaY=; b=RXT9fuG7KJ3+9uS6gU395hv7hafy6eIktIP/0QUwlMt8GYUY2yqrtCgn+2hSbvZv3d PvOErSDXLqX9kYl9AGdC9ID1XC8gh7YEkcDNMd+X0oYwQvV+7lRuLEhpiIy27KQgL6UG D6aGIy7pcE6ZuyPXRxPegq8oTi21oCQUZfh4XOR4IIotQSUUElQTQ3xGQUneNGWns+eD Xy3RaYl5Dw8M3+FrRftbN5Kyvh7ci1i2PmjCNyqcsgSDDyyue9whU9a3EO+oypJbxBYE oJ4RxljdZJ29Xde8iYvfu60TlKydVeM0Yjft29yJKHRTo7tDwAgaFaJ3DbONMYZdx2OO JQzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776946341; x=1777551141; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j1/l4zkCa5WUec0T7M2clK+8oAp4jlm4b6G4GuYEZaY=; b=oIk/zkCbyVDKVqrN5r5heReqBQ3xko2PhYyTx2PHB5WIVmWxqNCOac1zuAqhwmmTeG qcth1jKXsIYM0vY5mjfSTldXyjlYUbQVRzrn+jmSAbDtzy8K9u++7wlnYgw4wpiJyaUC DwJY9MUxHOhauuG7a04xsXNNDFJb08aLE9nZsuiTVDvOcpYrVlr0D5GrbB9h8e/pij5U KIzdexSQ291hEnIwQxgl6N9/zr+vLUME5Ui9+4rTVzJncLJ4yGbq7tglfYznu0j4bFv6 g5sK9b+a/OWYiN11I2mAZGSKbIBYDfWQtPgSIcgvq94z6ndLpSHK/T4giTJQylEGKBy3 0chQ== X-Forwarded-Encrypted: i=1; AFNElJ/DaGiwPGilaXWtomEy9VgZbAD4qQe8O41igIQtXfQlT176HScsK84Tb31NLFidOA4hwMePqsjr2YEwHL4=@vger.kernel.org X-Gm-Message-State: AOJu0YyKHBabcPU+SS5w1SV0Kf1IVaolQRZAduQUhXmNd7iyCL1H5+b9 JgzNe+QmTOvsGhQhU1kxucqO8mcnp0zS038iUKe5KoXceud1agbFuQVso2cwTik67LFDdE827+5 81lMRk7UxBm1kaDcy/MijFEF/26dUN02zxJNYSEwMIvQWEKtKBaWGxRAnXIpjK0pbymw= X-Gm-Gg: AeBDietBRAcrxxOKc9yg5qujFSCE2X1KA8wDXd/zY3b3CJFmyeKDVzZwZo/mWT44wLF qkravHbFueEnsXTaQ9Yg8L3d/4QjLNbmzbJMR5pEagzR1YF7OVXweNWqY2gxp6U+u7cMTEYa6Fe XmCIeUJ7D1K/lzh6ndrDsg0zq0qHWMQX0P9KynHHTtfl/eAMUb0qF9h8lz223rmZeVLNAan2l3t 6bzPL/Bz59+BXXpHrTuzoepoIOVJMcmUgNKCq/JeNRVgYLlzlcpkUI0TBhxXwENc5CLW7EcpUWG +0M+wC1WysvCq80HtpPmYsYe8SFnKEvLEsDm0axqtlfbUZoejsK22vPZcGw1yQ/CnKejC3f2cFz 2Tgd7NnuK1VnU3tCTioSDHoy6CaJ7r5NH3opSWZRvLe8U6Gq+Cqw3SqYfB6FQKQ== X-Received: by 2002:a05:6122:32ce:b0:56f:b674:783f with SMTP id 71dfb90a1353d-56fb6748742mr10294250e0c.6.1776946340982; Thu, 23 Apr 2026 05:12:20 -0700 (PDT) X-Received: by 2002:a05:6122:32ce:b0:56f:b674:783f with SMTP id 71dfb90a1353d-56fb6748742mr10294224e0c.6.1776946340469; Thu, 23 Apr 2026 05:12:20 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:843a:1e93:1fb7:5d86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a4b329542sm426273565e9.3.2026.04.23.05.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:12:19 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 23 Apr 2026 14:12:02 +0200 Subject: [PATCH v2 1/3] driver core: platform: remove software node on release() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-swnode-remove-on-dev-unreg-v2-1-0e5213cde2ed@oss.qualcomm.com> References: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> In-Reply-To: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Brendan Higgins , David Gow , Rae Moar , Andy Shevchenko Cc: brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1995; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=Z5Ah5+zyjgUIowchJf0oKYWytwiEw0ZLXjONRjD4ydc=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp6gyc8BFN2OMi/NvzCeSL3PhW5qcVNOou0R9Rg h/WX3ZUL0iJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaeoMnAAKCRAFnS7L/zaE wzGWD/0dKHCDkPsrY5Z95Zjaq6cQqBJyjVbUah7Ig1lXckZgdmeTwtH6fke8IibjvD36gF0DoNb wSWmkg2BjE3ujC+A3elq6vB5Jd9uViJtNY+3hxBNZ6I0lUjP0X//rvzaZnmb0Oog8muxh5Se/nJ CfUTODJXIpr2x3LmZROlye2Evbgu3wo6Ve2EtMHNK5gg6Z7VRM2+KpyRLGLrujD8q/NWXsdtrLL FTvcqU1d2RTCKa/2584nm807/yhbFUjbLZ8NYYAUNTpxdufXpHQDMx1Pw7M7gha2Ouks9sxgabm M0bMyDYUBLeWNUjFfRUoDEcAnWUApXFqmgStOuqisDWz9gaWGRNh0iVdU+Q2EfJn3McvC0UVqMu uUf1W+kuanZ4QBVFTmGEwNitrLvRFCUp3ly0geDzbrP4XPfUv3kNCc8e8jrndPzaIhKlZgHFLXT p5YXYs7VWTy61kSPXV3mVkMxmOI8cV4UJ3SnV/zo4DQRb3drMuhy5SawuaE/0tFI+NcizIQqqLO ZleiLSATOAuC3GGOpFQIJD8vdv0IDPSkBYUKPpTh8rpPYMpH5Cn1Po89uUymIF+p4NKEPErhRJb A7848gc2xAHfNF1cU2Vm+5GtJoJ8d5S0XPogFrrCL0QPo9Kkxu+6/JUUv0+U9Pys78MTsK3znVm DcyTnL9I7VXBbeg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEyMSBTYWx0ZWRfX+Qa5cmXOfzgS 2F1BAXEGbp/rcqohAWH9Kc/GxIN33v/IZRcRnxy7JHpJnfMa2np+F02bLd4BucVRwKv4JQlExM3 3CoYiCbyl2J8PU9Pf0SuHGD+J/I3qsK7Q8TeLGCZeIFstwgiar4JQB3UElHinmP2zBuxxaWC2sC /gI8qMoQidS0otnkxxnnzOgRKyDSHsNCgxM8qtPuSCAta3pZmsJXM6qS5sYsnqxfBC/msTPqWM9 8tcQvuKhngUkfZBOjwjfa4H4MaY/c7kKXyDcCwgOhPiO3nmj66Ao/ACbk0k6MVlXM/Bg9Ocbywz xWl9zvDB3CKiLmB7NnnCAcCqfj8jVOZ+x+TKznm8YXfz0j/0nFED18GWm0mH+497yYbo24Bvo+q PX9BeDSSIjngo7VY8ilV9axjRa0IN8SZbBkCRbtsX38Mhp13JGN+hVrfUvPk3akHx5ehDs92u2/ sBDgiomdUmaXkmyQJMg== X-Proofpoint-ORIG-GUID: vfRCp43JtlBwr9w3hQOSgifZ3JM1B7i0 X-Proofpoint-GUID: vfRCp43JtlBwr9w3hQOSgifZ3JM1B7i0 X-Authority-Analysis: v=2.4 cv=TJt1jVla c=1 sm=1 tr=0 ts=69ea0ca5 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Qj4d4BcRTDQS6HVN2hUA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230121 If we pass a software node to a newly created device using struct platform_device_info, it will not be removed when the device is released. This may happen when a module creating the device is removed or on failure in platform_device_add(). When we try to reuse that software node in a subsequent call to platform_device_register_full(), it will fails with -EBUSY. Add the missing call to device_remove_software_node() in release path. Make sure that we still function correctly if a software node is used as the primary firmware node. Fixes: 0fc434bc2c45 ("driver core: platform: allow attaching software nodes= when creating devices") Signed-off-by: Bartosz Golaszewski --- drivers/base/platform.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 75b4698d0e582e67adafa78c312d75c72fd654cf..43ea7dcd338dd3ddae57e6d0677= e5cb2673f6ed5 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -599,6 +599,7 @@ static void platform_device_release(struct device *dev) struct platform_object *pa =3D container_of(dev, struct platform_object, pdev.dev); =20 + device_remove_software_node(dev); of_node_put(pa->pdev.dev.of_node); kfree(pa->pdev.dev.platform_data); kfree(pa->pdev.mfd_cell); @@ -885,6 +886,16 @@ struct platform_device *platform_device_register_full(= const struct platform_devi goto err; } =20 + /* + * If the primary firmware node is a software node and there's no + * secondary firmware node, the primary will be affected by the call + * to device_remove_software_node() in platform_device_release() and + * its reference count will be dropped by one. Take another reference + * here to make it have no effect. + */ + if (is_software_node(pdevinfo->fwnode) && !pdevinfo->swnode) + fwnode_handle_get(pdevinfo->fwnode); + ret =3D platform_device_add(pdev); if (ret) { err: --=20 2.47.3 From nobody Wed Jun 17 06:26:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 236073BED5C for ; Thu, 23 Apr 2026 12:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776946349; cv=none; b=I40SLUcdU2cDv4dPnsZIcdJ8Dwx61WBqj9sDiLYufQ/cdWFRAMdu2gRY09WEzWouaYEL9CtRef9oPSTu54uPDk8Gckjdvxcqc7+5Ir2IMz3SaPI4hPEguN+QOfWyU1PtKaq6mihoTU7q3jHjEJ5vC6WalXg27BEceb3KiVXwOTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776946349; c=relaxed/simple; bh=DeQzfE7uEw87FoNwrajQBxkZ/sMoxBLsCBYIPXjNSsI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UhZT1VBJXPsm42OgRTEQQ3etgMYYet4TwAdvn/5O3uEwrmcUlE6IDRVtf1U1o/nS721inlfKXzr8J/NRaTnb/UbUZUJLRgfg1plGnN9viDjNKpo4bkUOxiw7nXN+h96/xG7g8aSQnB2JMZsYaVq1gI9n+Mk0jgQwog0qYW+VzQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HIhol+67; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BcEv0DpW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HIhol+67"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BcEv0DpW" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uH3r030030 for ; Thu, 23 Apr 2026 12:12:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 34bMm2QC5D3vRxjYjMA8BCTGNq2X+nM48LZ6CVNLD7Q=; b=HIhol+671TfNhcF0 iAMpbgTTIz2Twn5CiyPdiEhPMtJdMeQCHw84ftNR0BYCApO7vjkJ2yu1XZurFRB7 CHWzGrlNlGBJF8XGLaZ6TBG3l+1+7OHnvqFCq0J6YopYHQ+Z3LRSEUUwMoNGLv3g VJOfSDQrlyhMzu1GJ9fuGNUdPwLg3MNLyFv+2jkgEEnKocTlWql7IcZaD62VqzRm f5wocODrhG1KlZWPdq7gM9cPh9SspAPTbJQnzv8vidHhBO+wWuvlLvx1U30Sp3Jn s8g4LqrjfXA9zAp1VyIfIn9lOp3+8FWHdzJTPZhlPY68F/XMEey+VqRlHfxZ6pHS BzyfWA== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqdjm1et3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:12:24 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-953e00e8ea7so3034450241.0 for ; Thu, 23 Apr 2026 05:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776946343; x=1777551143; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=34bMm2QC5D3vRxjYjMA8BCTGNq2X+nM48LZ6CVNLD7Q=; b=BcEv0DpWedJOO2puE8G8rABSDv+x8/jMuoikFNLbC+o1y4SYa8MrJhFzYJI5L4IQpE Cej3DQDuHVzQVkg5RwBEo+VyetxrO5Em3UDXCk/yEnKT3rxk0KWJbb+w+DV8pG1J9cnc hZAMaF3AswWxPmKm6Vjx6ock+fbO78NUB9Mlis+WzZ2+sULho4wK9qrgiANyAg+/QEV6 huhBDZPdwdA8pbwVBVg5wgiHQyy9ELfbdmPnmLD/3UDo9PHOoOatjhyhYZbBsauc56TK QYtT9Gl/twyja8P1Y8NFKaHRAPfEVVplRaIkJD0LbcIf46TToSaObs2zkpZ+/ASwPsxK Jkcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776946343; x=1777551143; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=34bMm2QC5D3vRxjYjMA8BCTGNq2X+nM48LZ6CVNLD7Q=; b=MlTdp+Ylnyu9yCtxJYvNnnljca+ah0aRqmuB6QzrPzXrgux6mruYnYUGIjXFWW8MJA cfxTJZktG3eAi6RvKIScwxIcXjOJrvfErJE9qMz+lTXOjBGKBDWNWPM9QGFwz2768mNS ZmydWCmItrtd3icCvLndo9hOIpjU+Be4apR6AyCCkVaDcUgGB/FqLGu4vjgwTED6SKSw tIhw/MEtT3ipSk/YYB+sBirsNWhCdcy9dzRXCkIPqSjuhbJodfqhkD7xMxvTzjiwI+5S +1lgF94NvzVQ/XrXAPghoUR/DimsD1gF5NjPb9Oc9N7Y+yh7n8b1uznNnmVo29AS5t2Q f3lw== X-Forwarded-Encrypted: i=1; AFNElJ8EdgBg8Yq21vr/vXD1GGL7Zq2fMprUDifgPz1zmhc6IJKZhVeR9d670RwQMUvU0ssutMhl15BKNoT1UB8=@vger.kernel.org X-Gm-Message-State: AOJu0YztpV5O7Lxv0pQpv3OqWJG9RptJiGBvEs5Hac9d58/26+e/NE0t mGx8IeRmOH+l/3cYS0ampKaxoOL2b6yqrrBEF/ACN4+N5tjwQgQw9+fyvCXOgqRnLg5OaG73cPj TiTbseMEx2QizNU8qdQF4KzwGdH9UCdQCQSbyctGpwGmWvPuEK5uyMueSmC+NfV9B4d0= X-Gm-Gg: AeBDiescFQstvyjQvoAXdD2y+Y1vWKht5LoByoLtJkE5jZ3OktI94dOIoO72TkCZf9y RJ2IrtJ6o91c66dqYMjhVtI/hkgM5lf0ztYKMWsB63hw1FMrodEbISpTwFYVALg97dwZI3pmCMl SrJNSV7bI86g6tMTRCTHPDcvUl7JKoBc5Cu8mLGH/u17fsQ8HuE7PIKIn1PvRlnFNxLUcx4T0d8 6zSisiDi4S+nMZzT2n+NuOf3DWY40XzejFJG+KhiHivxiMtrHyFEBZC3wOL9rTQfCzGPvzXXeat Hi0pPJ4lTeZrCz8EJJrZx9rqgMQTGPVzEOws4zWApZMiAsa0zOJZdFJCa6mt9uNI9CAhrVnEocQ rLwj76ukdFVn2fUh8qnaSPpxbfQlXWiyeJkbWMHjee0qkp5Sxu42669JptidZrw== X-Received: by 2002:a05:6102:441f:b0:611:82b:a594 with SMTP id ada2fe7eead31-616f4f742a9mr11774519137.4.1776946343461; Thu, 23 Apr 2026 05:12:23 -0700 (PDT) X-Received: by 2002:a05:6102:441f:b0:611:82b:a594 with SMTP id ada2fe7eead31-616f4f742a9mr11774503137.4.1776946342965; Thu, 23 Apr 2026 05:12:22 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:843a:1e93:1fb7:5d86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a4b329542sm426273565e9.3.2026.04.23.05.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:12:21 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 23 Apr 2026 14:12:03 +0200 Subject: [PATCH v2 2/3] kunit: provide kunit_software_node_register() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-swnode-remove-on-dev-unreg-v2-2-0e5213cde2ed@oss.qualcomm.com> References: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> In-Reply-To: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Brendan Higgins , David Gow , Rae Moar , Andy Shevchenko Cc: brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3107; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=DeQzfE7uEw87FoNwrajQBxkZ/sMoxBLsCBYIPXjNSsI=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp6gydWozYlB8JZk4hwE8vQPB00YTzpXKRmFelb PKtewnzoMSJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaeoMnQAKCRAFnS7L/zaE w2QqD/9B1Vct/6IRC/j4NApvRWjYQehb6gccubkNkNOEFJ1AQAqefM8FUqqaEQpQ5a3wX1FWBCx 3LH6cfUbvQcdghjWsI+TzENB+/OaAkdj3xdjhlv7AJLiBu18fPGkWD53PzUWJPA4np3FUcxa1sF KwRbVqZghkqd9aais16O+YNUV8x9usQJKvSrMwa2JH7TgUJWPYy9XsG4p+8ywWD0Vucb3EwiAcx XOGwrlMl37WOTONGZZWZ5Ieqg9rPbaHBk7nL9q55Y7I3mzrMf1YaWUXmOCje1a5bLMC8qcFxv6Q UYtLwhWncKGIob3BwhaSb76V38nDsBRx7af3t7kf57MCwDeRpVW2Z66BYEc1NYYcd288CeYP0b3 CTJbi4ggihzTAND5cwikObtbkb8A6VE7umgOSIMM/xfte45MXahKtBq5jRI5iaHnjmnIS2pAIQL baa3Kr/+4LV9+QWeA+Po3fvMFt2lWiToYlLE9u3S2COsdydrwiTzZTOZniBjTNni/Boh/ESpe36 a4LHQneC8KIZWHUZaYD17CZPu2LSfgwvzn+r4RFC1+wQBSIRxpuARnGo+ctPDZ7wnlMtMlYYPzA yJEuZmA+rBwrNyXVZfYixmkn/eFuWfWMzprUqQ915/7BwjZGERiA9p/TJl97AaWeeig5kKfLWv4 6AH5rEaJ7byy78Q== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=EZn4hvmC c=1 sm=1 tr=0 ts=69ea0ca8 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=0NWOcHYCwBz2ZqcsIPkA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-GUID: deX5Zst1pRPhzYFA42Nn02twWAf98_w- X-Proofpoint-ORIG-GUID: deX5Zst1pRPhzYFA42Nn02twWAf98_w- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEyMSBTYWx0ZWRfXxL6BtiNrCc3J 9dowxLYVPq0g9AxeHPma+rHtkaEQO3fVPEqWKrnEbPTP/dE+VuwOKZXR7pQha3gtBYCHcKnafmK QtksSQ+FAzcZmoF/n0d6x8MXW+TylI2ADHJ+MveOJZvDb0sevH/bSFKgccqPmJHuEKv/404CfUt d+gTaRm+nDHnTgeux0Z/CvaCFxug0esrUcNivDID7HW/Liy7Kfp5g55t2Lz5UynK+Iu/r6uaJhz kbu1CbdVKPM/4LEBasSAdVfjQDm5UGxSvlW4HvKE4bHictmDuya8W4kdSLknbbIy49atuwmJoya bgUs7BEn4EHuZhEi49x0m3eB6coNV0UmwxRuuKvPCuSs3z3gWdng65ZZnYz+jex6GjC9Apc3BXm nEqFijE++XPUyZLowdPonjh7NpOb+8XCbfQooOMRlZEOeRauBbpHjcMp5WhL4SgKNdAwJHzB9Y0 /I3naidH1oogePjY76A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230121 Implement a helper for registering kunit test-managed software nodes. Signed-off-by: Bartosz Golaszewski --- include/kunit/fwnode.h | 19 ++++++++++++++++++ lib/kunit/Makefile | 3 ++- lib/kunit/fwnode.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 73 insertions(+), 1 deletion(-) diff --git a/include/kunit/fwnode.h b/include/kunit/fwnode.h new file mode 100644 index 0000000000000000000000000000000000000000..e1554ace64b8a5899aff9f4b424= 7e5157826a49b --- /dev/null +++ b/include/kunit/fwnode.h @@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * KUnit resource management helpers firmware nodes. + * + * Copyright (C) Qualcomm Technologies, Inc. and/or its subsidiaries + */ + +#ifndef _KUNIT_FWNODE_H +#define _KUNIT_FWNODE_H + +struct kunit; +struct fwnode_handle; +struct software_node; + +struct fwnode_handle * +kunit_software_node_register(struct kunit *test, + const struct software_node *node); + +#endif /* _KUNIT_FWNODE_H */ diff --git a/lib/kunit/Makefile b/lib/kunit/Makefile index 656f1fa35abcc635e67d5b4cb1bc586b48415ac5..7549a701791b5b7eaa8e0637b68= 18cdfd0b655a8 100644 --- a/lib/kunit/Makefile +++ b/lib/kunit/Makefile @@ -10,7 +10,8 @@ kunit-objs +=3D test.o \ executor.o \ attributes.o \ device.o \ - platform.o + platform.o \ + fwnode.o =20 ifeq ($(CONFIG_KUNIT_DEBUGFS),y) kunit-objs +=3D debugfs.o diff --git a/lib/kunit/fwnode.c b/lib/kunit/fwnode.c new file mode 100644 index 0000000000000000000000000000000000000000..bc8bf06762dd71a741a3419c1ca= 04028d6ad3ec8 --- /dev/null +++ b/lib/kunit/fwnode.c @@ -0,0 +1,52 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) Qualcomm Technologies, Inc. and/or its subsidiaries + */ + +#include +#include + +#include +#include + +static void kunit_software_node_unregister(void *data) +{ + const struct software_node *swnode =3D data; + + software_node_unregister(swnode); +} + +/** + * kunit_software_node_register() - Register a KUnit-managed software node + * @test: test context + * @swnode: Software node to register + * + * Register a test-managed software node and return its firmware node hand= le. + * The software node is unregistered after the test case completes. + * + * Return: Firmware node handle of the registered software node or IS_ERR() + * on failure. + */ +struct fwnode_handle * +kunit_software_node_register(struct kunit *test, + const struct software_node *swnode) +{ + struct fwnode_handle *fwnode; + int ret; + + ret =3D software_node_register(swnode); + if (ret) + return ERR_PTR(ret); + + fwnode =3D software_node_fwnode(swnode); + if (WARN_ON(!fwnode)) + return ERR_PTR(-ENOENT); + + ret =3D kunit_add_action_or_reset(test, kunit_software_node_unregister, + (void *)swnode); + if (ret) + return ERR_PTR(ret); + + return fwnode; +} +EXPORT_SYMBOL_GPL(kunit_software_node_register); --=20 2.47.3 From nobody Wed Jun 17 06:26:39 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B29E3BE16C for ; Thu, 23 Apr 2026 12:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776946349; cv=none; b=nGbs4RzpTtLzBSGU7TEK341nxliNEUIpzXmsH/2zN2E47owVJly9TpmEw4RYWyLjNBBsSnQAwRa2vFkybQZSS7QG9M1lyZzmsy7XCwYGNKujbgl2B5EbJBL/CkU6Y8MMsinSMKpPjw1Rq7RDZB3QduGHvBf9rzgp8KgQHwPnYZk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776946349; c=relaxed/simple; bh=SlQMI8IRV7H1W+0eRMmQQFi9awkSEWmQRb6390DKD64=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pSlCg0MDi/y3KGnWq+/8xnrszPzqds+/jrYDyrjPKf91xTZFxNbWEx9qznklLHKZ1OmPLIK7r5IOBugYfbJnlWmMSBMhGEVaVcMYqMgX0vFX+fQZ+CY0iABmSROy/B0oK1dasjla6cK5a6SVjomucA8EYuqVjK9Ar9+E5BrgVPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Gu/juZfg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eKPKLjKS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Gu/juZfg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eKPKLjKS" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63NBwdGF009834 for ; Thu, 23 Apr 2026 12:12:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JC0K8TJYemUka3ukcc1xuIUxIRphSxLm0aw3i2Lpe9o=; b=Gu/juZfg9DW6wQ53 LoOzGqs7uExgdk74DDKx0DAm8MIH/AvFpR4pJGYFQVSftrjkb3zcrNpQQMEY1ewy 6m/s0Q//ZkPD/yrsV2anqkQziSqAkqxnyc2BSAzsKB4IhkhM1r95Grx60Ue81jab xkimBeZww6MO/w1I5LWRpJPwiZwgdrRz00qH5ByedVFzlqejrmnN1mlVsOvmJ8Tg 4IQrvG1Bq+3yD0aUoYwQs+5kqastSVu2JpANt9quv27YZUV3TQ7fteIeW+k4qZwn eQdT4UYxo/1o8+hVuFuk2EXhz/mGSJfCOtp2ZvuZP0WEClhNmetrfswRVpQquHpJ gWLS3A== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqk1781h9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:12:25 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50e5a336b44so59686661cf.0 for ; Thu, 23 Apr 2026 05:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776946345; x=1777551145; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JC0K8TJYemUka3ukcc1xuIUxIRphSxLm0aw3i2Lpe9o=; b=eKPKLjKS0G225sMkO8X6eNW/Y4hIvKQLkE+kke6YqNuwXuJxpSm7In/i8iwfDbt3IF TLLkW7WcJcrN3pp3s4rde+p5fxbdCSZR/W4dhNrpbvdQLONlyJFdFnR7A98nunWCTfDT 6RofiYT9BC1aqZMv3/XQyGfqi/wmIC90WBIIId2VsH2gOBAwrVnxFz28INgDBvmnbrNj 96WobMTgaVs/FvGJbfnzL3tUu0VlcuaS0LcledWouHOoi35wlmqCbDmqU/Ls+IxVqcHw GE+eQwQj16/WmrDSd245/551bDVMKsvWWUkOayilYX/uANSzlQgbY9Qn0FHQKO+FYUW1 dHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776946345; x=1777551145; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JC0K8TJYemUka3ukcc1xuIUxIRphSxLm0aw3i2Lpe9o=; b=SY+2Rl4AWz+3Kjx/+5/wmuGL+E6GZVlnAa+nHSJpT3Hsth6lpSpTmqIReP8rgJkWEl 8kpINk3VJNKa+oQGZTOUMJc/mkxcpz4bZRynIEtKz7Gs0FcJqTc11K3DjU2GEFPQyLu6 fmiuAxPZrGT9L/u/+yQbU9O0gv6ArB2OGiFoQjiSBsKesV8PE5WYHPZk4ONxMrjkvLAu gduJ6m/KljGcSFiXfs5MykN5mmt7NBpfin5aRqtofc+4ETIrV/qn4zfpZBGX0mPnC3IA 3JWj4/jWCjHQYUKXDpvnM3Zl4Zehx7o5wh8YX9Sv35b7mjcTQLP7n8U+idYuGcbpdICp ZNfw== X-Forwarded-Encrypted: i=1; AFNElJ9IC3GgHiJwKWfMoOddyGnoFMSaaIyoc8jQvcEQu01aXJen82rT/t/AZCI3ti/DG2ikN+vWKkYIe+XiKjs=@vger.kernel.org X-Gm-Message-State: AOJu0YycTRpVafbdCKYfsIvy37zDoM2/jHkWmAdgiAwkCWw0OW6mWcxW LbkoXBgyVVGyy1dG9FIn8HGl/jiTKNTtoyrgdiL4KgKAHNctVkUpEIZQBeQSIt7aPOKWDiAuqZS dQiDRqq3AEHVWWTQWVIVHMh72pqcy5UEl2w/nbBRAdYZiAEJGP4giBCiYTS22LQem374= X-Gm-Gg: AeBDietVoUDMcnPQYA1BCcwpuHRdlXtmMFZoXr4D4y8PrOYS9eGSw7PsM+cVla7RNRA TynAUHEnlWIrhp/6e81DJtOqqokLFdANBKRTURa3Y2W5U3kfsUy7b35NnWwijTXqQjAdPfKxdDt wanFMEP2G4Fd7zi6KvY9njzZ1T+FySH0rlYnE9X4wO3ELOeSOJcUZK+M40XAgLvyo2CKMukOWWp BE0E3hdouhKtCG1KMhVJhgBFCDTkL48CvqmS2lcur2Araxvqylh+Zrkv5fTPMBNTpPVttugJC5F sGfaAQvfyOZxJHC82aP/CSpenNN0fQEPx2lTSX0wiJvwL4XLeCTIxgquG3YtrNEGuiZTuJkrrPI RMRiKrFyIAb73eXvgbFFsxcUesWv/rweIcObcjJlsFUVl3rp1bcpgp1AguqwDNg== X-Received: by 2002:ac8:5f4d:0:b0:50f:6e68:d71a with SMTP id d75a77b69052e-50f6e68e71dmr189569131cf.28.1776946345093; Thu, 23 Apr 2026 05:12:25 -0700 (PDT) X-Received: by 2002:ac8:5f4d:0:b0:50f:6e68:d71a with SMTP id d75a77b69052e-50f6e68e71dmr189568441cf.28.1776946344662; Thu, 23 Apr 2026 05:12:24 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:843a:1e93:1fb7:5d86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a4b329542sm426273565e9.3.2026.04.23.05.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:12:23 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 23 Apr 2026 14:12:04 +0200 Subject: [PATCH v2 3/3] driver core: platform: tests: add test cases for correct swnode removal Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-swnode-remove-on-dev-unreg-v2-3-0e5213cde2ed@oss.qualcomm.com> References: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> In-Reply-To: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Brendan Higgins , David Gow , Rae Moar , Andy Shevchenko Cc: brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4529; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=SlQMI8IRV7H1W+0eRMmQQFi9awkSEWmQRb6390DKD64=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp6gyeqxuM5PCbhczHEbe4WKT5eqDgjzg6iDDXO 4wUQzoCmrKJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaeoMngAKCRAFnS7L/zaE w/rlD/wL0If/GvdO1tv7cFZZI8IjImnBBeu5lMLRndVe/71H/5EmyKWMbOhP3vISG/F0wJqdewG 9s1OateVJTbflrHbQ09U0ZfIF9AQMVJuXQF3/aGK0r2wGN1X2iFjNVoa9GND3t9h01lD7T4SkWS o9w30ommUJ0m0kC0Ub9RSBJv8AThLvzN8l5rXRmivTlg5yD4+rcFxZ2oQfQdxwybtfn5LmYOEw+ SdtHFykWabbT7TkD5/0oC5wJtcrbS0Ba3ybWHd/gMkym6f8Csr6+UcXcKRxVRLdlX3iNTTyzaTC /4qmSssPiLOAB9qCf96GA2rvw88ZEbsYAyfHXA3Yy5C341oixHJ0FN6ZFtiPYTXg9gxqVTOyLtf EVezTRz5BEWYEThJodsG6XApGKy0xYB/9cMxSSyMIK33i1jhVuRcCxPYcuEjrf73qgA/gO81+9/ 1reSEhFVPzghc4d5zI11tmRYyUdlaTF+w5rt0HgLAdiLaSpIN0VOrmWFaBHrACYZReLJCCPUxHW s2GRRQ1nqamD24o+62NwQaruMLKPiBvJHeqjfifQFFitkoGTX/p71vj/QeQsVJeNaJ/gBMJnFGp YjyyVbmyZWk5sXld6rMek9TGkX+aCl3R4mI+KUIzPM+lLocPrnrAPs3hR+I1y3JMIVZ4F4MSMhs XCcGSjzvHKedJYg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-GUID: aaEz_kpfn8ZCzwoQsQ6QqoV0BTGNTFnd X-Authority-Analysis: v=2.4 cv=R98z39RX c=1 sm=1 tr=0 ts=69ea0ca9 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=nEOnLqI-ckDzOwT8s0oA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEyMSBTYWx0ZWRfX3eUWoWJ7/ybi b0d7w3HKM9oPaunJ+MjbWGXIta8kuQIB19zPQ9J/+kkFbYNUm/Uj+R76N4L6cpj4uekXEEirTJP TvsYz3zcq5HoBjsGiMEm3Y4R+7fGEBmJED8EUQC9BSc6IgzAPKRMh/N8HwIiLoDMjOJKqAaFw00 sIkQntuzHbeLP7AKKqLUxTyfuCQdKo3p13kWNB9Txg7afNYwNcOCsydrTnvXWSYlGV+3z3BBg0s kI1za8BbCVt6MByIgLc77KBlb7Euoau7+EHYZdUkjll3cae+eRW7LC4QTHSB/kAPRuUgMyI0Lia 4hS1JxUPp1S6Nxs+2rVzm8aNN6GfBAqeZLkxd+wdRYj/IVo9p8SxU2afbTDrkJ8sOm9kxFoh2F6 z+uKi3yy0Y8BfpWfbdqypYi2ma9xljNwiotEwH58lmN/9J92MZL+a0C+EYs+36AGYlJqU2ciURY nH3E2i6os2ZWRMBsSmg== X-Proofpoint-ORIG-GUID: aaEz_kpfn8ZCzwoQsQ6QqoV0BTGNTFnd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230121 Extend the kunit module for platform devices with test cases verifying that the same software node can be added to platform devices repeatedly. Signed-off-by: Bartosz Golaszewski --- drivers/base/test/platform-device-test.c | 106 +++++++++++++++++++++++++++= ++++ 1 file changed, 106 insertions(+) diff --git a/drivers/base/test/platform-device-test.c b/drivers/base/test/p= latform-device-test.c index 6355a2231b741791b54eb78af42e13f31f745184..4b23f0d7f88548c62c49801fcee= 0919915e6e153 100644 --- a/drivers/base/test/platform-device-test.c +++ b/drivers/base/test/platform-device-test.c @@ -1,12 +1,15 @@ // SPDX-License-Identifier: GPL-2.0 =20 +#include #include #include =20 #include #include +#include #include #include +#include =20 #define DEVICE_NAME "test" =20 @@ -253,9 +256,112 @@ static struct kunit_suite platform_device_match_test_= suite =3D { .test_cases =3D platform_device_match_tests, }; =20 +static int platform_device_swnode_test_probe(struct platform_device *pdev) +{ + return 0; +} + +static struct platform_driver platform_swnode_test_driver =3D { + .probe =3D platform_device_swnode_test_probe, + .driver =3D { + .name =3D DEVICE_NAME, + }, +}; + +static const struct software_node platform_device_test_swnode =3D { }; + +/* + * Check that reusing a software node works correctly. If the call to + * platform_device_register_full() fails after adding the secondary firmwa= re + * node, the software node must be unregistered in the device's release() + * callback or the subsequent call to platform_device_register_full() will= fail + * with -EBUSY due to the software node aleady having been registered. + */ +static void platform_device_swnode_add_twice(struct kunit *test) +{ + struct platform_device_info pdevinfo; + struct platform_device *pdev; + struct fwnode_handle fwnode; + int ret; + + ret =3D kunit_platform_driver_register(test, &platform_swnode_test_driver= ); + KUNIT_ASSERT_EQ(test, ret, 0); + + fwnode_init(&fwnode, NULL); + pdevinfo =3D (struct platform_device_info){ + .name =3D DEVICE_NAME, + .id =3D PLATFORM_DEVID_NONE, + .fwnode =3D &fwnode, + .swnode =3D &platform_device_test_swnode, + }; + + pdev =3D platform_device_register_full(&pdevinfo); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + wait_for_device_probe(); + KUNIT_ASSERT_TRUE(test, device_is_bound(&pdev->dev)); + + platform_device_unregister(pdev); + + pdev =3D platform_device_register_full(&pdevinfo); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + wait_for_device_probe(); + KUNIT_ASSERT_TRUE(test, device_is_bound(&pdev->dev)); + + platform_device_unregister(pdev); +} + +/* + * Check that passing a software node as the primary firmware node of the + * platform device does not result in it being unregistered by the call to + * device_remove_software_node() in its release path. + */ +static void platform_device_swnode_as_primary(struct kunit *test) +{ + struct platform_device_info pdevinfo; + struct platform_device *pdev; + struct fwnode_handle *fwnode; + int ret; + + ret =3D kunit_platform_driver_register(test, &platform_swnode_test_driver= ); + KUNIT_ASSERT_EQ(test, ret, 0); + + fwnode =3D kunit_software_node_register(test, &platform_device_test_swnod= e); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, fwnode); + + pdevinfo =3D (struct platform_device_info){ + .name =3D DEVICE_NAME, + .id =3D PLATFORM_DEVID_NONE, + .fwnode =3D fwnode, + }; + + pdev =3D platform_device_register_full(&pdevinfo); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + wait_for_device_probe(); + KUNIT_ASSERT_TRUE(test, device_is_bound(&pdev->dev)); + + platform_device_unregister(pdev); + + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, software_node_fwnode(&platform_device_= test_swnode)); +} + +static struct kunit_case platform_device_swnode_tests[] =3D { + KUNIT_CASE(platform_device_swnode_add_twice), + KUNIT_CASE(platform_device_swnode_as_primary), + {} +}; + +static struct kunit_suite platform_device_swnode_test_suite =3D { + .name =3D "platform-device-swnode", + .test_cases =3D platform_device_swnode_tests, +}; + kunit_test_suites( &platform_device_devm_test_suite, &platform_device_match_test_suite, + &platform_device_swnode_test_suite, ); =20 MODULE_DESCRIPTION("Test module for platform devices"); --=20 2.47.3