From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F16A13803C2; Thu, 23 Apr 2026 16:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.90 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961813; cv=none; b=U792bQmypBZqp01HwUQS94OmsdVGjNOvg3Vewn+DupKlkOHkuyPHKvV1p7OwDAL47M0TYEVeLJYWVBhtBx8lyOypLBLxsoGTh2eNjLsa+yBCZN00h6Jy3sF/72UmCp4fMM8um7SB38zCbyQB+Ndt1gI+gx8VZdHsSxyo1h1gQ2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961813; c=relaxed/simple; bh=ZXSTJ7b/38rgvmYO873buvlool6i84d5a2ZJr/9ipT8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BgvQUxLh9DUps2+VVAuXbsvy9TPMElYPMY4Kou71pzXmrQTmX4Lpk9LCQlRhiOUJFGwl4xPEuQshaJECMPv9Z136Ik4CcBt+e4a+IjMVr9HA3BdG6Fo0TqkYX+hL14IfgPOSaJvbtose/cdsVw8ian/Zw/+6YrW8oO6WGz9nCEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=ZGUSR4gu; arc=none smtp.client-ip=173.37.142.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="ZGUSR4gu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=2512; q=dns/txt; s=iport01; t=1776961812; x=1778171412; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=Ks0lsgTrBdaqV3gPaDF/jXpyLgWa4qOq0Cl3j1wSwFo=; b=ZGUSR4guD0vP5Kgb/wEZOcdhCPhbDhqaen60AiMH8SspalyY5M2Kxz6b chyy1H8UR+G+sstOynQ2Jif3Mpz3B6UjoHiFurBGY+oLXBZkepVJpQvJk hqyQUkvOlL6PEp/67YG3yjqgn1fDPVHhKCImaa97LpuIO3M6ABajTgFHa uwfsG3r3y3KGU5PxfE5B5OTbpuf2a8SEHDCVGaOT2RKFMWLVUBva3RxKQ c9ulZ1X+nLaRRfl4iGir3n1K0YidIpckZOqRcRT32ikmA+VtIBISSjc22 rT9fapj3ewDapomhZAkvHB3txvrUwHakdtQNhpB0gvCzPTU7oxSSl5JJl g==; X-CSE-ConnectionGUID: m46ZXPfLRMGKfxqLNDC25g== X-CSE-MsgGUID: l9WP7h05RHC7Me65Z1pb/w== X-IPAS-Result: =?us-ascii?q?A0BIAgCSPupp/4//Ja1aHgEBCxIMgWsQDwuCU4FPQ0mEV?= =?us-ascii?q?49TgiGeHYF/DwEBAQ9RBAEBhQYCjSwCJjQJDgECBAEBAQEDAgMBAQEBAQEBA?= =?us-ascii?q?QEBAQEKAQEFAQEBAgEHBYEOE4ZchlsCAQMjBFIQJQImAgJGEAYBEoMCgnQDs?= =?us-ascii?q?Dt6fzOBAYR9sySBZAELFAGBCi6FcoJmAYFwhAY7hD8nG4FJRIR9hAqEFIJpB?= =?us-ascii?q?IMcFIIgjH0JP4ECHANZLAFVEw0KCwcFYVIzAyAKCxISGBUCFC8PBBYyHXAMJ?= =?us-ascii?q?xIsFzRYGwcFgUuECW0UMQQhgQuDKoE2ewMLGA1IESw3Bg4bBD0BbgeKNCAPg?= =?us-ascii?q?TlxPVKCaCmTQIMyjV1roQ6EJoFkoA4BMpdmkwUsmFoio08xN4RogWg8gVkzG?= =?us-ascii?q?ggbFYMiUxkPji0WHMoDJjI/BwIHDgKRc4F9AQE?= IronPort-Data: A9a23:CZ1cta9I3rNSx7d8c1HwDrUDQH+TJUtcMsCJ2f8bNWPcYEJGY0x3n DdLUGzTM6neYmb2Lt9+at7l9EIGvsXTmN5qSwQ6qyxEQiMRo6IpJzg2wmQcns+2BpeeJK6yx 5xGMrEsFOhtEDmB4E/rbui/xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOdRbrRA2bBVOCvT/ 4mpyyHjEAX9gWAsbjhPs/7rRC5H5ZwehhtJ5jTSWtgT1LPuvyF9JI4SI6i3M0z5TuF8dgJtb 7+epF0R1jqxEyYFUrtJoJ6iGqE5auK60Ty1t5Zjc/PKbi6uCcAF+v1T2PI0MS+7gtgS9jx74 I0lWZeYEW/FMkBQ8QgQe0EwLs1wAUFJ0Lqbf0qPicK39WjpUHX82tFIIGpsYIJNr46bAUkWn RAZACoGYhbGg6e9x6i2D7EywM8iN8LseogYvxmMzxmAUq1gGs+FGfiXo4YEh1/chegWdRraT 9EQdTt0bBfASxZOIVwQTpk5mY9Eg1GgL2QB8w3F+/dfD277yF1O6OftaIfvWvfVYMgLw3TBv miB4DGsav0dHJnFodafyVqgj/HCmAv3UZwfEbm/+OIshlCPrkQXBRwKXFyTrfSzi0e4HdVFJ CQ89yYzqKEg+VCDQd76UBm15nWDu3Y0WMdaGsU55RuLx66S5ByWbkANSDJbZcNlssIqSTE0/ luUmdWvDjwHmKWcQ3+b95+OoD+yMDRTJmgHDQcATA0Y85zgrZs1gxbnUNluCui2g8fzFDW2x CqFxAA4iqkfgNAjyaq25xbEjiiqq5yPSRQ6jjg7RUq/5Q9/IYrgbIuy5B2Ds7BLLZ2SSR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnzjxpZGFUwWWJSIqQ= IronPort-HdrOrdr: A9a23:Ixv12q9U5dsgRxgl0y1uk+AuI+orL9Y04lQ7vn2ZhyYlFvBw8P rOoB1773HJYVkqNU3I9errBEDEewK/yXcX2+Ys1MmZPDUO0VHAROpfBMnZsl7d8kbFmtK1u5 0QFpRWOZncAUd3iMDi7BL9MdoxqeP3iZyAtKPyw2hgSAdyZ7ol1Qd2DQ6HDlZ7LTM2Y6bRbK DsgfZvln6HZWkdaNi9Cz0uWujOoMCOqbfdCCR2fyLOLGK1/EmVAHmQKWni4isj X-Talos-CUID: 9a23:pADbvWBm3SF+ZY76Eyw7qnwkIs4BSFjy73nAOmueJU0zFbLAHA== X-Talos-MUID: 9a23:0GZVZQWIJtir7Ijq/Du9uwk9NJ812YSFV2UAz8g04tGOcjMlbg== X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="741137865" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-3.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:02 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id 254C4180003AB; Thu, 23 Apr 2026 16:29:02 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:02 -0700 Subject: [PATCH net-next v5 01/10] enic: verify firmware supports V2 SR-IOV at probe time Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-1-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat , Breno Leitao X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=2560; i=satishkh@cisco.com; h=from:subject:message-id; bh=ZXSTJ7b/38rgvmYO873buvlool6i84d5a2ZJr/9ipT8=; b=90YRLlQzoHUs/dWlwOgUlCwhbW9Bad3DjLGRQ1leGNKTHHOubM/uvuVRUtLmejCpW/828nSLT Fvl8c5lHNO+A+OeISO4Gi+lGEgIAqObut6QIbt4OFFro/5Gm0rVRsnG X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com During PF probe, query the firmware get-supported-feature interface to verify that the running firmware supports V2 SR-IOV. Firmware version 5.3(4.72) and later report VIC_FEATURE_SRIOV via CMD_GET_SUPP_FEATURE_VER. If the firmware does not support the feature, set vf_type to ENIC_VF_TYPE_NONE and log a warning so the admin knows a firmware upgrade is needed. The VIC_FEATURE_SRIOV enum value (4) matches the firmware ABI. A placeholder entry (VIC_FEATURE_PTP at position 3) is added to keep the enum in sync with firmware's feature numbering. Suggested-by: Breno Leitao Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/enic_main.c | 21 ++++++++++++++++++++- drivers/net/ethernet/cisco/enic/vnic_devcmd.h | 2 ++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethe= rnet/cisco/enic/enic_main.c index e7125b818087..53d68272d06a 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -2641,8 +2641,10 @@ static void enic_iounmap(struct enic *enic) static void enic_sriov_detect_vf_type(struct enic *enic) { struct pci_dev *pdev =3D enic->pdev; - int pos; + u64 supported_versions, a1 =3D 0; u16 vf_dev_id; + int pos; + int err; =20 if (enic_is_sriov_vf(enic) || enic_is_dynamic(enic)) return; @@ -2669,6 +2671,23 @@ static void enic_sriov_detect_vf_type(struct enic *e= nic) enic->vf_type =3D ENIC_VF_TYPE_NONE; break; } + + if (enic->vf_type !=3D ENIC_VF_TYPE_V2) + return; + + /* A successful command means firmware recognizes + * VIC_FEATURE_SRIOV; supported_versions is available + * for sub-feature versioning in the future. + */ + err =3D vnic_dev_get_supported_feature_ver(enic->vdev, + VIC_FEATURE_SRIOV, + &supported_versions, + &a1); + if (err) { + dev_warn(&pdev->dev, + "SR-IOV V2 not supported by current firmware. Upgrade to VIC FW 5.3(4.= 72) or higher.\n"); + enic->vf_type =3D ENIC_VF_TYPE_NONE; + } } #endif =20 diff --git a/drivers/net/ethernet/cisco/enic/vnic_devcmd.h b/drivers/net/et= hernet/cisco/enic/vnic_devcmd.h index 605ef17f967e..7a4bce736105 100644 --- a/drivers/net/ethernet/cisco/enic/vnic_devcmd.h +++ b/drivers/net/ethernet/cisco/enic/vnic_devcmd.h @@ -734,6 +734,8 @@ enum vic_feature_t { VIC_FEATURE_VXLAN, VIC_FEATURE_RDMA, VIC_FEATURE_VXLAN_PATCH, + VIC_FEATURE_PTP, + VIC_FEATURE_SRIOV, VIC_FEATURE_MAX, }; =20 --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92DEA384235; Thu, 23 Apr 2026 16:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.90 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961815; cv=none; b=BY5jmClf00gE4HqDuUF05sad5+z5zxwfPymu2sNaRQrSUJ3rFRb2f9o0ooJJWGxtPtY108aMh7JVhTyiLcrHMvkmmxxahBsH0nJsnF1m4T7ZSfY7GgaP7lTnsEVH1t7lWfZq7l//YApb61L1ViOa+cCXWWJTw1Uc7ZEsNtoGEmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961815; c=relaxed/simple; bh=qlhfeksZz+XKX74y86PMSctRMUhiqOEZnpCahTINQR4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=susBgfK/WGH51kRLm+P0AqF5ybiJpk6oZWnv0UK69oEws6vyJSF0bKyWlnL/zXa15LZWN2erYkP1hxmnFB9rbx5k73Zdo1Tj7esIjDCUmmLtv8+wQpLZNcY+jzYkgktmkvjT8R8IR3ZL99expqRW96bb2HtNsSFViIKZVDhYNiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=jfc7vLXt; arc=none smtp.client-ip=173.37.142.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="jfc7vLXt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=7994; q=dns/txt; s=iport01; t=1776961813; x=1778171413; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=rq8RkynOrOnd72OONYo14/aNiZR3uYmftnvTm/IgRNo=; b=jfc7vLXt+y5Yl5TmHARJmbHXRMJpXwHj12FpZfS8BSCaG5hvU0nG552o A+rCqqADSXQtZBIq/eOZEK6qWLrIxYNx0bFa+EoZNZm237Ghlge3nNjgv UdEXvGW37tKCFc+Uwxtr9W70rGfR7gWaxEiEdFWCLf4f2pbT2ImqiQEMt PVIwlh0PVFE8vbAkZ7uJid90A8ptfwfJqMMm9MH1n67414B8Sb7b5G/Z/ +VySASywCsxHuu+3RkeUZjE/TMKNAZUlp0YDsdDgEnLYnLmUEWa31u+CO Js4xWxbPejMAdX0b44b57ZG3E+vPWIB1EjtgX779QxrDRvjfXDfyb1y2I w==; X-CSE-ConnectionGUID: f3RziMF3QOKXdE+Mm/VnVw== X-CSE-MsgGUID: ErlZvQhHRlqIrB+RrBbm7w== X-IPAS-Result: =?us-ascii?q?A0AnAACSPupp/4//Ja1aHQEBAQEJARIBBQUBgWsQBggBC?= =?us-ascii?q?wGCUoFPQ0mEV4gchzeCIZ4dFIFrDwEBAQ9RBAEBhQYCjSwCJjQJDgECBAEBA?= =?us-ascii?q?QEDAgMBAQEBAQEBAQEBAQEKAQEFAQEBAgEHBYEOE4ZchlsCAQMjBFIQJQImA?= =?us-ascii?q?gJGEAYBEoMCgnQDsDt6fzOBAYR9sySBZAELFAGBCi4BhXGCZgGBcIQGO4Q/J?= =?us-ascii?q?xuBSUSBFAGDaIQFAQQVg3+CaQSDHBSBfo0fCT+BAhwDWSwBVRMNCgsHBWFSM?= =?us-ascii?q?wMgCgsSEhgVAhQvDwQWMh1wDCcSLBc0WBsHBYFLhAltFDEEIYELgyqBNnsDC?= =?us-ascii?q?xgNSBEsNwYOGwQ9AW4HijQgD4E5cVk1AU1vgSGTKAiDdo1da4E1n1mEJoFko?= =?us-ascii?q?A4BMpdmkwWZBiKjSW6EaIFoPIFZMxoIGxWDIlMZD44tFsofJjI9AQEHAgcNA?= =?us-ascii?q?wuBaJAAEReBVQEB?= IronPort-Data: A9a23:7eCbYqNCx7MJvb3vrR2SlsFynXyQoLVcMsEvi/4bfWQNrUpzgzUCy GRKX2mPPamOMWejLdglOdnioUoAsZ/Ux4cxSXM5pCpnJ55oRWUpJjg4wmPYZX76whjrFRo/h ykmQoCeap1yFjmA9knF3oHJ9RFUzbuPSqf3FNnKMyVwQR4MYCo6gHqPocZh6mJTqYb/WVjlV e/a+ZWFZgf5gWUsbgr41orawP9RlKWq0N8nlgRWicBj5Df2i3QTBZQDEqC9R1OQrl58R7PSq 07rldlVz0uBl/sfIorNfoXTLiXmdoXv0T2m0RK6bUQNbi9q/UTe2o5jXBYVhNw+Zz+hx7idw /0V3XC8pJtA0qDkwIwgvxdk/y5WM/Z86r7iDyOGlu+jw2CFVn6r/fNQExRjVWEY0r4f7WBm7 /cULnUJKxuEne/zmOz9Qeh3jcNlJ87uVG8dkig/lneCUrB8HM2FGvmRjTNb9G9YasRmBv/CZ tEZajpHZxXbaBoJMVASYH47tLj03yCkLG0H8zp5o4Ia+Wzh0jVx8ILpKfvPUJ+wX+9fmxmH8 zeuE2PRR0ty2Mak4TaM7H+pruPGgy7+XIUcCPu+++ICqFCf22kaGhAKfVS8pva9hwi1XNc3A 08J8CMGrqUo8kGvCN7nUHWQqXiIpBMDGNxdD+E39imJ16zSpQ2ZbkAcRzRMbt0OrsI6RTU2k FSOmrvBAT1pra3QSn+H8LqQhS29NDJTLmIYYyIACwwf7LHLpowvgh/RZshsHbTzjdDvHzz0h TeQo0ADa647l8UH0eC/uFvAmT/p/saPRQ8u7QKRVWWghu9kWLOYi0WTwQCzxZ59wEyxFzFtY FBsdxCi0d0z IronPort-HdrOrdr: A9a23:6JaBXq3Bu13SKiua10UqLwqjBB4kLtp133Aq2lEZdPU0SKGlfp aV7YwmPHjP+U8ssRAb6La90cy7K080mqQb3WB8B9mftUzdyQmVxeJZnOzfKl/bak7DH7VmpN 1dmsFFYbWdMbE5t7ee3ODfKbcdKbG8m5xA7t2uq0uFIzsLV4hQqz1XJyzeOlFqQjJLH4M+E4 CRj/A33AZJeR4sH7aGL0hAZcfvjZngsqncTTsvOj4Az02voFqTmc3H+xrz5GZqb9uYq41ShV QskGbCl9KeW+nQ8G6g60bjq654tfGk7OBsOfy0pqEuW0TRYp7DXvUQZ1WF1gpF3N1GuD4R4a bxSw5LBbUM10/s X-Talos-CUID: =?us-ascii?q?9a23=3AodO1amiVgnSvEXNukjy6RZslUjJufCbn3nb1DRS?= =?us-ascii?q?BLkVZRJDWbFrXxqVajJ87?= X-Talos-MUID: 9a23:puF+EQWU0T2uvCzq/BL2gAN8DcdI2aC3KVon0q8ckcOBajMlbg== X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="741137873" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-3.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:03 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id E22D318000279; Thu, 23 Apr 2026 16:29:02 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:03 -0700 Subject: [PATCH net-next v5 02/10] enic: add admin channel open and close for SR-IOV Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-2-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=8200; i=satishkh@cisco.com; h=from:subject:message-id; bh=qlhfeksZz+XKX74y86PMSctRMUhiqOEZnpCahTINQR4=; b=fd93zLe6yeVoSiUPLtNURBAcLNEp92yDuemCbwlfrhdOC5/MT9RdvMT0VL0xk1JxA37qxou/0 YxOKvEG9QC3Dw3LfQ/hddc7zqoYeR82clZ9WVugbYk3LAFtSFdGMOgD X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com The V2 SR-IOV design uses a dedicated admin channel (WQ/RQ/CQ/INTR on separate BAR resources) for PF-VF mailbox communication rather than firmware-proxied devcmds. Introduce enic_admin_channel_open() and enic_admin_channel_close(). Open allocates and initialises the admin WQ, RQ, two CQs (one per direction) and one SR-IOV interrupt, then issues CMD_QP_TYPE_SET to tell firmware the queues are admin-type. Close reverses the sequence. enic_admin_wq_buf_clean() unmaps and frees any WQ buffers still held at close time, fixing a DMA mapping leak when a send times out. Add CMD_QP_TYPE_SET (97) and QP_TYPE_ADMIN/DATA defines to vnic_devcmd.h. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/Makefile | 3 +- drivers/net/ethernet/cisco/enic/enic_admin.c | 186 ++++++++++++++++++++++= ++++ drivers/net/ethernet/cisco/enic/enic_admin.h | 15 +++ drivers/net/ethernet/cisco/enic/vnic_devcmd.h | 9 ++ 4 files changed, 212 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cisco/enic/Makefile b/drivers/net/etherne= t/cisco/enic/Makefile index a96b8332e6e2..7ae72fefc99a 100644 --- a/drivers/net/ethernet/cisco/enic/Makefile +++ b/drivers/net/ethernet/cisco/enic/Makefile @@ -3,5 +3,6 @@ obj-$(CONFIG_ENIC) :=3D enic.o =20 enic-y :=3D enic_main.o vnic_cq.o vnic_intr.o vnic_wq.o \ enic_res.o enic_dev.o enic_pp.o vnic_dev.o vnic_rq.o vnic_vic.o \ - enic_ethtool.o enic_api.o enic_clsf.o enic_rq.o enic_wq.o + enic_ethtool.o enic_api.o enic_clsf.o enic_rq.o enic_wq.o \ + enic_admin.o =20 diff --git a/drivers/net/ethernet/cisco/enic/enic_admin.c b/drivers/net/eth= ernet/cisco/enic/enic_admin.c new file mode 100644 index 000000000000..afb50aa413f4 --- /dev/null +++ b/drivers/net/ethernet/cisco/enic/enic_admin.c @@ -0,0 +1,186 @@ +// SPDX-License-Identifier: GPL-2.0-only +// Copyright 2025 Cisco Systems, Inc. All rights reserved. + +#include +#include + +#include "vnic_dev.h" +#include "vnic_wq.h" +#include "vnic_rq.h" +#include "vnic_cq.h" +#include "vnic_intr.h" +#include "vnic_resource.h" +#include "vnic_devcmd.h" +#include "enic.h" +#include "enic_admin.h" +#include "cq_desc.h" +#include "wq_enet_desc.h" +#include "rq_enet_desc.h" + +/* Clean up any admin WQ buffers still held by hardware at close time. + * Normally buffers are freed inline after send completion, but a timed-out + * send intentionally leaves the buffer live until the queue is stopped. + */ +static void enic_admin_wq_buf_clean(struct vnic_wq *wq, + struct vnic_wq_buf *buf) +{ + struct enic *enic =3D vnic_dev_priv(wq->vdev); + + if (buf->os_buf) { + dma_unmap_single(&enic->pdev->dev, buf->dma_addr, + buf->len, DMA_TO_DEVICE); + kfree(buf->os_buf); + buf->os_buf =3D NULL; + } +} + +/* No-op: admin RQ buffer teardown is handled in enic_admin_channel_close = */ +static void enic_admin_rq_buf_clean(struct vnic_rq *rq, + struct vnic_rq_buf *buf) +{ +} + +static int enic_admin_qp_type_set(struct enic *enic, u32 enable) +{ + u64 a0 =3D QP_TYPE_ADMIN, a1 =3D enable; + int wait =3D 1000; + int err; + + spin_lock_bh(&enic->devcmd_lock); + err =3D vnic_dev_cmd(enic->vdev, CMD_QP_TYPE_SET, &a0, &a1, wait); + spin_unlock_bh(&enic->devcmd_lock); + + return err; +} + +static int enic_admin_alloc_resources(struct enic *enic) +{ + int err; + + err =3D vnic_wq_alloc_with_type(enic->vdev, &enic->admin_wq, 0, + ENIC_ADMIN_DESC_COUNT, + sizeof(struct wq_enet_desc), + RES_TYPE_ADMIN_WQ); + if (err) + return err; + + err =3D vnic_rq_alloc_with_type(enic->vdev, &enic->admin_rq, 0, + ENIC_ADMIN_DESC_COUNT, + sizeof(struct rq_enet_desc), + RES_TYPE_ADMIN_RQ); + if (err) + goto free_wq; + + err =3D vnic_cq_alloc_with_type(enic->vdev, &enic->admin_cq[0], 0, + ENIC_ADMIN_DESC_COUNT, + sizeof(struct cq_desc), + RES_TYPE_ADMIN_CQ); + if (err) + goto free_rq; + + err =3D vnic_cq_alloc_with_type(enic->vdev, &enic->admin_cq[1], 1, + ENIC_ADMIN_DESC_COUNT, + 16 << enic->ext_cq, + RES_TYPE_ADMIN_CQ); + if (err) + goto free_cq0; + + /* PFs have dedicated SRIOV_INTR resources for admin channel. + * VFs lack SRIOV_INTR; use a regular INTR_CTRL slot instead. + */ + if (vnic_dev_get_res_count(enic->vdev, RES_TYPE_SRIOV_INTR) >=3D 1) + err =3D vnic_intr_alloc_with_type(enic->vdev, + &enic->admin_intr, 0, + RES_TYPE_SRIOV_INTR); + else + err =3D vnic_intr_alloc(enic->vdev, &enic->admin_intr, + enic->intr_count); + if (err) + goto free_cq1; + + return 0; + +free_cq1: + vnic_cq_free(&enic->admin_cq[1]); +free_cq0: + vnic_cq_free(&enic->admin_cq[0]); +free_rq: + vnic_rq_free(&enic->admin_rq); +free_wq: + vnic_wq_free(&enic->admin_wq); + return err; +} + +static void enic_admin_free_resources(struct enic *enic) +{ + vnic_intr_free(&enic->admin_intr); + vnic_cq_free(&enic->admin_cq[1]); + vnic_cq_free(&enic->admin_cq[0]); + vnic_rq_free(&enic->admin_rq); + vnic_wq_free(&enic->admin_wq); +} + +static void enic_admin_init_resources(struct enic *enic) +{ + vnic_wq_init(&enic->admin_wq, 0, 0, 0); + vnic_rq_init(&enic->admin_rq, 1, 0, 0); + vnic_cq_init(&enic->admin_cq[0], 0, 1, 0, 0, 1, 0, 1, 0, 0, 0); + vnic_cq_init(&enic->admin_cq[1], 0, 1, 0, 0, 1, 0, 1, 0, 0, 0); + vnic_intr_init(&enic->admin_intr, 0, 0, 1); +} + +int enic_admin_channel_open(struct enic *enic) +{ + int err; + + if (!enic->has_admin_channel) + return -ENODEV; + + err =3D enic_admin_alloc_resources(enic); + if (err) { + netdev_err(enic->netdev, + "Failed to alloc admin channel resources: %d\n", + err); + return err; + } + + enic_admin_init_resources(enic); + + vnic_wq_enable(&enic->admin_wq); + vnic_rq_enable(&enic->admin_rq); + + err =3D enic_admin_qp_type_set(enic, 1); + if (err) { + netdev_err(enic->netdev, + "Failed to set admin QP type: %d\n", err); + goto disable_queues; + } + + return 0; + +disable_queues: + enic_admin_qp_type_set(enic, 0); + vnic_wq_disable(&enic->admin_wq); + vnic_rq_disable(&enic->admin_rq); + enic_admin_free_resources(enic); + return err; +} + +void enic_admin_channel_close(struct enic *enic) +{ + if (!enic->has_admin_channel) + return; + + enic_admin_qp_type_set(enic, 0); + + vnic_wq_disable(&enic->admin_wq); + vnic_rq_disable(&enic->admin_rq); + + vnic_wq_clean(&enic->admin_wq, enic_admin_wq_buf_clean); + vnic_rq_clean(&enic->admin_rq, enic_admin_rq_buf_clean); + vnic_cq_clean(&enic->admin_cq[0]); + vnic_cq_clean(&enic->admin_cq[1]); + vnic_intr_clean(&enic->admin_intr); + + enic_admin_free_resources(enic); +} diff --git a/drivers/net/ethernet/cisco/enic/enic_admin.h b/drivers/net/eth= ernet/cisco/enic/enic_admin.h new file mode 100644 index 000000000000..569aadeb9312 --- /dev/null +++ b/drivers/net/ethernet/cisco/enic/enic_admin.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* Copyright 2025 Cisco Systems, Inc. All rights reserved. */ + +#ifndef _ENIC_ADMIN_H_ +#define _ENIC_ADMIN_H_ + +#define ENIC_ADMIN_DESC_COUNT 64 +#define ENIC_ADMIN_BUF_SIZE 2048 + +struct enic; + +int enic_admin_channel_open(struct enic *enic); +void enic_admin_channel_close(struct enic *enic); + +#endif /* _ENIC_ADMIN_H_ */ diff --git a/drivers/net/ethernet/cisco/enic/vnic_devcmd.h b/drivers/net/et= hernet/cisco/enic/vnic_devcmd.h index 7a4bce736105..a1c8f522c7d7 100644 --- a/drivers/net/ethernet/cisco/enic/vnic_devcmd.h +++ b/drivers/net/ethernet/cisco/enic/vnic_devcmd.h @@ -455,8 +455,17 @@ enum vnic_devcmd_cmd { */ CMD_CQ_ENTRY_SIZE_SET =3D _CMDC(_CMD_DIR_WRITE, _CMD_VTYPE_ENET, 90), =20 + /* + * Set queue pair type (admin or data) + * in: (u32) a0 =3D queue pair type (0 =3D admin, 1 =3D data) + * in: (u32) a1 =3D enable (1) / disable (0) + */ + CMD_QP_TYPE_SET =3D _CMDC(_CMD_DIR_WRITE, _CMD_VTYPE_ENET, 97), }; =20 +#define QP_TYPE_ADMIN 0 +#define QP_TYPE_DATA 1 + /* CMD_ENABLE2 flags */ #define CMD_ENABLE2_STANDBY 0x0 #define CMD_ENABLE2_ACTIVE 0x1 --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 782333590AE; Thu, 23 Apr 2026 16:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961813; cv=none; b=S8Nf10kOy7N9Y6NnMHHDNw+84qCVrOgltJWAFwF2gSfmbwUprvcID6gqVC5d4z16eCMFijXUphaU4O602GwmDVQQhqe5ducVWLybosUZyf60kXWUx1UEVdHb35/pB75z8XAkojiTuwBcF0BYQnRi3r/mZkXFroMBbtn7QY21t5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961813; c=relaxed/simple; bh=4snTvNDTFctwNaanim5qhFqEho3/iG5kKLIInaCFbOg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ldxKBXex7meFu7u95D2HCkmoZFGwoCY6BNxHcXic8YPPzsH0BnddtCJAB5lppIs6nXcAfq+OVSuzbYs3FlMLkRknjBIeNuRv5ZqtOtaiTpAmTR1i5HhBvfgaphPpOVr6nXSbOEtiurxMoz0ixSA1n45pGTJZd+jLUvDHxIyLh4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=EIFNvRET; arc=none smtp.client-ip=173.37.142.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="EIFNvRET" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=3582; q=dns/txt; s=iport01; t=1776961811; x=1778171411; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=yOd99C02HCfv6xc441zXMqGrOo5haJdo0vCAYX9IyQQ=; b=EIFNvRETnlAhlA9RyfDrCrY+7+Ha5nnJnMWEOvVIRfcZIkhBwDoWmbWR RUhTB8r0O3IwbyQhIN967xeXc4+v1PgZZa92Y4zo9CkyIumEgSYcxmdOU gOw9kaLihSsGFn7Qpf5jhyru1o1N8o71UOVtpt1tVHu4ChCkUHBStRhw1 8+cDPDb6+8hr4W/cIZCzIh3kMRJQ0Bf9DEcZu3yLPTkTRByIJ+WQBJGuF tJfenl9aWPh/iwEYWxa948J2Fl9SsaRAjsRUT3rPYT6SxQzLdl87xcACX 1QjTYoJKV42pCYA73I+mG+LAVIGDemu2OWqinBQn9tFJFJ4oFfUD6EDDA A==; X-CSE-ConnectionGUID: A0UGU7J+RvO1HMK0FXBZmA== X-CSE-MsgGUID: 9TLaDjtWRziKrt7nQ+6jlg== X-IPAS-Result: =?us-ascii?q?A0AnAAAkSOpp/4//Ja1aHQEBAQEJARIBBQUBgXwIAQsBg?= =?us-ascii?q?laBT0NJhFeIHIc3giGeHYF/DwEBAQ9RBAEBhQYCjSwCJjQJDgECBAEBAQEDA?= =?us-ascii?q?gMBAQEBAQEBAQEBAQsBAQUBAQECAQcFgQ4ThlyGWwIBAyMEUhAlAiYCAkYQB?= =?us-ascii?q?gESgwKCdAOzUXp/M4EBhH3ZQoFkAQsUAYEKLgGFcYJmAYFwhAY7hD8nG4FJR?= =?us-ascii?q?IEVg2iBGYMGg3+CaQSDHBSPHgk/gQIcA1ksAVUTDQoLBwVhUjMDIAoLEhIYF?= =?us-ascii?q?QIULw8EFjIdcAwnEiwXNFgbBwWBS4QJbRQxBCGBC4MqgTaBAQMLGA1IESw3B?= =?us-ascii?q?g4bBD0BbgeKNiAPgTlxgQ4UgSkjNJNyCBWDYY1da4E1n1mEJoFkoA4BMpdmk?= =?us-ascii?q?wWZBiKkN4RogWg8gVkzGggbFYMiUxkPjioDFskOJjI/BwIHDgKSBIFsAQE?= IronPort-Data: A9a23:gk4CWqtn2NA1FqtKrIfXR3FqjefnVJZfMUV32f8akzHdYApBsoF/q tZmKWqCbKrbMGajKIgnbIW+9hlVsJ7WydZgHARs/H1jQiISgMeUXt7xwmUckM+xwmwvaGo9s q3yv/GZdJhcokf0/0nrav666yEgiclkf5KkYMbcICd9WAR4fykojBNnioYRj5Vh6TSDK1vlV eja/YuFYzdJ5xYuajhKs/7Z80s01BjPkGpwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 47r0LGj82rFyAwmA9Wjn6yTWhVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0NS+7vw60c+VZk 72hg3AfpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn3bEm51T4E8K0YIw075KLlwR1 78iNhdUTjWg38yG6oC+Y7w57igjBJGD0II3oHpsy3TdSP0hW52GG/uM7t5D1zB2jcdLdRrcT 5NGMnw0M1KaPkAJYwtMYH49tL/Aan3XaDREqUmVpqof6GnIxws327/oWDbQUoPQGJ0LxxfG/ Qoq+UyoPjUTGN6D9gCX81G2mrDJpGClWoYdQejQGvlCxQf7KnYoIBEfS1a+ifWwlEO7X9VRN woS9zZGhaU+6UmiXNThdxK/p3GAs1gXXN84O+4n4gilyafO5QudQG8eQVZpYdoqrsIpBjony lOEgfvtGDpp9raVIVqF/72ZqzKaIyUZLWYeIyQDSGMt59jlvZF2jR/VSNtnOLC6g8ezGjzqx T2O6i8kiN07i8MX26il1U7IjijqpZXTSAMxoALNUQqYAhhRfoWpYcmsrFPc9/sFdNjfRViat 39CkM+bhAwTMayweOW2aL1lNNmUCzytaVUwXXYH80EdygmQ IronPort-HdrOrdr: A9a23:xjw+964zIejEb6fvFAPXwD7XdLJyesId70hD6qm+c20wTiX+ra GTdZUguyMc5wx9ZJhNo7q90ey7MBHhHP1OjrX5Q43DYOCOggLBR72Kr7GSoAEIcBeTygcy79 YET4FOTPD9ElR+i9/3+02bH8ZI+qj/zImYwcrT0HtpSxhncOVb7wl/AhuGCUEefnghOXNALu v62uN34xy9ZH8QcsO3QlMBX+TFupn3saiOW29/O/bigzP+9w9BL9XBYmOl4is= X-Talos-CUID: =?us-ascii?q?9a23=3ASZUi9GquLMn8Qi07NrcshSjmUel9T1Lgk1WTGVG?= =?us-ascii?q?fUEZMa+W7eXWi/Yoxxg=3D=3D?= X-Talos-MUID: 9a23:C/ntxAiWxFYWovrD4R1W/MMpZftM6oisFH83g5QlodXbMxUzZTWZg2Hi X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="725061963" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-8.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:04 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id 9C54A18000483; Thu, 23 Apr 2026 16:29:03 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:04 -0700 Subject: [PATCH net-next v5 03/10] enic: add admin RQ buffer management Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-3-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=3640; i=satishkh@cisco.com; h=from:subject:message-id; bh=4snTvNDTFctwNaanim5qhFqEho3/iG5kKLIInaCFbOg=; b=yIpM3C+ifEf4jNqBxglhghmd68ywH7WbZ/3cHY9S3kXcok2GElz1tAK8au9SvmvazL3k65Zwh eENkwc5Y9MRBtVtRAxYexEcES27kKjVj6RhSktH1hJrEPEErf1Ppg0C X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com The admin receive queue needs pre-posted DMA buffers for incoming mailbox messages from VFs. Each buffer is a kmalloc'd region mapped for DMA (2048 bytes, sufficient for any MBOX message). Add enic_admin_rq_fill() to post buffers at open time, and enic_admin_rq_drain() to unmap and free them at close time. Wire both into the admin channel open/close paths. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/enic_admin.c | 66 ++++++++++++++++++++++++= +++- 1 file changed, 64 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_admin.c b/drivers/net/eth= ernet/cisco/enic/enic_admin.c index afb50aa413f4..67b2a5d52b1d 100644 --- a/drivers/net/ethernet/cisco/enic/enic_admin.c +++ b/drivers/net/ethernet/cisco/enic/enic_admin.c @@ -3,6 +3,7 @@ =20 #include #include +#include =20 #include "vnic_dev.h" #include "vnic_wq.h" @@ -34,10 +35,63 @@ static void enic_admin_wq_buf_clean(struct vnic_wq *wq, } } =20 -/* No-op: admin RQ buffer teardown is handled in enic_admin_channel_close = */ static void enic_admin_rq_buf_clean(struct vnic_rq *rq, struct vnic_rq_buf *buf) { + struct enic *enic =3D vnic_dev_priv(rq->vdev); + + if (!buf->os_buf) + return; + + dma_unmap_single(&enic->pdev->dev, buf->dma_addr, buf->len, + DMA_FROM_DEVICE); + kfree(buf->os_buf); + buf->os_buf =3D NULL; +} + +static int enic_admin_rq_post_one(struct enic *enic) +{ + struct vnic_rq *rq =3D &enic->admin_rq; + struct rq_enet_desc *desc; + dma_addr_t dma_addr; + void *buf; + + buf =3D kmalloc(ENIC_ADMIN_BUF_SIZE, GFP_KERNEL); + if (!buf) + return -ENOMEM; + + dma_addr =3D dma_map_single(&enic->pdev->dev, buf, ENIC_ADMIN_BUF_SIZE, + DMA_FROM_DEVICE); + if (dma_mapping_error(&enic->pdev->dev, dma_addr)) { + kfree(buf); + return -ENOMEM; + } + + desc =3D vnic_rq_next_desc(rq); + rq_enet_desc_enc(desc, (u64)dma_addr | VNIC_PADDR_TARGET, + RQ_ENET_TYPE_ONLY_SOP, ENIC_ADMIN_BUF_SIZE); + vnic_rq_post(rq, buf, 0, dma_addr, ENIC_ADMIN_BUF_SIZE, 0); + + return 0; +} + +static int enic_admin_rq_fill(struct enic *enic) +{ + struct vnic_rq *rq =3D &enic->admin_rq; + int err; + + while (vnic_rq_desc_avail(rq) > 0) { + err =3D enic_admin_rq_post_one(enic); + if (err) + return err; + } + + return 0; +} + +static void enic_admin_rq_drain(struct enic *enic) +{ + vnic_rq_clean(&enic->admin_rq, enic_admin_rq_buf_clean); } =20 static int enic_admin_qp_type_set(struct enic *enic, u32 enable) @@ -149,6 +203,13 @@ int enic_admin_channel_open(struct enic *enic) vnic_wq_enable(&enic->admin_wq); vnic_rq_enable(&enic->admin_rq); =20 + err =3D enic_admin_rq_fill(enic); + if (err) { + netdev_err(enic->netdev, + "Failed to fill admin RQ buffers: %d\n", err); + goto disable_queues; + } + err =3D enic_admin_qp_type_set(enic, 1); if (err) { netdev_err(enic->netdev, @@ -162,6 +223,7 @@ int enic_admin_channel_open(struct enic *enic) enic_admin_qp_type_set(enic, 0); vnic_wq_disable(&enic->admin_wq); vnic_rq_disable(&enic->admin_rq); + enic_admin_rq_drain(enic); enic_admin_free_resources(enic); return err; } @@ -177,7 +239,7 @@ void enic_admin_channel_close(struct enic *enic) vnic_rq_disable(&enic->admin_rq); =20 vnic_wq_clean(&enic->admin_wq, enic_admin_wq_buf_clean); - vnic_rq_clean(&enic->admin_rq, enic_admin_rq_buf_clean); + enic_admin_rq_drain(enic); vnic_cq_clean(&enic->admin_cq[0]); vnic_cq_clean(&enic->admin_cq[1]); vnic_intr_clean(&enic->admin_intr); --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81E7538422A; Thu, 23 Apr 2026 16:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.88 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961816; cv=none; b=CNdarWJK+rHMJo6kZthhV8lwW5BJqveu2QBf/k8QM010NjfGTdZoEQtQnNzCtznsbldaXoa+QZVMaliB6iWIkilOOJPxhddYUrWhehLYywWpAklEqhB/POx/nmRLxXq1wr+aiKfAxTCmOLOyraZzT3EU/DhUBkOw2wGRaAXVER4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961816; c=relaxed/simple; bh=vvcRUOj3OH5qlSDDYgcp3l221uB1lfETMtfgchm89mI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SyneCDWclysowJW1Ub8ysUbPpx7dyD4IA3SHsAM3+IZVXkNEjWWYt6ITJ0VTQit4IpExteah5cBTo4an4loR/rF6He+2+CCxdhY4pPhvYzzlGMvv1Sbph87vv+xjotF9mVnrZKXbH5cvl6ix9np+F/3vBxyncQg8JDwPM6hRMac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=fGBeqcgA; arc=none smtp.client-ip=173.37.142.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="fGBeqcgA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=14275; q=dns/txt; s=iport01; t=1776961813; x=1778171413; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=FQjy6nI2h6BBzLW2eomYScwSGjAFkGt0r4sdMbAZpF0=; b=fGBeqcgAnTzgSrmvAXISOTnoF1Iajv2bM+EbNrZGMZpLPxfAAQ2ekogY fWB/Sz76XE7rvQBVvgwDjECAlyTA3CjuUYb7aBsBvUqh3nNYGBqRVIHuy to98y9pYSPM+M0aQBnW4eAMwMXxwRESl1SqOsCtwyEhO2aTQN++9ux8dC JH2DpDUpVy4g0UHQ/6HZztWAQyZKruJLsVXXbtbOd2g6D2rSSqlk5VmNh fGMxcxwLLwsr04D+cXsjkgaoQ4FnloHN1XETn4gpk3XIRqwP/4aNu3c/S Es0gEWfCidILzfHBTKIeScH3o/U7NTHO47L11w/3yPY1Dei9iOGhBgMRj w==; X-CSE-ConnectionGUID: K8fSNBZmQkqv4kdyl5UXDg== X-CSE-MsgGUID: /Iecx8DPQi+llsgPQss4EA== X-IPAS-Result: =?us-ascii?q?A0AnAAClR+pp/4//Ja1aHQEBAQEJARIBBQUBgXwIAQsBg?= =?us-ascii?q?laBT0NJhFeIHIc3giGRTYxQgX8PAQEBD1EEAQGFBgKNLAImNAkOAQIEAQEBA?= =?us-ascii?q?QMCAwEBAQEBAQEBAQEBCwEBBQEBAQIBBwWBDhOGXIZbAgEDIwRSECUCJgICR?= =?us-ascii?q?hAGARKDAoJ0A7NVen8zgQGEfdlCgWQBCxQBgQouAYVxgmYBgXCEBjuEPycbg?= =?us-ascii?q?UlEgRQBg2iEGoQEgmkEgiJ6FIcUgQCHCgk/gQIcA1ksAVUTDQoLBwVhUjMDI?= =?us-ascii?q?AoLEhIYFQIULw8EFjIdcAwnEiwXNFgbBwWBS4QJbRQxBCGBC4MqgTaBAQMLG?= =?us-ascii?q?A1IESw3Bg4bBD0BbgeKNiAPgTlxAVkaG3pCPAgTHRQZHCmSYxuDY4wngTZrg?= =?us-ascii?q?TWfWYQmgWSgDgEyhASTYjOSUpkGIqMzNAEYN4RogWg8gVkzGggbFTuCZ1MZD?= =?us-ascii?q?44tFhzIciYyPQIHAgcNAwuRaASBeQEB?= IronPort-Data: A9a23:sojHCa4/RBmdgZWirT9CtAxRtPjGchMFZxGqfqrLsTDasY5as4F+v mYXDzuHOqyNZGGhLd1yO9i1oEMC6JKByYRnHFM4rHg1Zn8b8sCt6fZ1gavT04J+CuWZESqLO u1HMoGowPgcFyGa/lH2dOC98RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUw6mJSqYDR7zil5 5Wo+KUzBHf/g2Qqaj5OsPrYwP9SlK2aVA0w7wRWic9j5Dcyp1FNZLoDKKe4KWfPQ4U8NoaSW +bZwbilyXjS9hErB8nNuu6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTaJLwXXxqZwChxLid/ jniWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I0DuKxPRL/tS4E4eHt0WwcBdM2R39 uUGdDMBfxTeutKaz+fuIgVsrpxLwMjDJogTvDRkiDreF/tjGc6FSKTR7tge1zA17ixMNa+BP IxCNnw1MUmGOkEUUrsUIMpWcOOAnXDjciZYq1K9rqss6G+Vxwt0uFToGIWPK4fbFZQJzi50o EqB3mnyEkE2DOWeij6B6X2Uv/TUwQ7SDdd6+LqQs6QCbEeo7mAaFhATfVeyv/S8jkmwR5RZJ lB80icisK075kG3Ztb6WBK8rTiPuRt0c9lNGeQS6wyXzKfQpQGDCQAsRzhNctE598k7WTAny HeNgtXvQzdv2JWNQHiQ8La8tz6+OSEJa2QFYEcsSQoD/smmo4wpiB/LZshsHbTzjdDvHzz0h TeQo0AWgbgPgcMV/7u08EqBgD+2oJXNCAkv6W3qsnmN9Ah1YsuhIoev81WetagGJ4eCRV7Ht 38B8ySD0N0z4Vi2vHTlaI0w8HuBvp5p7BW0bYZTIqQc IronPort-HdrOrdr: A9a23:5bJMqK8JOCE894hNfgRuk+AuI+orL9Y04lQ7vn2ZhyYlFvBw8P rOoB1773HJYVkqNU3I9errBEDEewK/yXcX2+Ys1MmZPDUO0VHAROpfBMnZsl7d8kbFmtK1u5 0QFpRWOZncAUd3iMDi7BL9MdoxqeP3iZyAtKPyw2hgSAdyZ7ol1Qd2DQ6HDlZ7LTM2Y6bRbK DsgfZvln6HZWkdaNi9Cz0uWujOoMCOqbfdCCR2fyLOLGK1/EmVAHmQKWni4isj X-Talos-CUID: 9a23:mKF1EGAvZFlPoL/6Ewo3+nUyMPIgS37E0ivTL168VFtZZLLAHA== X-Talos-MUID: 9a23:JMVCKwXKnbib2pbq/HjNiTpyZOtQ2qXtDEQWnq0/oNLYGAUlbg== X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="729398948" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-1.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:05 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id 55C7C1800039B; Thu, 23 Apr 2026 16:29:04 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:05 -0700 Subject: [PATCH net-next v5 04/10] enic: add admin CQ service with MSI-X interrupt and NAPI polling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-4-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=14723; i=satishkh@cisco.com; h=from:subject:message-id; bh=vvcRUOj3OH5qlSDDYgcp3l221uB1lfETMtfgchm89mI=; b=6DDBRQKr09h89EzGciq/inNQCrY95oY+jzPuNJSfr2/NnUBxcUTnMqKEJCljEjCb8e9wI/Ozb uX0uqns7xXACLZQV6gPI/wPFp7W1NuaffnDU4jCtUueU/ty/soN5ciA X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com Add completion queue service for the admin channel WQ and RQ, driven by an MSI-X interrupt and NAPI polling. The receive pipeline is: MSI-X ISR -> NAPI poll -> RQ CQ service -> message enqueue -> workqueue handler -> admin_rq_handler callback. NAPI drains the RQ CQ in softirq context, copying each received buffer into an enic_admin_msg and appending it to a spinlock-protected list. A system workqueue handler then processes each message in process context where sleeping (mutex, GFP_KERNEL allocations) is safe. The WQ CQ service counts transmit completions and is called from the synchronous MBOX send path. Interrupt generation is disabled on the WQ CQ (admin_cq[0]) because it is polled synchronously; only the RQ CQ (admin_cq[1]) is interrupt-driven via NAPI. RQ buffer allocation uses GFP_ATOMIC since enic_admin_rq_fill() is called from NAPI context during CQ processing. Log a rate-limited warning when admin RQ buffer refill fails in NAPI context. The admin channel open/close paths set up and tear down the MSI-X interrupt, NAPI instance, and workqueue. CQ init enables interrupt delivery on the RQ CQ and sets the interrupt offset so completions trigger the admin ISR. The admin interrupt is allocated from the general INTR_CTRL pool (index =3D=3D intr_count) rather than the RES_TYPE_SRIOV_INTR slot, which firmware reserves for its own SR-IOV signaling. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/enic.h | 8 + drivers/net/ethernet/cisco/enic/enic_admin.c | 300 +++++++++++++++++++++++= ++-- drivers/net/ethernet/cisco/enic/enic_admin.h | 12 ++ 3 files changed, 298 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic.h b/drivers/net/ethernet/= cisco/enic/enic.h index 08472420f3a1..1c09da3c0b1a 100644 --- a/drivers/net/ethernet/cisco/enic/enic.h +++ b/drivers/net/ethernet/cisco/enic/enic.h @@ -296,6 +296,14 @@ struct enic { struct vnic_rq admin_rq; struct vnic_cq admin_cq[2]; struct vnic_intr admin_intr; + struct napi_struct admin_napi; + unsigned int admin_intr_index; + struct work_struct admin_msg_work; + spinlock_t admin_msg_lock; /* protects admin_msg_list */ + struct list_head admin_msg_list; + u64 admin_msg_drop_cnt; + void (*admin_rq_handler)(struct enic *enic, void *buf, + unsigned int len); }; =20 static inline struct net_device *vnic_get_netdev(struct vnic_dev *vdev) diff --git a/drivers/net/ethernet/cisco/enic/enic_admin.c b/drivers/net/eth= ernet/cisco/enic/enic_admin.c index 67b2a5d52b1d..cf1528c85506 100644 --- a/drivers/net/ethernet/cisco/enic/enic_admin.c +++ b/drivers/net/ethernet/cisco/enic/enic_admin.c @@ -4,6 +4,7 @@ #include #include #include +#include =20 #include "vnic_dev.h" #include "vnic_wq.h" @@ -15,6 +16,7 @@ #include "enic.h" #include "enic_admin.h" #include "cq_desc.h" +#include "cq_enet_desc.h" #include "wq_enet_desc.h" #include "rq_enet_desc.h" =20 @@ -49,14 +51,14 @@ static void enic_admin_rq_buf_clean(struct vnic_rq *rq, buf->os_buf =3D NULL; } =20 -static int enic_admin_rq_post_one(struct enic *enic) +static int enic_admin_rq_post_one(struct enic *enic, gfp_t gfp) { struct vnic_rq *rq =3D &enic->admin_rq; struct rq_enet_desc *desc; dma_addr_t dma_addr; void *buf; =20 - buf =3D kmalloc(ENIC_ADMIN_BUF_SIZE, GFP_KERNEL); + buf =3D kmalloc(ENIC_ADMIN_BUF_SIZE, gfp); if (!buf) return -ENOMEM; =20 @@ -75,13 +77,13 @@ static int enic_admin_rq_post_one(struct enic *enic) return 0; } =20 -static int enic_admin_rq_fill(struct enic *enic) +static int enic_admin_rq_fill(struct enic *enic, gfp_t gfp) { struct vnic_rq *rq =3D &enic->admin_rq; int err; =20 while (vnic_rq_desc_avail(rq) > 0) { - err =3D enic_admin_rq_post_one(enic); + err =3D enic_admin_rq_post_one(enic, gfp); if (err) return err; } @@ -94,6 +96,208 @@ static void enic_admin_rq_drain(struct enic *enic) vnic_rq_clean(&enic->admin_rq, enic_admin_rq_buf_clean); } =20 +static unsigned int enic_admin_cq_color(void *cq_desc, unsigned int desc_s= ize) +{ + u8 type_color =3D *((u8 *)cq_desc + desc_size - 1); + + return (type_color >> CQ_DESC_COLOR_SHIFT) & CQ_DESC_COLOR_MASK; +} + +unsigned int enic_admin_wq_cq_service(struct enic *enic) +{ + struct vnic_cq *cq =3D &enic->admin_cq[0]; + unsigned int work =3D 0; + void *desc; + + desc =3D vnic_cq_to_clean(cq); + while (enic_admin_cq_color(desc, cq->ring.desc_size) !=3D + cq->last_color) { + /* Ensure color bit is read before descriptor fields */ + rmb(); + vnic_cq_inc_to_clean(cq); + work++; + desc =3D vnic_cq_to_clean(cq); + } + + return work; +} + +static void enic_admin_msg_enqueue(struct enic *enic, void *buf, + unsigned int len) +{ + struct enic_admin_msg *msg; + + msg =3D kmalloc(struct_size(msg, data, len), GFP_ATOMIC); + if (!msg) { + enic->admin_msg_drop_cnt++; + if (net_ratelimit()) + netdev_warn(enic->netdev, + "admin msg enqueue drop (len=3D%u drops=3D%llu)\n", + len, enic->admin_msg_drop_cnt); + return; + } + + msg->len =3D len; + memcpy(msg->data, buf, len); + + spin_lock(&enic->admin_msg_lock); + list_add_tail(&msg->list, &enic->admin_msg_list); + spin_unlock(&enic->admin_msg_lock); +} + +unsigned int enic_admin_rq_cq_service(struct enic *enic, unsigned int budg= et) +{ + struct vnic_cq *cq =3D &enic->admin_cq[1]; + struct vnic_rq *rq =3D &enic->admin_rq; + struct vnic_rq_buf *buf; + unsigned int work =3D 0; + void *desc; + + desc =3D vnic_cq_to_clean(cq); + while (work < budget && + enic_admin_cq_color(desc, cq->ring.desc_size) !=3D + cq->last_color) { + /* Ensure CQ descriptor fields are read after + * the color/valid check. + */ + rmb(); + buf =3D rq->to_clean; + + dma_sync_single_for_cpu(&enic->pdev->dev, + buf->dma_addr, buf->len, + DMA_FROM_DEVICE); + + enic_admin_msg_enqueue(enic, buf->os_buf, buf->len); + + enic_admin_rq_buf_clean(rq, rq->to_clean); + rq->to_clean =3D rq->to_clean->next; + rq->ring.desc_avail++; + + vnic_cq_inc_to_clean(cq); + work++; + desc =3D vnic_cq_to_clean(cq); + } + + if (enic_admin_rq_fill(enic, GFP_ATOMIC) && net_ratelimit()) + netdev_warn(enic->netdev, "admin RQ refill failed\n"); + + return work; +} + +static irqreturn_t enic_admin_isr_msix(int irq, void *data) +{ + struct napi_struct *napi =3D data; + + napi_schedule_irqoff(napi); + + return IRQ_HANDLED; +} + +static void enic_admin_msg_work_handler(struct work_struct *work) +{ + struct enic *enic =3D container_of(work, struct enic, admin_msg_work); + struct enic_admin_msg *msg, *tmp; + LIST_HEAD(local_list); + + spin_lock_bh(&enic->admin_msg_lock); + list_splice_init(&enic->admin_msg_list, &local_list); + spin_unlock_bh(&enic->admin_msg_lock); + + list_for_each_entry_safe(msg, tmp, &local_list, list) { + if (enic->admin_rq_handler) + enic->admin_rq_handler(enic, msg->data, msg->len); + list_del(&msg->list); + kfree(msg); + } +} + +static int enic_admin_napi_poll(struct napi_struct *napi, int budget) +{ + struct enic *enic =3D container_of(napi, struct enic, admin_napi); + unsigned int credits; + unsigned int rq_work; + + credits =3D vnic_intr_credits(&enic->admin_intr); + + rq_work =3D enic_admin_rq_cq_service(enic, budget); + + if (rq_work > 0) + schedule_work(&enic->admin_msg_work); + + if (rq_work < budget && napi_complete_done(napi, rq_work)) { + if (credits) + vnic_intr_return_credits(&enic->admin_intr, credits, + 1 /* unmask */, 0); + } else { + if (credits) + vnic_intr_return_credits(&enic->admin_intr, credits, + 0 /* don't unmask */, 0); + } + + return rq_work; +} + +static int enic_admin_setup_intr(struct enic *enic) +{ + unsigned int intr_index =3D enic->intr_count; + int err; + + if (vnic_dev_get_intr_mode(enic->vdev) !=3D VNIC_DEV_INTR_MODE_MSIX || + intr_index >=3D enic->intr_avail) + return -ENODEV; + + err =3D vnic_intr_alloc(enic->vdev, &enic->admin_intr, intr_index); + if (err) { + netdev_warn(enic->netdev, + "Failed to alloc admin intr at index %u: %d\n", + intr_index, err); + return err; + } + + enic->admin_intr_index =3D intr_index; + + snprintf(enic->msix[intr_index].devname, + sizeof(enic->msix[intr_index].devname), + "%s-admin", enic->netdev->name); + enic->msix[intr_index].isr =3D enic_admin_isr_msix; + enic->msix[intr_index].devid =3D &enic->admin_napi; + + err =3D request_irq(enic->msix_entry[intr_index].vector, + enic->msix[intr_index].isr, 0, + enic->msix[intr_index].devname, + enic->msix[intr_index].devid); + if (err) { + netdev_warn(enic->netdev, + "Failed to request admin MSI-X irq: %d\n", err); + vnic_intr_free(&enic->admin_intr); + return err; + } + + enic->msix[intr_index].requested =3D 1; + + netif_napi_add(enic->netdev, &enic->admin_napi, + enic_admin_napi_poll); + napi_enable(&enic->admin_napi); + + netdev_dbg(enic->netdev, + "admin channel using MSI-X interrupt (index %u)\n", + intr_index); + + return 0; +} + +static void enic_admin_teardown_intr(struct enic *enic) +{ + unsigned int intr_index =3D enic->admin_intr_index; + + napi_disable(&enic->admin_napi); + netif_napi_del(&enic->admin_napi); + + free_irq(enic->msix_entry[intr_index].vector, + enic->msix[intr_index].devid); + enic->msix[intr_index].requested =3D 0; +} + static int enic_admin_qp_type_set(struct enic *enic, u32 enable) { u64 a0 =3D QP_TYPE_ADMIN, a1 =3D enable; @@ -139,23 +343,8 @@ static int enic_admin_alloc_resources(struct enic *eni= c) if (err) goto free_cq0; =20 - /* PFs have dedicated SRIOV_INTR resources for admin channel. - * VFs lack SRIOV_INTR; use a regular INTR_CTRL slot instead. - */ - if (vnic_dev_get_res_count(enic->vdev, RES_TYPE_SRIOV_INTR) >=3D 1) - err =3D vnic_intr_alloc_with_type(enic->vdev, - &enic->admin_intr, 0, - RES_TYPE_SRIOV_INTR); - else - err =3D vnic_intr_alloc(enic->vdev, &enic->admin_intr, - enic->intr_count); - if (err) - goto free_cq1; - return 0; =20 -free_cq1: - vnic_cq_free(&enic->admin_cq[1]); free_cq0: vnic_cq_free(&enic->admin_cq[0]); free_rq: @@ -176,13 +365,47 @@ static void enic_admin_free_resources(struct enic *en= ic) =20 static void enic_admin_init_resources(struct enic *enic) { + unsigned int intr_offset =3D enic->admin_intr_index; + vnic_wq_init(&enic->admin_wq, 0, 0, 0); vnic_rq_init(&enic->admin_rq, 1, 0, 0); - vnic_cq_init(&enic->admin_cq[0], 0, 1, 0, 0, 1, 0, 1, 0, 0, 0); - vnic_cq_init(&enic->admin_cq[1], 0, 1, 0, 0, 1, 0, 1, 0, 0, 0); + vnic_cq_init(&enic->admin_cq[0], + 0 /* flow_control_enable */, + 1 /* color_enable */, + 0 /* cq_head */, + 0 /* cq_tail */, + 1 /* cq_tail_color */, + 1 /* interrupt_enable */, + 1 /* cq_entry_enable */, + 0 /* cq_message_enable */, + intr_offset, + 0 /* cq_message_addr */); + vnic_cq_init(&enic->admin_cq[1], + 0 /* flow_control_enable */, + 1 /* color_enable */, + 0 /* cq_head */, + 0 /* cq_tail */, + 1 /* cq_tail_color */, + 1 /* interrupt_enable */, + 1 /* cq_entry_enable */, + 0 /* cq_message_enable */, + intr_offset, + 0 /* cq_message_addr */); vnic_intr_init(&enic->admin_intr, 0, 0, 1); } =20 +static void enic_admin_msg_drain(struct enic *enic) +{ + struct enic_admin_msg *msg, *tmp; + + spin_lock_bh(&enic->admin_msg_lock); + list_for_each_entry_safe(msg, tmp, &enic->admin_msg_list, list) { + list_del(&msg->list); + kfree(msg); + } + spin_unlock_bh(&enic->admin_msg_lock); +} + int enic_admin_channel_open(struct enic *enic) { int err; @@ -198,12 +421,24 @@ int enic_admin_channel_open(struct enic *enic) return err; } =20 + spin_lock_init(&enic->admin_msg_lock); + INIT_LIST_HEAD(&enic->admin_msg_list); + INIT_WORK(&enic->admin_msg_work, enic_admin_msg_work_handler); + + err =3D enic_admin_setup_intr(enic); + if (err) { + netdev_err(enic->netdev, + "Admin channel requires MSI-X, SR-IOV unavailable: %d\n", + err); + goto free_resources; + } + enic_admin_init_resources(enic); =20 vnic_wq_enable(&enic->admin_wq); vnic_rq_enable(&enic->admin_rq); =20 - err =3D enic_admin_rq_fill(enic); + err =3D enic_admin_rq_fill(enic, GFP_KERNEL); if (err) { netdev_err(enic->netdev, "Failed to fill admin RQ buffers: %d\n", err); @@ -217,13 +452,27 @@ int enic_admin_channel_open(struct enic *enic) goto disable_queues; } =20 + vnic_intr_unmask(&enic->admin_intr); + + netdev_dbg(enic->netdev, + "admin channel open: intr=3D%u wq_avail=3D%u rq_avail=3D%u cq0_color= =3D%u cq1_color=3D%u\n", + enic->admin_intr_index, + vnic_wq_desc_avail(&enic->admin_wq), + vnic_rq_desc_avail(&enic->admin_rq), + enic->admin_cq[0].last_color, + enic->admin_cq[1].last_color); + return 0; =20 disable_queues: + enic_admin_teardown_intr(enic); enic_admin_qp_type_set(enic, 0); vnic_wq_disable(&enic->admin_wq); vnic_rq_disable(&enic->admin_rq); + cancel_work_sync(&enic->admin_msg_work); + enic_admin_msg_drain(enic); enic_admin_rq_drain(enic); +free_resources: enic_admin_free_resources(enic); return err; } @@ -233,6 +482,13 @@ void enic_admin_channel_close(struct enic *enic) if (!enic->has_admin_channel) return; =20 + netdev_dbg(enic->netdev, "admin channel close\n"); + + vnic_intr_mask(&enic->admin_intr); + enic_admin_teardown_intr(enic); + cancel_work_sync(&enic->admin_msg_work); + enic_admin_msg_drain(enic); + enic_admin_qp_type_set(enic, 0); =20 vnic_wq_disable(&enic->admin_wq); diff --git a/drivers/net/ethernet/cisco/enic/enic_admin.h b/drivers/net/eth= ernet/cisco/enic/enic_admin.h index 569aadeb9312..73cdd3dac7ec 100644 --- a/drivers/net/ethernet/cisco/enic/enic_admin.h +++ b/drivers/net/ethernet/cisco/enic/enic_admin.h @@ -9,7 +9,19 @@ =20 struct enic; =20 +/* Wrapper for received admin messages queued for deferred processing. + * NAPI enqueues these; a workqueue handler processes them in process cont= ext + * where sleeping (mutex, GFP_KERNEL) is safe. + */ +struct enic_admin_msg { + struct list_head list; + unsigned int len; + u8 data[]; +}; + int enic_admin_channel_open(struct enic *enic); void enic_admin_channel_close(struct enic *enic); +unsigned int enic_admin_wq_cq_service(struct enic *enic); +unsigned int enic_admin_rq_cq_service(struct enic *enic, unsigned int budg= et); =20 #endif /* _ENIC_ADMIN_H_ */ --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 146B435F5E0; Thu, 23 Apr 2026 16:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.90 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961815; cv=none; b=dzk+vjMQK7LqSMEn6PjdWBPqShYNDCVRsStTY+XrpjG8rk7Bx685NrVOGzfgjo1ZHQZ1khPSjFgEV+Nsdx/wHa620782eby8rYxfGt1H9Depha4RWpiQqWtUvveP42kYfAtw4Cu99nuvGLU97xYgcyzm36XotbidcSgh9rjo8GA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961815; c=relaxed/simple; bh=DJOEZz0LgusiJsaMcuyJ/mo5kxauoqkYFLtqBtwJznQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SFaYynK4hc4dhJ5oRA0/fvRjcpLCYz5cVtFtBg8sCF81xFfaixyvQDhoYtrtQzjsMVCUu7hIA2ZFgxTU3MP9hg0G90PuGmtRLShpVaqWNML9KkSLThnv0P+/q9W4fzkrDwMczSBi2yOY2My216ACtr4W3fm3bg+jgMk6AT1lgtI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=ALINaMRe; arc=none smtp.client-ip=173.37.142.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="ALINaMRe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=3222; q=dns/txt; s=iport01; t=1776961814; x=1778171414; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=Ismjn8aCzPjNAuW3z5gQmVHzab5Wc6BkN3bhmJ9vQgA=; b=ALINaMRex5NHQqTNhJOlJ52dI7y313H/0/GUbqw7iaYKWqGBoJvPPu35 Z31PdUYXQ8dlt6L/CLVGzBUM6+NmwyRVQXgFHx1V8NhrVO0cbmMj3V1TE EbJW/GSXH6f07AscUjd2ti1eYdF0+01VWGDXpWzMcd2kL67tOijwVQw2V 5AWEJdCG13tyVQojCkgMDHfevrIw92oYPNZvuJGdQv73psa5nA+eD1KrH IeNE2N/Wv0XVTxHBeCpGLQzBomGwAp52RBaJ3ptWCYDZAY3wGyXVulRDa RyVhZFzmy96J4Q4mTxpE/kExzLUvt9owdiOHd49eIfTOok0NsWj/MWshZ g==; X-CSE-ConnectionGUID: Sp0WM8DsR0ibt25vhWyBpw== X-CSE-MsgGUID: 4JFg5GW1S6aYTrnZ7q31sg== X-IPAS-Result: =?us-ascii?q?A0BlAwCSPupp/4//Ja1aHgEBCxIMgWsQDwuEIkNJhFePU?= =?us-ascii?q?4IhkU2MUBSBaw8BAQEPUQQBAYUGAo0sAiY0CQ4BAgQBAQEBAwIDAQEBAQEBA?= =?us-ascii?q?QEBAQEBCgEBBQEBAQIBBwWBDhOGXIZbAgEDI0QSECUCJgICRhAGARKDAoJ0A?= =?us-ascii?q?7A7eoEygQGEfbMkgWULFAGBCi6FcoJmAYFwhAY7hD8nG4FJRIEUAYNohAUBG?= =?us-ascii?q?YN/gmkEgxwUjx0JP4ECHANZLAFVEw0KCwcFYVIzAyAKCxISGBUCFBwTDwQWM?= =?us-ascii?q?h1wDCcSLBc0WBsHBYFLhAltFDEEIYELgyqBNnsDCxgNSBEsNwYOGwQ9AW4Hi?= =?us-ascii?q?jQgD4E5cYEOfDVjGpdWjV1roQ6EJoFkoA4BMpdmkwWZBiKjG0MJUIRogWg8g?= =?us-ascii?q?VkzGggbFYMiUxkP2GImMj0CBwIHDQMLkXmBbAEB?= IronPort-Data: A9a23:0ofkAanRqJuwLSeXjvJM0Qvo5gy2J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdCDuFOfeLYWegKtt3a9m2oUkGupCBnIJhSQs/ri8yRVtH+JHPbTi7wugcHM8zwunrFh8PA xA2M4GYRCwMZiaC4Errav69/ScUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii+aEu/Dha++2k Y20+Za31GONgWYubDpIsfnb9HuDgdyr0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36YWBivkFrt52K2XCukMCdPpETb5LwYW8P49mAcksYJ N9l7fRcQi9xVkHAdXh0vxRwS0lD0aN6FLDvGmDnjunD41b8K3rm368zEkEJLKcA5bMiaY1O3 aRwxDEldBuPgaeyhbm8UOQp3pplJ8jwN4RZsXZlpd3bJa95GtaYHOOQuIIehWtr7ixNNa62i 84xcjNzbQ/AYB1nMVYMA5V4l+Ct7pX6W2IE8QvO+vpmvQA/yiQt8pbibfXqI+fUTPRphECq+ Xudpn/2V0Ry2Nu3jGDtHmiXruPGgy7+cI4bCrC98vlknBuVy3B7IBAaSF6ys/SlokG5XN1bJ gof/S9Ghasv/kWDTdTnWRC85nmesXY0UtxcCeAlqweA1qbZ/S6dG24CCDVBAPQ+vcU7Qz0Cz FKFn9r1QzdotdW9TXOb66fRrj6oPyURBXENaDVCTgYf5dTn5oYpgXrnSNt/HKOrpsP6FCu2w D2QqiU6wbIJgqY2O76T51vLhXeo45POVANwvluRVWO+5QQ/b4mgD2C11WXmAT97BN7xZjG8U LIswqByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:NcbXZqNH8wvgcMBcTjejsMiBIKoaSvp037Dk7TEUdfUzSK2lfq GV8sjzuiWYtN98YhsdcJW7Scu9qBDnmqKdn7NwAV7KZmCP01dAbrsSjrcKqAeNJ8SRzJ856Y 5QN4VzF9H0C0F3loLZ7BnQKadY/PC3tI2lmuvayW5gVkVRa69m5xpkEQrzKDwReOA/P+tfKL OsouxaujGnZXMbKu6/BnUDQqz/guejruOfXfbDbCRXkjVnSliTmcXHLyQ= X-Talos-CUID: 9a23:/5USQ25+qXzCsNJ0Sdssz1ZMJeV1XmbnlHbaPxXlF2ZWWZeNVgrF X-Talos-MUID: 9a23:VLz/Kwg36pODc4JTibHMfsMpaOVG7PmBNxk2z5w3h9OCB3NpYG6Gg2Hi X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="741137896" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-3.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:05 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id 12C4F180003A3; Thu, 23 Apr 2026 16:29:05 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:06 -0700 Subject: [PATCH net-next v5 05/10] enic: define MBOX message types and header structures Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-5-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=3237; i=satishkh@cisco.com; h=from:subject:message-id; bh=DJOEZz0LgusiJsaMcuyJ/mo5kxauoqkYFLtqBtwJznQ=; b=LH19yqNKUjfWP4c7hGUeeYRh4z9YSD1ooJfuioS+NgNR/OCyit2Ibohn7cf/Aq4uN4CYob0BV blM+JC5eHLUB/XTgKuyX2/jj94gRn187YDsepYqPiCkwrKq6Lfajq0L X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com Define the mailbox protocol structures for PF-VF communication: message header, generic reply, and per-message-type payloads for capability negotiation, VF registration/unregistration, and link state notification/acknowledgment. Include linux/types.h and linux/bits.h for __le16/__le32/__le64 and BIT() used in the header. Message types use an even=3Drequest / odd=3Dreply convention. The header carries source and destination VNIC IDs, a monotonically increasing message number, and the total message length. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/enic_mbox.h | 83 +++++++++++++++++++++++++= ++++ 1 file changed, 83 insertions(+) diff --git a/drivers/net/ethernet/cisco/enic/enic_mbox.h b/drivers/net/ethe= rnet/cisco/enic/enic_mbox.h new file mode 100644 index 000000000000..a52f1d25cb21 --- /dev/null +++ b/drivers/net/ethernet/cisco/enic/enic_mbox.h @@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* Copyright 2025 Cisco Systems, Inc. All rights reserved. */ + +#ifndef _ENIC_MBOX_H_ +#define _ENIC_MBOX_H_ + +#include +#include + +/* + * Mailbox protocol for PF-VF communication over the admin channel. + * + * Even numbers are requests, odd numbers are replies/acks. + * The prefix indicates the initiator: VF_ =3D VF-initiated, PF_ =3D PF-in= itiated. + */ +enum enic_mbox_msg_type { + ENIC_MBOX_VF_CAPABILITY_REQUEST =3D 0, + ENIC_MBOX_VF_CAPABILITY_REPLY =3D 1, + ENIC_MBOX_VF_REGISTER_REQUEST =3D 2, + ENIC_MBOX_VF_REGISTER_REPLY =3D 3, + ENIC_MBOX_VF_UNREGISTER_REQUEST =3D 4, + ENIC_MBOX_VF_UNREGISTER_REPLY =3D 5, + ENIC_MBOX_PF_LINK_STATE_NOTIF =3D 6, + ENIC_MBOX_PF_LINK_STATE_ACK =3D 7, + ENIC_MBOX_MAX +}; + +struct enic_mbox_hdr { + __le16 src_vnic_id; + __le16 dst_vnic_id; + u8 msg_type; + u8 flags; + __le16 msg_len; + __le64 msg_num; +}; + +struct enic_mbox_generic_reply { + __le16 ret_major; + __le16 ret_minor; +}; + +#define ENIC_MBOX_ERR_GENERIC BIT(0) +#define ENIC_MBOX_ERR_VF_NOT_REGISTERED BIT(1) +#define ENIC_MBOX_ERR_MSG_NOT_SUPPORTED BIT(2) + +/* ENIC_MBOX_VF_CAPABILITY_REQUEST / _REPLY */ +#define ENIC_MBOX_CAP_VERSION_0 0 +#define ENIC_MBOX_CAP_VERSION_1 1 + +struct enic_mbox_vf_capability_msg { + __le32 version; + __le32 reserved[32]; +}; + +/* The embedded enic_mbox_generic_reply has 2-byte alignment, but the + * __le32 members give this struct 4-byte natural alignment. Receive + * buffers come from kmalloc (>=3D 8-byte aligned), so there is no + * misaligned access risk when casting from the receive buffer. + */ +struct enic_mbox_vf_capability_reply_msg { + struct enic_mbox_generic_reply reply; + __le32 version; + __le32 reserved[32]; +}; + +/* ENIC_MBOX_VF_REGISTER / _UNREGISTER */ +struct enic_mbox_vf_register_reply_msg { + struct enic_mbox_generic_reply reply; +}; + +/* ENIC_MBOX_PF_LINK_STATE_NOTIF / _ACK */ +#define ENIC_MBOX_LINK_STATE_DISABLE 0 +#define ENIC_MBOX_LINK_STATE_ENABLE 1 + +struct enic_mbox_pf_link_state_notif_msg { + __le32 link_state; +}; + +struct enic_mbox_pf_link_state_ack_msg { + struct enic_mbox_generic_reply ack; +}; + +#endif /* _ENIC_MBOX_H_ */ --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CB6C38236C; Thu, 23 Apr 2026 16:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961815; cv=none; b=ifZclVBxEjUE0JcxUGSu5uHHdfDfNMJ27U53bxNnaRSGuPXUxKExubj3re1r+Dp7KqMUuUaIk6q7k+GuTvvsdM66YVXp2QhZS/RGMznVwGtvKHvzVK85SzzIdoj5kU6JeVNy3y/4y7B6tj90+eRjSOWs3olBF5YifDX9T5nr03c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961815; c=relaxed/simple; bh=HlsW+rOR6r7jE0j2X0/hlwQbrLlmvK2iJsMrubN+vtY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iyyMcEauov9pBxoAOSpZCShNDn8y9l5Cjg965mXdHt7y/9PnKW8xUdbSrGZvpqEgQj8yN6IQW6ivqWOa4GSKz8zGVoUyLrj81CHb6NPTnb0+WZ0GgxbzBGuHMUeWgMhE108UpOTHm/vOPmNndqw9yIqLXB5jZEqmF6Mt6Apf4S0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=JEabg0RC; arc=none smtp.client-ip=173.37.142.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="JEabg0RC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=9125; q=dns/txt; s=iport01; t=1776961813; x=1778171413; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=7VaO9v3qrXxObjoPeIq02bU+iGQzzZhl+AN0HAV8KI4=; b=JEabg0RCluvjMlory01ZDTc7lBvChwqObf6rYh0AoNS2S7fY1TTO/Ybv 9zFCZ4W2N9vfCQMm6DYG66bP0j/5mqbL3PUYV9EgBfRqoswnJJMy85UL4 clH7RupEunb9a/YRDN1Y7XWt7Y+uJzln0LDV2IY9SHHpe9MGLDPwTNipO ARh9pywXJkZlOpoZtfVGQsg/Ydeti5xqu3M2uzgPDeQBV1MPSyFTiBmUd yGGytdO6SjtJ0LeCL33tXbGESvycrKXLTyyX7UOpQ0jt4qrTJcZIIdUgp J8jjJacv5U/sftqslCXni+hFcxjS2ruTaVQ8ocOt+YNPH/upcrnLeVYrk g==; X-CSE-ConnectionGUID: Hd6AquzNTcaDCruSnsNhNw== X-CSE-MsgGUID: Osy37k5URZSag9E3UbOuWw== X-IPAS-Result: =?us-ascii?q?A0BIAgAkSOpp/4//Ja1QCh4BAQsSDIIFC4JXgU9DSYRXj?= =?us-ascii?q?1OCIZ4dFIFrDwEBAQ9RBAEBhQYCjSwCJjQJDgECBAEBAQEDAgMBAQEBAQEBA?= =?us-ascii?q?QEBAQsBAQUBAQECAQcFgQ4ThlyGWwIBAyMEUhAlAiYCAkUBEAYBEoMCgnQDs?= =?us-ascii?q?1F6fzOBAYR92UKBZAELFAGBCi6FcoJmAYFwhAY7hD8nG4FJRIEUAYNohAUBE?= =?us-ascii?q?AmDf4JpBIMcFIFeIINSiU4JP4ECHANZLAFVEw0KCwcFYVIzAyAKCxISGBUCF?= =?us-ascii?q?BwTDwQWMh1wDCcSLBc0WBsHBYFLhAltFDEEIYELgyqBNoEBAwsYDUgRLDcGD?= =?us-ascii?q?hsEPQFuB4o2IA+BOWoHAYENAROBKVcxGSyWeo1da6EOhCaBZIxakzQBMpdmk?= =?us-ascii?q?wWZBiKjSW6EaIFoPIFZMxoIGxWDIlMZD44tFhzIciYyPQEBBwIHDQMLgWiQA?= =?us-ascii?q?g8XB4FOAQE?= IronPort-Data: A9a23:ayqc6q2xG9eHj/4WHvbD5RNwkn2cJEfYwER7XKvMYLTBsI5bpzFTz jceXj3SPvuIZDP3fY9zb4jl/UhSvJaEz9c2TwM93Hw8FHgiRegpqji6wuYcGwvIc6UvmWo+t 512huHodZ5yFjmH4E/xbtANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq8wIDqtYAbeORXUXX4 rsen+WFYAX7g2IuaTpPg06+gEoHUMra6WtwUmMWPZinjHeG/1EJAZQWI72GLneQauF8Au6gS u/f+6qy92Xf8g1FIovNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ajs7XAMEhhXJ/0F1lqTzeJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXcG7lyX7n3XQL/pGLE1oFJQF6MBLCmhi3 uYFEzYWSBClmLfjqF67YrEEasULNsLnOsYb/3pn1zycVahgSpHYSKKM7thdtNsyrpkRRrCFO IxDNGcpNUibC/FMEg9/5JYWh+60h2L/cD1wo1OOrq1x6G/WpOB0+Oe3bYKLI43aFa25mG6/v XOdoGekPysoD9WQmBfez3iLm9DQyHaTtIU6UefQGuRRqFGa2GEWIBEfS1a+pf63lgi4Vs43A 0EY5y8nv6Uu3EOsSdb5Uluzp3vslh0BUdN4EOAg7gyJjK3O7G6xD24IVDNeK9orqMM7WxQuy 1mP2djpbRR3ubeYT3O17LqYrTqufyMSKAcqYS4CUBtA4NT5pow3pgzAQ8wlE6OviNDxXzbqz FiiqiUii7gNpdAE2r/9/l3dhT+o4J/TQWYICh7/RGmp6EZ9IYWifYHtsQad5vdbJ4HfRV6E1 JQZp/WjACk1JcnlvESwrC8lRtlFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:p0KZ36x3kFBZtKufRV15KrPw2r1zdoMgy1knxilNoNJuA6ilfq eV/cjztCWbtN9/YhwdcLy7UpVoBEmsl6KdgrN/AV7dZmnbUQKTRekI0WKh+UyCJ8SUzIJgPM lbAs1DIey1IFRkgcP9+QWiV/Qt0LC8gdmVrNab4ntzQQRtcq16qz14BAGSD1FsSGB9dPwE/e Knl616jgvlX2gLZcKmAXRAde3Cq9rX0K/CW3c9dmYaAM3kt0LT1FY8eCLopSsjbw== X-Talos-CUID: 9a23:18vxuGwP5uPIg4vFe34QBgU0Fp4Ma2DP6kvbKmOTE3tSTqazSXmPrfY= X-Talos-MUID: 9a23:gqptwwUuC4/iomzq/Bj3lWo9N5pV2ZaVAU9cvM47se6ZCjMlbg== X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="725061988" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-8.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:06 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id C48B31800039B; Thu, 23 Apr 2026 16:29:05 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:07 -0700 Subject: [PATCH net-next v5 06/10] enic: add MBOX core send and receive for admin channel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-6-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=9389; i=satishkh@cisco.com; h=from:subject:message-id; bh=HlsW+rOR6r7jE0j2X0/hlwQbrLlmvK2iJsMrubN+vtY=; b=OB2K+75RVnWh8RQ7AT2ZA6njug3J8M2uI8EZ1ZNY18hEeuReCIjRwh+nyoKt19xaKEg7T1wDh u11EtUtQvODDpn7LCDAvpmr10+Tiqv6yQ0sQiplrbx21/V+T9TKHdNB X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com Implement the mailbox protocol engine used for PF-VF communication over the admin channel. The send path (enic_mbox_send_msg) builds a message with a common header, DMA-maps it, posts a single WQ descriptor with the destination vnic ID encoded in the VLAN tag field, and polls the WQ CQ for completion. The receive path (enic_mbox_recv_handler) is installed as the admin RQ callback and validates incoming message headers. PF/VF-specific dispatch will be added in subsequent commits. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/Makefile | 2 +- drivers/net/ethernet/cisco/enic/enic.h | 6 + drivers/net/ethernet/cisco/enic/enic_admin.c | 23 +++- drivers/net/ethernet/cisco/enic/enic_mbox.c | 162 +++++++++++++++++++++++= ++++ drivers/net/ethernet/cisco/enic/enic_mbox.h | 8 ++ 5 files changed, 199 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/Makefile b/drivers/net/etherne= t/cisco/enic/Makefile index 7ae72fefc99a..e38aaf34c148 100644 --- a/drivers/net/ethernet/cisco/enic/Makefile +++ b/drivers/net/ethernet/cisco/enic/Makefile @@ -4,5 +4,5 @@ obj-$(CONFIG_ENIC) :=3D enic.o enic-y :=3D enic_main.o vnic_cq.o vnic_intr.o vnic_wq.o \ enic_res.o enic_dev.o enic_pp.o vnic_dev.o vnic_rq.o vnic_vic.o \ enic_ethtool.o enic_api.o enic_clsf.o enic_rq.o enic_wq.o \ - enic_admin.o + enic_admin.o enic_mbox.o =20 diff --git a/drivers/net/ethernet/cisco/enic/enic.h b/drivers/net/ethernet/= cisco/enic/enic.h index 1c09da3c0b1a..42f345aceced 100644 --- a/drivers/net/ethernet/cisco/enic/enic.h +++ b/drivers/net/ethernet/cisco/enic/enic.h @@ -292,6 +292,8 @@ struct enic { =20 /* Admin channel resources for SR-IOV MBOX */ bool has_admin_channel; + /* set on send timeout; cleared on channel re-open */ + bool mbox_send_disabled; struct vnic_wq admin_wq; struct vnic_rq admin_rq; struct vnic_cq admin_cq[2]; @@ -304,6 +306,10 @@ struct enic { u64 admin_msg_drop_cnt; void (*admin_rq_handler)(struct enic *enic, void *buf, unsigned int len); + + /* MBOX protocol state */ + struct mutex mbox_lock; + u64 mbox_msg_num; }; =20 static inline struct net_device *vnic_get_netdev(struct vnic_dev *vdev) diff --git a/drivers/net/ethernet/cisco/enic/enic_admin.c b/drivers/net/eth= ernet/cisco/enic/enic_admin.c index cf1528c85506..e097e6f8d8d4 100644 --- a/drivers/net/ethernet/cisco/enic/enic_admin.c +++ b/drivers/net/ethernet/cisco/enic/enic_admin.c @@ -19,6 +19,7 @@ #include "cq_enet_desc.h" #include "wq_enet_desc.h" #include "rq_enet_desc.h" +#include "enic_mbox.h" =20 /* Clean up any admin WQ buffers still held by hardware at close time. * Normally buffers are freed inline after send completion, but a timed-out @@ -167,7 +168,26 @@ unsigned int enic_admin_rq_cq_service(struct enic *eni= c, unsigned int budget) buf->dma_addr, buf->len, DMA_FROM_DEVICE); =20 - enic_admin_msg_enqueue(enic, buf->os_buf, buf->len); + if (enic->admin_rq_handler) { + struct cq_enet_rq_desc *rq_desc =3D desc; + u16 sender_vlan; + + /* Firmware sets the CQ VLAN field to identify the + * sender: 0 =3D PF, 1-based =3D VF index. Overwrite + * the untrusted src_vnic_id in the MBOX header with + * the hardware-verified value. + */ + sender_vlan =3D le16_to_cpu(rq_desc->vlan); + if (buf->len >=3D sizeof(struct enic_mbox_hdr)) { + struct enic_mbox_hdr *hdr =3D buf->os_buf; + + hdr->src_vnic_id =3D (sender_vlan =3D=3D 0) ? + cpu_to_le16(ENIC_MBOX_DST_PF) : + cpu_to_le16(sender_vlan - 1); + } + + enic_admin_msg_enqueue(enic, buf->os_buf, buf->len); + } =20 enic_admin_rq_buf_clean(rq, rq->to_clean); rq->to_clean =3D rq->to_clean->next; @@ -413,6 +433,7 @@ int enic_admin_channel_open(struct enic *enic) if (!enic->has_admin_channel) return -ENODEV; =20 + enic->mbox_send_disabled =3D false; err =3D enic_admin_alloc_resources(enic); if (err) { netdev_err(enic->netdev, diff --git a/drivers/net/ethernet/cisco/enic/enic_mbox.c b/drivers/net/ethe= rnet/cisco/enic/enic_mbox.c new file mode 100644 index 000000000000..3b2fc9822176 --- /dev/null +++ b/drivers/net/ethernet/cisco/enic/enic_mbox.c @@ -0,0 +1,162 @@ +// SPDX-License-Identifier: GPL-2.0-only +// Copyright 2025 Cisco Systems, Inc. All rights reserved. + +#include +#include +#include +#include + +#include "vnic_dev.h" +#include "vnic_wq.h" +#include "vnic_cq.h" +#include "enic.h" +#include "enic_admin.h" +#include "enic_mbox.h" +#include "wq_enet_desc.h" + +#define ENIC_MBOX_POLL_TIMEOUT_US 5000000 +#define ENIC_MBOX_POLL_INTERVAL_US 100 + +static void enic_mbox_fill_hdr(struct enic *enic, struct enic_mbox_hdr *hd= r, + u8 msg_type, u16 dst_vnic_id, u16 msg_len) +{ + memset(hdr, 0, sizeof(*hdr)); + hdr->dst_vnic_id =3D cpu_to_le16(dst_vnic_id); + hdr->msg_type =3D msg_type; + hdr->msg_len =3D cpu_to_le16(msg_len); + hdr->msg_num =3D cpu_to_le64(++enic->mbox_msg_num); +} + +int enic_mbox_send_msg(struct enic *enic, u8 msg_type, u16 dst_vnic_id, + void *payload, u16 payload_len) +{ + u16 total_len =3D sizeof(struct enic_mbox_hdr) + payload_len; + struct vnic_wq *wq =3D &enic->admin_wq; + struct wq_enet_desc *desc; + unsigned long timeout; + dma_addr_t dma_addr; + u16 vlan_tag; + void *buf; + int err; + + /* Serialize MBOX sends. The admin channel is a low-frequency + * control path; holding the mutex across the poll is acceptable. + */ + mutex_lock(&enic->mbox_lock); + + if (!enic->has_admin_channel || enic->mbox_send_disabled) { + err =3D -ENODEV; + goto unlock; + } + + if (vnic_wq_desc_avail(wq) =3D=3D 0) { + err =3D -ENOSPC; + goto unlock; + } + + buf =3D kmalloc(total_len, GFP_KERNEL); + if (!buf) { + err =3D -ENOMEM; + goto unlock; + } + + enic_mbox_fill_hdr(enic, buf, msg_type, dst_vnic_id, total_len); + if (payload_len) { + void *dst =3D buf + sizeof(struct enic_mbox_hdr); + + memcpy(dst, payload, payload_len); + } + + dma_addr =3D dma_map_single(&enic->pdev->dev, buf, total_len, + DMA_TO_DEVICE); + if (dma_mapping_error(&enic->pdev->dev, dma_addr)) { + kfree(buf); + err =3D -ENOMEM; + goto unlock; + } + + /* Firmware uses vlan field for routing: 0 =3D PF, 1-based =3D VF index */ + if (dst_vnic_id =3D=3D ENIC_MBOX_DST_PF) + vlan_tag =3D 0; + else + vlan_tag =3D dst_vnic_id + 1; + + desc =3D vnic_wq_next_desc(wq); + wq_enet_desc_enc(desc, (u64)dma_addr | VNIC_PADDR_TARGET, + total_len, 0, 0, 0, 1, 1, 0, 1, vlan_tag, 0); + vnic_wq_post(wq, buf, dma_addr, total_len, 1, 1, 1, 1, 0, 0); + vnic_wq_doorbell(wq); + + timeout =3D jiffies + usecs_to_jiffies(ENIC_MBOX_POLL_TIMEOUT_US); + err =3D -ETIMEDOUT; + while (time_before(jiffies, timeout)) { + if (enic_admin_wq_cq_service(enic)) { + err =3D 0; + break; + } + usleep_range(ENIC_MBOX_POLL_INTERVAL_US, + ENIC_MBOX_POLL_INTERVAL_US + 50); + } + /* Final check in case completion arrived during the last sleep */ + if (err && enic_admin_wq_cq_service(enic)) + err =3D 0; + + if (!err) { + wq->to_clean =3D wq->to_clean->next; + wq->ring.desc_avail++; + dma_unmap_single(&enic->pdev->dev, dma_addr, total_len, + DMA_TO_DEVICE); + kfree(buf); + } else { + netdev_err(enic->netdev, + "MBOX send timed out (type %u dst %u), disabling channel\n", + msg_type, dst_vnic_id); + /* + * The WQ descriptor is still live in hardware. Do not unmap + * or free the buffer: the device may still DMA from dma_addr. + * Mark the channel unusable so no further sends are attempted. + */ + enic->mbox_send_disabled =3D true; + } + + netdev_dbg(enic->netdev, + "MBOX send msg_type %u dst %u vlan %u err %d\n", + msg_type, dst_vnic_id, vlan_tag, err); +unlock: + mutex_unlock(&enic->mbox_lock); + return err; +} + +static void enic_mbox_recv_handler(struct enic *enic, void *buf, + unsigned int len) +{ + struct enic_mbox_hdr *hdr =3D buf; + + if (len < sizeof(*hdr)) { + if (net_ratelimit()) + netdev_warn(enic->netdev, + "MBOX: truncated message (len %u < %zu)\n", + len, sizeof(*hdr)); + return; + } + + if (hdr->msg_type >=3D ENIC_MBOX_MAX) { + if (net_ratelimit()) + netdev_warn(enic->netdev, + "MBOX: unknown msg type %u\n", + hdr->msg_type); + return; + } + + netdev_dbg(enic->netdev, + "MBOX recv: type %u from vnic %u len %u\n", + hdr->msg_type, le16_to_cpu(hdr->src_vnic_id), + le16_to_cpu(hdr->msg_len)); +} + +void enic_mbox_init(struct enic *enic) +{ + enic->mbox_msg_num =3D 0; + mutex_init(&enic->mbox_lock); + enic->admin_rq_handler =3D enic_mbox_recv_handler; +} diff --git a/drivers/net/ethernet/cisco/enic/enic_mbox.h b/drivers/net/ethe= rnet/cisco/enic/enic_mbox.h index a52f1d25cb21..73fd7f783ee2 100644 --- a/drivers/net/ethernet/cisco/enic/enic_mbox.h +++ b/drivers/net/ethernet/cisco/enic/enic_mbox.h @@ -80,4 +80,12 @@ struct enic_mbox_pf_link_state_ack_msg { struct enic_mbox_generic_reply ack; }; =20 +#define ENIC_MBOX_DST_PF 0xFFFF + +struct enic; + +void enic_mbox_init(struct enic *enic); +int enic_mbox_send_msg(struct enic *enic, u8 msg_type, u16 dst_vnic_id, + void *payload, u16 payload_len); + #endif /* _ENIC_MBOX_H_ */ --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B8CB37DEA8; Thu, 23 Apr 2026 16:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.93 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961814; cv=none; b=hgr/tY40LZ1EW7ZUS8dXLbKv2QKIQr0Z56MyGsnzMwVlIS9q77AlRV0FtQ95fhxMZJZ5iC6gNECfkEc3aF8NAQKvazB1p/HxifxkSpspnJA9AxAPfEFQMs5MNpWxXq9uSYOnQSX85C7cmClANDMNuN01TmFZe1LZJoXOonfZDK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961814; c=relaxed/simple; bh=3UXiwEguexDSU5q9sXykOpn4fjIRMVeBycb+uHtZMiI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PapjY9zs2hgS5PxWPJcX9GfafSkrJyJTXXi1O5LlvX20a0j9A3UwsVTqQdTHgcAOeZqTZzaCWVvWgyi2Lggl/KTHVua9hosxWOWTpfuAmk/BuZKQhgYvGGFm4dPKvRTgM8fBKClSa1zc8EFoJwwMd7KG7qk1FcjlbEURGXRV0hM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=hb6zFtNe; arc=none smtp.client-ip=173.37.142.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="hb6zFtNe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=8529; q=dns/txt; s=iport01; t=1776961812; x=1778171412; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=iD3A2YdfU8gmEgjI03DI0UYPW1uFfq1azzwfwXueZ/k=; b=hb6zFtNe8r40de6EakOCdKMJb9Te29KGvPJDE9ylF/NTFo2qRxn03s9W jGj/lEmjXmHkIfMYZiWPRu/Kc5r5pZKmUEsuN5hg3+LPKJLOJ2e5AtPP6 DWpvTIg6Q+L0s8JodwnLfqsrZw774bx4zJn6rIEUKFfFcHOSrLuJh+QiI ol+a4M7Bevp2GH4xc/t3PiKHVXAXWAwd6AuEImRP2dRgDPuy4025k9oby y+QDk4lQYP7k+rj4HbxQCtTrLC+t2TazEqF7Sag/YZ+ORRlCmeaozsbmf Y5KAw2PHFNvAjF3bXLo0n+ijuHeiusGXkEowLhEGiwKZufWyRpbZziIkk g==; X-CSE-ConnectionGUID: 1oD8PgVtT0eZ+B2uDldJgQ== X-CSE-MsgGUID: MPobrCY+S/Os275FNwHdFw== X-IPAS-Result: =?us-ascii?q?A0BIAgAkSOpp/4//Ja1aglmCGD+BT0NJhFePU4IhkU2MU?= =?us-ascii?q?BSBaw8BAQEPUQQBAYUGAo0sAiY0CQ4BAgQBAQEBAwIDAQEBAQEBAQEBAQELA?= =?us-ascii?q?QEFAQEBAgEHBYEOE4ZchlsCAQMjBFIQJQImAgJGEAYBEoIqWIJ0A7NRen8zg?= =?us-ascii?q?QGEfdlCgWQBCxQBgQouhXKCZgGBcIQGO4Q/JxuBSUSBFYNohAUag3+CaQSDH?= =?us-ascii?q?BSEZ4o3CT+BAhwDWSwBVRMNCgsHBWFSMwMgCgsSEhgVAhQcEw8EFjIdcAwQF?= =?us-ascii?q?xIsFzRYGwcFgUuECW0UMQQhgQuDKoE2gQEDCxgNSBEsNwYOGwQ9AW4HijYgD?= =?us-ascii?q?4E5agdLMBRCOTEBewUwkwsdg36NXWuBNZ9ZhCaBZKAOATKXZpMFmQYio0xrh?= =?us-ascii?q?GiBaDyBWTMaCBsVgyJTGQ+OLRYcyHImMj0CBwIHDQMLkXmBbAEB?= IronPort-Data: A9a23:0OKaB65FJJj4piFbRcZw6QxRtPjGchMFZxGqfqrLsTDasY5as4F+v jEeWmzTOfuPYGH3Kt0ga4zioBsFusKBmtAxSws5r38yZn8b8sCt6fZ1gavT04J+CuWZESqLO u1HMoGowPgcFyGa/lH2dOC98RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUw6mJSqYDR7zil5 5Wo+KUzBHf/g2Qqaj5OsPrYwP9SlK2aVA0w7wRWic9j5Dcyp1FNZLoDKKe4KWfPQ4U8NoaSW +bZwbilyXjS9hErB8nNuu6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTaJLwXXxqZwChxLid/ jniWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I0DuKxPRL/tS4E4eZIo0qt54P31yr fEqaxpXczyHi8C5+efuIgVsrpxLwMjDJogTvDRkiDreF/tjGc6FSKTR7tge1zA17ixMNa+BP IxCNnw1MUmGOkEUUrsUIMpWcOOAnXDjciZYq1K9rqss6G+Vxwt0uFToGIWPIYbWH5oMxS50o Erjx2PzGDord+fY7iHfrS+CoPDvkQ3kDdd6+LqQs6QCbEeo7mAaFhATfVeyv/S8jkmwR5RZJ lB80icisK075kG3Ztb6WBK8rTiPuRt0c9lNGeQS6wyXzKfQpQGDCQAsRzhNctE598k7WTAny HeNgtXvQzdv2JWNQHiQ8La8tz6+OSEJa2QFYEcsSQoD/smmo4wpiB/LZshsHbTzjdDvHzz0h TeQo0AWgbgPgcMV/7u08EqBgD+2oJXNCAkv6W3qsnmN9Ah1YsuhIoev81WetagGJ4eCRV7Ht 38B8ySD0N0z4Vi2vHTlaI0w8HuBvZ5p7BW0bYZTIqQc IronPort-HdrOrdr: A9a23:0hN+6qBJ4TkQSX7lHela55DYdb4zR+YMi2TDGXoBLSC9Ffb4qy nOppomPHDP5Qr5NEtLpTnEAtjjfZq+z/FICPcqXYtKNTOO0ACVxcNZnOjfKlbbdxEWmNQtsJ tIQuxSBML9CF5igd2/wgWpeuxQueWvweSEifjTynF1QRovUaFv6A9lFh2We3cGIjWufaBJc6 a0145guyeqf2gRY4CQA3kIWPWGmvjw/aiWGSLvw3UcmXOzZfTC0s+ALySl X-Talos-CUID: 9a23:OOo22mE8Sisg84JnqmI+82JEIs8bbkGFwUWTCRWlJWJlarKsHAo= X-Talos-MUID: 9a23:Di9bmwiYxCj11q7/ffUbbcMpEf9v6b6FOQM21rId4ZbZGwpvGzuzk2Hi X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="723242713" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-6.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:07 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id 7E1BF18000279; Thu, 23 Apr 2026 16:29:06 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:08 -0700 Subject: [PATCH net-next v5 07/10] enic: add MBOX PF handlers for VF register and capability Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-7-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=8869; i=satishkh@cisco.com; h=from:subject:message-id; bh=3UXiwEguexDSU5q9sXykOpn4fjIRMVeBycb+uHtZMiI=; b=VT1Oc5zN/LbiAqrKNktX38AH5FJBA8j+AWp/9GstvrUtVSucx4ynvnMEP3PXxWb6U05nacroQ rSbVaRWtEr4BKoyCh/lvdWCeFQYtJYQWcwuP1MWAb0mtc9ciqEJFyyi X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com Implement PF-side mailbox message processing for SR-IOV V2 admin channel communication. When the PF receives messages from VFs, the dispatch routes them to type-specific handlers: - VF_CAPABILITY_REQUEST: reply with protocol version 1 - VF_REGISTER_REQUEST: mark VF registered, reply, then send PF_LINK_STATE_NOTIF with link enabled - VF_UNREGISTER_REQUEST: mark VF unregistered, send reply - PF_LINK_STATE_ACK: log errors from VF acknowledgment Per-VF state (struct enic_vf_state) is tracked via enic->vf_state which will be allocated when SRIOV V2 is enabled. Remove the CONFIG_PCI_IOV guard from num_vfs in struct enic. The PF handlers reference enic->num_vfs for VF ID bounds checking in enic_mbox.c, which is compiled unconditionally. The field must be visible regardless of CONFIG_PCI_IOV to avoid build failures. Add enic_mbox_send_link_state() helper for PF-initiated link state notifications, also used later by ndo_set_vf_link_state. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/enic.h | 7 +- drivers/net/ethernet/cisco/enic/enic_mbox.c | 182 ++++++++++++++++++++++++= +++- drivers/net/ethernet/cisco/enic/enic_mbox.h | 1 + 3 files changed, 186 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic.h b/drivers/net/ethernet/= cisco/enic/enic.h index 42f345aceced..9b1fa3857df5 100644 --- a/drivers/net/ethernet/cisco/enic/enic.h +++ b/drivers/net/ethernet/cisco/enic/enic.h @@ -256,9 +256,7 @@ struct enic { struct enic_rx_coal rx_coalesce_setting; u32 rx_coalesce_usecs; u32 tx_coalesce_usecs; -#ifdef CONFIG_PCI_IOV u16 num_vfs; -#endif enum enic_vf_type vf_type; unsigned int enable_count; spinlock_t enic_api_lock; @@ -310,6 +308,11 @@ struct enic { /* MBOX protocol state */ struct mutex mbox_lock; u64 mbox_msg_num; + + /* PF: per-VF MBOX state, allocated when SRIOV V2 is enabled */ + struct enic_vf_state { + bool registered; + } *vf_state; }; =20 static inline struct net_device *vnic_get_netdev(struct vnic_dev *vdev) diff --git a/drivers/net/ethernet/cisco/enic/enic_mbox.c b/drivers/net/ethe= rnet/cisco/enic/enic_mbox.c index 3b2fc9822176..f3c0e94c2417 100644 --- a/drivers/net/ethernet/cisco/enic/enic_mbox.c +++ b/drivers/net/ethernet/cisco/enic/enic_mbox.c @@ -127,10 +127,175 @@ int enic_mbox_send_msg(struct enic *enic, u8 msg_typ= e, u16 dst_vnic_id, return err; } =20 +int enic_mbox_send_link_state(struct enic *enic, u16 vf_id, u32 link_state) +{ + struct enic_mbox_pf_link_state_notif_msg notif =3D {}; + + if (!enic->vf_state || vf_id >=3D enic->num_vfs || + !enic->vf_state[vf_id].registered) { + netdev_dbg(enic->netdev, + "MBOX: skip link state to unregistered VF %u\n", + vf_id); + return 0; + } + + notif.link_state =3D cpu_to_le32(link_state); + return enic_mbox_send_msg(enic, ENIC_MBOX_PF_LINK_STATE_NOTIF, vf_id, + ¬if, sizeof(notif)); +} + +static int enic_mbox_pf_handle_capability(struct enic *enic, void *msg, + u16 vf_id, u64 msg_num) +{ + struct enic_mbox_vf_capability_reply_msg reply =3D {}; + + reply.reply.ret_major =3D cpu_to_le16(0); + reply.version =3D cpu_to_le32(ENIC_MBOX_CAP_VERSION_1); + + return enic_mbox_send_msg(enic, ENIC_MBOX_VF_CAPABILITY_REPLY, vf_id, + &reply, sizeof(reply)); +} + +static int enic_mbox_pf_handle_register(struct enic *enic, void *msg, + u16 vf_id, u64 msg_num) +{ + struct enic_mbox_vf_register_reply_msg reply =3D {}; + int err; + + if (!enic->vf_state || vf_id >=3D enic->num_vfs) { + if (net_ratelimit()) + netdev_warn(enic->netdev, + "MBOX: register from invalid VF %u\n", + vf_id); + return -EINVAL; + } + + /* VF re-registering (e.g. guest reboot without clean unregister): + * mark the previous registration inactive before accepting the new one. + */ + if (enic->vf_state[vf_id].registered) { + netdev_dbg(enic->netdev, + "MBOX: VF %u re-register, cleaning previous state\n", + vf_id); + enic->vf_state[vf_id].registered =3D false; + } + + reply.reply.ret_major =3D cpu_to_le16(0); + err =3D enic_mbox_send_msg(enic, ENIC_MBOX_VF_REGISTER_REPLY, vf_id, + &reply, sizeof(reply)); + if (err) + return err; + + enic->vf_state[vf_id].registered =3D true; + netdev_info(enic->netdev, "VF %u registered via MBOX\n", vf_id); + + err =3D enic_mbox_send_link_state(enic, vf_id, + ENIC_MBOX_LINK_STATE_ENABLE); + if (err) + netdev_warn(enic->netdev, + "VF %u: failed to send initial link state: %d\n", + vf_id, err); + /* Registration succeeded; link state will be (re-)sent on next + * enic_link_check() event. + */ + return 0; +} + +static int enic_mbox_pf_handle_unregister(struct enic *enic, void *msg, + u16 vf_id, u64 msg_num) +{ + struct enic_mbox_vf_register_reply_msg reply =3D {}; + int err; + + if (!enic->vf_state || vf_id >=3D enic->num_vfs) { + if (net_ratelimit()) + netdev_warn(enic->netdev, + "MBOX: unregister from invalid VF %u\n", + vf_id); + return -EINVAL; + } + + /* VF is unloading; clear local state regardless of whether + * the reply is successfully delivered to avoid the PF treating + * a dead VF as still registered. + */ + enic->vf_state[vf_id].registered =3D false; + + reply.reply.ret_major =3D cpu_to_le16(0); + err =3D enic_mbox_send_msg(enic, ENIC_MBOX_VF_UNREGISTER_REPLY, vf_id, + &reply, sizeof(reply)); + + netdev_info(enic->netdev, "VF %u unregistered via MBOX\n", vf_id); + + return err; +} + +static void enic_mbox_pf_process_msg(struct enic *enic, + struct enic_mbox_hdr *hdr, void *payload) +{ + u16 vf_id =3D le16_to_cpu(hdr->src_vnic_id); + u16 msg_len =3D le16_to_cpu(hdr->msg_len); + int err =3D 0; + + if (!enic->vf_state) { + netdev_dbg(enic->netdev, + "MBOX: PF received msg but SRIOV not active\n"); + return; + } + + if (vf_id >=3D enic->num_vfs) { + if (net_ratelimit()) + netdev_warn(enic->netdev, + "MBOX: PF received msg from invalid VF %u\n", + vf_id); + return; + } + + switch (hdr->msg_type) { + case ENIC_MBOX_VF_CAPABILITY_REQUEST: + err =3D enic_mbox_pf_handle_capability(enic, payload, vf_id, + le64_to_cpu(hdr->msg_num)); + break; + case ENIC_MBOX_VF_REGISTER_REQUEST: + err =3D enic_mbox_pf_handle_register(enic, payload, vf_id, + le64_to_cpu(hdr->msg_num)); + break; + case ENIC_MBOX_VF_UNREGISTER_REQUEST: + err =3D enic_mbox_pf_handle_unregister(enic, payload, vf_id, + le64_to_cpu(hdr->msg_num)); + break; + case ENIC_MBOX_PF_LINK_STATE_ACK: { + struct enic_mbox_pf_link_state_ack_msg *ack =3D payload; + + if (msg_len < sizeof(*hdr) + sizeof(*ack)) + break; + if (le16_to_cpu(ack->ack.ret_major)) + netdev_warn(enic->netdev, + "MBOX: VF %u link state ACK error %u/%u\n", + vf_id, le16_to_cpu(ack->ack.ret_major), + le16_to_cpu(ack->ack.ret_minor)); + break; + } + default: + netdev_dbg(enic->netdev, + "MBOX: PF unhandled msg type %u from VF %u\n", + hdr->msg_type, vf_id); + err =3D -EOPNOTSUPP; + break; + } + + if (err) + netdev_warn(enic->netdev, + "MBOX: PF handler for msg type %u from VF %u failed: %d\n", + hdr->msg_type, vf_id, err); +} + static void enic_mbox_recv_handler(struct enic *enic, void *buf, unsigned int len) { struct enic_mbox_hdr *hdr =3D buf; + void *payload; + u16 msg_len; =20 if (len < sizeof(*hdr)) { if (net_ratelimit()) @@ -148,10 +313,23 @@ static void enic_mbox_recv_handler(struct enic *enic,= void *buf, return; } =20 + msg_len =3D le16_to_cpu(hdr->msg_len); + if (msg_len < sizeof(*hdr) || msg_len > len) { + if (net_ratelimit()) + netdev_warn(enic->netdev, + "MBOX: invalid msg_len %u (buf len %u)\n", + msg_len, len); + return; + } + netdev_dbg(enic->netdev, "MBOX recv: type %u from vnic %u len %u\n", - hdr->msg_type, le16_to_cpu(hdr->src_vnic_id), - le16_to_cpu(hdr->msg_len)); + hdr->msg_type, le16_to_cpu(hdr->src_vnic_id), msg_len); + + payload =3D buf + sizeof(*hdr); + + if (enic->vf_state) + enic_mbox_pf_process_msg(enic, hdr, payload); } =20 void enic_mbox_init(struct enic *enic) diff --git a/drivers/net/ethernet/cisco/enic/enic_mbox.h b/drivers/net/ethe= rnet/cisco/enic/enic_mbox.h index 73fd7f783ee2..f1de67db1273 100644 --- a/drivers/net/ethernet/cisco/enic/enic_mbox.h +++ b/drivers/net/ethernet/cisco/enic/enic_mbox.h @@ -87,5 +87,6 @@ struct enic; void enic_mbox_init(struct enic *enic); int enic_mbox_send_msg(struct enic *enic, u8 msg_type, u16 dst_vnic_id, void *payload, u16 payload_len); +int enic_mbox_send_link_state(struct enic *enic, u16 vf_id, u32 link_state= ); =20 #endif /* _ENIC_MBOX_H_ */ --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1463B39D6F8; Thu, 23 Apr 2026 16:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961819; cv=none; b=snO/85dHG7UO3WwszF3niYP5uH6BZNf7wgZ18VzKPOjX9uDWbCymNbTn6JTvvuRRnyDgwtyPHrjXgHHi+8IWIdaP2LNUm0f3aHwbE3VJCo330Eg8UzWfGGmpgMwfHilYhFj5C/rRdPRpnfxxQrywMTzGZLL9EpZkKHGM60v0fEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961819; c=relaxed/simple; bh=APLfrSE6/bUVl9FECXjWpOAWU6ipu1R/nXwWeb/u9TU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BVo4aXdxmPKbOLGOanqhFuFsqKxeP5xVmjrFV5Zf9jCOeGO9a2RW/9X+8argXBEie1nEM4mPOHZuroWtI4mHWo7cZn7w0RPvxfev50mBGK9KI+12/jvCEZrM0XP9yhG7fLaKO7Orvoa74Msl0ns+ZMEvzM/WCwAAqIn5ezDaacw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=Y2Ob1Tsp; arc=none smtp.client-ip=173.37.142.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="Y2Ob1Tsp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=9844; q=dns/txt; s=iport01; t=1776961817; x=1778171417; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=TxMWBY1GCh2MTuzomsIGUYP5X6tocS9mKdU2RFSx6Ag=; b=Y2Ob1Tsp4O41XByDIozPmyHjXhHm9xqqWym6dDZy5tDV0sLXxR7N7qMa 0NyV1zhKVswv6QN9Dbj6XISZBQE+YySpK9dcVd7GMgfD7IPhk2yfwR+fR joiSMGJxjHkKxEzYvxFJdYQURFScNbHEN891BCv70Gs/F/z1zpfYLjsHm oIn/jOvgCrG67iFD3Zq7Syn3zhqZkPAXzBB4qfnnK0ZoYoLosviEUCbw+ GTK2iMl1jlHhbjHE74te1TYi+EjgLWDBZPIQIU25LmQrSJViI2oSRcUuN rqt2m/1dknZhHoBojw/WLAuO16k4K9MhRUO5v0WDHdikqA8TKQ6KzhMft A==; X-CSE-ConnectionGUID: 9s7qW8rvQCG7HS+5QnB7kQ== X-CSE-MsgGUID: CHNoVMEhTeiCD6oqb8jH8A== X-IPAS-Result: =?us-ascii?q?A0AnAAClR+pp/4//Ja1aHQEBAQEJARIBBQUBgXwIAQsBg?= =?us-ascii?q?laBT0NJhFeIHIc3giGeHRSBaw8BAQEPUQQBAYUGAo0sAiY0CQ4BAgQBAQEBA?= =?us-ascii?q?wIDAQEBAQEBAQEBAQELAQEFAQEBAgEHBYEOE4ZchlsCAQMjBEASECUCJgICR?= =?us-ascii?q?hAGARKDAoJ0A7NVen8zgQHeP4FkAQsUAYEKLgGFcYJmAYFwhAY7hD8nG4FJR?= =?us-ascii?q?IEVg2iEBQUVg3+CaQSCDYEPFI8eCT+BAhwDWSwBVRMNCgsHBWFSMwMgCgsSE?= =?us-ascii?q?hgVAhQvDwQWMh1wDBAXEiwXNFgbBwWBS4QJbRQxBCGBC4MqgTaBAQMLGA1IE?= =?us-ascii?q?Sw3Bg4bBD0BbgeKNiAPgTlqBxZ5ezFnFQUwCZNhgzyNXWuBNZ9ZhCaBZKAOA?= =?us-ascii?q?TKEBJNikwWZBiKCNqExUIRogWg8gVkzGggbFYMiUxkPji0WHMhyJjI9AgcCB?= =?us-ascii?q?w0DC5FoEReBVQEB?= IronPort-Data: A9a23:P16NCq6N8+AgED9Ay693AgxRtPjGchMFZxGqfqrLsTDasY5as4F+v moaWTyHMqvfajb8fNlzOdy3ph5Sv5LTmtU1HlZupSg9Zn8b8sCt6fZ1gavT04J+CuWZESqLO u1HMoGowPgcFyGa/lH2dOC98RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUw6mJSqYDR7zil5 5Wo+KUzBHf/g2Qqaj5OsPrYwP9SlK2aVA0w7wRWic9j5Dcyp1FNZLoDKKe4KWfPQ4U8NoaSW +bZwbilyXjS9hErB8nNuu6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTaJLwXXxqZwChxLid/ jniWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I0DuKxPRL/tS4E4ebJZH49knG3933 tNHCAtOMymFrb21+efuIgVsrpxLwMjDJogTvDRkiDreF/tjGc6FSKTR7tge1zA17ixMNa+BP IxCNnw1MUmGOkEUUrsUIMpWcOOAnXDjciZYq1K9rqss6G+Vxwt0uFToGIWPJoTVGJ4Lxi50o Ert30L+PDQ3NOCSyBGprHW1jL/NvXPSDdd6+LqQs6QCbEeo7mAaFhATfVeyv/S8jkmwR5RZJ lB80icisK075kG3Ztb6WBK8rTiPuRt0c9lNGeQS6wyXzKfQpQGDCQAsRzhNctE598k7WTAny HeNgtXvQzdv2JWNQHiQ8La8tz6+OSEJa2QFYEcsSQoD/smmo4wpiB/LZshsHbTzjdDvHzz0h TeQo0AWgbgPgcMV/7u08EqBgD+2oJXNCAkv6W3qsnmN9Ah1YsuhIoev81WetagGJ4eCRV7Ht 38B8ySD0N0z4Vi2vHTlaI0w8HuBvZ5p7BW0bYZTIqQc IronPort-HdrOrdr: A9a23:tbLDqKilF3vOh1qx0pBmQ7q6uHBQXiwji2hC6mlwRA09TyVXrb HLoB19737JYVcqNk3I9ursBEDtexnhHNtOkOss1NSZMzUOxlHJEGgK1+KLqAEIWReOldK1vp 0NT0ERMqyUMXFKyev3/wW8Fc8t252k/LDAv5am815dCSxndK1k6R50EUKgEkNwTBRbHpZRLu v72iM+nUvGRV0nKuKmG3ICQ+/P4/fPlJ7gfFo6IiRP0nj3sdttg4SKaSRxGXwlIkhy/Ys= X-Talos-CUID: =?us-ascii?q?9a23=3AWXP4UGgvdnb41HTPrBzdG4U35TJuI2aC1UiAOVG?= =?us-ascii?q?BIkk2aIbWFGaW0vxnqp87?= X-Talos-MUID: 9a23:dKqtvgnzdmiX7T/OMODrdnpJFOFv3YGDCHwAkL4q5c6dP3xyG2e02WE= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="724075360" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-4.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:07 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id 3AB72180003A3; Thu, 23 Apr 2026 16:29:07 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:09 -0700 Subject: [PATCH net-next v5 08/10] enic: add MBOX VF handlers for capability, register and link state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-8-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=10195; i=satishkh@cisco.com; h=from:subject:message-id; bh=APLfrSE6/bUVl9FECXjWpOAWU6ipu1R/nXwWeb/u9TU=; b=Dz3iBBi5gbgYkpBIQPM1S4T5OO6EEJ3q055+oXJ8NEzOXrn+3ZHS2+ytivCV0upSxECNCIgk7 0LbJU3PWzk2CMWGqk8gdiGmwMVl9/0ivQk90OxNMitePATWwnf2F1TJ X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com Implement VF-side mailbox message processing for SR-IOV V2 admin channel communication. VF receive handlers: - VF_CAPABILITY_REPLY: store PF protocol version, signal completion - VF_REGISTER_REPLY: mark VF as registered, signal completion - VF_UNREGISTER_REPLY: mark VF as unregistered, signal completion - PF_LINK_STATE_NOTIF: update carrier state via netif_carrier_on/off, send ACK back to PF VF initiation functions for the probe-time handshake: - enic_mbox_vf_capability_check: send capability request, wait for PF reply via completion - enic_mbox_vf_register: send register request, wait for PF confirmation via completion - enic_mbox_vf_unregister: send unregister request, wait for PF confirmation The wait helper (enic_mbox_wait_reply) uses wait_for_completion_timeout, signaled when the admin ISR/NAPI/ workqueue pipeline delivers the reply message. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/enic.h | 9 +- drivers/net/ethernet/cisco/enic/enic_mbox.c | 220 ++++++++++++++++++++++++= ++++ drivers/net/ethernet/cisco/enic/enic_mbox.h | 3 + 3 files changed, 231 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cisco/enic/enic.h b/drivers/net/ethernet/= cisco/enic/enic.h index 9b1fa3857df5..29ce26284493 100644 --- a/drivers/net/ethernet/cisco/enic/enic.h +++ b/drivers/net/ethernet/cisco/enic/enic.h @@ -258,6 +258,8 @@ struct enic { u32 tx_coalesce_usecs; u16 num_vfs; enum enic_vf_type vf_type; + bool vf_registered; + u32 pf_cap_version; unsigned int enable_count; spinlock_t enic_api_lock; bool enic_api_busy; @@ -305,9 +307,14 @@ struct enic { void (*admin_rq_handler)(struct enic *enic, void *buf, unsigned int len); =20 - /* MBOX protocol state */ + /* MBOX protocol state -- single-flight: on the VF, all callers + * that wait on mbox_comp run under RTNL or during probe/remove, + * so only one completion is outstanding at a time. mbox_lock + * protects the shared admin WQ from concurrent senders. + */ struct mutex mbox_lock; u64 mbox_msg_num; + struct completion mbox_comp; =20 /* PF: per-VF MBOX state, allocated when SRIOV V2 is enabled */ struct enic_vf_state { diff --git a/drivers/net/ethernet/cisco/enic/enic_mbox.c b/drivers/net/ethe= rnet/cisco/enic/enic_mbox.c index f3c0e94c2417..3819efc837bf 100644 --- a/drivers/net/ethernet/cisco/enic/enic_mbox.c +++ b/drivers/net/ethernet/cisco/enic/enic_mbox.c @@ -5,6 +5,7 @@ #include #include #include +#include =20 #include "vnic_dev.h" #include "vnic_wq.h" @@ -127,6 +128,16 @@ int enic_mbox_send_msg(struct enic *enic, u8 msg_type,= u16 dst_vnic_id, return err; } =20 +static int enic_mbox_wait_reply(struct enic *enic, unsigned long timeout_m= s) +{ + unsigned long left; + + left =3D wait_for_completion_timeout(&enic->mbox_comp, + msecs_to_jiffies(timeout_ms)); + + return left ? 0 : -ETIMEDOUT; +} + int enic_mbox_send_link_state(struct enic *enic, u16 vf_id, u32 link_state) { struct enic_mbox_pf_link_state_notif_msg notif =3D {}; @@ -290,6 +301,136 @@ static void enic_mbox_pf_process_msg(struct enic *eni= c, hdr->msg_type, vf_id, err); } =20 +static void enic_mbox_vf_handle_capability_reply(struct enic *enic, + void *payload) +{ + struct enic_mbox_vf_capability_reply_msg *reply =3D payload; + + if (le16_to_cpu(reply->reply.ret_major) =3D=3D 0) + enic->pf_cap_version =3D le32_to_cpu(reply->version); + complete(&enic->mbox_comp); +} + +static void enic_mbox_vf_handle_register_reply(struct enic *enic, + void *payload) +{ + struct enic_mbox_vf_register_reply_msg *reply =3D payload; + + if (le16_to_cpu(reply->reply.ret_major)) { + netdev_warn(enic->netdev, + "MBOX: VF register rejected by PF: %u/%u\n", + le16_to_cpu(reply->reply.ret_major), + le16_to_cpu(reply->reply.ret_minor)); + } else { + enic->vf_registered =3D true; + } + complete(&enic->mbox_comp); +} + +static void enic_mbox_vf_handle_unregister_reply(struct enic *enic, + void *payload) +{ + struct enic_mbox_vf_register_reply_msg *reply =3D payload; + + if (le16_to_cpu(reply->reply.ret_major)) { + netdev_warn(enic->netdev, + "MBOX: VF unregister rejected by PF: %u/%u\n", + le16_to_cpu(reply->reply.ret_major), + le16_to_cpu(reply->reply.ret_minor)); + } else { + enic->vf_registered =3D false; + } + complete(&enic->mbox_comp); +} + +static void enic_mbox_vf_handle_link_state(struct enic *enic, void *payloa= d) +{ + struct enic_mbox_pf_link_state_notif_msg *notif =3D payload; + struct enic_mbox_pf_link_state_ack_msg ack =3D {}; + + switch (le32_to_cpu(notif->link_state)) { + case ENIC_MBOX_LINK_STATE_ENABLE: + if (!netif_carrier_ok(enic->netdev)) + netif_carrier_on(enic->netdev); + netdev_dbg(enic->netdev, "MBOX: link state -> UP\n"); + break; + case ENIC_MBOX_LINK_STATE_DISABLE: + if (netif_carrier_ok(enic->netdev)) + netif_carrier_off(enic->netdev); + netdev_dbg(enic->netdev, "MBOX: link state -> DOWN\n"); + break; + default: + netdev_warn(enic->netdev, "MBOX: unknown link state %u\n", + le32_to_cpu(notif->link_state)); + ack.ack.ret_major =3D cpu_to_le16(ENIC_MBOX_ERR_GENERIC); + break; + } + + enic_mbox_send_msg(enic, ENIC_MBOX_PF_LINK_STATE_ACK, ENIC_MBOX_DST_PF, + &ack, sizeof(ack)); +} + +static bool enic_mbox_vf_payload_ok(struct enic *enic, u8 msg_type, + u16 payload_len, size_t min_len) +{ + if (payload_len < min_len) { + netdev_warn(enic->netdev, + "MBOX: short payload for type %u (%u < %zu)\n", + msg_type, payload_len, min_len); + return false; + } + return true; +} + +static void enic_mbox_vf_process_msg(struct enic *enic, + struct enic_mbox_hdr *hdr, void *payload, + u16 payload_len) +{ + switch (hdr->msg_type) { + case ENIC_MBOX_VF_CAPABILITY_REPLY: { + size_t exp =3D sizeof(struct enic_mbox_vf_capability_reply_msg); + + if (!enic_mbox_vf_payload_ok(enic, hdr->msg_type, + payload_len, exp)) + return; + enic_mbox_vf_handle_capability_reply(enic, payload); + break; + } + case ENIC_MBOX_VF_REGISTER_REPLY: { + size_t exp =3D sizeof(struct enic_mbox_vf_register_reply_msg); + + if (!enic_mbox_vf_payload_ok(enic, hdr->msg_type, + payload_len, exp)) + return; + enic_mbox_vf_handle_register_reply(enic, payload); + break; + } + case ENIC_MBOX_VF_UNREGISTER_REPLY: { + size_t exp =3D sizeof(struct enic_mbox_vf_register_reply_msg); + + if (!enic_mbox_vf_payload_ok(enic, hdr->msg_type, + payload_len, exp)) + return; + enic_mbox_vf_handle_unregister_reply(enic, payload); + break; + } + case ENIC_MBOX_PF_LINK_STATE_NOTIF: { + size_t exp =3D sizeof(struct enic_mbox_pf_link_state_notif_msg); + + if (!enic_mbox_vf_payload_ok(enic, hdr->msg_type, + payload_len, exp)) + return; + enic_mbox_vf_handle_link_state(enic, payload); + break; + } + default: + netdev_dbg(enic->netdev, + "MBOX: VF unhandled msg type %u\n", + hdr->msg_type); + break; + } +} + static void enic_mbox_recv_handler(struct enic *enic, void *buf, unsigned int len) { @@ -330,11 +471,90 @@ static void enic_mbox_recv_handler(struct enic *enic,= void *buf, =20 if (enic->vf_state) enic_mbox_pf_process_msg(enic, hdr, payload); + else + enic_mbox_vf_process_msg(enic, hdr, payload, + msg_len - (u16)sizeof(*hdr)); +} + +int enic_mbox_vf_capability_check(struct enic *enic) +{ + struct enic_mbox_vf_capability_msg req =3D {}; + int err; + + enic->pf_cap_version =3D 0; + reinit_completion(&enic->mbox_comp); + req.version =3D cpu_to_le32(ENIC_MBOX_CAP_VERSION_1); + + err =3D enic_mbox_send_msg(enic, ENIC_MBOX_VF_CAPABILITY_REQUEST, + ENIC_MBOX_DST_PF, &req, sizeof(req)); + if (err) + return err; + + err =3D enic_mbox_wait_reply(enic, 3000); + if (err) { + netdev_warn(enic->netdev, + "MBOX: no capability reply from PF\n"); + return err; + } + + if (enic->pf_cap_version < ENIC_MBOX_CAP_VERSION_1) { + netdev_warn(enic->netdev, + "MBOX: PF version %u too old\n", + enic->pf_cap_version); + return -EOPNOTSUPP; + } + + return 0; +} + +int enic_mbox_vf_register(struct enic *enic) +{ + int err; + + enic->vf_registered =3D false; + reinit_completion(&enic->mbox_comp); + + err =3D enic_mbox_send_msg(enic, ENIC_MBOX_VF_REGISTER_REQUEST, + ENIC_MBOX_DST_PF, NULL, 0); + if (err) + return err; + + err =3D enic_mbox_wait_reply(enic, 3000); + if (err) { + netdev_warn(enic->netdev, + "MBOX: VF registration with PF timed out\n"); + return err; + } + + if (!enic->vf_registered) + return -ENODEV; + + return 0; +} + +int enic_mbox_vf_unregister(struct enic *enic) +{ + int err; + + if (!enic->vf_registered) + return 0; + + reinit_completion(&enic->mbox_comp); + + err =3D enic_mbox_send_msg(enic, ENIC_MBOX_VF_UNREGISTER_REQUEST, + ENIC_MBOX_DST_PF, NULL, 0); + if (err) + return err; + + err =3D enic_mbox_wait_reply(enic, 3000); + + return enic->vf_registered ? -ETIMEDOUT : 0; } =20 void enic_mbox_init(struct enic *enic) { enic->mbox_msg_num =3D 0; mutex_init(&enic->mbox_lock); + init_completion(&enic->mbox_comp); enic->admin_rq_handler =3D enic_mbox_recv_handler; } diff --git a/drivers/net/ethernet/cisco/enic/enic_mbox.h b/drivers/net/ethe= rnet/cisco/enic/enic_mbox.h index f1de67db1273..15e30ee2b0ed 100644 --- a/drivers/net/ethernet/cisco/enic/enic_mbox.h +++ b/drivers/net/ethernet/cisco/enic/enic_mbox.h @@ -88,5 +88,8 @@ void enic_mbox_init(struct enic *enic); int enic_mbox_send_msg(struct enic *enic, u8 msg_type, u16 dst_vnic_id, void *payload, u16 payload_len); int enic_mbox_send_link_state(struct enic *enic, u16 vf_id, u32 link_state= ); +int enic_mbox_vf_capability_check(struct enic *enic); +int enic_mbox_vf_register(struct enic *enic); +int enic_mbox_vf_unregister(struct enic *enic); =20 #endif /* _ENIC_MBOX_H_ */ --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 687A43822BB; Thu, 23 Apr 2026 16:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.95 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961815; cv=none; b=qQcevS0i7ks63rr57eQwB/t/CTik+LPekUzgKQma6gyArLa/gS6s9gqVhucqDQike/33u5kfr8CRJ/6IhcmBdiZ2XifHsuztGyn814OtpvvGc1frxLCV8+tg+B/o5upilTm+NLBpY9M1caq0uF1KTw86SPT4WXxC/MOz14tm3+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961815; c=relaxed/simple; bh=fG1PyNIPMw+XrOr17BnXfR4pZThG51FPEw67s7CAY1A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WTDn4rmqMtrLurT1fviXWxvRh7OizRsAlIbFrC0uSc5f4zMnpbUfQahEjp5Vjg6iIKwwCXbW5JdHvGRtAeMW8vzXIU6Lh2di3BY31i0gCnuS/b7E0xfPyn8NCLMq2xkQmmbIckeID7riSGs1JZ7tMgQ8l0Gwq5do1AFB9a/nctw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=XfRPoYkm; arc=none smtp.client-ip=173.37.142.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="XfRPoYkm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=9335; q=dns/txt; s=iport01; t=1776961813; x=1778171413; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=GrQ3JySE2o/IyDOxrosGlMnldUS8s4x2vsqwW3PChTw=; b=XfRPoYkmS7Qqh/t4ughp1+sCONsJ9I/5syLQNGjh89MbldYF7EJieU0w K58CsGeG9aXd8YuNJQeAg0gx4yMDOMTOtcUKBin+Ehpu/2Cp98zu3mi+U VF5SoSTvwChbUzGCAdg06tYEfMYaNgp5nD/VBrbYYQGFXYwvk9/ZFXbBK 1WSLNr9EN0N9MS8avEWLwotKi/aU4yI6bgAbKGiuPgLardAl7rRiucvhx mf/KGBPNcnSsQ8GSF2z00N0ms/49cReyNwTt26cSaWkFebdxCYO8dy6rQ qYRCGz7KfRZPmzDz2TsNkSfujA25NMBNLdn+4S75y+kTb9H8HUTipShdM w==; X-CSE-ConnectionGUID: hhvwMj+sSVmQlm3BXJY3ug== X-CSE-MsgGUID: NvF3J8H2SBCInjfq42yKeg== X-IPAS-Result: =?us-ascii?q?A0AaAAAkSOpp/4//Ja1aHAEBAQEBAQcBARIBAQQEAQGBf?= =?us-ascii?q?AcBAQsBghc/gU9DSYRXiByHN4Ihnh0UgWsPAQEBD1EEAQGFBgKNLAImNAkOA?= =?us-ascii?q?QIEAQEBAQMCAwEBAQEBAQEBAQEBCwEBBQEBAQIBBwWBDhOGXIZbAgEDIwRSE?= =?us-ascii?q?CUCJgICRhAGARKDAoJ0A7NRen8zgQGEfdlCgWQBCxQBgQouAYVxgmYBgXCEB?= =?us-ascii?q?juEPycbgUlEgRWDaIEogwKDdIJpBIMcFI8eCT+BAhwDWSwBVRMNCgsHBWFSM?= =?us-ascii?q?wMgCgsSEhgVAhQvDwQWMh1wDCcSLBc0WBsHBYFLhAltFDEEIYELgyqBNoEBA?= =?us-ascii?q?wsYDUgRLDcGDhsEPQFuB4o2IA+BOXEOSxwagTAMPxQfAhSTQQcWg2GNXWuBN?= =?us-ascii?q?Z9ZhCaBZKAOATKEBJNikwWZBiKCNqIBhGiBaDyBWTMaCBsVgyJTGQ+OLRYcd?= =?us-ascii?q?wECx3gmMj8HAgcOApFzBIF5AQE?= IronPort-Data: A9a23:+DgCR6PjbRyHHsXvrR1llsFynXyQoLVcMsEvi/4bfWQNrUol1j0En 2MYW2iAaPeIajHxfd0jYYm+/BtXuJLdyYJmSXM5pCpnJ55oRWUpJjg4wmPYZX76whjrFRo/h ykmQoCeaphyFTmE+kvF3oHJ9RFUzbuPSqf3FNnKMyVwQR4MYCo6gHqPocZh6mJTqYb/WVjlV e/a+ZWFZgf5gWUsaQr41orawP9RlKWq0N8nlgRWicBj5Df2i3QTBZQDEqC9R1OQapVUBOOzW 9HYx7i/+G7Dlz91Yj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnBaPpIACRYpQRw/ZwNlMDxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJSymZT78qHIT5fj6/VuEl4TP84DwdhyOGVLr tYoCgFWcx/W0opawJrjIgVtrt4oIM+uOMYUvWttiGmHS/0nWpvEBa7N4Le03h9p2ZsIRqmYP ZdEL2MzN3wsYDUXUrsTIIk3gOazhnr/WzZZs1mS46Ew5gA/ySQuiuW1boCNI43iqcN9uFi2/ UCW3z7CKDo7Mt6R0Gbf41Ghibqa9c/8cMdIfFGizdZmiUOew0QfAQMbUF+8r+X/jEOiM/pSJ 1ER8zgjsYA980ukStS7VBq9yFaHoxQVc9ldCes37EeK0KW8yw+fCnIJUX1HZcAqudEeQSEs0 BmCn7vBHTVlvbuUYWiQ+redsXW5Pi19BWsDYzIUCAgI+d/upKktgR/VCNVuCqi4ipvyAz6Y6 zaHsCQzmZ0NgsMRkaa251bKh3SrvJehc+Iuzh/cUmTg6kZyY5SoItT2r1Pa9v1Hao2eSzFto UQ5piRX18hWZbnlqcBHaLll8G2BjxpdDADhvA== IronPort-HdrOrdr: A9a23:YMHS362DxI0/yyI4awU7fwqjBEQkLtp133Aq2lEZdPWaSL39qy nIppUmPH7P5gr5N0tMpTntAsO9qDbnhPxICOoqUotKIjOHhILAFugLhrcKgQeQeBEWndQw6U 4PSdkaNPTASXV3ksr+5hC1CJIDzMnvytHQuc7ui1pgUg1ubbht9ENCCgidGlBrXwUuP+teKH Pl3LshmxOQPVIKc8+8Gn4JG8LHp9HNidbaRCRuPW9e1OFL5gnYkoIT1HOjr2wjbw8= X-Talos-CUID: 9a23:B6uwQW62KhCbzoSmK9ss9E4KBeUnMWbm8nLpJ0rjI1ZLeeaIRgrF X-Talos-MUID: 9a23:gbPJmgn3MhJPBLa77/r3dnpEKukzwfSOUnsnurQAucedaXZhGDqS2WE= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="725062019" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-8.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:08 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id E93C3180003AB; Thu, 23 Apr 2026 16:29:07 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:10 -0700 Subject: [PATCH net-next v5 09/10] enic: wire V2 SR-IOV enable with admin channel and MBOX Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-9-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=9555; i=satishkh@cisco.com; h=from:subject:message-id; bh=fG1PyNIPMw+XrOr17BnXfR4pZThG51FPEw67s7CAY1A=; b=qWYj2ls3cUKyhmlT1cl26GogS0S6yzdffEu4Q3WfCrOSOXEPVVQyKrJRle6ASU7JlBoMSIRPK 9gZMk1Caq4bB6p+NqMqL76muTGQC92kxedC9PkwApkjTLAhNwrsahFw X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com Extend enic_sriov_configure() to handle V2 SR-IOV VFs. When the PF detects V2 VF device IDs, the enable path allocates per-VF MBOX state, opens the admin channel, initializes the MBOX protocol, and then calls pci_enable_sriov(). The admin channel must be ready before VFs are created so that VF drivers can immediately begin the MBOX capability and registration handshake during their probe. The disable path reverses this order: pci_disable_sriov() first (so VF drivers unregister via MBOX), then the admin channel is closed and per-VF state is freed. Reject VF port profile requests when V2 SR-IOV is active (enic_is_valid_pp_vf), since enic->pp is not reallocated for V2 VFs and the V2 protocol uses MBOX instead of port profiles. Update enic_remove() to run enic_dev_deinit() and vnic_dev_close() after SR-IOV teardown, so the PF device remains functional while VFs are being cleaned up. This ordering applies to both V1 and V2 SR-IOV paths. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/enic.h | 1 + drivers/net/ethernet/cisco/enic/enic_main.c | 139 ++++++++++++++++++++++++= ++-- drivers/net/ethernet/cisco/enic/enic_mbox.c | 13 ++- drivers/net/ethernet/cisco/enic/enic_pp.c | 5 + drivers/net/ethernet/cisco/enic/enic_res.c | 1 + drivers/net/ethernet/cisco/enic/vnic_enet.h | 4 +- 6 files changed, 153 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic.h b/drivers/net/ethernet/= cisco/enic/enic.h index 29ce26284493..70bb8cb9fe42 100644 --- a/drivers/net/ethernet/cisco/enic/enic.h +++ b/drivers/net/ethernet/cisco/enic/enic.h @@ -315,6 +315,7 @@ struct enic { struct mutex mbox_lock; u64 mbox_msg_num; struct completion mbox_comp; + bool mbox_initialized; =20 /* PF: per-VF MBOX state, allocated when SRIOV V2 is enabled */ struct enic_vf_state { diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethe= rnet/cisco/enic/enic_main.c index 53d68272d06a..057716ccc283 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -60,6 +60,8 @@ #include "enic_clsf.h" #include "enic_rq.h" #include "enic_wq.h" +#include "enic_admin.h" +#include "enic_mbox.h" =20 #define ENIC_NOTIFY_TIMER_PERIOD (2 * HZ) =20 @@ -2689,6 +2691,122 @@ static void enic_sriov_detect_vf_type(struct enic *= enic) enic->vf_type =3D ENIC_VF_TYPE_NONE; } } + +static int __maybe_unused +enic_sriov_v2_enable(struct enic *enic, int num_vfs) +{ + int err; + + if (!enic->has_admin_channel) { + netdev_err(enic->netdev, + "V2 SR-IOV requires admin channel resources\n"); + return -EOPNOTSUPP; + } + + enic->vf_state =3D kcalloc(num_vfs, sizeof(*enic->vf_state), GFP_KERNEL); + if (!enic->vf_state) + return -ENOMEM; + + err =3D enic_admin_channel_open(enic); + if (err) { + netdev_err(enic->netdev, + "Failed to open admin channel: %d\n", err); + goto free_vf_state; + } + + enic_mbox_init(enic); + + enic->num_vfs =3D num_vfs; + + err =3D pci_enable_sriov(enic->pdev, num_vfs); + if (err) { + netdev_err(enic->netdev, + "pci_enable_sriov failed: %d\n", err); + goto close_admin; + } + + enic->priv_flags |=3D ENIC_SRIOV_ENABLED; + return num_vfs; + +close_admin: + enic->num_vfs =3D 0; + enic_admin_channel_close(enic); +free_vf_state: + kfree(enic->vf_state); + enic->vf_state =3D NULL; + return err; +} + +static void enic_sriov_v2_disable(struct enic *enic) +{ + pci_disable_sriov(enic->pdev); + enic_admin_channel_close(enic); + kfree(enic->vf_state); + enic->vf_state =3D NULL; + enic->num_vfs =3D 0; + enic->priv_flags &=3D ~ENIC_SRIOV_ENABLED; +} + +static int __maybe_unused +enic_sriov_configure(struct pci_dev *pdev, int num_vfs) +{ + struct net_device *netdev =3D pci_get_drvdata(pdev); + struct enic *enic =3D netdev_priv(netdev); + struct enic_port_profile *pp; + int err; + + if (num_vfs > 0) { + if (enic->config.mq_subvnic_count) { + netdev_err(netdev, + "SR-IOV not supported with multi-queue sub-vnics\n"); + return -EOPNOTSUPP; + } + + if (enic->vf_type =3D=3D ENIC_VF_TYPE_NONE) { + netdev_err(netdev, + "SR-IOV not supported on this firmware version\n"); + return -EOPNOTSUPP; + } + + if (enic->vf_type =3D=3D ENIC_VF_TYPE_V2) + return enic_sriov_v2_enable(enic, num_vfs); + + pp =3D kcalloc(num_vfs, sizeof(*pp), GFP_KERNEL); + if (!pp) + return -ENOMEM; + + err =3D pci_enable_sriov(pdev, num_vfs); + if (err) { + kfree(pp); + return err; + } + + kfree(enic->pp); + enic->pp =3D pp; + enic->num_vfs =3D num_vfs; + enic->priv_flags |=3D ENIC_SRIOV_ENABLED; + return num_vfs; + } + + if (!enic_sriov_enabled(enic)) + return 0; + + if (enic->vf_type =3D=3D ENIC_VF_TYPE_V2) { + enic_sriov_v2_disable(enic); + return 0; + } + + pci_disable_sriov(pdev); + enic->num_vfs =3D 0; + enic->priv_flags &=3D ~ENIC_SRIOV_ENABLED; + + kfree(enic->pp); + enic->pp =3D kzalloc_obj(*enic->pp, GFP_KERNEL); + if (!enic->pp) + return -ENOMEM; + + return 0; +} #endif =20 static int enic_probe(struct pci_dev *pdev, const struct pci_device_id *en= t) @@ -2787,12 +2905,18 @@ static int enic_probe(struct pci_dev *pdev, const s= truct pci_device_id *ent) goto err_out_vnic_unregister; =20 #ifdef CONFIG_PCI_IOV - /* Get number of subvnics */ + enic_sriov_detect_vf_type(enic); + + /* Auto-enable SR-IOV if VFs were pre-configured (e.g. at boot). + * V2 VFs require the admin channel, which is not yet set up at probe + * time; use sysfs (enic_sriov_configure) to enable V2 SR-IOV instead. + */ pos =3D pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_SRIOV); if (pos) { pci_read_config_word(pdev, pos + PCI_SRIOV_TOTAL_VF, &enic->num_vfs); - if (enic->num_vfs) { + if (enic->num_vfs && + enic->vf_type !=3D ENIC_VF_TYPE_V2) { err =3D pci_enable_sriov(pdev, enic->num_vfs); if (err) { dev_err(dev, "SRIOV enable failed, aborting." @@ -2804,7 +2928,6 @@ static int enic_probe(struct pci_dev *pdev, const str= uct pci_device_id *ent) num_pps =3D enic->num_vfs; } } - enic_sriov_detect_vf_type(enic); #endif =20 /* Allocate structure for port profiles */ @@ -3033,14 +3156,16 @@ static void enic_remove(struct pci_dev *pdev) cancel_work_sync(&enic->reset); cancel_work_sync(&enic->change_mtu_work); unregister_netdev(netdev); - enic_dev_deinit(enic); - vnic_dev_close(enic->vdev); #ifdef CONFIG_PCI_IOV if (enic_sriov_enabled(enic)) { - pci_disable_sriov(pdev); - enic->priv_flags &=3D ~ENIC_SRIOV_ENABLED; + if (enic->vf_type =3D=3D ENIC_VF_TYPE_V2) + enic_sriov_v2_disable(enic); + else + pci_disable_sriov(pdev); } #endif + enic_dev_deinit(enic); + vnic_dev_close(enic->vdev); kfree(enic->pp); vnic_dev_unregister(enic->vdev); enic_iounmap(enic); diff --git a/drivers/net/ethernet/cisco/enic/enic_mbox.c b/drivers/net/ethe= rnet/cisco/enic/enic_mbox.c index 3819efc837bf..7b5635295352 100644 --- a/drivers/net/ethernet/cisco/enic/enic_mbox.c +++ b/drivers/net/ethernet/cisco/enic/enic_mbox.c @@ -553,8 +553,17 @@ int enic_mbox_vf_unregister(struct enic *enic) =20 void enic_mbox_init(struct enic *enic) { + /* mbox_lock and mbox_comp must be initialized exactly once per + * device lifetime; the PF sriov_configure path can re-enter this + * on each enable cycle where these primitives are already set up. + */ + if (!enic->mbox_initialized) { + mutex_init(&enic->mbox_lock); + init_completion(&enic->mbox_comp); + enic->mbox_initialized =3D true; + } else { + reinit_completion(&enic->mbox_comp); + } enic->mbox_msg_num =3D 0; - mutex_init(&enic->mbox_lock); - init_completion(&enic->mbox_comp); enic->admin_rq_handler =3D enic_mbox_recv_handler; } diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c b/drivers/net/ethern= et/cisco/enic/enic_pp.c index 4720a952725d..3f611e240c25 100644 --- a/drivers/net/ethernet/cisco/enic/enic_pp.c +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c @@ -25,6 +25,11 @@ int enic_is_valid_pp_vf(struct enic *enic, int vf, int *= err) if (vf !=3D PORT_SELF_VF) { #ifdef CONFIG_PCI_IOV if (enic_sriov_enabled(enic)) { + /* V2 SR-IOV uses MBOX, not port profiles */ + if (enic->vf_type =3D=3D ENIC_VF_TYPE_V2) { + *err =3D -EOPNOTSUPP; + goto err_out; + } if (vf < 0 || vf >=3D enic->num_vfs) { *err =3D -EINVAL; goto err_out; diff --git a/drivers/net/ethernet/cisco/enic/enic_res.c b/drivers/net/ether= net/cisco/enic/enic_res.c index 2b7545d6a67f..436326ace049 100644 --- a/drivers/net/ethernet/cisco/enic/enic_res.c +++ b/drivers/net/ethernet/cisco/enic/enic_res.c @@ -59,6 +59,7 @@ int enic_get_vnic_config(struct enic *enic) GET_CONFIG(intr_timer_usec); GET_CONFIG(loop_tag); GET_CONFIG(num_arfs); + GET_CONFIG(mq_subvnic_count); GET_CONFIG(max_rq_ring); GET_CONFIG(max_wq_ring); GET_CONFIG(max_cq_ring); diff --git a/drivers/net/ethernet/cisco/enic/vnic_enet.h b/drivers/net/ethe= rnet/cisco/enic/vnic_enet.h index 9e8e86262a3f..519d2969990b 100644 --- a/drivers/net/ethernet/cisco/enic/vnic_enet.h +++ b/drivers/net/ethernet/cisco/enic/vnic_enet.h @@ -21,7 +21,9 @@ struct vnic_enet_config { u16 loop_tag; u16 vf_rq_count; u16 num_arfs; - u8 reserved[66]; + u8 reserved1[32]; + u16 mq_subvnic_count; + u8 reserved2[32]; u32 max_rq_ring; // MAX RQ ring size u32 max_wq_ring; // MAX WQ ring size u32 max_cq_ring; // MAX CQ ring size --=20 2.43.0 From nobody Wed Jun 17 07:37:14 2026 Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68AD739023F; Thu, 23 Apr 2026 16:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.37.142.88 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961818; cv=none; b=J7YgNpD8lv9Wa4rwUa6PC1svgtHEo6AvHp62tDFOExPnTAbyksm9aYgWzdE4lIdtAIUDC9jCmEfu1CNrnt+C+14YsF8G+0durONplVsXF6KeXz3NpN0iuQ+cVXOaO4X8CD6UFPtHhJLtcmBKS8jffbIZwOKf7h+HFJdBkciE3gY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961818; c=relaxed/simple; bh=cI7jZFbFLsJBhYo1XIMBZP3pNISto4Ay+0utIALdpiw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fX71PtBBQC7sA9uLbJ27ufetjzG7BLu3AyOmX4bsGcAKqNxci8hYGF1fVL9mSaC6jRgYqOdQqC39sJTG5K2usSDkG9gOisjZwEpZ37ZrvgFMAUG7DvJyUHeFJqyCPUhDpy9+beymcWkqCeeKglJcKTgunWIhW/KeItaf1Swnux8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com; spf=pass smtp.mailfrom=cisco.com; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b=kvdvMCn3; arc=none smtp.client-ip=173.37.142.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cisco.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cisco.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cisco.com header.i=@cisco.com header.b="kvdvMCn3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.com; i=@cisco.com; l=6800; q=dns/txt; s=iport01; t=1776961816; x=1778171416; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=52v8GMeIYVgKWnI1pwzIX7iE/NOeEJp5lV/mDLz15dw=; b=kvdvMCn39jfEAOQSTvTQOXY0X7ZqFNOJsNFCxkaWYCSWhOE8N7yY7nHF DZfW2FCPUAtTwYLfKOvySa2tckk/Wq2ZM3StF9Fe/EFXjmF/zVLYHRDZJ H8O5nkkEEGeRYE7QVMfdyov1NwFaZq1d5ARr1Xol/pRxlc7tAcY7Hg+OE utCj1qRpr1lO0UyvLONRFFou+QmS4kG5mX8Sz3ZNCZ3tXvTGtDGmHq5aT 0OEkNtnOL32QXSFGJT+Ir/03YoVO/UVY+H/8TI+KGIAIK+lKL5uMUGU+o 6NP1qUHsFD87yFRra1GBAQtuNvwVX3h9wtbw6iwX5+GjVkbQFwXuXL28H A==; X-CSE-ConnectionGUID: p2mi/VVCR1qJ23mpS0bm1A== X-CSE-MsgGUID: ulJt6zBZSFKSzvjiBDwrFw== X-IPAS-Result: =?us-ascii?q?A0BHAgClR+pp/4//Ja1aglmCV4FPQ0mEV49TgiGeHRSBa?= =?us-ascii?q?w8BAQEPUQQBAYUGAo0sAiY0CQ4BAgQBAQEBAwIDAQEBAQEBAQEBAQELAQEFA?= =?us-ascii?q?QEBAgEHBYEOE4ZchlsCAQMjBFIQJQImAgJGEAYBEoMCgnQDs1V6fzOBAYR92?= =?us-ascii?q?UKBZAELFAGBCi6FcoJmAYFwhAY7hD8nG4FJRIEUAYJ5b4QFJYN0gmkEgxwUj?= =?us-ascii?q?x4JP4ECHANZLAFVEw0KCwcFYVIzAyAKCxISGBUCFBwTDwQWMh1wDCcSLBc0W?= =?us-ascii?q?BsHBYFLhAltFDEEIYELgyqBNoEBAwsYDUgRLDcGDhsEPQFuB4o2IA+BOAFxA?= =?us-ascii?q?Vk1QjkyDzIlFQgtRZJjg36NXWuBNZ9ZhCaBZKAOATKXZpMFmQYio15ZhGiBa?= =?us-ascii?q?DyBWTMaCBsVgyJTGQ+OLRYcyHImMj8HAgcOApFzBIF5AQE?= IronPort-Data: A9a23:8tYqhaDqxx0IBhVW/+niw5YqxClBgxIJ4kV8jS/XYbTApG8mgTQFz zcaXD3Xaf+MajT1f9AgYYjj/R8H65WBnd82OVdlrnsFo1CmBibm6XV1Cm+qYkt+++WaFBoPA /02M4eGdIZvCCeA+n9BC5C5xVFkz6aEW7HgP+DNPyF1VGdMRTwo4f5Zs7ZRbrVA357jWGthh fuo+5eBYAP/gGYvWo4pw/vrRC1H7ayaVAww5jTSVdgT1HfCmn8cCo4oJK3ZBxPQXolOE+emc P3Ixbe/83mx109F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq+kTe5p0G2M80Mi+7vdkmc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzXWX6aSuI0P6n3TE269rDQYIA6Yio/9VWzpL7 cdAIjVUR0XW7w626OrTpuhEnM8vKozveYgYoHwllW+fBvc9SpeFSKLPjTNa9G5v3YYVQrCEO pdfMGY0BPjDS0Un1lM/E5sinfyohXnXeDxDo1XTrq0yi4TW5FMrgeO8YIuFJrRmQ+1ImmSE+ HDszV/XISoIKt6e4xaa6Fyz07qncSTTHdh6+KeD3vJjnlCW7mAaFhATUVy1vb+/h1LWc99TN kkd6Ccyhac180OvQ5/2WBjQiH2ZtBc0WNdKFeA+rgaXxcL86gCVHGUbDThMdNArqucyWDosk FSJ9/vxDDZitry9U3+R9r6I6zi1PEA9KW4EeD9BTgYf5dTniJ88gwiJTdt5FqOxyNrvFlnYx T2WoCUgr6scgNRN1Kih+13DxTW2qfD0ohUd/A7bWCehqwh+foPgP9Lu4lnA5vEGJ4GcJrWcg EU5dwGlxLhmJfmweOalGo3hwJnBCy65DQDh IronPort-HdrOrdr: A9a23:0ZQsZqtclVzTl60Iw0ODy+je7skDgNV00zEX/kB9WHVpmwKj5q STdZMgtCMc6Qx+ZJhOo7290cW7K080sKQFg7X5Xo3MYOCZgguVxehZhOOI/9SjIVycygc378 tdmsZFebjNJGk/oMrk7Ay/Cto6hPuK4MmT9J7j5kYoYA10Z6Rn9gtjTjyaHEp/WRVcCfMCZf yhD7J81l2dUEVSSNinDX8YWOWGjdjKmJX6JSMiPXccmXGzZffC0s+BL/BetS1uKA9y/Q== X-Talos-CUID: =?us-ascii?q?9a23=3AJzzgD2sj+pv121OgYQl4HlCC6Is9KHjci0nuCHX?= =?us-ascii?q?hEEQzE7iNcgea/fpNxp8=3D?= X-Talos-MUID: 9a23:7GOKLQQe2JH+LNPTRXTxgBN+atVC0Z+AK3sfj5cHkeWbLwJvbmI= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.23,195,1770595200"; d="scan'208";a="729398984" Received: from rcdn-l-core-06.cisco.com ([173.37.255.143]) by alln-iport-1.cisco.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 23 Apr 2026 16:29:09 +0000 Received: from [127.0.0.1] (unknown [10.25.128.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by rcdn-l-core-06.cisco.com (Postfix) with ESMTPS id A5F5C18000279; Thu, 23 Apr 2026 16:29:08 +0000 (GMT) From: Satish Kharat Date: Thu, 23 Apr 2026 09:28:11 -0700 Subject: [PATCH net-next v5 10/10] enic: add V2 VF probe with admin channel and PF registration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-enic-sriov-v2-admin-channel-v2-v5-10-caa9f504a3dc@cisco.com> References: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> In-Reply-To: <20260423-enic-sriov-v2-admin-channel-v2-v5-0-caa9f504a3dc@cisco.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 20260401-enic-sriov-v2-prep-v4-0-d5834b2ef1b9@cisco.com, Satish Kharat X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776961741; l=6994; i=satishkh@cisco.com; h=from:subject:message-id; bh=cI7jZFbFLsJBhYo1XIMBZP3pNISto4Ay+0utIALdpiw=; b=OS0MIvdNZKuYbOdk2Xsb/nIZiCARyosMHgbXqCxsqik0S+ng83d5izA2r3yOb3HQpbBd453mH nZLBXnzqJvDCDxmdSagxFusvrIFyM6b2PUIXuWJGLazUZ8o8/sq3jHE X-Developer-Key: i=satishkh@cisco.com; a=ed25519; pk=4BxbLoCGvHeIMH/PbpiNVx8/2IcTjFvqcr0AD8K6WLY= X-Outbound-Client-TLS: ANONYMOUS;unknown [10.25.128.216];TLSv1.3;TLS_AES_256_GCM_SHA384;256 X-Outbound-SMTP-Client: 10.25.128.216, [10.25.128.216] X-Outbound-Node: rcdn-l-core-06.cisco.com When a V2 SR-IOV VF probes, open the admin channel, initialize the MBOX protocol, perform the capability check with the PF, and register with the PF. This establishes the PF-VF communication path that the PF uses to send link state notifications. The admin channel and MBOX registration happen after enic_dev_init() (which discovers admin channel resources) and before register_netdev() so the VF is fully initialized before the interface is visible to userspace. The admin channel is opened before enic_mbox_init() installs the receive handler. This is safe because enic_admin_rq_cq_service() checks admin_rq_handler before enqueuing received buffers, so any interrupt that fires between open and mbox_init is harmlessly discarded. On remove, the VF unregisters from the PF and closes its admin channel before tearing down data path resources. V2 VFs are not provisioned with an RES_TYPE_SRIOV_INTR resource by firmware, so bypass that check in the admin channel capability detection for V2 VFs. The PF still requires this resource. Signed-off-by: Satish Kharat --- drivers/net/ethernet/cisco/enic/enic.h | 1 + drivers/net/ethernet/cisco/enic/enic_main.c | 77 +++++++++++++++++++++++++= +++- drivers/net/ethernet/cisco/enic/enic_res.c | 3 +- 3 files changed, 78 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic.h b/drivers/net/ethernet/= cisco/enic/enic.h index 70bb8cb9fe42..6f1cd110c670 100644 --- a/drivers/net/ethernet/cisco/enic/enic.h +++ b/drivers/net/ethernet/cisco/enic/enic.h @@ -442,6 +442,7 @@ void enic_reset_addr_lists(struct enic *enic); int enic_sriov_enabled(struct enic *enic); int enic_is_valid_vf(struct enic *enic, int vf); int enic_is_dynamic(struct enic *enic); +int enic_is_sriov_vf_v2(struct enic *enic); void enic_set_ethtool_ops(struct net_device *netdev); int __enic_set_rsskey(struct enic *enic); void enic_ext_cq(struct enic *enic); diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethe= rnet/cisco/enic/enic_main.c index 057716ccc283..eaf7c5640b7e 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -316,6 +316,11 @@ static int enic_is_sriov_vf(struct enic *enic) enic->pdev->device =3D=3D PCI_DEVICE_ID_CISCO_VIC_ENET_VF_V2; } =20 +int enic_is_sriov_vf_v2(struct enic *enic) +{ + return enic->pdev->device =3D=3D PCI_DEVICE_ID_CISCO_VIC_ENET_VF_V2; +} + int enic_is_valid_vf(struct enic *enic, int vf) { #ifdef CONFIG_PCI_IOV @@ -2157,6 +2162,13 @@ static void enic_reset(struct work_struct *work) enic_set_api_busy(enic, true); =20 enic_stop(enic->netdev); + /* CMD_SOFT_RESET disables all hardware queues including the + * admin channel queues (admin_wq, admin_rq, admin_cq). The + * recovery path below only reinitializes the data path queues. + * If the admin channel was active (V2 SR-IOV), it will be left + * in a disabled state after soft reset. Full admin channel + * recovery is planned as a future enhancement. + */ enic_dev_soft_reset(enic); enic_reset_addr_lists(enic); enic_init_vnic_resources(enic); @@ -2992,6 +3004,38 @@ static int enic_probe(struct pci_dev *pdev, const st= ruct pci_device_id *ent) goto err_out_dev_close; } =20 + /* V2 VF: open admin channel and register with PF. + * Must happen before register_netdev so the VF is fully + * initialized before the interface is visible to userspace. + * + * admin_channel_open() runs before enic_mbox_init() installs + * the receive handler. This is safe because + * enic_admin_rq_cq_service() checks admin_rq_handler before + * enqueuing any received buffer, so interrupts that fire + * between open and mbox_init are harmlessly discarded. + */ + if (enic_is_sriov_vf_v2(enic)) { + err =3D enic_admin_channel_open(enic); + if (err) { + dev_err(dev, + "Failed to open admin channel: %d\n", err); + goto err_out_dev_deinit; + } + enic_mbox_init(enic); + err =3D enic_mbox_vf_capability_check(enic); + if (err) { + dev_err(dev, + "MBOX capability check failed: %d\n", err); + goto err_out_admin_close; + } + err =3D enic_mbox_vf_register(enic); + if (err) { + dev_err(dev, + "MBOX VF registration failed: %d\n", err); + goto err_out_admin_close; + } + } + netif_set_real_num_tx_queues(netdev, enic->wq_count); netif_set_real_num_rx_queues(netdev, enic->rq_count); =20 @@ -3016,7 +3060,7 @@ static int enic_probe(struct pci_dev *pdev, const str= uct pci_device_id *ent) err =3D enic_set_mac_addr(netdev, enic->mac_addr); if (err) { dev_err(dev, "Invalid MAC address, aborting\n"); - goto err_out_dev_deinit; + goto err_out_admin_close; } =20 enic->tx_coalesce_usecs =3D enic->config.intr_timer_usec; @@ -3114,11 +3158,23 @@ static int enic_probe(struct pci_dev *pdev, const s= truct pci_device_id *ent) err =3D register_netdev(netdev); if (err) { dev_err(dev, "Cannot register net device, aborting\n"); - goto err_out_dev_deinit; + goto err_out_admin_close; } =20 return 0; =20 +err_out_admin_close: + if (enic_is_sriov_vf_v2(enic)) { + if (enic->vf_registered) { + int unreg_err =3D enic_mbox_vf_unregister(enic); + + if (unreg_err) + netdev_warn(netdev, + "Failed to unregister from PF: %d\n", + unreg_err); + } + enic_admin_channel_close(enic); + } err_out_dev_deinit: enic_dev_deinit(enic); err_out_dev_close: @@ -3155,6 +3211,23 @@ static void enic_remove(struct pci_dev *pdev) =20 cancel_work_sync(&enic->reset); cancel_work_sync(&enic->change_mtu_work); + + /* Close the admin channel and unregister from the PF before + * unregister_netdev() to prevent a late PF notification from + * touching a netdev that has been freed. + */ + if (enic_is_sriov_vf_v2(enic)) { + if (enic->vf_registered) { + int unreg_err =3D enic_mbox_vf_unregister(enic); + + if (unreg_err) + netdev_warn(netdev, + "Failed to unregister from PF: %d\n", + unreg_err); + } + enic_admin_channel_close(enic); + } + unregister_netdev(netdev); #ifdef CONFIG_PCI_IOV if (enic_sriov_enabled(enic)) { diff --git a/drivers/net/ethernet/cisco/enic/enic_res.c b/drivers/net/ether= net/cisco/enic/enic_res.c index 436326ace049..74cd2ee3af5c 100644 --- a/drivers/net/ethernet/cisco/enic/enic_res.c +++ b/drivers/net/ethernet/cisco/enic/enic_res.c @@ -211,7 +211,8 @@ void enic_get_res_counts(struct enic *enic) vnic_dev_get_res_count(enic->vdev, RES_TYPE_ADMIN_RQ) >=3D 1 && vnic_dev_get_res_count(enic->vdev, RES_TYPE_ADMIN_CQ) >=3D ARRAY_SIZE(enic->admin_cq) && - vnic_dev_get_res_count(enic->vdev, RES_TYPE_SRIOV_INTR) >=3D 1; + (enic_is_sriov_vf_v2(enic) || + vnic_dev_get_res_count(enic->vdev, RES_TYPE_SRIOV_INTR) >=3D 1); =20 dev_info(enic_get_dev(enic), "vNIC resources avail: wq %d rq %d cq %d intr %d admin %s\n", --=20 2.43.0