From nobody Wed Jun 17 04:06:23 2026 Received: from smtp64.iad3b.emailsrvr.com (smtp64.iad3b.emailsrvr.com [146.20.161.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B09D71E5724 for ; Wed, 22 Apr 2026 16:26:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=146.20.161.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776875220; cv=none; b=Dum6mECz0L0lC+X5+8GKA+1YgWvtR4jG6WimBXCgcxDG7AEqk1bgvY/qAzqDPV9TaB6+LcJCb0j8nyaAA2sN2TuI4gzrnTpB9I/KvYBgNSygfJcJSngDLLfU4E/n5ukv3kT9M9KwvG2jeBiylzwvPVkWyoqFmpjFAmbd8MP88TM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776875220; c=relaxed/simple; bh=S59iJjrqhOSuUnxWTcUSlTMa7Ptk+uqsO9OXA3gu1Sk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fhy4mBSvHdELMlk1k50ORI8kfJ2Ob/kPKd+rIKlrBmG3jfdy7F0VbaMFoLkiX4sZ+Cpydgo3ZppqCRSE+uJcrdBhXHwpcFbZkNgzSmLjorAltQYCmgNy4XYYg5Ee6P6LuIzjUrYPwEEr+4AxnMuR5QulHAtT2P/SizEv+gGYmXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=zT6/E1P4; arc=none smtp.client-ip=146.20.161.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="zT6/E1P4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1776874908; bh=S59iJjrqhOSuUnxWTcUSlTMa7Ptk+uqsO9OXA3gu1Sk=; h=From:To:Subject:Date:From; b=zT6/E1P4pyyMV9id1fKEd7GE82xEckMP5doAmJutB2VH66T1fnp6Dag1aZObPP+Rf /2unj7sXDYzY8lgA4Sgf1D9zl7kNITkMoVHn7YOx6aLsJPbfS/n5PkbHqT9ym9q8wI sat7V7Y+ALYgNEMbENy/QXFopk5dex7hYRl6B8UI= X-Auth-ID: abbotti@mev.co.uk Received: by smtp17.relay.iad3b.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 74FD0A03D1; Wed, 22 Apr 2026 12:21:47 -0400 (EDT) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten , stable@vger.kernel.org Subject: [PATCH v2] comedi: comedi_test: fix check for valid scan_begin_src in waveform_ai_cmdtest() Date: Wed, 22 Apr 2026 17:21:19 +0100 Message-ID: <20260422162138.36003-1-abbotti@mev.co.uk> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260422152600.32992-1-abbotti@mev.co.uk> References: <20260422152600.32992-1-abbotti@mev.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 4edc342a-7b8a-4e3d-bbc9-bc4d11aab71e-1-1 Content-Type: text/plain; charset="utf-8" Commit 783ddaebd397 ("staging: comedi: comedi_test: support scan_begin_src =3D=3D TRIG_FOLLOW") neglected to add a test that `scan_begin_src` has only one bit set. The allowed values are `TRIG_FOLLOW` and `TRIG_TIMER`, but the code incorrectly also allows `TRIG_FOLLOW | TRIG_TIMER`. Add a call to `comedi_check_trigger_is_unique()` to check that only one trigger source bit is set. Fixes: 783ddaebd397 ("staging: comedi: comedi_test: support scan_begin_src = =3D=3D TRIG_FOLLOW") Cc: Signed-off-by: Ian Abbott --- v2: Correct Cc address staging@ -> stable@ --- drivers/comedi/drivers/comedi_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/comedi/drivers/comedi_test.c b/drivers/comedi/drivers/= comedi_test.c index 01aafce20ef8..f586441d5981 100644 --- a/drivers/comedi/drivers/comedi_test.c +++ b/drivers/comedi/drivers/comedi_test.c @@ -274,6 +274,7 @@ static int waveform_ai_cmdtest(struct comedi_device *de= v, /* Step 2a : make sure trigger sources are unique */ =20 err |=3D comedi_check_trigger_is_unique(cmd->convert_src); + err |=3D comedi_check_trigger_is_unique(cmd->scan_begin_src); err |=3D comedi_check_trigger_is_unique(cmd->stop_src); =20 /* Step 2b : and mutually compatible */ --=20 2.53.0