From nobody Wed Jun 17 04:20:19 2026 Received: from smtp84.ord1d.emailsrvr.com (smtp84.ord1d.emailsrvr.com [184.106.54.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF34C1A5B90 for ; Wed, 22 Apr 2026 15:31:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=184.106.54.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776871908; cv=none; b=n+mer8qj3bGItwjJZy9mjIdpFNzL4R822md2L6g3NP2FAPI07pxH6j/68VHzyzPJjIox6A0CBXmKdbNsJNNXomY7IwR4cf8zFzvuUSr3rQa5+2W0LTFI2Gy8vcaNs7U7R7Eu6cqYCn6fkqaS6RbSdgpDSngIYd8x9l/hbNjEvfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776871908; c=relaxed/simple; bh=gWXPnKEiU1h++L2hu1f5RR1ocEgfCE0/2ZbX07ASa4g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ICoH7JGBdCQOk73tthjLpiljFovePj4THNfK/EezeCjen530NpKlDBsk7IoTeVezrQfy4VT3nxGb38z1jcSTXFvbCZoRow2k85lt47gFrDWimSm6agl86L0gl6DT7mZcasXiJ7n05oavqJ4BLnl/qchVCJniG25XHPAl9J2S22Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk; spf=pass smtp.mailfrom=mev.co.uk; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b=F2ZoN0VM; arc=none smtp.client-ip=184.106.54.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mev.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mev.co.uk header.i=@mev.co.uk header.b="F2ZoN0VM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1776871576; bh=gWXPnKEiU1h++L2hu1f5RR1ocEgfCE0/2ZbX07ASa4g=; h=From:To:Subject:Date:From; b=F2ZoN0VM2awFt1XLlbI0G2GygTLaHB0RDg86k7gTH6f+0AWESKXijlukSGM/9QUa1 FWtq+GydsBqvfqnnsG0hro1qTZegX+caX/N9EQhwjc8MU/kb0DUyb8odgOzDq2/Omy egpcaRoA17Q9hT6MtnQrHrbkntnI4BgejBmbWj6U= X-Auth-ID: abbotti@mev.co.uk Received: by smtp19.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 540AC6021F; Wed, 22 Apr 2026 11:26:15 -0400 (EDT) From: Ian Abbott To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten , staging@vger.kernel.org Subject: [PATCH] comedi: comedi_test: fix check for valid scan_begin_src in waveform_ai_cmdtest() Date: Wed, 22 Apr 2026 16:26:00 +0100 Message-ID: <20260422152600.32992-1-abbotti@mev.co.uk> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Classification-ID: 8c4e4a74-cd04-4dd2-bbab-7b61506c4d1d-1-1 Content-Type: text/plain; charset="utf-8" Commit 783ddaebd397 ("staging: comedi: comedi_test: support scan_begin_src =3D=3D TRIG_FOLLOW") neglected to add a test that `scan_begin_src` has only one bit set. The allowed values are `TRIG_FOLLOW` and `TRIG_TIMER`, but the code incorrectly also allows `TRIG_FOLLOW | TRIG_TIMER`. Add a call to `comedi_check_trigger_is_unique()` to check that only one trigger source bit is set. Fixes: 783ddaebd397 ("staging: comedi: comedi_test: support scan_begin_src = =3D=3D TRIG_FOLLOW") Cc: Signed-off-by: Ian Abbott --- drivers/comedi/drivers/comedi_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/comedi/drivers/comedi_test.c b/drivers/comedi/drivers/= comedi_test.c index 01aafce20ef8..f586441d5981 100644 --- a/drivers/comedi/drivers/comedi_test.c +++ b/drivers/comedi/drivers/comedi_test.c @@ -274,6 +274,7 @@ static int waveform_ai_cmdtest(struct comedi_device *de= v, /* Step 2a : make sure trigger sources are unique */ =20 err |=3D comedi_check_trigger_is_unique(cmd->convert_src); + err |=3D comedi_check_trigger_is_unique(cmd->scan_begin_src); err |=3D comedi_check_trigger_is_unique(cmd->stop_src); =20 /* Step 2b : and mutually compatible */ --=20 2.53.0