From nobody Wed Jun 17 04:05:56 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5C1331203 for ; Wed, 22 Apr 2026 15:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776871218; cv=none; b=f8mYMmbKIo04rOpirh370AiIqP0LVJ/j84dSpl7BdgLcSHE+JnDTsrIe/oD0hxFSruZJFfgDuEXbw8KUap7Sk/5mJjKUMywnUlsLCpCkJDqenA3hH9EoNfwHjPEAZqnnbSQS5Lf+KGBf+DlEEGAfuMumqq/ryH7iF1Ai16AV2Fs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776871218; c=relaxed/simple; bh=Fkl1SV9WILCI6yMzgo3XLHp/BoA7AbeR6AtxCtdM2RE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SPTHQ+RbNEFq7kBZCvAeyKZW8svb/IfN/b71ZPdFHVUSH5+lN2hRXeG7zaZ5eWjQXS1xlQhmAODKm/yx4aRKrUVW8TzU3BZM7lXuqS9pZYayCJ7ti2tFbiOjkF+0a7IgAntmfzEOuTXMF/7rEOD3D3QiwWtfZmw731WcrSZHvpA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FzK7IFiT; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FzK7IFiT" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-358ed696623so2553829a91.0 for ; Wed, 22 Apr 2026 08:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776871217; x=1777476017; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mpADVbbEyRcC013EcwNYOEROazEKbDHQ+rdZfvkNU4U=; b=FzK7IFiTuJ5TnFMnyG+1nu6SWciqt/uJ6iRVi6Nh99wdC6LJTRuMUPZdYYGvuP1iLZ uE1ImlQQmcrqf+cRIVdFwD5L+4eNSeG2ngX0uzgSmooU6ltNcSYsj8OuQQrKusSVphMx ZdsgJpqQQeZOcrpM74wDNU6vkzmg97tikJBLDg5NINgp32e5aOfQtuT8eim41X7txPJc 9GDlDKvDXEF/3EhUHLer+GfpQwzpbXy0U8KXfr4S6OqpPrAPNYZPL3PejfzNoSA6nUCL XP8t4k8hmH2gOB0T49Juy0odsiqDdR20gKZxfdzm/uYQBEs+hyLP5gbB8qx6WBvZ50qW Ko5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776871217; x=1777476017; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mpADVbbEyRcC013EcwNYOEROazEKbDHQ+rdZfvkNU4U=; b=iopVoJ+kyfVp438yo0atluHmCohPkeGhPI4++KWzJg+GpWtJDbNptOKhsuACX2vvB0 60Av2ZwdNm6agTLFa3UuaaNGmfN5cNAGKs0ulyogDJAz9Aio41H4KjNiPyd7Hj4qG7pd yuplW9fJrNvX+ZQYqrxQlQzflVeM7vS+NV2uiAbumMlfD9DslckLwYf7ZpH/LjIfsfHX 0dZqGuaxd8RQ/gDHt73MvBWOwBezF2fHXeFMbUy1+qrVEEX1Fb0/tLdCBsh/SDFxrpu8 41GaMDXeEYoof/HFxGSVjDjHpOHHU8AIcgzN08RAIlIStTZGALLFihbDeK/NGM/szdnB W45g== X-Gm-Message-State: AOJu0YxwmLGdMyCd3d24XEIARYIzRyy39x5NTbKbTAcc1957ZNsWjgyp k+n8sfFGfsZi7UL3tZTvaNyqUJm1u56P5ozGbvBBsD4GKQiwp/xY5vxX X-Gm-Gg: AeBDievm4Gmnner9KZ+gQeAQIidJt2vmvY5WhQt7H4mg9dF+CNCt712RxHWUj/XYkZO A8lz+aTBTTLeH3C9IwPilYwCSLIzBGC0PpO1sKO+Pnhzz7WCPzH3HSyEJf7HnHSKtP4kVXTarHG 2joP07+4Vc3yQpLAQbp5ifcrVZYp+6LB9N6HF0E2abzNC5UwgMOZYe5jPF/Op64NzrCHO/UrIZ8 pdem8jG6Y74ouBWxTLnBOet+trL2m3FIr92XgMwBf2vVrDNLdPzoxLCgedUzcYsOg1HW9VwMXmB zCKU1H0yzv3n8TMegVpfIqPL0xxjzdNQvMKffwjC/7HCF7Mare2OeXG90bvzRRcbIsBrKZQHzui A5sNMffX9cX9rXZnkiU8uqWLsjFF8rWRg1c7CvyHlNWBQYB2o2kTR3UQxB6ni3LPjgnoLlYhFBq o9NK5ncDVzVBgrAOE8b0Qxbqd21l2HmvaYvR38jBKX1Sd6CvhBdJpg4tS5PA== X-Received: by 2002:a17:90b:3504:b0:35f:bb33:d727 with SMTP id 98e67ed59e1d1-36140478be0mr23014095a91.20.1776871216850; Wed, 22 Apr 2026 08:20:16 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.246]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614186a52csm21748605a91.4.2026.04.22.08.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 08:20:16 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Konstantin Komarov Cc: linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] fs/ntfs3: fix syncing wrong inode on DIRSYNC cross-directory rename Date: Wed, 22 Apr 2026 23:20:10 +0800 Message-ID: <20260422152010.205694-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ntfs3_rename(), when IS_DIRSYNC(new_dir) is true, the code syncs the renamed file inode instead of the target directory new_dir: if (IS_DIRSYNC(new_dir)) ntfs_sync_inode(inode); /* should be new_dir */ DIRSYNC requires that directory metadata changes are written to disk synchronously. Since new_dir was modified (a new directory entry was added), it is new_dir that must be synced to satisfy the guarantee, not the renamed file itself. This bug has existed since the initial ntfs3 implementation and was carried through the refactoring in commit 78ab59fee07f ("fs/ntfs3: Rework file operations"). Fix by syncing new_dir instead of inode. Fixes: 4342306f0f0d ("fs/ntfs3: Add file operations and implementation") Signed-off-by: Zhan Xusheng --- fs/ntfs3/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c index b2af8f695e60..64cde1a856f4 100644 --- a/fs/ntfs3/namei.c +++ b/fs/ntfs3/namei.c @@ -340,7 +340,7 @@ static int ntfs_rename(struct mnt_idmap *idmap, struct = inode *dir, ntfs_sync_inode(dir); =20 if (IS_DIRSYNC(new_dir)) - ntfs_sync_inode(inode); + ntfs_sync_inode(new_dir); } =20 if (dir_ni !=3D new_dir_ni) --=20 2.43.0