From nobody Wed Jun 17 04:14:47 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DE093E8C7D for ; Wed, 22 Apr 2026 13:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776864103; cv=none; b=fGOPDIDETu0m/0gAWlaOPdXBSIHz6zhMME0+DBV9NDV6HRUVUA0Olvw7Hy4EHpKWlIQM2wNmr6xmVmiZ0aJEOFv50WWz9HN2u7UjEoKkmre9MoHo7zNhDkUb9rJrERt6CgbpDidSi/MEdzuPHZtCsZYDRFujYT+MRlI3/KmfK8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776864103; c=relaxed/simple; bh=H0LezHLoMZ6JOVynvqmDrdHSeozIVbP6OOlVwFb3Kkw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EwfQD93JM/DSkh2dM5boLYz5Tb04hAMIzOxp5nb3wGzK6DAbGWnQq92wXLSrTXZ8G7TsgsAoIup2mYPF4fCH3Cu2LS2lKK/SbYjxu1d5hdqkMDhCcaL9rk0PD6ztNSzbGZpWMfZ2vK6MVppRh+8YiRKvuDTVRWzUdGUhVQmnw6E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l8Vm9NH9; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l8Vm9NH9" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35d9f68d011so3574245a91.2 for ; Wed, 22 Apr 2026 06:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776864100; x=1777468900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7+lQMaCSFQoub5YPrds35ndszO408lEJtlAD9Cfjs+c=; b=l8Vm9NH9e7UkVJI4ziA1jBOLVUOHmicY/wRaqZ2vc3JixhLau0HpCxjLvYe4gNQjy8 jWnOxrTQXFghr9TRdQI8rh1SqxhNqkhBDhE4zZNvQ3Wr9Or0CzWyyncauclrzOhFjyJi UX0txi7MfqThV6uQCxYH3LlkOLihI4mHd6H+gXmdW2GmATmrLisgHNFgO26rRAgzir5X mdTN3HmsFeB99znjKboGnZ+eFY+8G9W5PY+j/lnY9gZPzxhK0mInuQRUTxgceAAFQxKS L4qZFAuCUhgeDLR5YsD/ohNdQBH58OSPvTC4rJNqXQSkvc12YUWwIVoAcb6mRAHbToNW 4ZIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776864100; x=1777468900; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7+lQMaCSFQoub5YPrds35ndszO408lEJtlAD9Cfjs+c=; b=STxnLWExeizyFRJL8mULVCTY/BEBIXuWtbgBuMfvg8Gc92X7D+oV0aWYZys93SWqos gCi1iqVKrcc8xzuAGCbyIhelWBazY5kLHOnMyrCH257AyeN3nZNImROsRgJEL0mySvnb jllmq1s0DMjAf8sIU1ZtwniHQ68iq8gVhMwVxZbeZdbgDstBJFizogoXvYRyPeINN90Z AfZyQpUo3yzvX04TgC4ZPZH882Yax2wll04bI9ePYyzLcT7nPtfBHBRu4X8m1ujikxNV h9Zs7kjBP8gj1D2KVa1vYz0UPQyGb0mJ79rTmuAD68iRFJIc0lvMRCKlZvP7TdYc6m5v oy/A== X-Forwarded-Encrypted: i=1; AFNElJ+Ose5akm3UOHdXvw1853wqRsEzIw6zrOddRso3/2SCkJf9qxUKVEIE6JEo4rmUcHFEcOpCT++YiaVkQS4=@vger.kernel.org X-Gm-Message-State: AOJu0YwCsFz5Dl+BbpoUYLG7tgkL0syMGhB8ByQV8Pnm5I6y+5ChZQxQ ag5cIscjYv/1EU0mWntzhapzBNstWdS1NrJqtBxivTRqWn8/CkHSNueP X-Gm-Gg: AeBDiesO1t5yuDAF1c5QbLtw0fBZaDo8EREWwNL5hZKNmkLOaTnBv4TMdsnutlAqeZh XDLgHq/wHADtyjkJxOGHMx+BiCcDXhdyspdl9xu8ZFozBypQBpP8fbfp5Kllx/Dp+/YCWvWffoy +6THKiDSS/DOJDeuu5iXEWaZyVeB+eLwqTmxLf2KCsVHCNfCXauQtC6Cz9K+agUy9xEovKxwEpu kI66kXnYl4d58cvt/sNywW0TAHqfN1u7AdDvHUHO0QFZWd390Nmts62++JE+OXQie0d1sulV+gv qfUvyRjYlrUymmgJqwo8HlIQH47eemqV43zTkPc4pN56EraVPrnLx/LBmDdL01fzN5d2uAqtekQ 3ZeDj64D1DEatKSqrEpooiqSwZqznbHAumqofFM0jKpEA4aD4rZdisQY2C0iyuc9zJM6CbtIqCJ mkR6jABf5jc2TlBTLjuGExfq2mYzJ+R1BrrXl8d14b30PveEOe0QLuIsX9/nKVjlfMeVsClGwhI XQk6HSfNVFmPmnzqjJ8476OZ88= X-Received: by 2002:a17:90b:4a0a:b0:35e:58d3:3284 with SMTP id 98e67ed59e1d1-361403e083bmr22784313a91.9.1776864100131; Wed, 22 Apr 2026 06:21:40 -0700 (PDT) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:383f:442d:1500:2c64:eb4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-361410a7a9fsm17046916a91.12.2026.04.22.06.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 06:21:39 -0700 (PDT) From: Deepanshu Kartikey To: mchehab@kernel.org Cc: kees@kernel.org, wsa@kernel.org, crope@iki.fi, peda@axentia.se, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+019ced393ab913002b75@syzkaller.appspotmail.com, Deepanshu Kartikey Subject: [PATCH] media: rtl2832: fix use-after-free in rtl2832_remove() Date: Wed, 22 Apr 2026 18:51:29 +0530 Message-ID: <20260422132129.24464-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cancel_delayed_work_sync() is called before i2c_mux_del_adapters() in rtl2832_remove(). While the cancel waits for any running instance of i2c_gate_work to finish, it does not prevent the timer from being rescheduled by a concurrent thread. During probe, the r820t_attach() call attempts I2C transfers through the mux adapter. These transfers go through i2c_mux_master_xfer(), which calls rtl2832_deselect() after the transfer completes, rescheduling i2c_gate_work via schedule_delayed_work(). If this transfer is still in flight when rtl2832_remove() runs, rtl2832_deselect() can reschedule i2c_gate_work after it has been cancelled, causing a use-after-free when kfree(dev) is called. Fix this by calling i2c_mux_del_adapters() before cancel_delayed_work_sync(). Once the mux adapter is unregistered, no new I2C transfers can go through it, so rtl2832_deselect() can no longer reschedule i2c_gate_work. The subsequent cancel_delayed_work_sync() is then guaranteed to be final. Fixes: cddcc40b1b15 ("[media] rtl2832: convert to use an explicit i2c mux c= ore") Reported-by: syzbot+019ced393ab913002b75@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D019ced393ab913002b75 Tested-by: syzbot+019ced393ab913002b75@syzkaller.appspotmail.com Signed-off-by: Deepanshu Kartikey --- drivers/media/dvb-frontends/rtl2832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-fron= tends/rtl2832.c index d8e1546aea5e..9898f729304a 100644 --- a/drivers/media/dvb-frontends/rtl2832.c +++ b/drivers/media/dvb-frontends/rtl2832.c @@ -1115,10 +1115,10 @@ static void rtl2832_remove(struct i2c_client *clien= t) =20 dev_dbg(&client->dev, "\n"); =20 - cancel_delayed_work_sync(&dev->i2c_gate_work); - i2c_mux_del_adapters(dev->muxc); =20 + cancel_delayed_work_sync(&dev->i2c_gate_work); + regmap_exit(dev->regmap); =20 kfree(dev); --=20 2.43.0