From nobody Wed Jun 17 03:58:18 2026 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037E83C7E1B for ; Wed, 22 Apr 2026 13:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776863027; cv=none; b=uqJqFvuvdTrWtKM4nvjreiqgL5TfrwaExpSmF4IKJiOq2HW2OSX53v9K1mQtay/UkcDIDhe6GGLsyeTk/u5+vKA4kwixGFBRiNNc+N5ZiGTsWa+K9n90nVrMn4PrR7lNl32Ooy3m/KZWAMtYGaDgoUQTilM6SJxBcUFWnA3snbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776863027; c=relaxed/simple; bh=NVp5rKRYc5QSU6T0BrJ5kTBob2N0jngaeZMRgSzkKTI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F1TKNVQdpxLKHkmEiiWEJ/xBDsNBznlcsxSJ5IyqID5UVOHI7WgDPfwel9/5Oj0CCm2v6dL9sDXdtCpGkMwb+D4E2RThjZAqo4DC/6HmtTjl1TUrwrmywX9sieIOfcX4r1WsVVoOc04nrez22Wp4shB5xCJFO97JFIshjyxttn8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g022hXn7; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g022hXn7" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ba36357195bso640565166b.0 for ; Wed, 22 Apr 2026 06:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776863024; x=1777467824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6DxlUcAzvEB7U+i5O0kj+4iBEHjE40skBjf9E+7IN5g=; b=g022hXn7mJYo98CrQVe0weyAw1cvWrg04DNbWu2Kjw5JpG5u/i9GIMxP0YTb0abKum xSZzILS83d8iA0tunQR++NxgmGUEKVlc5pau6zhf2euIIM9DELwsjiDQcB4f4+2BMAaL xDnQPf9fAZdOwyuq/onFNqGDNJ/erwjUE4Aflia+1ZpdEieFVgFbdDEUoEL+ujxpJ7cA wcd7AJwZTpY0Mv9/Stz4eSnS1FUXFXLtzqCKdWIorSgl2IPTRT/x7JcGtqZ+Ceez7yCM GXSvKV5IAJUI3AwAOa3bMKaqcAAbHXiipPQo++uel7dpwJ4gow4uvwJO4Ph73P4kw8ek bKdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776863024; x=1777467824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6DxlUcAzvEB7U+i5O0kj+4iBEHjE40skBjf9E+7IN5g=; b=GuJ+n4Os9BXgTsIHOduwNhHwhleW6YGuVX0qq+JkHf/mBsNlY/tIkeaO6NsBh4rcZb 9ukfhgoDw7Rk5EoYclAWVzprpb11yPRomUvyGnv3mqjlERdZTH8hycGHi9j04xCHnpd/ Jkz7nqT738f1GBOyRtq+V79AGlYMFy9oXsAQjdhGneNP9HkJ8djVOO7Rf7ZPQMYLwJpf cDvQpPNxVG2oYt0LfCIgpo/WBByi9wNxryP/Snx6RlzHbq7FzHdkZQ5DRDiF/upST5l8 QCsPtyWgxk9p9UabaaQorrpR0OMJzL0/q3plQY9U/lyehWRjxYkeP+3lrfh9TSJfeYIh 3S5A== X-Forwarded-Encrypted: i=1; AFNElJ+7fSI5VkGNyfLT29652ZlmJcMA1EOh7pDArimTxKcMTH7rmgKCRxeoze2uL79pCJVhlhaJ2zQOhqw7dSk=@vger.kernel.org X-Gm-Message-State: AOJu0YwA30UkPbu3j9PLg0y315rqRpfz0qGP+Y+FdvtQF5YLup5hL8qE dtMM5cSJT/NhV4S+yoSllgeHj2YKBL24EgGh/nrKNb08/58WTyWStxtJ X-Gm-Gg: AeBDieuoV19atqQ6vcUBRbxl80kmhu/fVAoqmumToeEyRRfvV6rAuD3M23pwTTZMB7S HOFuRA90P2+VESR9xQB+Rye+kxUXjW1mSYmKdeUCSC04h9FodHm4daY8xVK45aHJynVJynmaj+7 T69mhhsyNM4Zf3/a4GUTQYDip9JFA2XqOc6SFPVeg5P/3ZjBsnURYRpTTayfi5uYzCbQ25RfQ/Q EEPLDfr6dQ3iReMwz9Mjb31WsI3hplQlQnj4bGpnt+PSVsR0CHnqNC5OYBNL0x0/Rh65hEQQX4O C/rPVc9bEe165gW4Boq13Xl8W3eSrJtS+C48NFYrj00WGpYzLY92uwgsHMBFC2h2Hok9fAQHTqg yk1pXredXqxC7yvCcde1ZOp9K2UxVUDqFCUfvU0+bNeND0xVgATUNQijWfzXTaIGCfZAVcssN4B uqbmAYAXzEQ1V/G3SJwzB7hoOaLs16THvTUHuigbMuadHePNDxN+GM14Anyr5JWY8QDwm7GPu0c 1/YZpg/L5f0IKCNp6kfJ0zwAnjC3UXBJ6lDXw== X-Received: by 2002:a17:907:847:b0:b9c:a70c:d30b with SMTP id a640c23a62f3a-ba418e85407mr1112598566b.19.1776863023946; Wed, 22 Apr 2026 06:03:43 -0700 (PDT) Received: from arch-piotr.tailb7ebba.ts.net (226.55.classcom.pl. [195.150.55.226]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba4520c93c7sm531722966b.27.2026.04.22.06.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 06:03:42 -0700 (PDT) From: Piotr Zarycki To: vkuznets@redhat.com Cc: kvm@vger.kernel.org, seanjc@google.com, pbonzini@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Piotr Zarycki Subject: [PATCH v2] KVM: selftests: hyperv_tlb_flush: replace NOP loop with udelay() Date: Wed, 22 Apr 2026 15:03:07 +0200 Message-ID: <20260422130307.1171808-1-piotr.zarycki@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <87v7djgoji.fsf@redhat.com> References: <87v7djgoji.fsf@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded NOP loop with udelay() which was added to KVM selftests in commit 6b878cbb87bf ("KVM: selftests: Add guest udelay() utility for x86"). The NOP loop is CPU speed dependent while udelay() provides a deterministic delay regardless of host CPU frequency. Signed-off-by: Piotr Zarycki Reviewed-by: Vitaly Kuznetsov --- .../testing/selftests/kvm/x86/hyperv_tlb_flush.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/kvm/x86/hyperv_tlb_flush.c b/tools/tes= ting/selftests/kvm/x86/hyperv_tlb_flush.c index c542cc4762b1..4b7f089542c1 100644 --- a/tools/testing/selftests/kvm/x86/hyperv_tlb_flush.c +++ b/tools/testing/selftests/kvm/x86/hyperv_tlb_flush.c @@ -141,17 +141,6 @@ static void swap_two_test_pages(vm_paddr_t pte_gva1, v= m_paddr_t pte_gva2) *(uint64_t *)pte_gva2 =3D tmp; } =20 -/* - * TODO: replace the silly NOP loop with a proper udelay() implementation. - */ -static inline void do_delay(void) -{ - int i; - - for (i =3D 0; i < 1000000; i++) - asm volatile("nop"); -} - /* * Prepare to test: 'disable' workers by setting the expectation to '0', * clear hypercall input page and then swap two test pages. @@ -169,7 +158,7 @@ static inline void prepare_to_test(struct test_data *da= ta) wmb(); =20 /* Make sure workers have enough time to notice */ - do_delay(); + udelay(100); =20 /* Swap test page mappings */ swap_two_test_pages(data->test_pages_pte[0], data->test_pages_pte[1]); @@ -189,7 +178,7 @@ static inline void post_test(struct test_data *data, u6= 4 exp1, u64 exp2) set_expected_val((void *)data->test_pages, exp2, WORKER_VCPU_ID_2); =20 /* Make sure workers have enough time to test */ - do_delay(); + udelay(100); } =20 #define TESTVAL1 0x0101010101010101 --=20 2.53.0