From nobody Wed Jun 17 02:49:31 2026 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD6013DFC90 for ; Wed, 22 Apr 2026 12:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776861909; cv=none; b=Isjf4vdJba8sb5QzwrECFkHsqu4QxnCtHaB/iqiwddVu3N78hv594apSpJB8gYFeVgBEAoAu9lOTT1UUplD0jyUXE1eNcIzVukFuBwtspPsnNz9HqZyFVAg+N+KdPLP0MymTNZmRj8u8cni9PhuBM6ZKcMW3BSqp+hu7UwHy8yU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776861909; c=relaxed/simple; bh=abwAGso4IiQU00hdcSS+SAtlT/zYejjti4A59eyq1UI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fKCTy84OMQkxCm+BTZncOLKlpZTcbAbbWAqdAHxv1wT2Sv9wTLj5ht5D1hVTViMyTpE/wLIKtua33euIxtc496E/Redoyk0Nws/89UHUXttfxy308V0rBHUIRTP2mJf7lvZ1jWDTGUYOQ6yN5kHs86YbFSnTS8TnjnYyseLb/ZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U9ws12bH; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U9ws12bH" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-4243bf9be36so2575955fac.3 for ; Wed, 22 Apr 2026 05:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776861907; x=1777466707; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aO/SkChTK7D2rhqoVdEAZ0StdNdQJ4w+MbMIUQvwbhs=; b=U9ws12bHwzB/fgplgspcGgW2hEIrgLMvbJvNyq9j1xWDokGlx1xUugxRXWcrZ6UxAh 1K8l9AV1EA6K/CNq2kRg9B614Uyk10uHnrQwEdaeQHSFJ6wQ2tmYMzKlBhYwtMFyGKbx XGhRxX2ZjowsHMQXwN2OSTxozrsNNaDlmp4jAZLJeiHPBwSb0YTorx0hOwhDjFeBEG6H MuFNGWITxFyx6SUgb6MHIQ/xjXLc3xAR1YRLnNyemczp0XiZTvQd92z4LM2tt4OSqD+6 j/dvbzoKGSwoMm44h2phKZRtu/RWU2jLJT4516o4W+FnMaPi8atlzE3YxnVYc7D9Qq0b trLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776861907; x=1777466707; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aO/SkChTK7D2rhqoVdEAZ0StdNdQJ4w+MbMIUQvwbhs=; b=hCz/uHlk23kN9ME7gUsBlMj1Hj0kUW2rV6RHY4SQtpYH8rI0eZI7SE3cGjvzVRnYK7 aEahYaCld/uvU6M/7xgf0aleY2mctyKuCeAxzqSGfPtNOTNpXGASNeVxbk8hs0HcAM8e 5CXkwkVhZsYXmm9tP806uWvghCJ5IWjM16w6e7nfzXk2RKi2FopBlUKWAPqM8XvhIXyt NpZacU+Eoasz9pHwRagR7REPmxNXNyA/RFj/Jzo395oQBf9KrHJ4fD1DuwiONSxZjB9B Jb0WqOd/zRrEo9wUVurIUnfxXXrdrrDERWEvKmqOgkFxmTQbvsR0VbR3ejL496XPCt2r Hpew== X-Forwarded-Encrypted: i=1; AFNElJ8P2g39DV6otrbuxgMg7Qcn83LONZSklCLyEHh6OSmITowp2gOwkDWR7uAtK0zAZ2KIy2yPxJ8Pono/N0g=@vger.kernel.org X-Gm-Message-State: AOJu0YznAaf9aBo5YOmbfxtWZmvT4NXe/6friXbgt54gJMKasmvufDAK 71pxSYDqAlZVD8GKjFieJAfkbZMEU2vNmtD6n5rSUABzDhaMMa9V4hxU X-Gm-Gg: AeBDievyKoiQI7HvWz4kcXGNxPfaHg774imkQEyVZsX2yBVFd9DRDMKvXZhn60je+EQ GlopPvg0wBfps8vhiCFYfYyQ8C7qBB0DikDGQnLIZCRCIBLCR/oZRewneOCSgrXO/E9C4sSOJ4Z mrgI0H4JqIqtAX+440a8tWAaZ4WdEvPSCONOf5rJo4KjTLTXofwDm7oUOsjAwB+jKfzNMgXccCj dtfdIw9v8MJmtSLQPK9cTuxfNiF7i0+rSLi/LS6+e/y3GFK5vCeSTVdvfWZuF2qiLa03L3CVrHW TtEnn/jH77kweCxIvzshHdJGyfXEjGjfA+pgeJXd4mC3azxJAUS6A5o4y9fDNdjBbc/ELgOvhVR DPiQPo7lZQyWBoB2O6Zq0CquedqV8L10bYpwVysHLDe/PDqPK2RlwIy0z7bZ0LSUPoqxpTZtSZy k2NCWJu7yZclulSE760WRS7s1hK7dmhVOEH/CACQEgcCOeg5VMPHV/69Er0pCYyGDZwF26 X-Received: by 2002:a05:6871:e40f:b0:408:9c83:5b1a with SMTP id 586e51a60fabf-42abf254393mr14081749fac.4.1776861906740; Wed, 22 Apr 2026 05:45:06 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-42b8fe2c52bsm14478373fac.0.2026.04.22.05.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 05:45:06 -0700 (PDT) From: Maxwell Doose To: ak@it-klinger.de, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5] iio: proximity: srf08: Replace sprintf() with sysfs_emit() Date: Wed, 22 Apr 2026 07:45:05 -0500 Message-ID: <20260422124505.8875-1-m32285159@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() function calls with sysfs_emit() and sysfs_emit_at(). While the current code is fine, sysfs_emit() is preferred over sprintf(), and will help modernize the driver. Signed-off-by: Maxwell Doose Reviewed-by: Andy Shevchenko --- v2: - Fixed indenting of sysfs_emit call in function srf08_show_range_mm. - Optimized return sequence in function srf08_show_sensitivity by directly returning instead of modifying a variable and then returning. v3: - Changed indenting of sysfs_emit() call in function srf08_show_range_mm() per Andy Shevchenko's request. - Clarified commit message details. v4: - Changed sysfs_emit() call in function srf08_show_range() to be on one line to resolve issues around indentation alignment. - Clarified commit message details again. v5: - Reversed decision to put sysfs_emit() call on one line per Jonathan Cameron's request. - Fixed some of my editor's tab-spacing issues drivers/iio/proximity/srf08.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c index d7e4cc48cfbf..2ec8d0732763 100644 --- a/drivers/iio/proximity/srf08.c +++ b/drivers/iio/proximity/srf08.c @@ -226,7 +226,7 @@ static int srf08_read_raw(struct iio_dev *indio_dev, static ssize_t srf08_show_range_mm_available(struct device *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf, "[0.043 0.043 11.008]\n"); + return sysfs_emit(buf, "[0.043 0.043 11.008]\n"); } =20 static IIO_DEVICE_ATTR(sensor_max_range_available, S_IRUGO, @@ -238,8 +238,8 @@ static ssize_t srf08_show_range_mm(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct srf08_data *data =3D iio_priv(indio_dev); =20 - return sprintf(buf, "%d.%03d\n", data->range_mm / 1000, - data->range_mm % 1000); + return sysfs_emit(buf, "%d.%03d\n", + data->range_mm / 1000, data->range_mm % 1000); } =20 /* @@ -316,10 +316,10 @@ static ssize_t srf08_show_sensitivity_available(struc= t device *dev, =20 for (i =3D 0; i < data->chip_info->num_sensitivity_avail; i++) if (data->chip_info->sensitivity_avail[i]) - len +=3D sprintf(buf + len, "%d ", + len +=3D sysfs_emit_at(buf, len, "%d ", data->chip_info->sensitivity_avail[i]); =20 - len +=3D sprintf(buf + len, "\n"); + len +=3D sysfs_emit_at(buf, len, "\n"); =20 return len; } @@ -332,11 +332,8 @@ static ssize_t srf08_show_sensitivity(struct device *d= ev, { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct srf08_data *data =3D iio_priv(indio_dev); - int len; =20 - len =3D sprintf(buf, "%d\n", data->sensitivity); - - return len; + return sysfs_emit(buf, "%d\n", data->sensitivity); } =20 static ssize_t srf08_write_sensitivity(struct srf08_data *data, --=20 2.53.0