From nobody Wed Jun 17 04:06:23 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB61A3D3CF0 for ; Wed, 22 Apr 2026 12:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860774; cv=pass; b=o7d0DS0lMBDwRkeIbVE3lRldsC8fWG/6mj2RZ/Geg692k9XKk5swqiXFr/S3Uafcu14Dg/iJqFWkw02DydzPd8ftnUZZYQGUK7rz6po2ahGFn+zmVz9/11RahHQorEJX2pfo4ilw8pHDPKEd5HCQmejODXQ1zoHB1R/19sIk1no= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860774; c=relaxed/simple; bh=17ci1QC4Xe7rpHMyr9u1tbTOZr1bpowrtlFYh3Nqgsk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oFYv+r3MrBXaciRyzdqvxEnySa3Wqx4gM5iUrC8KlxIDC0brpx20Jtyo9u+I8EAgavyzuY+PWbBvehlNLycgPITNLI7e91TFnP9pDrgaXq8lRX5ovSk4VIZRUDTFHM/MT3CNg3yZSkCqDZiPJC4yTBASFgDxwiqhklHkH48g5uo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=DArBnfcq; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="DArBnfcq" ARC-Seal: i=1; a=rsa-sha256; t=1776860756; cv=none; d=zohomail.com; s=zohoarc; b=U1iPIm5sNEmi20E0mbYtl9SrXD1u5H6ikvPuhUb5aPVqhkYX1kwjpb9JVqlUI1TX/MqBHM3pY2kf3tnH6CIaDTCAeiJL1P02vqIKazpD4oTBItDytqrrZmAAjCbfR5BBKYa/Eq/XeNZ0RUzOdbEDu7VNJe7z6lsobByNnbhtKNM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776860756; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=+B/+9eBkwygGHzkwQiX0Pz0TfycjJYhHlNFkDxPPltg=; b=cmON9O/Xa0HVBOzB4bGIc+/oFDb3T0tNidsm4/K+63nX9ZSfymG50ksizKDhmDETvZN092Rw6ocVruVQtOspmfQ2npLSUGRPLLr8IuWW4yc6QfsX7GSR5KcicZ6VQIsgLsi0bEfO9awv91/ajINaivXKvCNV23tPnHWLWcsm/ug= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776860756; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=+B/+9eBkwygGHzkwQiX0Pz0TfycjJYhHlNFkDxPPltg=; b=DArBnfcqYs+913s77RzR0AcPhCJMWS91GtoCdIIqj8LP+pdDSedFL5RBm2EXgo2K WrseGpySsGexfnHGDc2RUtK/xHFuQ2WBtQy7G0b4xdNZTo+79lb+chdX7stT0jNKpN8 GE5Awbi36Fez2Iu9Xga7Kt4z0SMolmfZoWk8XrjM= Received: by mx.zohomail.com with SMTPS id 1776860754163226.7465683025158; Wed, 22 Apr 2026 05:25:54 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Subject: [PATCH v9 1/6] drm/panthor: Expose GPU page sizes to UM Date: Wed, 22 Apr 2026 13:25:28 +0100 Message-ID: <20260422122538.3117380-2-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260422122538.3117380-1-adrian.larumbe@collabora.com> References: <20260422122538.3117380-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable In future commits that will implement repeated mappings, only repeat values multiple of GPU page sizes will be tolerated. That means these values must be made known to UM. Do it through a queriable GPU info value. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_device.h | 3 +++ drivers/gpu/drm/panthor/panthor_drv.c | 8 ++++++++ drivers/gpu/drm/panthor/panthor_mmu.c | 9 ++++++++- include/uapi/drm/panthor_drm.h | 13 +++++++++++++ 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/pan= thor/panthor_device.h index 5cba272f9b4d..d856a4fe1d61 100644 --- a/drivers/gpu/drm/panthor/panthor_device.h +++ b/drivers/gpu/drm/panthor/panthor_device.h @@ -158,6 +158,9 @@ struct panthor_device { /** @csif_info: Command stream interface information. */ struct drm_panthor_csif_info csif_info; =20 + /** @mmu_info: MMU info */ + struct drm_panthor_mmu_info mmu_info; + /** @hw: GPU-specific data. */ struct panthor_hw *hw; =20 diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index 73fc983dc9b4..a8090bc4e33c 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -175,6 +175,7 @@ panthor_get_uobj_array(const struct drm_panthor_obj_arr= ay *in, u32 min_stride, _Generic(_obj_name, \ PANTHOR_UOBJ_DECL(struct drm_panthor_gpu_info, tiler_present), \ PANTHOR_UOBJ_DECL(struct drm_panthor_csif_info, pad), \ + PANTHOR_UOBJ_DECL(struct drm_panthor_mmu_info, page_size_bitmap), \ PANTHOR_UOBJ_DECL(struct drm_panthor_timestamp_info, current_timestamp)= , \ PANTHOR_UOBJ_DECL(struct drm_panthor_group_priorities_info, pad), \ PANTHOR_UOBJ_DECL(struct drm_panthor_sync_op, timeline_value), \ @@ -946,6 +947,10 @@ static int panthor_ioctl_dev_query(struct drm_device *= ddev, void *data, struct d args->size =3D sizeof(ptdev->csif_info); return 0; =20 + case DRM_PANTHOR_DEV_QUERY_MMU_INFO: + args->size =3D sizeof(ptdev->mmu_info); + return 0; + case DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO: args->size =3D sizeof(timestamp_info); return 0; @@ -966,6 +971,9 @@ static int panthor_ioctl_dev_query(struct drm_device *d= dev, void *data, struct d case DRM_PANTHOR_DEV_QUERY_CSIF_INFO: return PANTHOR_UOBJ_SET(args->pointer, args->size, ptdev->csif_info); =20 + case DRM_PANTHOR_DEV_QUERY_MMU_INFO: + return PANTHOR_UOBJ_SET(args->pointer, args->size, ptdev->mmu_info); + case DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO: ret =3D copy_struct_from_user(×tamp_info, sizeof(timestamp_info), diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index fa8b31df85c9..dad56a01c597 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -2750,7 +2750,7 @@ panthor_vm_create(struct panthor_device *ptdev, bool = for_mcu, refcount_set(&vm->as.active_cnt, 0); =20 pgtbl_cfg =3D (struct io_pgtable_cfg) { - .pgsize_bitmap =3D SZ_4K | SZ_2M, + .pgsize_bitmap =3D ptdev->mmu_info.page_size_bitmap, .ias =3D va_bits, .oas =3D pa_bits, .coherent_walk =3D ptdev->coherent, @@ -3195,6 +3195,11 @@ static void panthor_mmu_release_wq(struct drm_device= *ddev, void *res) destroy_workqueue(res); } =20 +static void panthor_mmu_info_init(struct panthor_device *ptdev) +{ + ptdev->mmu_info.page_size_bitmap =3D SZ_4K | SZ_2M; +} + /** * panthor_mmu_init() - Initialize the MMU logic. * @ptdev: Device. @@ -3207,6 +3212,8 @@ int panthor_mmu_init(struct panthor_device *ptdev) struct panthor_mmu *mmu; int ret, irq; =20 + panthor_mmu_info_init(ptdev); + mmu =3D drmm_kzalloc(&ptdev->base, sizeof(*mmu), GFP_KERNEL); if (!mmu) return -ENOMEM; diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index 0e455d91e77d..dc2704fc2829 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -246,6 +246,9 @@ enum drm_panthor_dev_query_type { /** @DRM_PANTHOR_DEV_QUERY_CSIF_INFO: Query command-stream interface info= rmation. */ DRM_PANTHOR_DEV_QUERY_CSIF_INFO, =20 + /** @DRM_PANTHOR_DEV_QUERY_MMU_INFO: Query MMU information. */ + DRM_PANTHOR_DEV_QUERY_MMU_INFO, + /** @DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO: Query timestamp information. */ DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO, =20 @@ -487,6 +490,16 @@ struct drm_panthor_timestamp_info { __u64 cpu_timestamp_nsec; }; =20 +/** + * struct drm_panthor_mmu_info - MMU information + * + * Structure grouping all queryable information relating to the MMU. + */ +struct drm_panthor_mmu_info { + /** @page_size_bitmap: Allowed page sizes */ + __u64 page_size_bitmap; +}; + /** * struct drm_panthor_group_priorities_info - Group priorities information * --=20 2.53.0 From nobody Wed Jun 17 04:06:23 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB5883D1CB2 for ; Wed, 22 Apr 2026 12:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860774; cv=pass; b=LColIbFLQ6D7WeI0Kv16aEvlCvbUr4a7CX9UlmEeLU1VvDk2DVJqRi0XeuJSy8UVDor/6nHU0+mpxLocD3iveYp4EWFEfwMXJ6PpFqzeB4BlbcYJnwybFm1RZ5ahMgLFLzqz82TGfyJl+R05wD/1Tk/1zLDgACLGwJKloy8/2S4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860774; c=relaxed/simple; bh=DKqRhcpMtnWKM9aiPhLBxNAnH1SioAk32z3FHAi7j/M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zroyq8K2vz0BgC6XlQQmzJRLs2IaOs2U8srCEEMoowhZUDkZFojkjyT8h7iAaojUNPZofWn5iT0JvldX44ro6doQ4m+G1zcB0siWK9JbeXwC0mPzqW3UWEuWc2wfZvbjk6EtuDbACklSRrqC/sKlSeQRAbBj7gYgondKRfIUf1I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=ZLBc+AA9; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="ZLBc+AA9" ARC-Seal: i=1; a=rsa-sha256; t=1776860758; cv=none; d=zohomail.com; s=zohoarc; b=WbYNxCc6JFPCbfW/tdgsN8XZJyBFxsg8en3P3UqxrdWOdO4+NbbM37KKl2SQdkyUpYxPdqAcIYghbFKoVfyJU91WGLVhmlz7Oo0iQjsWRTLiKKuJMeJ/2Hzb8ZyTfAhsIB40yM0bMWL1xLAkeCL/lSXmRJYEBRT9FyGaPedUHiE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776860758; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=pdXQf0JUF3Ul3GBd2eg5onO+xAyZIeria+FMMMSVKQA=; b=cd7Obz8Bx9AEw9pSRumoyW7YUIG6Q0O4Zw3OGosAuwEeCsMZsUroxtlU8PWXWjmwA4sIR/VsLNuuSK8PKeSI/mg5La9aYJS8naN+I7teGY3CpxIbLWuS/HKZbedYW5+CfF4RPGj2q/p4T9mP/T0sTbulNWUSEk3yC1QqCPlaJ2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776860758; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=pdXQf0JUF3Ul3GBd2eg5onO+xAyZIeria+FMMMSVKQA=; b=ZLBc+AA9/FcB85ucZprGpUXX94S+xaDQ4n2G62Hhpjs+2GQEBqrmfzRZehTMCWpT YrIbcIcPicVL6qyi7TqCs5pBEaZNbPkoCxLDW4+jeGnRVVZrZWmVy6wGjLKwf6aYeBs 8dnMnlwUjkbC5p+zOLg74pMzGpNolpnFupLJPUv8= Received: by mx.zohomail.com with SMTPS id 1776860757273780.5381964617723; Wed, 22 Apr 2026 05:25:57 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v9 2/6] drm/panthor: Pass vm_bind_op to vm_prepare_map_op_ctx Date: Wed, 22 Apr 2026 13:25:29 +0100 Message-ID: <20260422122538.3117380-3-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260422122538.3117380-1-adrian.larumbe@collabora.com> References: <20260422122538.3117380-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Instead of passing its constituent elements, pass the whole struct to simplify the function prototype. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_mmu.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index dad56a01c597..400e9652cd3b 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -1275,9 +1275,7 @@ static int panthor_vm_op_ctx_prealloc_pts(struct pant= hor_vm_op_ctx *op_ctx) static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx, struct panthor_vm *vm, struct panthor_gem_object *bo, - u64 offset, - u64 size, u64 va, - u32 flags) + const struct drm_panthor_vm_bind_op *op) { struct drm_gpuvm_bo *preallocated_vm_bo; struct sg_table *sgt =3D NULL; @@ -1286,12 +1284,12 @@ static int panthor_vm_prepare_map_op_ctx(struct pan= thor_vm_op_ctx *op_ctx, if (!bo) return -EINVAL; =20 - if ((flags & ~PANTHOR_VM_BIND_OP_MAP_FLAGS) || - (flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BIND_O= P_TYPE_MAP) + if ((op->flags & ~PANTHOR_VM_BIND_OP_MAP_FLAGS) || + (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BI= ND_OP_TYPE_MAP) return -EINVAL; =20 /* Make sure the VA and size are in-bounds. */ - if (size > bo->base.size || offset > bo->base.size - size) + if (op->size > bo->base.size || op->bo_offset > bo->base.size - op->size) return -EINVAL; =20 /* If the BO has an exclusive VM attached, it can't be mapped to other VM= s. */ @@ -1299,7 +1297,7 @@ static int panthor_vm_prepare_map_op_ctx(struct panth= or_vm_op_ctx *op_ctx, bo->exclusive_vm_root_gem !=3D panthor_vm_root_gem(vm)) return -EINVAL; =20 - panthor_vm_init_op_ctx(op_ctx, size, va, flags); + panthor_vm_init_op_ctx(op_ctx, op->size, op->va, op->flags); =20 ret =3D panthor_vm_op_ctx_prealloc_vmas(op_ctx); if (ret) @@ -1328,7 +1326,7 @@ static int panthor_vm_prepare_map_op_ctx(struct panth= or_vm_op_ctx *op_ctx, } =20 op_ctx->map.vm_bo =3D drm_gpuvm_bo_obtain_prealloc(preallocated_vm_bo); - op_ctx->map.bo_offset =3D offset; + op_ctx->map.bo_offset =3D op->bo_offset; =20 ret =3D panthor_vm_op_ctx_prealloc_pts(op_ctx); if (ret) @@ -2830,10 +2828,7 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file, gem =3D drm_gem_object_lookup(file, op->bo_handle); ret =3D panthor_vm_prepare_map_op_ctx(op_ctx, vm, gem ? to_panthor_bo(gem) : NULL, - op->bo_offset, - op->size, - op->va, - op->flags); + op); drm_gem_object_put(gem); return ret; =20 @@ -3029,10 +3024,16 @@ int panthor_vm_bind_exec_sync_op(struct drm_file *f= ile, int panthor_vm_map_bo_range(struct panthor_vm *vm, struct panthor_gem_obje= ct *bo, u64 offset, u64 size, u64 va, u32 flags) { + struct drm_panthor_vm_bind_op op =3D { + .bo_offset =3D offset, + .size =3D size, + .va =3D va, + .flags =3D flags, + }; struct panthor_vm_op_ctx op_ctx; int ret; =20 - ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, offset, size, va, = flags); + ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, &op); if (ret) return ret; =20 --=20 2.53.0 From nobody Wed Jun 17 04:06:23 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 641193D3338 for ; Wed, 22 Apr 2026 12:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860781; cv=pass; b=Hwy8C+Et2M1RISqfPTEr5FOGQex3hoZgWT+r9Ij+4ohcfHOXw4QDbxcW5JNTzrm5dNRi/DnTVpbhti9nDpuLV96zG/oF00hDqLwCJcmSAiBPaYwMX/N+pNw9YONH1nKndQYMCcXclKEpPnyq4wJk4k/JZIBSzoa/8f6p38vfQXA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860781; c=relaxed/simple; bh=FZ3lQod4xTOudbGir7X2ogSpv4SNFkpLyXZhSD0ZeAs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=T4OnPpMRbLO4mNV3UB9hy5Ntl9SKVmSN+nmHEG214dZ4y09Uwo72wWHUD1EEWXfxJXezP9t3Z+tIPIxLIndyN38nVSryO4Y1OTUe+URNY3kyFKdkHRtyrQOqXRq6C68/2junBRnn89Zm3+9mIS+m5QZRj5CM+gNNkzNT2PrE7Eo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=Fxmoci3O; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="Fxmoci3O" ARC-Seal: i=1; a=rsa-sha256; t=1776860762; cv=none; d=zohomail.com; s=zohoarc; b=gI7HQVwGoLfsRoLcSvjsYG4n2Ps7pn7WpIBXgsZSK4xbl1QNZ72YSmQcagOXEaAXYHWIKjyrGTDpK9W1WVgl0va4SdFul9NaPFLua6kQgkzNQn9DKpteaPR0idAJA6PX4QZGB/dTUFT1JCS28EQgQgxY8QQxEyq2q5x52I7YCVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776860762; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=wXWh4JTjO3XSS1HUIBp2EkkcOxlikol+FrLwQoFSZd4=; b=XPqwHuFg3zCniGTWLwfkHQ93nKMbdTjuWHjD7PBypjURs5T8j98ZFZWmB+D/FfUYtyL9XK1e3StDoRrHngO69qp4M1YxqLIn91VEWYK5hPfVrTiiqgYV1IAW92nIFV/ZedhubfYj852UrkPnTq7p2s92Zv612Jsp7/+85DrEFXM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776860762; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=wXWh4JTjO3XSS1HUIBp2EkkcOxlikol+FrLwQoFSZd4=; b=Fxmoci3OXQje69TeTWoN2D8n8ycalqOtXUq5bfGHaN6q1LrirjI+apTmCUiEUQB1 EQq/nhtEP3uCjVQSsP6CNcwsoBtBj4lS1SAb9w5y07bOF4fHsdQDbU6JVKS6lUo5/4g 3v/qdR5bFKX78ioK+Gs/iQITd+aYTrqxWyWlJnj4= Received: by mx.zohomail.com with SMTPS id 1776860760730893.8436997127039; Wed, 22 Apr 2026 05:26:00 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Daniel Almeida , Alice Ryhl , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v9 3/6] drm/panthor: Delete spurious whitespace from uAPI header Date: Wed, 22 Apr 2026 13:25:30 +0100 Message-ID: <20260422122538.3117380-4-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260422122538.3117380-1-adrian.larumbe@collabora.com> References: <20260422122538.3117380-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable There's no extra blank line after the last member of any other uAPI structures, so delete it. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- include/uapi/drm/panthor_drm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index dc2704fc2829..42c901ebdb7a 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -677,7 +677,6 @@ struct drm_panthor_vm_bind_op { * This array shall not be empty for sync-only operations. */ struct drm_panthor_obj_array syncs; - }; =20 /** --=20 2.53.0 From nobody Wed Jun 17 04:06:23 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3E63B27DB for ; Wed, 22 Apr 2026 12:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860781; cv=pass; b=Ffq2k2ZGxjE8UDui01iKSKLxlmqcSQ3fvdcN8KqyGKxiraG1liRjcTyMd1n7hImTAl2fW0ArvCmQSFhXmJGWTMYBcE5ECYi6lXKgCUDDo0+cA2psmtZ4FyKTz+4jYeX479OImrXXAVkcgunSc7S9930sTSH2hUSgJbyQHk2EgGM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860781; c=relaxed/simple; bh=WvxGYuse6EdGEdbNtaLg+rfLeQx2lwSzO3fMxmxQUsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=byUfOdbx7jvSMs0n5dKMrLbRLi4ci+6M/H/0ZIOEh6jNMkU7q4D1VvuXPuIZnypfehhSu1meSG1ui4qOvuXBk/WkDQr4qYyEAoW7HBDgWl9QY9XTP5SpP4nLmXuhGpNbutqIkBxzSXgP/dxEG1fgU7oGLL/9tMXalsEzPGm/TIM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=FRRaMcma; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="FRRaMcma" ARC-Seal: i=1; a=rsa-sha256; t=1776860764; cv=none; d=zohomail.com; s=zohoarc; b=EPLer5UUJGCpl6DtuQHlNiveY8JfRdkKE/CScL4G5F8reRRPRQjBYZszPPuMtyd4wR5jTZSLI9E7S2xnHGRofUiX1tfR2mR1rsXwWmTUmMrSLC7o6JRZUSS60NUiEveOTbProFdjM+acAa0XS4TC6iQjTEYUMQmQNn4HCdSKIsI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776860764; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=9lPuiNVrA0LM3ChHC/dFLUGUojgCyRrTYEEtP7kfHY4=; b=mUnruO7bdNloO1PEbQFbN75PzrpiBAB0Zgd8BbFtH+EN89i7v3dx+PIrzYk7VIcuc4pRaaBC919m30cWtDiSnjQgomQwMtZIiLbpR1t19opDDIiSKORZ+L3uxXT0leWt9H25g2hxsX4hyFYW8TbG7LJ+6PiHK634lFvbpvzQUz4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776860764; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=9lPuiNVrA0LM3ChHC/dFLUGUojgCyRrTYEEtP7kfHY4=; b=FRRaMcma+HfVi1G1v+5uKe0uockXTWAoiPJye3m3TMYgRljVm760svyKpiENRZwF WPEY8mD4Ijcw03FaW555WRQowT5kbpP9Vpktk2I2JlrmB2O6KyPIFrXqwAjSGZRwlQI VcziritUE7D0EzRNui8OkwDn85+MokIL+WEjTnqs= Received: by mx.zohomail.com with SMTPS id 1776860763639528.7948103669642; Wed, 22 Apr 2026 05:26:03 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v9 4/6] drm/panthor: Remove unused operation context field Date: Wed, 22 Apr 2026 13:25:31 +0100 Message-ID: <20260422122538.3117380-5-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260422122538.3117380-1-adrian.larumbe@collabora.com> References: <20260422122538.3117380-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable A Panthor BO's sgtable is now retrieved from its dmap field. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_mmu.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index 400e9652cd3b..54f7f7a8d44f 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -195,14 +195,6 @@ struct panthor_vm_op_ctx { /** @map.bo_offset: Offset in the buffer object. */ u64 bo_offset; =20 - /** - * @map.sgt: sg-table pointing to pages backing the GEM object. - * - * This is gathered at job creation time, such that we don't have - * to allocate in ::run_job(). - */ - struct sg_table *sgt; - /** @map.bo: the BO being mapped. */ struct panthor_gem_object *bo; } map; --=20 2.53.0 From nobody Wed Jun 17 04:06:23 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7463D2FFD for ; Wed, 22 Apr 2026 12:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860788; cv=pass; b=IJ6l5dfTSL6M0KINDV40dbOikIz7ecYfRWI2NLsmNc5KZ8cDeHeuACLNal/k0/doiz+EHR3HDbR4+GJvntgmL1WU7SnrgnivhuaeatGWwx2km/+lijE4tvhMLGloQUngH8rZTQUqJ6NRSlLvWi8cCsWWxFZsuYBXbEVa7PzwdZo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860788; c=relaxed/simple; bh=3Ql1iW622Tg4kzfu3ShbAiF5DR2wLjhLbHQC51AMoCY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MhbqyTQT9kB5h+PuhqYkeh/YqmADZIgD055+kFlM+tWXwJjpPdfqB9lAYjaLEZ66XxCrLpySrjZCtjVzvbuxTMld0wHDFGJtwcfd1/qZNHX1hr0I2dvb0qau2jI09eBUa/38skMNLewxFZCAS4ICrWYL0F3Utm/V+QjcDSYcgS0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=TOv4xUDK; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="TOv4xUDK" ARC-Seal: i=1; a=rsa-sha256; t=1776860768; cv=none; d=zohomail.com; s=zohoarc; b=gY6JEYte0I3g/R6lO3UeOxDTl/CyfTSHWKJ9+NpRZ9SEYj1sebcmV0fYsWz/pBeZoF6v2UWFSZMhRPWEXSa4ZgyIPMFkqnNsgAJtrJltKo+a6lxt8H5Thkyex5wxoPkpP6R5G7qziueSpB6u7C9Yq+TNFqO7PAbyJriHn3ibJxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776860768; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=4aXDbZWW2lXopSUFtkem8C/FgiqTFnMbd07l4IZVzUU=; b=jTMoFK6aIBk24y3wyY8CkBswDg+dJ+vCmB3IbkRER9Jj7GyL1uyaGjPXKuU3IuEJeT1aM6OvcxCAo6rIfeueQLgN6qD7RxtVmLaqYbQhpYrQ87YdVALNLvcgly0lZJi3Sc3aK6FOdapsMQRVNqCmrwponn9XNxLHaMsBpFLC88s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776860768; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=4aXDbZWW2lXopSUFtkem8C/FgiqTFnMbd07l4IZVzUU=; b=TOv4xUDKK7HxIWkfBD+87w8et7R7DsPqhKOgNtB4UprXkUpEghpZdGlvAqluP7K3 AjzZdBhUnahxhhMlGIDj7ovKuXG7XajvJ9GrXTZ9mPIm2koHGtPUtLaMOUc92eSkc39 Eh9kQVm3YzZbRfbB8W87kj3JPU2vEfcJF1lEYUaw= Received: by mx.zohomail.com with SMTPS id 1776860767653889.303288815062; Wed, 22 Apr 2026 05:26:07 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Subject: [PATCH v9 5/6] drm/panthor: Support sparse mappings Date: Wed, 22 Apr 2026 13:25:32 +0100 Message-ID: <20260422122538.3117380-6-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260422122538.3117380-1-adrian.larumbe@collabora.com> References: <20260422122538.3117380-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Allow UM to bind sparsely populated memory regions by cyclically mapping virtual ranges over a kernel-allocated dummy BO. This alternative is preferable to the old method of handling sparseness in the UMD, because it relied on the creation of a buffer object to the same end, despite the fact Vulkan sparse resources don't need to be backed by a driver BO. The choice of backing sparsely-bound regions with a Panhtor BO was made so as to profit from the existing shrinker reclaim code. That way no special treatment must be given to the dummy sparse BOs when reclaiming memory, as would be the case if we had chosen a raw kernel page implementation. A new dummy BO is allocated per open file context, because even though the Vulkan spec mandates that writes into sparsely bound regions must be discarded, our implementation is still a workaround over the fact Mali CSF GPUs cannot support this behaviour on the hardware level, so writes still make it into the backing BO. If we had a global one, then it could be a venue for information leaks between file contexts, which should never happen in DRM. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_gem.c | 18 +++ drivers/gpu/drm/panthor/panthor_gem.h | 2 + drivers/gpu/drm/panthor/panthor_mmu.c | 172 ++++++++++++++++++++++---- include/uapi/drm/panthor_drm.h | 12 ++ 4 files changed, 183 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/pantho= r/panthor_gem.c index 69cef05b6ef7..833153c2b080 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.c +++ b/drivers/gpu/drm/panthor/panthor_gem.c @@ -1345,6 +1345,24 @@ panthor_kernel_bo_create(struct panthor_device *ptde= v, struct panthor_vm *vm, return ERR_PTR(ret); } =20 +/** + * panthor_dummy_bo_create() - Create a Panthor BO meant to back sparse bi= ndings. + * @ptdev: Device. + * + * Return: A valid pointer in case of success, an ERR_PTR() otherwise. + */ +struct panthor_gem_object * +panthor_dummy_bo_create(struct panthor_device *ptdev) +{ + /* Since even when the DRM device's mount point has enabled THP we have n= o guarantee + * that drm_gem_get_pages() will return a single 2MiB PMD, and also we ca= nnot be sure + * that the 2MiB won't be reclaimed and re-allocated later on as 4KiB chu= nks, it doesn't + * make sense to pre-populate this object's page array, nor to fall back = on a BO size + * of 4KiB. Sticking to a dummy object size of 2MiB lets us keep things s= imple for now. + */ + return panthor_gem_create(&ptdev->base, SZ_2M, DRM_PANTHOR_BO_NO_MMAP, NU= LL, 0); +} + static bool can_swap(void) { return get_nr_swap_pages() > 0; diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/pantho= r/panthor_gem.h index ae0491d0b121..8639c2fa08e6 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.h +++ b/drivers/gpu/drm/panthor/panthor_gem.h @@ -315,6 +315,8 @@ panthor_kernel_bo_create(struct panthor_device *ptdev, = struct panthor_vm *vm, =20 void panthor_kernel_bo_destroy(struct panthor_kernel_bo *bo); =20 +struct panthor_gem_object *panthor_dummy_bo_create(struct panthor_device *= ptdev); + #ifdef CONFIG_DEBUG_FS void panthor_gem_debugfs_init(struct drm_minor *minor); #endif diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index 54f7f7a8d44f..7b91836e608d 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -112,6 +112,17 @@ struct panthor_mmu { struct panthor_vm_pool { /** @xa: Array used for VM handle tracking. */ struct xarray xa; + + /** + * @dummy: Dummy object used for sparse mappings + * + * Sparse bindings map virtual address ranges onto a dummy + * BO in a modulo fashion. Even though sparse writes are meant + * to be discarded and reads undefined, writes are still reflected + * in the dummy buffer. That means we must keep a dummy object per + * file context, to avoid data leaks between them. + */ + struct panthor_gem_object *dummy; }; =20 /** @@ -391,6 +402,16 @@ struct panthor_vm { */ struct list_head lru_node; } reclaim; + + /** + * @dummy: Dummy object used for sparse mappings. + * + * VM's must keep a reference to the file context-wide dummy BO because + * they can outlive the file context, which includes the VM pool holding + * the original dummy BO reference. + * + */ + struct panthor_gem_object *dummy; }; =20 /** @@ -1020,6 +1041,45 @@ panthor_vm_map_pages(struct panthor_vm *vm, u64 iova= , int prot, return 0; } =20 +static int +panthor_vm_map_sparse(struct panthor_vm *vm, u64 iova, int prot, + struct sg_table *sgt, u64 size) +{ + u64 start_iova =3D iova; + int ret; + + if (iova & (SZ_2M - 1)) { + u64 unaligned_size =3D min(ALIGN(iova, SZ_2M) - iova, size); + + ret =3D panthor_vm_map_pages(vm, iova, prot, sgt, + 0, unaligned_size); + if (ret) + return ret; + + size -=3D unaligned_size; + iova +=3D unaligned_size; + } + + /* TODO: we should probably optimize this at the io_pgtable level. */ + while (size > 0) { + u64 next_size =3D min(size, sg_dma_len(sgt->sgl)); + + ret =3D panthor_vm_map_pages(vm, iova, prot, + sgt, 0, next_size); + if (ret) + goto err_unmap; + + size -=3D next_size; + iova +=3D next_size; + } + + return 0; + +err_unmap: + panthor_vm_unmap_pages(vm, start_iova, iova - start_iova); + return ret; +} + static int flags_to_prot(u32 flags) { int prot =3D 0; @@ -1262,6 +1322,7 @@ static int panthor_vm_op_ctx_prealloc_pts(struct pant= hor_vm_op_ctx *op_ctx) (DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \ DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \ DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED | \ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE | \ DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) =20 static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx, @@ -1269,6 +1330,7 @@ static int panthor_vm_prepare_map_op_ctx(struct panth= or_vm_op_ctx *op_ctx, struct panthor_gem_object *bo, const struct drm_panthor_vm_bind_op *op) { + bool is_sparse =3D op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE; struct drm_gpuvm_bo *preallocated_vm_bo; struct sg_table *sgt =3D NULL; int ret; @@ -1280,8 +1342,21 @@ static int panthor_vm_prepare_map_op_ctx(struct pant= hor_vm_op_ctx *op_ctx, (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BI= ND_OP_TYPE_MAP) return -EINVAL; =20 - /* Make sure the VA and size are in-bounds. */ - if (op->size > bo->base.size || op->bo_offset > bo->base.size - op->size) + /* uAPI mandates sparsely bound regions must not be executable. */ + if (is_sparse && !(op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC)) + return -EINVAL; + + /* For non-sparse, make sure the VA and size are in-bounds. + * For sparse, this is not applicable, because the dummy BO is + * repeatedly mapped over a potentially wider VA range. + */ + if (!is_sparse && (op->size > bo->base.size || op->bo_offset > bo->base.s= ize - op->size)) + return -EINVAL; + + /* For sparse, we don't expect any user BO, the BO we get passed + * is the dummy BO attached to the VM pool. + */ + if (is_sparse && (op->bo_handle || op->bo_offset)) return -EINVAL; =20 /* If the BO has an exclusive VM attached, it can't be mapped to other VM= s. */ @@ -1543,6 +1618,9 @@ int panthor_vm_pool_create_vm(struct panthor_device *= ptdev, return ret; } =20 + drm_gem_object_get(&pool->dummy->base); + vm->dummy =3D pool->dummy; + args->user_va_range =3D kernel_va_start; return id; } @@ -1634,6 +1712,7 @@ void panthor_vm_pool_destroy(struct panthor_file *pfi= le) xa_for_each(&pfile->vms->xa, i, vm) panthor_vm_destroy(vm); =20 + drm_gem_object_put(&pfile->vms->dummy->base); xa_destroy(&pfile->vms->xa); kfree(pfile->vms); } @@ -1651,6 +1730,11 @@ int panthor_vm_pool_create(struct panthor_file *pfil= e) return -ENOMEM; =20 xa_init_flags(&pfile->vms->xa, XA_FLAGS_ALLOC1); + + pfile->vms->dummy =3D panthor_dummy_bo_create(pfile->ptdev); + if (IS_ERR(pfile->vms->dummy)) + return PTR_ERR(pfile->vms->dummy); + return 0; } =20 @@ -1968,6 +2052,9 @@ static void panthor_vm_free(struct drm_gpuvm *gpuvm) =20 free_io_pgtable_ops(vm->pgtbl_ops); =20 + if (vm->dummy) + drm_gem_object_put(&vm->dummy->base); + drm_mm_takedown(&vm->mm); kfree(vm); } @@ -2127,7 +2214,23 @@ static void panthor_vma_init(struct panthor_vma *vma= , u32 flags) #define PANTHOR_VM_MAP_FLAGS \ (DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \ DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \ - DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED) + DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED | \ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE) + +static int +panthor_vm_exec_map_op(struct panthor_vm *vm, u32 flags, + const struct drm_gpuva_op_map *op) +{ + struct panthor_gem_object *bo =3D to_panthor_bo(op->gem.obj); + int prot =3D flags_to_prot(flags); + + if (flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE) + return panthor_vm_map_sparse(vm, op->va.addr, prot, + bo->dmap.sgt, op->va.range); + + return panthor_vm_map_pages(vm, op->va.addr, prot, bo->dmap.sgt, + op->gem.offset, op->va.range); +} =20 static int panthor_gpuva_sm_step_map(struct drm_gpuva_op *op, void *priv) { @@ -2141,9 +2244,7 @@ static int panthor_gpuva_sm_step_map(struct drm_gpuva= _op *op, void *priv) =20 panthor_vma_init(vma, op_ctx->flags & PANTHOR_VM_MAP_FLAGS); =20 - ret =3D panthor_vm_map_pages(vm, op->map.va.addr, flags_to_prot(vma->flag= s), - op_ctx->map.bo->dmap.sgt, op->map.gem.offset, - op->map.va.range); + ret =3D panthor_vm_exec_map_op(vm, vma->flags, &op->map); if (ret) { panthor_vm_op_ctx_return_vma(op_ctx, vma); return ret; @@ -2159,13 +2260,16 @@ static int panthor_gpuva_sm_step_map(struct drm_gpu= va_op *op, void *priv) } =20 static bool -iova_mapped_as_huge_page(struct drm_gpuva_op_map *op, u64 addr) +iova_mapped_as_huge_page(struct drm_gpuva_op_map *op, u64 addr, bool is_sp= arse) { struct panthor_gem_object *bo =3D to_panthor_bo(op->gem.obj); const struct page *pg; pgoff_t bo_offset; =20 - bo_offset =3D addr - op->va.addr + op->gem.offset; + /* Per-VM Dummy BO in sparse mappings is always 2MiB, so checking the + * size of the very first page is enough. + */ + bo_offset =3D !is_sparse ? addr - op->va.addr + op->gem.offset : 0; pg =3D bo->backing.pages[bo_offset >> PAGE_SHIFT]; =20 return folio_size(page_folio(pg)) >=3D SZ_2M; @@ -2175,6 +2279,8 @@ static void unmap_hugepage_align(const struct drm_gpuva_op_remap *op, u64 *unmap_start, u64 *unmap_range) { + struct panthor_vma *unmap_vma =3D container_of(op->unmap->va, struct pant= hor_vma, base); + bool is_sparse =3D unmap_vma->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE; u64 aligned_unmap_start, aligned_unmap_end, unmap_end; =20 unmap_end =3D *unmap_start + *unmap_range; @@ -2186,7 +2292,7 @@ unmap_hugepage_align(const struct drm_gpuva_op_remap = *op, */ if (op->prev && aligned_unmap_start < *unmap_start && op->prev->va.addr <=3D aligned_unmap_start && - iova_mapped_as_huge_page(op->prev, *unmap_start)) { + (iova_mapped_as_huge_page(op->prev, *unmap_start, is_sparse))) { *unmap_range +=3D *unmap_start - aligned_unmap_start; *unmap_start =3D aligned_unmap_start; } @@ -2196,7 +2302,7 @@ unmap_hugepage_align(const struct drm_gpuva_op_remap = *op, */ if (op->next && aligned_unmap_end > unmap_end && op->next->va.addr + op->next->va.range >=3D aligned_unmap_end && - iova_mapped_as_huge_page(op->next, unmap_end - 1)) { + (iova_mapped_as_huge_page(op->next, *unmap_start, is_sparse))) { *unmap_range +=3D aligned_unmap_end - unmap_end; } } @@ -2231,15 +2337,27 @@ static int panthor_gpuva_sm_step_remap(struct drm_g= puva_op *op, panthor_vm_unmap_pages(vm, unmap_start, unmap_range); } =20 + /* In the following two branches, neither remap::unmap::offset nor remap:= :unmap::keep + * can be trusted to contain legitimate values in the case of sparse mapp= ings, because + * the drm_gpuvm core calculates them on the assumption that a VM_BIND op= eration's + * range is always less than the target BO. That doesn't hold in the case= of sparse + * bindings, but we don't care to adjust the BO offset of new VA's spawne= d by a remap + * operation because we ignore them altogether when sparse-mapping pages = on a HW level + * just further below. If we ever wanted to make use of remap::unmap::kee= p, then this + * logic would have to be reworked. + */ if (op->remap.prev) { - struct panthor_gem_object *bo =3D to_panthor_bo(op->remap.prev->gem.obj); u64 offset =3D op->remap.prev->gem.offset + unmap_start - op->remap.prev= ->va.addr; u64 size =3D op->remap.prev->va.addr + op->remap.prev->va.range - unmap_= start; + const struct drm_gpuva_op_map map_op =3D { + .va.addr =3D unmap_start, + .va.range =3D size, + .gem.obj =3D op->remap.prev->gem.obj, + .gem.offset =3D offset, + }; =20 - if (!unmap_vma->evicted) { - ret =3D panthor_vm_map_pages(vm, unmap_start, - flags_to_prot(unmap_vma->flags), - bo->dmap.sgt, offset, size); + if (!unmap_vma->evicted && size > 0) { + ret =3D panthor_vm_exec_map_op(vm, unmap_vma->flags, &map_op); if (ret) return ret; } @@ -2250,14 +2368,17 @@ static int panthor_gpuva_sm_step_remap(struct drm_g= puva_op *op, } =20 if (op->remap.next) { - struct panthor_gem_object *bo =3D to_panthor_bo(op->remap.next->gem.obj); u64 addr =3D op->remap.next->va.addr; u64 size =3D unmap_start + unmap_range - op->remap.next->va.addr; + const struct drm_gpuva_op_map map_op =3D { + .va.addr =3D addr, + .va.range =3D size, + .gem.obj =3D op->remap.next->gem.obj, + .gem.offset =3D op->remap.next->gem.offset, + }; =20 - if (!unmap_vma->evicted) { - ret =3D panthor_vm_map_pages(vm, addr, flags_to_prot(unmap_vma->flags), - bo->dmap.sgt, op->remap.next->gem.offset, - size); + if (!unmap_vma->evicted && size > 0) { + ret =3D panthor_vm_exec_map_op(vm, unmap_vma->flags, &map_op); if (ret) return ret; } @@ -2817,7 +2938,13 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file, =20 switch (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) { case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: - gem =3D drm_gem_object_lookup(file, op->bo_handle); + if (!(op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE)) { + gem =3D drm_gem_object_lookup(file, op->bo_handle); + } else { + gem =3D &vm->dummy->base; + drm_gem_object_get(&vm->dummy->base); + } + ret =3D panthor_vm_prepare_map_op_ctx(op_ctx, vm, gem ? to_panthor_bo(gem) : NULL, op); @@ -3025,6 +3152,9 @@ int panthor_vm_map_bo_range(struct panthor_vm *vm, st= ruct panthor_gem_object *bo struct panthor_vm_op_ctx op_ctx; int ret; =20 + if (drm_WARN_ON(&vm->ptdev->base, flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPAR= SE)) + return -EINVAL; + ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, &op); if (ret) return ret; diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index 42c901ebdb7a..1490a2223766 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -614,6 +614,18 @@ enum drm_panthor_vm_bind_op_flags { */ DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED =3D 1 << 2, =20 + /** + * @DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE: Sparsely map a virtual memory range + * + * Only valid with DRM_PANTHOR_VM_BIND_OP_TYPE_MAP. + * + * When this flag is set, the whole vm_bind range is mapped over a dummy = object in a cyclic + * fashion, and all GPU reads from addresses in the range return undefine= d values. This flag + * being set means drm_panthor_vm_bind_op:offset and drm_panthor_vm_bind_= op::handle must + * both be set to 0. DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC must also be set. + */ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE =3D 1 << 3, + /** * @DRM_PANTHOR_VM_BIND_OP_TYPE_MASK: Mask used to determine the type of = operation. */ --=20 2.53.0 From nobody Wed Jun 17 04:06:23 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7BE3D3333 for ; Wed, 22 Apr 2026 12:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860787; cv=pass; b=dOcpFw2TglJi1l9iB16cRqWrN1jMsUl/4FMzdBcqD8iKMmjfa8MboGMMQy25l0hEQRQTxZ7KARXTn55i2lBBkJgOi81w9D3wMVgD+urCy4vKF7czq6UhbefIM81r+sqFDsMy6oIV8p+DKxdv0GhCqPInc7u0Xr+Xzc27rSb7iK0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860787; c=relaxed/simple; bh=56EtDXzizX7mS4t7cViWY98hLtX6gO0NTKcGeADaN8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=o7oB+3OhwPLrK9R7c+nkcuGHG8znX3aLG4OfNQ/p7p8IFjC53rDrtJGtkty7iVYZ70fooSfTBCuOSGVxMIZptt8yUctwNLUzXeLTftTNhMmuIZE3G0Iq8t+5daKXtT4HrQu6SpT8MlJOf7God78Kc+E8N4jtnsd/BcU+l77K7sY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=TEBKifqH; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="TEBKifqH" ARC-Seal: i=1; a=rsa-sha256; t=1776860772; cv=none; d=zohomail.com; s=zohoarc; b=kSwbereQbA8PeZ0uAQ8q14y4xo9AN3VMJpAQQYo/tTh3Ii5peAKu1zWltlnxnSvf8KHybWh+zKjZESgp9H0h9DHkusU22j4R27CNsuoq3eWbNWsqTL0eVw64Hsu6N6nbGL39Ub3HDZ5kVbNF6gE0tRWQpK66FcjilsCg/ytZiUs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776860772; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=2rCicD+VYxPNzmaszmMlGl0ezNOaHWdEkCf8KQFWeyg=; b=crW/Bd5k9ajDRRTjY5ejjZ5NoRWO3VmMzfhh0FSoHOK1SXxUkRvVT66aOkB9ZRvxIaMlf8T26aa9Pn6k4kHtbhQaJNd+5EXnsZjpVXUyWygQ3jXLtZuWVqT8jO0KXZBpSmPUjpMvis8mrDJUTVK2UKuThBYorc/xsyRnkUPrJJw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776860772; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=2rCicD+VYxPNzmaszmMlGl0ezNOaHWdEkCf8KQFWeyg=; b=TEBKifqHdZIrqaFQThdvZTsa6mTOQYesku48O48ooslaIbwkK7AZem4t51kooZl0 xdodui8mTEq8vPpmT3R56SFX130SBwfKRNq8wZGv6nsxJMs9shobwzPYQL14QCsU3wb OA3c7sfME8pPAS1SGGooMLf0thSudZpCT+UvMFkE= Received: by mx.zohomail.com with SMTPS id 1776860770763843.5499229391443; Wed, 22 Apr 2026 05:26:10 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v9 6/6] drm/panthor: Bump the driver version to 1.9 Date: Wed, 22 Apr 2026 13:25:33 +0100 Message-ID: <20260422122538.3117380-7-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260422122538.3117380-1-adrian.larumbe@collabora.com> References: <20260422122538.3117380-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bump the driver version to reflect the new MMU info query ioctl parameter and the VM_BIND map sparse flag. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index a8090bc4e33c..4fa38ede6993 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1787,6 +1787,8 @@ static void panthor_debugfs_init(struct drm_minor *mi= nor) * - adds DRM_IOCTL_PANTHOR_BO_QUERY_INFO ioctl * - adds drm_panthor_gpu_info::selected_coherency * - 1.8 - extends DEV_QUERY_TIMESTAMP_INFO with flags + * - 1.9 - adds DRM_PANTHOR_DEV_QUERY_MMU_INFO query + * - adds DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE flag */ static const struct drm_driver panthor_drm_driver =3D { .driver_features =3D DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ | @@ -1800,7 +1802,7 @@ static const struct drm_driver panthor_drm_driver =3D= { .name =3D "panthor", .desc =3D "Panthor DRM driver", .major =3D 1, - .minor =3D 8, + .minor =3D 9, =20 .gem_prime_import_sg_table =3D panthor_gem_prime_import_sg_table, .gem_prime_import =3D panthor_gem_prime_import, --=20 2.53.0