From nobody Wed Jun 17 04:15:33 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A34C13D1CAA for ; Wed, 22 Apr 2026 12:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860103; cv=none; b=KrdOJh1MHlYp8LunJCEXGU2tTP2X6ptvLUMlv8QyiYWbyz/aD9WxezHQaGbVGQVzumDbcsHbGy5VPAdU9Wxzb31d5TB79LZFUpHF6jf7bSyO55vm5mV7cT/eETRpKTtLo151pQYaGAUic2pvenmwmhhDQG1Ettsvj7/ugcC3920= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860103; c=relaxed/simple; bh=L3mfDEdUtkrf6vafhVgaTGAZ+H/Cv4eshByKCax6nuI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nOBub4I5hl1qys5E/59NY+2lnRzcJ/Kdn7KkqmrIRbd8L5b5J2NljB1ZKGXl5vAEz24vyqtwBp56Ic+hVDEg7CVMYGu/avrl8WFouftnlRPywNugBghh6l+F7yKluFj47lRF6Dv6xZXO7L4j01yWRGKbfWLVFXtWxKLViL3+1dA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EhS1tL/Z; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EhS1tL/Z" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so44793945e9.0 for ; Wed, 22 Apr 2026 05:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776860100; x=1777464900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nLinte2bTrSfydnPw4RU23zBy6zkLJ7eny7r/S0aKYo=; b=EhS1tL/Zdy5sLeQSlOQ/pw3BJj5VLPmwNKyIH16SpcwW++tK31jDXtMlHBTlcT5ZYV /2DKomz/cAejjr9Vd+Iaawn3rK6OwoLiZyrz+zRnEF/knSrNRvWusj4PHUzmCBmiX0B6 c+rk6WwRlv0Zp2ekZ5xfwupWE3a1rqb+khUAPYNAsg84/TwhNdeceA7c+/G2YttYo5c2 dL/puhZGCmrPP3LIlQQT386JHLl4+iXfNwshphQQjPiVT2alzccU/NlPFPaxomVdDHoH sOZPC7zdoVGJyNNP9dqYHaOLtIk5XWf79qpyqGt1bVcNnYThS2G5sSSzb6KCqBYyndnq jQfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776860100; x=1777464900; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nLinte2bTrSfydnPw4RU23zBy6zkLJ7eny7r/S0aKYo=; b=IRHRdgUyMtNJ3FTWs6KjrKiX+lqs+40337qASyAvr1xB9PSIMEAz6NNtIFWv/HE2M/ KKclBdjXiuBeU4yIojUsC8AiuGDuhvmTtNO0DFq5u0qy3BZyIo4xVrncq5rJzQYkU93k SavFv6YmGaoewMK/ne7QO/I7le/dlaEaoc3dnT9EMsqZrPM6S6IkYV8UAiM+30T3vCVW kEe47hy2dRBd/e1sSHMqpfXvoQeWMOWxiAZg5sRVMSZSZBwbuINhpHkdBKePCRGTqMtm bbmhK+qC+BPEw6P8dzT5f5WtGgSCqsErzV7iPMhRKZgT39UTR48UIuVo0z5m3GFNQ+aS eV2g== X-Forwarded-Encrypted: i=1; AFNElJ+zbXMFRFfy/aP/qV5do+pjqiJuBI01b9rZGYs+rK5f1kbAsQHIqEm5VS7qzyMz13Y9dn1Da50ZzwVuZfY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2TCjyBewE2XEmRgpGBcGckTNj0SB1EBZq6im5a4+Ogn+LYNEb 2nLcOQL0SZF3cH4u3x4xC+KHQS1odchh4ZGO+cbfEpgv6C80qAyaq6MF X-Gm-Gg: AeBDiesQfWaPjCtEeAZWWsWX/F2eMSEYzQ4A9OwNk4dnUYmCYwru6lzyXNGZF6MYgy8 Da9e0V/kNsIWq+uljWpFle8/yXuBarqp1IEIWmCcfmqNJfiEpXigJJBjpEuivUL/JZLpQUDY96r AQ/YqdOMQcvAGapmtd4iQxbiZdfbMPpvCFW5zbCqx0hobRkgxHsTdqYopUOyxPdo7tua2Ss3tcC 6I2pPyExauVxLo6XHsnoq7/5AmPYrTDT3jVv1NcTVgk2znfKiS3thvqO5dCJgM+ulsaBteAa8N0 sRhMizyD+7ZWi/6oI6Y3NDfYNhTR4AvcLB1lwMUQGz4Xz45biv2GrhsglUvmYtaxnWLNLV25qtp 42kbhDIe4fs4XZmoiufI5S4FcJAr9Qofpa0bHY/M4mm5gpO7q2sKeUXcFOJs1OEtf+S1FhpzLyq 9Q1B6HpuaGPl6xSgrXLVy6PcY87q5FK3WANsB/pHZGMQ== X-Received: by 2002:a05:600c:4895:b0:488:ffad:6728 with SMTP id 5b1f17b1804b1-488ffad67f4mr158637015e9.19.1776860099737; Wed, 22 Apr 2026 05:14:59 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:a996:3b08:6e96:ca85]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891df9e50asm192056665e9.0.2026.04.22.05.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 05:14:59 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Biju Das , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dmitry Baryshkov , Tommaso Merciai , Manikandan Muralidharan , Cristian Ciocaltea , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v2] drm/bridge: adv7511: Clear HPD IRQ during atomic_enable() Date: Wed, 22 Apr 2026 13:14:54 +0100 Message-ID: <20260422121457.166780-1-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das On RZ/G3E SMARC EVK, suspend-to-RAM via PSCI powers down the ADV7535 chip entirely, causing the HPD status bit to be in a stale state on resume. When the display controller driver's system PM resume callback invokes drm_mode_config_helper_resume(), it calls the bridge's atomic_enable(), but the stale HPD IRQ is never cleared, leading to incorrect behaviour. Clear the HPD status bit in adv7511_bridge_atomic_enable() after powering on, so that any HPD interrupt latched before or during power-loss is dismissed before normal operation resumes. Signed-off-by: Biju Das Reviewed-by: Tommaso Merciai Tested-by: Tommaso Merciai --- Tested HPD, s2idle and s2ram on RZ/G3L SMARC EVK connected to ADV7535 on both polling and IRQ mode. v1->v2: * Dropped PM support instead clearing latched HPD status bit in adv7511_bridge_atomic_enable() * Dropped suspended variable from struct adv7511. * Updated comment in adv7511_bridge_atomic_enable(). * Clearing the HPD status bit unconditionally as there is no harm. * Updated commit header and description. * Dropped the tags. --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm= /bridge/adv7511/adv7511_drv.c index 6bd76c1fb007..7663814b4032 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -792,6 +792,13 @@ static void adv7511_bridge_atomic_enable(struct drm_br= idge *bridge, =20 adv7511_power_on(adv); =20 + /* + * Clear the HPD status bit (ADV7511_INT0_HPD), so that any HPD + * interrupt latched before or during power loss is dismissed before + * normal operation resumes. + */ + regmap_write(adv->regmap, ADV7511_REG_INT(0), ADV7511_INT0_HPD); + connector =3D drm_atomic_get_new_connector_for_encoder(state, bridge->enc= oder); if (WARN_ON(!connector)) return; --=20 2.43.0