From nobody Fri Jun 19 21:13:46 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 802B33C1991 for ; Wed, 22 Apr 2026 09:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849864; cv=none; b=Gzpf7pA0EBwjXrVDUUYMhKuEP/JsQuo8ZmbXYf5aRhd9YMVgj7mFNzX+iIjEx0qaDtYpeOPRLDlPvWRPuAdThhoBD2XXq4xLJUApoEuXgVOo5toO18bawW+RnE9kFhIYkJXyw74hc+b5985IP6dQMuCXccb6yA+WvxKyJSTuxRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849864; c=relaxed/simple; bh=fqGiXwv7TMUQTJi8HRdgDj9tkcWqqY9b9ZpTnTA2HXc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ck4KRHleVpkwWfKYLcvylk0GQWRyQ7D4RzdDy+KHYmVYt3TllpkWjC4N+UzBakQQjxug2pEesz+gV2kwqOrk4pbbDyd36Sx+DDeZmAcpzvk326FNHqG14oehU/mYq8haBd/O1lhVu8IoYpIgC/aOOcfVvtsQZEeH16zziYjsbNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DHrf/4OQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EZwyTCYb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DHrf/4OQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EZwyTCYb" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M99Bmi1443382 for ; Wed, 22 Apr 2026 09:24:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ISnEXNmu4DG VhMqbwORuMrVkS8MlUvvf+D9exDaKuko=; b=DHrf/4OQ+EA2LvFiKGv3BLcxxH+ D1keSCX1Mij28qi103rgC+sMN12z+Rtwh5xYixs7OhjZqmMpaX7m4qCYPHPLTULl PMq9jyvC3P/fCnmdH6Cbqyx2/6z4hNf3bc5jfqN4AUa/gQHHqQ4F4RskkvhJPA8v HLjzugcQN3aD4icLNAM46Et+gHkxVtoAmJMkFpQ0xMZlSO6ep0rDMNoxBjQCQOo7 OMnZDzTOMyKxKtp5iSDmHtinI4E1KDKQ/vv/HvjP8k/DnMSgahtkKw7F3KMd6KBs KlN5Qy8mqMFt2HEUInzR+xyLfL/jezahsWNx1nlBdOV3OIHBVTyBfNprlXw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenftmbt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 09:24:22 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-82f803658d5so6428746b3a.1 for ; Wed, 22 Apr 2026 02:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776849861; x=1777454661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ISnEXNmu4DGVhMqbwORuMrVkS8MlUvvf+D9exDaKuko=; b=EZwyTCYb7ArFVxXya2lSXHnq7kcWUp5zZ3tnlMZAdxO1aHRjcTQAJPBgwwzCWdvWhT NLc3sPMcYDQi0QlRh+EAsmNhfgmhEgVvJFgkGrrcBkepq6GyU3/9GjtZEklvYu6EvOCL 5XPBcm7H0S/H9d5EFiyHYheARMTRElm5bR6Uy4K35RTQFKshoYEJIj3tPDlBxhfsJ53h Q61iou6onteCFZKow0/RghKUvgq2BszRMPebXZHbyk9R6MuixaCqBZSW9iNJHrL59a7M BcV8pE6MFeKmSX5vjuFv1y9bP5xc/7dJtmkCxQV8X3beKpiuhvT0/8sOHWKwGNqB3KEf zXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776849861; x=1777454661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ISnEXNmu4DGVhMqbwORuMrVkS8MlUvvf+D9exDaKuko=; b=j9JxVl8Wbph/nadUaFYgrQO370++eW6mXkHqpGM4bHxLd2/kshWmviU0y7NKU7VPFo YwSBO2zw2uLld990wuysPCorerlgvVHxaNCw1OFDkeKoO//9MzkyOtaAY+YTbX5n0JkH sUlBK8JVEGbxR8xGSLlrsXiZHbzjtbbl6AyB0+CTxDZ5DkXKrLNL4PyTnCRaz/LEPcbP Y4HZPPHEi9qKNZ1Mf6iPPFQVfSPrp4rvG0n4ADR5GcbC1frhp8lPvKvmjHr3MYizTZ6y UuVSI5FHBv4V7dbyVdKumBHyLTEip+TKT6ePA8wayy9ub+Yz5u77ZGkcJpZZpHN9ZZvn IRgg== X-Forwarded-Encrypted: i=1; AFNElJ9ZD6ZSbAndh4r3TWuj+Pdc8EuyToX+4vsjc5QDjo92aZvwzfhZim5MxhTh36wcIdhdsUFN/OIIJVa+R64=@vger.kernel.org X-Gm-Message-State: AOJu0YxtqdchHwMaJ/TkwQy+HMopIPKWirM9OvC/FEJVBBii7+rL8IUk LGNOvicV1YRiSA0vfm+HaNPiclDa47/Z6S9rz9vT32c801Y6aCimGMDPya2/gfFrntuqNJFSs0U wpsLHBpyDg4Pyg/EXBXtjuqeEeAxyalr+WgDplXpj7pXToeIRqGZ/NLGAI8IjD3heQrY= X-Gm-Gg: AeBDieuy86tHWSouCvAU18OJgfOJg0bRNtCNLSrswOOwkZD8YU6DL8BGMCcCMV5ZmGX G7j5oQXqZ+9OB+wsrRt/hCLRX2EimjEGXxymTEiDNnKct55JBD83qtkmsaPB796T4wjb+9PRjRC +kGfcY5E7UEf7HtjwTS8jOcFK270VgubKjZpd308knVyyq/RqRBFrym6F16oz9xDPzoHdJXDdZ9 4JEnLuLdHDT7SqMdHjX3QUKMmRO5zGBiFkPQT4WvO9ySeufeKXLEck8hzqynKWc54IUjL5g1y01 TxtCXTitUyovSOANY9u9cFlQIYuGyPUL9HOs36gRYPzeoi/9p+6t7o/VyM36wBfbzvGyDJOk1r9 Bk/Klt3sVYlCP1YZRQ68SRxEfdS4H9NWe57OVOXaP2ufe2zh9G4dLPJNHPYgAkKty X-Received: by 2002:a05:6a00:116:b0:82f:9d21:d352 with SMTP id d2e1a72fcca58-82f9d21d516mr13893525b3a.9.1776849861160; Wed, 22 Apr 2026 02:24:21 -0700 (PDT) X-Received: by 2002:a05:6a00:116:b0:82f:9d21:d352 with SMTP id d2e1a72fcca58-82f9d21d516mr13893499b3a.9.1776849860677; Wed, 22 Apr 2026 02:24:20 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb38ddsm15778576b3a.34.2026.04.22.02.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 02:24:20 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, ltuikov89@gmail.com, konrad.dybcio@oss.qualcomm.com, andersson@kernel.org Subject: [PATCH v9 1/4] misc: fastrpc: Move fdlist to invoke context structure Date: Wed, 22 Apr 2026 14:54:06 +0530 Message-Id: <20260422092409.4107093-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> References: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: dG9myh5ERu37XQFZ4CEfFGZZLs46G6L7 X-Authority-Analysis: v=2.4 cv=YJuvDxGx c=1 sm=1 tr=0 ts=69e893c6 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=IPuuj3Sbi4WKP8RQR18A:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDA4NCBTYWx0ZWRfX7pCbM8lJaDLq 8pjt9fHU6y3G1TWFmD23astA2BY/h7NjJ3bxyIA4SUg5v2NxKnmExq6vjAiDhtic7+hnEp20PL5 Sqpae7tzTsyHjO/n/E9aLJQM7tZ6v6dUELcKYROb8dR/YVfot8XTJgAXaUf8gl2rD2Gcd8ouPY+ 7Kpz7Y/9sIGybfHJIRpWaIBoOgU6THooSZu7oJmRbYU0Bq2gBH9OUJB+/XtwY4SrxN7mvo5JaHi 1eAgVQNM2UeFkMt3sMVUU4UikYghN+kdUgIPm5RobeadBAhjMkYwydTNjn0qTMsonl9RHNSmATh wib6z9GhPBiNSi7meOTfyXaBvCy17YufsxdOBiGDVklizuVCK4H+PG9+vw5iyddtol2maAdNYjp oODIoLRMpb47Qp2Y1De9gfAOmTgnNBLsvkqZ9RIYx9VXvFgIQ6RGW9fY+ok4o8c5LXvu60PLTXe NOoNxz4jOnSWkVloQSg== X-Proofpoint-ORIG-GUID: dG9myh5ERu37XQFZ4CEfFGZZLs46G6L7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220084 Content-Type: text/plain; charset="utf-8" The fdlist is currently part of the meta buffer which is set during fastrpc_get_args(), this fdlist is getting recalculated during fastrpc_put_args(). Move fdlist to the invoke context structure to improve maintainability and reduce redundancy. This centralizes its handling and simplifies meta buffer preparation and reading logic. Signed-off-by: Ekansh Gupta Reviewed-by: Dmitry Baryshkov --- drivers/misc/fastrpc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 1080f9acf70a..a9f507a88c67 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -233,6 +233,7 @@ struct fastrpc_invoke_ctx { int pid; int client_id; u32 sc; + u64 *fdlist; u32 *crc; u64 ctxid; u64 msg_sz; @@ -1016,6 +1017,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) rpra =3D ctx->buf->virt; list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); + ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1118,18 +1120,11 @@ static int fastrpc_put_args(struct fastrpc_invoke_c= tx *ctx, union fastrpc_remote_arg *rpra =3D ctx->rpra; struct fastrpc_user *fl =3D ctx->fl; struct fastrpc_map *mmap =3D NULL; - struct fastrpc_invoke_buf *list; - struct fastrpc_phy_page *pages; - u64 *fdlist; - int i, inbufs, outbufs, handles; + u64 *fdlist =3D ctx->fdlist; + int i, inbufs; int ret =3D 0; =20 inbufs =3D REMOTE_SCALARS_INBUFS(ctx->sc); - outbufs =3D REMOTE_SCALARS_OUTBUFS(ctx->sc); - handles =3D REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTHANDLES= (ctx->sc); - list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); - pages =3D fastrpc_phy_page_start(list, ctx->nscalars); - fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); =20 for (i =3D inbufs; i < ctx->nbufs; ++i) { if (!ctx->maps[i]) { --=20 2.34.1 From nobody Fri Jun 19 21:13:46 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 189B93C278A for ; Wed, 22 Apr 2026 09:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849868; cv=none; b=F5YtC3doeR+84GX4UL4KhmcE8hQ2asD/xlgMyeAbC4JpbBVvRlzWKrxCqD0I5m6jmjQy4jbJ6E9nh7aQCcqmztqmNHFzt3cs1NucIWWI0rw/FMJ6RYs78PgRLU6jVR8v1LJg/BuqO8hYr2dMD0WMw463SP/qTJ/VWvJZKGbt4v8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849868; c=relaxed/simple; bh=17Ef71wpPprYkzSdH9NRRGCjdmeEYelFAAr5q3M9YqE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=En9LfcFzMQPn/JjtoDCiYnCW+JHH2XQFWuAtn4Y8pFejPZ1ySyyoWB3jVV0m1uPcIW/UUZFeg/G64419vtKHBl26ZCEMna8/kk6hKKqTqnhMgXd+xa1JbgHJPP2qO8sBWjj8tmrGAO+LYCV5PlisBCbyB5a+FjDmrnLwIU5hf4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=g+1nmx6A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eU6lyK8H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="g+1nmx6A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eU6lyK8H" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M96HVQ664335 for ; Wed, 22 Apr 2026 09:24:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=TZq/rLCuYKP zZ+3bFaDBlw4HhmEskTpGrvorY5Ef4Mg=; b=g+1nmx6A68Kw61XVmfG9ABrU1W8 rp7KU2ny4le52S59Qf2jKYO62ceWjGzm8r79c1h1bfzQ6JEtX71qjyYEIjtaF0KN 2RPaO02LOc4on1B4n2ZVTc/kNiKpJMBXkmuyU2Slcjg06wDWNfCjHi5tBJyB8sQR aV4mePJhFj0M5eolaaK1dGs3TYhxVt6E5jPJciDa3n7Ferkyc7SfneC+0gOr3TM2 I1+hR7uZdFnVEVfGGVBVKyrdmgnqFeNj5cQ1Q+ojGqf4e9iruPkPAEVNf1+GNTrd rGTwhQhY0/cDBWCHBRKhaVuvHDvW1H2vbD7aMkxzTLgwlSHyGLqW9uIUsLA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpudgr348-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 09:24:26 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c7948640854so2551410a12.1 for ; Wed, 22 Apr 2026 02:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776849866; x=1777454666; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TZq/rLCuYKPzZ+3bFaDBlw4HhmEskTpGrvorY5Ef4Mg=; b=eU6lyK8HFN2qb+J7aju4+nGrnAMMjpI0195Xg1+DqmHhxC49J2KaLJX3LZclI3EYo3 /7F4GvjXAV0Z+/wDJtboNYn4zPD+m6oP4XSVnd51seXv5YXTZrqmzZeBxkmUh26CvkFz HZuTboG0Uv5KXTMW+zSE82tt5hEl7SU3QzVH0HwL0lXbzpZx193Q6ioSBk8jP1SewO8N CyjlrJ6WGQCUsMMYaY+ijD3+aO6HJunvSxivknrjiZXH/ovO3J0DGKorPDOrlM7gnOF2 3oUefeXugDxFR3BZ11J6PFfQO6gzNyLuDQNqfdzuYJVp8TJm3XlJFPUYPYF3PCeikVPa GoRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776849866; x=1777454666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TZq/rLCuYKPzZ+3bFaDBlw4HhmEskTpGrvorY5Ef4Mg=; b=CILulvWiSjtsd3OTIWPeu2rbOgdjidnbDTkyzQfi47KT5UNCe008QTKbmHvwyew9LF W3az2KbzXLaDPEliiWd3EhrwC0cGQDo/MBN1T+329E6nbxWgPSgafEX+HkzqJofxXzCD kiAJwE6vHNOgnGhJW/+hum71jN+uDg6DovY2knGb/tLAcQlvszpDn34zxuYyikbEDyLL rbdE4E3sM1nP/RvbpjjjLntw67SY+trlaGtk9/4NzUkb2+Y1G+QXtECrEwuri/IVTN/l 9H45aGu7lehd6bFd7IMeTLlOweLDzKDQuiNSlq21u0jgXOvyi8Z6G/i64c2tPu/ti9W1 0zAQ== X-Forwarded-Encrypted: i=1; AFNElJ/jbse7POIXp8sN0fkD6PfQItHH36hS9srggEvL5bVY6JVHth34wK3Ox+W5s40D/m2bOlP1g+GvfPcWY40=@vger.kernel.org X-Gm-Message-State: AOJu0Yym1MoXAd/hZJNz1ZsKVzknRZo60uOZK+rhKLVVS65jv/QyGtef iAJfofDF8Trg7ugUnKoSXx8ptOpntzuXfN5t9CET7ZzKhFvIenouBeKIpBCKXw5u0rmOtFDETFO aSrKcfz+hX5DU8HHrAWuWXS1MvaGMzsS3o/vBQW+iR1hAugMYn9v15uSQcABkjPxY/Wc= X-Gm-Gg: AeBDieu5fhI+cAtwO7vC2pfCAwa946ZGGAp7+2SYeekwPhLrEV2qUEHzJ5enOrxoYwZ 7tROYi88g1gNWuSNqCyluRuzd5DWt1bJQHxLHtf7gLcnm7nVxT0EcSrsBPNd/rYcwYe63XaBFhH LREQqHCje56JspVsuqXOCo+4s/oqmFv5Cnh3JrgHTNdD6qgl5O1N2KmrSp/RnJWeeupp36u3uGo sAcY4sgVqTdyhV13khsm73ZafH8h5DlI7JfKwDEmoXDYM8YYTTA1kxY75KtIKuChNQjdcIIq9cO cRMwBcEwklU/qgcMmiibtHduJ+dTeZVD7a40HaIpMn7ylTObaMEymOKOnKVxBr9zZM6VPQxd5LB 8/UUAf1GDYqUzBngpo+G2BUFKkAEZg4CyznoSriqu/tnEetyy4ngqksOY7GQAmAqC X-Received: by 2002:a05:6300:218a:b0:398:7357:bb81 with SMTP id adf61e73a8af0-3a08d748eb8mr23344905637.15.1776849865601; Wed, 22 Apr 2026 02:24:25 -0700 (PDT) X-Received: by 2002:a05:6300:218a:b0:398:7357:bb81 with SMTP id adf61e73a8af0-3a08d748eb8mr23344874637.15.1776849865055; Wed, 22 Apr 2026 02:24:25 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb38ddsm15778576b3a.34.2026.04.22.02.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 02:24:24 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, ltuikov89@gmail.com, konrad.dybcio@oss.qualcomm.com, andersson@kernel.org Subject: [PATCH v9 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Wed, 22 Apr 2026 14:54:07 +0530 Message-Id: <20260422092409.4107093-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> References: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: O-TZxb9PhPUSxa07rupJAL604JrvRUJ- X-Authority-Analysis: v=2.4 cv=c5ibhx9l c=1 sm=1 tr=0 ts=69e893ca cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=HL6mAI18knL3XnPGOeUA:9 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: O-TZxb9PhPUSxa07rupJAL604JrvRUJ- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDA4NCBTYWx0ZWRfX+mG4V/poxkXK ykeVFyJZg96W4tTdOp2rF6L4Hz3JidbvAsK/NuleS872O4sj6t46zTnEl0ITHK4PE4FuUoo4h7n ROTQDcOcBpufpAYI5cVm/RW+lMYuCF2t9x5p/IshhxiX0tkrOhvuxQCmcTUUePubY1AP04SJoKU ykaUScVs9rJDkx598p4K+K9+4oPIHB4rQ+kvQRdAYPot/199dlM0Utk7Qe2Ut8MCFBNfZRtAxsF EUd+J9QVJhbHWB/Wib7LrlO3w45oobhtxiJn5tRLiChHLQygP/xrbxs/riT4R+bJ0ZdeoHIL8yh WlChoWrm9TSAQcikwefAGz4/p2JUYpOk0N2iy0Kc8MSSDGkhw3u4uY1yGPCaCQiDufCfRw9644F 0Axvse4Ut6hPyPZisaNo/bLGWAzZ2Pda9sy6Lh+XAyZ9vku+05AYXxrawlkHMi0+CQtmOyh5M25 Qvw8/g7g70I4dtXh81g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220084 Content-Type: text/plain; charset="utf-8" Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to improve readability and follow kernel bitfield conventions. Use FIELD_PREP and FIELD_GET instead of manual shifts for setting and extracting ctxid values. Reviewed-by: Konrad Dybcio Signed-off-by: Ekansh Gupta Reviewed-by: Dmitry Baryshkov --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index a9f507a88c67..3f5d5d73be5a 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -23,6 +23,7 @@ #include #include #include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -37,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK (0xFF0) +#define FASTRPC_CTXID_MASK GENMASK(11, 4) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" @@ -515,7 +516,7 @@ static void fastrpc_context_free(struct kref *ref) fastrpc_buf_free(ctx->buf); =20 spin_lock_irqsave(&cctx->lock, flags); - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); + idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)); spin_unlock_irqrestore(&cctx->lock, flags); =20 kfree(ctx->maps); @@ -649,7 +650,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( spin_unlock_irqrestore(&cctx->lock, flags); goto err_idr; } - ctx->ctxid =3D ret << 4; + ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_MASK, ret); spin_unlock_irqrestore(&cctx->lock, flags); =20 kref_init(&ctx->refcount); @@ -2508,7 +2509,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, if (len < sizeof(*rsp)) return -EINVAL; =20 - ctxid =3D ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); + ctxid =3D FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx); =20 spin_lock_irqsave(&cctx->lock, flags); ctx =3D idr_find(&cctx->ctx_idr, ctxid); --=20 2.34.1 From nobody Fri Jun 19 21:13:46 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C4353C199E for ; Wed, 22 Apr 2026 09:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849873; cv=none; b=SM2jgKG2JX3nSzfgjLGocYXRvJtGlDtLu4mfHeKMzu5JSdlRlC0aRar2M4tbispSAFFu6A8KS0/h6VD81vYAzGNVkzAXYmQfgKk5MYgK9gamvpOYkXOJKr5UPp8sRGfvRKGCIT8HOOJDFCYk2adnC5K7xvIXZ2bPz5/+/1dKkys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849873; c=relaxed/simple; bh=wLHY1YKwTOtJ5TMOu7Sc4w4rQ5+KEfPEjuD58JrY/gw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TTzK4cdO9ziZLudOl4fYimomlWJp+8pfTuRB7Ak570rbU4iMdASjggMjNGYq/FC+NeYwXCVRdp/uWZsGdQ43aVG4KXH3qerfPgi+0rXewbedVv1Ayu+4Sjqdr6nBb6aa7XPAZrxP88GiSIgp8LxK2rmVdUHwOQJ2nGQ4m9MOmaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SKfT2E63; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OfT6jpvp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SKfT2E63"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OfT6jpvp" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M98tVc2063469 for ; Wed, 22 Apr 2026 09:24:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=tFUu7w/Mdhl BRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=SKfT2E63EP/LASoR4GuII79LXU7 OgawffQ6Ze4uvBVmRjBkJcWNlnV4gKIdoy4nBnUgZxbhDFyWkZYCNw9L9SGcnwUV /8mZVofmJ0RdplQw8tqBC3GPhBraUEobvJknFAUk/Ff9d/wzTllZVy+83SjNasm1 fiQnWh55T0nNefHMiWytBWk3s9IABpRXNVN7Md5IwyZEI0Lq+3XtBo9en02D7MDm 0Vj1wNOl+aeYKd6vDAStj4RVytPjcse/XuWkbAA1G9CdYS4/k+Gm0nV+Q6VJWCUR 7k1WPYBFH63E4/71cynLiD7aXSzGAtMBr1rETGB+Wc1mYGB+UPBhXgr1wlQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenhjr5j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 09:24:31 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82fa366fb79so4228219b3a.2 for ; Wed, 22 Apr 2026 02:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776849870; x=1777454670; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tFUu7w/MdhlBRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=OfT6jpvp8j14KNZumc28DZkmtUMDJlGw+DgLIrWvtvkz58UwZy+ujQKuKRhekxqF3Q Ga93Xwy/0W+5JqVV6lCTNLkx8U5e2QO64WwplWgM0rq98lZuvspX2afvRRTIkLGCzWAi xfZ5PnZ2mgM3/aTEotBWjWCgvTkHNttnNKVxG9ctrJ6cO7k+YQSfZ6l/enxm7EdlJJQr sUqCIN1yylfwLYMS7wkttXQ7HoYGaC85d2FCI2ts+bGuqKnvK0Ck8+KNsDlBHUrMCSpI ZM3hdGTG+Lv+MEBaxizAR1qo1ZRmNkpXR4cL20eodwWHctSx9BlMGC81YLqCrZQWC+vh n+NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776849870; x=1777454670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tFUu7w/MdhlBRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=aLenJhzcuPvVpppTIlTHQtCEzyM2+U5bTU0lS2w6PFZp9+6LwH3vK3KKQ8rXwjYyEs lA0KEf5kaJijs10eh1hT0K5DWMtn7x/hXm6XBI+8LdhpCg5p7Q9Sa5b1U/SaLRM/1H9+ ii+c+zglB84JaByqzUIeoNbDyPljHzZ2sj/NUxtXy+YUSFRyNQkbxPBKcMFjHETIMqkQ cPL7PeH49iLzB7kuEjKbDdXSs+3g9Gtypn/A6kWGpCloJpLzwKoFekZ/bGLXJG/K8aoI 8tM5WAigFAqHL2FZ0fwX7+n+fLRb5iRPNnJHAVdavM4pA0kiOmRiIoaQIaXRFdvc5Y6t OyYg== X-Forwarded-Encrypted: i=1; AFNElJ9Fv3XHOK3R14GEfQNHcgn//x8wkHhb4rvFdjL20JXzmI3e3A3yE64ZWph34xSm5J1pYQdLi+ofajMaK8o=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl7Fd6cxzkf3LrtEmP92gIuk2/pzNX5RwrLTwk9SETFnfa7Dus +SVGPspiBeaR09Yr5HNhNO9JbK212vPmgJLYs9CzjMES6BdR3FeFUq6FbxN11khnxjld8+N+L93 FKrANl+rNbXvBfDNu4jE7S/L9uk/59xLFwmWwK2Nqc8GdCESzPWh/gXartO/zkdDV8vM= X-Gm-Gg: AeBDievE5ln9BrMSH0XBLFNv6fCyLPVlk/93hYRnqu3ARFuFOWM31gTbTbd7XUF8jYF TlPYV7z2eMO/jvWlKFLj94IIWtQv7TY+HUSzskeYcRTkwr4s64z55cbhY+6KJicIFoB8hda1OUt pQ/lh+QF8Ec+sHmR7fXej5xDpW4tBKxHYth6SFnWga5FPbatf9rTeFMd2EX59cAO9FuEc4Uv40F 2s+ihfkTmL9MhTvWN/Z4Iw02Lr7jhyVi3K/aMF7tTei4MWLHFKs6o7JJ2mBIpwK6ljKVXhtt96V bivTgxvTu6m2JKeb7uxNnGQWMShnBwdRZfcQSRTH9DNZd9dg0pnWo16NPEiued0fSNYO6aFcB7/ OyDrl+BLdKPinNfRJWFnkOXpjsLTCflDvUATznoszSLFMdcMyrWLMqgN21v5RXTwr X-Received: by 2002:a05:6a00:4b4e:b0:82f:3828:a00a with SMTP id d2e1a72fcca58-82f8c94bebamr22900110b3a.41.1776849870038; Wed, 22 Apr 2026 02:24:30 -0700 (PDT) X-Received: by 2002:a05:6a00:4b4e:b0:82f:3828:a00a with SMTP id d2e1a72fcca58-82f8c94bebamr22900060b3a.41.1776849869537; Wed, 22 Apr 2026 02:24:29 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb38ddsm15778576b3a.34.2026.04.22.02.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 02:24:28 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, ltuikov89@gmail.com, konrad.dybcio@oss.qualcomm.com, andersson@kernel.org Subject: [PATCH v9 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Wed, 22 Apr 2026 14:54:08 +0530 Message-Id: <20260422092409.4107093-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> References: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 9kf_rvEoBX7LgC8wIMnxCVhJxGpg0scH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDA4NCBTYWx0ZWRfX6RH+PfHrkRJ4 7RPYPrLrvI0e0E6KNgv+7uwU21hUnSAeTzWy6kZ2qzYeEdE00rGPbXvoIUGiWMk+XPO1jE3fVfu 2A4UQA1t//7QggF9JBtwp+B3OYL1P3dauIYRzs36GN2pKQ5tQ6kfmEekvTXq0JbMQMS022yQsvX V4osa/hKZFeBLJf87b33FNtebjDn+MyQG8EbHZxKf+sIkZIpvSqRB/DBCxIt2oVpflqGM+FoxVp +kWZN+A03rrq2qv/ECSJoxfIJv54yAZDlxlBnfed7dQq3jUbmrqESOM1jWXo0iT2Nv46jmmHZ9J e6jsFNUML1pFrr5WLOa1KmVpCQ5AXDFaXvLBbmQV4762pjrGzUBycXrEEip73lam1qkBl8grFp3 bbNSTemSzJ2j2Kcyw0S0uSI2UUJYmvyQ214sVZi43FDjc0v4WEwQVdS8wtbZ+nCkxTNBk2kYAJU YuV7ej5F4TRdgns71UA== X-Authority-Analysis: v=2.4 cv=WKJPmHsR c=1 sm=1 tr=0 ts=69e893cf cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=JTa3dIKMUYn8LlmgGFYA:9 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: 9kf_rvEoBX7LgC8wIMnxCVhJxGpg0scH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220084 Content-Type: text/plain; charset="utf-8" Current FastRPC context uses a 12-bit mask: [ID(8 bits)][PD type(4 bits)] =3D GENMASK(11, 4) This works for normal calls but fails for DSP polling mode. Polling mode expects a 16-bit layout: [15:8] =3D context ID (8 bits) [7:5] =3D reserved [4] =3D async mode bit [3:0] =3D PD type (4 bits) If async bit (bit 4) is set, DSP disables polling. With current mask, odd IDs can set this bit, causing DSP to skip poll updates. Update FASTRPC_CTXID_MASK to GENMASK(15, 8) so IDs occupy upper byte and lower byte is left for DSP flags and PD type. Reserved bits remain unused. This change is compatible with polling mode and does not break non-polling behavior. Bit layout: [15:8] =3D CCCCCCCC (context ID) [7:5] =3D xxx (reserved) [4] =3D A (async mode) [3:0] =3D PPPP (PD type) Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 3f5d5d73be5a..c4a3547a5c7f 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -38,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK GENMASK(11, 4) +#define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" --=20 2.34.1 From nobody Fri Jun 19 21:13:46 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCCEF3C3C00 for ; Wed, 22 Apr 2026 09:24:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849878; cv=none; b=UUvCca/FjUXujZXe8N07VDCMWAPp12wbGbWmTCd1m3lHp9YyaCvPXYhDV6ArG9qgyJo7dCXsHqBCvFfWRSa+lMI4StK8yrVUaMsV8ABVdRHU/wsdAKOATK6GIe538d1hAL2OnBgePOgyZBe5BUJgehuZXEA54nrTyG7tXsJaV94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776849878; c=relaxed/simple; bh=itn53tNkzwYhiQqg+IkczKrgxHVPJ46JGHM0lImXrGk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bhoHtDPncrvgRAlXzPFpSqSMcGS3nMtwC8M99HXwI34glordoQAkPmQchV1hdV5EGU+q7uzjSbSUt1fQ8p/pndxMCZPG6Wn/dSi3v5DE9JahS9h5XmeuseAJ21csZ7MM4CsMazsL8v2boFewertNNvGua6JU3zIioscPj4+dtfY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Gm926Zw7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OyS1euml; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Gm926Zw7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OyS1euml" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M5GGbe2209902 for ; Wed, 22 Apr 2026 09:24:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ZQDUrJEV+z2 kPQWitWweHCXDKrk3VVOPqd9K6vCaXR4=; b=Gm926Zw764GygkemnEbtGO5aejR DgsXAi1c5fwn3g4FB5qjHgMaxMs2cvBK8Lcj9dP5wVskZBRf+AdQ8rB1yO7Cx4CH JWXOs24WX5RBEorE0p24yrRhG7P8guGjN/tUpjSc7n9lwcOLlwvqD1TmbZV83h30 suea1Hv0Z45b8Qa8ify7pzP2HJBXuzzRTHJ8hAh4TcwULMkryfGkdzEKZqyiePTh MN8zoID2Ic5Bcxs7qO9w9JHCADVetQ5WYT22RLlGsY6FjiWHvkRrMB6+LLhprPld dMP7mBpbCcufZUd4QoW8818A2XVa+6mSIOf7HQp1XDi9WOSAaidnUp4hLZA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenganp9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 09:24:35 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82f6b0a7164so7379181b3a.0 for ; Wed, 22 Apr 2026 02:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776849875; x=1777454675; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZQDUrJEV+z2kPQWitWweHCXDKrk3VVOPqd9K6vCaXR4=; b=OyS1eumlMUeZ6QQPbISKsLaOpU1yvyjhM3vc4ReRmmxmTaRQ1i/8jPl6yEPt5JE4qb 6nTx8JdrWwYzkfkzrIcJnilCc5CcnBi5JmpSU7ajt57gJfGj8DFo7sUkQxYZEA3kuuzR JrubpnJSbsPnZBgwSxGH0TakkuY6UTMDOe3HGkU9Q3Mjs1J/eOuPp5/6EGF3BZ1l3VIm xYXlg+LPPDSIk/ZK7mSm6rE6QT3I+JcIMM7z/G82Pimdke8Fv3gMItrFhuTX3iWx+ZUL j4NxzimqGYdBTdvEQeODl1LkFyN/TewazKegCWADqmAk8xvvRVYqqNDFmybck5NV2RGS noqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776849875; x=1777454675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZQDUrJEV+z2kPQWitWweHCXDKrk3VVOPqd9K6vCaXR4=; b=gQ4mhmIi5UBvyDH31O7PYcvxxP/J7ruXXBSujeX+2Yq7evf8ud5nSPFoWDFTptaxUV LDyeg+I2Do06e5a3OozsKN6PRTLKjHYoagP6Tj16lzRQxynCw+63WL2NJExocCfVDRXe DI1HMGLYl1BlTFmZom3IFCqLDGV/K3pXNtFjQnYLhwz141oJSlt7LQyy928eUvdjcDz+ rsEjyTLspqRiHGgSMXe67M2m9nGQlUQhwhKSEIB9WEmUaegPHiaZDw/RQCH9oZrrQhv8 2Sho11evG9Fu8Ih8eWQuhcFEEsq3GPIu07BE5JcAO4rHltiaQe37uc5t5CYUr1EQm6p6 1YIQ== X-Forwarded-Encrypted: i=1; AFNElJ8ZH/GSKasy/h5n7yySDg2fbUc22KoSSUfhFJoQwrFasTtNvY3xp5rEOHGas61I7jQgmwXrCaSB7pPRkbY=@vger.kernel.org X-Gm-Message-State: AOJu0YzBSXFbTjRnx1PRSMDTDlsvasO8lSmDOfpHkMWdJR/6VO2U+iTh qu/lFQV0RpFa2r/BjG1+Bbx9hU88zbsGBBAxbEFDsfcsKwS3kXHIOsnk2rfcbauUXgcmqFgXgOU yR/JTbOig3OGHQpjXleaD0VM9HUXaLN7xtr8g0lQ7maenXFGZkQq9yQUBZFf4X5SaLWo= X-Gm-Gg: AeBDiesuaMgul2lbiHEffM/GbSu6EZ3xDFtZgUdgRlS7/2Z/hsKY3cT9Z6B3etFPLoN YcfxDnQWg1Atkorgn16wCKWUESJ7JcD5g7SVO/vx+sOhjaIXLY0PlA393oOPu1sFj7nClRLy82t ohkQGaR8vojdq3aaCKdrchAF8HaklEOTQ/63KHEQ1kzfIV5E6Siars+C7qzE63RCwg995lJGrGf Qn+wvt8l8v6zXs/RxBSsV94X6taOhZtv6hSv5ZXcI85KgZh81lhTGewJgGw/bujTh7UxYGOkH2K 2qggFEuVoEqMTXMSEt+zFwNuuXC4kUT5n5X20HOU2I/T3VLiPwW+TJES7h1bt9RFsSo2/Lhv0lS YHnXqs2tsEQgKlIsVTMUxgDCW+Y1A/abD8cQ/FDFzRML1LMk1bd6++LoGlStJRiW3 X-Received: by 2002:a05:6a00:3491:b0:824:a635:4181 with SMTP id d2e1a72fcca58-82f8c827148mr22551876b3a.15.1776849874503; Wed, 22 Apr 2026 02:24:34 -0700 (PDT) X-Received: by 2002:a05:6a00:3491:b0:824:a635:4181 with SMTP id d2e1a72fcca58-82f8c827148mr22551830b3a.15.1776849873992; Wed, 22 Apr 2026 02:24:33 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebb38ddsm15778576b3a.34.2026.04.22.02.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 02:24:33 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, ltuikov89@gmail.com, konrad.dybcio@oss.qualcomm.com, andersson@kernel.org Subject: [PATCH v9 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Date: Wed, 22 Apr 2026 14:54:09 +0530 Message-Id: <20260422092409.4107093-5-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> References: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDA4NCBTYWx0ZWRfX5lBmBDgRSofw BHDZFO3awfSJsvLsamozODBael3QDJjIdYWCD3y3BkNbh9O30hR5kLhJqJFnuOvdoKXIEM4x3RD o2hncunu00HQHiJ30ARW5lcoxs6aktF6Qukg2mnQZwwBA4PKHTUmN7n6mUl5nYyeTkyN0x+fd0D bLX0p+HbXL0qAp5F+xOCBjlpK/tkiB0Nmd7oQGEhSG+qxrC6f1Yb32bLI3Xy3HA2fPFGdIAb9GP PoOc/Cj8x2WXpsi9BbjB3vyEg+HW68+HeQuJxRZeIOP5fvV4ILfUzW2JHFvAphD/ev1nzudl30r 6H70j3zUmlhU5IJSDTUS1RKyqJmAZy3xrMDg3LDcQiU0+J8L1/Qtc9CUyoqcZMG74gkeIBNPQI9 Ia6p9KtHIV7APJheUPAleQN4XeLav3OwFsdKYwVe7mH7QZTn3jjQRtO1gjZONFm6lF5z0oXglnh ibXLaY1SC61u29MKO3g== X-Proofpoint-ORIG-GUID: CH9qVk5kEyOSuiT950RDx7aOJZkS9vq3 X-Authority-Analysis: v=2.4 cv=RYygzVtv c=1 sm=1 tr=0 ts=69e893d3 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=wn3mZlvuqqDVgct7km0A:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: CH9qVk5kEyOSuiT950RDx7aOJZkS9vq3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220084 Content-Type: text/plain; charset="utf-8" For any remote call to DSP, after sending an invocation message, fastRPC driver waits for glink response and during this time the CPU can go into low power modes. This adds latency to overall fastrpc call as CPU wakeup and scheduling latencies are included. Add polling mode support with which fastRPC driver will poll continuously on a memory after sending a message to remote subsystem which will eliminate CPU wakeup and scheduling latencies and reduce fastRPC overhead. In case poll timeout happens, the call will fallback to normal RPC mode. Poll mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl request with FASTRPC_POLL_MODE request id. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 148 ++++++++++++++++++++++++++++++++++-- include/uapi/misc/fastrpc.h | 25 ++++++ 2 files changed, 166 insertions(+), 7 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index c4a3547a5c7f..7445e2aa3c3c 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -24,6 +24,8 @@ #include #include #include +#include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -38,6 +40,12 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 +/* + * Maximum handle value for static handles. + * Static handles are pre-defined, fixed numeric values statically assigned + * in the IDL file or FastRPC framework. + */ +#define FASTRPC_MAX_STATIC_HANDLE (20) #define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) @@ -106,6 +114,12 @@ =20 #define miscdev_to_fdevice(d) container_of(d, struct fastrpc_device, miscd= ev) =20 +/* Poll response number from remote processor for call completion */ +#define FASTRPC_POLL_RESPONSE (0xdecaf) + +/* Polling mode timeout limit */ +#define FASTRPC_POLL_MAX_TIMEOUT_US (10000) + struct fastrpc_phy_page { dma_addr_t addr; /* dma address */ u64 size; /* size of contiguous region */ @@ -236,8 +250,14 @@ struct fastrpc_invoke_ctx { u32 sc; u64 *fdlist; u32 *crc; + /* Poll memory that DSP updates */ + u32 *poll_addr; u64 ctxid; u64 msg_sz; + /* work done status flag */ + bool is_work_done; + /* process updates poll memory instead of glink response */ + bool is_polled; struct kref refcount; struct list_head node; /* list of ctxs */ struct completion work; @@ -263,6 +283,7 @@ struct fastrpc_soc_data { u32 sid_pos; u32 dma_addr_bits_cdsp; u32 dma_addr_bits_default; + bool poll_mode_supported; }; =20 struct fastrpc_channel_ctx { @@ -285,6 +306,7 @@ struct fastrpc_channel_ctx { struct list_head invoke_interrupted_mmaps; bool secure; bool unsigned_support; + bool poll_mode_supported; u64 dma_mask; const struct fastrpc_soc_data *soc_data; }; @@ -308,6 +330,8 @@ struct fastrpc_user { int client_id; int pd; bool is_secure_dev; + /* Flags poll mode state */ + bool poll_mode; /* Lock for lists */ spinlock_t lock; /* lock for allocations */ @@ -923,7 +947,8 @@ static int fastrpc_get_meta_size(struct fastrpc_invoke_= ctx *ctx) sizeof(struct fastrpc_invoke_buf) + sizeof(struct fastrpc_phy_page)) * ctx->nscalars + sizeof(u64) * FASTRPC_MAX_FDLIST + - sizeof(u32) * FASTRPC_MAX_CRCLIST; + sizeof(u32) * FASTRPC_MAX_CRCLIST + + sizeof(u32); =20 return size; } @@ -1019,6 +1044,9 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); + ctx->poll_addr =3D (u32 *)((uintptr_t)ctx->fdlist + sizeof(u64) * FASTRPC= _MAX_FDLIST + + sizeof(u32) * FASTRPC_MAX_CRCLIST); + args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1188,6 +1216,61 @@ static int fastrpc_invoke_send(struct fastrpc_sessio= n_ctx *sctx, =20 } =20 +static int poll_for_remote_response(struct fastrpc_invoke_ctx *ctx) +{ + u32 val; + int ret; + + /* + * Poll until DSP writes FASTRPC_POLL_RESPONSE into *ctx->poll_addr + * or until another path marks the work done. + */ + ret =3D readl_poll_timeout_atomic(ctx->poll_addr, val, + (val =3D=3D FASTRPC_POLL_RESPONSE) || ctx->is_work_done, 1, + FASTRPC_POLL_MAX_TIMEOUT_US); + + if (!ret && val =3D=3D FASTRPC_POLL_RESPONSE) { + ctx->is_work_done =3D true; + ctx->retval =3D 0; + } + + if (ret =3D=3D -ETIMEDOUT) + ret =3D -EIO; + + return ret; +} + +static inline int fastrpc_wait_for_response(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err =3D 0; + + if (kernel) { + if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) + err =3D -ETIMEDOUT; + } else { + err =3D wait_for_completion_interruptible(&ctx->work); + } + + return err; +} + +static int fastrpc_wait_for_completion(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err; + + if (ctx->is_polled) { + err =3D poll_for_remote_response(ctx); + if (!err) + return 0; + /* If polling timed out or failed, move to normal response mode */ + ctx->is_polled =3D false; + } + + return fastrpc_wait_for_response(ctx, kernel); +} + static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel, u32 handle, u32 sc, struct fastrpc_invoke_args *args) @@ -1223,13 +1306,14 @@ static int fastrpc_internal_invoke(struct fastrpc_u= ser *fl, u32 kernel, if (err) goto bail; =20 - if (kernel) { - if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) - err =3D -ETIMEDOUT; - } else { - err =3D wait_for_completion_interruptible(&ctx->work); - } + /* + * Set message context as polled if the call is for a user PD + * dynamic module and user has enabled poll mode. + */ + if (handle > FASTRPC_MAX_STATIC_HANDLE && fl->pd =3D=3D USER_PD && fl->po= ll_mode) + ctx->is_polled =3D true; =20 + err =3D fastrpc_wait_for_completion(ctx, kernel); if (err) goto bail; =20 @@ -1813,6 +1897,33 @@ static int fastrpc_get_info_from_kernel(struct fastr= pc_ioctl_capability *cap, return 0; } =20 +static int fastrpc_set_option(struct fastrpc_user *fl, char __user *argp) +{ + struct fastrpc_ioctl_set_option opt =3D {0}; + int i; + + if (copy_from_user(&opt, argp, sizeof(opt))) + return -EFAULT; + + for (i =3D 0; i < ARRAY_SIZE(opt.reserved); i++) { + if (opt.reserved[i] !=3D 0) + return -EINVAL; + } + + if (opt.request_id !=3D FASTRPC_POLL_MODE) + return -EINVAL; + + if (opt.value) { + if (!fl->cctx->poll_mode_supported) + return -EOPNOTSUPP; + fl->poll_mode =3D true; + } else { + fl->poll_mode =3D false; + } + + return 0; +} + static int fastrpc_get_dsp_info(struct fastrpc_user *fl, char __user *argp) { struct fastrpc_ioctl_capability cap =3D {0}; @@ -2168,6 +2279,9 @@ static long fastrpc_device_ioctl(struct file *file, u= nsigned int cmd, case FASTRPC_IOCTL_MEM_UNMAP: err =3D fastrpc_req_mem_unmap(fl, argp); break; + case FASTRPC_IOCTL_SET_OPTION: + err =3D fastrpc_set_option(fl, argp); + break; case FASTRPC_IOCTL_GET_DSP_INFO: err =3D fastrpc_get_dsp_info(fl, argp); break; @@ -2323,6 +2437,7 @@ static const struct fastrpc_soc_data kaanapali_soc_da= ta =3D { .sid_pos =3D 56, .dma_addr_bits_cdsp =3D 34, .dma_addr_bits_default =3D 32, + .poll_mode_supported =3D true, }; =20 static const struct fastrpc_soc_data default_soc_data =3D { @@ -2331,6 +2446,22 @@ static const struct fastrpc_soc_data default_soc_dat= a =3D { .dma_addr_bits_default =3D 32, }; =20 +/* + * Older platforms that use default_soc_data but whose DSP firmware + * supports the FastRPC polling mode. + */ +static const struct of_device_id fastrpc_poll_supported_machines[] __maybe= _unused =3D { + { .compatible =3D "qcom,qcs8300" }, + { .compatible =3D "qcom,qcs9100" }, + { .compatible =3D "qcom,sm8450" }, + { .compatible =3D "qcom,sm8550" }, + { .compatible =3D "qcom,sm8650" }, + { .compatible =3D "qcom,sm8750" }, + { .compatible =3D "qcom,x1e80100" }, + { .compatible =3D "qcom,x1p42100" }, + {}, +}; + static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) { struct device *rdev =3D &rpdev->dev; @@ -2397,6 +2528,8 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *r= pdev) secure_dsp =3D !(of_property_read_bool(rdev->of_node, "qcom,non-secure-do= main")); data->secure =3D secure_dsp; data->soc_data =3D soc_data; + data->poll_mode_supported =3D soc_data->poll_mode_supported || + of_machine_get_match(fastrpc_poll_supported_machines); =20 switch (domain_id) { case ADSP_DOMAIN_ID: @@ -2521,6 +2654,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, } =20 ctx->retval =3D rsp->retval; + ctx->is_work_done =3D true; complete(&ctx->work); =20 /* diff --git a/include/uapi/misc/fastrpc.h b/include/uapi/misc/fastrpc.h index c6e2925f47e6..63346e27d5e9 100644 --- a/include/uapi/misc/fastrpc.h +++ b/include/uapi/misc/fastrpc.h @@ -16,6 +16,7 @@ #define FASTRPC_IOCTL_INIT_CREATE_STATIC _IOWR('R', 9, struct fastrpc_init= _create_static) #define FASTRPC_IOCTL_MEM_MAP _IOWR('R', 10, struct fastrpc_mem_map) #define FASTRPC_IOCTL_MEM_UNMAP _IOWR('R', 11, struct fastrpc_mem_unmap) +#define FASTRPC_IOCTL_SET_OPTION _IOWR('R', 12, struct fastrpc_ioctl_set_o= ption) #define FASTRPC_IOCTL_GET_DSP_INFO _IOWR('R', 13, struct fastrpc_ioctl_cap= ability) =20 /** @@ -67,6 +68,24 @@ enum fastrpc_proc_attr { /* Fastrpc attribute for memory protection of buffers */ #define FASTRPC_ATTR_SECUREMAP (1) =20 +/** + * FASTRPC_POLL_MODE - Enable/disable poll mode for FastRPC invocations + * + * Poll mode is an optimization that allows the CPU to poll shared memory + * for completion instead of waiting for an interrupt-based response. + * This reduces latency for fast-completing operations. + * + * Restrictions: + * - Only supported for USER_PD (User Protection Domain) + * - Only applies to dynamic modules (handle > 20) + * - Static modules always use interrupt-based completion + * + * Values: + * - 0: Disable poll mode (use interrupt-based completion) + * - 1: Enable poll mode (poll shared memory for completion) + */ +#define FASTRPC_POLL_MODE (1) + struct fastrpc_invoke_args { __u64 ptr; __u64 length; @@ -133,6 +152,12 @@ struct fastrpc_mem_unmap { __s32 reserved[5]; }; =20 +struct fastrpc_ioctl_set_option { + __u32 request_id; /* Request type (e.g., FASTRPC_POLL_MODE) */ + __u32 value; /* Request-specific value */ + __s32 reserved[6]; +}; + struct fastrpc_ioctl_capability { __u32 unused; /* deprecated, ignored by the kernel */ __u32 attribute_id; --=20 2.34.1