From nobody Wed Jun 17 02:53:05 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6150E39B95A for ; Wed, 22 Apr 2026 03:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776827162; cv=none; b=IxYkWNr6qwKwm7RaVtA+SXH0fARthC8GwUIfkaRQYVGusmhw7YnYHukDN5uP/rwl7BenOXheI7lBxRCrr4XK1ufxurPCNNE8PXpAxhCNu88GNzNKoXAAmWBJsPAEx8qksRpMvvsoetWa0PZ7DD2MoVhNxtBzxrZdKAP+316S/mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776827162; c=relaxed/simple; bh=79buZRqMWZQxv5cCvNuYA6Q6naOk+CqWVTsVrBS+fAo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GgnaMK4Xpbtco5Xm5kJQmzol1uUhMPNCLevbayTyCv9CgIsue5uLjR0fkrpwibcWIuIWXUm/V1EbEEpU0mL+skaV1ISAK6XwbeIXw8dyTFKMQGBVqyJiRfQdPt+/ug75WXztlOCczJot5uLpkNK5qk0z5w5XeJpC0Gn444e2huk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AWIeeam5; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AWIeeam5" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a9296b3926so28450635ad.1 for ; Tue, 21 Apr 2026 20:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776827155; x=1777431955; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yEay/Zix8z7BU3wldFSztch+sq0SYs1KDcG9UwWstzc=; b=AWIeeam5DrqfuFYwC57ysmx8LMb3W7DzhrXT8bzaB30z+0Lhgz4+UUZBDXImmnWqQY fJCBYiD04O6fzufSlsYwsILo4ckbu294mkjKN0lH3ON9DcFPA60gY0rZ+h0K+5q0vC9R 44Z89LPhxjH6zdq+Wbm1IGc3Mr+HcD4ZTD+EXuvcW3xnY1G9XpnFqZH8unrSgYKbA0fs 4nMOHGWpYQaRSYfxD1Eyik2qS0r1y7khwfnWL/ySeh9tSgnRSssr2XNmXhYUdu9zhJz9 BRJJTgJxDOfkZy/IIomEYD5OohP6DpMOKzUKIBeHo5tVIshnlaZD5tjXMV6dr6Q1xTJl YbsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776827155; x=1777431955; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yEay/Zix8z7BU3wldFSztch+sq0SYs1KDcG9UwWstzc=; b=h8lVxKp/JE3UfnOLCmoJ66RXTt6CnTzqJGnWF0xVDntG6QGIMCDqyCdW1JdTdk6dqL zg+uF2V2Ea5tGPNejU71stkNkIxichPvF3V/Ouag9O6/LGMOdK4l/9AHFuzGdT/WtGmc IQcSRmTKHYjaJN4zkK3aycepqPXfIJUQEcL0S7fIOjyiAwiR3n2dFm7I0K9GS8mcpw/+ krSyQ23aos+DJxwbSFtjOjt639CBmawXHHrjewbUTlALyLFvEak11pE8wIWXkvYXkU7Y bjUUx/yK0AiJN4P7adJXVP9OqZmjXOCxM7NlKrKKRBpJI1x4IL3UBPymOIE4lkicb7V2 O/iQ== X-Forwarded-Encrypted: i=1; AFNElJ+DAUelfIlS/7SruJlJ0IXewllIh4Vr4XqugkaKdr/F2/fX1adMAprgJ6iRHrwvFbrijgFaN63OpUNYUfg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxq1u8oxzEbeSfxy/Tv+3IQuEkMLSTxYg6KdhAS1EujfH+mIgVa Q75K3k0zrX4Om7Nwg/dcjRXUK3K0Ippkvh9P4SSkvtWpaGmS2SNF0NFp X-Gm-Gg: AeBDiesnPIa3Q8furYx9e8oYfSHqXsaO60jwnwfqrgFiONJF/oXrjrIm/WDthtkwdko ouHvIRKsuYNRIfPhLyZzodhMjOPtsowP7/93LowYK6EJh5cD/rsuJ4fKK6RyZwzjfsw7CYTSLaL diIwiO5arbUpFLG8rsZbC+g2CXAlqILuGBxNaHsLgbCT3UpHC2zYGmtkB1RKxzwSqinbNh93BTi jgFIvUsEc0fwJhEACKmMmQtqn1fFIDn7uFyORVvgn/P/A3x/lKeI4SvmGKEnCuMXAVz4eW4IHBA C4KPwvjw+0sLfN3xpYstYL4pG4YqHguQyhDNPaJ7jNRhNnasNH6L9x+q9HkQZ49BRFYmmHQygy+ 7Fp5aQwCIUO4GZ0Wrur06jsCYXLaHwyBi2CCPa64FYGLxCSD5qpRt+zgA7yY2ilqq14kwpe7lJt tCz9/mgkeSQBsddGKZRSWQ7ohw8BupEwoXJ0SQ/yZ41RQBVPFCtWEwycwmkA== X-Received: by 2002:a17:903:983:b0:2b2:5256:9ce7 with SMTP id d9443c01a7336-2b5f9fa0f47mr224245075ad.36.1776827155409; Tue, 21 Apr 2026 20:05:55 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.246]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab3a929sm143792445ad.72.2026.04.21.20.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 20:05:54 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Namjae Jeon Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] ntfs: fix s64 overflow in ntfs_mapping_pairs_decompress() Date: Wed, 22 Apr 2026 11:05:43 +0800 Message-ID: <20260422030543.125743-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In ntfs_mapping_pairs_decompress(), deltaxcn is decoded from the on-disk mapping pairs array and negative values are rejected, but large positive values up to S64_MAX pass through unchecked. The subsequent `vcn +=3D deltaxcn` can then wrap the s64 accumulator to a negative value, breaking the monotonically-increasing VCN invariant that ntfs_rl_vcn_to_lcn() and related helpers rely on. A crafted NTFS image with a single 8-byte run-length of S64_MAX triggers this when lowest_vcn > 0, leading to incorrect LCN lookups and potential reads/writes to wrong disk sectors. Add an overflow check before the addition and treat the on-disk data as corrupt (-EIO) when the result would exceed S64_MAX. Signed-off-by: Zhan Xusheng --- fs/ntfs/runlist.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/ntfs/runlist.c b/fs/ntfs/runlist.c index b213b4976d2b..a32affb57d29 100644 --- a/fs/ntfs/runlist.c +++ b/fs/ntfs/runlist.c @@ -823,7 +823,16 @@ struct runlist_element *ntfs_mapping_pairs_decompress(= const struct ntfs_volume * * element. */ rl[rlpos].length =3D deltaxcn; - /* Increment the current vcn by the current run length. */ + /* + * Increment the current vcn by the current run length. + * Both are non-negative here; guard against s64 overflow + * from a crafted mapping pairs array to preserve the + * monotonically-increasing vcn invariant. + */ + if (unlikely(deltaxcn > S64_MAX - vcn)) { + ntfs_error(vol->sb, "VCN overflow in mapping pairs array."); + goto err_out; + } vcn +=3D deltaxcn; /* * There might be no lcn change at all, as is the case for --=20 2.43.0