From nobody Wed Jun 17 04:03:53 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CE88317143 for ; Wed, 22 Apr 2026 11:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856618; cv=none; b=O9VnHD1IxEzSZHAJmKldnvNRHCymG5a2CTIMMIrW1YXl4586XkmcRMEudnNaYUl7Bxb9yPCaHPO498phnsFDUSytExDD8pB4YRDttFaD+kikwTbLPuKwpFYF2jK2drkkaKVk6TFduxtjbyWdcP8hq9HP2eGgQ9EGXoFz1GBQf/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856618; c=relaxed/simple; bh=G6ZFBPo0z9LQpTfYNT7xUXOr5jQoLY8ztbN1qAozn6I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LxSspr+0auA/zixQk3fYKA1m7PC7B2hscWFKQKcnN84hdMBP0rpgu1LHOkej++/jvKqhCHs9rRdKeAy7PfLbBMNL7YUv2fIfUvY/Xl6DEvIMNSYAiyacGAe7WiWR5Mkmg84d3ucwd5MGqnrzgXmHDU1lS82VK2ADxdWRljQHBOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F8NedmIT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RNeKjPru; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F8NedmIT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RNeKjPru" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63MAEa2n2000621 for ; Wed, 22 Apr 2026 11:16:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7QfYSMr6guIMXdf3O06pHgZqjV/R1TMVX9fUxgcBlDw=; b=F8NedmITBx0SGJb+ nY4Xi6S/VvxmYFvcP27A+lu9ld93v2odprx4tSDLYhZai+1PWjOgzYxeeSeR9JpF 0QHQzmxSZJ3+FCgPuflgaYITQZq8arJKHFl+rhOPEs2HzKXpeZfE/OhOy8iQKfuH I3Fl08NklOFgbQE8YD8j14YbtPkBke6BUY7Uev6a/Me7wF9JExX3468HkMPKAol4 jPaNixFobAZLNxP9wwqm49+ZxnU0waJr7MeLeSpB/s34+/7DU8UoSqz70CW5ZBzZ VzfCbHz3LDkJds2nBHYqe7N+3Z+G+IRf5dB1Kn+Zpxvodjl23ieq7U38m8JkYFkK Fb6iOw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenfb6p3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 11:16:55 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-82f780a13c9so4084767b3a.0 for ; Wed, 22 Apr 2026 04:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776856615; x=1777461415; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7QfYSMr6guIMXdf3O06pHgZqjV/R1TMVX9fUxgcBlDw=; b=RNeKjPruC6z3Zmubba67AMnong8D06qDpHQ9ZDr7fZPsiCnYCKQuLSlhm0iy9jLGxj 0AZHBKs63Hqev8jtJtwgtXueIA0HIiQM61vlpSx0EanOAamFLgJr+TcA9Kl9YS9++MMV vAA2xHxc5IL65PmGCoWWZRcCxZyyb2xx8kEmHPwNSGFrje673sTlEsDmxpVu6CzQBzbP tBlDXQ/1lF2aEWXl6ZQMhrzXJkHBfhpGuO+lo0AyDyqBgFyv/hNsTafZzgLzx+Cay4I7 h2YtsyxuBH+QLlpStrCZTckuxtg2fqLBQWBc7dZ9bAwfqvZhG6DangnkipQy8BzmuvNb siIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856615; x=1777461415; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7QfYSMr6guIMXdf3O06pHgZqjV/R1TMVX9fUxgcBlDw=; b=G1xDOkym9a813LEpPCJ+AXlo6sO57gc2bmN4XdGS+3tNWleB+Sit36GknDrvtnPxid BIRjoiQaIr/YWNQbwC3Xy34XWvzs+eIj/w6WymlQh+55t0bJi5MmYc6hZS6j5Hxgu3IS /LXnneX1GKkahnLrG+U16/DPeSFwsMXU96Qcc+egTIPl011+pUZC+Tpk5g+5GHBuOMaC J+dJYV27Q3suS85RdN0Dnsgf0u3SS9vOJaQTsCpz8oGfnQkAgjsU36Jml6HqSL+f6UeM J1PhaBkFsnNbcsRyGX71EaSdxMTcRaPkicfhI0m989KO++3SuaeIt75c/C2VB4EJVrCJ 8kLA== X-Forwarded-Encrypted: i=1; AFNElJ9+W/CGBWH9yys/CclbP0QZycRYYwDAHj0ZbjFpgVN4k6K0ZjjPrC5PZCISKKTUX4I1H6dUosQcf4eateA=@vger.kernel.org X-Gm-Message-State: AOJu0YyWGPRe7//xw1s+2GFCXVjJdjHn/B9C+GVg6VONl5EN+9Ui/G3j pZ5GvEvs2f4gwDmPILXIn3ThMmuIYqN7znT/1WFCDRLo508pJseancjqbOE6xCZ4NXVN000k+zI uuAmkh1rOEOltSzUEvg+nUZpS3U7FWsfHSRoZzmIqindSmO81ayHYXHe79W3eSl6Jbl4= X-Gm-Gg: AeBDiesyVKPFulKhI1UZ6f9cmhcIrxM4F7j8IQ+o4ZDgNOGytb82I8EwMPftdNz5QLC gPy9nK+/MvXQ2AfbAJt5vqNfRYO0vJ2FzC9HTHLDI8QmJH4JCsA8OkbHFc3v7j7c9TWpxMw6iLs sUo9SWbI6Ji6QrGYIY46iRkRG66o72C4/ajd9GKbz51ZKg28X1qw1raRBSg9wESoElB085Ia9xk JEWXD1iz6sa31VC+fDRFtZPTf0K1zsFqxdW6Bxj9JW4SXsvbvnV2AMkgVu+gkRQE9kQ7MFFjvyM +fNZ9ZluPPIx08V6e4nXxOuRAzSeXLX19HldyyDqqyIhL/oPeI/+Kktzhz2H/VNThT5tUDPJLqo wPFMlr+jJuKKh86ZusEYfoStsbB5wXRhVjQHfCoHXWL6wP9hThfQYhgPayLMyoS2leis36Q== X-Received: by 2002:a05:6a00:94e2:b0:7e8:3fcb:9b03 with SMTP id d2e1a72fcca58-82f8b531fe8mr18696176b3a.25.1776856615164; Wed, 22 Apr 2026 04:16:55 -0700 (PDT) X-Received: by 2002:a05:6a00:94e2:b0:7e8:3fcb:9b03 with SMTP id d2e1a72fcca58-82f8b531fe8mr18696144b3a.25.1776856614610; Wed, 22 Apr 2026 04:16:54 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe901csm21100782b3a.48.2026.04.22.04.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:16:54 -0700 (PDT) From: Dikshita Agarwal Date: Wed, 22 Apr 2026 16:46:34 +0530 Subject: [PATCH 1/7] media: qcom: iris: Centralize internal buffer table selection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260422-iris-code-improvement-v1-1-8e150482212d@oss.qualcomm.com> References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776856606; l=7994; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=G6ZFBPo0z9LQpTfYNT7xUXOr5jQoLY8ztbN1qAozn6I=; b=efO/sBo+hgCNafAVgACO5Nw+pI3JmSKKRsDsbn2bt7dyuth8qPRvNzHD3dLVixe3iqy/LA31d oErJRweHuT5CX4+3bpS2SpF1LIiCFZpXnwsZ3H3hSTTSJtbG4hAoG5m X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: fHGCnmLxI27yXQ8toUo8bSIZe1eKjqz7 X-Authority-Analysis: v=2.4 cv=fozsol4f c=1 sm=1 tr=0 ts=69e8ae28 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=YO4-hHwgDu7wuGDVLqgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwOCBTYWx0ZWRfX6LS7QyrLvFvB iRe0wsKeiUOcu+27CySe6hV9+zC93ZAUo8wb56zcYIkexhCaJP1x6VgHtJvw7QQLbMyBRnqgkGG I/d/0ERdqkHLhHcSUZouHU2j3YGjnP/FZOUoYYMQZuDtNvVWA/FalvKcY2W/CJQJdHA8SRS1Mc8 47GYwYxx1TZXrAThkbaKqcryhjVTLdpD++CnTPzLIl4fzIyPmJgp10PZnZZQaoqZt0C5+JFk40C 8MsIWEoLBdlY1GN+XOjdQo6c0EoK+HP8lY9mMxYyijIZExUEQUWJZfEYoSr21FPIMnafIR58Ex3 TPA60x+vlSHy4R43tjzgvkeb88bQXm7EFGjk/qYz/cxx3Wh90v7o2dU/GQrlW/dFD45OAUakoXW YMLss3QztFFzepNHlI8JnS432cITF/zcxdFDTtGQud4hnhLpLFhJUaX2V2zGhtlcbIUbEBWcQFY Qgjh3O0xn3H5kCyxt7w== X-Proofpoint-GUID: fHGCnmLxI27yXQ8toUo8bSIZe1eKjqz7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220108 Internal buffer table dispatch is duplicated across multiple Iris code paths, which is error=E2=80=91prone and makes future changes harder to reas= on about. Consolidate the buffer dispatch logic into a single helper so that table selection is defined in exactly one place and keep call sites minimal. No functional change intended. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_buffer.c | 107 ++++++---------------= ---- 1 file changed, 26 insertions(+), 81 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index 9151f43bc6b9c2c34c803de4231d1e6de0bec6c4..137a69c99bcc24a72f4f27e516b= 8fb4d6509c0ad 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -299,39 +299,41 @@ static void iris_fill_internal_buf_info(struct iris_i= nst *inst, buffers->min_count =3D iris_vpu_buf_count(inst, buffer_type); } =20 -void iris_get_internal_buffers(struct iris_inst *inst, u32 plane) +static void iris_get_int_buf_tbl(struct iris_inst *inst, u32 plane, + const u32 **buf_tbl, u32 *buf_tbl_size) { const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; - const u32 *internal_buf_type; - u32 internal_buffer_count, i; =20 if (inst->domain =3D=3D DECODER) { if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *buf_tbl =3D platform_data->dec_ip_int_buf_tbl; + *buf_tbl_size =3D platform_data->dec_ip_int_buf_tbl_size; } else { - internal_buf_type =3D platform_data->dec_op_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_op_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *buf_tbl =3D platform_data->dec_op_int_buf_tbl; + *buf_tbl_size =3D platform_data->dec_op_int_buf_tbl_size; } } else { if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *buf_tbl =3D platform_data->enc_ip_int_buf_tbl; + *buf_tbl_size =3D platform_data->enc_ip_int_buf_tbl_size; } else { - internal_buf_type =3D platform_data->enc_op_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_op_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *buf_tbl =3D platform_data->enc_op_int_buf_tbl; + *buf_tbl_size =3D platform_data->enc_op_int_buf_tbl_size; } } } =20 +void iris_get_internal_buffers(struct iris_inst *inst, u32 plane) +{ + const u32 *internal_buf_type; + u32 internal_buffer_count, i; + + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); + + for (i =3D 0; i < internal_buffer_count; i++) + iris_fill_internal_buf_info(inst, internal_buf_type[i]); +} + static int iris_create_internal_buffer(struct iris_inst *inst, enum iris_buffer_type buffer_type, u32 index) { @@ -366,29 +368,12 @@ static int iris_create_internal_buffer(struct iris_in= st *inst, =20 int iris_create_internal_buffers(struct iris_inst *inst, u32 plane) { - const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; u32 internal_buffer_count, i, j; struct iris_buffers *buffers; const u32 *internal_buf_type; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->dec_op_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->enc_op_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); =20 for (i =3D 0; i < internal_buffer_count; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -442,30 +427,13 @@ int iris_queue_internal_deferred_buffers(struct iris_= inst *inst, enum iris_buffe =20 int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane) { - const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; struct iris_buffer *buffer, *next; struct iris_buffers *buffers; const u32 *internal_buf_type; u32 internal_buffer_count, i; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->dec_op_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->enc_op_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); =20 for (i =3D 0; i < internal_buffer_count; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -501,30 +469,13 @@ int iris_destroy_internal_buffer(struct iris_inst *in= st, struct iris_buffer *buf =20 static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane= , bool force) { - const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; struct iris_buffer *buf, *next; struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - len =3D platform_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->dec_op_int_buf_tbl; - len =3D platform_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - len =3D platform_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->enc_op_int_buf_tbl; - len =3D platform_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); =20 for (i =3D 0; i < len; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -593,18 +544,12 @@ static int iris_release_internal_buffers(struct iris_= inst *inst, =20 static int iris_release_input_internal_buffers(struct iris_inst *inst) { - const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; const u32 *internal_buf_type; u32 internal_buffer_count, i; int ret; =20 - if (inst->domain =3D=3D DECODER) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; - } + iris_get_int_buf_tbl(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, + &internal_buf_type, &internal_buffer_count); =20 for (i =3D 0; i < internal_buffer_count; i++) { ret =3D iris_release_internal_buffers(inst, internal_buf_type[i]); --=20 2.34.1 From nobody Wed Jun 17 04:03:53 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA3CE373BF3 for ; Wed, 22 Apr 2026 11:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856623; cv=none; b=kmHPrqg6DB9JI9f78NULaQgNV+c7TePBIPZEw2dzzz+irOjSm21wn90f22t7WEvUsNikHCDck71oUhIHXMYTTh4/RVl1EHaq4FINaU6o2ogWGbSQ8oNbjOIwYtwsQzCyaxawFIuE+2EGQeJd5VLpi3xFVrn6BBULmL9VDptICpM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856623; c=relaxed/simple; bh=VC9WposBlvve2ycacip2kliKPfx0sQcMrhIp6YST/BM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CQ9HiBPOYrf+9gZot5Piqy9ztiz9/hekkHmuHxE5y8htMb2dHKXDUA3NP9ruebMDe+HHUxeBYl4p6THxPR/aU847j4z+wh78sAIeBfXtgPvnRZ4ePPpuGHH6s+wavWzxZO7Qa4OD4oQofb1o9SMsRXGeNY2FwGAF591TtqRaUi4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mqdAaAV+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kaF0/Y4Q; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mqdAaAV+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kaF0/Y4Q" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M99E1a1082101 for ; Wed, 22 Apr 2026 11:17:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1lzMCwbAjL7qV1kx/Xu6U0s693kcoGBTXqWxUmoSiBY=; b=mqdAaAV+7IKvawnK iUp1aLBGwDiPYnLfgtZsGh8hpS9EkGQS4vcM93CPdxHKOpFtBYGz2kGCAnLKw2qf cDQBZaCfFQ1EZLwFAVhiFVIVpgfYadTnwICvjCF+VSnlnT9xE2Mmdhpykt/+7Dg3 OQj38Z0Kor19zIijR18RzyHy9aoiLqfQgPuVfl+m5JjEuD6dHb06Q7GbEnHXWJKS t1IvM0wG1ulN5RxPFcCIDNoCOZwbN9/Y7Id3p3wo5xjIZUQrYZpWtTDUfigZK2yf 70FKzK76O+/lUcnM6EnfkwUBt5IawivlAIutY02ODwXjPGKXaZd/wN4odk9nLOU3 8JYM7w== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpeng35gd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 11:17:00 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c795fa31e18so2606827a12.2 for ; Wed, 22 Apr 2026 04:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776856619; x=1777461419; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1lzMCwbAjL7qV1kx/Xu6U0s693kcoGBTXqWxUmoSiBY=; b=kaF0/Y4QH7Cl4qhMUKNo7KRS46x5mvU9UAm6gHHgZC43w+rpVHdcDGUNfV5z48U0qy kVOxh2MQNNS5SIAVklLHZSig7D6vfatqHYEQpJBJhHw0VTjQ2wlD3xv4Gs1Vj0KFJGql Ivycc3FzC+qqo+nXI57pEIRyE1JsjcGe9lzdCDQ2FfNiDu79dTkUFxKA6GaXFEjjht7Y 0dwX7o2g95ZQnpx9gRft2LaG59Yv3q18fK+Gx0lJdkd6ovnzfNyJauQdaK6qCq4AvZzZ xUouBK18MwrKjFlqVUIuhQTVy638AVPUdflD5HammIqgPQ09r28dAxebkNDBU5tAnX76 0ytw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856619; x=1777461419; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1lzMCwbAjL7qV1kx/Xu6U0s693kcoGBTXqWxUmoSiBY=; b=fpmsOAF4Cib6FUKhTqTu+k4zLr1o/90/LoaLCma71b9SeHJUQRXGIf7J6zEZJfd24I nHZeqtFkG3jNBQJqBqsDsDFCcIUEyBv0hb0nvl/FvkLoRaH9pTAvS6Tiy3DRN4ilS6EI 3dCsbrwXF0twOy6z9IALoB4nRy+4DM1T3QwrWZ5tY7cZosgXMWgGzdKzh6WKnrIL1Lzy 2NLStcINszbxIsFQVLh+xKEYnmiBosruO0M66GX1zItVZLWcFzLCpahdbOLBLvWvYYP8 SNtcoJkMVjYiMVyQ3t074SYQQx3isZNxtv6RwuHenFVfXwoeZbBiNxSUnzBx8m+BipJu x5fw== X-Forwarded-Encrypted: i=1; AFNElJ9THwBfTngKOfafqZMdNblAk1mHZOnqtdRq7AtPinY5wU5lHJ+3MWkYBJVOUnsfo6Tfp00kWaiSRtbLXVo=@vger.kernel.org X-Gm-Message-State: AOJu0YzwVp7d2y3idIWsooUK0QUIydWS5FrGBrU1fLQTBcgm0Y34pZZw p7XmXU+ZH4oh34W+Vi7Os65keR+E4kqg2mJVDkW8WanoKpsvTeYR6GCps4BQv4BGPEKuLvvz4he I5vagw9PbZIEmLDfBm79xj6dpsqdEoXvJUDSPuI/+cSMhvGbE36Ol7V5eOCQ0/4u2CYU= X-Gm-Gg: AeBDieulbZyDBIwsyxJIC8ARJXbbw6B6A4D1GddEz/EerBg9BgtGxZcdJgxUuZAX2T5 O46JBzI/cn7WBsWC86jX1sGWe4HEcVTIXLv3kYgc4GB35Lva36bDazK12IX5eYKehDiIXfR+VRn 4w5920Mzw435I2qWiq8Ey84aUngiwPpSZbcQVdL+ukVKM+aCH2DF9EXiyiJebiWqAwo/u0yhkjM Zd0sCP6b9qOwJx1JOKEIi6taYOl+W/nFy+UNiaDd3K8mpFm173TADM5uRYAIbLxvwUj1vMrNDs4 MrcSA/gGCN9uGabP9DRK8Lc/862asqpe4ZVicu0t2+3wawFfGRon+2PiEhw5Ru3CrmA6I/8Oe7+ 1Z4Y9He45QKH3J+ZQbh/v9EIhAFvVyjG8o2brZ/8aqxiJgtMlxhO+gf0aypFOCz7Js+gX9A== X-Received: by 2002:a05:6300:210d:b0:3a0:d88:6d6b with SMTP id adf61e73a8af0-3a08d90b33cmr25778802637.49.1776856619434; Wed, 22 Apr 2026 04:16:59 -0700 (PDT) X-Received: by 2002:a05:6300:210d:b0:3a0:d88:6d6b with SMTP id adf61e73a8af0-3a08d90b33cmr25778757637.49.1776856618917; Wed, 22 Apr 2026 04:16:58 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe901csm21100782b3a.48.2026.04.22.04.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:16:58 -0700 (PDT) From: Dikshita Agarwal Date: Wed, 22 Apr 2026 16:46:35 +0530 Subject: [PATCH 2/7] media: qcom: iris: fix state-change debug log printing stale value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260422-iris-code-improvement-v1-2-8e150482212d@oss.qualcomm.com> References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776856606; l=1218; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=VC9WposBlvve2ycacip2kliKPfx0sQcMrhIp6YST/BM=; b=XRyt4NbjzTkcPs9rnszE/7tjuhN52sg/EEloca15RHAHSaBRXfkw4g0GwU2zJzmX02gAiVEqk M4AOXfRReV9CCEqJ1oCXjgvecVg5cMWcOh8Un2GA0S8lT+oMllVdD2u X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Authority-Analysis: v=2.4 cv=CNUamxrD c=1 sm=1 tr=0 ts=69e8ae2c cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=xFg6UwmA3-Dp8VzUGb0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: bkgZC_ZBnp7qXoarEcQD1Kmm9HUgaJnL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwOCBTYWx0ZWRfX9IXnmlLKUuXB gmn4Po3uVCWwj7SYHT2FsesWzFh3BjAdUPIjZVVhvhr7EJgPdPnEtTpnfC7jp5h784KkbcyK6a3 H0zk7L8e4AlxOjyWvrM3lB+NUpgQ9YxvN9+dc0rujK8SfHeyVwy0TqIj+aGdTbX5dwDMFFI12bv anlGeCcaUinneJ6SUj/AV1ZGFuIoqXn8RRw8csiZf4gpQrovg/q0HhiMUW0hAe/jW9UPD9BJs49 ZWQ+uHmwWvFq1GDfxXP0sncVwklvwK0A8nrbNebx9x6UScsEVPJ2Eap0Y3V3CiHnj7t2jc8o1pz HqHzvLYT1v0OSFt7jRNSs7URT+CK/xksKVAg5azXxFKIW/icyozMicxgFRoDpqxyBJr2QKMumR6 if9FKGni9Ja+j9rCRu0Xs86xTWYzVeJZ8ZB1W48uB/aaXe3PpRznPSOzwiuSEFedLX61iDGEmrE CFo8trWF5JCybq0cjfQ== X-Proofpoint-ORIG-GUID: bkgZC_ZBnp7qXoarEcQD1Kmm9HUgaJnL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220108 The state=E2=80=91change debug log in iris_inst_change_state() always print= s the same value for the old and new state, rendering it useless for debugging. This happens because the state is updated before the log is emitted. Log the transition before updating the state so the previous value is preserved, consistent with the existing sub=E2=80=91state handling. Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") Signed-off-by: Dikshita Agarwal Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/= platform/qcom/iris/iris_state.c index d14472414750dc7edc4834f32a51f2c5adc3762e..e991f34916ec6e74f3d2cf98bd6= 1b8b1e12a3ca8 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst, return -EINVAL; =20 change_state: - inst->state =3D request_state; dev_dbg(inst->core->dev, "state changed from %x to %x\n", inst->state, request_state); + inst->state =3D request_state; =20 return 0; } --=20 2.34.1 From nobody Wed Jun 17 04:03:53 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06A2D3ACF19 for ; Wed, 22 Apr 2026 11:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856630; cv=none; b=QOb/qmK4KySMuQR5vsLjav9YzdeiLNSDwsXbWSaSwfVVFWiyX1hMFacm7WCI9Bb/QmHB/mIfEaEIc8FsMxjeeK63pp4HYUG4ksgQZrx+uo+RmWp0wV6Ivm0Fh3FDXga5NRRFlm1tdjTr9K4n3nrjH7BZXkqch4Z1hmsTILqMKJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856630; c=relaxed/simple; bh=Qy/Be5/4hsLlhF16qrlPI+nyPqg+3meE4d+jGR8bZvI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KYvzPYTWsFJNX0t4XO/gW+PirLwkOMxVbmtllJpjkcBT22yiSTYqyZbbRchn86RhBMWZo6cwrydX/YrplToPHMHw//Z6BSQ6b1r3gyenMkZglkhged+nIBXUcb12//wr5gjikQRBcMvVdrk0w5rmI8kmiMpNJtm5N+msjjXfDd0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=evK9AF27; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CDGbZC4R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="evK9AF27"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CDGbZC4R" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63MAp5gb2123575 for ; Wed, 22 Apr 2026 11:17:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8b4BYumIlUhTMjTFowWUiyeW6SXHWD9PMEUFmloo+xI=; b=evK9AF27Tk2AdAO0 f2E+GfslRDKFfqnvj3e8Zon3sXnPp0yAB20e9MVkg3xb1fy42rT7Exh5a+wFkdWw grx6ZwS7S4TObiAIjQCExqOemYRhWTuMGy/h3pysCt0zHqoPmgoQ1YT6RPBFyqhG FtGUGHQ6G8BlGIAXZIznb7rZTomARqnauVVQdKdvn4RDyjGrx18XAW78ZckgKwEF Xl/Zsqw3Tzb1CSh9SQm8/5lAEyhMjzu32awmSiGoQmPYtrthDC+2aW1JDrSs5YEH mMw8rQ63qqu+KGTsePERN+1ihOd24sWbWllw0uf4uH+1Nn51Lqr+/U3bjEu0Wx7q ILwIbQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenfu3y3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 11:17:04 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c79744a2d99so2245128a12.1 for ; Wed, 22 Apr 2026 04:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776856624; x=1777461424; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8b4BYumIlUhTMjTFowWUiyeW6SXHWD9PMEUFmloo+xI=; b=CDGbZC4RmHGZIHLjAImr1tspJfbD+6wLZZU1lfbiFSlq4b+xWJ08G4z99M/0dJQ9lJ O2hcEbpTEkrWgsM3BMsmZszbu1oodvpc2+m4H9b/KaL/Y2Y47m6X+GHNRKYmCtmfbmwm 4WI+b09piPnR2JblO5s0EUM8+KG7d/asou8TYeyeZXhgm/jq8feRZTFXIjirr2OT0IVn SY7AM0ZG18iATMFHOw2ERjf1LyEJ5cqEvGnlBhIrJM7nSurzUFEp3UC8PfEQ8N4BnETa QMqvFsUNJDOJTcKR0BS3t5q8LEZ037hJ0CV41zrpSYZkl5Bcnh6XBi++dzvUNQTnxF/B G11Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856624; x=1777461424; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8b4BYumIlUhTMjTFowWUiyeW6SXHWD9PMEUFmloo+xI=; b=HTMIOoSE28IKSglWyfaJ9uhA+Gs/nD3BgH0GQ9uTW3NqlbPTp4VHw8Dtb9Rp3F8/6m PgGSU/knuZRy4YxQgtvaFnE2rSk9CjXivzx3WqLBazfgpmh7SG9u445T5g80BCxnIt1y 3XMVyy91q658s88H+BN9asIjZaR9VdWp1nX6KAEMsd9NpPdfxiQTpv+pGVUjClig5cMa WNOCOWy2xMtQqYAkFOvQXFqxBxWp5vHGzcm8hGS1Qicy+DB0CqYBAqqvI+8iyDbiyhZc ZbgkVvn6WneobxYXhoR3QelGxVgjYM8njsEQ3t3Br/EUQziNgkiZiFkRCNkm2o7dmpGZ N0Fg== X-Forwarded-Encrypted: i=1; AFNElJ/UhBGDWpLWtGrYrRKGUOP33NaMnjVyvKMtqsHtW8EFIXiWnLGnhCj8QiXljVu9miLhHR5BqD1MJg+1HXo=@vger.kernel.org X-Gm-Message-State: AOJu0YwLg4REZe3OSxLq+Ew2Cz6UFYfLvfU1+ElP9oh9xllePGFkc0Vr 9fP6Czn8EVvGCUZsmD3nM+aWXAfe2KpRLwPQ+YPgq5diPv1bqWcjsEsPBS9P0ijt35PCWrqZdbE 3IscumQLNbSMlIs4jYlsxuO0nLu6QAsZZjqywLTdnbe1a0CzLIR5khWUMFUL8bRm3awU= X-Gm-Gg: AeBDiesZge8yFGuqCKK1Z1226RS6TD4YD2F9zTBv6T6EemAis9PPJW9uaRdPOP+DUvj IOFjP6QfbwTlOOroKeH0EMSM4k9SejFSvhsetS1XBDJDN+7h6eY4F5b9II8S5A5KHmpWQ3Y/d6t XGP1LsuamqeWrkqGsYdvTSvndErvgIt6StC/4vTb8tzTgNN615YPHcvWXJJrh43ViaV80cyX0oa 41xTM1m/fNE6HEANjsBVin6c+uVx9isUUmjaoFet7RkufnRahXy3oNI4rEGoWkXhDJ5k6tBLA+H mDySBftK3bq9UhI3ci34lyaHDPiGC7mH8CKV2bJGeajtNSyd79YMDs/QUJyS5Zggc1L+IwLKcxN CE2yNHOEMmZPeTkNtG39T/2qV0Mz7NP2Ms4Kf/S7sw2+J3PXz6BZ3pg1z5hSAWiUF9+UWHA== X-Received: by 2002:a05:6a00:b87:b0:827:441a:c970 with SMTP id d2e1a72fcca58-82f8c87e33amr21942485b3a.6.1776856623566; Wed, 22 Apr 2026 04:17:03 -0700 (PDT) X-Received: by 2002:a05:6a00:b87:b0:827:441a:c970 with SMTP id d2e1a72fcca58-82f8c87e33amr21942444b3a.6.1776856623065; Wed, 22 Apr 2026 04:17:03 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe901csm21100782b3a.48.2026.04.22.04.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:17:02 -0700 (PDT) From: Dikshita Agarwal Date: Wed, 22 Apr 2026 16:46:36 +0530 Subject: [PATCH 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260422-iris-code-improvement-v1-3-8e150482212d@oss.qualcomm.com> References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776856606; l=1180; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=Qy/Be5/4hsLlhF16qrlPI+nyPqg+3meE4d+jGR8bZvI=; b=jtm67hkpdalOgvSzH4iWBc24BA4VoODxqqL80IMpuBtOJuoHk/m36+f7OGigaor+2z76JHmEW pLTW4DHrlZ8AAZ/k6cD6npl8gKWiGTzz6UQb24JLe7nJcBPbSs/c5dH X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Authority-Analysis: v=2.4 cv=OdioyBTY c=1 sm=1 tr=0 ts=69e8ae30 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=et4WSneAAUjHYPCqp6wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: RxLqslSqZNHflvFbaGX6c17NBDpNhKZv X-Proofpoint-GUID: RxLqslSqZNHflvFbaGX6c17NBDpNhKZv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwOCBTYWx0ZWRfXxLrd1pV/taq1 iKpUMWN8TmrjDHCLrp6sBHX3zm2EzeC3Keq5vtAzeDa+lXJmsI0/WWEFa/Izcc5+wlhIyuoPZ2t 3iXwBW6wefzb5hRBoUEvMzm8rafJrQsCJMzQEhuCr7ec9tpNt0hlKay/f+zLmseOMomTVRf0ciL 1r0bim7jdfGvMJB9uzju5WJ1EDflS/Fj6lAmZgszKPlkR1tpsAwJkXSvRs+Llk2U6k0tbECugV0 N7o9htDA34qmRVy826N05AmlevoPsPbNWW/VDLT5DS3ux+ZxbbM9co5lFsbLPx7Pxc1LcQaluLw fOPZN9LAdOqetVh6UUOIyO4pWJ8+WTsT67PcgV6PMwm2RPW+WCr8C199K7W+D6E2Ib+2Qd32Shr nLG+p/xKHf6jtVLbYC65e6PPQa7fg5xITyLU39KnJmojlZA9QVNkeswTE8N6xlXmnEeIhEPrdOM fWR4n8s4opC76WwYztA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220108 iris_allow_cmd() incorrectly tests a single sub=E2=80=91state bit using a s= calar comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Signed-off-by: Dikshita Agarwal Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/= platform/qcom/iris/iris_state.c index e991f34916ec6e74f3d2cf98bd61b8b1e12a3ca8..5552725c614ea2e336e25489827= 0302fafa646c3 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd =3D=3D V4L2_DEC_CMD_STOP || cmd =3D=3D V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state !=3D IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } =20 --=20 2.34.1 From nobody Wed Jun 17 04:03:53 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7175299944 for ; Wed, 22 Apr 2026 11:17:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856630; cv=none; b=rTr+F/NcKs62U6D55WwtzxH/L96C+uGIrnTTFNNWwmqtQRqCBQHhJICpOktrfV/FqEQzsp0APeKRiwr5cpOt7ncK6oZCH2SffFwRpfOP25hiAbO4yDwLv88Tn6jIF2Otle+G9khqhMcEtcxa9wy4hn6X16IkMtTXZEeKf+MtxIA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856630; c=relaxed/simple; bh=wXJ29qJ9nlNpNzyVwmliOL00C7sS3Qrpz+U+LvAc1vg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jytTOUkiyxpo2CF9nFnTYBmh4MGmHTdGgxjklkCRAL0EKJ4mn1U/RXxvHIVczHAsmD3lVA7jZiTk0JDr2AYdP45bVVBDXXDuihDOf7SmGUMOhLAchOTxWcXIlO+RRd70JsdDpjtaS3Lo2hu8Ub//qRlfAJ/FdrGgFhp4fYeIHdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aefHxqmC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IsjRgdtD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aefHxqmC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IsjRgdtD" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63MA0oxj2000986 for ; Wed, 22 Apr 2026 11:17:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xs04e26vQV7jGpkvJ0zKvXqEfdEH1nMhkt/hhhJhtxo=; b=aefHxqmCZzs77ksX 1mf6Ed4UoPmmpl7U5DHc2OMIC4cc/5FKfXxK791YNq2j/a0F8jBetoiOdmb0DxfM schCHQKPpzQtVgceEIQpFk95y6+UIiFNbNCLPBz5Opy47N6ozzoQchczYloaelCu uuqML/EO3OE1ZOl4XyW7lXMdH5i1llz6lhgyy0GaclEZ4yXNKNj6JKBeOsvZs6H5 3Pts69et3Xc1MkzShP12dZ5i5LX1eEHtaZL0xrPOBNCUm0RFDDll0pGR4WTVvrga n+q6VHj/cV1K7Ni4SPr5Hhn1TKeqV0VDYpDPXw1GnA6MsDmfIve9m2scAqhgmbgq 6uwpKw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenfb6py-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 11:17:08 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-82f460260cfso5619053b3a.2 for ; Wed, 22 Apr 2026 04:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776856628; x=1777461428; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xs04e26vQV7jGpkvJ0zKvXqEfdEH1nMhkt/hhhJhtxo=; b=IsjRgdtDq+mYrErGJHQjYkQwSMAmWsh0UKXFrx3sNbcQNTj0Gt/2qt1F3R5TpaVgUP 07g4deUaFBjqRgIWA2oSwDz1GQJl3oxmeZ6hC+lm0OZ63DFgf9IVvYRWiVNh8kE9AR+c OBad7rCF5oe9DMTcVv+mheu5aUtUzJ65BmWxa108wmkZv5RUL/2JBD/6NG50mmULcxXH DUvEvnTCbB4mZIEXXWTLYt/lrRHhbHw4PRa64N+HoQ4c5qULmFzmHg4+n0agOeRzyX8p sHpuhoqcZErXLmgCxd2F78kIh0fT7hSrZSdfz0uDprKfugz6zyc5UCZ6S/LYYk3NJYev 6RUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856628; x=1777461428; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xs04e26vQV7jGpkvJ0zKvXqEfdEH1nMhkt/hhhJhtxo=; b=J+nUm2g2H1hNfrYMcsqLCslX3IcuyeyO++3Krftx4+we6nUb4hCO71YIOV0M/O3MvT QOIQ55nVGXtKPlbAHfcYxkmyJXY7D7uQnKdIDXiM3gn4uwHfk3OHwSly0Z2BK95yKTBB V8wb5h9E6l0T/VcRE+DXUpq1Z+LWiSdb8fcL5D+XuDUOLqxYUTkP9YeOlPeREj1K1U/n vppO+pCaQz74rZbOcPODCSZsZZxh17IRvsSD5y5MhluJVWQGNtBQREH0kooKTiqOw2ov l6or5Swo0qofgIHB3bfxDB4JH251YhS1wW/bzkVOvxUkfVIHeM6OLWo2mNUMSSdnn7MY loTA== X-Forwarded-Encrypted: i=1; AFNElJ8xvFp31bzDFPOqr9ruqn6Gpz85uX1EJVTdoS29djIul2OaS2rmT/94+jBJJJvNClo5aQpJtyux1fBKGLg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywx7sYvncydokmQXTxwWn1aJgLSU2D111WuZnBdw8seDGjtYTQ1 uKjve67fMD4DL3CqlHA99rEEOOXSvTp0KTOcPv69bDyUyNXXQvzgRg4Bh3rAeHo/oCG4h23njkE q/t9samAhRyHZuoUKWWcVa0Im8AdGbfnxQlWeYCB548VRyHet4QpccOhUqybEC9Rg37o= X-Gm-Gg: AeBDietXyJCEjWUiB6E+MklpSXoR0kgD/YCNpWj+DrE801ukJDE+cl2ZaWm50A6snYs ttv89XOe639McgWBW10ZvhOEqKsCxL0tsXeZKf4oyOkM5jyUNDKLrpcqoycNm9SU42IXz2xes0H RD7uvCzHigST0Nd4e/c/ef+NBD7UOt2SwwYb8ZP1ndHJM1n8wmc2Rnh/OdzpzuLdDzjjPiUrAwT AWvWO1PabzKChWZbMVZy7k7DKcbcG/sdzBO5ZpHKt2qdvMI7uhbBuuzisdNWrXmybjKEK8MsWIh pqP6MD/a+zY2oA61zIT3NR8A5ttkfqf9SmqH8+KknWWyjJfc8XFivF9RVDStsXGwgIW+j/x5lWp Q4bOJX0ypvqBXPOfPbGTtlXYjFlR8pSIeaCwZuWlffbfZbdtwGOYMpZl5Dx5a4sKtszvRAw== X-Received: by 2002:a05:6a00:418b:b0:82c:7383:3745 with SMTP id d2e1a72fcca58-82f8c834458mr24017237b3a.19.1776856627650; Wed, 22 Apr 2026 04:17:07 -0700 (PDT) X-Received: by 2002:a05:6a00:418b:b0:82c:7383:3745 with SMTP id d2e1a72fcca58-82f8c834458mr24017201b3a.19.1776856627215; Wed, 22 Apr 2026 04:17:07 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe901csm21100782b3a.48.2026.04.22.04.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:17:06 -0700 (PDT) From: Dikshita Agarwal Date: Wed, 22 Apr 2026 16:46:37 +0530 Subject: [PATCH 4/7] media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260422-iris-code-improvement-v1-4-8e150482212d@oss.qualcomm.com> References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776856606; l=1385; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=wXJ29qJ9nlNpNzyVwmliOL00C7sS3Qrpz+U+LvAc1vg=; b=HEE9b1ozEQ5M3v70/DrPcmLmew3bbzldxzNVN4qPr5xTc6TuKxySSJy59Uj9Ipc1K8v24GIxd WTMlfSpg62wCT0RBX8rTG6OxqfoUkt1OYpT329WLi1s4IZu8bfM/GUZ X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: axWf9DkW-_M2Rnl21UKvOOu1GOo4WNMe X-Authority-Analysis: v=2.4 cv=fozsol4f c=1 sm=1 tr=0 ts=69e8ae34 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=baIckf8PCApkX7IVpfsA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwOCBTYWx0ZWRfX8HaxDLOObefq uI05YkFrLngHaJoSyWNxDOhuiOWKLP7M+9pc4gALyN15HdT+mF2g5iHUmxk5TEUNmCmc2DkM09B XZQYfD+hCuZKGXlyShRz3EL8s5cILg2IsJeE7bDPu/R13AcIueklk29GxexRC08PKggNuqRKGyc i7qSKuY4gFSUtAwcgaYgKQoRrwo3tk0n4O0o3Jq+Ys/zsdk1rqeDWVdqobcG72n0hBwIt5o99P5 BuobK4Eqksb0RQL255L6e4nisSJSFuXFrN9DDk6beiWVWoprp2qY4iJU88hWrSF3pCn7jC80I70 rAafxeSIknSs677aGxHCFCvjrWenjhH1dQpJtOJ453SOPQ08Lri3Z0oN6GcSumlcPITuhFs7bzH cN55SMzkTzupsHtSZBHE3Y+mXl8D0HpX0bPlNsXUG2Cqo3KXRjmOSbz+IHjG4+DBZcW1XIRLyth qbddEx/oy7X9giA3c1Q== X-Proofpoint-GUID: axWf9DkW-_M2Rnl21UKvOOu1GOo4WNMe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220108 Fold the ternary initialiser directly into the variable declaration, removing the dead store that was immediately overwritten. Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform capabilitie= s and properties") Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index 30bfd90d423ba024caf6ececc827f7102e8f3324..06698fde639ec654ff9ec78a178= 271ab2284f5f0 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -536,10 +536,9 @@ static int iris_hfi_gen2_set_tier(struct iris_inst *in= st, u32 plane) { u32 port =3D iris_hfi_gen2_get_port(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLA= NE); struct iris_inst_hfi_gen2 *inst_hfi_gen2 =3D to_iris_inst_hfi_gen2(inst); - u32 tier =3D inst->fw_caps[TIER].value; - - tier =3D (inst->codec =3D=3D V4L2_PIX_FMT_AV1) ? inst->fw_caps[TIER_AV1].= value : + u32 tier =3D (inst->codec =3D=3D V4L2_PIX_FMT_AV1) ? inst->fw_caps[TIER_A= V1].value : inst->fw_caps[TIER].value; + inst_hfi_gen2->src_subcr_params.tier =3D tier; =20 return iris_hfi_gen2_session_set_property(inst, --=20 2.34.1 From nobody Wed Jun 17 04:03:53 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8AC23CF043 for ; Wed, 22 Apr 2026 11:17:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856635; cv=none; b=iOLbYmS5bJW0QZZ3hNGsHrTA9DgXA1cn4GN2WK0H7mC0fXuLTVGjEZ+Qzq7k/o1zc6OOp5TvCSY4jrXWhBhabFXBbuauuUUElSOnnGER6ti6l9rWv35qDuqafZEqVwplxM4+S2PcjL38R/jru5TFiTlHvN8PhOttoJCmF0oKtKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856635; c=relaxed/simple; bh=cZWoW0QtVKH8JIVtUlT67HMSZVr757vitB1z3b7VwJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uArbCtCEQrPCiinvb9FxkTdBiR3Ps27jdHfkc1J1D4IsxASGPfZU7An+VjHxd/l/7/FDgxV4O3ANddsbUQiKYcIwhSkfzxQi3RX0Gc69E8P3sZn8yTAT21jQHLPW2uHDooPnYi415U5vizlywj+XAsx1HF4Yfvg+zYv4vE+391c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Yi3OISCY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iCymLkcr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Yi3OISCY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iCymLkcr" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M98tpH2063469 for ; Wed, 22 Apr 2026 11:17:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DhrOe5+iY2QBpjWGl8a6mJqg/wd0SGxajIelouCwIfo=; b=Yi3OISCYxuQQCkiK L6sYlAGHivF5uV5jH6ciqnTC2Ui9y7gOQ7HFyQnb0FlwJRfXN3yxItO5RkMyrZrY iovkB4aIZcHSDa2Ur7eNHJK5fcpC1mlyW9VXAlwFG7tj5Sj/6104KJ05wi4CQTvy nf//0BCsVpbzqVGJ+pqNgLO3DdE3+ug40a2rGbwUlVYTFG7m3nscX4aAy0gaTZxo 11zF3L3WTG93PTeeeNhDfPTVcyR0TNhDalopDSjrUiTHTvKEg0xgRS1XIXmYWUQ+ nzmkePCYOxoBDuZuTk4bl+LxCl2kJW8VTXsXG9gu41awvJqwb/2EaefaeRck5l24 6vyGQw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenhk523-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 11:17:12 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b249541063so47288535ad.3 for ; Wed, 22 Apr 2026 04:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776856632; x=1777461432; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DhrOe5+iY2QBpjWGl8a6mJqg/wd0SGxajIelouCwIfo=; b=iCymLkcr10/GXsL0LG9z5l2lOwqpw1W6583L0ghpB53q1vyejETvtJG4IL3cZjnbIX OYWX/LlXUmjC8JE6wSIxPpB29jqX4YRz6h2z0G1pKolIGK0Y7Y/RCEOQu/efQxuGF0RD GNWqH10MazPifid0m1futx/f0+zjOgC0o7q812yq/6b+02BtBrSmwaO5T7J7yf+lz+Dh GPrmsbjaICZIgBsac5uYYmO92Q9Zw8RTEZ4dpKYEeoyJzeexYgbnQ6CYPvHI7iwUNy7m UEQR5gefH/mJvyup2hsYOlIiRuCXNzyiFTe2MvTrz8uQsHNn8eg2bMotCZR/V2zLn8iH Vj3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856632; x=1777461432; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DhrOe5+iY2QBpjWGl8a6mJqg/wd0SGxajIelouCwIfo=; b=Avsbso7TSoeUEsnNsXek7AH9FM8PpOy3ZdthbiaP8S1Oo3+BmFTyqV21pBHl4Hemnp RcfdpGIZWk5C9AiSN5NirTlYGpXWvEDxj+ElvTJpTne9HQJ0dVDfJ7gMo4xUkWgXNehX vYtLlTOND3yxWWXXDraA9FhZ3/NtvNZyfBlN0F2ytLv1j/ANVr7YUjmVbQTQL+hqhlTO YWybZy20w55dEiQqZh8tMD8MullfvbsIroZDXEnp2s1TlwF9c5ZyY+FyRv52SpgIyWeG tCFGYych+Ji0JxAZRmgeBz2YBEK2riEzru6AGosGb76KK9LU6NH0R9a9u9KifFZaxbCx 5LgQ== X-Forwarded-Encrypted: i=1; AFNElJ8kygE6dgbdBQl6/h+cjrBcfkSe+4h05dbxXtja4lpBKoYU+H3DtYKni5ucXeWtOcOs0su45LX1GoA3HqQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwOy9xHZM01YdRMYrmxwderf2kGKYPplOeGQ3jVmVdU27SULmzk 74ixokJOE0CkN34ZCAEakLvc7NA7vS8rNKSThcrMgG4NrV7b+EoPF/lNb4V+9yaLwfvthKzinez IW/yprWodtwZUInHqeAklC9ClryGn1W5cEYfAcB5VenfdAld8jlQ3IIKX4nCQF9ZXE7Y= X-Gm-Gg: AeBDieurBm3ZOi8lrRhBsXcwhvrc1sPKcW7/i3AjaqTER1OP9EKiDBZhyV/DUE2/uO2 HTI/5sia45E/f5POaT1GEC67nZ/S+lf838ZlBkTrbFMHx443N5VpEyp1oNjEn4z14Hr9uN2lwL8 CwB4c2vS6HAltBG4OqYEqi1acHB5UM8jUJpc23nuImFkE77OQXSoPqnWgpWooGDaxG2lB4I5wcm 1C+CskrFyTbEYuC2lalblTamb6wsSRgysnGt9tDRKqCllPF3Ex+pjjQQ86Zc6SNQq/guNSkNi0D h8hWipe7XsMILkbSNNF1BN6rLTEWRfAirEkApO7K+XbQIR5arFrooG3qfOVZdltF6mM7D/x+csf CXyj5lM6GeiGh5DDFCGPhsfX4SplIXWVQfRrx13oIhlbe+pRdOUjFuyIG7WsA8QFlZO0AIA== X-Received: by 2002:a05:6a20:a113:b0:39b:c9ff:e3eb with SMTP id adf61e73a8af0-3a08d6879c8mr25419763637.4.1776856631796; Wed, 22 Apr 2026 04:17:11 -0700 (PDT) X-Received: by 2002:a05:6a20:a113:b0:39b:c9ff:e3eb with SMTP id adf61e73a8af0-3a08d6879c8mr25419727637.4.1776856631301; Wed, 22 Apr 2026 04:17:11 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe901csm21100782b3a.48.2026.04.22.04.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:17:11 -0700 (PDT) From: Dikshita Agarwal Date: Wed, 22 Apr 2026 16:46:38 +0530 Subject: [PATCH 5/7] media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260422-iris-code-improvement-v1-5-8e150482212d@oss.qualcomm.com> References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776856606; l=1298; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=cZWoW0QtVKH8JIVtUlT67HMSZVr757vitB1z3b7VwJY=; b=x7UK8J0rJmpaw3XK3wfvpIDBpo0KeW5jh5IMMR7ZopJl69ODuA+YWEzoVCDscfVphPiV3/T/0 E2Zfhi+UEK/CRYUcKGyKF+nhyk82zo7/ayLi4OqgEQZqwBu/CRSYn6J X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: 31d0jobs9vEkxz0LqWE73mHk8d1jQS6M X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwOCBTYWx0ZWRfX4slrRCjfOpJb x+j0rnhYO1cOdzKf312PPwnQnfpPhUGuYiCMl9P7cOjcyGylpyqrgtj9qWoBwGGTSV7U5mmaOJc xfi8z7n+dMJSd1VOdOPKZPJPCmJbL3Wm6vVhV0MOp9AU6D/i4ZE8KnvbR6Jk6W8fY3oNe6RXFsa BUICgGvG7hewjSXHfDaIkxQkgSuC1vI1RzQlz7hRSx417gtnYnTPFd8ob/1I40vjwW6AuC1tDyQ OWOjX8Vb7iTL7q3RnsULxyBKjjxqOBCgZxC+nmzHLtf+czIeCpdVUWmlR5hL5ff7AfrfD++HrBd VdfzwmvQ2BPymt0m/Vn4SuDj8xX50tsfzoe0fEIC571Gkfdi9ScqytcZRNumdQmmlVXEs3cd/EG SoEORqDvo3MQCqErK9oX3I9B7vrkVOrPHwWDXMh5RY9Zu1M/3KQiClClqwtSMBGs2IfjL2K3zeP aZiBRV4vuFx/kjliYfQ== X-Authority-Analysis: v=2.4 cv=WKJPmHsR c=1 sm=1 tr=0 ts=69e8ae38 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=jSGZT_DOcC9zL5wkuQYA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: 31d0jobs9vEkxz0LqWE73mHk8d1jQS6M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220108 HFI_PROP_OPB_ENABLE/iris_hfi_gen2_set_opb_enable appeared twice in the dispatch table, causing the property to be sent to firmware twice on every config-params call. Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform capabilitie= s and properties") Signed-off-by: Dikshita Agarwal Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index 06698fde639ec654ff9ec78a178271ab2284f5f0..dc7acde1913e65eb39734702cb1= 64bb26b8ea6c2 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -623,7 +623,6 @@ static int iris_hfi_gen2_session_set_config_params(stru= ct iris_inst *inst, u32 p {HFI_PROP_FRAME_RATE, iris_hfi_gen2_set_frame_rate = }, {HFI_PROP_AV1_FILM_GRAIN_PRESENT, iris_hfi_gen2_set_film_grain = }, {HFI_PROP_AV1_SUPER_BLOCK_ENABLED, iris_hfi_gen2_set_super_block = }, - {HFI_PROP_OPB_ENABLE, iris_hfi_gen2_set_opb_enable = }, }; =20 if (inst->domain =3D=3D DECODER) { --=20 2.34.1 From nobody Wed Jun 17 04:03:53 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D38F33E34E for ; Wed, 22 Apr 2026 11:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856639; cv=none; b=BrOwjjcrmGGudgwpthq5mnhtKrkbheEo6Rf5yK57cDziZ68FqVcjEOl+bWPdqmJp7G9kDuM4F4NRNtnSKYzsd2lr8BVBeEcVTCvCLrboJwbYn+sDUaa3BnW+gqM3Kd6do1s6p8M5T2RUYWhMawmxFwBA0Any+sCTMeWU+Id/D0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856639; c=relaxed/simple; bh=g9IR8KnHH6+1Tmoj7gb2YK2cNjAd/VRLFVaxwWPe/vs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JozEgPI75N+QxVZIPaw3RccrLtSmmt7xg1CNjhQk21TlVU3oM0jixMn0AHLfc2dwCX9lCI+9Zf5Vz7BnkwwkZIfXn+CiXPg7oiUcaOo6fndBwUNr/+kljxiBWeDUGGtYTtvXHAumS1K9W8KAW7HeJYdriEscmZBBMJh9lqoaXP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iCMKw/MN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZXZSZEfH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iCMKw/MN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZXZSZEfH" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M99E7A1443728 for ; Wed, 22 Apr 2026 11:17:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Km58GpJkLRFDB0UlfVyXA5qy9bxrBogWZ7Kd/EqcNDE=; b=iCMKw/MNYv7m1xB6 UaoGnjfHWgbFh+KnxBBd8ancih9iFc0NRw22cKtzIt2AZyhJpW9uIHg6SskpysvX SpImGjlzOgLEYNq+jVnh7cEwtk88y02/lqJX+ig+qvBEkjwc35DX1GoX0QooXRRk XFr7Z8LH7FZnJAxoEJ0E7n0PDYBCq0HERo97s4V28ZE7fXYMb6ofIdmweP8uBnao IEBye4cQ29AwzDJK0TE6iocaP+vklsXTV742yMWFpQBDxNyejsAIpquoGwzniwrk S34oQ8Gb6dAy3oIP+vgo3m4NVMcyc66jo4WPVgW4oOTgvMfCGq6mVkNZ7frBtbcS La/DQg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenfu17x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 11:17:17 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82f74bcfb86so6345105b3a.0 for ; Wed, 22 Apr 2026 04:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776856636; x=1777461436; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Km58GpJkLRFDB0UlfVyXA5qy9bxrBogWZ7Kd/EqcNDE=; b=ZXZSZEfH9QhHCCm9xnC7UzNuCANdVc+jZBJ0xq+VOM0W/pL9WOZAbPzOm4P+9RxdiA nZxUDU/7cs0LbWsiM5I2Bftbk2sjgm6ANkliXrKb8p5ZcpYFdydQFsw05B5EcRIhJdM+ qCuPebVIhsaukuwM3mvD203avIqmO7wKt4Gk2052y/JL7fsM+eD31ltXGzFpr0BzOZUr /+RNZMpOEnwiSPQjKPYS/zf11h6nojAYNqg/ltxl1lAQhXOtGwdBCQ8+SfSgu/xCh+fl 9hmfFV2tVHvpIjhzEorSKvOUznoZsZBQ9imGiJHRcnafQpwXIpshdaCe5owWN4NCpVuM uj/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856636; x=1777461436; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Km58GpJkLRFDB0UlfVyXA5qy9bxrBogWZ7Kd/EqcNDE=; b=THbR1xGIwf4UzDfSICTPGdVw8z/337W903277wrlluOlotxolrxTfSzI1KNTcc4mtc nQcTkeeYN82crNxYcWfDDEeLB06Z9nPclQFgiLXuWeMPFnla/YYzswvOs2Xxn5/TNn66 cWRdpZQtur5cZ2U/l25IimGIh1cY4ZMP/sxTgwAVL9ZYchvx9zjCkBLVer021rhU8ZJj T2hoPcdHNNVxGKv4V/cS3CZiDQN6/8i9qyNvzoRx7JAfN0s2X80FMueOHXqAlxO2W17f eXUO0ATPWZ6wEonzJHeMXth2ZQ5CQLGTmv5EMhqs6t/pvLz9n+v72mMtIk21p6aBzfrV fMgA== X-Forwarded-Encrypted: i=1; AFNElJ8UCZQtr2l8mHD+0fiGBqAdjo5c7wfeh8/uzDAlzGDb6C4USk5xTzPmMbUQLU31PbORVebBfa60/GlXsJo=@vger.kernel.org X-Gm-Message-State: AOJu0YxFwGc2vhJq6iE0Q/THw8UiiKdhH8Qyeo5kR1N84NrYd7FBbc2s YASGXexhk9JIRQJo5ZUjNGcCbsWB8/dugIZXDVyPDJCoYCbmTzIrzP5ZVkgN280CrHulsb7wH1a uotxPW/hz1PL9ShnBANOK8OLIzWfbV9rpo6nCZ8TDV5DTE9RvzP3sOPITKDZ3EJO3UQs= X-Gm-Gg: AeBDietD3lzD4x4ACWHbWbxdHMmuEw/JJcsjBkIFSLidKYW5hD6GEtvtQql2uEhGW68 yjuzPjOMWl+nWZFDTtLDB4Raf4I8zBRNuuptm5RR9/ramw4geljh0wnWLslGyf/kfppneSuv7tb 3m2s2KB7TA70gFqMT3o6NfguWJK7QV04SKkjDQshMu8G5wsTOAFlaUgf792Nam856G8nkUjV5r7 6xr5C/CqU1uRzRtoBFuuksMpD0P1kWot5sRUAJJEvxEMPbOGtU8+3qoVsdstZtkUXtRLBJXIL/z 46LHyuJluN6ctwMPv3FJyVZv7G6s2l7+J+Fe5kQpoCG3OAvqfAD9J0csC10VaKM2/5Nh7r9BDop 96ZUf5AN8J3SonD+lnnhPzSEXV7SM1pBGL1Dm7pr0wuFPwQrsuc/wckfgN+Gs+DCIVM8KYg== X-Received: by 2002:a05:6a00:c8b:b0:81f:5037:a317 with SMTP id d2e1a72fcca58-82f8c852deamr23556156b3a.11.1776856635984; Wed, 22 Apr 2026 04:17:15 -0700 (PDT) X-Received: by 2002:a05:6a00:c8b:b0:81f:5037:a317 with SMTP id d2e1a72fcca58-82f8c852deamr23556115b3a.11.1776856635447; Wed, 22 Apr 2026 04:17:15 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe901csm21100782b3a.48.2026.04.22.04.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:17:15 -0700 (PDT) From: Dikshita Agarwal Date: Wed, 22 Apr 2026 16:46:39 +0530 Subject: [PATCH 6/7] media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260422-iris-code-improvement-v1-6-8e150482212d@oss.qualcomm.com> References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776856606; l=976; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=g9IR8KnHH6+1Tmoj7gb2YK2cNjAd/VRLFVaxwWPe/vs=; b=juH8HyrkSGURUlxLT/h8aMnPuevI6YYYK2DueuFH0IgBoBEtOvTxCX53QeJb2ogHWvDVr7huo 3MdJeJbF5n4BTigQ/BqeWUxZzytQICjCxbrC2MccDduq7f5i+pFCv1A X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-GUID: hXuRP0fjaXAXr3lTSkyI--FWEkO8cXlt X-Authority-Analysis: v=2.4 cv=YJuvDxGx c=1 sm=1 tr=0 ts=69e8ae3d cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=TZpohm96M3O9q7pB9U4A:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwOCBTYWx0ZWRfX5nVZy4y9rGAQ u+R8a2ncE3TX9Jc2m9MlfE/ASjkTgIpxDIwLwnRHJikAnqC9qDMmewOCRfvuFwitVnLzvAay/32 6rVEvgBRrlhApGB9+YDs78DPpnvNn73/Z1WMWFeKv+1At7GYlhFPBznGJY71moUO7hG6mZrgjxk DY/ywgWIdPD7upN1+daQcFqXw7Sor7QYFG7tfdLlS82Er/8OXXXnXq+wiILTfVZSetk+JI08lmy PcYrqJVJf/y4mkcyxwz4SN1gStubLEvn0rsg88b6eMS/VkjUhHdpzjTEBExV8jtShir7mTmOci3 4YPenf8SGC5ppuEgkl5aCvrnvGybh+f0CZs1PNIljosKyyPZ41kITRt1qoNouKDQevqRNy09F8X VkJoCn0/NxsRYWCR+4MJUwJFMuxvue8DUhINKhEVQT5/gxfOrcoC0DxNUDwchx+s4z+qEwGYreX jlnX4zB7Oh4sA+niy8Q== X-Proofpoint-ORIG-GUID: hXuRP0fjaXAXr3lTSkyI--FWEkO8cXlt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220108 Without the break the AV1 case falls through, risking unintended behaviour if new cases are added after it. Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform capabilitie= s and properties") Signed-off-by: Dikshita Agarwal Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index dc7acde1913e65eb39734702cb164bb26b8ea6c2..494c8d9fe14b4d347fcc3bb3cfe= 494365de360d3 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -696,6 +696,7 @@ static int iris_hfi_gen2_session_set_codec(struct iris_= inst *inst) break; case V4L2_PIX_FMT_AV1: codec =3D HFI_CODEC_DECODE_AV1; + break; } =20 iris_hfi_gen2_packet_session_property(inst, --=20 2.34.1 From nobody Wed Jun 17 04:03:53 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1643A3CFF4D for ; Wed, 22 Apr 2026 11:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856643; cv=none; b=lYvP8zM971yQfF3cJFQj6A7CstUGZbfVu1Q6SJI8sSIX1GY/3uVnSVM2us8BmbpvXW9U88WQFEYX2joDyPDqj6DsjEC29dZFKgb5aOZYe0kO76gD1cbO4TbHqBWu9Jfepn7l6fESGCxw2AQFDRjTKYLcuqXg2gguZwUXi2o2w9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856643; c=relaxed/simple; bh=Jbh3ewlZURHGfxOIxegETw5Vx0Yr6tndGi7C/P8xCaQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iMvx9YU/szELbbK4NyypqcvVJE8qiQjxjrX3XUuHBd3PxwlU7d7rNJJWlT0M76gKlMFeOwYU2iUgM5SRvMh4hBrEFf1910qN1CDOlliObAfPEUuYf0YRFzp6prgK+7wzKhPaPTC2+eBn3d4FUUq7X6XzauW87NqXmlXlCAkl6ew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i2zQ4VB/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=czaKztZO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i2zQ4VB/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="czaKztZO" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M5CbSS2935889 for ; Wed, 22 Apr 2026 11:17:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rKFQPgjt7eYtDdi6D75h2wv4cgPqa3Hgwpc1smHTUzY=; b=i2zQ4VB/HX0Tjxyz fAHYm4iwcjXu0FQisdj0mQ4EU01nHSXfoK/Q1Fm54NyO8EeTaaoKS9EmH7fL6Yf7 BgkHIGz1Z8wWPyT5FPwO0+1/jBBofafFVEy+LQ/sy48HyFa0DRI1f5uv3h8Ls/Vm mhY6itvR7Eej5jsYCN14PrPushRx0wZmi4dV+9yUo3MDT6NjqRNXVZa2R/vf2BfV N2jMk5a2/9a8dMD8D5H64gh18rXd8QU2btyH2P/Kh/mw1zWyX9dNGoGd7UAY3ZaY C1rKLppBCAjzYLuBq9DdlhS4A+51gSxE9Ntfhl+5C5OAn70hNpipocR6hpUym/js +1cLMQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenkb20r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 11:17:21 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82f9429f49cso6279658b3a.3 for ; Wed, 22 Apr 2026 04:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776856640; x=1777461440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rKFQPgjt7eYtDdi6D75h2wv4cgPqa3Hgwpc1smHTUzY=; b=czaKztZOfzmSZrIjaFQhB1gvj/LrnkOQz90VAhgvGPZ7xd0f8pBk0uvxDfUAbI3/FI PDHpUM7FW+rL+K5I+dgeC8MA82Tb/ABDfRC0DHMrZusxrAt7olQR8OT9ZFftIPV4s6zL 6q4Xgm7zKQKNfGndSHxfXIoqFf0DVOjp9ZEKp82QQBAo7mVtzxHuv807ztbDSchiYD9F cTbxKXVeiih2DVJX+Q/ghUTA2+W8dhT+kr59o10Xpli+AwKMj7A9DEFyZuoSyu/ZI6s9 huAGOuoqIjR27BcFvqgIMwycQKWNVQrG6fXzi9bnRk+iTH24BHdwjZp4ttD69TwkvGkc D1Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856640; x=1777461440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rKFQPgjt7eYtDdi6D75h2wv4cgPqa3Hgwpc1smHTUzY=; b=U2RDjdiXzvszCsY3IF5hVw68H0AqC/cTq/U0yvNPBFqQa1jOIuksezcy0nYRPyAY3l jyfyEbdHMVJSSIrRki+5v4nshYdhROOvYMZ2tYA3eqQsXwBCR13uDU6xjmg5FVVv6EE4 6Mo8qsNFavjm57Tc78FTAixFRbFLtCmGUHY9xmI2dxavZNXq0Im144LzZUx41XPmyYwv gCJw+5yCpRdv4Ozty2bDjA8D5/ckby7NyZcWJzsFXW/pkjyy1Nnvfe9bRgDE7ZkVwvfU 6B2ciM7x5lkNdRoJj8/BLPI6wKlgvod6d0pY/PIOPcjtcRogStxhbsw9nH4CEzaCXczS HEWQ== X-Forwarded-Encrypted: i=1; AFNElJ+DItpKzJzq8uYY+f5WJk/oCE8blF+1yu0BqtC3lKkD+LH3OTK9NJpusuwVTkTdPYwOiL195SCqeXeCs7c=@vger.kernel.org X-Gm-Message-State: AOJu0YzgD3U6+1IP18VpFTfWJ21k/ySBGV2WY70HO/hmGqyjqtRBmk27 Lq7dn0DOx105ieAtbfJ+b3uTQXmZujRx1HaFld9WBMYsK0/3XM8KSlESs86qzTHgjsbkOiXMgy4 DtKOVZx+PcFtEeW07gm5UPaH/Pkiza+6xCUzPfcU1ThBrlpWJYQ1/XdVfomxvvBSTf88= X-Gm-Gg: AeBDies3gk0I/BqAZWzilf4HsU5sPRBE0jsnAbZtIJzewsvJ2cXf0iFTtzWne48LqMV veqHk6CXlBEusqws3/erEr3qol58B2QR6iNqRfrlOF+aclo9Mt6OOIdB29UHGMPWS6Whl86oLjB d+FWwWHEJB/DNd85rid4/L1NBM2hPvr7GUWIQ4auPQDWqQuH9xRzK9chcnQhdBO1ILH+a0CSy1A hvzjH8MswIRH8HFu7IKegPqQGuSX+SVO8q2LkiHDz9ZUUkfJJg98HdznCdFg9cO2yBuJUTSsMdv CmfMUL2bAFggWkJK3o8Etr6Euh4HkWr3kckGAR1xxVTOqMF7MfJ3iePCVMMv4pi1lmAk/Cts2X2 Mcnq3XhGoWyR/Ou7kLTifA6MHLojQqzvxPMgwReyKWiiqQ4PYLfxfhrGg4GDyD/avNRJvEQ== X-Received: by 2002:a05:6a00:4b54:b0:82f:6e39:d90f with SMTP id d2e1a72fcca58-82f8c93d102mr22724206b3a.39.1776856640116; Wed, 22 Apr 2026 04:17:20 -0700 (PDT) X-Received: by 2002:a05:6a00:4b54:b0:82f:6e39:d90f with SMTP id d2e1a72fcca58-82f8c93d102mr22724164b3a.39.1776856639622; Wed, 22 Apr 2026 04:17:19 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe901csm21100782b3a.48.2026.04.22.04.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:17:19 -0700 (PDT) From: Dikshita Agarwal Date: Wed, 22 Apr 2026 16:46:40 +0530 Subject: [PATCH 7/7] media: qcom: iris: Make iris_destroy_internal_buffer() return void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260422-iris-code-improvement-v1-7-8e150482212d@oss.qualcomm.com> References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776856606; l=5103; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=Jbh3ewlZURHGfxOIxegETw5Vx0Yr6tndGi7C/P8xCaQ=; b=vhCvl9BVSmEHYFqdsKw/GzOArLPagrdO8KKMygn95x01akdnU5vkj8fZp9z/Ht4AphpqHiu6F GlzczV/0n8xADfCdqbKk70jFtL/kiqsq2AT/w8bl8uz/dUuFRen4LsK X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-GUID: YatkNE7Fl1nVr_jUT481IrivETV8LwSQ X-Authority-Analysis: v=2.4 cv=SONykuvH c=1 sm=1 tr=0 ts=69e8ae41 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=U2F47QYUfY1_dUrEBYAA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: YatkNE7Fl1nVr_jUT481IrivETV8LwSQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwOCBTYWx0ZWRfX9X1H3VyquE04 Xg3e2Rota7+5SRjT9AsUVQGYggwdkJWTLL8maKF5TA06OoGImEVWCHp/gCKQ//x2N+4v/eDrNvJ 26Xb2efuK8sVP2luQLBtAEZPhfv31j0khCVtEvi7wEj3Sj3MUS28V39Sm9eL5PnJ96mL3GOJQkt Y/R99QsXwxow0AFyrhhzk+BVjhWOyMk8E0K1tBCKISiAR14wKNbrDX1gJm9Nc12cr0MKPiFMnlL j8eh35rI0gmtGaUr+HIzmtt2iqXdtyNei6gfz9F28v9di10AYGYweEWORXaMTD0eZFadczm21EC 69os2dS44twLJ+SAOr1+90u97bxu++pKT88HL/9BalmwpH+3msgrQbbcbuIGcctpcO715c+NMGH /yC5/x5Mo4kO0C+dY3HQeSn0LuKkXhRGbBj/pSYPZv3crxn3YYwpfZXqdxruOZij4W1A0k2KFS+ +SfzK2GkZurhLuHaz9w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220108 iris_destroy_internal_buffer() is guaranteed to succeed and never reports an error. Returning an int is misleading and forces callers to handle a meaningless status value. Convert it to return void to match its behavior and simplify callers. Signed-off-by: Dikshita Agarwal Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio --- drivers/media/platform/qcom/iris/iris_buffer.c | 16 ++++--------= ---- drivers/media/platform/qcom/iris/iris_buffer.h | 2 +- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 4 +++- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index 137a69c99bcc24a72f4f27e516b8fb4d6509c0ad..2da0498843595d3071040d45f1e= 605f8814f87a2 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -455,7 +455,7 @@ int iris_queue_internal_buffers(struct iris_inst *inst,= u32 plane) return 0; } =20 -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffe= r *buffer) +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buff= er *buffer) { struct iris_core *core =3D inst->core; =20 @@ -463,8 +463,6 @@ int iris_destroy_internal_buffer(struct iris_inst *inst= , struct iris_buffer *buf dma_free_attrs(core->dev, buffer->buffer_size, buffer->kvaddr, buffer->device_addr, buffer->dma_attrs); kfree(buffer); - - return 0; } =20 static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane= , bool force) @@ -473,7 +471,6 @@ static int iris_destroy_internal_buffers(struct iris_in= st *inst, u32 plane, bool struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; - int ret; =20 iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); =20 @@ -488,9 +485,7 @@ static int iris_destroy_internal_buffers(struct iris_in= st *inst, u32 plane, bool if (!force && buf->attr & BUF_ATTR_QUEUED) continue; =20 - ret =3D iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; + iris_destroy_internal_buffer(inst, buf); } } =20 @@ -500,11 +495,8 @@ static int iris_destroy_internal_buffers(struct iris_i= nst *inst, u32 plane, bool else buffers =3D &inst->buffers[BUF_ARP]; =20 - list_for_each_entry_safe(buf, next, &buffers->list, list) { - ret =3D iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; - } + list_for_each_entry_safe(buf, next, &buffers->list, list) + iris_destroy_internal_buffer(inst, buf); } =20 return 0; diff --git a/drivers/media/platform/qcom/iris/iris_buffer.h b/drivers/media= /platform/qcom/iris/iris_buffer.h index 75bb767761824c4c02e0df9b765896cc093be333..ab8e5d953101a786ade20540ee3= c3ed226160cbe 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.h +++ b/drivers/media/platform/qcom/iris/iris_buffer.h @@ -112,7 +112,7 @@ void iris_get_internal_buffers(struct iris_inst *inst, = u32 plane); int iris_create_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_deferred_buffers(struct iris_inst *inst, enum iris= _buffer_type buffer_type); -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffe= r *buffer); +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buff= er *buffer); int iris_destroy_all_internal_buffers(struct iris_inst *inst, u32 plane); int iris_destroy_dequeued_internal_buffers(struct iris_inst *inst, u32 pla= ne); int iris_alloc_and_queue_persist_bufs(struct iris_inst *inst, enum iris_bu= ffer_type buf_type); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen1_command.c index e42d17653c2c37f526e6b26c6e29cc45ae29a747..d1114e5ce7788c5e803ac7aec50= 5a6115997eb27 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -442,7 +442,7 @@ static int iris_hfi_gen1_session_unset_buffers(struct i= ris_inst *inst, struct ir =20 ret =3D iris_wait_for_session_response(inst, false); if (!ret) - ret =3D iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); =20 exit: kfree(pkt); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/dr= ivers/media/platform/qcom/iris/iris_hfi_gen2_response.c index 8e19f61bbbf9e427f658471b4502bedb1ad5f616..f5c342f4c926a68b2017006a3c1= cfbb251605ae0 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c @@ -447,7 +447,9 @@ static int iris_hfi_gen2_handle_release_internal_buffer= (struct iris_inst *inst, =20 buf->attr &=3D ~BUF_ATTR_QUEUED; =20 - return iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); + + return 0; } =20 static int iris_hfi_gen2_handle_session_stop(struct iris_inst *inst, --=20 2.34.1