From nobody Wed Jun 17 02:50:55 2026 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFB5C36AB57 for ; Tue, 21 Apr 2026 23:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776814833; cv=none; b=YpWt76XRPbN08sDoG/snbJOuS10OrW3avl47coasSGdKfCiAfNXyuCSUfhnW0/s7vJ4QwOAtGEkH8BOGTBa2w9+lepL8y8ZSQh1pZclHp+JMoa+zb2NB/pY+G34XAKc8mktax29g8B2Z5O8AQ5Sq9QD7ASQZv+XqKqyGrEyNxEI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776814833; c=relaxed/simple; bh=FAjd0SGYlTGbrBuZkkUHlFzHmjvnupkiWc5/sWK4Frc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SifaiU5rHPbURed//HuafqN5bYkEx5sd6oBsenNABiTgql3vT9kxF7oq4eeytK0PMoRmYEj+EQhwRL6ZIsuARi9npwajN/n7x6mJBy5Lt5WSQGGKlhXiwu/VjCzMtBa/J0PDCkONBlq2AVnV9j94208QJoXdv99E0GWZ+QfoNI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E/KYD38C; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E/KYD38C" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-8aca2726f61so58666106d6.0 for ; Tue, 21 Apr 2026 16:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776814831; x=1777419631; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WHYPowIO/Ty/lLtBU9hns/rmbNm5oK+oGzhuJOxaFBs=; b=E/KYD38CDdCa0WDj2RnqfZ0gy0G5TYbjL4OQ8UrFBMedffCPEg9BrhMXWeaLh4XdKh uV48BmGHysY3wOsgTky57ggCu6VaBU0Tdqx6bP7XNedOQ0qEihQRm8Bi8cRoJQWS6efv Jgl9s74VpVQfkxliYxhXZs3aAs64VPPU6hgWvvGZ8Gg6bz8CkEfN0xP6QxDWscuMUYJM HVlJTywkRjPdj5eepDrOgyu75SQgTJPCzN+WUo5G6Nq1MpdbqiPipD/XAfrMupzSP/iR cOKPXPzQjTOirg89GrhCx0FnoaGDnx8VOI+AdCgMd6HDwSkYdHezR4gvEPGxMk3SrP7Z 99zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776814831; x=1777419631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WHYPowIO/Ty/lLtBU9hns/rmbNm5oK+oGzhuJOxaFBs=; b=hyafO5WsqRlB+b1dN3ucnjarmiIeXpdE3157L4DxSBD5YEV3CB8rcJfCl2FkVd0tJk kiQ32FDMBuAVGo5ppGe7LNoHtPsLhMaRGLPb1HGAqolfsdlENRT9hLFa8ipOfhuoO9B+ 4eqP0d4LA06WF7DZh96HY+XLi3oXYGl85R/aS5i3GsOgRjADx0owsvAybIQ/gunj+b5I 9kJZFB2QhZwLmg1m7fYpDftU8YLdSl8e/H8eRcUwJsDt9+3AsxlCV21cCPQ51u1JlTFY GE2Rxc+iW/3N1HH22DlfAUucSNb59xMHkNv33ST2fUUM2+1ibVCCdzC4R/PzAq8F55EO vNTA== X-Forwarded-Encrypted: i=1; AFNElJ9XkTiwLs4Ef3zdyIOPEigHC1epdh9aZfuLYtZElzUQkDPu8IEkHwoMawd4lw1mK/7CALEuqfjbAT1vF4s=@vger.kernel.org X-Gm-Message-State: AOJu0YxxH3hlSpfOidsVx2kJ9I2Q5xL2nhKCHlHswubYH41NUjMqAAZ0 aIPMdmi4Ph3nOdJwkJBMpdEO+pDoPQ932mldmnBNn89fl2DwInaEgPke X-Gm-Gg: AeBDiesXfp+dmF7a5WCgiCaW/+ib6usBNUxvl5ZgURtfyTtxskxyjxWzeQGYj9Lf4SQ H95chOF6rfEtB9wD0koe6HG4tfCTdrYFrXVhlVW7UqiowNjFZhGI7JicmTh7wBe73ar9zmwxAPQ +1D6xpaGPAqZTK1QfNtNzN931hv+Ip9fkrooDWw3lz4TV+Zs0g5GUmfGs4KJI02LkEbhNqKazgA gE5aht+Pqa8O8p+i2PidX5Pmu5ENtZJvmD0Cy6N5ba8HUKho7nRNz6zE8BGh/S3CegfePfCikRH 105ep4nnw6060khWML4qr4QcEhasbczmnKTymYkqrE3WmCHkkhJBR6CCclQsdXQi3sIWpr2/t2A 8+NhcM+WClrrmGXvb2+5AOjnLtjiT9CYUPZVfJwwSvsa//4URiRTATmP9rYRGHr2ODSXf9r8W/O fTfSDvuVM4jLqibyqOJdQ8v9cY6NzhDnpVQ1ldLVCgFROhtL29S8kJB9FYUu6g+QbTbPAGau0xZ vkAr6Xu9UCR3pyExGIX6hw+5MSdrnY= X-Received: by 2002:a05:6214:2f03:b0:8ac:af0d:c101 with SMTP id 6a1803df08f44-8b027fd9d3fmr313865016d6.10.1776814831016; Tue, 21 Apr 2026 16:40:31 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ae86947sm152590596d6.37.2026.04.21.16.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 16:40:30 -0700 (PDT) From: Michael Bommarito To: Steve French Cc: Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel test robot , oe-kbuild-all@lists.linux.dev Subject: [PATCH] smb: client: scope end_of_dacl to CIFS_DEBUG2 use in parse_dacl Date: Tue, 21 Apr 2026 19:40:22 -0400 Message-ID: <20260421234022.4144209-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <202604220046.tGkRxVtS-lkp@intel.com> References: <202604220046.tGkRxVtS-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After validate_dacl() was factored out in commit 149822e5541c, the local end_of_dacl in parse_dacl() is only read by the dump_ace() call under #ifdef CONFIG_CIFS_DEBUG2. With CIFS_DEBUG2 off the variable is assigned but never used, which gcc -W=3D1 flags as -Wunused-but-set-variable. Remove the local and compute the end-of-dacl pointer inline at the single call site inside the existing CIFS_DEBUG2 guard. No functional change: when CIFS_DEBUG2 is enabled the argument value is identical to what the removed local carried; when CIFS_DEBUG2 is disabled the code was already dead. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202604220046.tGkRxVtS-lkp@int= el.com/ Fixes: 149822e5541c ("smb: client: validate the whole DACL before rewriting= it in cifsacl") Signed-off-by: Michael Bommarito Assisted-by: Claude:claude-opus-4-7 --- fs/smb/client/cifsacl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c index 4ec204d2c774..ec5d47779304 100644 --- a/fs/smb/client/cifsacl.c +++ b/fs/smb/client/cifsacl.c @@ -836,7 +836,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end= _of_acl, int i; u16 num_aces =3D 0; int acl_size; - char *acl_base, *end_of_dacl; + char *acl_base; struct smb_ace **ppace; =20 /* BB need to add parm so we can store the SID BB */ @@ -860,7 +860,6 @@ static void parse_dacl(struct smb_acl *pdacl, char *end= _of_acl, user/group/other have no permissions */ fattr->cf_mode &=3D ~(0777); =20 - end_of_dacl =3D (char *)pdacl + le16_to_cpu(pdacl->size); acl_base =3D (char *)pdacl; acl_size =3D sizeof(struct smb_acl); =20 @@ -876,7 +875,8 @@ static void parse_dacl(struct smb_acl *pdacl, char *end= _of_acl, ppace[i] =3D (struct smb_ace *) (acl_base + acl_size); =20 #ifdef CONFIG_CIFS_DEBUG2 - dump_ace(ppace[i], end_of_dacl); + dump_ace(ppace[i], + (char *)pdacl + le16_to_cpu(pdacl->size)); #endif if (mode_from_special_sid && ppace[i]->sid.num_subauth >=3D 3 && --=20 2.53.0