From nobody Wed Jun 17 02:50:06 2026 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1249C3A759B for ; Tue, 21 Apr 2026 22:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811956; cv=none; b=amTeqYFF6sMdiOPFTpDexdxnfg3mtYi19N4gKEqMVxRHJVIlZ44UszE+Df2yylr5Uw4/Ajvd6vomEveNC3jprnHu674BoxxeRNuX4ldOkpz75bInZiPbWyKRqBkaYeQUtJ65PG4/ShqXGPX5hlCj9ISFLnK/ERRqbRnpJWshlXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811956; c=relaxed/simple; bh=lfv6xMuTWxVW/xyXczBYRRPg3gtNkJiy/z6/BGQznFs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NmH2jOE1TfXBk+5RrjdtWk4mqQ+eRxrV/fCxiKTy9k8vmCQGSFZDSZprY8F6bHWQWDpVia2x7AxwfE9wwZ++SFEdShCusfkgk6Zs/DeQAE8Sa6ZqWWmL4496proHFZt1AOvWsyiF/23iuZZBmuVtfsT0a1Y1N/jMwf/HS9/jA4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H7K9HljG; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H7K9HljG" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso5108533eec.1 for ; Tue, 21 Apr 2026 15:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776811953; x=1777416753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1E8HRC9jadERrbomVh88MVvNtDc5/zpLXfvKSJQAhUQ=; b=H7K9HljG3k4FBBsjw0fRAZ3ZDr1QYneatGr6HW/IAsFttqeG8bJNahLg3cabbnzYpK XA0k+XHQRVyrF2aaAXa/A7euBI4bbCjTnVqAYoyhVLiodx+z/pGG3xTUgfETs62PlwKW v6Rli7b9sU/00sU8et5GhWI2XOCkvyxtyjXFUBiPbdQ/qN0esBpmax0siiLy2Wjky0gm 6Qynln8Bl2SgM5rEttdqReHBmGKdne2Aw/vUqBeVhwsP4Mo/NgRTYnLhcciNssOGfoIy soRWV/2zlHmbaDwFq39YlUO+HUlEUKBSubqWp87SEwuKb+DGb1AsinG4Chfp30td39nH DYdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776811953; x=1777416753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1E8HRC9jadERrbomVh88MVvNtDc5/zpLXfvKSJQAhUQ=; b=ZrO0X91svOCNCEcv5dQzJMCX7FNexCVXnGopuzGYI+ikkMXxfm4QSr5zLnTXNtgqJO W8f6T6vrCLbXjgbynDx3bQL/VWTIGHmF7SsQ9RfxEJ+1Ih5K9q2AsOnfkYeMzXhrZkGK eYZRcwCcIEtLi8o03fpxV0ZDHfuwsglu/VIkd60DzyRW2Zf0a6hswLUHVxA2V0G0buNp VWYTayhJ7dqb36JaflfPCLoqUzIZnRC3dq50Fkkj4CoXXtXHrVGVDE5Rx2+3kJcMGJ9I 6kA7B/5IbchAtMdS4O24XqP7erUO9UjWXdCTb+Sk9Hh1eauZ6Gqvk858qI9AysUF4Z1t osYg== X-Gm-Message-State: AOJu0YzPtRlh1zjxkIXwU2UfqcxXfPZMleHavi2fB60wrWNKj2L3iq/J KlmrHPJGXGKwzx0LRI/9xGEF3ddxJE18Wt2/CUxX0eDqYwtbPzKSTrpBiBZI8HP7apk= X-Gm-Gg: AeBDiesu79OEb/FH2Dvxjb3wnh5EebEx7Rt4Phq3gaUNIBlcTlXSPXmuOg9gSRlByLj sf/UXMock0shhVCpk3DAqqATZxisI6eN2c9JrvelTjC8kMrR9MUySQWWeKxP6/HOgnwoE6PRFYP DatGhhwtXycEl25+SsgqvyVw6iXEZNY7k7kEE5B9q0HAOuweBmtMGSAUPeodH+MM+vKuK19cUWQ zFTQUWQ8HiLvxzXk10zyrh9y+5+cHJSlGSeh2B6pp9HPsPcqK3vcpTBTBUtDcstXKvzVxpRuZ4/ ui3QZo8xalao8/GC4hfT7f+wLtsDx1IMKmyL18MBhBiRxGCfT1Q94ZnZmC0G8szevPBjpzDbRBj oh6SkfKiR5XFikDvN2Lcir0fXGBHBANwL42I9LRXfPJYuoCYs4sDpJciRZGCQy07JWpWJHpg303 +dRlPNCkIG91f5VwSKvUMKBrOb1o2EEZ6FJx5NMUnBHeo= X-Received: by 2002:a05:7300:cd94:b0:2ea:4228:ab11 with SMTP id 5a478bee46e88-2ea4228ab6amr3006778eec.3.1776811952929; Tue, 21 Apr 2026 15:52:32 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53a4a8018sm26145884eec.8.2026.04.21.15.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 15:52:32 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v4 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Date: Tue, 21 Apr 2026 15:52:13 -0700 Message-ID: <20260421225217.12472-2-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260421225217.12472-1-tchatard@gmail.com> References: <20260421225217.12472-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dell Latitude 5285 2-in-1 has a BIOS bug where the ACPI GEXP device and the I2C4 controller (INT3446) both claim the same MMIO region via the shared SB04 variable. This causes intel_lpss_acpi to fail binding to I2C4 with -EBUSY, preventing the front camera (OV5670) sensor from being registered. Add a DMI quirk that selects IGNORE_RESOURCE_CONFLICTS for INT3446 on this machine, matching the existing pattern used by other LPSS quirks. Signed-off-by: Thierry Chatard --- drivers/mfd/intel-lpss-acpi.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 63406026d..c48eac03a 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -13,6 +13,8 @@ #include #include #include +#include +#include #include #include #include @@ -52,6 +54,16 @@ static const struct intel_lpss_platform_info spt_i2c_inf= o =3D { .swnode =3D &spt_i2c_node, }; =20 +/* + * Same as spt_i2c_info but with QUIRK_IGNORE_RESOURCE_CONFLICTS for Dell = 5285 + * where ACPI GEXP device conflicts with I2C4 (INT3446) MMIO resources. + */ +static const struct intel_lpss_platform_info spt_i2c_info_ignore_conflicts= =3D { + .clk_rate =3D 120000000, + .swnode =3D &spt_i2c_node, + .quirks =3D QUIRK_IGNORE_RESOURCE_CONFLICTS, +}; + static const struct property_entry uart_properties[] =3D { PROPERTY_ENTRY_U32("reg-io-width", 4), PROPERTY_ENTRY_U32("reg-shift", 2), @@ -172,6 +184,16 @@ static const struct acpi_device_id intel_lpss_acpi_ids= [] =3D { }; MODULE_DEVICE_TABLE(acpi, intel_lpss_acpi_ids); =20 +static const struct dmi_system_id dell5285_lpss_dmi[] =3D { + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + }, + { } +}; + static int intel_lpss_acpi_probe(struct platform_device *pdev) { const struct intel_lpss_platform_info *data; @@ -182,6 +204,18 @@ static int intel_lpss_acpi_probe(struct platform_devic= e *pdev) if (!data) return -ENODEV; =20 + /* + * Apply IGNORE_RESOURCE_CONFLICTS for I2C4 on Dell Latitude 5285. + * The ACPI GEXP device conflicts with I2C4 (INT3446) MMIO resources + * due to a BIOS bug where both use the same SB04 variable. + */ + if (data =3D=3D &spt_i2c_info && + acpi_dev_hid_uid_match(ACPI_COMPANION(&pdev->dev), "INT3446", NULL) && + dmi_check_system(dell5285_lpss_dmi)) { + dev_info(&pdev->dev, "Dell 5285: applying IGNORE_RESOURCE_CONFLICTS for = I2C4\n"); + data =3D &spt_i2c_info_ignore_conflicts; + } + info =3D devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL); if (!info) return -ENOMEM; --=20 2.51.0 From nobody Wed Jun 17 02:50:06 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4B153A7827 for ; Tue, 21 Apr 2026 22:52:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811959; cv=none; b=jHRi5+ymfbMwPymc0Kkjj5c4Jf8NJztoOM7ImEeO9dCmRst3zk+YEGv5AgRAiKhdxG31DvUVi0NIh/qBMFvC6jdZwWarIQTpZENuB7ZFitG1PYVGK7HFraWnCF5MBwZQUpFcqhkisKSu4RveIpCRRG8QTnAoauHj2nxyD3wmPhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811959; c=relaxed/simple; bh=pkISsqV/Vd/AkxRoaxIZdYMzBbCImLUZNm6/QZ3JzIA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OWwjtz8e2O5WhNYhyFGjBKrROb9/8nbfdxPC4mmFEo+gizYg4khFOc5f4DE/8dluKFWb3FIVBGyXuqigcGZdju4sIWGmYFadgL2E7c41z9zQlJgZCnxaeVTPasvk44eKvkd9ru8qcJ7bkA1lV5S8Jw6pU2pJYMK4OBSe0qmYqwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OGupfWbU; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OGupfWbU" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2dec803f9f0so2825908eec.0 for ; Tue, 21 Apr 2026 15:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776811956; x=1777416756; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qMmU13XWi2hz/awwYwuaTGeoy/1gyMry/mt49asroCk=; b=OGupfWbUQAXYCzcLTVxk4AAuqIZ+3ToqdEVaY7cmfRSvUWs4Z/GHUopGy6GOKz/wDK qs03Uyx3Fsb71jjW8XY0/JyluX+ZZE75bsUBvzd19z9y1c+N/0ZXNojijEUbu1p4T1Ef ev2KpeKOJoL5/MYOlDGAxYxoa9HyqHKqHMJdAN/9oIRoj7bQyxyvV0aA+1puAScURy0c RbDlj5R+NAk4veVRzWZ9GmncKcqRuytq0eDUKNaJeL9vS4NYd1BgT70YMz+WzB1Tv+qO QVdqJBizZRBiNoxiJOk7HR0LHBMwgwPa0lMD5038+kmNujYB4Nu6GUGKVyLdXsYexYUi DNrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776811956; x=1777416756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qMmU13XWi2hz/awwYwuaTGeoy/1gyMry/mt49asroCk=; b=j5S8v93LX+DMMZIazggmwtq56CJCCIGRQY20931KCKj2vtb5ivOy7Mo4ykc3MUgq84 kx9Ynbh7nFiAaqfmUR4yOTAI4zG1UbUR+sAyK/EjtGv7ay/OehEoiw8KGUX4JqNWhfhY 1JTId0KUunydjScg4wu0PflZJK9iQcHVoJZNWsv6U+50/PsO//CnqlBfu4C0pBMBXulm qUEsg5fnoIvTbtcAhAQi1ftygnCwQClJetYfH5UyxSE/s2C7BiBqG3q8kYuFnWdkb16F kvFShGCyOk+t/MEP704jhRM2S8uZva35SLxrEA1ScTLR9QJfkR3pwByIUjFCWwhyUNgt sJsg== X-Gm-Message-State: AOJu0Yy84rvxt8yFM+8jb1vAHuRPs8NZH0gpEW2yaPg+LuWmxCYm74Z7 QdNQSwu/HNmhonzwIoDTosWMA1HOfFySRjpc/Ethgi/C25LOVzZeayf5fb/rA6wFot8= X-Gm-Gg: AeBDiesN31iQqezab+cnzi8WrfzUebYk/o8mUGEAyVCKmuRnP3jOhLpTqqK1DllYVP3 VkOce6eQ2iRgX7rNXrgq+lLnAGTS00QP/ZX4RlXrv7rKYUi++7Cb1XoHnO6vaCvt4F65sM+RqXM ZPWXsMzKvyeSWi0buOxdCM12mKTzsooR8ooTPYbZZ0ouE3DVJ/l6EfbKn0V+Iv4xLexA36WCDg0 e8YYu+QVQLpVgMYZa9OM/HIVFs9IT7wH7/AcLdlc7xLc+LHYOyWmWrxFeoiTrqcHu54IlxblUNj ymChIqUAzsljdngoGeJ6u4YXxDVheZ4kuET1n+2XawgfWcWS074kY020pFyBsFiuHgZ79rDHZ5i xPWXLZf8CyX3pPN1J/t7t/9iAzFCwpD77kvQdLMdjvWqX4KbXRsPiy0ey1IpxoLOFtO3MDEjV4N Yk3b2yAKfEpiD7LA1PUjFQ6jpgGphgQLB5 X-Received: by 2002:a05:7300:5711:b0:2c5:c532:1fe1 with SMTP id 5a478bee46e88-2e42c15ceacmr9582888eec.3.1776811955691; Tue, 21 Apr 2026 15:52:35 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53a4a8018sm26145884eec.8.2026.04.21.15.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 15:52:35 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v4 2/5] platform/x86: int3472: tps68470: fix clock consumer registration for Dell Latitude 5285 Date: Tue, 21 Apr 2026 15:52:14 -0700 Message-ID: <20260421225217.12472-3-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260421225217.12472-1-tchatard@gmail.com> References: <20260421225217.12472-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The BIOS on the Dell Latitude 5285 leaves GNVS field C0TP at zero. With C0TP=3D0 the ACPI _DEP method on INT3479 (OV5670, front camera) resolves to PCI0 instead of the INT3472 (TPS68470 PMIC) device. Because for_each_acpi_consumer_dev() walks the _DEP reverse-mapping, INT3479 is invisible to it: the clock consumer lookup entry for the front camera is never registered with the tps68470-clk driver, and the OV5670 sensor driver cannot acquire its MCLK. Fix this without touching ACPI tables by adding optional static clock consumer fields to struct int3472_tps68470_board_data: unsigned int n_clk_consumers; const struct tps68470_clk_consumer *clk_consumers; When board data is present and n_clk_consumers is non-zero, probe uses the static list instead of for_each_acpi_consumer_dev() to populate tps68470-clk platform data. Platforms that do not set these fields continue to use the existing ACPI traversal path unchanged. The board_data lookup is moved before the clock-pdata allocation so that it is available for both the static and dynamic paths. Signed-off-by: Thierry Chatard --- drivers/platform/x86/intel/int3472/tps68470.c | 36 +++++++++++++++---- drivers/platform/x86/intel/int3472/tps68470.h | 10 ++++++ 2 files changed, 39 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platfo= rm/x86/intel/int3472/tps68470.c index a496075c0..e121eb24a 100644 --- a/drivers/platform/x86/intel/int3472/tps68470.c +++ b/drivers/platform/x86/intel/int3472/tps68470.c @@ -147,17 +147,40 @@ static int skl_int3472_tps68470_probe(struct i2c_clie= nt *client) struct tps68470_clk_platform_data *clk_pdata; struct mfd_cell *cells; struct regmap *regmap; - int n_consumers; + unsigned int n_consumers; int device_type; int ret; - int i; + unsigned int i; =20 if (!adev) return -ENODEV; =20 - n_consumers =3D skl_int3472_fill_clk_pdata(&client->dev, &clk_pdata); - if (n_consumers < 0) - return n_consumers; + /* + * Look up board data before building clock platform data. On + * platforms where a sensor's ACPI _DEP does not list the INT3472 + * device, for_each_acpi_consumer_dev() misses that sensor and its + * clock consumer entry is never registered. Board data can supply + * a static consumer list to use instead, bypassing the broken _DEP + * traversal. + */ + board_data =3D int3472_tps68470_get_board_data(dev_name(&client->dev)); + + if (board_data && board_data->n_clk_consumers) { + clk_pdata =3D devm_kzalloc(&client->dev, + struct_size(clk_pdata, consumers, + board_data->n_clk_consumers), + GFP_KERNEL); + if (!clk_pdata) + return -ENOMEM; + clk_pdata->n_consumers =3D board_data->n_clk_consumers; + for (i =3D 0; i < board_data->n_clk_consumers; i++) + clk_pdata->consumers[i] =3D board_data->clk_consumers[i]; + n_consumers =3D board_data->n_clk_consumers; + } else { + n_consumers =3D skl_int3472_fill_clk_pdata(&client->dev, &clk_pdata); + if (n_consumers < 0) + return n_consumers; + } =20 regmap =3D devm_regmap_init_i2c(client, &tps68470_regmap_config); if (IS_ERR(regmap)) { @@ -176,7 +199,6 @@ static int skl_int3472_tps68470_probe(struct i2c_client= *client) device_type =3D skl_int3472_tps68470_calc_type(adev); switch (device_type) { case DESIGNED_FOR_WINDOWS: - board_data =3D int3472_tps68470_get_board_data(dev_name(&client->dev)); if (!board_data) return dev_err_probe(&client->dev, -ENODEV, "No board-data found for th= is model\n"); =20 @@ -233,7 +255,7 @@ static int skl_int3472_tps68470_probe(struct i2c_client= *client) static void skl_int3472_tps68470_remove(struct i2c_client *client) { const struct int3472_tps68470_board_data *board_data; - int i; + unsigned int i; =20 board_data =3D int3472_tps68470_get_board_data(dev_name(&client->dev)); if (board_data) { diff --git a/drivers/platform/x86/intel/int3472/tps68470.h b/drivers/platfo= rm/x86/intel/int3472/tps68470.h index 35915e701..1d3d67459 100644 --- a/drivers/platform/x86/intel/int3472/tps68470.h +++ b/drivers/platform/x86/intel/int3472/tps68470.h @@ -12,11 +12,21 @@ #define _INTEL_SKL_INT3472_TPS68470_H =20 struct gpiod_lookup_table; +struct tps68470_clk_consumer; struct tps68470_regulator_platform_data; =20 struct int3472_tps68470_board_data { const char *dev_name; const struct tps68470_regulator_platform_data *tps68470_regulator_pdata; + /* + * Static clock consumers. When n_clk_consumers is non-zero these + * are used in place of for_each_acpi_consumer_dev() to build the + * tps68470-clk platform data. Needed on platforms where a sensor's + * ACPI _DEP does not list the INT3472 device, causing that sensor + * to be missed by the ACPI dependency traversal. + */ + unsigned int n_clk_consumers; + const struct tps68470_clk_consumer *clk_consumers; unsigned int n_gpiod_lookups; struct gpiod_lookup_table *tps68470_gpio_lookup_tables[]; }; --=20 2.51.0 From nobody Wed Jun 17 02:50:06 2026 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 142413A8725 for ; Tue, 21 Apr 2026 22:52:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811966; cv=none; b=lIulqwm15GaD1j6PV+3ApqGkycVxPbMMYgtkbabJTX1nxTD2hlscrusCBk59btLsN2UKwDedRwfuHHCh3ZzjoC1ClTorB68iJOKztVhNKrzrVmx5dp3hLkMjKByNIb0guWOVKcCHzA1o42n6Tq2Oit+pMVz92QcV49VYxiDO0/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811966; c=relaxed/simple; bh=oCnOvcvyB5Q5+CMfPe8RbKAt5UgH4Q8QeBB9wZgxNgo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TUxU0AwV1s6B5JkknERyicIOmOwj1xxxt5/DtsPERCcubCNl4Nps7ZQUfjd7uUE/cQSnqfwubEMa0RtfR4vDLVDbgogulhgdcwRJFPZqg6Ya+YhQujtcJQ1k/5+1On+Gdwz+Fg7+DA6sULryAdg139erCfK78ejjhfOamH8h+2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nfcToyWv; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nfcToyWv" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2d9916deb14so8831597eec.0 for ; Tue, 21 Apr 2026 15:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776811958; x=1777416758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LbcbMd28r+rmUyZ8KhlCo0GdQR1hCRYbQzQN370ZlHo=; b=nfcToyWvPz38AoQm946PLdUy78gvB3p4U0hKNzPzEDTOTTldD17OCwwxVmZjisvQ+D tbq8pKa0bEw2Zbe8SkNV604GNbuwjcFBgp8eaJiRlpq2st/RpBgODARKUbkVe2cBCjvY PvaTGBvHclvWl0L7MzQW/XJPfQwgk5ylAwoFcNzDYOu54nIX9ZQwqOx5/Q9Um6ly0I+N qClnpfBXBk/5Mfo0pxOVH3AJKM38gN2YOV28wFapyyNQZYh9grTfg/P7Frk2qiz9hW+w cZOIaI+DTEdmpVB0nVJwgdP6KHyNGidiVpbOrwzgjWq+7mbWndDF9W58pYsT4MV3TfYT cuCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776811958; x=1777416758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LbcbMd28r+rmUyZ8KhlCo0GdQR1hCRYbQzQN370ZlHo=; b=faxkaoY2TtOkDSJq4zZe8N238tobLnD9ssxJkKX3DhXfF0ZWRwXdqQ5NHL2pBQ34As hTyyDlkflGoz8uEIRywb4vRNjjcIgC58oeSDh2rTB1hOk34ZMbPX3OwUxnwLTI+25Pli ZJm4oeXOM+d30+RlX6NhXUP9wyf55Vqg4kQ46VkIhRmxgJaelC9QFV14xBK646oTaSK2 esgo3cOMrO+cLMqHIfLuoxy2YF2MtkRyu/thhAP4zBJ2/FyVSe/bULlbOBoPKBf6GyPz dxUiKS6USeTAudUicktQZDyJBpz42WEO89mLXb4vGodsu7mgeuIdNL/yhQwTVRmdmyPL K1Fw== X-Gm-Message-State: AOJu0YyuBdwueDeUKot84XZ9XcLE6Zkw8EqWJDWFe1eDHQxaE0pT8yB9 xalMmX2KlsVwNmrI3FpLBRtPVPVVK3MNuyD1gyoeDeKhoXzfO5V18HjF/OPesAIMXno= X-Gm-Gg: AeBDievsq9fg5PtHDNeFwXppunltzM6abbnQOAu2UD4RtKKxZkOPy53sKq4nEW2MdOs a6CMD87XQ6ps6Uv1BfB7HMgZJfKQWTc3FBW1bEw7ln7l3G323HgINSue3jhSAv0rWphwCpDgalR U3dR0LjOL9UWa7Tcb0PJqJepSKP4ClIwT899UCHYd6JwC5KzEbQnquDYD2ZwEfiBe7VTzvx+uw7 R3a/bWFByz8ozHYZMNegk0NmKf8CPQ39n0gXIdZsqh/4sJM7P3UVNoe98/ugPfgfQqpHmc3FQmH 71Ym7ojZ3ciSNiBgzyNysgFSVqQL0R/3s2q898qPoRWP+4vZua2iuzZG7ZA/nIeBCF2xq8JcTcs kN2D2OUmO6l/WMmZa3AGKMHtqSbvh1QomyzavcBOxNyvINpiVyEwoqZGU7S2UBeHNyZ7TJZ0t+a IjeJ8s+3OqRi8I0ryp/iu+s41aGMmdrn2Z X-Received: by 2002:a05:7300:f193:b0:2df:5715:82be with SMTP id 5a478bee46e88-2e466044880mr10177993eec.2.1776811957939; Tue, 21 Apr 2026 15:52:37 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53a4a8018sm26145884eec.8.2026.04.21.15.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 15:52:37 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v4 3/5] platform/x86: int3472: tps68470: add board data for Dell Latitude 5285 Date: Tue, 21 Apr 2026 15:52:15 -0700 Message-ID: <20260421225217.12472-4-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260421225217.12472-1-tchatard@gmail.com> References: <20260421225217.12472-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dell Latitude 5285 2-in-1 has two cameras connected through a TPS68470 PMIC/clock/GPIO hub: Front: OV5670 (ACPI INT3479) on I2C4 Back: OV8858 (ACPI INT3477) on I2C2, daisy-chained behind TPS68470 S_I2C port (controlled by reg 0x43 S_I2C_CTL) GPIO mapping (TPS68470): INT3479 (OV5670): GPIO3 =3D reset, GPIO4 =3D powerdown (both active-low) INT3477 (OV8858): GPIO9 =3D s_resetn, GPIO7 =3D s_enable (both active-low) GPIO9 and GPIO7 are the TPS68470 secondary-port GPIOs (SGPO reg 0x22 bits 2 and 0), not regular GPDO outputs. Regulator mapping: CORE -> dvdd / INT3477 ANA -> avdd / INT3477 VIO -> generic (hardware always-on, no enable register, no consumers) VSIO -> dovdd / INT3477: enabling VSIO sets S_I2C_CTL (reg 0x43), opening the I2C passthrough to OV8858; the ov8858 driver enables dovdd at probe time, which naturally activates the passthrough before any I2C transaction to the sensor. AUX1 -> dvdd / INT3479 AUX2 -> dovdd / INT3479 A static clock consumer list is provided for both sensors (INT3477 and INT3479) to work around the broken ACPI _DEP on INT3479 described in the previous patch. Signed-off-by: Thierry Chatard --- .../x86/intel/int3472/tps68470_board_data.c | 169 +++++++++++++++++- 1 file changed, 166 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/dri= vers/platform/x86/intel/int3472/tps68470_board_data.c index 71357a036..b40ac4fc5 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -74,8 +74,12 @@ static const struct regulator_init_data surface_go_tps68= 470_vcm_reg_init_data =3D .consumer_supplies =3D int347a_vcm_consumer_supplies, }; =20 -/* Ensure the always-on VIO regulator has the same voltage as VSIO */ -static const struct regulator_init_data surface_go_tps68470_vio_reg_init_d= ata =3D { +/* + * VIO has no enable register (always on at hardware level) and must never + * have direct consumers -- all outputs go through VSIO. Its voltage must + * exactly match VSIO on any board using the I2C pass-through. + */ +static const struct regulator_init_data generic_tps68470_vio_reg_init_data= =3D { .constraints =3D { .min_uV =3D 1800600, .max_uV =3D 1800600, @@ -122,7 +126,7 @@ static const struct tps68470_regulator_platform_data su= rface_go_tps68470_pdata =3D [TPS68470_CORE] =3D &surface_go_tps68470_core_reg_init_data, [TPS68470_ANA] =3D &surface_go_tps68470_ana_reg_init_data, [TPS68470_VCM] =3D &surface_go_tps68470_vcm_reg_init_data, - [TPS68470_VIO] =3D &surface_go_tps68470_vio_reg_init_data, + [TPS68470_VIO] =3D &generic_tps68470_vio_reg_init_data, [TPS68470_VSIO] =3D &surface_go_tps68470_vsio_reg_init_data, [TPS68470_AUX1] =3D &surface_go_tps68470_aux1_reg_init_data, [TPS68470_AUX2] =3D &surface_go_tps68470_aux2_reg_init_data, @@ -287,6 +291,158 @@ static const struct int3472_tps68470_board_data dell_= 7212_tps68470_board_data =3D }, }; =20 +/* Settings for Dell Latitude 5285 2-in-1 */ + +/* + * The BIOS leaves GNVS field C0TP at zero, which causes INT3479's _DEP to + * resolve to PCI0 instead of the INT3472 device. Provide a static clock + * consumer list so probe registers MCLK lookups for both sensors regardle= ss + * of the broken _DEP traversal. + */ +static const struct tps68470_clk_consumer dell_5285_clk_consumers[] =3D { + { .consumer_dev_name =3D "i2c-INT3477:00" }, /* OV8858 rear camera */ + { .consumer_dev_name =3D "i2c-INT3479:00" }, /* OV5670 front camera */ +}; + +static struct regulator_consumer_supply dell_5285_int3477_ana_consumer_sup= plies[] =3D { + REGULATOR_SUPPLY("avdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3477_core_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dvdd", "i2c-INT3477:00"), +}; + +/* + * VSIO controls the S_I2C_CTL passthrough. Its voltage must match VIO + * exactly (both 1800600 uV). Mapping VSIO to dovdd/INT3477 means the + * passthrough is enabled when the ov8858 driver enables its dovdd supply. + */ +static struct regulator_consumer_supply dell_5285_int3477_vsio_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dovdd", "i2c-INT3477:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_aux1_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dvdd", "i2c-INT3479:00"), +}; + +static struct regulator_consumer_supply dell_5285_int3479_aux2_consumer_su= pplies[] =3D { + REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), +}; + +static const struct regulator_init_data dell_5285_tps68470_core_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1200000, + .max_uV =3D 1200000, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_core_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3477_core_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_ana_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_ana_consumer_supp= lies), + .consumer_supplies =3D dell_5285_int3477_ana_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_vcm_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D 0, + .consumer_supplies =3D NULL, +}; + +static const struct regulator_init_data dell_5285_tps68470_vsio_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3477_vsio_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3477_vsio_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_aux1_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1213200, + .max_uV =3D 1213200, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_aux1_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_aux1_consumer_supplies, +}; + +static const struct regulator_init_data dell_5285_tps68470_aux2_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D 1, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(dell_5285_int3479_aux2_consumer_sup= plies), + .consumer_supplies =3D dell_5285_int3479_aux2_consumer_supplies, +}; + +static const struct tps68470_regulator_platform_data dell_5285_tps68470_pd= ata =3D { + .reg_init_data =3D { + [TPS68470_CORE] =3D &dell_5285_tps68470_core_reg_init_data, + [TPS68470_ANA] =3D &dell_5285_tps68470_ana_reg_init_data, + [TPS68470_VCM] =3D &dell_5285_tps68470_vcm_reg_init_data, + [TPS68470_VIO] =3D &generic_tps68470_vio_reg_init_data, + [TPS68470_VSIO] =3D &dell_5285_tps68470_vsio_reg_init_data, + [TPS68470_AUX1] =3D &dell_5285_tps68470_aux1_reg_init_data, + [TPS68470_AUX2] =3D &dell_5285_tps68470_aux2_reg_init_data, + }, +}; + +static struct gpiod_lookup_table dell_5285_int3477_gpios =3D { + .dev_id =3D "i2c-INT3477:00", + .table =3D { + /* + * TPS68470 GPIO9 =3D s_resetn (secondary camera reset, active-low) + * TPS68470 GPIO7 =3D s_enable (secondary camera enable/powerdown) + * These logic outputs are specifically designed for secondary + * camera control on the TPS68470. Matches Surface Go pattern. + */ + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 7, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + +static struct gpiod_lookup_table dell_5285_int3479_gpios =3D { + .dev_id =3D "i2c-INT3479:00", + .table =3D { + GPIO_LOOKUP("tps68470-gpio", 3, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 4, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + +static const struct int3472_tps68470_board_data dell_5285_tps68470_board_d= ata =3D { + .dev_name =3D "i2c-INT3472:05", + .tps68470_regulator_pdata =3D &dell_5285_tps68470_pdata, + .n_clk_consumers =3D ARRAY_SIZE(dell_5285_clk_consumers), + .clk_consumers =3D dell_5285_clk_consumers, + .n_gpiod_lookups =3D 2, + .tps68470_gpio_lookup_tables =3D { + &dell_5285_int3477_gpios, + &dell_5285_int3479_gpios, + }, +}; + static const struct dmi_system_id int3472_tps68470_board_data_table[] =3D { { .matches =3D { @@ -316,6 +472,13 @@ static const struct dmi_system_id int3472_tps68470_boa= rd_data_table[] =3D { }, .driver_data =3D (void *)&dell_7212_tps68470_board_data, }, + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5285"), + }, + .driver_data =3D (void *)&dell_5285_tps68470_board_data, + }, { } }; =20 --=20 2.51.0 From nobody Wed Jun 17 02:50:06 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D56F84414 for ; Tue, 21 Apr 2026 22:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811963; cv=none; b=cMjsg4B3L05VW3L5o6bBFg7X8azvkNVV8W6CzRvcX8SzYYRuXTfMLO6oDPzeHE5azYMghlwR4l2QkofZJ0aof1npS6J0Byg0KDnj/yros7KKmDOcAPm5Jc7JbO9rK6qwnjPF6SKZYar0q6hfTkfJyfKqwf0tdGjhX3dVb372mTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811963; c=relaxed/simple; bh=wde4TF8CgNzn8si/JL9P12OCZloroRuFEPIxq/TcvgI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nkfZG0WW3SZ4CJWwUKwE19zhdvErK/ihDGSTU1fJOO/hH2aoyrqQcquOFzl7wU2sWfy3ieUKZcZj+YPwkI4viZKiG37GSXv8TkG9m+WZaoXqHrAQ6a3LGbh77DWDN0Bq8bv5dkGer+QW5ffeU7OM0MEzQF041h/GwPxQXE6Gx2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SbUvLWtU; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SbUvLWtU" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2d832f2f44cso4488781eec.0 for ; Tue, 21 Apr 2026 15:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776811960; x=1777416760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TVHeDChmbK7H9JMCFb+9pqFytvxF0fdzrozCeGR4L7s=; b=SbUvLWtUSO2m58+nCCX+zpd8ndtOXOWe8ks3LaMcZBaghswgkAyp0JZj7s1rtqGhfK Adeo43KiLaG+Z+ca1VM1my23j3YY3Sjs00BZXI4+jSKGAfgwYCCCXY5uS0kRyYVrsbAR U/bEi/dp3I8+ic2+SHP8imXNwdOdFQwJEC2of1QHZc/E+CpspROEYnuoNApJVeFGToEW H5HhrpJrXnACswTJVS4RdJjlaPzg5oy70pNzDO0vLDwTQVveNrPxN2Lz9mYqpWPo87b3 NQtt2f/Et2qvrlTkAQ5BoveS/ENdn7l0TcdeAi75YnUFgG6LIGaDU3tyymyXd0ZzL1yT ePCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776811960; x=1777416760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TVHeDChmbK7H9JMCFb+9pqFytvxF0fdzrozCeGR4L7s=; b=LgHNBp3odq4bSiI4o98w5zE6XoczvBV9ADC7T3rWa16o8m+JS/DYCHxEQmOxAlxtPh iu+gxV6UTBk6LRZGvx3ODZ4B4+jjkYke/RZPIMpa9LF/oyw8sxHbHSKBcuDDR4UPnwsF Uyb30Hs5hE/YxW/ayPRO7RX0KFvWIu3fZwCINCzWwbXFUnC6+YWg4iTEl9jEDyfkDzj/ WXKI9QNvnpeCjjD3tUYuq3+BBnCr78gL3RNEhIj7H05WAehMzJjFXdYCndmnZYh6dl42 iAnRbKg80bGxobPS9j5U6LEKCAzfCcDp8QkG062vHwIH/Muwq+NGFqGKCSWneGUh/+3M 36Ww== X-Gm-Message-State: AOJu0Yzd9AfuwMQ2yOcdZP2BmPUexz2OCQS1BvRvmUUnJU8Mo6PSqVA8 M/TiEMU+LpKekWGk8dcXdZBFUDmLFOUVEnJIg9FGEz9kfEaM0l4SsmX3ATDrG/VqSK4= X-Gm-Gg: AeBDiesT4o1BnpR7hslq0hzKaSxcvOKhnyrJrdaweSXT8bdAWzylsB09H0Zw6d2gPmw ww3w5sz90BUc4ABqWzEZZmRFtyp9zSOYT/HRC+SAcIRe88ovjVKEDdBbNjbWdDb0r2R4Du5d8WN FK2MiQvXHDJ6Tmjuxi5Z8UFi5FjVMN0PqEKyKjlpH+DEPaQYAeIk3YlerU0cmnhyaKeyZ27F8Lb Y7qqdCiJoq1RjhK8Knda8gacYqPzI7v1B58MA1ItDovVuwQcHvoAVs5KOEwYC3hVjcfy71N6xxP phKgSwI0AFQX3JREeiHHjL68w2TJlDaZduKgJRL42Pdq9gTa1h21RukWjUjRuxKx2E9za0RZINM oMVfhkK3UCchmMppJ/DEwraAMOI5bB7kBYqsf6z6gbSCFFlharUeb9mX2qVJwyXDkJLU6qcqdbM jeo0gJ6KEN+ykrmPPPIzbz4U9Nj0bTRHTr X-Received: by 2002:a05:7301:1f17:b0:2ea:b975:3db1 with SMTP id 5a478bee46e88-2eab9753fd9mr749690eec.23.1776811959862; Tue, 21 Apr 2026 15:52:39 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53a4a8018sm26145884eec.8.2026.04.21.15.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 15:52:39 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v4 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Date: Tue, 21 Apr 2026 15:52:16 -0700 Message-ID: <20260421225217.12472-5-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260421225217.12472-1-tchatard@gmail.com> References: <20260421225217.12472-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Omnivision OV8858 is used as the rear camera in several Intel IPU3-based devices (e.g. Dell Latitude 5285 2-in-1). Its ACPI HID is INT3477. Add a sensor configuration entry with a link frequency of 360 MHz to allow ipu_bridge to create the firmware node for this sensor. Signed-off-by: Thierry Chatard --- drivers/media/pci/intel/ipu-bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel= /ipu-bridge.c index fc6608e33..f51749d0f 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -63,6 +63,8 @@ static const struct ipu_sensor_config ipu_supported_senso= rs[] =3D { IPU_SENSOR_CONFIG("INT33F0", 1, 384000000), /* Omnivision OV2740 */ IPU_SENSOR_CONFIG("INT3474", 1, 180000000), + /* Omnivision OV8858 */ + IPU_SENSOR_CONFIG("INT3477", 1, 360000000), /* Omnivision OV5670 */ IPU_SENSOR_CONFIG("INT3479", 1, 422400000), /* Omnivision OV8865 */ --=20 2.51.0 From nobody Wed Jun 17 02:50:06 2026 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ACC13A9631 for ; Tue, 21 Apr 2026 22:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811964; cv=none; b=WX+jsfr8mN1zdgxpI0vtrzqMwWg0+jyTdR0ceEieAO0QjGP6K3YFw32Z010CZ9bVPRKf4bmL7lnduxqpgQAW7oq3ogNoQL68+0rbUWm3gkoE6MOjuFAFMrIG/cFX1EiraBLFC3CxDNliO3dbV4uaEGQtYecDRQk1deZNXwi7mqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776811964; c=relaxed/simple; bh=vN7/TMO7cbX7Kb346f90McAkvXOdYr4HMCpOfdsC120=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XlnirXW5ytK6eCBtqOPql85K2vq8ffSRg9gn0YKtWhxzQ7l1ushY0/ruARQNrdSMIN7yBc+nPL2OuZAevk90vjC+C8aV1FVmainniMBthlX89F1rsA/wmUg6H3TH9v+PjarK2f4yEwRK2TAJ8wkF6p+4JSXHyi5ojBmtwOd1cEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pSiVD4rp; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pSiVD4rp" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2d8ffdc31d0so459064eec.0 for ; Tue, 21 Apr 2026 15:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776811962; x=1777416762; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oyaL0qjo0P+Rjj/R8G2l6sBVGr71qFrjDMNkthRUPUw=; b=pSiVD4rpB6WShfIaJdNEOCfJBr3WHlCTpKEOMGFdUHgJ2uLV0yg2b4ula38xPOeiiI dqsIKIkdMyVeWA6uzSAMnMk1G7wXsXPgLs1TFNq48Cu8PnibUk3lVwsnF1/DasZHi6kK Bm0PpGgxM4Eap7gp1kbkc6Xdo+nnUSn7TmJOyI1ZDTqqUPRBHNQICHSzCo1ntcr8oaAU 8wlpoj/xGjyYC5Y7kpv7lbkurXjkTRS6Vjwi6UjF7Si4Pjq4TawCCtTm9fRu9j5XdPLj Ntl4P6eiK8qNXChL0BQyT9RFqEpzTTFaWYihvoPI9yJ7DK/6Wmq6aQ8kQ8Vk0nCEwyLp SO2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776811962; x=1777416762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oyaL0qjo0P+Rjj/R8G2l6sBVGr71qFrjDMNkthRUPUw=; b=dx+tUuqIENBYql1XwfILIXJ2zdGE55JfqqdF/a0FiDJFB+QVSGqPS968uGlIb32zpw ojuiTNs4EwUSLaAiKxqbdjTvtU2eO0jJnkW3/B+aOMkspFC44mYYOAlovN0QytprL2kX Io3DXMOH7e9yaxQJjVIaWyjZoyzm+V5VOgCBSl8hNxOFYkhxX7HUmVwnvb7M9UvZmLgf vRLJZHdtRRJFszWJcHYkVyPtGMVAD/WOECebeMJDCip0ma/sgjpnAthAq/0fFDD+rnb0 4HHJ80sc10UhiHztkyNsmzTaRYE31Is5pw86DpCcFIb5eURyw/FjzL0g2ZyVDtYoamo3 7WGg== X-Gm-Message-State: AOJu0Yz2N/pxpt8/p+RlFG4y06MUWGoFaxmwgLPQem9io8vF9v/KbWUn Le2KwvdGJ+aENGVuFcTN6cDQvLyQDbRIF0bC5bPlAXMBgvTY12T4JAQ3qUZGGIJ5lHY= X-Gm-Gg: AeBDietRw0ZA/G6+c6ex0lp5s8dMBon9VJ+YiHlm8UQ7pgLbxt2RCKt8cqXVTqZvdAp FbKRW7O2Yl7Tu63SCxVricqhSN3IAiByvWpxqVJJNUQsrJwHX3uwkf5acwXlr+b0cgETtVgcSxw 62sUmA2A1LDgDm5yObROXrQmxc0UtxTT/tlIjIdKwOZ8XQxPJ50PzYAHQryrQPdPDINwuEscRrC ZyQDGX2To4UPHoyrxqbTFh+/UThVLC3XCw3qeY/swANUUj+YLDWlgTpUauLuusDHJeMMYNciliS 0qnosX1AKSY/BorvagFlqi0l7tRWazxe7JWhDiO3I1Gg7DAJ0eYIvqSGqbjIsQi+dYeX3/CNTI+ bOFamDZmNIRPUy/4CBV5wRXhdb8Aqukxf/BgYSqxj5/RawE+20lGPjrGnzk1jDWlbYk9DwpzDwv fkpbyc0UFwohbH7xJ/htWFWgCtMyLeg7SJpJJ/LOHL6x4= X-Received: by 2002:a05:7301:1295:b0:2d2:ff9e:c07d with SMTP id 5a478bee46e88-2e478e162dcmr11101548eec.24.1776811962042; Tue, 21 Apr 2026 15:52:42 -0700 (PDT) Received: from TC-LAPTOP.lan ([209.76.64.37]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53a4a8018sm26145884eec.8.2026.04.21.15.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 15:52:41 -0700 (PDT) From: Thierry Chatard To: linux-kernel@vger.kernel.org Cc: hansg@kernel.org, lee@kernel.org, platform-driver-x86@vger.kernel.org, ilpo.jarvinen@linux.intel.com, djrscally@gmail.com, linux-media@vger.kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, Thierry Chatard Subject: [PATCH v4 5/5] media: ov8858: add ACPI device ID INT3477 Date: Tue, 21 Apr 2026 15:52:17 -0700 Message-ID: <20260421225217.12472-6-tchatard@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260421225217.12472-1-tchatard@gmail.com> References: <20260421225217.12472-1-tchatard@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Omnivision OV8858 appears in ACPI firmware under the HID INT3477 on Intel IPU3-based platforms such as the Dell Latitude 5285 2-in-1. Add INT3477 to the ACPI match table so the driver binds when instantiated by ipu_bridge. The supply names array already covers the regulators needed on this platform: the TPS68470 board data maps VSIO to the "dovdd" supply of INT3477, so enabling dovdd via regulator_bulk_enable() also activates the S_I2C_CTL passthrough (reg 0x43) that gates I2C access to the sensor. No additional supply name is required in the driver. Signed-off-by: Thierry Chatard --- drivers/media/i2c/ov8858.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov8858.c b/drivers/media/i2c/ov8858.c index 3f45f7fab..a1fa0be52 100644 --- a/drivers/media/i2c/ov8858.c +++ b/drivers/media/i2c/ov8858.c @@ -79,8 +79,8 @@ =20 static const char * const ov8858_supply_names[] =3D { "avdd", /* Analog power */ - "dovdd", /* Digital I/O power */ "dvdd", /* Digital core power */ + "dovdd", /* Digital I/O power */ }; =20 struct regval { @@ -1981,11 +1981,18 @@ static const struct of_device_id ov8858_of_match[] = =3D { }; MODULE_DEVICE_TABLE(of, ov8858_of_match); =20 +static const struct acpi_device_id ov8858_acpi_ids[] =3D { + { "INT3477" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(acpi, ov8858_acpi_ids); + static struct i2c_driver ov8858_i2c_driver =3D { .driver =3D { .name =3D "ov8858", .pm =3D &ov8858_pm_ops, .of_match_table =3D ov8858_of_match, + .acpi_match_table =3D ov8858_acpi_ids, }, .probe =3D ov8858_probe, .remove =3D ov8858_remove, --=20 2.51.0