From nobody Wed Jun 17 02:57:21 2026 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E9C27FB05 for ; Tue, 21 Apr 2026 21:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776808121; cv=none; b=GWhXajfLY1Ta2+P9PZTBtm3lV7uVtvZVOGkblPRE8u5IvQPTSdyAFhWVsQr3iycznpal+skKbmtYoRIiytvuBdfN8kaXm2MTWLVsFTnUWo1pPY6YeWz49TgOguKbURbcA6rlUGGkfADCvT0RR+HoPtYiKnSV3MTNsH5/xrXYbuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776808121; c=relaxed/simple; bh=z+OTlEWZ2CY/jTUPoZT4vCXngQ+n9huGQHKnarhQRYY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QlZa6M2lPWlhKxEHVnSDkL+X48p2JwcGbwf7GmGBwEpglEuzmLgC8xgda9T7YrdandaEaVH0DthlYjqQa1nbvJeppxV85/+etPyDb4fGN26i/SxJl3X3rKnpy/TnX72moIG9SnsOXKWCvdo+BOkzy6/Y3h24+lDeDZKmye+hk5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d7f+BE/Y; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d7f+BE/Y" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-479f7e75a6bso360472b6e.2 for ; Tue, 21 Apr 2026 14:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776808119; x=1777412919; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MaoP4pyVSjCeA6bwsLDEugQYLQyHAyT99gzHjryd6F4=; b=d7f+BE/YHGaR6GJazc8CBKYtFByfAjCA1KjLOm3oOBzKa/V7jLWz3innFRDv+4DBy+ 42/JREp5xlLHorIOdEKq0ogFW7P1Ag1oroMLmDlLPrr8ClJ2YVGxfGngmwhLbPXEJpRv A4mzphjX4PFBwz4y2NV/0gEuC8eQUsa8Ngdvc6R4GiUi2l8DNaE8kmL6QgSxz9TzAK1W N1PRuew20HHF3ig4WSxoZC7eoLz4KxRfcfBKR6BLrrYZS26BtfYcnF/1IEQVJDHFSUy2 KAPCcp+aw9ZNs4yho3TZtRl6GoJLDxGikXF5OQP/9D6Miv50cPmdha1A0B8/iMzDvZtT a5fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776808119; x=1777412919; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MaoP4pyVSjCeA6bwsLDEugQYLQyHAyT99gzHjryd6F4=; b=NwyqAYUmKFUsKlKYQFZ89UvEmWlfSRFMZRUNFkBeckTKYb5VJx0ieLiBwsoKKATKIn brSaexkZG1QCvTfnGYukBaYV+2W/vG4v8qQ3Lw0cMPk7BYqH6EvFjPpS/cxcPjyYPgP5 wYRdvu4OiTcBuYSKvQQFVZlgxGizFfl2eRuDyOFL2Jfjr2R9V01aw0EfQX+6isGjbkJd n6sTdWr/D4tQpek1jI0hqRHZRhQ7Gt0K1hJszEusUSksIDZRyE2GBqlC1naCyQLkHGHc aWyvtv75N0xwr10PXc4Gc69kWAp6ywbiOr+9IDsMBH7RW2v+SijDjowcRUv/DB6i7y8B cGQA== X-Forwarded-Encrypted: i=1; AFNElJ9poMN9mfkmUhW6VA+Ey8vx9W69emSLf0uYuyRAmZcTWT711qejYBJqyecHm2e3MEEyMnAS/h7ndI5la9Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yy50CrJNsToOebj50xLJWC7E0SMO8qL7D5WluzawzLP9RoRo+hs s5/6XZTbCZKHewPJCYX7zhQBbJF6SHsdIi4XAxXjPXTfWxghTz+/iNJn X-Gm-Gg: AeBDiesV7IUBPIu+r3HmnCyw4yoWAcOlfP7xP+P8P1ja0EyrZ8tm1BXpQHYYNOvqU3l 7MMKc2NU2acQJ5TmK4HF+5ayL3MFRmh7mn4pCl6Yxfc4E4OSFUgikc5ncDwjEJYMASQ2S/IrV2o lhz+rzUgd1xTs86Ht2+7LwsH1LgtVPF7quxha2FeRtHbR8ImC/C4lMppcUZzlnwx53DyGGxLC0d yy43nGiu/VrjYzUqqstLPuEE8F+E3MK0lWl12o/xEzrFYm8Kw0Ok8alYfRNoBISFvg30g+DCaxM Ymcnd7mTPkgiVuHXlEUCZ62uZB20jgdxByDANCcQaLfrejMGWYv5QGCkl2URTvITXP7A7NTLviF qmf6WG5EBTrJf94pCiuz+X+IoFgHmfZ7rW04Z7V1AeU8GaMYXPtd1I9Q9vBbgFGj1+m2pd1Fyve YFWtSoW37RU3XL1pxX4q3mHTM/zLm5zRbIbrhdCQbIcnElTuKXhdamTR+A3UHeWaQ38RWE X-Received: by 2002:a05:6808:bc6:b0:45f:8be:d983 with SMTP id 5614622812f47-4799c8ca7c3mr11827919b6e.12.1776808119084; Tue, 21 Apr 2026 14:48:39 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-479a02097b6sm9839476b6e.14.2026.04.21.14.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 14:48:38 -0700 (PDT) From: Maxwell Doose To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] i3c: master: Replace sprintf() with sysfs_emit() family Date: Tue, 21 Apr 2026 16:48:37 -0500 Message-ID: <20260421214837.20939-1-m32285159@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() function calls with sysfs_emit() and sysfs_emit_at() function calls where appropriate. This will help harden the driver and help modernize it. While at it, add missing newlines at the end of some sysfs_emit() (formerly sprintf()) calls. Signed-off-by: Maxwell Doose Reviewed-by: Frank Li --- v2: - Change commit message to use imperative voice as suggested by Frank Li. drivers/i3c/master.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 9e6be49bebb2..c0d19eae06b9 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -174,7 +174,7 @@ static ssize_t bcr_show(struct device *dev, =20 i3c_bus_normaluse_lock(bus); desc =3D dev_to_i3cdesc(dev); - ret =3D sprintf(buf, "0x%02x\n", desc->info.bcr); + ret =3D sysfs_emit(buf, "0x%02x\n", desc->info.bcr); i3c_bus_normaluse_unlock(bus); =20 return ret; @@ -191,7 +191,7 @@ static ssize_t dcr_show(struct device *dev, =20 i3c_bus_normaluse_lock(bus); desc =3D dev_to_i3cdesc(dev); - ret =3D sprintf(buf, "0x%02x\n", desc->info.dcr); + ret =3D sysfs_emit(buf, "0x%02x\n", desc->info.dcr); i3c_bus_normaluse_unlock(bus); =20 return ret; @@ -208,7 +208,7 @@ static ssize_t pid_show(struct device *dev, =20 i3c_bus_normaluse_lock(bus); desc =3D dev_to_i3cdesc(dev); - ret =3D sprintf(buf, "%llx\n", desc->info.pid); + ret =3D sysfs_emit(buf, "%llx\n", desc->info.pid); i3c_bus_normaluse_unlock(bus); =20 return ret; @@ -225,7 +225,7 @@ static ssize_t dynamic_address_show(struct device *dev, =20 i3c_bus_normaluse_lock(bus); desc =3D dev_to_i3cdesc(dev); - ret =3D sprintf(buf, "%02x\n", desc->info.dyn_addr); + ret =3D sysfs_emit(buf, "%02x\n", desc->info.dyn_addr); i3c_bus_normaluse_unlock(bus); =20 return ret; @@ -256,7 +256,7 @@ static ssize_t hdrcap_show(struct device *dev, if (!hdrcap_strings[mode]) continue; =20 - ret =3D sprintf(buf + offset, offset ? " %s" : "%s", + ret =3D sysfs_emit_at(buf, offset, offset ? " %s" : "%s", hdrcap_strings[mode]); if (ret < 0) goto out; @@ -264,7 +264,7 @@ static ssize_t hdrcap_show(struct device *dev, offset +=3D ret; } =20 - ret =3D sprintf(buf + offset, "\n"); + ret =3D sysfs_emit_at(buf, offset, "\n"); if (ret < 0) goto out; =20 @@ -290,10 +290,10 @@ static ssize_t modalias_show(struct device *dev, ext =3D I3C_PID_EXTRA_INFO(devinfo.pid); =20 if (I3C_PID_RND_LOWER_32BITS(devinfo.pid)) - return sprintf(buf, "i3c:dcr%02Xmanuf%04X", devinfo.dcr, + return sysfs_emit(buf, "i3c:dcr%02Xmanuf%04X\n", devinfo.dcr, manuf); =20 - return sprintf(buf, "i3c:dcr%02Xmanuf%04Xpart%04Xext%04X", + return sysfs_emit(buf, "i3c:dcr%02Xmanuf%04Xpart%04Xext%04X\n", devinfo.dcr, manuf, part, ext); } static DEVICE_ATTR_RO(modalias); @@ -578,9 +578,9 @@ static ssize_t mode_show(struct device *dev, if (i3cbus->mode < 0 || i3cbus->mode >=3D ARRAY_SIZE(i3c_bus_mode_strings) || !i3c_bus_mode_strings[i3cbus->mode]) - ret =3D sprintf(buf, "unknown\n"); + ret =3D sysfs_emit(buf, "unknown\n"); else - ret =3D sprintf(buf, "%s\n", i3c_bus_mode_strings[i3cbus->mode]); + ret =3D sysfs_emit(buf, "%s\n", i3c_bus_mode_strings[i3cbus->mode]); i3c_bus_normaluse_unlock(i3cbus); =20 return ret; @@ -595,7 +595,7 @@ static ssize_t current_master_show(struct device *dev, ssize_t ret; =20 i3c_bus_normaluse_lock(i3cbus); - ret =3D sprintf(buf, "%d-%llx\n", i3cbus->id, + ret =3D sysfs_emit(buf, "%d-%llx\n", i3cbus->id, i3cbus->cur_master->info.pid); i3c_bus_normaluse_unlock(i3cbus); =20 @@ -611,7 +611,7 @@ static ssize_t i3c_scl_frequency_show(struct device *de= v, ssize_t ret; =20 i3c_bus_normaluse_lock(i3cbus); - ret =3D sprintf(buf, "%ld\n", i3cbus->scl_rate.i3c); + ret =3D sysfs_emit(buf, "%ld\n", i3cbus->scl_rate.i3c); i3c_bus_normaluse_unlock(i3cbus); =20 return ret; @@ -626,7 +626,7 @@ static ssize_t i2c_scl_frequency_show(struct device *de= v, ssize_t ret; =20 i3c_bus_normaluse_lock(i3cbus); - ret =3D sprintf(buf, "%ld\n", i3cbus->scl_rate.i2c); + ret =3D sysfs_emit(buf, "%ld\n", i3cbus->scl_rate.i2c); i3c_bus_normaluse_unlock(i3cbus); =20 return ret; --=20 2.53.0