From nobody Wed Jun 17 01:52:05 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 084613D810D for ; Tue, 21 Apr 2026 13:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779397; cv=none; b=Yh+N9rYKAWobwlxeFEWwrBU3SHtPIOJWKxI9PIwLUnOOerVfJs2KvypnNSwY1Xt9a6qg/7nKXG8y5GsOpljLZsSuJZlQzNVGTmXlJjbvt+H6zx1McGseqCECWBSZNNPh9RXmkAuyhnGr1PzXIAowF02lBPEUUDAyfgnUTG81Rx4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779397; c=relaxed/simple; bh=kKZ2eoQ5zExPxPUVDm9+Bjv946REbBveK4BG4RekTwk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T1CqWmdtiyAWhF5YAH92vEMjrBV8zQyfJAJLfpkvaL+teYV6Se3xA0vJ9xsveAE3d7uLY0ZV9m34LIkCt6n9tj2ORYqhmgsCsUNTD3QIVWYFOnIEXW86pQElDbE+DNA5RO6GRHmygEoi/WyAEeq1EHogzkjxBO3MRKDneXP3RQg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=El27gZ9O; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="El27gZ9O" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-43d64313c39so3367094f8f.3 for ; Tue, 21 Apr 2026 06:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776779394; x=1777384194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2zHXMr6dY7lbD0aEaxS9wFDwdUTKjF7ef2KbAfXUkPE=; b=El27gZ9OlwnaitqqZOs+yfShEU0YqlH+Nq72sniySrJjn1Nmp02Nryq6+8KeqPppVF tyDv2KXc0J0quwxpy+hQsXU+e86UoQQk9CoCCs64+6a2SGBd+kTfL3DQzX/q7qjHHCrB jyjRLvTyAdmVqk0uRpkFcyG/STmNhHbgjMp+aHTFN8knuiiH7HL7eDKke2sv3XHTLU/z uy/hMsYFbkf88ost5mr79tGklRf8h103xAyDLe/QEQMPFi3sumN3eXj4uhP4B5LxDtLr Xh25+Xqs8VPoYLfEEaRh8XH3TNyl/WsW7i0/57eqD1qay7ouS8PQ+farRHEwj3R9XGYs /gjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776779394; x=1777384194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2zHXMr6dY7lbD0aEaxS9wFDwdUTKjF7ef2KbAfXUkPE=; b=fQoLHZ5Fr9rdn3m9wLd5fE4FBMZBeQpxdaCGBYnHnlSj7qdBJ4YQY66J6YL2J/FZgZ DlbCpmegrwE0id4BqxiTFOc1q0hpnoY45ah+FusITClWgvPml7ujGH8J/vO2XBlnDCdM I3+af0fzcQPkVk8TnCs1zMMTj9FdKD0rHFMXKo0K+lKIxNRiqpsTD2A6Spjg2GZvvEBL fA0qn9PhRHqAMZlETUZ6OsNxG20ECk+ObjmGr5p9IW62/sUxCnxxn+ZcK5HUejExDBS6 3E95bstDaBYriPcMcaqXUuDEx/YL1bGvoI+aV4hHYKc/NIoBz8Sxf0NjM+IK2XoTl7GM mZcg== X-Forwarded-Encrypted: i=1; AFNElJ8Q6lvfOdXOesNDkPwg5BGnPRLlCLPRmhRGY8nbT5CRQkDp1UDkKHWYUnpKD8aZjTz4wH+XG7RpPFYRh3U=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl7rm5nBaSN3CyAPCEOtS5/emQIFOtCOTuqRHCpNwpEYQYW2xU 0rgChBDu0Jt943hLZuQ5Mgr8dpzjVpJklvQZe6kGexeXek3bdT6mOc+jYIwW X-Gm-Gg: AeBDievU1ihwEv6bnv6R0fSGhabDE8gLnwVWS/NLVg9MMXdCdia9EaQ75JQRDeK5HAs MKPSQR3gOF1DnG0BIWaCArR0pQ50x2My4Uft3KzJmUmLY9PWVFT91NKflRahdDHWFtx9UAoHjzU SUlqmMP1oY/43sOzRVV6okoEKabJWCxxF4D01ubRkDfcZTpxnAMQuDE3306f9+iQPw/chPG30Vy fFUnvzRWazD3TmmGDEeUtZ6H0WhdPPT5FRNnJeD/r9ISf/F8nPuTjjm7pC+uvdJRd60W9R85mxr B0pNDr7UFcu0CkmDXfWtZJqCMhkFCxIlaU4E60YGadNbHftKkAX41vtaFUz/RFGdZUafjgadoYC M7gAcaZLHF2OpWJEhyKN1UBUsnX5KYBkw2DbgBcE1nEYz51FBdmWPixEjQVYktWs/nxFjHUHVXx 9pvtE= X-Received: by 2002:a05:6000:250e:b0:43d:7ef:552f with SMTP id ffacd0b85a97d-43fe3dfbd9fmr29529388f8f.25.1776779394294; Tue, 21 Apr 2026 06:49:54 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb13a0sm37671480f8f.8.2026.04.21.06.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:49:53 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani Subject: [PATCH v3 1/3] wifi: wl18xx: fix OOB read from firmware rx_ba_link_id in BA event handler Date: Tue, 21 Apr 2026 13:49:49 +0000 Message-ID: <20260421134952.338301-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260421134952.338301-1-tristmd@gmail.com> References: <20260421134952.338301-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani The firmware-controlled rx_ba_link_id (u8) is used to index the 16-entry wl->links[] array without bounds checking in the BA window size change event handler. An out-of-range value causes OOB reads and an immediate pointer dereference of the OOB wlvif field. Add bounds validation consistent with all other HLID consumers in the driver. Fixes: d4392269f7ce ("wlcore: Add RX_BA_WIN_SIZE_CHANGE_EVENT event") Signed-off-by: Tristan Madani --- Changes in v3: - Regenerated from wireless-next with proper git format-patch to produce valid index hashes (v2 had post-processed index lines). Changes in v2: - No code changes from v1. drivers/net/wireless/ti/wl18xx/event.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ti/wl18xx/event.c b/drivers/net/wireless/= ti/wl18xx/event.c index a9f090e15cbbe..fac12a8590355 100644 --- a/drivers/net/wireless/ti/wl18xx/event.c +++ b/drivers/net/wireless/ti/wl18xx/event.c @@ -212,6 +212,12 @@ int wl18xx_process_mailbox_events(struct wl1271 *wl) u8 win_size =3D mbox->rx_ba_win_size; const u8 *addr; =20 + if (link_id >=3D WLCORE_MAX_LINKS) { + wl1271_error("BA event: invalid link_id %u\n", + link_id); + goto out; + } + wlvif =3D wl->links[link_id].wlvif; vif =3D wl12xx_wlvif_to_vif(wlvif); =20 --=20 2.47.3 From nobody Wed Jun 17 01:52:05 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D57893D8119 for ; Tue, 21 Apr 2026 13:49:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779398; cv=none; b=ZM4qdvvl4GSdEb6TYDBYeSbwp3Z9GWkctVdFBJnDsEx6XPKOc+6uJbw3l9Z7GnYrHuAaUyJQL2X/nImnB6653EqX8z2FeNO3hakF2EvllCZhQTJRPv97z/Ywz/Eg0FIaAk/ZjIVV2Lzeq33qH4zRWACyM+0GWIcawHeBcXumVGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779398; c=relaxed/simple; bh=VQJmGeicKEsi6S1aknxYXPHkbMtvDEapOhVDhRsNyb8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B9PA/B8Ri6BiSDsId7bsNSyTwZ4t+x+0cD6yJAV9CNxOLH52l12Ia0wEQ3aXuZn18Q916ApCLnAtNpQHXVnUnVz0WX/D1PMZaTPTmc2O5yCX19FV5oLshEF+rJRgI/i8SBA77vJ+ud/c2COJ5q1xz/s6qHtgu9+QO65JbJRbQnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OUJtJdOs; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OUJtJdOs" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43d77f60944so3467748f8f.3 for ; Tue, 21 Apr 2026 06:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776779395; x=1777384195; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XW7SuI64R5lXg3EcFdNoYLk+o32d4vhook9t2qciYl4=; b=OUJtJdOsxaoIeEDmx92xeuRCER3C+Hd8QJwVrboQYm2MTT5riRyXks6IeCSBiJaRij 7U++RfRQVKsycwu4D5aMaZmJsuzUeYOuiHfBNiOZfkKo4UeHgrBLUgDpkyZKFKEXLrtm OFaG3n2/JSjjvS6MuwbpuNhN6mRMPBCJZHyiE9rD6TqHAt7EF+jdYJQ3cUr8Izu/9gQl nSNVz5PFRjT+etzcomgb78QyUh9GAXxfSbZQBS+jD+zNUDsdtzzoDFW5srPeUZCP5HaN 0P91A9RAFgdc2I+F7JYysdtiyD6Bd1u1slNkb7Azf/O6qP2gzELEo7nhaY+ua8dUTGTe IRuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776779395; x=1777384195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XW7SuI64R5lXg3EcFdNoYLk+o32d4vhook9t2qciYl4=; b=OX2ggdJ6Ghtrzee9WzbRqD4TXcE9WhdVbdX+bFNnqXhhgD3SJeE9tR9EexJ8n3qz6m JHpDYyqoz2tMdAcV7TcTKqssU+D3DMsIqVvrni/UY7b09NKrqtCpVuA6qf8Zy7d5GLVS NRoAF9v3oiZPMIKjEh+vRLfQDJQF0DCDxlBcemwsV2L9O6bkFNxTcrQLE13D/H+o4DC9 B2k1vkygEUn/FSI1dPrOojGYmWp5LUgjm/33dw4nM+Pe+PbaNyqMyvdgZ28P1jxjVqcz XqPBuHX4fjlmSf+2eSYq4J4dr8aVR4lTi4qnZ5R+6k/a4QRBPBDdFLTsxJUHLsp09zG9 e7CQ== X-Forwarded-Encrypted: i=1; AFNElJ/1oKjWv4cW7HEKUDojSbF0tR9M/2Yeimxzry0DSn4NSd3nsCrsvPyfn7svLAoP2OeOxfq8Ve3hKQB0cig=@vger.kernel.org X-Gm-Message-State: AOJu0YwgDW+ahVinmO3Ry9lDcaOHQblDzdCNWHiXU614HNnMcgxmM0ws gjSeq890AIegcT4w4xocyeh7+6OdxtIc3UalaEIyXEuO54zHjjEFQ9M= X-Gm-Gg: AeBDietzzUOze8BLv9oECUYGXASha0eb+sDDySxafmfU+JjNw+5s0JhifOflwZFfr2J UMwUBOuz1YVxIo5LhOfd1WwRh/q5wurUxfz09EGZQyFBr9a1CY4Y71siLqTASChicx4jRuMv/R4 ldEUv6R5wZsOTtyb9V7VTi95cuGwyx3D2kVnzXW94QZ9ebCdcyi5hWErjnMDwPyhlVokL2TN9xp 8rjVqid3f5RDWkKE17+ZC7avsBKs2sah3+/9NQDuCMOulo/AVP+QyX23q3N+wLqxuJgH5CwizN0 TvRnCPR9BiUno8J9nJQQgujLDqSurPO0ToKahvkRhJYQkA5GOApLOcrXJ6AvVYsy0nN10NZSoRv QibjXmap+Tq0TzjSWregtS5n1NB9zz/8IxNAqMFOdbImydmcY9qvoCcuXDQhqCVNz1L8vE+Q78a dbhV8= X-Received: by 2002:adf:f2c7:0:b0:43f:e44a:f276 with SMTP id ffacd0b85a97d-43fe44b01a5mr20217458f8f.3.1776779395152; Tue, 21 Apr 2026 06:49:55 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb13a0sm37671480f8f.8.2026.04.21.06.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:49:54 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani Subject: [PATCH v3 2/3] wifi: wlcore: fix OOB read from firmware max_buff_size in logger handler Date: Tue, 21 Apr 2026 13:49:50 +0000 Message-ID: <20260421134952.338301-3-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260421134952.338301-1-tristmd@gmail.com> References: <20260421134952.338301-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani The firmware-controlled max_buff_size field is used to compute buffer offsets in wlcore_event_fw_logger() without validation against the 4128-byte kernel allocation. An inflated value causes out-of-bounds reads from kernel heap, with the data written to the debugfs-accessible fwlog ring buffer. Cap max_buff_size at the allocation size minus the header offset. Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") Signed-off-by: Tristan Madani --- Changes in v3: - Regenerated from wireless-next with proper git format-patch to produce valid index hashes (v2 had post-processed index lines). Changes in v2: - No code changes from v1. drivers/net/wireless/ti/wlcore/event.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ti/wlcore/event.c b/drivers/net/wireless/= ti/wlcore/event.c index 6c3a8ea9613e9..26c74dfcaeeff 100644 --- a/drivers/net/wireless/ti/wlcore/event.c +++ b/drivers/net/wireless/ti/wlcore/event.c @@ -61,6 +61,13 @@ int wlcore_event_fw_logger(struct wl1271 *wl) if (actual_len =3D=3D 0) goto free_out; =20 + if (le32_to_cpu(fw_log.max_buff_size) > + WL18XX_LOGGER_SDIO_BUFF_MAX - WL18XX_LOGGER_BUFF_OFFSET) { + wl1271_error("fw logger: max_buff_size %u exceeds buffer\n", + le32_to_cpu(fw_log.max_buff_size)); + goto free_out; + } + /* Calculate the internal pointer to the fwlog structure */ addr_ptr =3D internal_fw_addrbase + addr; =20 --=20 2.47.3 From nobody Wed Jun 17 01:52:05 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B02873DB63E for ; Tue, 21 Apr 2026 13:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779399; cv=none; b=RuaphCaV94N0ar+CcJru20D7b07KrrVmnuHBagBrr5Csz5Jrii8KbdjfuOPlro51786i5/KCWd60qwV55hNmeP2rHiJ3JPtm/50P7piqqsZSuvh8JKgJY+7uLN5LDkJgNEOqkioju6PZJ6PisXg5zygS7V3MLhAlCF9TAywyaoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779399; c=relaxed/simple; bh=suTBYE1gP/R4ATTroFoL/2430iJXnOm52ISvcEoM5Ys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PFVj25vXxH+vJLCDDCvKsW+p5j9+prWiCZbiaXCjVa/Fb3h/4+F/S+w1s9oO1pQje/D4shdV7aPXSp9bci7hHpz1Og38Z59qHm5uWPe0fdcdGU18/hr1BLjwb3UNMZZbhbhKYh6igCAz/bWAwT3oy/DmioOxxkJ29ap78ZrxUbs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nVH/AngT; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nVH/AngT" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488ff90d6c7so33118355e9.2 for ; Tue, 21 Apr 2026 06:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776779396; x=1777384196; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AKGjiE71pcy1j0gjcQ9BLUrLYWLwxIOwPknCBw0OO9w=; b=nVH/AngTe1OASNbRMp0o1OkkDIpAIakHRONiCnkW4j518SdULB83geuAO0+xWjl3XJ Vvw0nXcM06jdsANDgqv3HrXYodgnRKWN5DN6sr1c8+NUdGUuRn3C45GYJusj9GPPvSvy JH0l9okLmj2Fyl/DGYTKFbIUmx/G2u18yRS9Igl/cas/5ML3hJmK8UeaqgdIzsqbkvpU TiOyG/yBLsBJACOgEft+7b3KFujrGUdqOwLJP50pQf9gVIGhCmnBXGGzby6NA9syhh5S Qc18RGKR2oQTjXSnbRmBUETQsynmXDUBYkZ/IQEUSvYmSgLKXWDTKTa9b24r118BIkt2 l5LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776779396; x=1777384196; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AKGjiE71pcy1j0gjcQ9BLUrLYWLwxIOwPknCBw0OO9w=; b=Kx0nC0Is9PMbj/wX3CtiCLtHpoY8KOC9XPSbIKI2AZLF8XRyF6TsvDsQAiJrHRqOeI +UqqId84Gpm7OS2wIPEBIlCxB8d5+juBueq8lYJCaUetMtoZJabQssU8Sr6PhKnZGiU3 AH14BpFYozdzF1b1eyQjxgVfgaFU5oC6pykccXOkD8L8HXLRpd16Ky/6SRch38V87w8z MgWKI2aZTYh0g0eA6AUVIkPKyRrhQgoJHHwSUgJgrJcWV0OCITBJG3jifSD2O3PeO4V1 AxIpcLuwAu+TY1E33Ew/yOrDQonLgw1F41dJFtgRJ9EyIuh84JkyM80GcZgWk+rflqie WX+g== X-Forwarded-Encrypted: i=1; AFNElJ+9cZ7E9epVeMzooinBR/wME6hjY4HPLyTFdMfYDBamh9O0x/lvSahvC9xtxWodjXbkwkxmeBhm+5GojK8=@vger.kernel.org X-Gm-Message-State: AOJu0YwDeJyqNluDiImjrGZedKDK+izOGdLP4hGnfQATFsdT1fyeisoc nTlvSzLFqOGZIXLpABEun4Coafi/slSa0p7RonhBKgVl2OL5484y2l4= X-Gm-Gg: AeBDietFqi4yvnFokDCDn9E3rP8rTirdgax5PH9btZTI/a1+Gops8L+peQ/DA0U+kon PvVNDW5ISY2QJwmULr1hhkAoR1vv9k6IvaOxeU4l6w70KpSvsVJNNayyBp1xVGL+LtPoM4Ua5Vi E6S3ou6T3RGaQHX3W+weVVdaZAyd+nYUYzhLIBA7W4o4sSsLH7TVbwL42EwRMXFusTWR7pkAJkH 1TnQ+PCdDiZe1LmKIEAHKp8BxwOUBGm2eZRpao2TWVbFG2/0l1iCZkymXFYltPUvs50bvMGfDnD ciK9UOsuSBlkpmV9HY6NIKpMn2GE8s5IEuPTq1IZ4qFurAtf4hrSSKGMaXwUeZEr0VYioYiEzOh pH2Qdaoyb+KCS51kmv7EbkCZIxPnCGx7mT6QvAufubLPxFFG40WR4m3jaP00kQRZ5X+lyyqqsR+ M8EjRyMiETl6pigw== X-Received: by 2002:a05:600c:3483:b0:488:af7f:775f with SMTP id 5b1f17b1804b1-488fb77d343mr244770145e9.18.1776779396003; Tue, 21 Apr 2026 06:49:56 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb13a0sm37671480f8f.8.2026.04.21.06.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:49:55 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani Subject: [PATCH v3 3/3] wifi: wl18xx: fix OOB read from firmware SSID/password lengths in smart config event Date: Tue, 21 Apr 2026 13:49:51 +0000 Message-ID: <20260421134952.338301-4-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260421134952.338301-1-tristmd@gmail.com> References: <20260421134952.338301-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristan Madani The firmware-controlled sc_ssid_len and sc_pwd_len values are used as nla_put sizes from fixed-size mailbox buffers (32 and 64 bytes) without bounds checking. Values exceeding the buffer sizes cause out-of-bounds reads delivered to userspace via nl80211 vendor events. Clamp the lengths to the mailbox buffer sizes before use. Fixes: e93e15fb47e5 ("wlcore/wl18xx: handle smart config events") Signed-off-by: Tristan Madani --- Changes in v3: - Regenerated from wireless-next with proper git format-patch to produce valid index hashes (v2 had post-processed index lines). Changes in v2: - No code changes from v1. drivers/net/wireless/ti/wl18xx/event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ti/wl18xx/event.c b/drivers/net/wireless/= ti/wl18xx/event.c index fac12a8590355..19c7f5bdada5e 100644 --- a/drivers/net/wireless/ti/wl18xx/event.c +++ b/drivers/net/wireless/ti/wl18xx/event.c @@ -82,6 +82,9 @@ static int wlcore_smart_config_decode_event(struct wl1271= *wl, { struct sk_buff *skb; =20 + ssid_len =3D min_t(u8, ssid_len, 32); + pwd_len =3D min_t(u8, pwd_len, 64); + wl1271_debug(DEBUG_EVENT, "SMART_CONFIG_DECODE_EVENT_ID"); wl1271_dump_ascii(DEBUG_EVENT, "SSID:", ssid, ssid_len); =20 --=20 2.47.3